Re: [PATCH vhost 08/23] vdpa/mlx5: Clear and reinitialize software VQ data on reset

2024-06-19 Thread Eugenio Perez Martin
On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea wrote: > > The hardware VQ configuration is mirrored by data in struct > mlx5_vdpa_virtqueue . Instead of clearing just a few fields at reset, > fully clear the struct and initialize with the appropriate default > values. > > As clear_vqs_ready() is

Re: [PATCH vhost 05/23] vdpa/mlx5: Iterate over active VQs during suspend/resume

2024-06-19 Thread Eugenio Perez Martin
On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea wrote: > > No need to iterate over max number of VQs. > > Signed-off-by: Dragos Tatulea > Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH vhost 06/23] vdpa/mlx5: Remove duplicate suspend code

2024-06-19 Thread Eugenio Perez Martin
On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea wrote: > > Use the dedicated suspend_vqs() function instead. > > Signed-off-by: Dragos Tatulea > Reviewed-by: Cosmin Ratiu Reviewed-by: Eugenio Pérez > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +-- > 1 file changed, 1 insertion(+), 6

Re: [PATCH vhost 04/23] vdpa/mlx5: Drop redundant check in teardown_virtqueues()

2024-06-19 Thread Eugenio Perez Martin
On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea wrote: > > The check is done inside teardown_vq(). > > Signed-off-by: Dragos Tatulea > Reviewed-by: Cosmin Ratiu Reviewed-by: Eugenio Pérez > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 ++ > 1 file changed, 2 insertions(+), 8

Re: [PATCH vhost 03/23] vdpa/mlx5: Drop redundant code

2024-06-19 Thread Eugenio Perez Martin
On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea wrote: Patch message suggestion: Originally, the second loop initialized the CVQ. But (acde3929492b ("vdpa/mlx5: Use consistent RQT size") initialized all the queues in the first loop, so the second iteration in ... > > The second iteration in

Re: Bug in Kernel 6.8.x, 6.9.x Causing Trace/Panic During Shutdown/Reboot

2024-06-19 Thread Ilkka Naulapää
disabled CONFIG_FORCE_NR_CPUS option for 6.9.5 but the trace + panic still exists. So that one didn't help. I've also been bisecting the trace but have not finished it yet as the last half dozen builds produced non-bootable kernels. Anyway, I will continue it soon(ish) when I have a bit more free

Re: [PATCH vhost 02/23] vdpa/mlx5: Make setup/teardown_vq_resources() symmetrical

2024-06-19 Thread Eugenio Perez Martin
On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea wrote: > > ... by changing the setup_vq_resources() parameter. s/parameter/parameter type/ ? Either way, Acked-by: Eugenio Pérez > > Signed-off-by: Dragos Tatulea > Reviewed-by: Cosmin Ratiu > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 10

Re: [PATCH vhost 01/23] vdpa/mlx5: Clarify meaning thorough function rename

2024-06-19 Thread Eugenio Perez Martin
On Mon, Jun 17, 2024 at 5:08 PM Dragos Tatulea wrote: > > setup_driver()/teardown_driver() are a bit vague. These functions are > used for virtqueue resources. > > Same for alloc_resources()/teardown_resources(): they represent fixed > resources that are meant to exist during the device lifetime.

[PATCH v2] module: Add log information for loading module failures

2024-06-19 Thread Yusong Gao
Add log information in kernel-space when loading module failures. Try to load the unsigned module and the module with bad signature when set 1 to /sys/module/module/parameters/sig_enforce. Unsigned module case: (linux) insmod unsigned.ko [ 18.714661] Loading of unsigned module is rejected

Re: [PATCH v6 0/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-19 Thread Mike Rapoport
On Tue, Jun 18, 2024 at 12:21:19PM +0200, Ard Biesheuvel wrote: > On Mon, 17 Jun 2024 at 23:01, Alexander Graf wrote: > > So I would personally prefer for this code not to go in at all. But if > it does go in (and Steven has already agreed to this), it needs a > giant disclaimer that it is best

Re: [PATCH v2] net: missing check virtio

2024-06-19 Thread Michael S. Tsirkin
On Thu, Jun 13, 2024 at 12:54:48PM +0300, Denis Arefev wrote: > Two missing check in virtio_net_hdr_to_skb() allowed syzbot > to crash kernels again > > 1. After the skb_segment function the buffer may become non-linear > (nr_frags != 0), but since the SKBTX_SHARED_FRAG flag is not set anywhere >

Re: [PATCH] module: Add log information for loading module failures

2024-06-19 Thread Yusong Gao
On 6/19/24 02:54, Luis Chamberlain wrote: On Fri, Jun 14, 2024 at 09:25:19AM +, Yusong Gao wrote: Add log information in kernel-space when loading module failures. Try to load the unsigned module and the module with bad signature when set 1 to /sys/module/module/parameters/sig_enforce.

Re: [PATCH v6 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-19 Thread Mike Rapoport
On Tue, Jun 18, 2024 at 12:06:27PM -0400, Steven Rostedt wrote: > On Tue, 18 Jun 2024 20:55:17 +0800 > Zhengyejian wrote: > > > > + start = memblock_phys_alloc(size, align); > > > + if (!start) > > > + return -ENOMEM; > > > + > > > + reserved_mem_add(start, size, name); > > > + > > > +

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Andy Chiu
On Tue, Jun 18, 2024 at 9:40 PM Alexandre Ghiti wrote: > > Hi Andy, > > On Tue, Jun 18, 2024 at 2:48 PM Andy Chiu wrote: > > > > On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: > > > > > > Hi Conor, > > > > > > On 17/06/2024 15:23, Alexandre Ghiti wrote: > > > > Hi Conor, > > > > > > > >

Re: [PATCH v15 05/14] x86/sgx: Implement basic EPC misc cgroup functionality

2024-06-18 Thread Huang, Kai
On Tue, 2024-06-18 at 18:23 -0500, Haitao Huang wrote: > On Tue, 18 Jun 2024 18:15:37 -0500, Huang, Kai wrote: > > > On Tue, 2024-06-18 at 07:56 -0500, Haitao Huang wrote: > > > On Tue, 18 Jun 2024 06:31:09 -0500, Huang, Kai > > > wrote: > > > > > > > > > > > > @@ -921,7 +956,8 @@ static

Re: [PATCH v2] net: missing check virtio

2024-06-18 Thread Jakub Kicinski
On Fri, 14 Jun 2024 13:18:26 +0300 Denis Arefev wrote: > Yeah, I was thinking of adding Fixes: > > But this code is new, it complements what is done. > 1. check (!(ret && (hdr->gso_size > needed) && >((remainder > needed) || (remainder == 0 > complements comit 0f6925b3e8da0

Re: [PATCH V1] rpmsg: glink: Make glink smem interrupt wakeup capable

2024-06-18 Thread Bjorn Andersson
On Thu, Jun 13, 2024 at 04:05:17PM +0530, Deepak Kumar Singh wrote: > > > On 6/3/2024 3:07 PM, Caleb Connolly wrote: > > Hi Deepak, > > > > On 03/06/2024 09:36, Deepak Kumar Singh wrote: > > > There are certain usecases which require glink interrupt to be > > > wakeup capable. For example if

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Luis Chamberlain
On Tue, Jun 18, 2024 at 02:19:47PM -0700, Sami Tolvanen wrote: > Hi Luis, > > On Tue, Jun 18, 2024 at 12:42:51PM -0700, Luis Chamberlain wrote: > > a) Ensure correctness for all users / tools, so that proper plumbing is > >really done. By considering all symbols you increase your scope of > >

Re: [PATCH v15 05/14] x86/sgx: Implement basic EPC misc cgroup functionality

2024-06-18 Thread Haitao Huang
On Tue, 18 Jun 2024 18:15:37 -0500, Huang, Kai wrote: On Tue, 2024-06-18 at 07:56 -0500, Haitao Huang wrote: On Tue, 18 Jun 2024 06:31:09 -0500, Huang, Kai wrote: > > > @@ -921,7 +956,8 @@ static int __init sgx_init(void) > > if (!sgx_page_cache_init()) > > return

Re: [PATCH v15 05/14] x86/sgx: Implement basic EPC misc cgroup functionality

2024-06-18 Thread Huang, Kai
On Tue, 2024-06-18 at 07:56 -0500, Haitao Huang wrote: > On Tue, 18 Jun 2024 06:31:09 -0500, Huang, Kai wrote: > > > > > > @@ -921,7 +956,8 @@ static int __init sgx_init(void) > > > if (!sgx_page_cache_init()) > > > return -ENOMEM; > > > > > > - if (!sgx_page_reclaimer_init()) { >

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Sami Tolvanen
Hi Luis, On Tue, Jun 18, 2024 at 12:42:51PM -0700, Luis Chamberlain wrote: > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > The first 12 patches of this series add a small tool for computing > > symbol versions from DWARF, called gendwarfksyms. When passed a list > > of

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Sami Tolvanen
On Wed, Jun 19, 2024 at 04:03:45AM +0900, Masahiro Yamada wrote: > On Wed, Jun 19, 2024 at 2:18 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Jun 19, 2024 at 01:50:36AM +0900, Masahiro Yamada wrote: > > > On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > That's

Re: [PATCH 13/15] modpost: Add support for hashing long symbol names

2024-06-18 Thread Sami Tolvanen
On Wed, Jun 19, 2024 at 01:47:13AM +0900, Masahiro Yamada wrote: > On Tue, Jun 18, 2024 at 2:58 AM Sami Tolvanen wrote: > > > > +#define barrier_data(ptr) __asm__ __volatile__("": :"r"(ptr) :"memory") > > > > > I know this is a copy-paste of the kernel space code, > but is barrier_data() also

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Sami Tolvanen
Hi Masahiro, On Wed, Jun 19, 2024 at 01:28:21AM +0900, Masahiro Yamada wrote: > I am surprised at someone who attempts to add another variant of genksyms. The options are rather limited if we want Rust modules that are compatible with modversions. We either come up with a way to version Rust

Re: [PATCH 6.10.0-rc2] kernel/module: avoid panic on loading broken module

2024-06-18 Thread Luis Chamberlain
On Thu, Jun 06, 2024 at 03:31:49PM +0200, Daniel v. Kirschten wrote: > If a module is being loaded, and the .gnu.linkonce.this_module section > in the module's ELF file does not have the WRITE flag, the kernel will > map the finished module struct of that module as read-only. > This causes a

Re: [PATCH] filemap: add trace events for get_pages, map_pages, and fault

2024-06-18 Thread Steven Rostedt
On Tue, 18 Jun 2024 09:36:56 + Takaya Saeki wrote: > To allow precise tracking of page caches accessed, add new tracepoints > that trigger when a process actually accesses them. > > The ureadahead program used by ChromeOS traces the disk access of > programs as they start up at boot up. It

Re: [PATCH v3] module: create weak dependecies

2024-06-18 Thread Luis Chamberlain
On Tue, May 14, 2024 at 09:25:55AM -0500, Lucas De Marchi wrote: > On Fri, May 10, 2024 at 10:57:22AM GMT, Jose Ignacio Tornos Martinez wrote: > > It has been seen that for some network mac drivers (i.e. lan78xx) the > > related module for the phy is loaded dynamically depending on the current > >

[PATCH] uprobe: Do not use UPROBE_SWBP_INSN as static initializer

2024-06-18 Thread Jiri Olsa
Nathan reported compilation fail for loongarch arch: kernel/events/uprobes.c: In function 'arch_uprobe_trampoline': arch/loongarch/include/asm/uprobes.h:12:33: error: initializer element is not constant 12 | #define UPROBE_SWBP_INSNlarch_insn_gen_break(BRK_UPROBE_BP) |

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Luis Chamberlain
On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. >

Re: [PATCH] bpf/selftests: Fix __NR_uretprobe in uprobe_syscall test

2024-06-18 Thread Jiri Olsa
On Sun, Jun 16, 2024 at 09:51:18PM +0200, Jiri Olsa wrote: > On Sun, Jun 16, 2024 at 01:19:11AM +0900, Masami Hiramatsu wrote: > > On Sun, 16 Jun 2024 00:19:20 +0900 > > Masami Hiramatsu (Google) wrote: > > > > > On Fri, 14 Jun 2024 12:15:09 +0200 > > > Jiri Olsa wrote: > > > > > > > Fixing

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Masahiro Yamada
On Wed, Jun 19, 2024 at 2:18 AM Greg Kroah-Hartman wrote: > > On Wed, Jun 19, 2024 at 01:50:36AM +0900, Masahiro Yamada wrote: > > On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > > > Hi folks, > > > > >

Re: [PATCH v4 2/3] kbuild, kconfig: generate offset range data for builtin modules

2024-06-18 Thread Luis Chamberlain
On Fri, Jun 14, 2024 at 01:14:27PM -0400, Kris Van Hees wrote: > The offset range data for builtin modules is generated using: > - modules.builtin: associates object files with module names > - vmlinux.map: provides load order of sections and offset of first member > per section > -

Re: [PATCH] module: Add log information for loading module failures

2024-06-18 Thread Luis Chamberlain
On Fri, Jun 14, 2024 at 09:25:19AM +, Yusong Gao wrote: > Add log information in kernel-space when loading module failures. > Try to load the unsigned module and the module with bad signature > when set 1 to /sys/module/module/parameters/sig_enforce. > > Unsigned module case: > (linux) insmod

Re: [PATCH v5] remoteproc: xlnx: add attach detach support

2024-06-18 Thread Tanmay Shah
On 6/18/24 11:55 AM, Mathieu Poirier wrote: > On Tue, Jun 18, 2024 at 11:45:28AM -0500, Tanmay Shah wrote: >> >> >> On 6/17/24 10:40 AM, Mathieu Poirier wrote: >> > Good day, >> > >> > On Mon, Jun 10, 2024 at 08:42:27AM -0700, Tanmay Shah wrote: >> >> It is possible that remote processor is

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Greg Kroah-Hartman
On Wed, Jun 19, 2024 at 01:50:36AM +0900, Masahiro Yamada wrote: > On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > > Hi folks, > > > > > > This series implements CONFIG_MODVERSIONS for Rust, an important > > >

Re: [PATCH v10 2/8] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-06-18 Thread Andrew Davis
On 6/18/24 12:05 PM, Mathieu Poirier wrote: Good morning, On Mon, Jun 10, 2024 at 01:06:09PM -0500, Andrew Davis wrote: From: Martyn Welch The AM62x and AM64x SoCs of the TI K3 family has a Cortex M4F core in the MCU domain. This core is typically used for safety applications in a stand

Re: [PATCH v10 2/8] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-06-18 Thread Mathieu Poirier
Good morning, On Mon, Jun 10, 2024 at 01:06:09PM -0500, Andrew Davis wrote: > From: Martyn Welch > > The AM62x and AM64x SoCs of the TI K3 family has a Cortex M4F core in > the MCU domain. This core is typically used for safety applications in a > stand alone mode. However, some application

Re: [PATCH v5] remoteproc: xlnx: add attach detach support

2024-06-18 Thread Mathieu Poirier
On Tue, Jun 18, 2024 at 11:45:28AM -0500, Tanmay Shah wrote: > > > On 6/17/24 10:40 AM, Mathieu Poirier wrote: > > Good day, > > > > On Mon, Jun 10, 2024 at 08:42:27AM -0700, Tanmay Shah wrote: > >> It is possible that remote processor is already running before > >> linux boot or remoteproc

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Masahiro Yamada
On Wed, Jun 19, 2024 at 1:44 AM Greg Kroah-Hartman wrote: > > On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > > Hi folks, > > > > This series implements CONFIG_MODVERSIONS for Rust, an important > > feature for distributions like Android that want to ship Rust > > kernel modules,

Re: [PATCH 13/15] modpost: Add support for hashing long symbol names

2024-06-18 Thread Masahiro Yamada
On Tue, Jun 18, 2024 at 2:58 AM Sami Tolvanen wrote: > > Rust frequently has symbol names longer than MODULE_NAME_LEN, because > the full namespace path is encoded into the mangled name. Instead of > modpost failing when running into a long name with CONFIG_MODVERSIONS, > store a hash of the name

Re: [PATCH v5] remoteproc: xlnx: add attach detach support

2024-06-18 Thread Tanmay Shah
On 6/17/24 10:40 AM, Mathieu Poirier wrote: > Good day, > > On Mon, Jun 10, 2024 at 08:42:27AM -0700, Tanmay Shah wrote: >> It is possible that remote processor is already running before >> linux boot or remoteproc platform driver probe. Implement required >> remoteproc framework ops to

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Greg Kroah-Hartman
On Mon, Jun 17, 2024 at 05:58:19PM +, Sami Tolvanen wrote: > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. >

Re: [PATCH 00/15] Implement MODVERSIONS for Rust

2024-06-18 Thread Masahiro Yamada
On Tue, Jun 18, 2024 at 2:58 AM Sami Tolvanen wrote: > > Hi folks, > > This series implements CONFIG_MODVERSIONS for Rust, an important > feature for distributions like Android that want to ship Rust > kernel modules, and depend on modversions to help ensure module ABI > compatibility. > > There

Re: [PATCH v6 0/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Steven Rostedt
On Tue, 18 Jun 2024 13:47:49 +0200 Alexander Graf wrote: > IMHO the big fat disclaimer should be in the argument name. > "reserve_mem" to me sounds like it actually guarantees a reservation - > which it doesn't. Can we name it more along the lines of "debug" (to > indicate it's not for

Re: [PATCH v6 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Steven Rostedt
On Tue, 18 Jun 2024 20:55:17 +0800 Zhengyejian wrote: > > + start = memblock_phys_alloc(size, align); > > + if (!start) > > + return -ENOMEM; > > + > > + reserved_mem_add(start, size, name); > > + > > + return 0; > > Hi, steve, should here return 1 ? Other __setup functions

Re: [PATCH 2/2] arm64: dts: qcom: qcm6490-shift-otter: Name the regulators

2024-06-18 Thread Caleb Connolly
On 18/06/2024 15:30, Luca Weiss wrote: Without explicitly specifying names for the regulators they are named based on the DeviceTree node name. This results in multiple regulators with the same name, making debug prints and regulator_summary impossible to reason about. Signed-off-by: Luca

[RFC PATCH 1/4] kernel/reboot: Introduce pre_restart notifiers

2024-06-18 Thread Mathieu Desnoyers
Introduce a new pre_restart notifier chain for callbacks that need to be executed after the system has been made quiescent with syscore_shutdown(), before machine restart. This pre_restart notifier chain should be invoked on machine restart and on emergency machine restart. The use-case for this

[RFC PATCH 3/4] arm64: Invoke pre_restart notifiers

2024-06-18 Thread Mathieu Desnoyers
Invoke the pre_restart notifiers after shutdown, before machine restart. This allows preserving pmem memory across warm reboots. Invoke the pre_restart notifiers before emergency machine restart as well to cover the panic() scenario. Signed-off-by: Mathieu Desnoyers Cc: Dan Williams Cc: Vishal

[RFC PATCH 2/4] nvdimm/pmem: Flush to memory before machine restart

2024-06-18 Thread Mathieu Desnoyers
Register pre-restart notifiers to flush pmem areas from CPU data cache to memory on reboot, immediately before restarting the machine. This ensures all other CPUs are quiescent before the pmem data is flushed to memory. I did an earlier POC that flushed caches on panic/die oops notifiers [1], but

[RFC PATCH 0/4] Flush nvdimm/pmem to memory before machine restart

2024-06-18 Thread Mathieu Desnoyers
Introduce a new pre_restart notifier chain for callbacks that need to be executed after the system has been made quiescent with syscore_shutdown(), before machine restart. Register pre-restart notifiers to flush pmem areas from CPU data cache to memory on reboot, immediately before restarting the

[RFC PATCH 4/4] x86: Invoke pre_restart notifiers

2024-06-18 Thread Mathieu Desnoyers
Invoke the pre_restart notifiers after shutdown, before machine restart. This allows preserving pmem memory across warm reboots. Invoke the pre_restart notifiers on emergency_machine_restart to cover the panic() scenario. Signed-off-by: Mathieu Desnoyers Cc: Dan Williams Cc: Vishal Verma Cc:

Re: [PATCH v4 35/35] kmsan: Enable on s390

2024-06-18 Thread Alexander Potapenko
On Thu, Jun 13, 2024 at 5:40 PM Ilya Leoshkevich wrote: > > Now that everything else is in place, enable KMSAN in Kconfig. > > Acked-by: Heiko Carstens > Signed-off-by: Ilya Leoshkevich Reviewed-by: Alexander Potapenko

Re: [PATCH v4 09/35] kmsan: Expose kmsan_get_metadata()

2024-06-18 Thread Alexander Potapenko
On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich wrote: > > Each s390 CPU has lowcore pages associated with it. Each CPU sees its > own lowcore at virtual address 0 through a hardware mechanism called > prefixing. Additionally, all lowcores are mapped to non-0 virtual > addresses stored in the

Re: [PATCH v4 12/35] kmsan: Support SLAB_POISON

2024-06-18 Thread Alexander Potapenko
On Fri, Jun 14, 2024 at 1:44 AM Ilya Leoshkevich wrote: > > On Thu, 2024-06-13 at 16:30 -0700, SeongJae Park wrote: > > Hi Ilya, > > > > On Thu, 13 Jun 2024 17:34:14 +0200 Ilya Leoshkevich > > wrote: > > > > > Avoid false KMSAN negatives with SLUB_DEBUG by allowing > > > kmsan_slab_free() to

Re: Bug in Kernel 6.8.x, 6.9.x Causing Trace/Panic During Shutdown/Reboot

2024-06-18 Thread Steven Rostedt
On Thu, 13 Jun 2024 10:32:24 +0300 Ilkka Naulapää wrote: > ok, so if you don't have any idea where this bug is after those debug > patches, I'll try to find some time to bisect it as a last resort. > Stay tuned. FYI, I just debugged a strange crash that was caused by my config having something

Re: [PATCH v4 16/35] mm: slub: Unpoison the memchr_inv() return value

2024-06-18 Thread Alexander Potapenko
On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich wrote: > > Even though the KMSAN warnings generated by memchr_inv() are suppressed > by metadata_access_enable(), its return value may still be poisoned. > > The reason is that the last iteration of memchr_inv() returns > `*start != value ? start :

Re: [PATCH v4 14/35] kmsan: Do not round up pg_data_t size

2024-06-18 Thread Alexander Potapenko
On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich wrote: > > x86's alloc_node_data() rounds up node data size to PAGE_SIZE. It's not > explained why it's needed, but it's most likely for performance > reasons, since the padding bytes are not used anywhere. Some other > architectures do it as well,

Re: [PATCH v4 15/35] mm: slub: Let KMSAN access metadata

2024-06-18 Thread Alexander Potapenko
On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich wrote: > > Building the kernel with CONFIG_SLUB_DEBUG and CONFIG_KMSAN causes > KMSAN to complain about touching redzones in kfree(). > > Fix by extending the existing KASAN-related metadata_access_enable() > and metadata_access_disable() functions

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Alexandre Ghiti
Hi Andy, On Tue, Jun 18, 2024 at 2:48 PM Andy Chiu wrote: > > On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: > > > > Hi Conor, > > > > On 17/06/2024 15:23, Alexandre Ghiti wrote: > > > Hi Conor, > > > > > > Sorry for the delay here. > > > > > > On 13/06/2024 09:48, Conor Dooley wrote: >

Re: [PATCH 2/2] arm64: dts: qcom: qcm6490-shift-otter: Name the regulators

2024-06-18 Thread Konrad Dybcio
On 6/18/24 15:30, Luca Weiss wrote: Without explicitly specifying names for the regulators they are named based on the DeviceTree node name. This results in multiple regulators with the same name, making debug prints and regulator_summary impossible to reason about. Signed-off-by: Luca Weiss

Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-06-18 Thread Konrad Dybcio
On 6/18/24 15:13, Naina Mehta wrote: Rename qdss@8880 memory region as qlink_logging memory region and add qdss_mem memory region at address of 0x8850. Split mpss_dsmharq_mem region into 2 separate regions and reduce the size of mpssadsp_mem region. Signed-off-by: Naina Mehta ---

Re: [PATCH 1/2] arm64: dts: qcom: qcm6490-fairphone-fp5: Name the regulators

2024-06-18 Thread Konrad Dybcio
On 6/18/24 15:30, Luca Weiss wrote: Without explicitly specifying names for the regulators they are named based on the DeviceTree node name. This results in multiple regulators with the same name, making debug prints and regulator_summary impossible to reason about. Signed-off-by: Luca Weiss

[PATCH 2/2] arm64: dts: qcom: qcm6490-shift-otter: Name the regulators

2024-06-18 Thread Luca Weiss
Without explicitly specifying names for the regulators they are named based on the DeviceTree node name. This results in multiple regulators with the same name, making debug prints and regulator_summary impossible to reason about. Signed-off-by: Luca Weiss ---

[PATCH 1/2] arm64: dts: qcom: qcm6490-fairphone-fp5: Name the regulators

2024-06-18 Thread Luca Weiss
Without explicitly specifying names for the regulators they are named based on the DeviceTree node name. This results in multiple regulators with the same name, making debug prints and regulator_summary impossible to reason about. Signed-off-by: Luca Weiss ---

[PATCH 0/2] Name the regulators for QCM6490 Fairphone 5 & SHIFTphone 8

2024-06-18 Thread Luca Weiss
As per individual commit messages: Without explicitly specifying names for the regulators they are named based on the DeviceTree node name. This results in multiple regulators with the same name, making debug prints and regulator_summary impossible to reason about. Signed-off-by: Luca Weiss ---

[PATCH v3 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS remoteproc node

2024-06-18 Thread Naina Mehta
Enable MPSS remoteproc node on sdx75-idp platform. Signed-off-by: Naina Mehta Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdx75-idp.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts

[PATCH v3 4/5] arm64: dts: qcom: sdx75: Add remoteproc node

2024-06-18 Thread Naina Mehta
Add MPSS remoteproc node for SDX75 SoC. Signed-off-by: Naina Mehta Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdx75.dtsi | 47 + 1 file changed, 47 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi

[PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-06-18 Thread Naina Mehta
Rename qdss@8880 memory region as qlink_logging memory region and add qdss_mem memory region at address of 0x8850. Split mpss_dsmharq_mem region into 2 separate regions and reduce the size of mpssadsp_mem region. Signed-off-by: Naina Mehta --- arch/arm64/boot/dts/qcom/sdx75.dtsi | 18

[PATCH v3 2/5] remoteproc: qcom: pas: Add SDX75 remoteproc support

2024-06-18 Thread Naina Mehta
Add MPSS Peripheral Authentication Service support for SDX75 platform. Signed-off-by: Naina Mehta --- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index 8458bcfe9e19..833e2f9c2c5e

[PATCH v3 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS

2024-06-18 Thread Naina Mehta
Document the MPSS Peripheral Authentication Service on SDX75 platform. Signed-off-by: Naina Mehta Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml| 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v3 0/5] Add MPSS remoteproc support for SDX75

2024-06-18 Thread Naina Mehta
Add modem support to SDX75 using the PAS remoteproc driver. Also, add qlink_logging memory region and split MPSS DSM region into 2 separate regions. These patches were co-authored by Rohit Agarwal while at Qualcomm. Changes in v3: - Updated commit message for reserved memory updation for mpss.

Re: [PATCH v6 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Zhengyejian
On 2024/6/13 23:55, Steven Rostedt wrote: From: "Steven Rostedt (Google)" In order to allow for requesting a memory region that can be used for things like pstore on multiple machines where the memory layout is not the same, add a new option to the kernel command line called "reserve_mem".

Re: [PATCH v15 05/14] x86/sgx: Implement basic EPC misc cgroup functionality

2024-06-18 Thread Haitao Huang
On Tue, 18 Jun 2024 06:31:09 -0500, Huang, Kai wrote: @@ -921,7 +956,8 @@ static int __init sgx_init(void) if (!sgx_page_cache_init()) return -ENOMEM; - if (!sgx_page_reclaimer_init()) { + if (!sgx_page_reclaimer_init() || !sgx_cgroup_init()) { +

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Andy Chiu
On Tue, Jun 18, 2024 at 8:02 PM Alexandre Ghiti wrote: > > Hi Conor, > > On 17/06/2024 15:23, Alexandre Ghiti wrote: > > Hi Conor, > > > > Sorry for the delay here. > > > > On 13/06/2024 09:48, Conor Dooley wrote: > >> On Thu, May 23, 2024 at 01:51:34PM +0200, Alexandre Ghiti wrote: > >>> Commit

Re: [PATCH v4 11/35] kmsan: Allow disabling KMSAN checks for the current task

2024-06-18 Thread Alexander Potapenko
On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich wrote: > > Like for KASAN, it's useful to temporarily disable KMSAN checks around, > e.g., redzone accesses. Introduce kmsan_disable_current() and > kmsan_enable_current(), which are similar to their KASAN counterparts. > > Make them reentrant in

[PATCH RESEND v10 01/12] clk: mmp: Switch to use struct u32_fract instead of custom one

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Andy Shevchenko The struct mmp_clk_factor_tbl repeats the generic struct u32_fract. Kill the custom one and use the generic one instead. Signed-off-by: Andy Shevchenko Tested-by: Duje Mihanović Reviewed-by: Linus Walleij Reviewed-by: Stephen Boyd Signed-off-by: Duje Mihanović ---

[PATCH RESEND v10 12/12] MAINTAINERS: add myself as Marvell PXA1908 maintainer

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add myself as the maintainer for Marvell PXA1908 SoC support. Signed-off-by: Duje Mihanović --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ebf03f5f0619..5d48ac9801df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH RESEND v10 11/12] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value Edition LTE, a smartphone based on said SoC. Signed-off-by: Duje Mihanović --- arch/arm64/boot/dts/marvell/Makefile | 3 + .../dts/marvell/pxa1908-samsung-coreprimevelte.dts | 328

[PATCH RESEND v10 10/12] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add ARCH_MMP configuration option for Marvell PXA1908 SoC. Signed-off-by: Duje Mihanović --- arch/arm64/Kconfig.platforms | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index

[PATCH RESEND v10 09/12] dt-bindings: marvell: Document PXA1908 SoC

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add dt binding for the Marvell PXA1908 SoC. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Duje Mihanović --- Documentation/devicetree/bindings/arm/mrvl/mrvl.yaml | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH RESEND v10 05/12] clk: mmp: Add Marvell PXA1908 APBC driver

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the APBC controller block found on Marvell's PXA1908 SoC. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile | 2 +- drivers/clk/mmp/clk-pxa1908-apbc.c | 131 + 2 files changed, 132 insertions(+), 1

[PATCH RESEND v10 06/12] clk: mmp: Add Marvell PXA1908 APBCP driver

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the APBCP controller block found on Marvell's PXA1908 SoC. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile| 2 +- drivers/clk/mmp/clk-pxa1908-apbcp.c | 84 + 2 files changed, 85 insertions(+), 1

[PATCH RESEND v10 08/12] clk: mmp: Add Marvell PXA1908 MPMU driver

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the MPMU controller block on Marvell's PXA1908 SoC. The driver is incomplete, currently only supporting the fixed PLL1; dynamic PLLs 2-4 and CPU/DDR/AXI clock support is missing. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile | 2 +-

[PATCH RESEND v10 07/12] clk: mmp: Add Marvell PXA1908 APMU driver

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add driver for the APMU controller block found on Marvell's PXA1908 SoC. This driver is incomplete, lacking support for (at least) GPU, VPU, DSI and CCIC (camera related) clocks. Signed-off-by: Duje Mihanović --- drivers/clk/mmp/Makefile | 2 +-

[PATCH RESEND v10 04/12] dt-bindings: clock: Add Marvell PXA1908 clock bindings

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add dt bindings and documentation for the Marvell PXA1908 clock controller. Reviewed-by: Conor Dooley Reviewed-by: Stephen Boyd Signed-off-by: Duje Mihanović --- .../devicetree/bindings/clock/marvell,pxa1908.yaml | 48

[PATCH RESEND v10 02/12] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add the "marvell,pxa1908-padconf" compatible to allow migrating to a separate pinctrl driver later. Reviewed-by: Rob Herring Acked-by: Linus Walleij Signed-off-by: Duje Mihanović --- Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 1 file changed,

[PATCH RESEND v10 03/12] pinctrl: single: add marvell,pxa1908-padconf compatible

2024-06-18 Thread Duje Mihanović via B4 Relay
From: Duje Mihanović Add the "marvell,pxa1908-padconf" compatible to allow migrating to a separate pinctrl driver later. Acked-by: Linus Walleij Signed-off-by: Duje Mihanović --- drivers/pinctrl/pinctrl-single.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH RESEND v10 00/12] Initial Marvell PXA1908 support

2024-06-18 Thread Duje Mihanović via B4 Relay
Hello, This series adds initial support for the Marvell PXA1908 SoC and "samsung,coreprimevelte", a smartphone using the SoC. USB works and the phone can boot a rootfs from an SD card, but there are some warnings in the dmesg: During SMP initialization: [0.006519] CPU features: SANITY

Re: [PATCH] riscv: Fix early ftrace nop patching

2024-06-18 Thread Alexandre Ghiti
Hi Conor, On 17/06/2024 15:23, Alexandre Ghiti wrote: Hi Conor, Sorry for the delay here. On 13/06/2024 09:48, Conor Dooley wrote: On Thu, May 23, 2024 at 01:51:34PM +0200, Alexandre Ghiti wrote: Commit c97bf629963e ("riscv: Fix text patching when IPI are used") converted ftrace_make_nop()

Re: [PATCH v2 3/3] ARM: dts: qcom: msm8926-motorola-peregrine: Add framebuffer supplies

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add regulators used by the framebuffer of Motorola Moto G 4G (2013). Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/3] ARM: dts: qcom: msm8926-motorola-peregrine: Update temperature sensor

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add alert interrupt for the temperature sensor of Motorola Moto G 4G (2013), although not used by the driver yet. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 1/3] ARM: dts: qcom: msm8926-motorola-peregrine: Add accelerometer, magnetometer, regulator

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add the accelerometer, magnetometer and regulator that are present on the Motorola Moto G 4G (2013) device. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v6 0/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Alexander Graf
On 18.06.24 12:21, Ard Biesheuvel wrote: On Mon, 17 Jun 2024 at 23:01, Alexander Graf wrote: On 17.06.24 22:40, Steven Rostedt wrote: On Mon, 17 Jun 2024 09:07:29 +0200 Alexander Graf wrote: Hey Steve, I believe we're talking about 2 different things :). Let me rephrase a bit and make a

Re: [PATCH v15 05/14] x86/sgx: Implement basic EPC misc cgroup functionality

2024-06-18 Thread Huang, Kai
> @@ -921,7 +956,8 @@ static int __init sgx_init(void) > if (!sgx_page_cache_init()) > return -ENOMEM; > > - if (!sgx_page_reclaimer_init()) { > + if (!sgx_page_reclaimer_init() || !sgx_cgroup_init()) { > + misc_cg_set_capacity(MISC_CG_RES_SGX_EPC, 0); >

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-18 Thread Michael S. Tsirkin
On Mon, Jun 17, 2024 at 09:44:21AM -0700, Jakub Kicinski wrote: > On Mon, 17 Jun 2024 12:20:19 -0400 Michael S. Tsirkin wrote: > > > But the virtio spec doesn't allow setting the MAC... > > > I'm probably just lost in the conversation but there's hypervisor side > > > and there is user/VM side,

Re: [PATCH v6 0/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up

2024-06-18 Thread Ard Biesheuvel
On Mon, 17 Jun 2024 at 23:01, Alexander Graf wrote: > > On 17.06.24 22:40, Steven Rostedt wrote: > > On Mon, 17 Jun 2024 09:07:29 +0200 > > Alexander Graf wrote: > > > >> Hey Steve, > >> > >> > >> I believe we're talking about 2 different things :). Let me rephrase a > >> bit and make a concrete

Re: [PATCH v4 32/35] s390/uaccess: Add KMSAN support to put_user() and get_user()

2024-06-18 Thread Ilya Leoshkevich
On Tue, 2024-06-18 at 11:52 +0200, Alexander Potapenko wrote: > On Tue, Jun 18, 2024 at 11:40 AM Ilya Leoshkevich > wrote: > > > > On Tue, 2024-06-18 at 11:24 +0200, Alexander Potapenko wrote: > > > On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich > > > > > > wrote: > > > > > > > > put_user()

Re: [PATCH 1/8] riscv: stacktrace: convert arch_stack_walk() to noinstr

2024-06-18 Thread Alexandre Ghiti
Hi Andy, On 13/06/2024 09:11, Andy Chiu wrote: arch_stack_walk() is called intensively in function_graph when the kernel is compiled with CONFIG_TRACE_IRQFLAGS. As a result, the kernel logs a lot of arch_stack_walk and its sub-functions into the ftrace buffer. However, these functions should

Re: [PATCH v4 32/35] s390/uaccess: Add KMSAN support to put_user() and get_user()

2024-06-18 Thread Alexander Potapenko
On Tue, Jun 18, 2024 at 11:40 AM Ilya Leoshkevich wrote: > > On Tue, 2024-06-18 at 11:24 +0200, Alexander Potapenko wrote: > > On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich > > wrote: > > > > > > put_user() uses inline assembly with precise constraints, so Clang > > > is > > > in principle

Re: [PATCH v4 32/35] s390/uaccess: Add KMSAN support to put_user() and get_user()

2024-06-18 Thread Ilya Leoshkevich
On Tue, 2024-06-18 at 11:24 +0200, Alexander Potapenko wrote: > On Thu, Jun 13, 2024 at 5:39 PM Ilya Leoshkevich > wrote: > > > > put_user() uses inline assembly with precise constraints, so Clang > > is > > in principle capable of instrumenting it automatically. > > Unfortunately, > > one of

<    1   2   3   4   5   6   7   8   9   10   >