On 19 April 2021 09:17, Krzysztof Kozlowski wrote:
> Use of_device_get_match_data() to make the code slightly smaller.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
Acked-by: Adam Thomson
> drivers/mfd/da9062-core.c | 13 -
> 1 file changed, 4 insertio
On 19 April 2021 09:17, Krzysztof Kozlowski wrote:
> Use of_device_get_match_data() to make the code slightly smaller.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
Acked-by: Adam Thomson
> drivers/mfd/da9052-i2c.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 dele
On 15 April 2021 17:04, Mark Brown wrote:
> On Thu, Apr 15, 2021 at 04:00:48PM +0000, Adam Thomson wrote:
> > On 26 March 2021 22:16, Pierre-Louis Bossart wrote:
>
> > Apologies for the delay in getting to this. The change looks fine to me,
> > although this part was E
some time back, and I find it hard to believe anyone
out there has a board with this on. Wondering if it would make sense to remove
the driver permanently?
For the change at hand though:
Reviewed-by: Adam Thomson
> sound/soc/codecs/da732x.c | 17 ++---
> sound/soc/cod
ly_voltage gets updated
> once local port's tcpm enters SNK_TRANSITION_SINK when the accepted
> current_limit and supply_voltage is enforced.
>
> Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through
> power_supply")
> Signed-off-by: Badhri Jagan Sridhar
ot;)
> Signed-off-by: Badhri Jagan Sridharan
> ---
Missing commit information aside:
Reviewed-by: Adam Thomson
> drivers/usb/typec/tcpm/tcpm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tc
e supply through
> power_supply")
> Signed-off-by: Badhri Jagan Sridharan
> ---
Looks sensible, typo aside:
Reviewed-by: Adam Thomson
> drivers/usb/typec/tcpm/tcpm.c | 17 ++---
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/d
On 18 March 2021 20:40, Badhri Jagan Sridharan wrote:
> > Regarding selecting PDOs or PPS APDOs, surely we should only notify of a
> change
> > when we reach SNK_READY which means a new contract has been established?
> Until
> > that point it's possible any requested change could be rejected so
On 17 March 2021 18:13, Badhri Jagan Sridharan wrote:
> tcpm-source-psy- does not invoke power_supply_changed API when
> one of the published power supply properties is changed.
> power_supply_changed needs to be called to notify
> userspace clients(uevents) and kernel clients.
>
> Fixes:
On 16 March 2021 16:23, Mark Jonas wrote:
> From: Hubert Streidl
>
> By default the PMIC DA9063 2-wire interface is SMBus compliant. This
> means the PMIC will automatically reset the interface when the clock
> signal ceases for more than the SMBus timeout of 35 ms.
>
> If the I2C driver /
re-Louis Bossart
Acked-by: Adam Thomson
e latency issue described above.
>
> This patch enables the I2C bus mode if I2C_FUNC_I2C is set or
> otherwise enables the SMBus mode for a native SMBus controller
> which doesn't have I2C_FUNC_I2C set.
>
> Signed-off-by: Hubert Streidl
> Signed-off-by: Mark Jonas
Thanks for your efforts. Looks sensible to me, so:
Reviewed-by: Adam Thomson
e latency issue described above.
>
> This patch enables the I2C bus mode if I2C_FUNC_I2C is set or
> otherwise enables the SMBus mode for a native SMBus controller
> which doesn't have I2C_FUNC_I2C set.
>
> Signed-off-by: Hubert Streidl
> Signed-off-by: Mark Jonas
> ---
> Chang
On 25 January 2021 12:55, Mark Jonas wrote:
> From: Hubert Streidl
>
> By default the PMIC DA9063 2-wire interface is SMBus compliant. This
> means the PMIC will automatically reset the interface when the clock
> signal ceases for more than the SMBus timeout of 35 ms.
>
> If the I2C driver /
On 08 January 2021 08:53, Xu Wang wrote:
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
>
> Signed-off-by: Xu Wang
> ---
> sound/soc/codecs/da7218.c | 13 +
>
ff-by: Daniel Lezcano
> Reviewed-by: Lukasz Luba
For DA9062: Reviewed-by: Adam Thomson
On 01 December 2020 13:58, Mark Brown wrote:
> On Mon, 30 Nov 2020 16:59:04 +, Adam Ward wrote:
> > This series extends the DA9121 driver to add support for related products:
> >
> > DA9130, 10A, Dual-Phase (Automotive Grade)
> > DA9122, 5A + 5A
> > DA9131, 5A + 5A (Automotive Grade)
>
On 27 November 2020 12:52, Michael Klein wrote:
> "REGUALTOR" -> "REGULATOR"
>
> Signed-off-by: Michael Klein
Reviewed-by: Adam Thomson
ith the help of Coccinelle.
>
> Signed-off-by: Rikard Falkeborn
Acked-by: Adam Thomson
On 21 September 2020 21:50, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Adam Thomson
On 21 September 2020 21:50, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Adam Thomson
in that case. This
commit restores the default value to avoid this happening.
Fixes: aa5b18d1c290 ("ASoC: da7219: Move soft reset handling to codec level
probe")
Reported-by: Pierre-Louis Bossart
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 5 +++--
1 file changed, 3 insert
d da9210_dt_ids[] = {
> | ^
>
> Signed-off-by: Jisheng Zhang
Acked-by: Adam Thomson
On 18 August 2020 17:39, Zhi, Yong wrote:
> > This patch set reorganises and fixes device and codec level probe/remove
> > handling within the driver, to allow clean probe and remove at the codec
> > level.
> >
> > This set relates to an issue raised by Yong Zhi where a codec level re-probe
> >
On 12 August 2020 14:31, Hsin-Yi Wang wrote:
> Add regmap_cache to reduce wakeups events of interrupt if regulator is
> accessed frequently. This results in saving more power.
>
> Suggested-by: Daniel Kurtz
> Signed-off-by: Hsin-Yi Wang
Acked-by: Adam Thomson
freed up so the clocks were still registered from the previous
codec level probe().
This commit updates the clock handling for MCLK usage and DAI
clock provision to fix this discrepancy and allow the codec level
probe/remove functionality to operate as intended.
Signed-off-by: Adam Thomson
* functions being called for
regulator instantiation at the codec level.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 371 +++---
1 file changed, 188 insertions(+), 183 deletions(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
In preparation for cleanup of device level and codec level probe
funcitonality, all necessary devm_* allocations and fw retrieval
functions are moved to the I2C probe level code.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219-aad.c | 85
instantiation.
In addition some improvements around regulator handling and soft reset have
also been included.
Adam Thomson (3):
ASoC: da7219: Move required devm_* allocations to device level code
ASoC: da7219: Move soft reset handling to codec level probe
ASoC: da7219: Fix clock handling around
-regulator.c:
Acked-by: Adam Thomson
> ---
> drivers/regulator/da9055-regulator.c | 2 --
> drivers/regulator/da9062-regulator.c | 2 --
> drivers/regulator/da9063-regulator.c | 2 --
> drivers/regulator/da9210-regulator.c | 4
> drivers/regulator/da9211-regu
On 19 July 2020 01:29, Randy Dunlap wrote:
> Drop the repeated word "that" in a comment.
>
> Signed-off-by: Randy Dunlap
> Cc: Support Opensource
> Cc: Lee Jones
Acked-by: Adam Thomson
> ---
> include/linux/mfd/da9055/pdata.h |2 +-
> 1 file c
This update adds new regmap tables to support the latest DA silicon
which will automatically be selected based on the chip and variant
information read from the device.
Signed-off-by: Adam Thomson
Acked-for-MFD-by: Lee Jones
---
v3:
- No change
v2:
- No change
drivers/mfd/da9063-i2c.c
the proper regmap tables for
real initialisation.
Signed-off-by: Adam Thomson
---
v3:
- Replaced magic numbers around I2C paged access code with enums and defines
- Small style tidy ups as requested by Lee Jones
v2:
- Use raw I2C read access instead of a temporary regmap to interrogate chip
:
- Use raw I2C read access instead of a temporary regmap to interrogate chip and
variant id registers
Adam Thomson (2):
mfd: da9063: Fix revision handling to correctly select reg tables
mfd: da9063: Add support for latest DA silicon revision
drivers/mfd/da9063-core.c| 31
t; If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Acked-b
On 03 July 2020 10:33, Adam Thomson wrote
> On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
>
> > fix W=1 warning
> >
> > sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> > defined but not used [-Wunused-const-variable=]
> > 1711
On 26 June 2020 17:46, Sebastian Reichel wrote:
> This adds default clock/PLL configuration to the driver
> for usage with generic drivers like simple-card for usage
> with a fixed rate clock.
>
> Signed-off-by: Sebastian Reichel
Looks good. Thanks for the work here.
Reviewed-b
On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
> fix W=1 warning
>
> sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
> defined but not used [-Wunused-const-variable=]
> 1711 | static const struct acpi_device_id da7219_acpi_match[] = {
> |
On 01 July 2020 19:24, Pierre-Louis Bossart wrote:
> Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
>
> Signed-off-by: Pierre-Louis Bossart
So is the issue that the Kernel warning mechanism doesn't like Doxygen syntax?
If so then:
Acked-by: Adam Thomson
> ---
On 25 June 2020 20:17, Lee Jones wrote:
> Looks as though 99f75ce666199 ("regulator: da9063: fix suspend") failed
> to clean-up all of the existing .suspend variable initialisations.
> This has led to some 'initilized field overwritten' issues now present
> in W=1 builds.
You probably were not
ch works.
> > > >
> > > > This update adds raw I2C read access functionality to read the chip
> > > > and variant/revision information (common to all revisions) so that
> > > > it can subsequently correctly choose the proper regmap tables for
> &g
unctionality to read the chip
> > and variant/revision information (common to all revisions) so that
> > it can subsequently correctly choose the proper regmap tables for
> > real initialisation.
> >
> > Signed-off-by: Adam Thomson
> > ---
> > d
On 17 April 2020 11:56, Adam Thomson wrote:
> This patch set fixes the currently broken revision handling in the driver's
> i2c_probe() function and then adds DA support to existing permitted revisions.
Do I need to resend this patch, or will you still pick up the original mail
submissio
On 11 May 2020 14:26, Sebastian Reichel wrote:
> This adds default clock/PLL configuration to the driver
> for usage with generic drivers like simple-card for usage
> with a fixed rate clock.
>
> Signed-off-by: Sebastian Reichel
> ---
> sound/soc/codecs/da7213.c | 76
>
ftware nodes.
>
> Let's switch this driver over.
>
> Signed-off-by: Dmitry Torokhov
Acked-by: Adam Thomson
> ---
>
> drivers/regulator/da9211-regulator.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/da9
p on my test
board with DA9063. Although very unlikely to occur it does make sense so:
Tested-by: Adam Thomson
>
> ---
>
> Not marking as cc-stable as this was not reproduced and not tested.
> ---
> drivers/rtc/rtc-da9063.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>
On 26 September 2019 15:39, Marco Felsch wrote:
> On 19-09-26 14:04, Adam Thomson wrote:
> > On 26 September 2019 12:44, Marco Felsch wrote:
> >
> > > On 19-09-26 10:17, Adam Thomson wrote:
> > > > On 26 September 2019 09:10, Marco Felsch wrote:
> > >
On 26 September 2019 12:44, Marco Felsch wrote:
> On 19-09-26 10:17, Adam Thomson wrote:
> > On 26 September 2019 09:10, Marco Felsch wrote:
> >
> > > On 19-09-25 16:18, Adam Thomson wrote:
> > > > On 25 September 2019 16:52, Marco Fel
On 26 September 2019 09:10, Marco Felsch wrote:
> On 19-09-25 16:18, Adam Thomson wrote:
> > On 25 September 2019 16:52, Marco Felsch wrote:
> >
> > > Hi Adam,
> > >
> > > On 19-09-24 09:23, Adam Thomson wrote:
> > > > On 17 September
On 26 September 2019 06:51, Axel Lin wrote:
> The sleep flag bit decides the mode for BUCK_MODE_MANUAL case, simplify
> the logic as the result is the same.
>
> Signed-off-by: Axel Lin
Reviewed-by: Adam Thomson
> ---
> drivers/regulator/da9063-regulator.c | 9 +++--
&g
ix suspend_enable/disable preparation"
However, changes look fine so:
Reviewed-by: Adam Thomson
> ---
> drivers/regulator/da9062-regulator.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/da9062-regulator.c b/drivers/re
On 25 September 2019 16:52, Marco Felsch wrote:
> Hi Adam,
>
> On 19-09-24 09:23, Adam Thomson wrote:
> > On 17 September 2019 13:43, Marco Felsch wrote:
> >
> > > Add the documentation which describe the voltage selection gpio support.
> > > This propert
On 17 September 2019 13:43, Marco Felsch wrote:
> The DA9062/1 devices can switch their regulator voltages between
> voltage-A (active) and voltage-B (suspend) settings. Switching the
> voltages can be controlled by ther internal state-machine or by a gpio
> input signal and can be configured for
On 17 September 2019 13:43, Marco Felsch wrote:
> Add the documentation which describe the voltage selection gpio support.
> This property can be applied to each subnode within the 'regulators'
> node so each regulator can be configured differently.
>
> Signed-off-by: Marco Felsch
> ---
>
On 23 September 2019 23:03, Marco Felsch wrote:
> Hi Adam,
>
> On 19-09-23 16:03, Adam Thomson wrote:
> > On 17 September 2019 13:43, Marco Felsch wrote:
> >
> > > Currently the suspend reg_field maps to the pmic voltage selection bits
> > > and is used du
re is no need to check
> which regulator setting is active.
>
So I believe you're correct with the above statements. The driver, rather than
enabling/disabling a regulator in system suspend, will instead put the regulator
to a low power state, which is definitely not the desired outcome. Thanks for
On 17 September 2019 13:43, Marco Felsch wrote:
> Currently the suspend reg_field maps to the pmic voltage selection bits
> and is used during suspend_enabe/disable() and during get_mode(). This
> seems to be wrong for both use cases.
Hi Marco,
I'd be very surprised if what was in place was
On 02 May 2019 05:08, Yu-Hsuan Hsu wrote:
> If we want to set rate to 64000 on da7219, it fails and returns
> "snd_pcm_hw_params: Invalid argument".
> We should remove 64000 from support rate list because it is not
> available.
>
> Signed-off-by: Yu-Hsuan Hsu
y once until it re-initialize after codec power up.
>
> Signed-off-by: Logesh
Reviewed-by: Adam Thomson
> ---
> Changes in v2:
> -Include the mask DA7213_DAI_BCLKS_PER_WCLK_MASK
>
> sound/soc/codecs/da7213.c | 5 -
> sound/soc/codecs/da7213.h | 2 ++
>
eded for the clk_round_rate() call to work as
expected.
Signed-off-by: Adam Thomson
---
Changes in v2:
- Removed clk_round_rate() call for WCLK/SR as this is not sensible.
- Added checking after clk_round_rate() call for BCLK to verify returne rate is
suitable for the hw_params() desired frame size.
s
On 27 April 2019 18:20, Mark Brown wrote:
> On Fri, Apr 26, 2019 at 01:59:24PM +0100, Adam Thomson wrote:
>
> > + /*
> > +* Rounding the rate here avoids failure trying to set a new
> > +* rate on an already enable
On 25 April 2019 06:43, Logesh Kolandavel wrote:
> From: Logesh
>
> If the da7213 codec is configured as Master with the DAPM power down
> delay time set, 'snd_soc_component_write' function overwrites the
> DAI_CLK_EN bit of DAI_CLK_MODE register which leads to audio play
> only once until it
.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index 5f5fa34..72268f5 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
On 10 April 2019 17:39, Hans de Goede wrote:
> On 10-04-19 18:14, Adam Thomson wrote:
> > On 10 April 2019 16:45, Hans de Goede wrote:
> >
> >> Hi Kyle,
> >>
> >> On 10-04-19 14:49, Kyle Tso wrote:
> >>> On Wed, Apr 10, 2019 at 6:32 PM Adam T
On 09 April 2019 15:41, Hans de Goede wrote:
> Hi,
>
> On 09-04-19 15:06, Heikki Krogerus wrote:
> > On Tue, Apr 09, 2019 at 04:02:30PM +0300, Heikki Krogerus wrote:
> >> +Hans
> >>
> >> On Mon, Apr 08, 2019 at 10:17:35PM +0800, Kyle Tso wrote:
> >>> On Fri, Apr 5, 2019 at 9:42 PM Guenter Roeck
On 21 March 2019 12:22, Mark Brown wrote:
> On Tue, Mar 19, 2019 at 05:49:30PM +0000, Adam Thomson wrote:
>
> > -- #clock-cells : Should be set to '<0>', only one clock source
> > provided;
> > -- clock-output-names : Name given for DAI clocks output;
> > +-
of CCF. Enabling/disabling either BCLK or WCLK
will result in clocks being ungated/gated accordingly. To simplify
matters, these clocks can only be configured if the codec is set
as master, otherwise CCF control is disallowed.
Signed-off-by: Adam Thomson
---
include/sound/da7219.h| 8 +-
sound
With the need to expose WCLK and BCLK as separate clocks, the
'clock-cells' and 'clock-output-names' descriptions need to be
updated as now the codec is providing 2 clocks. The example is
also updated accordingly.
Signed-off-by: Adam Thomson
---
Documentation/devicetree/bindings/sound/da7219
This patch set extends the existing CCF support in the DA7219 codec driver by
splitting the DAI clock gate into clocks to cover WCLK and BCLK, to enable the
configuration of these clocks from audio machine drivers when this codec is
the clock master of the DAI.
Adam Thomson (3):
ASoC: da7219
As the DAI clocks for DA7219 have now been split into BCLK and WCLK,
the clock lookup name needs to be udpated here to select BCLK to
achieve the same functionality as before with regards to DAI clock
gating.
Signed-off-by: Adam Thomson
---
sound/soc/amd/acp-da7219-max98357a.c | 2 +-
1 file
On 8 February 2019 18:18, Mark Brown wrote:
> On Fri, Feb 15, 2019 at 07:06:15AM +, Agrawal, Akshu wrote:
>
> > +static static int cz_da7219_hw_params(struct snd_pcm_substream
> *substream,
> > + struct snd_pcm_hw_params *params) {
> > + /* da7219 Codec is
19
> during
> playback/capture on non da7219 codecs.
>
> Being able to set bclk at lower rate also fixes noise issue observed on some
> dmics.
>
> Signed-off-by: Akshu Agrawal
Reviewed-by: Adam Thomson
> ---
> sound/soc/amd/acp-da7219-max98357a.c | 20 ++
On 14 February 2019 14:30, Greg KH wrote:
> On Thu, Feb 14, 2019 at 02:17:14PM +0000, Adam Thomson wrote:
> > On 12 February 2019 16:20, Guenter Roeck wrote:
> >
> > > On 2/12/19 2:54 AM, Greg KH wrote:
> > > > On Tue, Feb 12, 2019 at 06:29:39PM +0800, Kyl
On 12 February 2019 16:20, Guenter Roeck wrote:
> On 2/12/19 2:54 AM, Greg KH wrote:
> > On Tue, Feb 12, 2019 at 06:29:39PM +0800, Kyle Tso wrote:
> >> On Thu, Jan 31, 2019 at 3:02 PM Greg KH
> wrote:
> >>
> >>> On Thu, Jan 31, 2019 at 11:54:11AM +0800, Kyle Tso wrote:
> Provide a function
rate now based on SR and
word length provided to hw_params().
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 36 ++--
sound/soc/codecs/da7219.h | 1 +
2 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc
handling is now used as an input to determine the BCLK
offset to align closer with other examples within ALSA.
Changes in v2:
- Update 0001 patch to use '&&' instead of '&' in hw_params() to decide if
BCLK rate should be configured or not.
Adam Thomson (2):
ASoC: da7219: Add suppor
, the driver now only limits frame size if codec
is clock master, and dynamically determines the BCLK offset
relating to WCLK using the tx_mask for slot offset along with the
slot width provided.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 80
On 13 February 2019 17:48, Adam Thomson wrote:
This patch set updates the driver to be more flexible regarding the BCLK and
TDM
> configurations of the device.
>
> Previously the BCLK rate was fixed at 64 periods per WCLK, when the codec is
> DAI
> clock master, but to satisf
rate now based on SR and
word length provided to hw_params().
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 36 ++--
sound/soc/codecs/da7219.h | 1 +
2 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc
handling is now used as an input to determine the BCLK
offset to align closer with other examples within ALSA.
Adam Thomson (2):
ASoC: da7219: Add support for master mode BCLK rate adjustment
ASoC: da7219: Update TDM usage to be more flexible
sound/soc/codecs/da7219.c | 116
, the driver now only limits frame size if codec
is clock master, and dynamically determines the BCLK offset
relating to WCLK using the tx_mask for slot offset along with the
slot width provided.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 80
nterested to see how many Sources go off-piste like that with a more
unusual PPS range, especially when the default fixed is 5V, and they're required
to support one of the defined PPS ranges which will start at 3.3V. Not sure what
this might gain you. However, spec says it's possible so:
Reviewed-by: Adam T
On 08 January 2019 09:13, Adam Thomson wrote:
> This small patchset provides improvements to CCF based clock handling relating
> to the DAI clocks. In the first patch MCLK is made parent of DAI clocks, if
> MCLK
> has been provided to the driver, which means that MCLK will a
adds the ability to
read the WCLK rate provided by the codec when DAI clocks are featured. This is
more useful than the returned rate simply being the rate of the parent clock,
which in this case would be MCLK.
Adam Thomson (2):
ASoC: da7219: MCLK should be enabled before DAI clocks
ASoC: da7219
is now added as a parent to the
DAI clocks, if MCLK was provided, so that if they are enabled MCLK
will automatically be enabled as a prerequisite by the CCF.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 32
1 file changed, 24 insertions(+), 8
, as set in HW, so that's what we
now do.
Signed-off-by: Adam Thomson
---
sound/soc/codecs/da7219.c | 45 ++---
sound/soc/codecs/da7219.h | 1 +
2 files changed, 43 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs
in assignment (different base
> types)
> da7219-aad.c:157:37:expected unsigned short [unsigned] [usertype]
> tonegen_freq_hptest
> da7219-aad.c:157:37:got restricted __le16 [usertype]
>
> Cc: Adam Thomson
> Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Adam Thomso
On 05 January 2019 02:03, Pierre-Louis Bossart wrote:
> Reported by Sparse:
> da7219.c:841:57: warning: dubious: x & !y
>
> Cc: Adam Thomson
> Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Adam Thomson
> ---
> sound/soc/codecs/da7219.c | 2 +-
> 1 fil
erational voltage times the
>maximum current defined in the selected Source PDO d. Select the Source PDO
> with the highest maximum power
>
> Signed-off-by: Kyle Tso
Acked-by: Adam Thomson
>
> ---
> Changelog since v1:
> - updated the commit message as suggested b
On 17 December 2018 12:45, Kyle Tso wrote:
> On Mon, Dec 17, 2018 at 8:23 PM Adam Thomson
> wrote:
> >
> > On 17 December 2018 02:48, Kyle Tso wrote:
> >
> > > Current matching rules ensure that the voltage range of selected
> > > Source Capability i
On 17 December 2018 02:48, Kyle Tso wrote:
> Current matching rules ensure that the voltage range of selected Source
> Capability is entirely within the range defined in one of the Sink
> Capabilities. This
> is reasonable but not practical because Sink may not support wide range of
> voltage
mit, to
> re-configure
> the maximum voltage from the external supply at runtime based on system-level
> knowledge or user input.
>
> Signed-off-by: Enric Balletbo i Serra
> Reviewed-by: Guenter Roeck
Acked-by: Adam Thomson
> ---
>
> Changes in v3:
> - Impr
On 12 December 2018 02:47, Kyle Tso wrote:
> On Mon, Dec 10, 2018 at 7:36 PM Adam Thomson
> wrote:
> >
> > On 10 December 2018 09:01, Adam Thomson wrote:
> >
> > > On 06 December 2018 03:02, Kyle Tso wrote:
> > >
> > > > Current ma
On 10 December 2018 09:01, Adam Thomson wrote:
> On 06 December 2018 03:02, Kyle Tso wrote:
>
> > Current matching rules ensure that the voltage range of selected
> > Source Capability is entirely within the range defined in one of the
> > Sink Capabilities. This is reas
On 06 December 2018 03:02, Kyle Tso wrote:
> Current matching rules ensure that the voltage range of selected Source
> Capability is entirely within the range defined in one of the Sink
> Capabilities. This
> is reasonable but not practical because Sink may not support wide range of
> voltage
org
> Signed-off-by: Rob Herring
For da9052 regulator driver:
Acked-by: Adam Thomson
> ---
> drivers/regulator/88pm8607.c | 2 +-
> drivers/regulator/da9052-regulator.c | 2 +-
> drivers/regulator/max8997-regulator.c | 2 +-
> drivers/regulator
org
> Signed-off-by: Rob Herring
For da9052 regulator driver:
Acked-by: Adam Thomson
> ---
> drivers/regulator/88pm8607.c | 2 +-
> drivers/regulator/da9052-regulator.c | 2 +-
> drivers/regulator/max8997-regulator.c | 2 +-
> drivers/regulator
On 05 December 2018 04:27, Akshu Agrawal wrote:
> On 12/5/2018 2:46 AM, Adam Thomson wrote:
> > On 04 December 2018 18:36, Akshu Agrawal wrote:
> >
> >> Failed i2c transaction can lead to failure in reg read or write.
> >> Need to have error check for each read
On 05 December 2018 04:27, Akshu Agrawal wrote:
> On 12/5/2018 2:46 AM, Adam Thomson wrote:
> > On 04 December 2018 18:36, Akshu Agrawal wrote:
> >
> >> Failed i2c transaction can lead to failure in reg read or write.
> >> Need to have error check for each read
On 04 December 2018 18:36, Akshu Agrawal wrote:
> Failed i2c transaction can lead to failure in reg read or write.
> Need to have error check for each read write operation.
>
I'm not really clear what this gains you. If I2C is broken this won't solve
anything, and you have far deeper problems.
1 - 100 of 1025 matches
Mail list logo
