[PATCH 1/2] ASoC: da7219: Correct IRQ level in DT binding example

2017-11-17 Thread Adam Thomson
Current DT binding documentation shows an example where the IRQ for the device is chosen to be ACTIVE_HIGH. This is incorrect as the device only supports ACTIVE_LOW, so this commit fixes that discrepancy. Signed-off-by: Adam Thomson --- Documentation/devicetree/bindings/sound/da7219.txt | 2

[PATCH 0/2] ASoC: Correct DT binding examples IRQ usage for da7218/9

2017-11-17 Thread Adam Thomson
Currently in the DT bindings documents for DA7218 and DA7219, the examples for bindings usage show ACTIVE_HIGH IRQ usage. For both devices this is incorrect as the devices themselves only suport ACTIVE_LOW. This patch set rectifies the inconsistency. Adam Thomson (2): ASoC: da7219: Correct IRQ

[PATCH v2] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-16 Thread Adam Thomson
s are reported to TCPM. Changes in v2: - Remove erroneous extended header check Patch is based on Linux next-20171114 to include move out of staging. Signed-off-by: Adam Thomson --- drivers/usb/typec/fusb302/fusb302.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --

[PATCH] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-16 Thread Adam Thomson
s are reported to TCPM. Patch is based on Linux next-20171114 to include move out of staging. Signed-off-by: Adam Thomson --- drivers/usb/typec/fusb302/fusb302.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/usb/typec/fusb302/fusb302.c b/drivers/usb/

RE: [PATCH AUTOSEL for 4.9 31/56] ASoC: da7218: Set DAI output pin high impedance when not in use

2017-11-15 Thread Adam Thomson
On 15 November 2017 16:43, alexander.le...@verizon.com wrote: > On Wed, Nov 15, 2017 at 12:19:18PM +, Mark Brown wrote: > >On Wed, Nov 15, 2017 at 02:45:42AM +, alexander.le...@verizon.com wrote: > > > >> This patch updates the AIF_OUT widget to set the DAI output pin of > >> the device as

RE: [PATCH 1/2] ASoC: da7218: fix fix child-node lookup

2017-11-14 Thread Adam Thomson
ematurely freed. > > Fixes: 4d50934abd22 ("ASoC: da7218: Add da7218 codec driver") > Cc: stable # 4.5 > Cc: Adam Thomson > Signed-off-by: Johan Hovold Acked-by: Adam Thomson > --- > sound/soc/codecs/da7218.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

[RFC PATCH v2 4/7] typec: tcpm: Add core support for sink side PPS

2017-11-14 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 476

[RFC PATCH v2 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2017-11-14 Thread Adam Thomson
This commit adds definitions for PD Rev 3.0 messages, including APDO PPS and extended message support for TCPM. Signed-off-by: Adam Thomson --- include/linux/usb/pd.h | 174 + 1 file changed, 162 insertions(+), 12 deletions(-) diff --git a

[RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-14 Thread Adam Thomson
pply class' Signed-off-by: Adam Thomson --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 +- drivers/usb/typec/tcpm.c| 225 +++- 4 files changed, 228 in

[RFC PATCH v2 5/7] power: supply: Add type for USB PD PPS chargers

2017-11-14 Thread Adam Thomson
This adds a type to represent USB PPS chargers as defined in the USB Power Delivery Specification Revision 3.0 V1.1 Signed-off-by: Adam Thomson Reviewed-by: Sebastian Reichel --- drivers/power/supply/power_supply_sysfs.c | 2 +- include/linux/power_supply.h | 1 + 2 files changed

[RFC PATCH v2 7/7] typec: tcpm: Add support for sink PPS related messages

2017-11-14 Thread Adam Thomson
ndled. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 152 --- 1 file changed, 143 insertions(+), 9 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index 7c26c3d..8db49ab 100644 --- a/drivers/usb/typec/tcpm.c

[RFC PATCH v2 3/7] typec: tcpm: Add SDB header for Status message handling

2017-11-14 Thread Adam Thomson
This commit adds a header providing definitions for handling Status messages. Currently the header only focuses on handling incoming Status messages. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ext_sdb.h | 31 +++ 1 file changed, 31 insertions(+) create

[RFC PATCH v2 2/7] typec: tcpm: Add ADO header for Alert message handling

2017-11-14 Thread Adam Thomson
This commit adds a header providing definitions for handling Alert messages. Currently the header only focuses on handling incoming alerts. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ado.h | 42 ++ 1 file changed, 42 insertions(+) create mode

[RFC PATCH v2 0/7] typec: tcpm: Add sink side support for PPS

2017-11-14 Thread Adam Thomson
s for referencing correct license. NOTE: Code changes are based on linux-next tag 'next-20171114' to pick up the move out of staging of TCPM related code. Adam Thomson (7): typec: tcpm: Add PD Rev 3.0 definitions to PD header typec: tcpm: Add ADO header for Alert message handling typec

RE: [RFC PATCH 5/7] power: supply: Add type for USB PD PPS chargers

2017-11-07 Thread Adam Thomson
On 06 November 2017 13:26, Sebastian Reichel wrote: > Hi, > > On Wed, Nov 01, 2017 at 05:03:13PM +0000, Adam Thomson wrote: > > This adds a type to represent USB PPS chargers as defined in the > > USB Power Delivery Specification Revision 3.0 V1.1 > > >

RE: [RFC PATCH 2/7] typec: tcpm: Add ADO header for Alert message handling

2017-11-02 Thread Adam Thomson
On 02 November 2017 16:49, Greg Kroah-Hartman wrote: > On Thu, Nov 02, 2017 at 11:40:12AM +0000, Adam Thomson wrote: > > On 01 November 2017 17:20, Greg Kroah-Hartman wrote: > > > > > On Wed, Nov 01, 2017 at 05:03:10PM +, Adam Thomson wrote: > > > >

RE: [RFC PATCH 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2017-11-02 Thread Adam Thomson
On 01 November 2017 20:09, Jack Pham wrote: > Hi Adam, > > On Wed, Nov 01, 2017 at 05:03:09PM +0000, Adam Thomson wrote: > > This commit adds definitions for PD Rev 3.0 messages, including > > APDO PPS and extended message support for TCPM. > > >

RE: [RFC PATCH 3/7] typec: tcpm: Add SDB header for Status message handling

2017-11-02 Thread Adam Thomson
On 01 November 2017 17:21, Greg Kroah-Hartman wrote: > On Wed, Nov 01, 2017 at 05:03:11PM +0000, Adam Thomson wrote: > > This commit adds a header providing definitions for handling > > Status messages. Currently the header only focuses on handling > > incoming Status message

RE: [RFC PATCH 2/7] typec: tcpm: Add ADO header for Alert message handling

2017-11-02 Thread Adam Thomson
On 01 November 2017 17:20, Greg Kroah-Hartman wrote: > On Wed, Nov 01, 2017 at 05:03:10PM +0000, Adam Thomson wrote: > > This commit adds a header providing definitions for handling Alert > > messages. Currently the header only focuses on handling incoming > > alerts. > &

[RFC PATCH 3/7] typec: tcpm: Add SDB header for Status message handling

2017-11-01 Thread Adam Thomson
This commit adds a header providing definitions for handling Status messages. Currently the header only focuses on handling incoming Status messages. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ext_sdb.h | 40 1 file changed, 40 insertions

[RFC PATCH 0/7] typec: tcpm: Add sink side support for PPS

2017-11-01 Thread Adam Thomson
ed to ensure re-requests occur regularly to ensure PPS remains and the source does not hard reset. So with all of that covered, please feel free to rip this apart as you see fit. Note: Code changes are based on linux-next tag 'next-20171017' to pick up the move out of staging of TCPM rela

[RFC PATCH 2/7] typec: tcpm: Add ADO header for Alert message handling

2017-11-01 Thread Adam Thomson
This commit adds a header providing definitions for handling Alert messages. Currently the header only focuses on handling incoming alerts. Signed-off-by: Adam Thomson --- include/linux/usb/pd_ado.h | 49 ++ 1 file changed, 49 insertions(+) create

[RFC PATCH 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header

2017-11-01 Thread Adam Thomson
This commit adds definitions for PD Rev 3.0 messages, including APDO PPS and extended message support for TCPM. Signed-off-by: Adam Thomson --- include/linux/usb/pd.h | 162 + 1 file changed, 151 insertions(+), 11 deletions(-) diff --git a

[RFC PATCH 7/7] typec: tcpm: Add support for sink PPS related messages

2017-11-01 Thread Adam Thomson
ndled. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 152 --- 1 file changed, 143 insertions(+), 9 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c index bf3c93a..d12304e 100644 --- a/drivers/usb/typec/tcpm.c

[RFC PATCH 6/7] typec: tcpm: Represent source supply through power_supply class

2017-11-01 Thread Adam Thomson
pply class' Signed-off-by: Adam Thomson --- drivers/usb/typec/Kconfig | 1 + drivers/usb/typec/fusb302/Kconfig | 2 +- drivers/usb/typec/fusb302/fusb302.c | 63 +- drivers/usb/typec/tcpm.c| 225 +++- 4 files changed, 228 in

[RFC PATCH 4/7] typec: tcpm: Add core support for sink side PPS

2017-11-01 Thread Adam Thomson
This commit adds code to handle requesting of PPS APDOs. Switching between standard PDOs and APDOs, and re-requesting an APDO to modify operating voltage/current will be triggered by an external call into TCPM. Signed-off-by: Adam Thomson --- drivers/usb/typec/tcpm.c | 441

[RFC PATCH 5/7] power: supply: Add type for USB PD PPS chargers

2017-11-01 Thread Adam Thomson
This adds a type to represent USB PPS chargers as defined in the USB Power Delivery Specification Revision 3.0 V1.1 Signed-off-by: Adam Thomson --- drivers/power/supply/power_supply_sysfs.c | 2 +- include/linux/power_supply.h | 1 + 2 files changed, 2 insertions(+), 1 deletion

[PATCH 2/2] ASoC: Intel: bxt: Move codec sysclk config to codec_init function

2017-06-19 Thread Adam Thomson
river does not have the correct MCLK rates programmed and so the HP detection feature does not operate as expected. This patch rectifies this issue by moving the sysclk call to codec_init function so it's only called once at initialisation. Signed-off-by: Adam Thomson Acked-by: Sathyanaraya

[PATCH 0/2] ASoC: da7219: Resolve HP detect issues relating to MCLK

2017-06-19 Thread Adam Thomson
The patch set resolves issues in the HP detect feature, relating to MCLK, where the feature can misdetect headphones as lineout. Adam Thomson (2): ASoC: da7219: Fix HP detection procedure for all MCLK frequencies ASoC: Intel: bxt: Move codec sysclk config to codec_init function sound/soc

[PATCH 1/2] ASoC: da7219: Fix HP detection procedure for all MCLK frequencies

2017-06-19 Thread Adam Thomson
consistent timings for the procedure, regardless of MCLK frequency. Signed-off-by: Adam Thomson Acked-by: Sathyanarayana Nujella --- sound/soc/codecs/da7219-aad.c | 31 +++-- sound/soc/codecs/da7219.c | 53 +-- sound/soc/codecs

[RESEND PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-23 Thread Adam Thomson
tifies this discrepancy. Signed-off-by: Adam Thomson Reviewed-by: Takashi Sakamoto --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index d256ebf..6e1940e 100644 --- a/sound/soc/codecs/da7218.c

[PATCH] ASoC: da7213: Update driver to use device_property* FW functions

2017-05-19 Thread Adam Thomson
to use device_property* calls instead so that both ACPI and DT are handled as expected. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/sound/soc/codecs/da7213.c b/sound/soc

[PATCH] ASoC: da7213: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
tifies this discrepancy. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index 12da558..d114f33 100644 --- a/sound/soc/codecs/da7213.c +++ b/sound/soc/codecs/da7213.

RE: [PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
On 03 May 2017 15:10, Takashi Sakamoto wrote: > On May 3 2017 22:54, Adam Thomson wrote: > > In the SRM lock check section of code the '&' bitwise operator is > > used as part of checking lock status. Functionally the code works > > as intended, but the

[PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check

2017-05-03 Thread Adam Thomson
tifies this discrepancy. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index d256ebf..6e1940e 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da721

RE: [PATCH 14/62] watchdog: da9063_wdt: Convert to use device managed functions

2017-01-17 Thread Adam Thomson
n e;' > - Drop assignments to otherwise unused variables > - Drop unused variables > - Drop remove function > - Drop dev_set_drvdata() > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Support Opensource > Signed-off-by: Guenter Roeck > --- Acked-by: Adam Thomson

RE: [PATCH 13/62] watchdog: da9062_wdt: Convert to use device managed functions

2017-01-17 Thread Adam Thomson
op remove function > - Drop dev_set_drvdata() > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Support Opensource > Signed-off-by: Guenter Roeck > --- Acked-by: Adam Thomson

RE: [PATCH 11/62] watchdog: da9052_wdt: Convert to use device managed functions

2017-01-17 Thread Adam Thomson
;' > - Drop assignments to otherwise unused variables > - Replace 'if (e) { return expr; }' with 'if (e) return expr;' > - Drop remove function > - Drop platform_set_drvdata() > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Support Opensource > Signed-off-by: Guenter Roeck > --- Acked-by: Adam Thomson

RE: [PATCH 12/62] watchdog: da9055_wdt: Convert to use device managed functions

2017-01-17 Thread Adam Thomson
- Drop remove function > - Drop platform_set_drvdata() > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Support Opensource > Signed-off-by: Guenter Roeck > --- Acked-by: Adam Thomson

RE: [PATCH] backlight: da9052: Fix module autoload

2017-01-03 Thread Adam Thomson
t > > After this patch: > > $ modinfo drivers/video/backlight/da9052_bl.ko | grep alias > alias: platform:da9052-wled3 > alias: platform:da9052-wled2 > alias: platform:da9052-wled1 > > Signed-off-by: Javier Martinez Canillas > --- Acked-by: Adam Thomson

RE: [PATCH v2] watchdog: constify watchdog_info structures

2017-01-03 Thread Adam Thomson
5_wdt_set_timeout(wdt_dev, 0); > } > > -static struct watchdog_info da9055_wdt_info = { > +static const struct watchdog_info da9055_wdt_info = { > .options= WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING, > .identity = "DA9055 Watchdog", > }; For DA9052 and DA9055: Acked-by: Adam Thomson

[PATCH] ASoC: da7218: Set DAI output pin high impedance when not in use

2016-12-16 Thread Adam Thomson
riven. This patch updates the AIF_OUT widget to set the DAI output pin of the device as high impedance when not in use. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7218.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7

RE: [PATCH] ASoC: da7219: Connect output enable register to DAIOUT

2016-10-28 Thread Adam Thomson
, 0), > + SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, > DA7219_DAI_TDM_CTRL, > + DA7219_DAI_OE_SHIFT, DA7219_NO_INVERT), > SND_SOC_DAPM_AIF_IN("DAIIN", "Playback", 0, SND_SOC_NOPM, 0, 0), > > /* Output Muxes */ > -- > 2.8.0.rc3.226.g39d4020 Acked-by: Adam Thomson

[PATCH] ASoC: da7219: Improve pop/click performance for sensitive HPs

2016-10-03 Thread Adam Thomson
. Signed-off-by: Adam Thomson --- Changes are based on top of commit: ASoC: da7219: Disable AAD if codec is not a wake-up source sound/soc/codecs/da7219-aad.c | 18 -- sound/soc/codecs/da7219.c | 139 -- sound/soc/codecs/da7219.h | 5 ++ 3

[PATCH 2/2] ASoC: da7219: Disable AAD if codec is not a wake-up source

2016-09-26 Thread Adam Thomson
uring system suspend aren't captured. This patch updates the driver to disable AAD during suspend, if we're not a wake-up source, and then re-enables this on resume. Signed-off-by: Adam Thomson --- include/sound/da7219.h| 2 ++ sound/soc/codecs/da

[PATCH 1/2] ASoC: da7219: Reset codec gracefully, if still active

2016-09-26 Thread Adam Thomson
Currently the reset code in i2c_probe only resets the AAD part of the device and not the entire codec. This patch updates the driver to resolve this and ensures that if the codec is still active from a previous boot then the audio paths are powered down prior to reset. Signed-off-by: Adam Thomson

[PATCH 0/2] ASoC: da7219: Codec soft reset and AAD improvements

2016-09-26 Thread Adam Thomson
under the following commits: ASoC: da7219: software reset codec at probe ASoC: da7219: Support HP detect procedure when MCLK not present Adam Thomson (2): ASoC: da7219: Reset codec gracefully, if still active ASoC: da7219: Disable AAD if codec is not a wake-up source include/sound/da7219.h

[PATCH] ASoC: da7219: Support HP detect procedure when MCLK not present

2016-09-12 Thread Adam Thomson
adds support for the HP detect procedure when running from the device's internal oscillator, to ensure all platforms can make use of this feature correctly. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219-aad.c | 34 -- sound/soc/codecs/da7219-

RE: [PATCH] ASoC: da7219: make sure the valid event when startup

2016-09-09 Thread Adam Thomson
On 09 September 2016 15:02, Xing Zheng wrote: > We need to ensure the master bias and jack detection to be enabled > before reporting event at the da7219_aad_irq_thread. Otherwise, we > may acquire the incorrect the unplug event when the DUT startup > with a plugged headphone. For this device, th

[PATCH 1/2] ASoC: da7218: Remove 32KHz PLL mode from driver

2016-08-08 Thread Adam Thomson
Functionality has been removed in latest silicon variants. This patch removes the feature from the driver to align. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7218.c | 12 +++- sound/soc/codecs/da7218.h | 2 -- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a

[PATCH 2/2] ASoC: da7218: Improve driver efficiency with regards to MCLK usage

2016-08-08 Thread Adam Thomson
Currently MCLK remains enabled during bias STANDBY state, and this is not necessary. This patch updates the code to handle enabling and disabling of MCLK, if provided, when moving between STANDBY and PREPARE states, therefore saving power when no active streams present. Signed-off-by: Adam

[PATCH 0/2] ASoC: da7218: Small clocking related updates for driver

2016-08-08 Thread Adam Thomson
This patch set contains two updates relating to clocking. The first removes the 32KHz PLL feature as this is no longer supported, and the second provides MCLK effciency improvements to avoid unnecessary MCLK enabling. Changes are based on v4.8-rc1 Linux kernel. Adam Thomson (2): ASoC: da7218

RE: [alsa-devel] [PATCH 3/4] ASoC: da7213: Refactor sysclk(), pll() functions to improve handling

2016-08-08 Thread Adam Thomson
On 08 August 2016 08:43, Peter Meerwald-Stadler wrote: > > Currently the handling of the PLL in the driver is a little clunky, > > and not ideal for all modes. This patch updates the code to make it > > cleaner and more sensible for the various PLL states. > > > > Key items of note are: > > - MCL

[PATCH 2/4] ASoC: da7213: Improve driver efficiency with regards to MCLK usage

2016-08-04 Thread Adam Thomson
Currently MCLK remains enabled during bias STANDBY state, and this is not necessary. This patch updates the code to handle enabling and disabling of MCLK, if provided, when moving between STANDBY and PREPARE states, therefore saving power when no active streams present. Signed-off-by: Adam

[PATCH 4/4] ASoC: da7213: Improve 32KHz mode PLL locking

2016-08-04 Thread Adam Thomson
To aid PLL in locking on to a 32KHz MCLK, some register mods are made during PLL configuration, and when enabling the DAI, to achieve the full range of sample rates. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 25 - 1 file changed, 24 insertions(+), 1

[PATCH 3/4] ASoC: da7213: Refactor sysclk(), pll() functions to improve handling

2016-08-04 Thread Adam Thomson
correct MCLK rates, to avoid incorrect usage of PLL for this operation. - For 32KHz mode, SRM flag now correctly enabled and fout set to sensible value to achieve appropriate PLL dividers. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 85

[PATCH 0/4] ASoC: da7213: Device clocking updates and fixes

2016-08-04 Thread Adam Thomson
DAI is enabled. Patches are based on v4.7 Linux kernel Adam Thomson (4): ASoC: da7213: Default to 64 BCLKs per WCLK to support all formats ASoC: da7213: Improve driver efficiency with regards to MCLK usage ASoC: da7213: Refactor sysclk(), pll() functions to improve handling ASoC: da7213

[PATCH 1/4] ASoC: da7213: Default to 64 BCLKs per WCLK to support all formats

2016-08-04 Thread Adam Thomson
Previously code defaulted to 32 BCLKS per WCLK which meant 24 and 32 bit DAI formats would not work properly. This patch fixes the issue by defaulting to 64 BCLKs per WCLK. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] ASoC: da7219: Make more efficient use of MCLK within driver

2016-07-29 Thread Adam Thomson
moving between the STANDBY and PREPARE bias level, and when a 3-pole jack is inserted and HP detection is required, thus saving power at all other times. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219-aad.c | 18 +- sound/soc/codecs/da7219.c | 18 +++--- 2

RE: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

2016-06-21 Thread Opensource [Adam Thomson]
t; > > > Changes in v3: > > - Use of_node_cmp() in device_get_named_child_node() to match DT node. > > > > Changes in v2: > > - Rebase to v4.7-rc1 > > - Small updates to codec patch based on previous reviewer comments > > > > Adam Thomson (2): &

RE: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

2016-06-21 Thread Opensource [Adam Thomson]
21 June 2016 12:42, Rafael J. Wysocki wrote: > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode, > > > + const char *name) > > > +{ > > > + return is_acpi_data_node(fwnode) ? > > > + (!strcasecmp(to_acpi_data_node(fwnode)->name, name

RE: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

2016-06-21 Thread Opensource [Adam Thomson]
On 20 June 2016 12:39, Adam Thomson wrote: > For device nodes in both DT and ACPI, it possible to have named > child nodes which contain properties (an existing example being > gpio-leds). This adds a function to find a named child node for > a device which can be used by drivers

RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

2016-06-16 Thread Opensource [Adam Thomson]
On 16 June 2016 02:15, Xing Zheng wrote: > >> + /* Enable Headset and 4 Buttons Jack detection */ > >> + ret = snd_soc_card_jack_new(rtd->card, "Headset Jack", > >> + SND_JACK_HEADSET | > > Should this also include SND_JACK_LINEOUT? da7219 differentiat

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

2016-06-14 Thread Opensource [Adam Thomson]
On 13 June 2016 20:33, Frank Rowand wrote: > > DT node names are case insensitive. The of.h header does provide a helper > > macro > > which is equivalent to this, but that macro is part of the '#ifdef > > CONFIG_OF' > > block. If I were to use it then it would cause non-DT builds to fail. I >

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

2016-06-13 Thread Opensource [Adam Thomson]
On 13 June 2016 09:47, Mark Brown wrote: > > That's strange. I'm not a subscriber to that mailing list, but I assume that > > shouldn't matter here? Strangely though the only mailing list these seem to > > have > > made it to is the ALSA one. :( Will see if I can find out why as I've not > > seen

RE: [PATCH 0/3] ASoC: da7219: Add ACPI initialisation support to driver

2016-06-10 Thread Opensource [Adam Thomson]
On 10 June 2016 11:16, Adam Thomson wrote: > This patch set updates the driver to use generic device property & fwnode > related functions to read in either DT and ACPI data for driver > initialisation. > > Changes are based on v4.6-rc6 Linux Kernel. > > Adam Thom

[PATCH 3/3] ASoC: da7219: Add initial ACPI id for device

2016-06-10 Thread Adam Thomson
This adds "DLGS7219" ACPI id for the codec. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella --- sound/soc/codecs/da7219.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index bc32322..da268b8 100644 --- a

[PATCH 2/3] ASoC: da7219: Add ACPI parsing support

2016-06-10 Thread Adam Thomson
This update allows for parsing of ACPI, in addition to existing DT support. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella --- sound/soc/codecs/da7219-aad.c | 32 sound/soc/codecs/da7219.c | 7 --- 2 files changed, 32 insertions(+), 7

[PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-06-10 Thread Adam Thomson
This change converts the driver from using the of_* functions to using the device_* and fwnode_* functions for accssing DT related data. This is in preparation for updates to support ACPI based initialisation. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella --- sound/soc/codecs

[PATCH 0/3] ASoC: da7219: Add ACPI initialisation support to driver

2016-06-10 Thread Adam Thomson
This patch set updates the driver to use generic device property & fwnode related functions to read in either DT and ACPI data for driver initialisation. Changes are based on v4.6-rc6 Linux Kernel. Adam Thomson (3): ASoC: da7219: Convert driver to use generic device/fwnode functions

RE: [RESEND PATCH v2 1/2] device property: Add function to search for named child of device

2016-06-10 Thread Opensource [Adam Thomson]
On 10 June 2016 00:11, Rafael J. Wysocki wrote: > For some reason that didn't make it into the linux-acpi list, or at > least I can't see it there. That's strange. I'm not a subscriber to that mailing list, but I assume that shouldn't matter here? Strangely though the only mailing list these seem

[PATCH 4/5] ASoC: da7213: Update PLL ranges to improve locking at frequency boundary

2016-05-10 Thread Adam Thomson
This update changes the dividers used for ranges of input MCLK frequencies, to improve PLL locking for a corner case when at edge of MCLK frequency input divider range. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 26 +- sound/soc/codecs/da7213.h | 28

[PATCH 1/5] ASoC: da7213: Add DAI DAPM event to control DAI clocks

2016-05-10 Thread Adam Thomson
Currently, when Codec is I2S master DAI clocks are continuously generated even if all audio streams have stopped. To improve efficiency, control of the DAI clocks for master mode have been moved to a DAPM widget event so they're only enabled as required. Signed-off-by: Adam Thomson ---

[PATCH 2/5] ASoC: da7213: Add checking of SRM lock status before enabling DAI

2016-05-10 Thread Adam Thomson
x27;t occur within a given time. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 23 +++ sound/soc/codecs/da7213.h | 4 2 files changed, 27 insertions(+) diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index 701bd62..680d111 100644 --- a/

[PATCH 5/5] ASoC: da7213: Allow PLL disable/bypass when using 32KHz sysclk

2016-05-10 Thread Adam Thomson
Current checking for PLL 32KHz mode fails in driver code when bypassing the PLL. This is due to an incorrect check of PLL source type when 32KHz clock is provided. Removal of this check resolves the issue. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 2 +- 1 file changed, 1

[PATCH 0/5] ASoC: da7213: clocking related improvements for codec

2016-05-10 Thread Adam Thomson
This is a collection of updates with regards to clocking on da7213 codec, including power efficiency & stability improvements. Patches are based on v4.6-rc7 kernel. Adam Thomson (5): ASoC: da7213: Add DAI DAPM event to control DAI clocks ASoC: da7213: Add checking of SRM lock status be

[PATCH 3/5] ASoC: da7213: Default PC counter to free-running when DAI disabled

2016-05-10 Thread Adam Thomson
Currently PC counter is always synchronised to DAI which means that when the DAI is disabled, features such as ALC calibration cannot be executed successfully. This patch makes sure that when the DAI is disabled, PC counter is set to free-running. Signed-off-by: Adam Thomson --- sound/soc

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-09 Thread Opensource [Adam Thomson]
On May 06, 2016, 17:06, Mark Brown wrote: > No, not really - your DT is fairly unusual in how it's done and the lack > of ACPI helpers is not a good sign on that side. The _DSD things are > really only supposed to work for simple properties on devices. It's unusual in that there's a child node (

RE: [PATCH 2/3] ASoC: da7219: Add ACPI parsing support

2016-05-06 Thread Opensource [Adam Thomson]
On May 06, 2016, 13:39, Mark Brown wrote: > > @@ -27,7 +28,6 @@ > > #include "da7219.h" > > #include "da7219-aad.h" > > > > - > > /* > > * Detection control > > */ > > Random whitespace change. Fair point. Will sort it. > > > static struct fwnode_handle *da7219_aad_of_named_fwhandle(st

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-06 Thread Opensource [Adam Thomson]
On May 06, 2016, 13:27, Mark Brown wrote: > > This change converts the driver from using the of_* functions to using > > the device_* and fwnode_* functions for accssing DT related data. > > This is in preparation for updates to support ACPI based initialisation. > > Is this *really* sensible? D

RE: linux-next: build failure after merge of the sound-asoc tree

2016-05-06 Thread Opensource [Adam Thomson]
On May 06, 2016, 13:03, Mark Brown wrote: > > This patch was the 3rd in of a set of 3, and the header you added below was > > added as part of the 2nd patch of that set, hence why it is missing here. I > > assume the first 2 patches are still being reviewed by Mark. > > Yes. The ID patch should

RE: linux-next: build failure after merge of the sound-asoc tree

2016-05-06 Thread Opensource [Adam Thomson]
On May 06, 2016, 01:58, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function > 'ACPI_PTR' [-Werror=implicit-function-declaration]

[PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-05 Thread Adam Thomson
This change converts the driver from using the of_* functions to using the device_* and fwnode_* functions for accssing DT related data. This is in preparation for updates to support ACPI based initialisation. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella --- sound/soc/codecs

[PATCH 0/3] ASoC: da7219: Add ACPI initialisation support to driver

2016-05-05 Thread Adam Thomson
This patch set updates the driver to use generic device property & fwnode related functions to read in either DT and ACPI data for driver initialisation. Changes are based on v4.6-rc6 Linux Kernel. Adam Thomson (3): ASoC: da7219: Convert driver to use generic device/fwnode functions

[PATCH 3/3] ASoC: da7219: Add initial ACPI id for device

2016-05-05 Thread Adam Thomson
This adds "DLGS7219" ACPI id for the codec. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella --- sound/soc/codecs/da7219.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index bc32322..da268b8 100644 --- a

[PATCH 2/3] ASoC: da7219: Add ACPI parsing support

2016-05-05 Thread Adam Thomson
This update allows for parsing of ACPI, in addition to existing DT support. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella --- sound/soc/codecs/da7219-aad.c | 32 sound/soc/codecs/da7219.c | 7 --- 2 files changed, 32 insertions(+), 7

[PATCH] ASoC: da7218: Update PLL ranges and dividers to improve locking

2016-04-22 Thread Adam Thomson
The expected MCLK frequency ranges and the associated dividers are updated to improve PLL locking in a corner scenario, with low MCLK frequency near an input divider change boundary. Signed-off-by: Adam Thomson --- This patch is based on v4.6-rc1 kernel version sound/soc/codecs/da7218.c | 32

[PATCH 1/2] ASoC: da7219: Update PLL ranges and dividers to improve locking

2016-04-19 Thread Adam Thomson
The expected MCLK frequency ranges and the associated dividers are updated to improve PLL locking in a corner scenario, with low MCLK frequency near an input divider change boundary. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219.c | 28 ++-- sound/soc/codecs

[PATCH 2/2] ASoC: da7219: Disallow unsupported 32KHz clock setting in set_dai_sysclk()

2016-04-19 Thread Adam Thomson
The PLL function was updated to disallow 32KHz in commit 501f72e9c520 ("ASoC: da7219: Remove support for 32KHz PLL mode"), but set_dai_sysclk() was missed and still permits it. This patch resolves that discrepancy. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219.c | 2 +- 1 fi

[PATCH 0/2] ASoC: da7219: Small clocking related updates for PLL and sysclk

2016-04-19 Thread Adam Thomson
set_dai_pll() function. Patches are based on v4.6-rc4 kernel version. Adam Thomson (2): ASoC: da7219: Update PLL ranges and dividers to improve locking ASoC: da7219: Disallow unsupported 32KHz clock setting in set_dai_sysclk() sound/soc/codecs/da7219.c | 30

RE: [PATCH] mfd: Allow i2c modular drivers to build with I2C=m

2016-01-21 Thread Opensource [Adam Thomson]
On January 21, 2016 00:50, Axel Lin wrote: > These drivers can be built as module, so make them depend on I2C rather > than I2C=y. > > Signed-off-by: Axel Lin For Dialog devices: Acked-by: Adam Thomson

[PATCH] ASoC: da7218: Correct BCLK inversion for DSP DAI format mode

2016-01-05 Thread Adam Thomson
By default the device latches data on the falling edge of the BCLK in DSP mode, whereas the expectation for normal BCLK is to latch on the rising edge. This updates the driver to invert the BCLK configuration for DSP mode, to align with expected behaviour. Signed-off-by: Adam Thomson --- This

[PATCH] ASoC: da7219: Correct BCLK inversion for DSP DAI format mode

2016-01-05 Thread Adam Thomson
By default the device latches data on the falling edge of the BCLK in DSP mode, whereas the expectation for normal BCLK is to latch on the rising edge. This updates the driver to invert the BCLK configuration for DSP mode, to align with expected behaviour. Signed-off-by: Adam Thomson --- This

[PATCH 1/1] ASoC: da7219: Add regmap patch to support old silicon

2015-12-23 Thread Adam Thomson
Initial silicon did not have master bias enabled by default, unlike later HW, so use regmap patch to align with newer defaults. Signed-off-by: Adam Thomson --- This patch is based on the following commit: 'ASoC: da7219: Remove support for 32KHz PLL mode

RE: [PATCH 3/6] ASoC: da7219: Update REFERENCES reg default, in-line with HW

2015-12-23 Thread Opensource [Adam Thomson]
On December 23, 2015 00:10, Mark Brown wrote: > On Tue, Dec 22, 2015 at 06:27:53PM +0000, Adam Thomson wrote: > > In current AB silicon, BIAS_EN field is enabled by default in the > > REFERENCES register, so the regmap default value should reflect > > this. > > This i

[PATCH 0/6] ASoC: da7219: AB Silicon related updates and small fixes.

2015-12-22 Thread Adam Thomson
This is a small collection of updates & fixes, put together for ease. For changes relating to AB silicon, previous silicon revision is obsolete and was unavailable outside of Dialog, so does not require driver support in the future. Changes are based on v4.4-rc6 kernel. Adam Thomson (6):

[PATCH 3/6] ASoC: da7219: Update REFERENCES reg default, in-line with HW

2015-12-22 Thread Adam Thomson
In current AB silicon, BIAS_EN field is enabled by default in the REFERENCES register, so the regmap default value should reflect this. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7219.c b/sound

[PATCH 5/6] ASoC: da7219: Add support for 1.6V micbias level

2015-12-22 Thread Adam Thomson
HW can provide 1.6V micbias level as well the existing levels already provided in the driver. This patch adds support for 1.6V to the DT binding. Signed-off-by: Adam Thomson --- Documentation/devicetree/bindings/sound/da7219.txt | 2 +- include/sound/da7219.h | 3

[PATCH 2/6] ASoC: da7219: Fix Sidetone to work regardless of DAI capture

2015-12-22 Thread Adam Thomson
Previously Sidetone would operate only when capture to DAI was in progress, due to DAPM path configuration. There is no reason why this should not operate without DAI capture, so this patch updates the DAPM path accordingly. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7219.c | 3 ++- 1

[PATCH 4/6] ASoC: da7219: Remove internal LDO features of codec

2015-12-22 Thread Adam Thomson
In AB silicon, the internal LDO is not supported so remove DT and driver references to this (digital voltage direct from 'VDD' supply) Signed-off-by: Adam Thomson --- Documentation/devicetree/bindings/sound/da7219.txt | 6 ++- include/sound/da7219.h

<    1   2   3   4   5   6   >