Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Adrian Bunk
On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: > [EMAIL PROTECTED] wrote: >> From: Randy Dunlap <[EMAIL PROTECTED]> >... > So I think the breakage that occurs is mitigated by two factors: > 1) kernel hackers that do their own configs are expected to be able to > figure this stuff. >

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Adrian Bunk
On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Randy Dunlap [EMAIL PROTECTED] ... So I think the breakage that occurs is mitigated by two factors: 1) kernel hackers that do their own configs are expected to be able to figure this stuff. 2) kernel

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-14 Thread Adrian Bunk
On Fri, Dec 14, 2007 at 06:17:55PM -0500, Jeff Garzik wrote: Adrian Bunk wrote: On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Randy Dunlap [EMAIL PROTECTED] ... So I think the breakage that occurs is mitigated by two factors: 1) kernel hackers

Re: [PATCH] tmpfs: restore missing clear_highpage

2007-12-14 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 05:01:51AM +, Hugh Dickins wrote: On Tue, 11 Dec 2007, Chuck Ebbert wrote: On 11/28/2007 01:55 PM, Hugh Dickins wrote: tmpfs was misconverted to __GFP_ZERO in 2.6.11. There's an unusual case in which shmem_getpage receives the page from its caller instead

Re: Print taint info in more places.

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 05:49:27PM -0500, Dave Jones wrote: > We've found in the past that various bug reports have had minimal > information, just a few printk's rather than a complete oops, > and it's taken several round-trips with the bug reporter before > we've discovered they had some

Re: RFC: remove __read_mostly

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 11:48:27PM +0100, Eric Dumazet wrote: > Adrian Bunk a écrit : >> I tried the following patch with a full x86 .config [1]: >> >> --- a/include/asm-x86/cache.h >> +++ b/include/asm-x86/cache.h >> -#define __read_mostly __attribute_

Re: RFC: remove __read_mostly

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 11:29:08PM +0100, Andi Kleen wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > > -rwxrwxr-x 1 bunk bunk 46607243 2007-12-13 19:50 vmlinux.old > > -rwxrwxr-x 1 bunk bunk 46598691 2007-12-13 21:55 vmlinux > > File sizes are useles

RFC: remove __read_mostly

2007-12-13 Thread Adrian Bunk
I tried the following patch with a full x86 .config [1]: --- a/include/asm-x86/cache.h +++ b/include/asm-x86/cache.h -#define __read_mostly __attribute__((__section__(".data.read_mostly"))) +/* #define __read_mostly __attribute__((__section__(".data.read_mostly"))) */ The result [2,3] was:

Working upstream toolchain for avr32?

2007-12-13 Thread Adrian Bunk
AFAIK the latest available AVR32 toolchains are some patched gcc 4.0 and some patched binutils 2.17, and avr32 is currently the only architecture in the kernel where upstream of both of them is not capable of building a kernel for the architecture. ALthough not technically a requirement, it

[2.6 patch] m68knommu: remove duplicate exports

2007-12-13 Thread Adrian Bunk
One EXPORT_SYMBOL should be enough for everyone. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Greg Ungerer <[EMAIL PROTECTED]> --- This patch has been sent on: - 29 Oct 2007 arch/m68knommu/kernel/m68k_ksyms.c | 11 --- 1 file changed,

[2.6 patch] Kconfig help: don't refer to the PCI-HOWTO

2007-12-13 Thread Adrian Bunk
A HOWTO that hasn't been updated for half a dozen years no longer "contains valuable information about which PCI hardware does work under Linux and which doesn't". Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/alpha/Kconfig |5 - arch/arm/Kconfig

[2.6 patch] x86: default to PCI=y

2007-12-13 Thread Adrian Bunk
PCI is one of the few hardware stuff where defaulting to y makes sense. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 753cd05e76043bb56edb30b2277be9f3e77ee0c4 diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 80b7ba4..2897cc0 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/K

Re: 2.6.24-rc5-mm1

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 05:07:44PM +0100, Borislav Petkov wrote: > On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote: > > The problem comes from the new macro UDPX_INC_STATS_BH introduced > > by Herbert, which was a nice addition to increment the correct > > UDP MIB depending on the

Re: Next patches for the 2.6.25 queue

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 09:46:42AM -0500, Mathieu Desnoyers wrote: > Hi Andrew, > > I would like to post my next patches in a way that would make it as > easy for you and the community to review them. Currently, the patches > that have really settled down are : > > * For 2.6.25 >... > -

Re: Next patches for the 2.6.25 queue

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 09:46:42AM -0500, Mathieu Desnoyers wrote: Hi Andrew, I would like to post my next patches in a way that would make it as easy for you and the community to review them. Currently, the patches that have really settled down are : * For 2.6.25 ... - Immediate Values

Re: 2.6.24-rc5-mm1

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 05:07:44PM +0100, Borislav Petkov wrote: On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote: The problem comes from the new macro UDPX_INC_STATS_BH introduced by Herbert, which was a nice addition to increment the correct UDP MIB depending on the socket

[2.6 patch] x86: default to PCI=y

2007-12-13 Thread Adrian Bunk
PCI is one of the few hardware stuff where defaulting to y makes sense. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 753cd05e76043bb56edb30b2277be9f3e77ee0c4 diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 80b7ba4..2897cc0 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig

[2.6 patch] Kconfig help: don't refer to the PCI-HOWTO

2007-12-13 Thread Adrian Bunk
A HOWTO that hasn't been updated for half a dozen years no longer contains valuable information about which PCI hardware does work under Linux and which doesn't. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/alpha/Kconfig |5 - arch/arm/Kconfig|5

[2.6 patch] m68knommu: remove duplicate exports

2007-12-13 Thread Adrian Bunk
One EXPORT_SYMBOL should be enough for everyone. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Greg Ungerer [EMAIL PROTECTED] --- This patch has been sent on: - 29 Oct 2007 arch/m68knommu/kernel/m68k_ksyms.c | 11 --- 1 file changed, 11 deletions

Working upstream toolchain for avr32?

2007-12-13 Thread Adrian Bunk
AFAIK the latest available AVR32 toolchains are some patched gcc 4.0 and some patched binutils 2.17, and avr32 is currently the only architecture in the kernel where upstream of both of them is not capable of building a kernel for the architecture. ALthough not technically a requirement, it

RFC: remove __read_mostly

2007-12-13 Thread Adrian Bunk
I tried the following patch with a full x86 .config [1]: --- a/include/asm-x86/cache.h +++ b/include/asm-x86/cache.h -#define __read_mostly __attribute__((__section__(.data.read_mostly))) +/* #define __read_mostly __attribute__((__section__(.data.read_mostly))) */ The result [2,3] was:

Re: RFC: remove __read_mostly

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 11:29:08PM +0100, Andi Kleen wrote: Adrian Bunk [EMAIL PROTECTED] writes: -rwxrwxr-x 1 bunk bunk 46607243 2007-12-13 19:50 vmlinux.old -rwxrwxr-x 1 bunk bunk 46598691 2007-12-13 21:55 vmlinux File sizes are useless -- check size output. textdata bss

Re: RFC: remove __read_mostly

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 11:48:27PM +0100, Eric Dumazet wrote: Adrian Bunk a écrit : I tried the following patch with a full x86 .config [1]: --- a/include/asm-x86/cache.h +++ b/include/asm-x86/cache.h -#define __read_mostly __attribute__((__section__(.data.read_mostly))) +/* #define

Re: Print taint info in more places.

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 05:49:27PM -0500, Dave Jones wrote: We've found in the past that various bug reports have had minimal information, just a few printk's rather than a complete oops, and it's taken several round-trips with the bug reporter before we've discovered they had some proprietary

[2.6 patch] make __videobuf_read_start() static

2007-12-12 Thread Adrian Bunk
__videobuf_read_start() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- bd6ebe6d1cef48341d124d47ecaab4fff96a59a8 diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c index c8a5cb5..4e39a11 100644 --- a/drivers/media/video/videobuf-

[2.6 patch] videobuf-core.c locking fixes

2007-12-12 Thread Adrian Bunk
ng, does the patch below fix it? > Shane cu Adrian <-- snip --> After commit 19fb1457990b6b7e15586ec7331541a184233acc the callers in videobuf-core.c that already hold the lock must call __videobuf_read_start() instead of videobuf_read_start(). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

[2.6 patch] drivers/media/Makefile: always enter video/

2007-12-12 Thread Adrian Bunk
e patch below instead that fixes the actual bug instead of working around it? > Cheers, > Mauro cu Adrian <-- snip --> Since not all code under drivers/media/video/ depends on CONFIG_VIDEO_DEV we cannot only enter it depending on CONFIG_VIDEO_DEV. Signed-off-by: Adrian Bunk <[EM

Re: [v4l-dvb-maintainer] build #340 failed for 2.6.24-rc5-g75b8c13 in?linux/drivers/media/video/tuner.ko

2007-12-12 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 11:00:46AM -0500, [EMAIL PROTECTED] wrote: > Mauro Carvalho Chehab wrote: >... > What we really need is to make the Kconfig selection behave as if it > depends on VIDEO_TUNER, but only if VIDEO_TUNER is selected. I know > that sounds redundant, but that would actually

[2.6 patch] let elv_register() return void

2007-12-12 Thread Adrian Bunk
elv_register() always returns 0, and there isn't anything it does where it should return an error (the only error condition is so grave that it's handled with a BUG_ON). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- block/as-iosched.c |4 +++- block/cfq-iosched.c

Re: [PATCH 00/47] CRIS patches for CRISv32 EtraxFS and ARTPEC-3

2007-12-12 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 02:52:12AM -0800, Andrew Morton wrote: > On Thu, 29 Nov 2007 17:02:22 +0100 Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > This patchset contains the differences to add support for the EtraxFS and > > ARTPEC-3 CPUs, both of the CRISv32 family. Both chips can

Re: 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined!

2007-12-12 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 09:03:14AM -0200, Mauro Carvalho Chehab wrote: >... > I'm afraid that this wouldn't avoid this bug, however. > > The removal of the EXPORT_SYMBOL_GPL seemed to be the intention of > Brandon, since he renamed the function, removing the locks. I think he > didn't noticed

Re: 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined!

2007-12-12 Thread Adrian Bunk
Patch looks good, it seems a merge conflict of commit 19bc5133dae9562e8824ef101464061f9854c1d8 was resolved the wrong way. @Mauro: Any objections against a later path that changes the exports to the general "immediately after the function" convention? It would have avoided at least two such bugs

Re: 2.6.24-rc5 videobuf_read_start [drivers/media/video/videobuf-dvb.ko] undefined!

2007-12-12 Thread Adrian Bunk
Patch looks good, it seems a merge conflict of commit 19bc5133dae9562e8824ef101464061f9854c1d8 was resolved the wrong way. @Mauro: Any objections against a later path that changes the exports to the general immediately after the function convention? It would have avoided at least two such bugs

Re: 2.6.24-rc5 videobuf_read_start [drivers/media/video/videobuf-dvb.ko] undefined!

2007-12-12 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 09:03:14AM -0200, Mauro Carvalho Chehab wrote: ... I'm afraid that this wouldn't avoid this bug, however. The removal of the EXPORT_SYMBOL_GPL seemed to be the intention of Brandon, since he renamed the function, removing the locks. I think he didn't noticed that

Re: [PATCH 00/47] CRIS patches for CRISv32 EtraxFS and ARTPEC-3

2007-12-12 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 02:52:12AM -0800, Andrew Morton wrote: On Thu, 29 Nov 2007 17:02:22 +0100 Jesper Nilsson [EMAIL PROTECTED] wrote: Hi, This patchset contains the differences to add support for the EtraxFS and ARTPEC-3 CPUs, both of the CRISv32 family. Both chips can now be

Re: [v4l-dvb-maintainer] build #340 failed for 2.6.24-rc5-g75b8c13 in?linux/drivers/media/video/tuner.ko

2007-12-12 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 11:00:46AM -0500, [EMAIL PROTECTED] wrote: Mauro Carvalho Chehab wrote: ... What we really need is to make the Kconfig selection behave as if it depends on VIDEO_TUNER, but only if VIDEO_TUNER is selected. I know that sounds redundant, but that would actually solve

[2.6 patch] let elv_register() return void

2007-12-12 Thread Adrian Bunk
elv_register() always returns 0, and there isn't anything it does where it should return an error (the only error condition is so grave that it's handled with a BUG_ON). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- block/as-iosched.c |4 +++- block/cfq-iosched.c |8

[2.6 patch] drivers/media/Makefile: always enter video/

2007-12-12 Thread Adrian Bunk
on CONFIG_VIDEO_DEV. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 9c315b376729908cbdde8adaea0d7bc0a47a2c36 diff --git a/drivers/media/Makefile b/drivers/media/Makefile index 8fa1993..8cf9135 100644 --- a/drivers/media/Makefile +++ b/drivers/media/Makefile @@ -3,6 +3,6 @@ # obj-y := common/ -obj

[2.6 patch] videobuf-core.c locking fixes

2007-12-12 Thread Adrian Bunk
19fb1457990b6b7e15586ec7331541a184233acc the callers in videobuf-core.c that already hold the lock must call __videobuf_read_start() instead of videobuf_read_start(). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/media/video/videobuf-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[2.6 patch] make __videobuf_read_start() static

2007-12-12 Thread Adrian Bunk
__videobuf_read_start() can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- bd6ebe6d1cef48341d124d47ecaab4fff96a59a8 diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c index c8a5cb5..4e39a11 100644 --- a/drivers/media/video/videobuf-core.c

Re: [2.6 patch] drivers/pci/msi.c: move arch hooks to the top

2007-12-11 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 09:44:10AM +1100, Michael Ellerman wrote: > On Tue, 2007-12-11 at 23:19 +0100, Adrian Bunk wrote: > > This patch fixes the following problem present with older gcc versions: > > > > <-- snip --> > > > > ... > > CC driv

[2.6 patch] scsi/aic94xx/: cleanups

2007-12-11 Thread Adrian Bunk
On Mon, Nov 05, 2007 at 11:43:35AM -0800, Darrick J. Wong wrote: > On Mon, Nov 05, 2007 at 06:07:29PM +0100, Adrian Bunk wrote: > > This patch contains the following cleanups: > > - static functions in .c files shouldn't be marked inline > > - make needlessly global code stat

[2.6 patch] drivers/scsi/aic94xx/ section fixes

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.init.text.20+0xb3061): Section mismatch: reference to .exit.text:asd_unmap_ha (between 'asd_pci_probe' and 'ips_insert_device') ... <-- snip --> Signed-off-by: Adrian

[2.6 patch] drivers/scsi/advansys.c section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.exit.text+0xcf8a): Section mismatch: reference to .init.data:_asc_def_iop_base (between 'advansys_isa_remove' and 'exit_this_scsi_driver') ... <-- snip --> Signed-of

[2.6 patch] drivers/net/sis190.c section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to .exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom') ... <-- snip --> Signed-off-by: Adrian

[2.6 patch] drivers/media/video/ivtv/ section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.text+0x94f07b): Section mismatch: reference to .init.text.20:init_ivtv_i2c (between 'ivtv_process_eeprom' and 'ivtv_init_on_first_open') ... <-- snip --> Signed-off-by:

[2.6 patch] scsi/megaraid.c: __devexit annotation

2007-12-11 Thread Adrian Bunk
megaraid_remove_one() can become __devexit. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- b7d71f38d1c1aa66311e862b58f36aa34c888f98 diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 66c6520..765c24d 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/mega

[2.6 patch] drivers/media/video/bt8xx/ section fixes

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.text+0x881632): Section mismatch: reference to .init.text.20:bttv_check_chipset (between 'bttv_init_module' and 'bttv_cleanup_module') ... <-- snip --> Signed-off-by:

[2.6 patch] kernel/timer.c section fixes

2007-12-11 Thread Adrian Bunk
(.text+0x41d67): Section mismatch: reference to .init.data:tvec_base_done.22610 (between 'timer_cpu_notify' and 'run_timer_softirq') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 5898f1ca82c5a536b65b3ee26099b67316549664 diff --git a/kernel/timer.c b/kernel/tim

[2.6 patch] drivers/net/s2io.c section fixes

2007-12-11 Thread Adrian Bunk
l_sset') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/s2io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 50fb761b99d7ee0b234359d02144f84a87e2faff diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 121cb10..9d80f1c 10

[2.6 patch] x86 apic_32.c section fix

2007-12-11 Thread Adrian Bunk
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- ffa2f7f7e1cb68073b9ad597414dfd792ab5c697 diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c index 96986b4..edb5108 100644 --- a/arch/x86/kernel/apic_32.c +++ b/arch/x86/kernel/apic_32.c @@ -849,7 +849,7 @@ void __init

[2.6 patch] idle_regs() must be __cpuinit

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n, CONFIG_HOTPLUG_CPU=y: <-- snip --> ... WARNING: vmlinux.o(.text+0x399a6): Section mismatch: reference to .init.text.5:idle_regs (between 'fork_idle' and 'get_task_mm') ... <-- snip --> Signed-off-by:

[2.6 patch] x86_32: select_idle_routine() must be __cpuinit

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n, CONFIG_HOTPLUG_CPU=y: <-- snip --> ... WARNING: vmlinux.o(.text+0x1199a): Section mismatch: reference to .init.text.5:select_idle_routine (between 'init_intel' and 'init_nexgen') ... <-- snip --> Signed-of

[2.6 patch] x86 smpboot_32.c section fixes

2007-12-11 Thread Adrian Bunk
smatch: reference to .init.data:smp_b_stepping (between 'smp_store_cpu_info' and 'cpu_exit_clear') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/x86/kernel/smpboot_32.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) b031bee4469bf6e7590601

[2.6 patch] x86_32: disable_pse must be __cpuinitdata

2007-12-11 Thread Adrian Bunk
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 4cd9e8dd188db19d1ef697beb1fceb2ae67294a1 diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c index e1e18c3..9c24b45 100644 --- a/arch/x86/kernel/setup_32.c +++ b/arch/x86/kernel/setup_32.c @@ -67,7 +67,7 @@ address, and must

[2.6 patch] calibrate_delay() must be __cpuinit

2007-12-11 Thread Adrian Bunk
text.1:calibrate_delay (between 'smp_callin' and 'cpu_coregroup_map') ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/alpha/kernel/smp.c |4 arch/frv/kernel/setup.c |2 +- arch/ia64/kernel/smpboot.c

Re: [PATCH] tmpfs: restore missing clear_highpage

2007-12-11 Thread Adrian Bunk
On Wed, Nov 28, 2007 at 06:55:10PM +, Hugh Dickins wrote: > tmpfs was misconverted to __GFP_ZERO in 2.6.11. There's an unusual case in > which shmem_getpage receives the page from its caller instead of allocating. > We must cover this case by clear_highpage before SetPageUptodate, as before.

[2.6 patch] #if 0 pci_cleanup_aer_correct_error_status()

2007-12-11 Thread Adrian Bunk
This patch #if 0's the no longer used pci_cleanup_aer_correct_error_status(). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/pci/pcie/aer/aerdrv_core.c |3 ++- include/linux/aer.h|5 - 2 files changed, 2 insertions(+), 6 del

[2.6 patch] drivers/video/pm3fb.c section fix

2007-12-11 Thread Adrian Bunk
smatch: reference to .init.data: (between 'pm3fb_size_memory' and 'update_crtc2') WARNING: vmlinux.o(.text+0x46e5c7): Section mismatch: reference to .init.data: (between 'pm3fb_size_memory' and 'update_crtc2') ... <-- snip --> Signed-off-by: Adrian Bunk <[

[2.6 patch] fs/nfs/direct.c: remove dead code

2007-12-11 Thread Adrian Bunk
This code became dead after commit b9148c6b80d802dbc2a7530b29915a80432e50c7 (which BTW doesn't seem to have changed any behaviour) and can therefore be removed. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6/fs/nfs/direct.c.old 2

[2.6 patch] xen: fiddle_vdso() must be __init

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch: <-- snip --> ... WARNING: vmlinux.o(.text+0x2589): Section mismatch: reference to .init.data:vsyscall_int80_start (between 'fiddle_vdso' and 'xen_setup_features') ... <-- snip --> Signed-off-by: Adrian Bunk <[

scsi/lpfc/lpfc_attr.c: bogus code

2007-12-11 Thread Adrian Bunk
Commit 2e0fef85e098f6794956b8b80b79fbb4cbb7 added the folowing code to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be dead code: <-- snip --> ... lpfc_state_show(struct class_device *cdev, char *buf) { ... switch (vport->port_state) {

[2.6 patch] drivers/net/ipg.c: add __devexit annotation

2007-12-11 Thread Adrian Bunk
ipg_remove() can become __devexit. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 97ace7a0e52ceac30caae20e1a3fe72c4644bce7 diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd23bb..285ebbc 100644 --- a/drivers/net/ipg.c +++ b/drivers/net/ipg.c @@ -2214,7 +2214,7 @@ static

[2.6 patch] wireless/ipw2200.c: add __dev{init,exit} annotations

2007-12-11 Thread Adrian Bunk
This patch adds __dev{init,exit} annotations. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/ipw2200.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) dc37213e10799b6613c322c775923f070c8d5d9b diff --git a/drivers/net/wireless/ipw2200.c b/drive

[2.6 patch] crypto/geode-aes.c: add __dev{init,exit} annotations

2007-12-11 Thread Adrian Bunk
This patch adds __dev{init,exit} annotations. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/crypto/geode-aes.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 9a5ecd183293da27ad66241b51c93bea0634df55 diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto

[2.6 patch] drivers/pci/msi.c: move arch hooks to the top

2007-12-11 Thread Adrian Bunk
esults in unspecified behavior ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/pci/msi.c | 91 ++ 1 file changed, 45 insertions(+), 46 deletions(-) 6b61f9979425bec016aefdddfd415f6fa5240b67 diff --git a/d

[2.6 patch] drivers/pci/msi.c: move arch hooks to the top

2007-12-11 Thread Adrian Bunk
in unspecified behavior ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/pci/msi.c | 91 ++ 1 file changed, 45 insertions(+), 46 deletions(-) 6b61f9979425bec016aefdddfd415f6fa5240b67 diff --git a/drivers/pci/msi.c b

[2.6 patch] crypto/geode-aes.c: add __dev{init,exit} annotations

2007-12-11 Thread Adrian Bunk
This patch adds __dev{init,exit} annotations. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/crypto/geode-aes.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 9a5ecd183293da27ad66241b51c93bea0634df55 diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c

[2.6 patch] wireless/ipw2200.c: add __dev{init,exit} annotations

2007-12-11 Thread Adrian Bunk
This patch adds __dev{init,exit} annotations. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) dc37213e10799b6613c322c775923f070c8d5d9b diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net

[2.6 patch] drivers/net/ipg.c: add __devexit annotation

2007-12-11 Thread Adrian Bunk
ipg_remove() can become __devexit. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 97ace7a0e52ceac30caae20e1a3fe72c4644bce7 diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd23bb..285ebbc 100644 --- a/drivers/net/ipg.c +++ b/drivers/net/ipg.c @@ -2214,7 +2214,7 @@ static struct

scsi/lpfc/lpfc_attr.c: bogus code

2007-12-11 Thread Adrian Bunk
Commit 2e0fef85e098f6794956b8b80b79fbb4cbb7 added the folowing code to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be dead code: -- snip -- ... lpfc_state_show(struct class_device *cdev, char *buf) { ... switch (vport-port_state) {

[2.6 patch] fs/nfs/direct.c: remove dead code

2007-12-11 Thread Adrian Bunk
This code became dead after commit b9148c6b80d802dbc2a7530b29915a80432e50c7 (which BTW doesn't seem to have changed any behaviour) and can therefore be removed. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6/fs/nfs/direct.c.old 2007-12-02

[2.6 patch] xen: fiddle_vdso() must be __init

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch: -- snip -- ... WARNING: vmlinux.o(.text+0x2589): Section mismatch: reference to .init.data:vsyscall_int80_start (between 'fiddle_vdso' and 'xen_setup_features') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[2.6 patch] drivers/video/pm3fb.c section fix

2007-12-11 Thread Adrian Bunk
: reference to .init.data: (between 'pm3fb_size_memory' and 'update_crtc2') WARNING: vmlinux.o(.text+0x46e5c7): Section mismatch: reference to .init.data: (between 'pm3fb_size_memory' and 'update_crtc2') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[2.6 patch] #if 0 pci_cleanup_aer_correct_error_status()

2007-12-11 Thread Adrian Bunk
This patch #if 0's the no longer used pci_cleanup_aer_correct_error_status(). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/pci/pcie/aer/aerdrv_core.c |3 ++- include/linux/aer.h|5 - 2 files changed, 2 insertions(+), 6 deletions

Re: [PATCH] tmpfs: restore missing clear_highpage

2007-12-11 Thread Adrian Bunk
On Wed, Nov 28, 2007 at 06:55:10PM +, Hugh Dickins wrote: tmpfs was misconverted to __GFP_ZERO in 2.6.11. There's an unusual case in which shmem_getpage receives the page from its caller instead of allocating. We must cover this case by clear_highpage before SetPageUptodate, as before.

[2.6 patch] calibrate_delay() must be __cpuinit

2007-12-11 Thread Adrian Bunk
to .init.text.1:calibrate_delay (between 'smp_callin' and 'cpu_coregroup_map') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/alpha/kernel/smp.c |4 arch/frv/kernel/setup.c |2 +- arch/ia64/kernel/smpboot.c

[2.6 patch] x86_32: disable_pse must be __cpuinitdata

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n, CONFIG_HOTPLUG_CPU=y: -- snip -- ... WARNING: vmlinux.o(.text+0xfa52): Section mismatch: reference to .init.data:disable_pse (between 'identify_cpu' and 'identify_secondary_cpu') ... -- snip -- Signed-off-by: Adrian

[2.6 patch] x86_32: select_idle_routine() must be __cpuinit

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n, CONFIG_HOTPLUG_CPU=y: -- snip -- ... WARNING: vmlinux.o(.text+0x1199a): Section mismatch: reference to .init.text.5:select_idle_routine (between 'init_intel' and 'init_nexgen') ... -- snip -- Signed-off-by: Adrian Bunk

[2.6 patch] x86 smpboot_32.c section fixes

2007-12-11 Thread Adrian Bunk
: reference to .init.data:smp_b_stepping (between 'smp_store_cpu_info' and 'cpu_exit_clear') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- arch/x86/kernel/smpboot_32.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) b031bee4469bf6e7590601c70d6e5b662667b6b1 diff

[2.6 patch] x86 apic_32.c section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n, CONFIG_HOTPLUG_CPU=y: -- snip -- ... WARNING: vmlinux.o(.text+0x2390d): Section mismatch: reference to .init.text.5:setup_local_APIC (between 'start_secondary' and 'check_tsc_warp') ... -- snip -- Signed-off-by: Adrian

[2.6 patch] idle_regs() must be __cpuinit

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n, CONFIG_HOTPLUG_CPU=y: -- snip -- ... WARNING: vmlinux.o(.text+0x399a6): Section mismatch: reference to .init.text.5:idle_regs (between 'fork_idle' and 'get_task_mm') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

[2.6 patch] kernel/timer.c section fixes

2007-12-11 Thread Adrian Bunk
+0x41d67): Section mismatch: reference to .init.data:tvec_base_done.22610 (between 'timer_cpu_notify' and 'run_timer_softirq') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 5898f1ca82c5a536b65b3ee26099b67316549664 diff --git a/kernel/timer.c b/kernel/timer.c index a05817c..d4527dc

[2.6 patch] drivers/net/s2io.c section fixes

2007-12-11 Thread Adrian Bunk
') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/s2io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 50fb761b99d7ee0b234359d02144f84a87e2faff diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 121cb10..9d80f1c 100644 --- a/drivers/net

[2.6 patch] scsi/megaraid.c: __devexit annotation

2007-12-11 Thread Adrian Bunk
megaraid_remove_one() can become __devexit. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- b7d71f38d1c1aa66311e862b58f36aa34c888f98 diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 66c6520..765c24d 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c

[2.6 patch] drivers/media/video/bt8xx/ section fixes

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.text+0x881632): Section mismatch: reference to .init.text.20:bttv_check_chipset (between 'bttv_init_module' and 'bttv_cleanup_module') ... -- snip -- Signed-off-by: Adrian Bunk

[2.6 patch] drivers/media/video/ivtv/ section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.text+0x94f07b): Section mismatch: reference to .init.text.20:init_ivtv_i2c (between 'ivtv_process_eeprom' and 'ivtv_init_on_first_open') ... -- snip -- Signed-off-by: Adrian Bunk

[2.6 patch] drivers/scsi/advansys.c section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.exit.text+0xcf8a): Section mismatch: reference to .init.data:_asc_def_iop_base (between 'advansys_isa_remove' and 'exit_this_scsi_driver') ... -- snip -- Signed-off-by: Adrian Bunk

[2.6 patch] drivers/net/sis190.c section fix

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to .exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

[2.6 patch] drivers/scsi/aic94xx/ section fixes

2007-12-11 Thread Adrian Bunk
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.init.text.20+0xb3061): Section mismatch: reference to .exit.text:asd_unmap_ha (between 'asd_pci_probe' and 'ips_insert_device') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

[2.6 patch] scsi/aic94xx/: cleanups

2007-12-11 Thread Adrian Bunk
On Mon, Nov 05, 2007 at 11:43:35AM -0800, Darrick J. Wong wrote: On Mon, Nov 05, 2007 at 06:07:29PM +0100, Adrian Bunk wrote: This patch contains the following cleanups: - static functions in .c files shouldn't be marked inline - make needlessly global code static - #if 0 unused code

Re: [2.6 patch] drivers/pci/msi.c: move arch hooks to the top

2007-12-11 Thread Adrian Bunk
On Wed, Dec 12, 2007 at 09:44:10AM +1100, Michael Ellerman wrote: On Tue, 2007-12-11 at 23:19 +0100, Adrian Bunk wrote: This patch fixes the following problem present with older gcc versions: -- snip -- ... CC drivers/pci/msi.o /home/bunk/linux/kernel-2.6/git/linux-2.6

Re: Correct types for mod_devicetable.h (was: Re: m68k build failure)

2007-12-10 Thread Adrian Bunk
On Sun, Dec 09, 2007 at 06:08:18PM +0100, Pierre Ossman wrote: > On Sun, 2 Dec 2007 12:22:31 +0100 (CET) > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > > > I gave it a try: > > - Remove existing alignment attributes from some device_id types > > - Introduce kernel_* types with proper

Re: [PATCH 33/42] MM: extern for drop_pagecache_sb

2007-12-10 Thread Adrian Bunk
On Sun, Dec 09, 2007 at 09:42:06PM -0500, Erez Zadok wrote: > Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> > --- > include/linux/mm.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 1b7b95c..fc61bd3 100644 > ---

Re: [PATCH 33/42] MM: extern for drop_pagecache_sb

2007-12-10 Thread Adrian Bunk
On Sun, Dec 09, 2007 at 09:42:06PM -0500, Erez Zadok wrote: Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/mm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 1b7b95c..fc61bd3 100644 ---

Re: Correct types for mod_devicetable.h (was: Re: m68k build failure)

2007-12-10 Thread Adrian Bunk
On Sun, Dec 09, 2007 at 06:08:18PM +0100, Pierre Ossman wrote: On Sun, 2 Dec 2007 12:22:31 +0100 (CET) Geert Uytterhoeven [EMAIL PROTECTED] wrote: I gave it a try: - Remove existing alignment attributes from some device_id types - Introduce kernel_* types with proper size and

Re: [lm-sensors] 2.6.24-rc4 hwmon it87 probe fails

2007-12-09 Thread Adrian Bunk
On Sun, Dec 09, 2007 at 04:12:25PM -0500, Elvis Pranskevichus wrote: > Jean Delvare wrote: > > > Hi Mike, > > > > On Sat, 8 Dec 2007 21:22:34 -0500, Mike Houston wrote: > >> On Sun, 9 Dec 2007 01:05:54 +0100 > >> Adrian Bunk <[EMAIL PROTECTED]> w

Re: [lm-sensors] 2.6.24-rc4 hwmon it87 probe fails

2007-12-09 Thread Adrian Bunk
On Sun, Dec 09, 2007 at 04:12:25PM -0500, Elvis Pranskevichus wrote: Jean Delvare wrote: Hi Mike, On Sat, 8 Dec 2007 21:22:34 -0500, Mike Houston wrote: On Sun, 9 Dec 2007 01:05:54 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: On Tue, Dec 04, 2007 at 09:51:54PM -0500, Mike Houston

Re: 2.6.24-rc4 hwmon it87 probe fails

2007-12-08 Thread Adrian Bunk
On Tue, Dec 04, 2007 at 09:51:54PM -0500, Mike Houston wrote: > I finally got around to testing Linux 2.6.24 (2.6.24-rc4) and found > that the it87 driver fails to probe and consequently, my sensors no > longer work. This was fine with Linux 2.6.23.8 (the last kernel I was > using) > > The

Re: Why does reading from /dev/urandom deplete entropy so much?

2007-12-08 Thread Adrian Bunk
On Thu, Dec 06, 2007 at 02:32:05PM -0500, Bill Davidsen wrote: >... > Sounds like a local DoS attack point to me... As long as /dev/random is readable for all users there's no reason to use /dev/urandom for a local DoS... cu Adrian -- "Is there not promise of rain?" Ling Tan asked

<    6   7   8   9   10   11   12   13   14   15   >