2014/1/16 Konrad Rzeszutek Wilk konrad.w...@oracle.com:
On Tue, Jan 14, 2014 at 11:13:46PM +0900, Akinobu Mita wrote:
Calling dma_alloc_coherent() with __GFP_ZERO must return zeroed memory.
But when the contiguous memory allocator (CMA) is enabled on x86 and
the memory region is allocated
()
is used as a fallback.
Cc: Marek Szyprowski
Cc: Konrad Rzeszutek Wilk
Cc: David Woodhouse
Cc: Don Dutile
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: Andi Kleen
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita
---
No c
().
Cc: Marek Szyprowski
Cc: Konrad Rzeszutek Wilk
Cc: David Woodhouse
Cc: Don Dutile
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: Andi Kleen
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita
Acked-by: Marek Szyprowski
---
No c
"H. Peter Anvin"
Cc: Andi Kleen
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita
---
New patch from this version
Documentation/kernel-parameters.txt | 7 +--
drivers/base/dma-contiguous.c | 42 -
include/linux/dm
Molnar
Cc: "H. Peter Anvin"
Cc: Andi Kleen
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita
---
New patch from this version
include/linux/memblock.h | 2 ++
mm/memblock.c| 27 ---
2 files changed, 22 insert
Rzeszutek Wilk
Cc: David Woodhouse
Cc: Don Dutile
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: Andi Kleen
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita
---
New patch from this version
arch/x86/kernel/pci-dma.c | 3 +--
1 file
or
example, CMA allocates memory below 4GB by "cma=64M@0-4G", it is
required for the devices only supporting 32-bit addressing on 64-bit
systems without iommu.
* Changes from v1
- fix dma_alloc_coherent() with __GFP_ZERO
- add placement specifier for "cma=" kernel parameter
, CMA allocates memory below 4GB by cma=64M@0-4G, it is
required for the devices only supporting 32-bit addressing on 64-bit
systems without iommu.
* Changes from v1
- fix dma_alloc_coherent() with __GFP_ZERO
- add placement specifier for cma= kernel parameter
Akinobu Mita (5):
x86: make
...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
---
New patch from this version
arch/x86/kernel/pci-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c
index 872079a..9644405 100644
...@infradead.org
Cc: Don Dutile ddut...@redhat.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Andi Kleen a...@firstfloor.org
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Andi Kleen a...@firstfloor.org
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
---
New patch from this version
Documentation/kernel
a...@firstfloor.org
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Acked-by: Marek Szyprowski m.szyprow...@samsung.com
---
No change from the previous version
arch/x86/Kconfig | 2 +-
arch/x86/include/asm/swiotlb.h | 7
: Andi Kleen a...@firstfloor.org
Cc: x...@kernel.org
Cc: io...@lists.linux-foundation.org
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
---
No change from the previous version
drivers/iommu/intel-iommu.c | 32
1 file changed, 24 insertions(+), 8 deletions
contiguous memory with
dma_alloc_coherent() and tell the base address to the device that
requires it. This is why I need this change.
Akinobu Mita (2):
x86: enable DMA CMA with swiotlb
intel-iommu: integrate DMA CMA
arch/x86/Kconfig | 2 +-
arch/x86/include/asm/swiotlb.h | 7
()
is used as a fallback.
Cc: Marek Szyprowski
Cc: David Woodhouse
Cc: io...@lists.linux-foundation.org
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Signed-off-by: Akinobu Mita
---
drivers/iommu/intel-iommu.c | 32
1 fi
().
Cc: Marek Szyprowski
Cc: Konrad Rzeszutek Wilk
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Cc: Andi Kleen
Signed-off-by: Akinobu Mita
Acked-by: Marek Szyprowski
---
No change from the previous version
arch/x86/Kconfig | 2 +-
()
is used as a fallback.
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: David Woodhouse dw...@infradead.org
Cc: io...@lists.linux-foundation.org
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: x...@kernel.org
Signed-off-by: Akinobu Mita
().
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: x...@kernel.org
Cc: Andi Kleen a...@firstfloor.org
Signed-off-by: Akinobu Mita akinobu.m
contiguous memory with
dma_alloc_coherent() and tell the base address to the device that
requires it. This is why I need this change.
Akinobu Mita (2):
x86: enable DMA CMA with swiotlb
intel-iommu: integrate DMA CMA
arch/x86/Kconfig | 2 +-
arch/x86/include/asm/swiotlb.h | 7
2013/11/23 H. Peter Anvin :
> On 11/22/2013 04:27 AM, Akinobu Mita wrote:
>>
>> I'm currently working for integrating DMA CMA with intel-iommu which
>> I can test. Regardless of which dma ops is actually used, I would
>> like to allocate large contiguous mem
2013/11/23 H. Peter Anvin h...@zytor.com:
On 11/22/2013 04:27 AM, Akinobu Mita wrote:
I'm currently working for integrating DMA CMA with intel-iommu which
I can test. Regardless of which dma ops is actually used, I would
like to allocate large contiguous memory with dma_alloc_coherent
2013/11/22 H. Peter Anvin :
> On 11/21/2013 07:02 AM, Akinobu Mita wrote:
>>
>> I want to use DMA CMA for the feature that requires a single huge chunk
>> (about 64MB) of host memory.
>
> That is tautological. "I want to use the Contiguous Memory Allocator
2013/11/22 H. Peter Anvin h...@zytor.com:
On 11/21/2013 07:02 AM, Akinobu Mita wrote:
I want to use DMA CMA for the feature that requires a single huge chunk
(about 64MB) of host memory.
That is tautological. I want to use the Contiguous Memory Allocator to
allocate contiguous memory
2013/11/20 Konrad Rzeszutek Wilk :
> On Wed, Nov 20, 2013 at 08:32:19AM +0900, Akinobu Mita wrote:
>> The DMA Contiguous Memory Allocator support on x86 is disabled when
>> swiotlb config option is enabled. So DMA CMA is always disabled on
>> x86_64 because swio
2013/11/20 Konrad Rzeszutek Wilk konrad.w...@oracle.com:
On Wed, Nov 20, 2013 at 08:32:19AM +0900, Akinobu Mita wrote:
The DMA Contiguous Memory Allocator support on x86 is disabled when
swiotlb config option is enabled. So DMA CMA is always disabled on
x86_64 because swiotlb is always
2013/11/19 Jens Axboe :
> On 11/18/2013 06:11 AM, Akinobu Mita wrote:
>> The data type of max_sectors and max_hw_sectors in queue settings are
>> unsigned int. But these values are passed to __bio_add_page() as an
>> argument whose data type is unsigned shor
The data type of max_sectors in queue settings is unsigned int. But
this value is stored to the local variable whose type is unsigned short
in bio_size_ok(). This can cause unexpected result when max_sectors >
0x.
Cc: Chris Mason
Cc: linux-bt...@vger.kernel.org
Signed-off-by: Akinobu M
Axboe
Cc: Alexander Viro
Signed-off-by: Akinobu Mita
---
fs/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bio.c b/fs/bio.c
index 2bdb4e2..33d79a4 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -601,7 +601,7 @@ EXPORT_SYMBOL(bio_get_nr_vecs);
static int __bio_add_page
Axboe ax...@kernel.dk
Cc: Alexander Viro v...@zeniv.linux.org.uk
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
---
fs/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bio.c b/fs/bio.c
index 2bdb4e2..33d79a4 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -601,7 +601,7
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
---
This patch is only compile tested.
fs/btrfs/volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 0db6370..92303f4 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
2013/11/19 Jens Axboe ax...@kernel.dk:
On 11/18/2013 06:11 AM, Akinobu Mita wrote:
The data type of max_sectors and max_hw_sectors in queue settings are
unsigned int. But these values are passed to __bio_add_page() as an
argument whose data type is unsigned short. In the worst case
2013/9/20 Paul Bolle :
> On Thu, 2013-08-22 at 23:49 +0900, Akinobu Mita wrote:
>> 2013/8/22 James Bottomley :
>> > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote:
>> >> Unfortunately, this warning isn't fixed in linux-next, either.
>> >> Paul B
2013/9/20 Paul Bolle pebo...@tiscali.nl:
On Thu, 2013-08-22 at 23:49 +0900, Akinobu Mita wrote:
2013/8/22 James Bottomley jbottom...@parallels.com:
On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote:
Unfortunately, this warning isn't fixed in linux-next, either.
Paul Bolle also sent
2013/8/22 James Bottomley :
> On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote:
>> 2013/8/22 Martin K. Petersen :
>> >>>>>> "Joe" == Joe Perches writes:
>> >
>> > Joe> I don't get this build warning in the first place and
2013/8/22 Martin K. Petersen :
>> "Joe" == Joe Perches writes:
>
> Joe> I don't get this build warning in the first place and I think the
> Joe> scsi_debug file is quite old and probably doesn't need to be
> Joe> changed at all.
>
> guard isn't a boolean, it selects the checksum algorithm
2013/8/22 Martin K. Petersen martin.peter...@oracle.com:
Joe == Joe Perches j...@perches.com writes:
Joe I don't get this build warning in the first place and I think the
Joe scsi_debug file is quite old and probably doesn't need to be
Joe changed at all.
guard isn't a boolean, it selects
2013/8/22 James Bottomley jbottom...@parallels.com:
On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote:
2013/8/22 Martin K. Petersen martin.peter...@oracle.com:
Joe == Joe Perches j...@perches.com writes:
Joe I don't get this build warning in the first place and I think the
Joe
The definision of ffs() for ia64 is almost same as
asm-generic/bitops/builtin-ffs.h. The only difference is that it is
defined as inline function or macro function. So this switches to use
the header.
Signed-off-by: Akinobu Mita
Cc: Tony Luck
Cc: Fenghua Yu
Cc: linux-i...@vger.kernel.org
The definisions of __ffs(), __fls(), and ffs() for tile are almost same
as asm-generic/bitops-*.h. The only difference is that it is defined
as __always_inline or inline. So this switches to use those headers.
Signed-off-by: Akinobu Mita
Cc: Chris Metcalf
---
arch/tile/include/asm/bitops.h
The definisions of __ffs(), __fls(), and ffs() for tile are almost same
as asm-generic/bitops-*.h. The only difference is that it is defined
as __always_inline or inline. So this switches to use those headers.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Chris Metcalf cmetc
The definision of ffs() for ia64 is almost same as
asm-generic/bitops/builtin-ffs.h. The only difference is that it is
defined as inline function or macro function. So this switches to use
the header.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Tony Luck tony.l...@intel.com
Cc
("bits in OOB size: %u\n",ffs(ns->geom.oobsz) - 1);
But removing this warning by casting to 'int' looks odd, so I suggest
unifying the return type of ffs() on all architectures.
Signed-off-by: Akinobu Mita
Reported-by: Fengguang Wu
Cc: Mikael Starvik
Cc: Jesper Nilsson
Cc: l
("bits in OOB size: %u\n",ffs(ns->geom.oobsz) - 1);
But removing this warning by casting to 'int' looks odd, so I suggest
unifying the return type of ffs() on all architectures.
Signed-off-by: Akinobu Mita
Reported-by: Fengguang Wu
Cc: Mikael Starvik
Cc: Jesper Nilsson
Cc: l
(bits in OOB size: %u\n,ffs(ns-geom.oobsz) - 1);
But removing this warning by casting to 'int' looks odd, so I suggest
unifying the return type of ffs() on all architectures.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Reported-by: Fengguang Wu fengguang...@intel.com
Cc: Mikael
(bits in OOB size: %u\n,ffs(ns-geom.oobsz) - 1);
But removing this warning by casting to 'int' looks odd, so I suggest
unifying the return type of ffs() on all architectures.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Reported-by: Fengguang Wu fengguang...@intel.com
Cc: Mikael
2013/7/17 Paul Bolle :
> On Wed, 2013-07-17 at 00:21 +0900, Akinobu Mita wrote:
>> This one looks good to me.
>
> Thanks.
>
>> It would be much better if this commit
>> log had a reference to the commit that introduced this warning as
>> you described afte
2013/7/16 Paul Bolle :
> Building scsi_debug.o triggers a GCC warning:
> drivers/scsi/scsi_debug.c: In function ‘dif_verify’:
> drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>
> This is a false positive. But if we
2013/7/16 Paul Bolle pebo...@tiscali.nl:
Building scsi_debug.o triggers a GCC warning:
drivers/scsi/scsi_debug.c: In function ‘dif_verify’:
drivers/scsi/scsi_debug.c:1755:3: warning: ‘csum’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
This is a false positive.
2013/7/17 Paul Bolle pebo...@tiscali.nl:
On Wed, 2013-07-17 at 00:21 +0900, Akinobu Mita wrote:
This one looks good to me.
Thanks.
It would be much better if this commit
log had a reference to the commit that introduced this warning as
you described after '---' in v1 patch.
Do you mean
ake care to decrease
sdb->resid if fill_from_dev_buffer() is called more than once.
Signed-off-by: Akinobu Mita
Cc: "James E.J. Bottomley"
Cc: Douglas Gilbert
Cc: linux-s...@vger.kernel.org
---
* No change from v2
drivers/scsi/scsi_debug.c | 48 ++
The only difference between sg_pcopy_{from,to}_buffer() and
sg_copy_{from,to}_buffer() is an additional argument that specifies
the number of bytes to skip the SG list before copying.
Signed-off-by: Akinobu Mita
Cc: Tejun Heo
Cc: Imre Deak
Cc: Herbert Xu
Cc: "David S. Miller"
Cc:
This function is used to proceed page iterator to the next page if
necessary, and will be used to implement the variants of
sg_copy_{from,to}_buffer() later.
Signed-off-by: Akinobu Mita
Acked-by: Tejun Heo
Cc: Tejun Heo
Cc: Imre Deak
Cc: Herbert Xu
Cc: "David S. Miller"
Cc:
Use sg_pcopy_to_buffer() which is better than the function previously used.
Because it doesn't do kmap/kunmap for skipped pages.
Signed-off-by: Akinobu Mita
Cc: Herbert Xu
Cc: Horia Geanta
Cc: "David S. Miller"
Cc: linux-cry...@vger.kernel.org
---
* No change from v2
driv
- Simplify the assignment of sdb->resid in fill_from_dev_buffer() in
scsi_debug
Akinobu Mita (4):
lib/scatterlist: factor out sg_miter_get_next_page() from
sg_miter_next()
lib/scatterlist: introduce sg_pcopy_from_buffer() and
sg_pcopy_to_buffer()
crypto: talitos: use sg_pcopy_to_buffer()
the assignment of sdb-resid in fill_from_dev_buffer() in
scsi_debug
Akinobu Mita (4):
lib/scatterlist: factor out sg_miter_get_next_page() from
sg_miter_next()
lib/scatterlist: introduce sg_pcopy_from_buffer() and
sg_pcopy_to_buffer()
crypto: talitos: use sg_pcopy_to_buffer()
scsi_debug: fix
This function is used to proceed page iterator to the next page if
necessary, and will be used to implement the variants of
sg_copy_{from,to}_buffer() later.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Acked-by: Tejun Heo t...@kernel.org
Cc: Tejun Heo t...@kernel.org
Cc: Imre Deak imre.d
Use sg_pcopy_to_buffer() which is better than the function previously used.
Because it doesn't do kmap/kunmap for skipped pages.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: Horia Geanta horia.gea...@freescale.com
Cc: David S. Miller da
care to decrease
sdb-resid if fill_from_dev_buffer() is called more than once.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Douglas Gilbert dgilb...@interlog.com
Cc: linux-s...@vger.kernel.org
---
* No change from v2
drivers/scsi
The only difference between sg_pcopy_{from,to}_buffer() and
sg_copy_{from,to}_buffer() is an additional argument that specifies
the number of bytes to skip the SG list before copying.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Tejun Heo t...@kernel.org
Cc: Imre Deak imre.d
2013/6/18 Tejun Heo :
> On Tue, Jun 18, 2013 at 10:31:32PM +0900, Akinobu Mita wrote:
>> /**
>> + * sg_miter_seek - reposition mapping iterator
>> + * @miter: sg mapping iter to be seeked
>> + * @offset: number of bytes to plus the current location
>> + *
2013/6/18 Tejun Heo t...@kernel.org:
On Tue, Jun 18, 2013 at 10:31:32PM +0900, Akinobu Mita wrote:
/**
+ * sg_miter_seek - reposition mapping iterator
+ * @miter: sg mapping iter to be seeked
+ * @offset: number of bytes to plus the current location
+ *
+ * Description:
+ * Sets
The only difference between sg_pcopy_{from,to}_buffer() and
sg_copy_{from,to}_buffer() is an additional argument that specifies
the number of bytes to skip the SG list before copying.
Signed-off-by: Akinobu Mita
Cc: Tejun Heo
Cc: Imre Deak
Cc: Herbert Xu
Cc: "David S. Miller"
Cc:
This function is used to proceed page iterator to the next page if
necessary, and will be used to implement the variants of
sg_copy_{from,to}_buffer() later.
Signed-off-by: Akinobu Mita
Cc: Tejun Heo
Cc: Imre Deak
Cc: Herbert Xu
Cc: "David S. Miller"
Cc: linux-cry...@vger.ker
Use sg_pcopy_to_buffer() which is better than the function previously used.
Because it doesn't do kmap/kunmap for skipped pages.
Signed-off-by: Akinobu Mita
Cc: Herbert Xu
Cc: Horia Geanta
Cc: "David S. Miller"
Cc: linux-cry...@vger.kernel.org
---
* No change from v1
driv
ake care to decrease
sdb->resid if fill_from_dev_buffer() is called more than once.
Signed-off-by: Akinobu Mita
Cc: "James E.J. Bottomley"
Cc: Douglas Gilbert
Cc: linux-s...@vger.kernel.org
---
* Change from v2
- Simplify the assignment of sdb->resid in fill_from_dev_buff
the patch "introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()"
- Add function comment for internal function sg_miter_seek()
- Simplify the assignment of sdb->resid in fill_from_dev_buffer() in
scsi_debug
Akinobu Mita (4):
lib/scatterlist: factor out sg_miter_get_nex
the patch introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()
- Add function comment for internal function sg_miter_seek()
- Simplify the assignment of sdb-resid in fill_from_dev_buffer() in
scsi_debug
Akinobu Mita (4):
lib/scatterlist: factor out sg_miter_get_next_page() from
care to decrease
sdb-resid if fill_from_dev_buffer() is called more than once.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Douglas Gilbert dgilb...@interlog.com
Cc: linux-s...@vger.kernel.org
---
* Change from v2
- Simplify the assignment
Use sg_pcopy_to_buffer() which is better than the function previously used.
Because it doesn't do kmap/kunmap for skipped pages.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: Horia Geanta horia.gea...@freescale.com
Cc: David S. Miller da
This function is used to proceed page iterator to the next page if
necessary, and will be used to implement the variants of
sg_copy_{from,to}_buffer() later.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Tejun Heo t...@kernel.org
Cc: Imre Deak imre.d...@intel.com
Cc: Herbert Xu herb
The only difference between sg_pcopy_{from,to}_buffer() and
sg_copy_{from,to}_buffer() is an additional argument that specifies
the number of bytes to skip the SG list before copying.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Tejun Heo t...@kernel.org
Cc: Imre Deak imre.d
2013/6/7 Tejun Heo :
> Hello,
>
> On Thu, Jun 06, 2013 at 09:52:56PM +0900, Akinobu Mita wrote:
>> +static bool sg_miter_get_next_page(struct sg_mapping_iter *miter)
>> +{
>> + if (!miter->__remaining) {
>> + struct scatterlist *sg;
>
2013/6/6 Imre Deak :
> Looks ok to me, perhaps adding the seek functionality to the mapping
> iterator would make things more generic and the mapping iterator more
> resemble the page iterator. So we'd have a new sg_miter_start_offset and
> call it here something like:
>
> sg_miter_start_offset(,
2013/6/6 Imre Deak imre.d...@intel.com:
Looks ok to me, perhaps adding the seek functionality to the mapping
iterator would make things more generic and the mapping iterator more
resemble the page iterator. So we'd have a new sg_miter_start_offset and
call it here something like:
2013/6/7 Tejun Heo t...@kernel.org:
Hello,
On Thu, Jun 06, 2013 at 09:52:56PM +0900, Akinobu Mita wrote:
+static bool sg_miter_get_next_page(struct sg_mapping_iter *miter)
+{
+ if (!miter-__remaining) {
+ struct scatterlist *sg;
+ unsigned long pgoffset
Use sg_pcopy_to_buffer() which is better than the function previously used.
Because it doesn't do kmap/kunmap for skipped pages.
Signed-off-by: Akinobu Mita
Cc: Herbert Xu
Cc: Horia Geanta
Cc: "David S. Miller"
Cc: linux-cry...@vger.kernel.org
---
drivers/crypto/tali
correctly.
This fixes it by using sg_pcopy_{from,to}_buffer() that can copy from/to
the middle of SG list.
Signed-off-by: Akinobu Mita
Cc: "James E.J. Bottomley"
Cc: Douglas Gilbert
Cc: linux-s...@vger.kernel.org
---
drivers/scsi/scsi_debug.c | 43
list before copying.
The main reason for introducing these functions is to fix a problem
in scsi_debug module. And there is a local function in crypto/talitos
module, which can be replaced by sg_pcopy_to_buffer().
Akinobu Mita (3):
lib/scatterlist: introduce sg_pcopy_from_buffer
The only difference between sg_pcopy_{from,to}_buffer() and
sg_copy_{from,to}_buffer() is an additional argument that specifies
the number of bytes to skip the SG list before copying.
Signed-off-by: Akinobu Mita
Cc: Tejun Heo
Cc: Imre Deak
Cc: Herbert Xu
Cc: "David S. Miller"
Cc:
The only difference between sg_pcopy_{from,to}_buffer() and
sg_copy_{from,to}_buffer() is an additional argument that specifies
the number of bytes to skip the SG list before copying.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Tejun Heo t...@kernel.org
Cc: Imre Deak imre.d
list before copying.
The main reason for introducing these functions is to fix a problem
in scsi_debug module. And there is a local function in crypto/talitos
module, which can be replaced by sg_pcopy_to_buffer().
Akinobu Mita (3):
lib/scatterlist: introduce sg_pcopy_from_buffer
correctly.
This fixes it by using sg_pcopy_{from,to}_buffer() that can copy from/to
the middle of SG list.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Douglas Gilbert dgilb...@interlog.com
Cc: linux-s...@vger.kernel.org
---
drivers/scsi
Use sg_pcopy_to_buffer() which is better than the function previously used.
Because it doesn't do kmap/kunmap for skipped pages.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: Horia Geanta horia.gea...@freescale.com
Cc: David S. Miller da
systems, the allocation size is smaller
than requeired if the number of bits is not a multiple of BITS_PER_LONG.
Signed-off-by: Akinobu Mita
Cc: Konrad Rzeszutek Wilk
---
mm/frontswap.c | 2 +-
mm/swapfile.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/frontswap.c b/mm
systems, the allocation size is smaller
than requeired if the number of bits is not a multiple of BITS_PER_LONG.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
---
mm/frontswap.c | 2 +-
mm/swapfile.c | 2 +-
2 files changed, 2 insertions(+), 2
This fixes the misaligned indentation introduced by
drivers-net-rename-random32-to-prandom_u32.patch in the -mm tree.
This also remove unneeded parentheses in order not to cause line over
80 characters.
Signed-off-by: Akinobu Mita
Cc: "John W. Linville"
Cc: "David S. Miller&quo
The Kconfig help text for MEMORY_NOTIFIER_ERROR_INJECT and
OF_RECONFIG_NOTIFIER_ERROR_INJECT has mismatched module names.
Signed-off-by: Akinobu Mita
---
lib/Kconfig.debug | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 28be08c
The Kconfig help text for MEMORY_NOTIFIER_ERROR_INJECT and
OF_RECONFIG_NOTIFIER_ERROR_INJECT has mismatched module names.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
---
lib/Kconfig.debug | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Kconfig.debug b/lib
This fixes the misaligned indentation introduced by
drivers-net-rename-random32-to-prandom_u32.patch in the -mm tree.
This also remove unneeded parentheses in order not to cause line over
80 characters.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: John W. Linville linvi
2013/3/12 :
> On Sun, 10 Mar 2013 17:09:50 +0900, Akinobu Mita said:
>> This fixes the wrong position of the comment introduced by
>> scsi-rename-random32-to-prandom_u32.patch in the -mm tree.
>>
>> Signed-off-by: Akinobu Mita
>> Cc: "James
2013/3/12 valdis.kletni...@vt.edu:
On Sun, 10 Mar 2013 17:09:50 +0900, Akinobu Mita said:
This fixes the wrong position of the comment introduced by
scsi-rename-random32-to-prandom_u32.patch in the -mm tree.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: James E.J. Bottomley jbottom
This fixes the misaligned indentation introduced by
drivers-net-rename-random32-to-prandom_u32.patch in the -mm tree.
This also remove unneeded parentheses in order not to cause line over
80 characters.
Signed-off-by: Akinobu Mita
Cc: "David S. Miller"
Cc: Brett Rudley
Cc: Arend
This fixes the wrong position of the comment introduced by
scsi-rename-random32-to-prandom_u32.patch in the -mm tree.
Signed-off-by: Akinobu Mita
Cc: "James E.J. Bottomley"
Cc: Andrew Vasquez
---
drivers/scsi/qla2xxx/qla_attr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletion
This fixes the wrong position of the comment introduced by
scsi-rename-random32-to-prandom_u32.patch in the -mm tree.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Andrew Vasquez andrew.vasq...@qlogic.com
---
drivers/scsi/qla2xxx
This fixes the misaligned indentation introduced by
drivers-net-rename-random32-to-prandom_u32.patch in the -mm tree.
This also remove unneeded parentheses in order not to cause line over
80 characters.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: David S. Miller da...@davemloft.net
Cc
Use memchr_inv to verify that the specified memory range is cleared.
Signed-off-by: Akinobu Mita
Cc: Steven Whitehouse
Cc: cluster-de...@redhat.com
Cc: Christine Caulfield
Cc: David Teigland
---
fs/gfs2/lock_dlm.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/fs
2013/3/7 Steven Whitehouse :
> Hi,
>
> This doesn't apply over the patch which Dave just sent. Can you redo
> this against the current GFS2 -nmw tree if it is still required? Thanks,
I checked Dave's patch. It fixes the same issue that I was trying to fix.
So this -v2 patch is not needed
2013/3/7 Steven Whitehouse swhit...@redhat.com:
Hi,
This doesn't apply over the patch which Dave just sent. Can you redo
this against the current GFS2 -nmw tree if it is still required? Thanks,
I checked Dave's patch. It fixes the same issue that I was trying to fix.
So this -v2 patch is not
Use memchr_inv to verify that the specified memory range is cleared.
Signed-off-by: Akinobu Mita akinobu.m...@gmail.com
Cc: Steven Whitehouse swhit...@redhat.com
Cc: cluster-de...@redhat.com
Cc: Christine Caulfield ccaul...@redhat.com
Cc: David Teigland teigl...@redhat.com
---
fs/gfs2/lock_dlm.c
MAP_OFFSET from bytes to bits
in order to reduce the conversion of the unit.
Signed-off-by: Akinobu Mita
Cc: Steven Whitehouse
Cc: cluster-de...@redhat.com
Cc: Christine Caulfield
Cc: David Teigland
---
* Change from v1
- fix wrong offsets caused by the change of type of the 'lvb_bits'
(detected
501 - 600 of 1201 matches
Mail list logo
