ring copys as buf is const */
> if (!p_args) {
> dev_warn(device,
> @@ -1611,7 +1612,7 @@ static ssize_t alarms_store(struct device *device,
>
> free_m:
> /* free allocated memory */
> - kfree(p_args);
> + kfree(orig);
>
> return
Le vendredi 15 mai 2020 à 16:29 +0200, Greg KH a écrit :
> On Mon, May 11, 2020 at 10:35:35PM +0200, Akira Shimahara wrote:
> > Adding code comments to split code in dedicated parts. After the global
> > declarations (defines, macros and function declarations), code is organize
parameter.
Updating documentation in Documentation/ABI/testing/sysfs-driver-w1_therm
and Documentation/w1/slaves/w1_therm.rst accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code
/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code comments according to kernel-doc requirements
Changes in v7:
- Formatting code comments
/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code comments according to kernel-doc requirements
Changes in v7:
- Formatting code comments
was only set and never
read (so not stored in the device struct).
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code
device families structures.
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code comments according to kernel-doc
several times (W1_THERM_MAX_TRY), waiting
W1_THERM_RETRY_DELAY between two attempt.
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6
Adding a sysfs-driver-w1_therm documentation file in
Documentation/ABI/testing. It describe the onlys sysfs entry of w1_therm
module, based on Documentation/w1/slaves/w1_therm.rst
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
.
A dedicated reset_select_slave() function is implemented here,
it always perform an adressing to each slave using the MATCH ROM
command.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code
interface functions
Signed-off-by: Akira Shimahara
---
Main motivation on the first patch of this serie is to clean up the code,
document it and reorder it to prepare the next patches, which are clearer
after this.
One main point is to keep all device/family dependent code gather at the
beginning
Hi,
Le dimanche 10 mai 2020 à 20:33 -0700, Randy Dunlap a écrit :
> Hi,
>
> A few more comments here (inline):
>
> On 5/10/20 7:15 AM, Akira Shimahara wrote:
>
> > drivers/w1/slaves/w1_therm.c | 398 ---
> > 1 file changed, 23
Hi,
Le dimanche 10 mai 2020 à 20:25 -0700, Randy Dunlap a écrit :
> Hi,
>
>
>
> The kernel-doc comment changes look good. Thanks for doing that.
>
>
>
>
>
> On 5/10/20 7:17 AM, Akira Shimahara wrote:
>
>
>
> > diff --git a/driv
/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code comments according to kernel-doc requirements
.../ABI/testing/sysfs-driver-w1_therm
parameter.
Updating documentation in Documentation/ABI/testing/sysfs-driver-w1_therm
and Documentation/w1/slaves/w1_therm.rst accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code
was only set and never
read (so not stored in the device struct).
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code
/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code comments according to kernel-doc requirements
.../ABI/testing/sysfs-driver-w1_therm
protocol), it is removed
from device families structures.
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code comments
several times (W1_THERM_MAX_TRY), waiting
W1_THERM_RETRY_DELAY between two attempt.
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6
Adding a sysfs-driver-w1_therm documentation file in
Documentation/ABI/testing. It describe the onlys sysfs entry of w1_therm
module, based on Documentation/w1/slaves/w1_therm.rst
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
.
A dedicated reset_select_slave() function is implemented here,
it always perform an adressing to each slave using the MATCH ROM
command.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
Changes in v6:
- Formatting code
interface functions
Signed-off-by: Akira Shimahara
---
Main motivation on the first patch of this serie is to clean up the code,
document it and reorder it to prepare the next patches, which are clearer
after this.
One main point is to keep all device/family dependent code gather at the
beginning
*f;
> > + int (*convert)(u8 rom[9]);
> > + int (*precision)(struct device *device, int val);
> > + int (*eeprom)(struct device *device);
> > +};
> > +
>
>
> thanks.
>
> --
>
> ~Randy
Hi,
Well noted, I will do it and re submit the serie. Thanks for your time.
Akira SHIMAHARA
parameter.
Updating documentation in Documentation/ABI/testing/sysfs-driver-w1_therm
and Documentation/w1/slaves/w1_therm.rst accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
.../ABI/testing/sysfs-driver
/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
.../ABI/testing/sysfs-driver-w1_therm | 12 +
drivers/w1/slaves/w1_therm.c | 278 --
2
/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
.../ABI/testing/sysfs-driver-w1_therm | 16 ++
drivers/w1/slaves/w1_therm.c | 158
protocol), it is removed
from device families structures.
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
.../ABI/testing/sysfs-driver-w1_therm
was only set and never
read (so not stored in the device struct).
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
.../ABI/testing/sysfs-driver-w1_therm
several times (W1_THERM_MAX_TRY), waiting
W1_THERM_RETRY_DELAY between two attempt.
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
.../ABI/testing
Adding a sysfs-driver-w1_therm documentation file in
Documentation/ABI/testing. It describe the onlys sysfs entry of w1_therm
module, based on Documentation/w1/slaves/w1_therm.rst
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
.
A dedicated reset_select_slave() function is implemented here,
it always perform an adressing to each slave using the MATCH ROM
command.
Signed-off-by: Akira Shimahara
---
Changes in v5:
- All patch serie in one .c file
- Correcting some comments
- adding include
drivers/w1/slaves/w1_therm.c
interface functions
Signed-off-by: Akira Shimahara
---
Main motivation on the first patch of this serie is to clean up the code,
document it and reorder it to prepare the next patches, which are clearer
after this.
One main point is to keep all device/family dependent code gather at the
beginning
multiple .c files, otherwise it's not needed.
>
>
>
> thanks,
>
>
>
> greg k-h
Hi,
Ok well noted, I will do it tomorrow, and keep it as 8 patches.
Thanks for your time
Akira Shimahara
+ w1_write_block(sl->master, match, 9);
> > +
> > + return 0;
> > +}
>
>
> If you put this higher up in the .c file, no function definition is
>
> needed in the .h file at all, right?
>
>
>
> thanks,
>
>
>
> greg k-h
Yes, everything could be put in the .c file, but I think we will loose
clarity.
Please, let me know what you prefer.
Thanks
Akira Shimahara
Le mardi 05 mai 2020 à 16:48 +0200, Greg KH a écrit :
> > Creating w1_therm.h header to organize code. Organize the
> > w1_therm.c file
> > to gather hardware functions, device specific functions, interface
> > functions and sysfs functions.
> >
Le jeudi 30 avril 2020 à 13:21 +0200, Greg KH a écrit :
> On Thu, Apr 30, 2020 at 12:34:03PM +0200, Akira shimahara wrote:
> > Hello,
> >
> > Le mercredi 29 avril 2020 à 18:18 +0300, Evgeniy Polyakov a écrit :
> > > Hi
> > >
> >
Hello,
Le mercredi 29 avril 2020 à 18:18 +0300, Evgeniy Polyakov a écrit :
> Hi
>
>
>
> 29.04.2020, 16:47, "Greg KH" :
>
>
>
> > > +What: /sys/bus/w1/devices/.../w1_slave
> > > +Date: Apr 2020
> > > +Contact: Akira Shimahara
&
in Documentation/ABI/testing/sysfs-driver-w1_therm
and Documentation/w1/slaves/w1_therm.rst accordingly.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 36 ++-
Documentation/w1/slaves/w1_therm.rst | 50 +++-
drivers/w1/slaves/w1_therm.c
, a safe cast shall be performed using the min and
max temperature that device are able to measure. This is done by
int_to_short inline function.
Updating doc in Documentation/ABI/testing/sysfs-driver-w1_therm
accordingly.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm
device families structures.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 14 ++
drivers/w1/slaves/w1_therm.c | 151 +++---
drivers/w1/slaves/w1_therm.h | 36 -
3 files changed, 142 insertions(+), 59
w1_slave has been kept for compatibility, without changing its
output format.
Updating doc in Documentation/ABI/testing/sysfs-driver-w1_therm
accordingly.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 12 +
drivers/w1/slaves/w1_therm.c | 266
.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 17 +
drivers/w1/slaves/w1_therm.c | 404 ++
drivers/w1/slaves/w1_therm.h | 91 +++-
3 files changed, 408 insertions(+), 104 deletions(-)
diff --git a/Documentation
.
Updating Documentation/ABI/testing/sysfs-driver-w1_therm accordingly.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 12 +++
drivers/w1/slaves/w1_therm.c | 94 ++-
drivers/w1/slaves/w1_therm.h | 43 -
3 files
Adding a sysfs-driver-w1_therm documentation file in
Documentation/ABI/testing. It describe the onlys sysfs entry of w1_therm
module, based on Documentation/w1/slaves/w1_therm.rst
Signed-off-by: Akira Shimahara
---
Documentation/ABI/testing/sysfs-driver-w1_therm | 17 +
1 file
.
A dedicated reset_select_slave() function is implemented here,
it always perform an adressing to each slave using the MATCH ROM
command.
Signed-off-by: Akira Shimahara
---
drivers/w1/slaves/w1_therm.c | 29 ++---
drivers/w1/slaves/w1_therm.h | 13 +
2 files
Creating w1_therm.h header to organize code. Organize the w1_therm.c file
to gather hardware functions, device specific functions, interface
functions and sysfs functions.
Signed-off-by: Akira Shimahara
---
drivers/w1/slaves/w1_therm.c | 302 +++
drivers/w1
Le mercredi 29 avril 2020 à 15:47 +0200, Greg KH a écrit :
> On Wed, Apr 29, 2020 at 03:33:20PM +0200, Akira Shimahara wrote:
> > Patch for enhacement of w1_therm module. Added features :
> > - Optimized conversion time regarding to device resolution
> > - Dedicated sysfs
Le mercredi 29 avril 2020 à 15:46 +0200, Greg KH a écrit :
> On Wed, Apr 29, 2020 at 03:32:04PM +0200, Akira Shimahara wrote:
> > Patch for enhacement of w1_therm module.
> > Adding ext_power sysfs entry (RO). Return the power status of the
> > device:
> > - 0: devic
Le mercredi 29 avril 2020 à 15:43 +0200, Greg KH a écrit :
> On Wed, Apr 29, 2020 at 03:30:48PM +0200, Akira Shimahara wrote:
> > Patch for enhancement of w1_therm module.
> > - Creating a w1_therm.h file to clean up the code and documenting
> > it.
> > - fix
documentation in Documentation/ABI/testing/sysfs-driver-w1_therm
and Documentation/w1/slaves/w1_therm.rst
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 36 ++-
Documentation/w1/slaves/w1_therm.rst | 50 +++-
drivers/w1/slaves/w1_therm.c
-w1_therm
accordingly.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 15 ++
drivers/w1/slaves/w1_therm.c | 129 ++
drivers/w1/slaves/w1_therm.h | 12 ++
3 files changed, 156 insertions(+)
diff --git
-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 43 +
drivers/w1/slaves/w1_therm.c | 785 +-
drivers/w1/slaves/w1_therm.h | 168 +++-
3 files changed, 760 insertions(+), 236 deletions(-)
diff --git a/Documentation/ABI
and this new entry.
Signed-off-by: Akira Shimahara
---
.../ABI/testing/sysfs-driver-w1_therm | 29 ++
drivers/w1/slaves/w1_therm.c | 93 ++-
drivers/w1/slaves/w1_therm.h | 44 -
3 files changed, 163 insertions(+), 3 deletions(-)
create
. At the beginning of the search process,
sl->master->slave_count is 1 even if more devices are on the line,
causing data collision in the bus.
Signed-off-by: Akira Shimahara
---
drivers/w1/slaves/w1_therm.c | 325 ---
drivers/w1/slaves/w1_therm.h
Le mardi 28 avril 2020 à 14:44 +0200, Greg KH a écrit :
> On Sun, Apr 26, 2020 at 07:20:30PM +0200, Akira shimahara wrote:
> > Le dimanche 26 avril 2020 à 19:09 +0200, Greg KH a écrit :
> > > On Sun, Apr 26, 2020 at 02:36:52PM +0200, Akira shimahara wrote:
> > > > Le
55 matches
Mail list logo
