Re: floppy on alpha

2000-10-14 Thread Alain Knaff
>Yes. If you see how to do it - patches are welcome. One of the possible >ways is to create a structure when you register driver, remove it upon >rmmod, replace ->b_dev and friends with pointers to that structure and >make the removal of this beast invalidate the buffers. Wouldn't it be easye

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
>On Sat, 16 Sep 2000, Alain Knaff wrote: > >> >Flush >> >> What is so shocking about flushing away the cache for a >> write-protected floppy? > >Erm... The fact that final close() will do it anyway? Well it shouldn't, that would be a useless performa

[PATCH] Fix floppy ioctls, REVISED edition

2000-09-16 Thread Alain Knaff
The following patch (against 2.4.0-test8) restores floppy ioctl functionality, which has been broken in 2.4.0-test6-pre7. It now tests for fake ioctl's, so their should be no interaction with read-only mounts: --- 2.4.0-test8/linux/drivers/block/floppy.cMon Sep 11 20:09:28 2000 +++ linux/driv

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> Moreover you seem to have an interesting definition of "most": for >> many of those ioctls, sysctl would be rather clumsy: FDRAWCMD, >> FDSETPRM, FDCLRPRM, FDDEFPRM, FDFMTBEG, FDFMTTRK, FDFMTEND, FDFLUSH, &

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> Ok, now could you tell me a way how to easily detect a "fake inode", >> and I rewrite my "restore ioctl functionality patch" in a way as not >> to break floppy root mounts. > >s/root// > &

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> >Probably the clean solution would be to add a character device per >> >controller (/dev/fdc), turning eject /dev/fd0 into >> >% echo eject 0 > /dev/fdc0 >> >> Why do that for floppies, when w

Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: >> >> The following patch (against 2.4.0-test8) restores ioctl functionality, >> which has been broken in 2.4.0-test6-pre7: > >No. Th epatch breaks things. You cannot use "permission" at that point, >and

Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> The following patch (against 2.4.0-test8) restores ioctl functionality, >> which has been broken in 2.4.0-test6-pre7: > >I would reserve "broken" for original state. What's wrong with "if you

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> >FYI, here is a chunk of our conversation - I just realized that most of it >> >was private with AV and Linus so it is reasonable that you didn't see it. >> >> Thanks for mailing me this. Well, I w

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
>FYI, here is a chunk of our conversation - I just realized that most of it >was private with AV and Linus so it is reasonable that you didn't see it. Thanks for mailing me this. Well, I would have actually preferred to take part in this discussion when it first took place, rather than learning a

[PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Alain Knaff
The following patch (against 2.4.0-test8) restores ioctl functionality, which has been broken in 2.4.0-test6-pre7: --- 2.4.0-test8/linux/drivers/block/floppy.cMon Sep 11 20:09:28 2000 +++ linux/drivers/block/floppy.cSat Sep 16 15:03:39 2000 @@ -3435,6 +3435,8 @@ static int fd_ioctl(s