Re: [PATCH 05/10] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

On Thu, 2021-03-18 at 12:44 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for > struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead >

Re: [RESEND PATCH 00/10] arm64: dts: intel: socfpga: minor cleanups

On Mon, 2021-03-08 at 17:22 +0100, Krzysztof Kozlowski wrote: > Hi Arnd and Olof, > > This is just a resend of previous patch. Since I did not get replies > from Intel maintainers, I assume this could go via soc tree directly. I think the to/cc list is missing Dinh, the socfpga maintainer: Dinh

Re: [PATCH 05/10] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

Hi Lee, Thanks for the patch. On Wed, 2021-03-03 at 14:34 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for > struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead >

Re: [PATCH v6 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

Hi Jassi, Thank you very much for your feedback. On Sun, 2021-02-14 at 22:54 -0600, Jassi Brar wrote: > IIUIC, maybe the solution is simpler What if we set txdone_poll. > Always return success in send_data(). And check if we overflew the > fifo in last_tx_done(). If we did overflow, try to

Re: [PATCH 02/11] dt-bindings: arm: intel,keembay: limit the dtschema to root node

Hi Krzysztof, Thanks for the fix. On Wed, 2021-02-10 at 18:18 +0100, Krzysztof Kozlowski wrote: > The check for the board compatible should be limited only to the root > node. Any other nodes with such compatible are not part of this schema > and should not match. > > Signed-off-by: Krzysztof

Re: [PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

On Thu, 2021-02-04 at 18:55 +, Lee Jones wrote: > On Thu, 04 Feb 2021, Alessandrelli, Daniele wrote: > > > On Thu, 2021-02-04 at 11:09 +, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/crypto/ke

Re: [PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

On Thu, 2021-02-04 at 11:09 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for > struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead >

Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

On Tue, 2021-02-02 at 20:42 +1100, Herbert Xu wrote: > On Tue, Feb 02, 2021 at 09:27:33AM +0000, Alessandrelli, Daniele > wrote: > > I see. Just to clarify: does the in-kernel user requirement also > > apply > > to the case when the author of a device driver also p

Re: [PATCH v7 4/7] crypto: add ecc curve and expose them

On Tue, 2021-02-02 at 16:13 +1100, Herbert Xu wrote: > The issue is that we always require a software implementation for > any given hardware algorithm. As otherwise kernel users cannot > rely on the algorithm to work. I understand. This sounds very reasonable to me. > Of course we don't want

Re: [PATCH v3 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

Hi Jassi, Thank you very much for your feedback. On Mon, 2021-02-01 at 01:07 -0600, Jassi Brar wrote: > On Fri, Jan 29, 2021 at 8:21 PM wrote: > > From: Daniele Alessandrelli > > > > Add mailbox controller enabling inter-processor communication (IPC) > > between the CPU (aka, the Application

Re: [PATCH v2 06/34] dt-bindings: Add bindings for Keem Bay VPU IPC driver

Hi Rob, Thanks for your review. On Mon, 2021-01-11 at 13:24 -0600, Rob Herring wrote: > On Fri, Jan 08, 2021 at 01:25:32PM -0800, mgr...@linux.intel.com > wrote: > > From: Paul Murphy > > > > Add DT bindings documentation for the Keem Bay VPU IPC driver. > > > > Cc: Rob Herring > > Cc:

Re: [PATCH v5 3/5] crypto: expose elliptic curve parameters as Crypto APIs

On Mon, 2021-01-04 at 17:36 +0800, yumeng wrote: > > 在 2021/1/3 5:29, Herbert Xu 写道: > > On Thu, Dec 24, 2020 at 02:08:25PM +0800, Meng Yu wrote: > > > Move elliptic curves definition to 'include/crypto/ecc_curve_defs.h', > > > so all can use it, > > > > > > Signed-off-by: Meng Yu > > >

Re: keembay-ocs-aes-core.c:undefined reference to `devm_ioremap_resource'

On Thu, 2020-12-17 at 13:23 +0800, kernel test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: accefff5b547a9a1d959c7e76ad539bf2480e78b > commit: 88574332451380f4b51f6ca88ab9810e714bfb9b crypto: keembay - > Add support for Keem Bay

Re: [PATCH] crypto: CRYPTO_DEV_KEEMBAY_OCS_AES_SM4 should depend on ARCH_KEEMBAY

Thanks for the patch. On Wed, 2020-12-16 at 14:14 +0100, Geert Uytterhoeven wrote: > The Intel Keem Bay Offload and Crypto Subsystem (OCS) is only present > on > Intel Keem Bay SoCs. Hence add a dependency on ARCH_KEEMBAY, to > prevent > asking the user about this driver when configuring a

Re: [PATCH 1/1] soc: keembay: Add Keem Bay IMR driver

Hi Arnd, Pavel, Thanks for your feedback. > > > > > > The problem is that I need this code to be run early at boot, so > > > I > > > don't think I can make this a module. > > > > How early is early enough? Basically, before any device with direct memory access is activated (because if

Re: [PATCH 0/1] Add IMR driver for Keem Bay

On Tue, 2020-04-21 at 17:36 +0100, Daniele Alessandrelli wrote: > The following is a patch for a new Intel Movidius SoC, code-named > Keem > Bay. > > Keem Bay needs a driver to disable the Isolated Memory Region (IMR) > set up by the SoC bootloader during early boot. > > If such an IMR is not