Re: [PATCH] FMC: fix 'passing zero to PTR_ERR()' warning

2019-06-20 Thread Alessandro Rubini
Hello. drivers/fmc is going to be removed from the official kernel (removal is queued by Linus Walleij, with approval by fmc authors). So this patch should be dropped. thanks /alessandro

Re: [PATCH] fmc: Delete the FMC subsystem

2019-06-11 Thread Alessandro Rubini
Acked-by: Alessandro Rubini

Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code

2018-12-07 Thread Alessandro Rubini
> Subject: [PATCH] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Acked-by: Alessandro Rubini > Alessandro, Davide - you can find additional context regarding why we > are making these changes in the [00/22] e-mail that can be found here: > https://lore.kernel.org/lkm

Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code

2018-12-07 Thread Alessandro Rubini
> Subject: [PATCH] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Acked-by: Alessandro Rubini > Alessandro, Davide - you can find additional context regarding why we > are making these changes in the [00/22] e-mail that can be found here: > https://lore.kernel.org/lkm

Re: [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true

2018-10-16 Thread Alessandro Rubini
Me: >> > OTOH I admit you can compare any value with -EINVAL, after PTR_ERR. >> > But in general you first detect the error condition and then split >> > among error (or print a message according to the exact value. Al Viro: >> >> if (IS_ERR(p) && PTR_ERR(p) == -ENOENT) >> instead of >>

Re: [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true

2018-10-16 Thread Alessandro Rubini
Me: >> > OTOH I admit you can compare any value with -EINVAL, after PTR_ERR. >> > But in general you first detect the error condition and then split >> > among error (or print a message according to the exact value. Al Viro: >> >> if (IS_ERR(p) && PTR_ERR(p) == -ENOENT) >> instead of >>

Re: [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true

2018-10-15 Thread Alessandro Rubini
Hello. > during a review I claimed that PTR_ERR should only be used if IS_ERR was > already checked. The rationale isn't obvious though and Thierry > suggested to keep the code as is and not introduce an IS_ERR check. The rationale is the same ch11 you linked to: "any other value is a valid

Re: [PATCH RFC] err.h: document that PTR_ERR should only be used if IS_ERR returns true

2018-10-15 Thread Alessandro Rubini
Hello. > during a review I claimed that PTR_ERR should only be used if IS_ERR was > already checked. The rationale isn't obvious though and Thierry > suggested to keep the code as is and not introduce an IS_ERR check. The rationale is the same ch11 you linked to: "any other value is a valid

Re: [PATCH V3 1/5] drivers/fmc: remove unused variable

2017-07-18 Thread Alessandro Rubini
> Ah, sorry, wrong "changelog". I meant the area that shows up in git > about what this patch does. There's no description of it other than the > Subject line. Yes. Ok, I'll add a longer commit message for V4 of the whole set. Tomorrow (/me leaving now to a client).

Re: [PATCH V3 1/5] drivers/fmc: remove unused variable

2017-07-18 Thread Alessandro Rubini
> Ah, sorry, wrong "changelog". I meant the area that shows up in git > about what this patch does. There's no description of it other than the > Subject line. Yes. Ok, I'll add a longer commit message for V4 of the whole set. Tomorrow (/me leaving now to a client).

Re: [PATCH V3 1/5] drivers/fmc: remove unused variable

2017-07-18 Thread Alessandro Rubini
> Again, I do not like to take patches without any changelog text at all > :( Sorry, I added this after the "---" line. I thought it was this one the missing item: V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2 (Pat): added Tested-by and incorrect From line V1

Re: [PATCH V3 1/5] drivers/fmc: remove unused variable

2017-07-18 Thread Alessandro Rubini
> Again, I do not like to take patches without any changelog text at all > :( Sorry, I added this after the "---" line. I thought it was this one the missing item: V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2 (Pat): added Tested-by and incorrect From line V1

[PATCH V3 0/5] Update kernel to latest FMC bus release

2017-07-18 Thread Alessandro Rubini
on registration Upstream git repo: http://www.ohwr.org/projects/fmc-bus/repository/show?rev=fmc-bus-v2017-06 FMC maintainer: Alessandro Rubini <rub...@gnudd.com> Initial approver of FMC: Greg KH <gre...@linuxfoundation.org> Federico Vaga (5): drivers/fmc: remove unused variable drivers/f

[PATCH V3 0/5] Update kernel to latest FMC bus release

2017-07-18 Thread Alessandro Rubini
on registration Upstream git repo: http://www.ohwr.org/projects/fmc-bus/repository/show?rev=fmc-bus-v2017-06 FMC maintainer: Alessandro Rubini Initial approver of FMC: Greg KH Federico Vaga (5): drivers/fmc: remove unused variable drivers/fmc: hide fmc operations behind helpers drivers/fmc: The only

[PATCH V3 4/5] drivers/fmc: change registration prototype

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga <federico.v...@cern.ch> Permit use of either fmc_device_register_n or fmc_device_register_n_gw depending on the type of device in use. Signed-off-by: Federico Vaga <federico.v...@cern.ch> Tested-by: Pat Riehecky <riehe...@fnal.gov> Acked-by: Ales

[PATCH V3 4/5] drivers/fmc: change registration prototype

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga Permit use of either fmc_device_register_n or fmc_device_register_n_gw depending on the type of device in use. Signed-off-by: Federico Vaga Tested-by: Pat Riehecky Acked-by: Alessandro Rubini --- V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2

[PATCH V3 3/5] drivers/fmc: The only way to dump the SDB is from debugfs

2017-07-18 Thread Alessandro Rubini
fnal.gov> Acked-by: Alessandro Rubini <rub...@gnudd.com> --- V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2 (Pat): added Tested-by and incorrect From line V1 (Pat): picked from ohwr.org repo, where most fmc users pick from. drivers/fmc/Makefile | 1 + drivers

[PATCH V3 3/5] drivers/fmc: The only way to dump the SDB is from debugfs

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga Driver should not call fmc_sdb_dump() anymore. (actually they can but the operation is not supported, so it will print an error message) Signed-off-by: Federico Vaga Tested-by: Pat Riehecky Acked-by: Alessandro Rubini --- V3 (Alessandro): fixed From line in patch, added

[PATCH V3 5/5] drivers/fmc: carrier can program FPGA on registration

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga <federico.v...@cern.ch> The initial FPGA may require programming before it is useful. Signed-off-by: Federico Vaga <federico.v...@cern.ch> Tested-by: Pat Riehecky <riehe...@fnal.gov> Acked-by: Alessandro Rubini <rub...@gnudd.com> --- V3 (Alessandro):

[PATCH V3 2/5] drivers/fmc: hide fmc operations behind helpers

2017-07-18 Thread Alessandro Rubini
h> Tested-by: Pat Riehecky <riehe...@fnal.gov> Acked-by: Alessandro Rubini <rub...@gnudd.com> --- V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2 (Pat): added Tested-by and incorrect From line V1 (Pat): picked from ohwr.org repo, where most fmc users pick

[PATCH V3 1/5] drivers/fmc: remove unused variable

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga <federico.v...@cern.ch> Signed-off-by: Federico Vaga <federico.v...@cern.ch> Tested-by: Pat Riehecky <riehe...@fnal.gov> Acked-by: Alessandro Rubini <rub...@gnudd.com> --- V3 (Alessandro): fixed From line in patch, added alessandro's acked-by

[PATCH V3 1/5] drivers/fmc: remove unused variable

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga Signed-off-by: Federico Vaga Tested-by: Pat Riehecky Acked-by: Alessandro Rubini --- V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2 (Pat): added Tested-by and incorrect From line V1 (Pat): picked from ohwr.org repo, where most fmc users pick

[PATCH V3 5/5] drivers/fmc: carrier can program FPGA on registration

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga The initial FPGA may require programming before it is useful. Signed-off-by: Federico Vaga Tested-by: Pat Riehecky Acked-by: Alessandro Rubini --- V3 (Alessandro): fixed From line in patch, added alessandro's acked-by V2 (Pat): added Tested-by and incorrect From line

[PATCH V3 2/5] drivers/fmc: hide fmc operations behind helpers

2017-07-18 Thread Alessandro Rubini
From: Federico Vaga This gave us more freedom to change/add/remove operations without recompiling all device driver. Typically, Carrier board implement the fmc operations, so they will not use these helpers. Signed-off-by: Federico Vaga Tested-by: Pat Riehecky Acked-by: Alessandro Rubini

Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on registration

2017-07-17 Thread Alessandro Rubini
> This is not how the "From:" line works, please read SubmittingPatches > for the correct usage... I'm submitting V3 with the correct From line, and my acked-by, since now I managed to actually test them. It will happen later today. Thanks greg for considering the patches. /alessandro

Re: [PATCH v2 05/05] drivers/fmc: carrier can program FPGA on registration

2017-07-17 Thread Alessandro Rubini
> This is not how the "From:" line works, please read SubmittingPatches > for the correct usage... I'm submitting V3 with the correct From line, and my acked-by, since now I managed to actually test them. It will happen later today. Thanks greg for considering the patches. /alessandro

Re: [PATCH 0/5] Update kernel to latest FMC bus release

2017-07-05 Thread Alessandro Rubini
Hello. Thank you Pat for taking care of these patches. > Federico Vaga (5): > drivers/fmc: remove unused variable > drivers/fmc: hide fmc operations behind helpers > drivers/fmc: The only way to dump the SDB is from debugfs > drivers/fmc: change registration prototype > drivers/fmc:

Re: [PATCH 0/5] Update kernel to latest FMC bus release

2017-07-05 Thread Alessandro Rubini
Hello. Thank you Pat for taking care of these patches. > Federico Vaga (5): > drivers/fmc: remove unused variable > drivers/fmc: hide fmc operations behind helpers > drivers/fmc: The only way to dump the SDB is from debugfs > drivers/fmc: change registration prototype > drivers/fmc:

Re: [PATCH] fmc: don't include moduleparam.h in include/linux header files.

2016-09-09 Thread Alessandro Rubini
> So move the include to the one and only driver to use these macros and > ensure we keep setting the proper example in include/linux headers. > > Cc: Alessandro Rubini <rub...@gnudd.com> > Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> Thanks. Acked-

Re: [PATCH] fmc: don't include moduleparam.h in include/linux header files.

2016-09-09 Thread Alessandro Rubini
> So move the include to the one and only driver to use these macros and > ensure we keep setting the proper example in include/linux headers. > > Cc: Alessandro Rubini > Signed-off-by: Paul Gortmaker Thanks. Acked-by: Alessandro Rubini

Re: [PATCH] FMC: misc_register should not be called while atomic

2014-04-16 Thread Alessandro Rubini
>> --- a/drivers/fmc/fmc-chardev.c >> +++ b/drivers/fmc/fmc-chardev.c >> @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc) >> fc->misc.fops = _fops; >> fc->misc.name = kstrdup(dev_name(>dev), GFP_KERNEL); >> >> -spin_lock(_lock); >> ret = misc_register(>misc); >>

Re: [PATCH] FMC: misc_register should not be called while atomic

2014-04-16 Thread Alessandro Rubini
--- a/drivers/fmc/fmc-chardev.c +++ b/drivers/fmc/fmc-chardev.c @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc) fc-misc.fops = fc_fops; fc-misc.name = kstrdup(dev_name(fmc-dev), GFP_KERNEL); -spin_lock(fc_lock); ret = misc_register(fc-misc); +

Re: [FMC] BUG: scheduling while atomic: swapper/1/0x10000002

2014-04-08 Thread Alessandro Rubini
Hello. Thank you for the report. I'm at a conference and I fear I won't be able to test myself in the next days, but I think this is already fixed (it is part of the "misc_register" call path, so it's the same problem). The fix is commit v3.11-rc2-11-g783c2fb 783c2fb FMC: fix locking in

Re: [FMC] BUG: scheduling while atomic: swapper/1/0x10000002

2014-04-08 Thread Alessandro Rubini
Hello. Thank you for the report. I'm at a conference and I fear I won't be able to test myself in the next days, but I think this is already fixed (it is part of the misc_register call path, so it's the same problem). The fix is commit v3.11-rc2-11-g783c2fb 783c2fb FMC: fix locking in sample

[PATCH 2/2] FMC: show_sdb_tree: dump synthesis/commit ID info

2014-02-22 Thread Alessandro Rubini
'spec_top_fmc_adcmc-projects/fmc-adc-100m14b4cha.git' \ synthesized 20140116 by mcattin (ISE version 133), commit f0a539dffe6d Signed-off-by: Tomasz Wlostowski Acked-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas --- drivers/fmc/fmc-sdb.c | 34

[PATCH 1/2] FMC: make eeprom attribute writable

2014-02-22 Thread Alessandro Rubini
This allows easier modification to the eeprom than loading the fmc-write-eeprom module. The carrier driver will refuse writing if the FPGA is not running the golden gateware image, so writing in practice is only available at manufacture/development time. Signed-off-by: Alessandro Rubini Acked

[PATCH 2/2] FMC: show_sdb_tree: dump synthesis/commit ID info

2014-02-22 Thread Alessandro Rubini
'spec_top_fmc_adcmc-projects/fmc-adc-100m14b4cha.git' \ synthesized 20140116 by mcattin (ISE version 133), commit f0a539dffe6d Signed-off-by: Tomasz Wlostowski tomasz.wlostow...@cern.ch Acked-by: Alessandro Rubini rub...@gnudd.com Acked-by: Juan David Gonzalez Cobas dco...@cern.ch

[PATCH 1/2] FMC: make eeprom attribute writable

2014-02-22 Thread Alessandro Rubini
This allows easier modification to the eeprom than loading the fmc-write-eeprom module. The carrier driver will refuse writing if the FPGA is not running the golden gateware image, so writing in practice is only available at manufacture/development time. Signed-off-by: Alessandro Rubini rub

[PATCH 1/2] FMC: support carriers with no mezzanine

2014-01-30 Thread Alessandro Rubini
ommit fixes one such checks and removes the other, so to actually accept slots with no mezzanines. That's because the carrier may offer some support anyways (the SPEC does), and working on the carrier with no mezzanine-specific driver is common during development. Signed-off-by: Alessandro R

[PATCH 2/2] FMC: show_sdb_tree: fix offset calculation

2014-01-30 Thread Alessandro Rubini
The code reported wrong addresses in the sdb dumps. All sdb addresses are relative, but the code was adding the base address twice. Bug exposed by a gateware image with two bridge levels. Thanks David for reporting the problem. Signed-off-by: Alessandro Rubini Reported-by: Juan David Gonzalez

[PATCH 2/2] FMC: show_sdb_tree: fix offset calculation

2014-01-30 Thread Alessandro Rubini
The code reported wrong addresses in the sdb dumps. All sdb addresses are relative, but the code was adding the base address twice. Bug exposed by a gateware image with two bridge levels. Thanks David for reporting the problem. Signed-off-by: Alessandro Rubini rub...@gnudd.com Reported

[PATCH 1/2] FMC: support carriers with no mezzanine

2014-01-30 Thread Alessandro Rubini
and removes the other, so to actually accept slots with no mezzanines. That's because the carrier may offer some support anyways (the SPEC does), and working on the carrier with no mezzanine-specific driver is common during development. Signed-off-by: Alessandro Rubini rub...@gnudd.com Acked-by: Juan

Re: [PATCH] fmc: Fix decimal permissions

2014-01-28 Thread Alessandro Rubini
> This 444 should have been octal. Right, my fault. We are not using the sysfs interface for module parameters, so I didn't notice. > Signed-off-by: Joe Perches Acked-by: Alessandro Rubini thanks /alessandro, with two other minor fmc fixes to submit soon -- To unsubscribe from thi

Re: [PATCH] fmc: Fix decimal permissions

2014-01-28 Thread Alessandro Rubini
This 444 should have been octal. Right, my fault. We are not using the sysfs interface for module parameters, so I didn't notice. Signed-off-by: Joe Perches j...@perches.com Acked-by: Alessandro Rubini rub...@gnudd.com thanks /alessandro, with two other minor fmc fixes to submit soon

Re: fmc: BUG: scheduling while atomic: swapper/0/1/0x00000002

2013-10-14 Thread Alessandro Rubini
Hello. > I'm getting the following with randconfig testing in kvm, config is > .attached. I acknowledge this is a bug of mine, and your .config shows your are testing v3.11. I posted the fix on Jul 16th 2013, and it is now in master as v3.11-rc2-11-g783c2fb. However it is not an ancestor of

Re: fmc: BUG: scheduling while atomic: swapper/0/1/0x00000002

2013-10-14 Thread Alessandro Rubini
Hello. I'm getting the following with randconfig testing in kvm, config is .attached. I acknowledge this is a bug of mine, and your .config shows your are testing v3.11. I posted the fix on Jul 16th 2013, and it is now in master as v3.11-rc2-11-g783c2fb. However it is not an ancestor of

Re: [PATCH] FMC: Staticize local symbols

2013-08-12 Thread Alessandro Rubini
> This local symbol is used only in this file. > Fix the following sparse warnings: Thanks! Acked-by: Alessandro Rubini /alessandro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [fmc] BUG: scheduling while atomic: swapper/0/1/0x00000002

2013-08-12 Thread Alessandro Rubini
> On 08/11/2013 09:52 PM, Fengguang Wu wrote: >> FYI, the bug still exists in the upstream and linux-next kernels. Strange. Greg approved the patch I sent. I see it in next-20130809 but also next-20130801 and other ones with the same hash: 783c2fb FMC: fix locking in sample chardev driver

Re: [fmc] BUG: scheduling while atomic: swapper/0/1/0x00000002

2013-08-12 Thread Alessandro Rubini
On 08/11/2013 09:52 PM, Fengguang Wu wrote: FYI, the bug still exists in the upstream and linux-next kernels. Strange. Greg approved the patch I sent. I see it in next-20130809 but also next-20130801 and other ones with the same hash: 783c2fb FMC: fix locking in sample chardev driver

Re: [PATCH] FMC: Staticize local symbols

2013-08-12 Thread Alessandro Rubini
This local symbol is used only in this file. Fix the following sparse warnings: Thanks! Acked-by: Alessandro Rubini rub...@gnudd.com /alessandro -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 00/26] STA2X11 devicetree support for amba/pci

2013-08-07 Thread Alessandro Rubini
[stripped list of issues from my original message follows] >> Some of the problems he found are: >> >> * Passing a dtb to the kernel: we use a modified kexec at present >> * Passing correct irq numbers to the AMBA drivers >> * Switching to a new gpio driver with devicetree support

Re: [PATCH 26/26] pinctrl: add support for sta2x11 (via pinctrl-nomadik)

2013-08-07 Thread Alessandro Rubini
> Maybe you could add a commit message? Ack (Davide is holidays, I grant that for him). > Apart from that it looks like a straight-forward plug-in to the > Nomadik pin controller, so I'd happily apply it, but I guess it > will go in through the x86 tree? It's part of a bigger series, that adds

[PATCH 02/26] DMA: PL330: use prefix in reg names to build under x86

2013-08-07 Thread Alessandro Rubini
be built by randomconfig after ARM_AMBA appears within x86. No other technical changes have been performed. The patch was build-tested only. Signed-off-by: Alessandro Rubini Link: http://lkml.kernel.org/r/1355146956-6009-2-git-send-email-cimina...@gnudd.com Acked-by: Giancarlo Asnaghi [Davide Cimin

[PATCH 00/26] STA2X11 devicetree support for amba/pci

2013-08-07 Thread Alessandro Rubini
s very difficult to pass over in the x86 world. On the other hand platform data is denied by x86 maintainers. So the question is: what is the right way (and the right dts structure) to deal with a hotplug bus that instantiates AMBA devices, without killing del self-detection features? Thanks /aless

[PATCH 03/26] mmc: Use the new

2013-08-07 Thread Alessandro Rubini
For portability, use . Signed-off-by: Alessandro Rubini Link: http://lkml.kernel.org/r/1355146956-6009-6-git-send-email-cimina...@gnudd.com Acked-by: Giancarlo Asnaghi Acked-by: David Brown Signed-off-by: H. Peter Anvin --- drivers/mmc/host/mmci.c |2 +- drivers/mmc/host/msm_sdcc.c

[PATCH 04/26] x86: add CONFIG_ARM_AMBA, selected by STA2X11

2013-08-07 Thread Alessandro Rubini
The sta2x11 I/O Hub is a bridge from PCIe to AMBA. It reuses a number of amba drivers and needs to activate core bus support. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi --- arch/x86/Kconfig |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/x86

[PATCH 05/26] drivers/amba: add support for a PCI bridge

2013-08-07 Thread Alessandro Rubini
This is a PCI driver that registers AMBA devices for the range of supported devices. It is currently used by STA2X11, which exports AMBA peripherals under PCIe. The original AMBA drivers work with no changes or minimal ones. Signed-off-by: Alessandro Rubini Acked-by: Giancarlo Asnaghi Cc

[PATCH 01/26] x86: fix warning for sta2x11

2013-08-07 Thread Alessandro Rubini
() without passing "attrs". The real solution, in my opinion, would be adding "attrs" as argument to swiotlb_free_coherent() and remove this new empty function as well as the identical ones found in other 6 files within arch. Signed-off-by: Alessandro Rubini Acked-by: Gianca

[PATCH 01/26] x86: fix warning for sta2x11

2013-08-07 Thread Alessandro Rubini
passing attrs. The real solution, in my opinion, would be adding attrs as argument to swiotlb_free_coherent() and remove this new empty function as well as the identical ones found in other 6 files within arch. Signed-off-by: Alessandro Rubini rub...@gnudd.com Acked-by: Giancarlo Asnaghi

[PATCH 03/26] mmc: Use the new linux/sizes.h

2013-08-07 Thread Alessandro Rubini
For portability, use linux/sizes.h. Signed-off-by: Alessandro Rubini rub...@gnudd.com Link: http://lkml.kernel.org/r/1355146956-6009-6-git-send-email-cimina...@gnudd.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com Acked-by: David Brown dav...@codeaurora.org Signed-off-by: H. Peter Anvin

[PATCH 04/26] x86: add CONFIG_ARM_AMBA, selected by STA2X11

2013-08-07 Thread Alessandro Rubini
The sta2x11 I/O Hub is a bridge from PCIe to AMBA. It reuses a number of amba drivers and needs to activate core bus support. Signed-off-by: Alessandro Rubini rub...@gnudd.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com --- arch/x86/Kconfig |4 1 files changed, 4 insertions

[PATCH 05/26] drivers/amba: add support for a PCI bridge

2013-08-07 Thread Alessandro Rubini
This is a PCI driver that registers AMBA devices for the range of supported devices. It is currently used by STA2X11, which exports AMBA peripherals under PCIe. The original AMBA drivers work with no changes or minimal ones. Signed-off-by: Alessandro Rubini rub...@gnudd.com Acked-by: Giancarlo

[PATCH 02/26] DMA: PL330: use prefix in reg names to build under x86

2013-08-07 Thread Alessandro Rubini
appears within x86. No other technical changes have been performed. The patch was build-tested only. Signed-off-by: Alessandro Rubini rub...@gnudd.com Link: http://lkml.kernel.org/r/1355146956-6009-2-git-send-email-cimina...@gnudd.com Acked-by: Giancarlo Asnaghi giancarlo.asna...@st.com [Davide

[PATCH 00/26] STA2X11 devicetree support for amba/pci

2013-08-07 Thread Alessandro Rubini
maintainers. So the question is: what is the right way (and the right dts structure) to deal with a hotplug bus that instantiates AMBA devices, without killing del self-detection features? Thanks /alessandro Alessandro Rubini (5): x86: fix warning for sta2x11 DMA: PL330: use prefix in reg names

Re: [PATCH 26/26] pinctrl: add support for sta2x11 (via pinctrl-nomadik)

2013-08-07 Thread Alessandro Rubini
Maybe you could add a commit message? Ack (Davide is holidays, I grant that for him). Apart from that it looks like a straight-forward plug-in to the Nomadik pin controller, so I'd happily apply it, but I guess it will go in through the x86 tree? It's part of a bigger series, that adds

Re: [PATCH 00/26] STA2X11 devicetree support for amba/pci

2013-08-07 Thread Alessandro Rubini
[stripped list of issues from my original message follows] Some of the problems he found are: * Passing a dtb to the kernel: we use a modified kexec at present * Passing correct irq numbers to the AMBA drivers * Switching to a new gpio driver with devicetree support *

[PATCH] FMC: fix locking in sample chardev driver

2013-07-16 Thread Alessandro Rubini
s own list. Reported-by: Sasha Levin Reported-by: Fengguang Wu Signed-off-by: Alessandro Rubini --- drivers/fmc/fmc-chardev.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/fmc/fmc-chardev.c b/drivers/fmc/fmc-chardev.c index cc031db..ace6ef2 100644 --- a/drive

[PATCH] FMC: fix locking in sample chardev driver

2013-07-16 Thread Alessandro Rubini
. Reported-by: Sasha Levin sasha.le...@oracle.com Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Alessandro Rubini rub...@gnudd.com --- drivers/fmc/fmc-chardev.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/fmc/fmc-chardev.c b/drivers/fmc/fmc

Re: [FMC] BUG: scheduling while atomic: swapper/1/0x10000002

2013-07-03 Thread Alessandro Rubini
Hello. > I got the below dmesg and the first bad commit is > > commit 4debfe409b6e550032bfef9733e9f6f7c5613617 > Author: Alessandro Rubini > Date: Tue Jun 18 23:48:07 2013 +0200 > > FMC: add a char-device mezzanine driver thank you for your report. I already

Re: [FMC] BUG: scheduling while atomic: swapper/1/0x10000002

2013-07-03 Thread Alessandro Rubini
Hello. I got the below dmesg and the first bad commit is commit 4debfe409b6e550032bfef9733e9f6f7c5613617 Author: Alessandro Rubini rub...@gnudd.com Date: Tue Jun 18 23:48:07 2013 +0200 FMC: add a char-device mezzanine driver thank you for your report. I already got a problem

Re: FMC: BUG: scheduling while atomic on boot

2013-06-20 Thread Alessandro Rubini
Hello. > I compiled FMC in to test it out, but when booting with it I get: Thank you for your report. I'll take a look tomorrow. I admit I only use it as a module (I'm on it even now, working on an ADC FMC board). Thanks again, I'll have a fix ASAP /alessandro -- To unsubscribe from this

Re: [patch] FMC: fix error handling in probe() function

2013-06-20 Thread Alessandro Rubini
> The call to kzalloc() wasn't checked. > The dev_info() message dereferenced freed memory on error. > > Signed-off-by: Dan Carpenter Acked-by: Alessandro Rubini Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [patch] FMC: fix error handling in probe() function

2013-06-20 Thread Alessandro Rubini
The call to kzalloc() wasn't checked. The dev_info() message dereferenced freed memory on error. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Alessandro Rubini rub...@gnudd.com Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: FMC: BUG: scheduling while atomic on boot

2013-06-20 Thread Alessandro Rubini
Hello. I compiled FMC in to test it out, but when booting with it I get: Thank you for your report. I'll take a look tomorrow. I admit I only use it as a module (I'm on it even now, working on an ADC FMC board). Thanks again, I'll have a fix ASAP /alessandro -- To unsubscribe from this

Re: [patch -next] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
>> +arr->record = kzalloc(sizeof(arr->record[0]) * n, GFP_KERNEL); >> +arr->subtree = kzalloc(sizeof(arr->subtree[0]) * n, GFP_KERNEL); > n comes from the hardware no? Yes. Length of hardware description array. > Maybe make these kcalloc too. I'm not a fan of kcalloc. I think it

Re: [patch] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
> Apparently these are going through Greg K-H. I'll resend, with Greg > CC'd so he can pick it up from the mailing list. > > Could you add an entry to the MAINTAINERS file so that Greg will be > CC'd automatically using get_maintainer.pl? Ok. Added to my todo list. > Is there a dedicated list

Re: [patch] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
> If we don't allocate "arr" then the cleanup path will dereference it and > oops. You are right, thanks (acked). How is the procedure here? I don't have my own git tree on kernel.org for pull requests. Can this go through the janitors? (if it makes sense, I can try the procedure to have a

Re: [PATCH 2/8] FMC: add needed headers

2013-06-19 Thread Alessandro Rubini
> The use of the 'readl' and 'writel' identifiers here causes build errors on > architectures where those are macros. This renames the fields to > read32/write32 > to avoid the problem. Thanks. I'll apply the same to my repo and related drivers. Acked-by: Alessandro Rubini

Re: [PATCH 2/8] FMC: add needed headers

2013-06-19 Thread Alessandro Rubini
The use of the 'readl' and 'writel' identifiers here causes build errors on architectures where those are macros. This renames the fields to read32/write32 to avoid the problem. Thanks. I'll apply the same to my repo and related drivers. Acked-by: Alessandro Rubini rub...@gnudd.com

Re: [patch] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
If we don't allocate arr then the cleanup path will dereference it and oops. You are right, thanks (acked). How is the procedure here? I don't have my own git tree on kernel.org for pull requests. Can this go through the janitors? (if it makes sense, I can try the procedure to have a tree,

Re: [patch -next] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
+arr-record = kzalloc(sizeof(arr-record[0]) * n, GFP_KERNEL); +arr-subtree = kzalloc(sizeof(arr-subtree[0]) * n, GFP_KERNEL); n comes from the hardware no? Yes. Length of hardware description array. Maybe make these kcalloc too. I'm not a fan of kcalloc. I think it removes

Re: [patch] FMC: NULL dereference on allocation failure

2013-06-19 Thread Alessandro Rubini
Apparently these are going through Greg K-H. I'll resend, with Greg CC'd so he can pick it up from the mailing list. Could you add an entry to the MAINTAINERS file so that Greg will be CC'd automatically using get_maintainer.pl? Ok. Added to my todo list. Is there a dedicated list for

[PATCH V3 4/6] FMC: add a software mezzanine driver

2013-06-18 Thread Alessandro Rubini
This simple do-nothing mezzanine driver shows how to write a mezzanine driver, that can also handle interrupts reported by the carrier. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00

[PATCH V3 6/6] FMC: add a char-device mezzanine driver

2013-06-18 Thread Alessandro Rubini
This driver exports the memory area associated with the mezzanine card as a misc device, so users can access registers. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX

[PATCH V3 2/6] FMC: add documentation for the core

2013-06-18 Thread Alessandro Rubini
This is selected sections of the current manual for fmc-bus, as developed outside of the kernel before submission. Like the other patches in this set, it corresponds to commit ab23167f of the repository at ohwr.org Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked

[PATCH V3 3/6] FMC: add a software carrier driver

2013-06-18 Thread Alessandro Rubini
), but they are bigger things and are not part of this submission. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX|3 + Documentation/fmc/fmc-fakedev.txt | 36 drivers/fmc

[PATCH V3 5/6] FMC: add a driver to write mezzanine EEPROM

2013-06-18 Thread Alessandro Rubini
This driver allows to reprogram the EEPROM in a mezzanine, to store its own identifiers during manufacturing or to save other useful data. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc

[PATCH V3 0/6] FMC: resending unapplied patches

2013-06-18 Thread Alessandro Rubini
Six patches from the series I initially sent on Jun 12. Changes in V3: all 6 yet unapplied by greg are resent, in correct order. Changes in V2: turned a generic "public domain" note for code to be reused into a proper BSD-like license, but I only resent affected patches, in error.

[PATCH V3 1/6] FMC: add core bus driver

2013-06-18 Thread Alessandro Rubini
in the FPGA, and dumping it for diagnostics. SDB is not mandatory. Files in this commit correspond to commit ab23167f in the master branch of the project hosted on ohwr.org. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias

Re: [PATCH V2 0/2] FMC: resend sample drivers

2013-06-18 Thread Alessandro Rubini
> Did I only not apply 2 patches? I thought there should be some more > that I'm missing here. Can you resend _everything_ that I need to apply > that I haven't already? Ok. I wondered which magic tools of yours would use "v2" to rebuild the series in the same order. Sneding the whole 6-lot in

[PATCH V2 1/2] FMC: add a software carrier driver

2013-06-18 Thread Alessandro Rubini
), but they are bigger things and are not part of this submission. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00-INDEX|3 + Documentation/fmc/fmc-fakedev.txt | 36 drivers/fmc

[PATCH V2 2/2] FMC: add a software mezzanine driver

2013-06-18 Thread Alessandro Rubini
This simple do-nothing mezzanine driver shows how to write a mezzanine driver, that can also handle interrupts reported by the carrier. Signed-off-by: Alessandro Rubini Acked-by: Juan David Gonzalez Cobas Acked-by: Emilio G. Cota Acked-by: Samuel Iglesias Gonsalvez --- Documentation/fmc/00

[PATCH V2 0/2] FMC: resend sample drivers

2013-06-18 Thread Alessandro Rubini
the distribution policies. I rebased to next-20130617 and rebuilt, with no conflicts. In any of the patches of the original series. [1] https://lkml.org/lkml/2013/6/17/772: "Just redo those two patches and send them as 'v2'") Alessandro Rubini (2): FMC: add a software carrier driver

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-18 Thread Alessandro Rubini
> Alessandro, care to respin the patches that I didn't apply and resend > them so that I can? Yes, ASAP. But, according to the later message by David, I'll respin with the BSD license for demo code and EXPORT_SYMBOL (no GPL-only clause): https://lkml.org/lkml/2013/6/18/119 "As mentioned,

Re: [PATCH 3/8] FMC: add core bus driver

2013-06-18 Thread Alessandro Rubini
Alessandro, care to respin the patches that I didn't apply and resend them so that I can? Yes, ASAP. But, according to the later message by David, I'll respin with the BSD license for demo code and EXPORT_SYMBOL (no GPL-only clause): https://lkml.org/lkml/2013/6/18/119 As mentioned, CERN

[PATCH V2 0/2] FMC: resend sample drivers

2013-06-18 Thread Alessandro Rubini
the distribution policies. I rebased to next-20130617 and rebuilt, with no conflicts. In any of the patches of the original series. [1] https://lkml.org/lkml/2013/6/17/772: Just redo those two patches and send them as 'v2') Alessandro Rubini (2): FMC: add a software carrier driver FMC: add

[PATCH V2 1/2] FMC: add a software carrier driver

2013-06-18 Thread Alessandro Rubini
), but they are bigger things and are not part of this submission. Signed-off-by: Alessandro Rubini rub...@gnudd.com Acked-by: Juan David Gonzalez Cobas dco...@cern.ch Acked-by: Emilio G. Cota c...@braap.org Acked-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- Documentation/fmc/00-INDEX|3

[PATCH V2 2/2] FMC: add a software mezzanine driver

2013-06-18 Thread Alessandro Rubini
This simple do-nothing mezzanine driver shows how to write a mezzanine driver, that can also handle interrupts reported by the carrier. Signed-off-by: Alessandro Rubini rub...@gnudd.com Acked-by: Juan David Gonzalez Cobas dco...@cern.ch Acked-by: Emilio G. Cota c...@braap.org Acked-by: Samuel

Re: [PATCH V2 0/2] FMC: resend sample drivers

2013-06-18 Thread Alessandro Rubini
Did I only not apply 2 patches? I thought there should be some more that I'm missing here. Can you resend _everything_ that I need to apply that I haven't already? Ok. I wondered which magic tools of yours would use v2 to rebuild the series in the same order. Sneding the whole 6-lot in a few

[PATCH V3 0/6] FMC: resending unapplied patches

2013-06-18 Thread Alessandro Rubini
Six patches from the series I initially sent on Jun 12. Changes in V3: all 6 yet unapplied by greg are resent, in correct order. Changes in V2: turned a generic public domain note for code to be reused into a proper BSD-like license, but I only resent affected patches, in error. Alessandro

  1   2   3   >