/amdgpu/amdgpu_cs.c:1656: warning: expecting prototype
> > for amdgpu_cs_find_bo_va(). Prototype was for amdgpu_cs_find_mapping()
> > instead
> >
> > Cc: Alex Deucher
> > Cc: "Christian König"
> > Cc: David Airlie
> > Cc: Daniel
t; > or member 'sched_score' not described in 'amdgpu_ring_init'
> >
> > Cc: Alex Deucher
> > Cc: "Christian König"
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Cc: Sumit Semwal
> > Cc: amd-...@lists.freedesktop.org
> > C
for amdgpu_copy_ttm_mem_to_mem(). Prototype was for
> > amdgpu_ttm_copy_mem_to_mem() instead
> >
> > Cc: Alex Deucher
> > Cc: "Christian König"
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Cc: Sumit Semwal
> > Cc: Jerome Glisse
>
gt; for amdgpu_dummy_page_init(). Prototype was for
> > amdgpu_gart_dummy_page_init() instead
> > drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:96: warning: expecting prototype
> > for amdgpu_dummy_page_fini(). Prototype was for
> > amdgpu_gart_dummy_page_fini() instead
>
rameter or member 'sched_score' not described in
> > 'amdgpu_fence_driver_init_ring'
> >
> > Cc: Alex Deucher
> > Cc: "Christian König"
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Cc: Sumit Semwal
> > Cc: Jerome Glisse
> &
with '/**', but isn't a kernel-doc comment. Refer
> > Documentation/doc-guide/kernel-doc.rst
> >
> > Cc: Alex Deucher
> > Cc: "Christian König"
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Cc: amd-...@lists.freedesktop.org
> > Cc:
: variable ‘r’ set
> but not used [-Wunused-but-set-variable]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Sumit Semwal
> Cc: amd-...@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org
> Cc: linux-
On Fri, Apr 16, 2021 at 11:32 AM Christian König
wrote:
>
> Am 16.04.21 um 16:37 schrieb Lee Jones:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/ttm/ttm_bo.c:293: warning: expecting prototype for
> > function ttm_bo_cleanup_refs(). Prototype was for
On Fri, Apr 16, 2021 at 1:47 AM Liang, Prike wrote:
>
> [AMD Public Use]
>
> > From: Stephen Rothwell
> > Sent: Friday, April 16, 2021 12:09 PM
> > To: Liang, Prike
> > Cc: Alex Deucher ; S-k, Shyam-sundar > sundar@amd.com>; Linux Kernel Mailing List
On Fri, Apr 16, 2021 at 12:48 AM David Niklas wrote:
>
> Hey,
>
> I forgot to give you a bug tracker in case you want one.
> Here: https://bugzilla.kernel.org/show_bug.cgi?id=212691
I've followed up on the bug report. Please take a look there.
Alex
>
> Thanks,
> David
>
Applied. Thanks!
Alex
On Thu, Apr 15, 2021 at 5:30 AM Yang Li wrote:
>
> Kernel test robot throws below warning ->
>
> smatch warnings:
> drivers/gpu/drm/radeon/si.c:4514 si_vm_packet3_cp_dma_check() warn:
> inconsistent indenting
>
> Fixed the inconsistent indenting.
>
> Reported-by: Abaci
On Tue, Apr 13, 2021 at 2:37 PM Daniel Vetter wrote:
>
> On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher wrote:
> >
> > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng
> > wrote:
> > >
> > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb
r efifb stays at PCI
> D0")
> BugLink: https://bugs.launchpad.net/bugs/1922403
> Signed-off-by: Kai-Heng Feng
Reviewed-by: Alex Deucher
> ---
> drivers/video/fbdev/efifb.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/efi
Applied. Thanks!
Alex
On Wed, Apr 7, 2021 at 2:23 AM wrote:
>
> From: Yingjie Wang
>
> In radeon_dp_mst_detect(), We should check whether or not @connector
> has been unregistered from userspace. If the connector is unregistered,
> we should return disconnected status.
>
> Fixes: 9843ead08f18
On Tue, Apr 6, 2021 at 10:13 AM Carlis wrote:
>
> From: Xuezhi Zhang
>
> Fix the following coccicheck warning:
> drivers/gpu/drm/amd/pm//amdgpu_pm.c:1940:8-16:
> WARNING: use scnprintf or sprintf
> drivers/gpu/drm/amd/pm//amdgpu_pm.c:1978:8-16:
> WARNING: use scnprintf or sprintf
>
)
> >> knlGS:
> >> [17359.930047] CS: 0010 DS: ES: CR0: 80050033
> >> [17359.936674] CR2: CR3: 0006d700e005 CR4:
> >> 001706e0
> > From what I understand, the init_user_pages fails (r
Current code already contains the fix.
Alex
On Thu, Apr 1, 2021 at 9:09 AM Christian König
wrote:
>
> Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> > Keep sparse happy by preserving the __user annotation when casting.
> >
> > Reported-by: kernel test robot
> > Signed-off-by: Rasmus
This code has been dropped.
Alex
On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote:
>
> Fix checkpatch.pl warning:
> Too many leading tabs - consider code refactoring
> WARNING: Too many leading tabs - consider code refactoring
> + for (j = 0; j <
Applied. Thanks!
Alex
On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote:
>
> Fix patch check warning:
> WARNING: suspect code indent for conditional statements (8, 17)
> + if (obj && obj->use < 0) {
> +DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n",
> obj->head.name);
>
Applied. Thanks!
On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote:
>
> Fix patch check warning:
> WARNING: Prefer kmalloc_array over kmalloc with multiply
> + buf = kmalloc(MAX_KFIFO_SIZE * sizeof(*buf), GFP_KERNEL);
>
> Signed-off-by: Bernard Zhao
> ---
>
Applied. Thanks!
Alex
On Tue, Mar 30, 2021 at 12:21 PM Christian König
wrote:
>
> Reviewed-by: Christian König for the entire
> series.
>
> Alex will probably pick them up for the next feature pull request.
>
> Regards,
> Christian.
>
> Am 30.03.21 um 17:33 schrieb Xℹ Ruoyao:
> > In AMDGPU
On Mon, Mar 29, 2021 at 9:36 PM 万家兵 wrote:
>
>
> >On Sat, Mar 27, 2021 at 3:28 AM Wan Jiabing wrote:
> >>
> >> struct dc_state has been declared at 273rd line.
> >> Remove the duplicate.
> >> Delete duplicate blank lines.
> >
> >Can you split these into separate patches?
> >
> >Alex
>
> OK. But
On Sat, Mar 27, 2021 at 3:28 AM Wan Jiabing wrote:
>
> struct dc_state has been declared at 273rd line.
> Remove the duplicate.
> Delete duplicate blank lines.
Can you split these into separate patches?
Alex
>
> Signed-off-by: Wan Jiabing
> ---
> drivers/gpu/drm/amd/display/dc/dc.h | 10
Hi Mark. I've fixed this up in my tree.
Alex
On Mon, Mar 29, 2021 at 10:18 AM Mark Yacoub wrote:
>
> oh this sucks. I'll look into my config and fix it. Thanks Stephen for
> bringing it to my attention!
>
> On Sun, Mar 28, 2021 at 5:24 PM Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> >
Applied. Thanks!
Alex
On Sun, Mar 28, 2021 at 1:35 AM Diego Viola wrote:
>
> Signed-off-by: Diego Viola
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>
Applied. Thanks!
Alex
On Mon, Mar 22, 2021 at 6:45 PM Randy Dunlap wrote:
>
> On 3/22/21 2:06 PM, Bhaskar Chowdhury wrote:
> >
> > s/defintion/definition/ .two different places.
> >
> > Signed-off-by: Bhaskar Chowdhury
>
> Acked-by: Randy Dunlap
>
> > ---
> >
Applied. Thanks!
Alex
On Thu, Mar 25, 2021 at 5:26 AM Nirmoy wrote:
>
>
> Reviewed-by: Nirmoy Das
>
> On 3/25/21 9:53 AM, Bhaskar Chowdhury wrote:
> > s/acccess/access/
> > s/inferface/interface/
> > s/sequnce/sequence/ .two different places.
> > s/retrive/retrieve/
> >
Applied. Thanks!
Alex
On Wed, Mar 24, 2021 at 7:46 PM Randy Dunlap wrote:
>
> On 3/24/21 4:29 PM, Bhaskar Chowdhury wrote:
> > s/miror/mirror/
> > s/needind/needing/
> > s/informations/information/
> >
> > Signed-off-by: Bhaskar Chowdhury
>
> Acked-by: Randy Dunlap
>
> Thanks.
>
> > ---
> >
Applied. Thanks!
Alex
On Wed, Mar 24, 2021 at 9:37 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> A previous fix I did left a rather complicated loop in
> amdgpu_securedisplay_debugfs_write() for what could be expressed in a
> simple sprintf, as Rasmus pointed out.
>
> This drops the
Applied. Thanks!
Alex
On Tue, Mar 23, 2021 at 9:04 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> gcc warns about an sprintf() that uses the same buffer as source
> and destination, which is undefined behavior in C99:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c: In function
>
Same patch was already applied recently.
Thanks,
Alex
On Mon, Mar 22, 2021 at 9:19 PM Wan Jiabing wrote:
>
> ../hw_ddc.h, ../hw_gpio.h and ../hw_hpd.h have been included
> at line 32, so remove them.
>
> Signed-off-by: Wan Jiabing
> ---
>
The same patch was already applied recently. Thanks!
Alex
On Mon, Mar 22, 2021 at 9:10 PM Wan Jiabing wrote:
>
> dce110/dce110_resource.h has been included at line 58, so remove
> the duplicate include at line 64.
>
> Signed-off-by: Wan Jiabing
> ---
>
Applied. Thanks!
Alex
On Mon, Mar 22, 2021 at 7:55 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> clang points out that the %hu format string does not match the type
> of the variables here:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:263:7: warning: format specifies type
> 'unsigned
Applied. Thanks!
Alex
On Mon, Mar 22, 2021 at 8:10 AM Christian König
wrote:
>
>
>
> Am 22.03.21 um 13:02 schrieb Wan Jiabing:
> > amdgpu_hdp.h has been included at line 91, so remove
> > the duplicate include.
> >
> > Signed-off-by: Wan Jiabing
>
> Acked-by: Christian König
>
> > ---
> >
Applied. Thanks!
Alex
On Sun, Mar 21, 2021 at 5:33 AM Qu Huang wrote:
>
> Here is the system crash log:
> [ 1272.884438] BUG: unable to handle kernel NULL pointer dereference at
> (null)
> [ 1272.88] IP: [< (null)>] (null)
> [ 1272.884447] PGD 825b09067 PUD 8267c8067 PMD
Applied. Thanks!
Alex
On Sat, Mar 20, 2021 at 3:10 PM Randy Dunlap
wrote:
>
>
>
> On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote:
>
> >
> > s/seralization/serialization/
> > s/parallism/parallelism/
> >
> > Signed-off-by: Bhaskar Chowdhury
>
> Acked-by: Randy Dunlap
>
>
> > ---
> >
Applied. Thanks!
Alex
On Mon, Mar 22, 2021 at 3:40 AM Christian König
wrote:
>
> Am 21.03.21 um 16:19 schrieb Tong Zhang:
> > TTM_PL_VRAM may not initialized at all when calling
> > radeon_bo_evict_vram(). We need to check before doing eviction.
> >
> > [2.160837] BUG: kernel NULL pointer
On Sun, Mar 21, 2021 at 8:12 PM Evan Benn wrote:
>
> On Sat, Mar 20, 2021 at 8:36 AM Alex Deucher wrote:
> >
> > On Fri, Mar 19, 2021 at 5:31 PM Evan Benn wrote:
> > >
> > > On Sat, 20 Mar 2021 at 02:10, Harry Wentland
> > > wrote:
> &g
On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap
wrote:
>
>
>
> On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
>
> > s/traing/training/
> >
> > ...Plus the entire sentence construction for better readability.
> >
> > Signed-off-by: Bhaskar Chowdhury
> > ---
> > Changes from V1:
> > Alex and Randy's
On Fri, Mar 19, 2021 at 5:31 PM Evan Benn wrote:
>
> On Sat, 20 Mar 2021 at 02:10, Harry Wentland wrote:
> > On 2021-03-19 10:22 a.m., Alex Deucher wrote:
> > > On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote:
> > >>
> > >> AMDGPU_DM_DEF
On Fri, Mar 19, 2021 at 2:47 PM Christian König
wrote:
>
>
>
> Am 19.03.21 um 19:26 schrieb Harry Wentland:
> > On 2021-03-19 2:13 p.m., Alex Deucher wrote:
> >> + Harry, Nick
> >>
> >> On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
> >>
On Fri, Mar 19, 2021 at 2:26 PM Harry Wentland wrote:
>
> On 2021-03-19 2:13 p.m., Alex Deucher wrote:
> > + Harry, Nick
> >
> > On Fri, Mar 19, 2021 at 4:24 AM Lee Jones wrote:
> >>
> >> Fixes the following W=1 kernel build warning(s):
> >>
&g
./display/dc/dce80/dce80_resource.c:868:6:
> warning: no previous prototype for ‘dce80_validate_bandwidth’
> [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:913:16:
> warning: no previous prototype for ‘dce80_validate_global’
> [-Wmissing-proto
.c:2016:1: warning:
> the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Colin Ian
On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote:
>
> AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12
> to ensure no display backlight will flicker at low user brightness
> settings. However this value is quite bright, so for devices that do not
> implement the ACPI ATIF
>
Applied both patches. Thanks!
Alex
On Thu, Mar 18, 2021 at 7:20 PM Bhaskar Chowdhury wrote:
>
>
> s/proces/process/
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Applied. Thanks!
Alex
On Thu, Mar 18, 2021 at 5:00 AM Koenig, Christian
wrote:
>
> Reviewed-by: Christian König
>
> Von: Daniel Gomez
> Gesendet: Donnerstag, 18. März 2021 09:32
> Cc: dag...@gmail.com ; Daniel Gomez ;
> Deucher, Alexander ; Koenig, Christian
Applied. Thanks!
Alex
On Wed, Mar 17, 2021 at 12:09 PM Daniel Gomez wrote:
>
> If userptr pages have been pinned but not bounded,
> they remain uncleared.
>
> Signed-off-by: Daniel Gomez
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3
On Thu, Mar 18, 2021 at 2:08 PM Randy Dunlap wrote:
>
> On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote:
> >
> > s/traing/training/
> >
> > Signed-off-by: Bhaskar Chowdhury
> > ---
> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff
On Wed, Mar 17, 2021 at 10:37 PM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c:220:65-70:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Applied. Thanks. In
On Tue, Mar 16, 2021 at 4:09 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:721:65-70: WARNING:
> conversion to bool not needed here.
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp.c:1139:67-72: WARNING:
> conversion
Applied. Thanks!
Alex
On Mon, Mar 15, 2021 at 4:22 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c:358:69-74: WARNING:
> conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
>
On Sun, Mar 14, 2021 at 11:22 PM Bhaskar Chowdhury
wrote:
>
>
> s/"an minimum"/"a minimum"/
> s/"an maxmum"/"a maximum"/
>
> Signed-off-by: Bhaskar Chowdhury
Applied. Thanks!
Alex
> ---
> Changes from V1:
> Randy's suggestion to adjust the subject line text
> And missed out a spell
Applied. Thanks!
Alex
On Thu, Mar 11, 2021 at 11:34 AM Colin King wrote:
>
> From: Colin Ian King
>
> The variable result is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
>
Applied. Thanks!
Alex
On Fri, Mar 12, 2021 at 5:08 AM Colin King wrote:
>
> From: Colin Ian King
>
> There is a spelling mistake in an assert message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 2 +-
> 1 file changed, 1
On Mon, Mar 15, 2021 at 4:04 AM Nicholas Johnson
wrote:
>
> When using some Thunderbolt hosts using BIOS-assisted PCI enumeration
> with IO BAR assigned, we get an atombios timeout, such as:
>
> [drm:atom_op_jump [amdgpu]] *ERROR* atombios stuck in loop for more than
> 20secs aborting
>
On Thu, Mar 11, 2021 at 10:02 AM Alexandre Desnoyers wrote:
>
> On Thu, Mar 11, 2021 at 2:49 PM Daniel Gomez wrote:
> >
> > On Thu, 11 Mar 2021 at 10:09, Daniel Gomez wrote:
> > >
> > > On Wed, 10 Mar 2021 at 18:06, Alex Deucher wrote:
> > > >
Applied. Thanks!
Alex
On Thu, Mar 11, 2021 at 4:28 AM Colin King wrote:
>
> From: Colin Ian King
>
> There is a spelling mistake in a drm debug message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Wed, Mar 10, 2021 at 11:37 AM Daniel Gomez wrote:
>
> Disabling GFXOFF via the quirk list fixes a hardware lockup in
> Ryzen V1605B, RAVEN 0x1002:0x15DD rev 0x83.
>
> Signed-off-by: Daniel Gomez
> ---
>
> This patch is a continuation of the work here:
> https://lkml.org/lkml/2021/2/3/122
On Tue, Mar 9, 2021 at 12:55 PM Jean-Philippe Brucker
wrote:
>
> Hi Felix,
>
> On Tue, Mar 09, 2021 at 11:30:19AM -0500, Felix Kuehling wrote:
> > > I think the proper fix would be to not rely on custom hooks into a
> > > particular
> > > IOMMU driver, but to instead ensure that the amdgpu
On Sun, Mar 7, 2021 at 10:14 PM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1600:40-45: WARNING: conversion
> to bool not needed here.
>
> ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1598:40-45: WARNING: conversion
> to bool not needed
On Sun, Mar 7, 2021 at 10:00 PM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:561:34-39: WARNING:
> conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
This patch was already
Applied. Thanks!
Alex
On Sat, Mar 6, 2021 at 6:05 AM wrote:
>
> From: Zhang Yunkai
>
> 'dce110_resource.h' included in 'dcn21_resource.c' is duplicated.
> 'hw_gpio.h' included in 'hw_factory_dce110.c' is duplicated.
>
> Signed-off-by: Zhang Yunkai
> ---
>
Applied. Thanks!
Alex
On Sat, Mar 6, 2021 at 5:48 AM wrote:
>
> From: Zhang Yunkai
>
> 'drm/drm_hdcp.h' included in 'amdgpu_dm.c' is duplicated.
> It is also included in the 79th line.
>
> Signed-off-by: Zhang Yunkai
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> 1 file
Applied. Thanks!
Alex
On Thu, Mar 4, 2021 at 11:02 PM Quan, Evan wrote:
>
> [AMD Public Use]
>
> Thanks. Reviewed-by: Evan Quan
>
> -Original Message-
> From: Jia-Ju Bai
> Sent: Friday, March 5, 2021 11:54 AM
> To: Deucher, Alexander ; Koenig, Christian
> ; airl...@linux.ie;
The same patch was already applied a while ago.
Thanks,
Alex
On Fri, Mar 5, 2021 at 1:41 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8257:16-21: WARNING:
> conversion to bool not needed here.
>
> Reported-by: Abaci
Applied. Thanks!
Alex
On Wed, Mar 3, 2021 at 2:05 PM Gustavo A. R. Silva
wrote:
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these
Applied. thanks.
Alex
On Wed, Mar 3, 2021 at 8:25 AM Colin King wrote:
>
> From: Colin Ian King
>
> The continue statement in a for-loop is redudant and can be removed.
> Clean up the code to address this.
>
> Addresses-Coverity: ("Continue as no effect")
> Fixes: b6f91fc183f7
Applied. Thanks!
Alex
On Wed, Mar 3, 2021 at 9:07 AM Colin King wrote:
>
> From: Colin Ian King
>
> The variable status is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
>
Applied. Thanks!
Alex
On Thu, Mar 4, 2021 at 3:02 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:956:52-57: WARNING:
> conversion to bool not needed here.
>
>
ISABLE’)
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:214:16: note: in
> expansion of macro ‘AUX_SW_DATA__AUX_SW_AUTOINCREMENT_DISABLE_MASK’
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:127:2: note: in
> expansion of macro ‘AUX_SF’
>
> Cc: Harry Wentland
> Cc: Leo Li
> Cc:
462:11:
> warning: unused variable ‘pixel_clock_10KHz_in’ [-Wunused-variable]
>
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Lee Jones
> Cc: amd-...@lists.freedesktop.org
> C
_table.c: In function
> ‘adjust_display_pll_v2’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1459:35:
> warning: variable ‘params’ set but not used [-Wunused-but-set-variable]
>
> Cc: Harry Wentland
> Cc: Leo Li
> Cc: Alex Deucher
> Cc: "Christian Kön
Applied. Thanks!
Alex
On Wed, Mar 3, 2021 at 2:42 AM Christian König wrote:
>
> Am 03.03.21 um 01:27 schrieb Colin King:
> > From: Colin Ian King
> >
> > Currently the ioctl command RADEON_INFO_SI_BACKEND_ENABLED_MASK can
> > copy back uninitialised data in value_tmp that pointer *value
On Wed, Mar 3, 2021 at 4:18 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:2252:40-45: WARNING: conversion
> to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Applied. Thanks!
Alex
> ---
>
On Mon, Mar 1, 2021 at 9:21 AM Geert Uytterhoeven wrote:
>
> On Mon, 1 Mar 2021, Geert Uytterhoeven wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v5.12-rc1[1] compared to v5.11[2].
> >
> > Summarized:
> > - build errors: +2/-0
>
> > [1]
> >
Applied. Thanks!
Alex
On Mon, Mar 1, 2021 at 1:50 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:298:33-38:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
On Thu, Feb 25, 2021 at 10:01 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> clang points out that the new logic uses an always-uninitialized
> array index:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9810:38: warning:
> variable 'i' is uninitialized when used here
Applied. Thanks!
Alex
On Tue, Mar 2, 2021 at 10:03 AM Harry Wentland wrote:
>
> On 2021-03-02 9:05 a.m., Colin King wrote:
> > From: Colin Ian King
> >
> > Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or
> > SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized
On Fri, Feb 26, 2021 at 4:42 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c:273:16-21: WARNING:
> conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Applied. Thanks!
Alex
>
On Fri, Feb 26, 2021 at 4:17 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:924:47-52:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Applied. Thanks!
On Thu, Feb 25, 2021 at 10:01 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> clang points out that the new logic uses an always-uninitialized
> array index:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9810:38: warning:
> variable 'i' is uninitialized when used here
On Thu, Feb 25, 2021 at 4:19 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:243:67-72:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Applied. Thanks!
On Thu, Feb 25, 2021 at 4:02 AM Yang Li wrote:
>
> Fix the following coccicheck warning:
> ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1589:0-23: WARNING:
> fops_ib_preempt should be defined with DEFINE_DEBUGFS_ATTRIBUTE
> ./drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1592:0-23: WARNING:
>
On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion
> to bool not needed here.
>
> ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion
> to bool not needed
On Mon, Feb 22, 2021 at 3:13 PM Souptick Joarder wrote:
>
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38:
> >> warning: variable 'i' is uninitialized when used here
> >> [-Wuninitialized]
>timing = >detailed_timings[i];
>
yeah, fdo ran out of disk space so I moved to gitlab:
https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next
Alex
On Mon, Feb 22, 2021 at 7:26 PM Bas Nieuwenhuizen
wrote:
>
> I think Alex moved to gitlab for his branches
>
> On Tue, Feb 23, 2021, 12:50 AM Simon Ser wrote:
>>
>> On
On Wed, Feb 10, 2021 at 8:14 AM Daniel Vetter wrote:
>
> On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote:
> > Reviewed-by: Christian König for the series.
>
> Smash it into -misc?
@Christian Koenig did these ever land? I don't see them in drm-misc.
Alex
> -Daniel
>
> >
> > Am
This was already fixed by a patch from Yang Li .
Alex
On Tue, Feb 23, 2021 at 1:13 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8260:16-21: WARNING:
> conversion to bool not needed here.
>
> Reported-by: Abaci Robot
Applied. Thanks!
Alex
On Sat, Feb 20, 2021 at 3:35 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1621:40-45: WARNING: conversion
> to bool not needed here.
>
> ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1619:40-45: WARNING:
Applied. Thanks!
Alex
On Sat, Feb 20, 2021 at 2:16 AM Jiapeng Chong
wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:544:34-39: WARNING:
> conversion to bool not needed here.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Applied. Thanks!
Alex
On Sun, Feb 21, 2021 at 10:15 PM Quan, Evan wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Reviewed-by: Evan Quan
>
> -Original Message-
> From: amd-gfx On Behalf Of Jiapeng
> Chong
> Sent: Saturday, February 20, 2021 10:55 AM
> To:
Applied. Thanks!
Alex
On Thu, Feb 18, 2021 at 6:12 PM Wang, Kevin(Yang) wrote:
>
> thanks,
>
> Reviewed-by: Kevin Wang
>
> Regards,
> Kevin
>
> > 在 2021年2月19日，06:49，Nathan Chancellor 写道：
> >
> > Clang warns:
> >
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning:
> >
On Sun, Feb 21, 2021 at 6:45 PM Nathan Chancellor wrote:
>
> On Sun, Feb 21, 2021 at 03:07:17PM -0800, Linus Torvalds wrote:
> > On Thu, Feb 18, 2021 at 10:06 PM Dave Airlie wrote:
> > >
> > > Let me know if there are any issues,
> >
> > gcc was happy, and I obviously already pushed out my
Applied. Thanks!
Alex
On Thu, Feb 18, 2021 at 9:23 AM Yang Li wrote:
>
> Fix the following coccicheck warning:
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8142:16-21: WARNING:
> conversion to bool not needed here
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
>
Applied. Thanks!
Alex
On Mon, Feb 15, 2021 at 5:43 AM Christian König
wrote:
>
>
>
> Am 15.02.21 um 11:21 schrieb Chen Lin:
> > From: Chen Lin
> >
> > Remove the 'radeon_packet3_check_t' typedef as it is not used.
> >
> > Signed-off-by: Chen Lin
>
> Reviewed-by: Christian König
>
> > ---
>
On Wed, Feb 10, 2021 at 6:49 PM Gustavo A. R. Silva
wrote:
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of
On Wed, Feb 10, 2021 at 5:40 PM Gustavo A. R. Silva
wrote:
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of
On Wed, Feb 10, 2021 at 6:36 PM Gustavo A. R. Silva
wrote:
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of
On Wed, Feb 10, 2021 at 4:23 PM Gustavo A. R. Silva
wrote:
>
> Fix potential integer overflow by casting actual_calculated_clock_100hz
> to u64, in order to give the compiler complete information about the
> proper arithmetic to use.
>
> Notice that such variable is used in a context that expects
1 - 100 of 1443 matches
Mail list logo
