Re: [PATCH v5] docs/zh_CN: add translations in zh_CN/dev-tools/gcov

2021-04-14 Thread Alex Shi
Reviewed-by: Alex Shi On 2021/4/14 下午9:21, Wu XiangCheng wrote: > From: Bernard Zhao > > Add new zh translations > * zh_CN/dev-tools/gcov.rst > * zh_CN/dev-tools/index.rst > and link them to zh_CN/index.rst > > Signed-off-by: Bernard Zhao > Reviewed-by: Wu Xian

Re: [PATCH v4] docs/zh_CN: add translations in zh_CN/dev-tools/gcov

2021-04-14 Thread Alex Shi
On 2021/4/14 下午7:24, Wu XiangCheng wrote: > From: Bernard Zhao > > Add new zh translations > * zh_CN/dev-tools/gcov.rst > * zh_CN/dev-tools/index.rst > and link them to zh_CN/index.rst > > Signed-off-by: Bernard Zhao > Reviewed-by: Wu Xiangcheng > Signed-off-by: Wu XiangCheng > --- >

Re: [PATCH v1 1/4] docs: make reporting-issues.rst official and delete reporting-bugs.rst

2021-03-31 Thread Alex Shi
On 2021/3/31 下午4:33, Wu X.C. wrote: > Cc Alex Shi's new email > > On Tue, Mar 30, 2021 at 04:13:04PM +0200, Thorsten Leemhuis wrote: >> Removing Documentation/admin-guide/reporting-bugs.rst will break links >> in some of the translations. I was unsure if simply changing them to >>

[PATCH 1/2] mailmap: update email address for Alex Shi

2021-03-26 Thread Alex Shi
Add my kernel.org address for old email address. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Jonathan Corbet Cc: Kees Cook Cc: Leon Romanovsky Cc: Thomas Bogendoerfer Cc: Alexander Lobakin Cc: linux-kernel@vger.kernel.org --- .mailmap | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 2/2] Docs/zh_CN: update Alex Shi new email address

2021-03-26 Thread Alex Shi
I am leaving Alibaba, udpate the old email address to new one. Signed-off-by: Alex Shi Cc: Harry Wei Cc: Alex Shi Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- Documentation/translations/zh_CN/disclaimer-zh_CN.rst | 2 +- MAINTAINERS

Re: [PATCH v1 14/14] mm: multigenerational lru: documentation

2021-03-19 Thread Alex Shi
在 2021/3/13 下午3:57, Yu Zhao 写道: > +Recipes > +--- > +:Android on ARMv8.1+: ``X=4``, ``N=0`` > + > +:Android on pre-ARMv8.1 CPUs: Not recommended due to the lack of > + ``ARM64_HW_AFDBM`` > + > +:Laptops running Chrome on x86_64: ``X=7``, ``N=2`` > + > +:Working set estimation: Write ``+

Re: [PATCH] PATCH Documentation translations:translate sound/hd-audio/controls to chinese

2021-03-04 Thread Alex Shi
Reviewed-by: Alex Shi 在 2021/3/4 下午5:45, hjh 写道: > Signed-off-by: hjh > --- > Documentation/translations/zh_CN/index.rst| 1 + > .../zh_CN/sound/hd-audio/controls.rst | 102 ++ > .../zh_CN/sound/hd-audio/index.rst| 14 +++ > .../

Re: [PATCH] PATCH Documentation translations:translate sound/hd-audio/controls to chinese

2021-03-03 Thread Alex Shi
在 2021/3/2 下午5:13, huangjianghui 写道: >> we usually include patch into email instead of attach it as attachment. >> You can try use 'git send-email' to post your patches. >> >> Thanks >> Alex >> >> > I am sorry to do those, my patch is shown below: Hi Jianghui, I cann't apply your patch: $ g

Re: [PATCH] PATCH Documentation translations:translate sound/hd-audio/controls to chinese

2021-03-02 Thread Alex Shi
在 2021/3/2 上午11:22, huangjianghui 写道: >> > In the next patch ,I deleted the index of the untranstated files,and i > used checkpatch.pl to detect doc errors and tried to built the htmldocs > on my pc. > > Thanks, > > Huang Jianghui Hi Jianghui, we usually include patch into email instead of

Re: [PATCH] PATCH Documentation translations:translate sound/hd-audio/controls to chinese

2021-03-01 Thread Alex Shi
n is outdated > +or if there is a problem with the translation. with the disclaimer file, this info could be removed. > + > +Chinese maintainer: Huang Jianghui We call us translator,译者。 Others looks fine for me. Reviewed-by: Alex Shi Thanks Alex

Re: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions

2021-02-24 Thread Alex Shi
在 2021/2/24 下午4:37, Yu Zhao 写道: >>> @@ -65,18 +63,12 @@ static __always_inline void >>> __clear_page_lru_flags(struct page *page) >>> */ >>> static __always_inline enum lru_list page_lru(struct page *page) >>> { >>> - enum lru_list lru; >>> + unsigned long flags =

Re: [PATCH v2 03/10] mm: don't pass "enum lru_list" to lru list addition functions

2021-02-24 Thread Alex Shi
在 2021/2/24 下午1:29, Yu Zhao 写道: > On Tue, Feb 23, 2021 at 02:50:11PM -0800, Andrew Morton wrote: >> On Tue, 26 Jan 2021 15:14:38 -0700 Yu Zhao wrote: >> >>> On Tue, Jan 26, 2021 at 10:01:11PM +, Matthew Wilcox wrote: On Fri, Jan 22, 2021 at 03:05:53PM -0700, Yu Zhao wrote: > +++

Re: [PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line

2021-02-21 Thread Alex Shi
Reviewed-by: Alex Shi 在 2021/2/21 下午11:25, Masahiro Yamada 写道: > You should use KCFLAGS to pass additional compiler flags from the > command line. Using EXTRA_CFLAGS is wrong. > > EXTRA_CFLAGS is supposed to specify flags applied only to the current > Makefile (and now depr

Re: [PATCH 1/1] [PATCH] Documentation/translations: Translate sound/hd-audio/controls.rst into Chinese

2021-02-19 Thread Alex Shi
在 2021/2/19 下午10:48, hjh 写道: > +Documentation/sound/hd-audio/controls.rst 的中文翻译 > + > +如果想评论或更新本文的内容,请直接联系原文档的维护者。如果你使用英文 > +交流有困难的话,也可以向中文版维护者求助。如果本翻译更新不及时或者翻 > +译存在问题,请联系中文版维护者。 > + > +中文版维护者: 黄江慧 Huang Jianghui > +中文版翻译者: 黄江慧 Huang Jianghui > + > + better to reuse disclaimer-zh_CN.rst

[tip: locking/core] locking/rtmutex: Add missing kernel-doc markup

2021-01-28 Thread tip-bot2 for Alex Shi
The following commit has been merged into the locking/core branch of tip: Commit-ID: bf594bf400016a1ac58c753bcc0393a39c36f669 Gitweb: https://git.kernel.org/tip/bf594bf400016a1ac58c753bcc0393a39c36f669 Author:Alex Shi AuthorDate:Fri, 13 Nov 2020 16:58:11 +08:00 Committer

[tip: locking/core] locking/rtmutex: Add missing kernel-doc markup

2021-01-27 Thread tip-bot2 for Alex Shi
The following commit has been merged into the locking/core branch of tip: Commit-ID: 59ea5f1508e15cecddd8e2ca828f7962ea37adab Gitweb: https://git.kernel.org/tip/59ea5f1508e15cecddd8e2ca828f7962ea37adab Author:Alex Shi AuthorDate:Fri, 13 Nov 2020 16:58:11 +08:00 Committer

Re: [PATCH] mm/filemap: Adding missing mem_cgroup_uncharge() to __add_to_page_cache_locked()

2021-01-24 Thread Alex Shi
Reviewed-by: Alex Shi 在 2021/1/25 下午12:24, Waiman Long 写道: > The commit 3fea5a499d57 ("mm: memcontrol: convert page > cache to a new mem_cgroup_charge() API") introduced a bug in > __add_to_page_cache_locked() causing the following splat: > > [ 1570.068330] page dumpe

Re: [RESEND v13 00/10] KVM: x86/pmu: Guest Last Branch Recording Enabling

2021-01-15 Thread Alex Shi
在 2021/1/8 上午9:36, Like Xu 写道: > Because saving/restoring tens of LBR MSRs (e.g. 32 LBR stack entries) in > VMX transition brings too excessive overhead to frequent vmx transition > itself, the guest LBR event would help save/restore the LBR stack msrs > during the context switching with the

Re: [PATCH for doc-next] doc/zh_CN: adjust table markup in mips/ingenic-tcu.rst

2021-01-12 Thread Alex Shi
Reviewed-by: Alex Shi 在 2021/1/13 下午3:00, Lukas Bulwahn 写道: > Commit 419b1d4ed1cb ("doc/zh_CN: add mips ingenic-tcu.rst translation") > introduces a warning with make htmldocs: > > ./Documentation/translations/zh_CN/mips/ingenic-tcu.rst: > 61: WARNING: Malfor

Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

2021-01-06 Thread Alex Shi
在 2021/1/6 下午12:28, Hugh Dickins 写道: > On Sat, 12 Dec 2020, Alex Shi wrote: >> >> I'm very sorry, a typo here. the patch should be updated: >> >> From ed4fa1c6d5bed5766c5f0c35af0c597855d7be06 Mon Sep 17 00:00:00 2001 >> From: Alex Shi >> Date: Fri, 11 Dec

Re: [PATCH] docs/zh_CN: add Chinese booting and index file

2021-01-05 Thread Alex Shi
在 2021/1/5 下午5:19, siyant...@loongson.cn 写道: > From: Yanteng Si > > This is the Chinese version of booting and index file > > Signed-off-by: Yanteng Si > --- > .../translations/zh_CN/mips/booting.rst | 47 +++ > .../translations/zh_CN/mips/index.rst | 45

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-04 Thread Alex Shi
Reviewed-by: Alex Shi 在 2021/1/4 下午1:03, Hugh Dickins 写道: > Boot a CONFIG_MEMCG=y kernel with "cgroup_disabled=memory" and you are > met by a series of warnings from the VM_WARN_ON_ONCE_PAGE(!memcg, page) > recently added to the inline mem_cgroup_page_lruvec(). > > An

[RFC PATCH 1/4] mm/swap.c: pre-sort pages in pagevec for pagevec_lru_move_fn

2020-12-25 Thread Alex Shi
-by: Alex Shi Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Yu Zhao Cc: Michal Hocko Cc: Matthew Wilcox (Oracle) Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/swap.c | 92 +++ 1 file changed, 79 insertions

[RFC PATCH 3/4] mm/swap.c: extend the usage to pagevec_lru_add

2020-12-25 Thread Alex Shi
be united. Signed-off-by: Alex Shi Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Yu Zhao Cc: Michal Hocko Cc: Matthew Wilcox (Oracle) Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/swap.c | 31 --- 1 file changed, 12 insertions

[RFC PATCH 2/4] mm/swap.c: bail out early for no memcg and no numa

2020-12-25 Thread Alex Shi
If a system has memcg disabled and no numa node, like a embedded system, there is no needs to do the pagevec sort, since only just one lruvec in system. In this situation, we could skip the pagevec sorting. Signed-off-by: Alex Shi Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Yu Zhao Cc

[RFC PATCH 0/4] pre sort pages on lruvec in pagevec

2020-12-25 Thread Alex Shi
box. So I don't know if it's workable in some scenario, just sent out if someone has interesting... Alex Shi (4): mm/swap.c: pre-sort pages in pagevec for pagevec_lru_move_fn mm/swap.c: bail out early for no memcg and no numa mm/swap.c: extend the usage to pagevec_lru_add mm/swap.c: no sort

Re: [PATCH v2] docs/zh_CN: Improve Cinese transolation quality.

2020-12-23 Thread Alex Shi
在 2020/12/21 下午8:34, Ran Wang 写道: > Hi Alex, > > > On Monday, December 21, 2020 3:52 PM, Alex Shi wrote: > >> 在 2020/12/19 上午11:42, Ran Wang 写道: >>> Hi Jonathan, >>> >>> On Tuesday, December 8, 2020 11:00 PM Jonathan Corbet wrote: >&g

Re: linux kernel新手想参与文档翻译

2020-12-23 Thread Alex Shi
CC linux-doc ?? 2020/12/23 11:03, ?? : > ?? > ?0?2 ?0?2 ?0?2 > Linuxkernel??Documentation/translations/zh_CN

Re: [PATCH v2 2/3] mm/memcg: remove rcu locking for lock_page_lruvec function series

2020-12-22 Thread Alex Shi
Cc: Hui Su and Alexander Duyck as Hugh suggested. 在 2020/12/22 下午1:20, Alex Shi 写道: > lock_page_lruvec() and its variants used rcu_read_lock() with the > intention of safeguarding against the mem_cgroup being destroyed > concurrently; but so long as they are called under the

Re: [PATCH 1/3] mm/memcg: revise the using condition of lock_page_lruvec function series

2020-12-21 Thread Alex Shi
在 2020/12/22 上午11:01, Hugh Dickins 写道: > On Thu, 17 Dec 2020, Alex Shi wrote: > >> The series function could be used under lock_page_memcg(), add this and >> a bit style changes following commit_charge(). >> >> Signed-off-by: Alex Shi >> Cc: Hugh Dickin

[PATCH v2 1/3] mm/memcg: revise the using condition of lock_page_lruvec function series

2020-12-21 Thread Alex Shi
lock_page_lruvec() and its variants are safe to use under the same conditions as commit_charge(): add lock_page_memcg() to the comment. Polished with Hugh Dickins' suggestions, thanks! Signed-off-by: Alex Shi Acked-by: Hugh Dickins Cc: Hugh Dickins Cc: Johannes Weiner Cc: Michal Hocko Cc

[PATCH v2 3/3] mm/compaction: remove rcu_read_lock during page compaction

2020-12-21 Thread Alex Shi
, Thanks! Signed-off-by: Alex Shi Acked-by: Hugh Dickins Cc: Hugh Dickins Cc: Johannes Weiner Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/compaction.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c

[PATCH v2 2/3] mm/memcg: remove rcu locking for lock_page_lruvec function series

2020-12-21 Thread Alex Shi
the unnecessary rcu_read_lock() and _unlock(). Hugh Dickin's polished the commit log, Thanks a lot! Signed-off-by: Alex Shi Acked-by: Hugh Dickins Cc: Hugh Dickins Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgro...@vger.kernel.org Cc: linux...@kvack.org Cc: linux

Re: [PATCH v2] docs/zh_CN: Improve Cinese transolation quality.

2020-12-20 Thread Alex Shi
在 2020/12/19 上午11:42, Ran Wang 写道: > Hi Jonathan, > > On Tuesday, December 8, 2020 11:00 PM Jonathan Corbet wrote: >   >> On Tue,  8 Dec 2020 21:16:04 +0800 >> Ran Wang wrote: >> >>> Signed-off-by: Ran Wang >>> --- >>> Change in v2: >>>    - For 'cn_development_coding' part, change back

[PATCH 2/3] mm/memcg: remove rcu locking for lock_page_lruvec function series

2020-12-16 Thread Alex Shi
The rcu_read_lock was used to block memcg destory, but with the detailed calling conditions, the memcg won't gone since the page is hold. So we don't need it now, let's remove them to save locking load in debugging. Signed-off-by: Alex Shi Cc: Hugh Dickins Cc: Johannes Weiner Cc: Michal Hocko

[PATCH 3/3] mm/compaction: remove rcu_read_lock during page compaction

2020-12-16 Thread Alex Shi
rcu_read_lock was used to guard memcg destory, now TestClearPageLRU could block this happen, so we don't need it. Remove it to reduce locking load in debugging mode. Signed-off-by: Alex Shi Cc: Hugh Dickins Cc: Johannes Weiner Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel

[PATCH 1/3] mm/memcg: revise the using condition of lock_page_lruvec function series

2020-12-16 Thread Alex Shi
The series function could be used under lock_page_memcg(), add this and a bit style changes following commit_charge(). Signed-off-by: Alex Shi Cc: Hugh Dickins Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgro...@vger.kernel.org Cc: linux...@kvack.org Cc

Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

2020-12-11 Thread Alex Shi
I'm very sorry, a typo here. the patch should be updated: >From ed4fa1c6d5bed5766c5f0c35af0c597855d7be06 Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Fri, 11 Dec 2020 21:26:46 +0800 Subject: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON() coccinelle reports some warnings: WARNING:

[PATCH] mm/zsmalloc: replace if (cond) BUG() with BUG_ON()

2020-12-11 Thread Alex Shi
coccinelle reports some warning: WARNING: Use BUG_ON instead of if condition followed by BUG. It could be fixed by BUG_ON(). Reported-by: ab...@linux.alibaba.com Signed-off-by: Alex Shi Cc: Minchan Kim Cc: Nitin Gupta Cc: Sergey Senozhatsky Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux

[PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

2020-12-11 Thread Alex Shi
coccinelle reports some warnings: WARNING: Use BUG_ON instead of if condition followed by BUG. It could be fixed by BUG_ON(). Reported-by: ab...@linux.alibaba.com Signed-off-by: Alex Shi Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/mmap.c | 22

Re: [PATCH 00/11] mm: lru related cleanups

2020-12-10 Thread Alex Shi
Hi Yu, btw, after this patchset, to do cacheline alignment on each of lru lists are possible, so did you try that to see performance changes? Thanks Alex 在 2020/12/8 上午6:09, Yu Zhao 写道: > The cleanups are intended to reduce the verbosity in lru list > operations and make them less error-prone.

Re: [PATCH v2] docs/zh_CN: Improve Cinese transolation quality.

2020-12-08 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/12/8 下午9:16, Ran Wang 写道: > Signed-off-by: Ran Wang > --- > Change in v2: > - For 'cn_development_coding' part, change back to '是关于编码过程的' > > .../translations/zh_CN/process/1.Intro.rst| 61 ++- > 1 file changed,

Re: [PATCH 11/11] mm: enlarge the "int nr_pages" parameter of update_lru_size()

2020-12-08 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/12/8 上午6:09, Yu Zhao 写道: > update_lru_sizes() defines an unsigned long argument and passes it as > nr_pages to update_lru_size(). Though this isn't causing any overflows > I'm aware of, it's a bad idea to go through the demotion given that we > have recen

Re: [PATCH 10/11] mm: make lruvec_lru_size() static

2020-12-08 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/12/8 上午6:09, Yu Zhao 写道: > All other references to the function were removed after > commit b910718a948a ("mm: vmscan: detect file thrashing at the reclaim root") > > Signed-off-by: Yu Zhao > --- > include/linux/mmzone.h | 2 -- &

Re: [PATCH 09/11] mm: fold __update_lru_size() into its sole caller

2020-12-08 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/12/8 上午6:09, Yu Zhao 写道: > All other references to the function were removed after > commit a892cb6b977f ("mm/vmscan.c: use update_lru_size() in > update_lru_sizes()") > > Signed-off-by: Yu Zhao > --- > include/linux/mm_inline.h | 9

Re: [PATCH 08/11] mm: fold page_lru_base_type() into its sole caller

2020-12-08 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/12/8 上午6:09, Yu Zhao 写道: > We've removed all other references to this function. > > Signed-off-by: Yu Zhao > --- > include/linux/mm_inline.h | 27 ++- > 1 file changed, 6 insertions(+), 21 deletions(-) > > di

Re: [PATCH 04/11] mm: don't pass "enum lru_list" to trace_mm_lru_insertion()

2020-12-08 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/12/8 上午6:09, Yu Zhao 写道: > The parameter is redundant in the sense that it can be extracted > from the "struct page" parameter by page_lru() correctly. > > Signed-off-by: Yu Zhao > --- > include/trace/events/pagemap.h |

Re: [PATCH 03/11] mm: don't pass "enum lru_list" to lru list addition functions

2020-12-08 Thread Alex Shi
在 2020/12/8 上午6:09, Yu Zhao 写道: > The "enum lru_list" parameter to add_page_to_lru_list() and > add_page_to_lru_list_tail() is redundant in the sense that it can > be extracted from the "struct page" parameter by page_lru(). > > A caveat is that we need to make sure PageActive() or >

Re: [PATCH 03/11] mm: don't pass "enum lru_list" to lru list addition functions

2020-12-08 Thread Alex Shi
在 2020/12/8 上午6:09, Yu Zhao 写道: > > __count_vm_events(PGACTIVATE, nr_pages); > @@ -543,14 +542,14 @@ static void lru_deactivate_file_fn(struct page *page, > struct lruvec *lruvec) >* It can make readahead confusing. But race window >* is

Re: [PATCH 01/11] mm: use add_page_to_lru_list()

2020-12-07 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/12/8 上午6:09, Yu Zhao 写道: > There is add_page_to_lru_list(), and move_pages_to_lru() should reuse > it, not duplicate it. > > Signed-off-by: Yu Zhao > --- > mm/vmscan.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > di

Re: [PATCH] docs/zh_CN: Improve Cinese transolation quality.

2020-12-07 Thread Alex Shi
在 2020/12/7 下午9:05, Ran Wang 写道: >>> +:ref:`cn_development_followthrough` 介绍了提交补丁之后发生的事情;至此工作实际 >> is it bybond 80 chars? > On my part this line is aligned with context (on vim), and pass checkpatch.pl > check, En, right, maybe a line alignment? but it depends on different editors. it's

Re: [PATCH] docs/zh_CN: Improve Cinese transolation quality.

2020-12-06 Thread Alex Shi
在 2020/12/5 下午6:36, Ran Wang 写道: > Signed-off-by: Ran Wang > --- > .../translations/zh_CN/process/1.Intro.rst| 61 ++- > 1 file changed, 32 insertions(+), 29 deletions(-) > > diff --git a/Documentation/translations/zh_CN/process/1.Intro.rst >

Re: [PATCH 1/3] mm/swap.c: pre-sort pages in pagevec for pagevec_lru_move_fn

2020-12-01 Thread Alex Shi
在 2020/12/1 下午4:10, Michal Hocko 写道: > On Tue 01-12-20 16:02:13, Alex Shi wrote: >> Pages in pagevec may have different lruvec, so we have to do relock in >> function pagevec_lru_move_fn(), but a relock may cause current cpu wait >> for long time on the same lock for spi

[PATCH 3/3] mm/swap.c: extend the usage to pagevec_lru_add

2020-12-01 Thread Alex Shi
be united. Signed-off-by: Alex Shi Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Yu Zhao Cc: Michal Hocko Cc: Matthew Wilcox (Oracle) Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/swap.c | 30 +++--- 1 file changed, 11 insertions(+), 19

[PATCH 2/3] mm/swap.c: bail out early for no memcg and no numa

2020-12-01 Thread Alex Shi
If a system has memcg disabled and no numa node, like a embedded system, there is no needs to do the pagevec sort, since only just one lruvec in system. In this situation, we could skip the pagevec sorting. Signed-off-by: Alex Shi Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Yu Zhao Cc

[PATCH 1/3] mm/swap.c: pre-sort pages in pagevec for pagevec_lru_move_fn

2020-12-01 Thread Alex Shi
-by: Alex Shi Cc: Konstantin Khlebnikov Cc: Hugh Dickins Cc: Yu Zhao Cc: Michal Hocko Cc: Matthew Wilcox (Oracle) Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/swap.c | 92 +++ 1 file changed, 79 insertions

Re: [PATCH] certs/blacklist: fix kernel doc interface issue

2020-11-30 Thread Alex Shi
在 2020/11/30 下午6:04, David Howells 写道: > Alex Shi wrote: > >> /** >> * mark_hash_blacklisted - Add a hash to the system blacklist >> - * @hash - The hash as a hex string with a type prefix (eg. >> "tbs:23aa429783") >> + * @hash: - The hash as

Re: [PATCH] mm/memcg: bail out early when !memcg in mem_cgroup_lruvec

2020-11-28 Thread Alex Shi
在 2020/11/28 下午12:02, Andrew Morton 写道: > On Fri, 27 Nov 2020 11:08:35 +0800 Alex Shi > wrote: > >> Sometime, we use NULL memcg in mem_cgroup_lruvec(memcg, pgdat) >> so we could get out early in the situation to avoid useless checking. >> >> Also warning if

[tip: x86/cleanups] x86/PCI: Make a kernel-doc comment a normal one

2020-11-27 Thread tip-bot2 for Alex Shi
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 638920a66a17c8e1f4415cbab0d49dc4a344c2a7 Gitweb: https://git.kernel.org/tip/638920a66a17c8e1f4415cbab0d49dc4a344c2a7 Author:Alex Shi AuthorDate:Fri, 13 Nov 2020 16:58:14 +08:00 Committer

Re: [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add

2020-11-26 Thread Alex Shi
在 2020/11/26 下午11:55, Matthew Wilcox 写道: > On Thu, Nov 26, 2020 at 04:44:04PM +0100, Vlastimil Babka wrote: >> However, Matthew wanted to increase pagevec size [1] and once 15^2 becomes >> 63^2, it starts to be somewhat more worrying. >> >> [1] >>

[PATCH] mm/memcg: bail out early when !memcg in mem_cgroup_lruvec

2020-11-26 Thread Alex Shi
Sometime, we use NULL memcg in mem_cgroup_lruvec(memcg, pgdat) so we could get out early in the situation to avoid useless checking. Also warning if both parameter are NULL. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Johannes Weiner Cc: Shakeel Butt Cc: Roman Gushchin Cc: Lorenzo Stoakes

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-26 Thread Alex Shi
在 2020/11/26 下午11:23, Vlastimil Babka 写道: >>> >>> I tried that, and .text became significantly larger, for reasons which >>> I didn't investigate ;) > > I found out that comparing whole .text doesn't often work as changes might be > lost in alignment, or > once in a while cross the alignment

Re: [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add

2020-11-26 Thread Alex Shi
在 2020/11/26 下午3:24, Yu Zhao 写道: > Oh, no, I'm not against your idea. I was saying it doesn't seem > necessary to sort -- a nested loop would just do the job given > pagevec is small. > > diff --git a/mm/swap.c b/mm/swap.c > index cb3794e13b48..1d238edc2907 100644 > --- a/mm/swap.c > +++

Re: [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add

2020-11-25 Thread Alex Shi
在 2020/11/26 下午12:52, Yu Zhao 写道: >> */ >> void __pagevec_lru_add(struct pagevec *pvec) >> { >> -int i; >> -struct lruvec *lruvec = NULL; >> +int i, nr_lruvec; >> unsigned long flags = 0; >> +struct page *page; >> +struct lruvecs lruvecs; >> >> -for (i = 0; i

Re: [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add

2020-11-25 Thread Alex Shi
在 2020/11/25 下午11:38, Vlastimil Babka 写道: > On 11/20/20 9:27 AM, Alex Shi wrote: >> The current relock logical will change lru_lock when found a new >> lruvec, so if 2 memcgs are reading file or alloc page at same time, >> they could hold the lru_lock alternately, an

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-25 Thread Alex Shi
在 2020/11/26 上午7:43, Andrew Morton 写道: > On Tue, 24 Nov 2020 12:21:28 +0100 Vlastimil Babka wrote: > >> On 11/22/20 3:00 PM, Alex Shi wrote: >>> Thanks a lot for all comments, I picked all up and here is the v3: >>> >>> From 167131dd106a96fd08af725df8

Re: [PATCH] mm/memcg: warn on missing memcg on mem_cgroup_page_lruvec()

2020-11-25 Thread Alex Shi
Acked-by: Alex Shi 在 2020/11/25 下午7:22, Lorenzo Stoakes 写道: > Move memcg check to mem_cgroup_page_lruvec() as there are callers which > may invoke this with !memcg in mem_cgroup_lruvec(), whereas they should > not in mem_cgroup_page_lruvec(). > > We expect that we have always

Re: linux-next boot error: WARNING in prepare_kswapd_sleep

2020-11-24 Thread Alex Shi
VM_WARN_ON_ONCE_PAGE(!page_memcg(page), page); > return mem_cgroup_lruvec(page_memcg(page), pgdat); > } > Acked. Right. Would you like to remove the bad commit 4b2904f3 ("mm/memcg: add missed warning in mem_cgroup_lruvec") and replace yours. and further more, could you

Re: INFO: task can't die in shrink_inactive_list (2)

2020-11-24 Thread Alex Shi
在 2020/11/24 下午8:00, Alex Shi 写道: >>> syzbot found the following issue on: >>> >>> HEAD commit:03430750 Add linux-next specific files for 20201116 >>> git tree: linux-next >>> console output: https://syzkaller.appspot.com/x/log.t

Re: INFO: task can't die in shrink_inactive_list (2)

2020-11-24 Thread Alex Shi
在 2020/11/24 下午8:00, Alex Shi 写道: >>> >>> syzbot found the following issue on: >>> >>> HEAD commit:03430750 Add linux-next specific files for 20201116 >>> git tree: linux-next >>> console output: https://syzkaller.appspot.co

Re: INFO: task can't die in shrink_inactive_list (2)

2020-11-24 Thread Alex Shi
在 2020/11/24 上午11:54, Andrew Morton 写道: > On Fri, 20 Nov 2020 17:55:22 -0800 syzbot > wrote: > >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit:03430750 Add linux-next specific files for 20201116 >> git tree: linux-next >> console output:

Re: INFO: task can't die in shrink_inactive_list (2)

2020-11-23 Thread Alex Shi
CC: Hugh Dickin & Johannes, 在 2020/11/24 上午11:54, Andrew Morton 写道: > On Fri, 20 Nov 2020 17:55:22 -0800 syzbot > wrote: > >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit:03430750 Add linux-next specific files for 20201116 >> git tree: linux-next >> console

[REF PATCH] block/loop: remove unused range

2020-11-23 Thread Alex Shi
The variable isn't used, so don't brother to set it. Signed-off-by: Alex Shi Cc: Jens Axboe Cc: linux-bl...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/block/loop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index

[PATCH] fs/btrfs: remove parent_level in btrfs_sb_log_location_bdev

2020-11-23 Thread Alex Shi
The variable parent_level isn't used, so don't bother to get it. Signed-off-by: Alex Shi Cc: Chris Mason Cc: Josef Bacik Cc: David Sterba Cc: linux-bt...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/btrfs/ctree.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs

[PATCH] sched/core: remove rq getting in schedule_tail

2020-11-23 Thread Alex Shi
commit dfa50b605c2a ("sched: Make finish_task_switch() return 'struct rq *'") moved the 'rq' parameter into finish_task_switch, so we don't need it now in schedule_tail. Signed-off-by: Alex Shi Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietma

Re: [PATCH] Documentation: Chinese translation of Documentation/arm64/elf_hwcaps.rst

2020-11-23 Thread Alex Shi
Thanks Bailu! Reviewed-by: Alex Shi 在 2020/11/24 上午10:38, Bailu Lin 写道: > This is a Chinese translated version of > Documentation/arm64/elf_hwcaps.rst > > Signed-off-by: Bailu Lin > --- > Changes in v2: > - Modify five translation issues as Alex sugguested. > --

Re: [PATCH] Documentation: Chinese translation of Documentation/arm64/elf_hwcaps.rst

2020-11-22 Thread Alex Shi
在 2020/11/21 下午6:23, Bailu Lin 写道: > This is a Chinese translated version of > Documentation/arm64/elf_hwcaps.rst > > Signed-off-by: Bailu Lin > --- > Documentation/arm64/elf_hwcaps.rst| 2 + > .../translations/zh_CN/arm64/elf_hwcaps.rst | 240 ++ >

Re: [PATCH next] mm/swap.c: reduce lock contention in lru_cache_add

2020-11-22 Thread Alex Shi
在 2020/11/21 上午7:19, Andrew Morton 写道: > On Fri, 20 Nov 2020 16:27:27 +0800 Alex Shi > wrote: > >> The current relock logical will change lru_lock when found a new >> lruvec, so if 2 memcgs are reading file or alloc page at same time, >> they could hold the lru

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-22 Thread Alex Shi
在 2020/11/22 下午8:35, Matthew Wilcox 写道: > On Sun, Nov 22, 2020 at 08:00:19PM +0800, Alex Shi wrote: >> mm/compaction.c | 2 +- >> mm/vmscan.c | 69 +++-- >> 2 files changed, 34 insertions(+), 37 deletions(-) > >

Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-22 Thread Alex Shi
在 2020/11/21 上午7:13, Andrew Morton 写道: > On Fri, 20 Nov 2020 16:03:33 +0800 Alex Shi > wrote: > >> The function just return 2 results, so use a 'switch' to deal with its >> result is unnecessary, and simplify it to a bool func as Vlastimil >> suggested. >>

Re: [PATCH next-akpm] mm/memcg: add missed warning in mem_cgroup_lruvec

2020-11-20 Thread Alex Shi
在 2020/11/20 下午5:30, Alex Shi 写道: > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 925b09ace986..7809020ef7bd 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -618,6 +618,7 @@ static inline struct lruvec *mem_cgrou

[PATCH next-akpm] mm/memcg: remove incorrect comments

2020-11-20 Thread Alex Shi
Swapcache readahead pages are charged before get used, so it unlikely be migrated before charged. remove the incorrect comments. Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Andrew Morton Cc: cgro...@vger.kernel.org Cc: linux...@kvack.org Cc

[PATCH next-akpm] mm/memcg: add missed warning in mem_cgroup_lruvec

2020-11-20 Thread Alex Shi
_ONCE_PAGE(!memcg, page); Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Johannes Weiner Cc: Shakeel Butt Cc: Roman Gushchin Cc: Michal Hocko Cc: Yafang Shao Cc: Alexander Duyck Cc: Hui Su Cc: Wei Yang Cc: linux-kernel@vger.kernel.org --- include/linux/memcontrol.h | 1 + 1 file

[PATCH next] mm/swap.c: reduce lock contention in lru_cache_add

2020-11-20 Thread Alex Shi
them once in above scenario. That could reduce fairness waiting for lock reget. Than, vm-scalability/case-lru-file-readtwice could get ~5% performance gain on my 2P*20core*HT machine. Suggested-by: Konstantin Khlebnikov Signed-off-by: Alex Shi Cc: Konstantin Khlebnikov Cc: Andrew Morton Cc

[PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up

2020-11-20 Thread Alex Shi
The function just return 2 results, so use a 'switch' to deal with its result is unnecessary, and simplify it to a bool func as Vlastimil suggested. Also removed 'goto' in using by reusing list_move(). Signed-off-by: Alex Shi Cc: Andrew Morton Cc: Hugh Dickins Cc: Yu Zhao Cc: Vlastimil Babka

Re: [PATCH] docs/vm: remove unused 3 items explanation for /proc/vmstat

2020-11-18 Thread Alex Shi
在 2020/11/19 上午4:46, Jonathan Corbet 写道: > On Mon, 16 Nov 2020 17:51:22 +0800 > Alex Shi wrote: > >> Commit 5647bc293ab1 ("mm: compaction: Move migration fail/success >> stats to migrate.c"), removed 3 items in /proc/vmstat. but the docs >> still has

Re: [PATCH] khugepaged: add couples parameter explanation for kernel-doc markup

2020-11-17 Thread Alex Shi
在 2020/11/17 下午3:15, Alex Shi 写道: > /** > * collapse_file - collapse filemap/tmpfs/shmem pages into huge one. > * > + * @mm: process address space where collapse happens > + * @file: file that collapse on > + * @start: collapse start address Hi Andrew, A trailing w

[PATCH] mm/truncate: add parameter explanation for invalidate_mapping_pagevec

2020-11-17 Thread Alex Shi
parameter or member 'end' not described in 'invalidate_mapping_pagevec' mm/truncate.c:646: warning: Function parameter or member 'nr_pagevec' not described in 'invalidate_mapping_pagevec' Signed-off-by: Alex Shi Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm

[PATCH] mm/mapping_dirty_helpers: enhance the kernel-doc markups

2020-11-17 Thread Alex Shi
in 'clean_record_pte' Signed-off-by: Alex Shi Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/mapping_dirty_helpers.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/mapping_dirty_helpers.c b/mm/mapping_dirty_helpers.c index 2c7d03675903..b59054ef2e10

[PATCH] mm/vmalloc: add 'align' parameter explanation for pvm_determine_end_from_reverse

2020-11-17 Thread Alex Shi
Kernel-doc markup has a issue on pvm_determine_end_from_reverse: mm/vmalloc.c:3145: warning: Function parameter or member 'align' not described in 'pvm_determine_end_from_reverse' Add a explanation for it to remove the warning. Signed-off-by: Alex Shi Cc: Andrew Morton Cc: linux...@kvack.org Cc

[PATCH] khugepaged: add couples parameter explanation for kernel-doc markup

2020-11-16 Thread Alex Shi
/khugepaged.c:1626: warning: Function parameter or member 'node' not described in 'collapse_file' Signed-off-by: Alex Shi Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org --- mm/khugepaged.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/mm

[PATCH] mm: add colon to fix kernel-doc markups error for check_pte

2020-11-16 Thread Alex Shi
The function check_pte needs a correct colon for kernel-doc markup, otherwise, gcc has the following warning for W=1, mm/page_vma_mapped.c:86: warning: Function parameter or member 'pvmw' not described in 'check_pte' Signed-off-by: Alex Shi Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux

[PATCH] docs/vm: remove unused 3 items explanation for /proc/vmstat

2020-11-16 Thread Alex Shi
Commit 5647bc293ab1 ("mm: compaction: Move migration fail/success stats to migrate.c"), removed 3 items in /proc/vmstat. but the docs still has their explanation. let's remove them. "compact_blocks_moved", "compact_pages_moved", "compact_pagemigrate_failed"

Re: [PATCH doc] doc: zh_CN: add tmpfs to index tree

2020-11-16 Thread Alex Shi
Reviewed-by: Alex Shi 在 2020/11/16 下午2:47, Wang Qing 写道: > Add temfs to the index tree while adding tempfs translation. > > Signed-off-by: Wang Qing > --- > Documentation/translations/zh_CN/filesystems/index.rst | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [PATCH v21 00/19] per memcg lru lock

2020-11-15 Thread Alex Shi
Hi Andrew, With all patches are acked-by Hugh and Johannes, and full testing from LKP, is this patchset ready for more testing on linux-next? or anything still need be improved? Thanks Alex 在 2020/11/5 下午4:55, Alex Shi 写道: > This version rebase on next/master 20201104, with much of Johanne

Re: [PATCH 1/6] time: fix kernel-doc markup

2020-11-15 Thread Alex Shi
在 2020/11/16 上午6:48, Thomas Gleixner 写道: > On Fri, Nov 13 2020 at 15:24, Alex Shi wrote: > >> The kernel-doc interface error cause some warning: > > I fixes the lot up and applied it. Please look at the changes I did and > be more careful next time. > Hi Thomas,

[tip: timers/core] timekeeping: Add missing parameter docs for pvclock_gtod_[un]register_notifier()

2020-11-15 Thread tip-bot2 for Alex Shi
The following commit has been merged into the timers/core branch of tip: Commit-ID: f27f7c3f100e74a7f451a63a15788f50c52f7cce Gitweb: https://git.kernel.org/tip/f27f7c3f100e74a7f451a63a15788f50c52f7cce Author:Alex Shi AuthorDate:Fri, 13 Nov 2020 15:24:32 +08:00 Committer

[tip: timers/core] timekeeping: Add missing parameter documentation for update_fast_timekeeper()

2020-11-15 Thread tip-bot2 for Alex Shi
The following commit has been merged into the timers/core branch of tip: Commit-ID: e025b03113d27139ce2b28b82599018e4d8fa5f6 Gitweb: https://git.kernel.org/tip/e025b03113d27139ce2b28b82599018e4d8fa5f6 Author:Alex Shi AuthorDate:Fri, 13 Nov 2020 15:24:31 +08:00 Committer

[tip: timers/core] time: Add missing colons for parameter documentation of time64_to_tm()

2020-11-15 Thread tip-bot2 for Alex Shi
The following commit has been merged into the timers/core branch of tip: Commit-ID: a0f5a65fa5faeef708d022698d5fcba290a35856 Gitweb: https://git.kernel.org/tip/a0f5a65fa5faeef708d022698d5fcba290a35856 Author:Alex Shi AuthorDate:Fri, 13 Nov 2020 15:24:30 +08:00 Committer

[tip: timers/core] timekeeping: Remove static functions from kernel-doc markup

2020-11-15 Thread tip-bot2 for Alex Shi
The following commit has been merged into the timers/core branch of tip: Commit-ID: 199d280c884de44c3b0daeb77438db43f6db01a2 Gitweb: https://git.kernel.org/tip/199d280c884de44c3b0daeb77438db43f6db01a2 Author:Alex Shi AuthorDate:Fri, 13 Nov 2020 15:24:33 +08:00 Committer

  1   2   3   4   5   6   7   8   9   10   >