Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 28 October 2015 at 19:28, Leonid Yegoshin wrote: > On 10/28/2015 12:04 PM, Alex Smith wrote: >> >> On 28 October 2015 at 18:57, Leonid Yegoshin >> wrote: >>> >>> >> As I've explained the VDSO will only use the CP0 counter in the same >> sit

Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 28 October 2015 at 18:57, Leonid Yegoshin wrote: > On 10/28/2015 11:30 AM, Alex Smith wrote: >> >> On 28 October 2015 at 18:21, Leonid Yegoshin >> wrote: >>> >>> >>> >>> 1) I don't see that in code - there is no check that

Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 28 October 2015 at 18:21, Leonid Yegoshin wrote: > > On 10/28/2015 03:20 AM, Alex Smith wrote: >> >> On 27 October 2015 at 20:46, Leonid Yegoshin >> wrote: >>> >>> I believe, until this issue is fixed the R4K only CPU should be excluded >>>

Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 27 October 2015 at 20:46, Leonid Yegoshin wrote: > I doesn't work in this way - a standard CP0_counter synchronization code > takes up to hundred milliseconds to complete with running some loop cycles > on two CPUs. It is clearly seen in Malta FPGA board. > > Non-standard (one way sync, write

Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 28 October 2015 at 18:21, Leonid Yegoshin <leonid.yegos...@imgtec.com> wrote: > > On 10/28/2015 03:20 AM, Alex Smith wrote: >> >> On 27 October 2015 at 20:46, Leonid Yegoshin <leonid.yegos...@imgtec.com> >> wrote: >>> >>> I believe, until t

Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 28 October 2015 at 19:28, Leonid Yegoshin <leonid.yegos...@imgtec.com> wrote: > On 10/28/2015 12:04 PM, Alex Smith wrote: >> >> On 28 October 2015 at 18:57, Leonid Yegoshin <leonid.yegos...@imgtec.com> >> wrote: >>> >>> >> As I've exp

Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 28 October 2015 at 18:57, Leonid Yegoshin <leonid.yegos...@imgtec.com> wrote: > On 10/28/2015 11:30 AM, Alex Smith wrote: >> >> On 28 October 2015 at 18:21, Leonid Yegoshin <leonid.yegos...@imgtec.com> >> wrote: >>> >>> >>> >>

Re: [v3, 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-28 Thread Alex Smith
On 27 October 2015 at 20:46, Leonid Yegoshin wrote: > I doesn't work in this way - a standard CP0_counter synchronization code > takes up to hundred milliseconds to complete with running some loop cycles > on two CPUs. It is clearly seen in Malta FPGA board. > >

Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

2015-10-16 Thread Alex Smith
Hi James, On 15 October 2015 at 09:47, James Hogan wrote: >> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts >> b/arch/mips/boot/dts/ingenic/ci20.dts >> index 9fcb9e7..453f1d3 100644 >> --- a/arch/mips/boot/dts/ingenic/ci20.dts >> +++ b/arch/mips/boot/dts/ingenic/ci20.dts >> @@ -42,3 +42,57 @@

Re: [PATCH v7,3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

2015-10-16 Thread Alex Smith
Hi James, On 15 October 2015 at 09:47, James Hogan wrote: >> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts >> b/arch/mips/boot/dts/ingenic/ci20.dts >> index 9fcb9e7..453f1d3 100644 >> --- a/arch/mips/boot/dts/ingenic/ci20.dts >> +++

Re: [PATCH 1/3] MIPS: Initial implementation of a VDSO

2015-09-28 Thread Alex Smith
mips/vdso/elf.S > @@ -0,0 +1,68 @@ > +/* > + * Copyright (C) 2015 Imagination Technologies > + * Author: Alex Smith > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the >

Re: [PATCH 1/3] MIPS: Initial implementation of a VDSO

2015-09-28 Thread Alex Smith
> --- /dev/null > +++ b/arch/mips/vdso/elf.S > @@ -0,0 +1,68 @@ > +/* > + * Copyright (C) 2015 Imagination Technologies > + * Author: Alex Smith <alex.sm...@imgtec.com> > + * > + * This program is free software; you can redistribute it and/or modify it > + * u

[PATCH v6 0/4] mtd: nand: jz4780: Add NAND and BCH drivers

2015-09-16 Thread Alex Smith
Hi, This series adds support for the BCH controller and NAND devices on the Ingenic JZ4780 SoC. Tested on the MIPS Creator Ci20 board. All dependencies are now in mainline. This version of the series is based on 4.3-rc1. Review and feedback welcome. Thanks, Alex Alex Smith (4): mtd: nand

[PATCH v6 2/4] dt-bindings: binding for jz4780-{nand,bch}

2015-09-16 Thread Alex Smith
From: Alex Smith Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller, used by the jz4780_{nand,bch} drivers. Signed-off-by: Alex Smith Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux

[PATCH v6 4/4] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

2015-09-16 Thread Alex Smith
From: Alex Smith Add device tree nodes for the NEMC and BCH to the JZ4780 device tree, and make use of them in the Ci20 device tree to add a node for the board's NAND. Note that since the pinctrl driver is not yet upstream, this includes neither pin configuration nor busy/write-protect GPIO

[PATCH v6 3/4] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-16 Thread Alex Smith
From: Alex Smith Add a driver for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller. DMA is not currently implemented. While older 47xx SoCs also have a BCH controller, they are incompatible with the one in the 4780 due to differing register/bit positions

[PATCH v6 1/4] mtd: nand: increase ready wait timeout and report timeouts

2015-09-16 Thread Alex Smith
From: Alex Smith If nand_wait_ready() times out, this is silently ignored, and its caller will then proceed to read from/write to the chip before it is ready. This can potentially result in corruption with no indication as to why. While a 20ms timeout seems like it should be plenty enough

[PATCH v6 3/4] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-16 Thread Alex Smith
From: Alex Smith <alex.sm...@imgtec.com> Add a driver for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller. DMA is not currently implemented. While older 47xx SoCs also have a BCH controller, they are incompatible with the one in the 4780 due to dif

[PATCH v6 4/4] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

2015-09-16 Thread Alex Smith
From: Alex Smith <alex.sm...@imgtec.com> Add device tree nodes for the NEMC and BCH to the JZ4780 device tree, and make use of them in the Ci20 device tree to add a node for the board's NAND. Note that since the pinctrl driver is not yet upstream, this includes neither pin configuration no

[PATCH v6 1/4] mtd: nand: increase ready wait timeout and report timeouts

2015-09-16 Thread Alex Smith
From: Alex Smith <alex.sm...@imgtec.com> If nand_wait_ready() times out, this is silently ignored, and its caller will then proceed to read from/write to the chip before it is ready. This can potentially result in corruption with no indication as to why. While a 20ms timeout seems like it

[PATCH v6 2/4] dt-bindings: binding for jz4780-{nand,bch}

2015-09-16 Thread Alex Smith
From: Alex Smith <alex.sm...@imgtec.com> Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller, used by the jz4780_{nand,bch} drivers. Signed-off-by: Alex Smith <alex.sm...@imgtec.com> Cc: Zubair Lutfullah Kakakhel &

[PATCH v6 0/4] mtd: nand: jz4780: Add NAND and BCH drivers

2015-09-16 Thread Alex Smith
Hi, This series adds support for the BCH controller and NAND devices on the Ingenic JZ4780 SoC. Tested on the MIPS Creator Ci20 board. All dependencies are now in mainline. This version of the series is based on 4.3-rc1. Review and feedback welcome. Thanks, Alex Alex Smith (4): mtd: nand

Re: [PATCH v5 1/4] mtd: nand: increase ready wait timeout and report timeouts

2015-09-15 Thread Alex Smith
On 10 September 2015 at 00:49, Brian Norris wrote: > + Niklas > > On Tue, Sep 08, 2015 at 10:10:50AM +0100, Alex Smith wrote: >> If nand_wait_ready() times out, this is silently ignored, and its >> caller will then proceed to read from/write to the chip before it is >>

Re: [PATCH v5 3/4] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-15 Thread Alex Smith
On 9 September 2015 at 15:24, Ezequiel Garcia wrote: > On 08 Sep 10:10 AM, Alex Smith wrote: >> Add a driver for NAND devices connected to the NEMC on JZ4780 SoCs, as >> well as the hardware BCH controller. DMA is not currently implemented. >> >> While older 47xx SoCs

Re: [PATCH v5 3/4] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-15 Thread Alex Smith
On 9 September 2015 at 15:24, Ezequiel Garcia <ezequ...@vanguardiasur.com.ar> wrote: > On 08 Sep 10:10 AM, Alex Smith wrote: >> Add a driver for NAND devices connected to the NEMC on JZ4780 SoCs, as >> well as the hardware BCH controller. DMA is not currently implemented. &

Re: [PATCH v5 1/4] mtd: nand: increase ready wait timeout and report timeouts

2015-09-15 Thread Alex Smith
On 10 September 2015 at 00:49, Brian Norris <computersforpe...@gmail.com> wrote: > + Niklas > > On Tue, Sep 08, 2015 at 10:10:50AM +0100, Alex Smith wrote: >> If nand_wait_ready() times out, this is silently ignored, and its >> caller will then proceed to read fr

[PATCH v5 1/4] mtd: nand: increase ready wait timeout and report timeouts

2015-09-08 Thread Alex Smith
meout does occur so that it is easier to pinpoint any problems in future caused by the chip not becoming ready. Signed-off-by: Alex Smith Reviewed-by: Ezequiel Garcia Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux-...@lists.infradead.org Cc: linux-kernel@vger.

[PATCH v5 2/4] dt-bindings: binding for jz4780-{nand,bch}

2015-09-08 Thread Alex Smith
Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller, used by the jz4780_{nand,bch} drivers. Signed-off-by: Alex Smith Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux-...@lists.infradead.org Cc: linux-kernel

[PATCH v5 3/4] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-08 Thread Alex Smith
implementing a common driver for them quite messy. Signed-off-by: Alex Smith Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux-...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- v4 -> v5: - Bump RB_DELAY up to be sufficient for the driver to work with

[PATCH v5 4/4] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

2015-09-08 Thread Alex Smith
of the NAND relies on the boot loader to have left the pins configured in a usable state, which should be the case when booted from the NAND. Signed-off-by: Alex Smith Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux-...@lists.infradead.org Cc: devicet

[PATCH v5 0/4] mtd: nand: jz4780: Add NAND and BCH drivers

2015-09-08 Thread Alex Smith
Hi, This series adds support for the BCH controller and NAND devices on the Ingenic JZ4780 SoC. Tested on the MIPS Creator Ci20 board. All dependencies are now in mainline. This version of the series is based on current mainline (pre 4.3-rc1). Review and feedback welcome. Thanks, Alex Alex

[PATCH v5 0/4] mtd: nand: jz4780: Add NAND and BCH drivers

2015-09-08 Thread Alex Smith
Hi, This series adds support for the BCH controller and NAND devices on the Ingenic JZ4780 SoC. Tested on the MIPS Creator Ci20 board. All dependencies are now in mainline. This version of the series is based on current mainline (pre 4.3-rc1). Review and feedback welcome. Thanks, Alex Alex

[PATCH v5 3/4] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-08 Thread Alex Smith
implementing a common driver for them quite messy. Signed-off-by: Alex Smith <alex.sm...@imgtec.com> Cc: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> Cc: David Woodhouse <dw...@infradead.org> Cc: Brian Norris <computersforpe...@gmail.com> Cc: linux-...@lists.infrad

[PATCH v5 4/4] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

2015-09-08 Thread Alex Smith
of the NAND relies on the boot loader to have left the pins configured in a usable state, which should be the case when booted from the NAND. Signed-off-by: Alex Smith <alex.sm...@imgtec.com> Cc: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> Cc: David Woodhouse <dw...@in

[PATCH v5 1/4] mtd: nand: increase ready wait timeout and report timeouts

2015-09-08 Thread Alex Smith
meout does occur so that it is easier to pinpoint any problems in future caused by the chip not becoming ready. Signed-off-by: Alex Smith <alex.sm...@imgtec.com> Reviewed-by: Ezequiel Garcia <ezequ...@vanguardiasur.com.ar> Cc: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com

[PATCH v5 2/4] dt-bindings: binding for jz4780-{nand,bch}

2015-09-08 Thread Alex Smith
Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller, used by the jz4780_{nand,bch} drivers. Signed-off-by: Alex Smith <alex.sm...@imgtec.com> Cc: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> Cc: David W

Re: [PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-09-07 Thread Alex Smith
On 06/09/2015 21:38, Ezequiel Garcia wrote: > On 27 Jul 02:50 PM, Alex Smith wrote: >> Hi, >> >> This series adds support for the BCH controller and NAND devices on >> the Ingenic JZ4780 SoC. >> >> Tested on the MIPS Creator Ci20 board. All dependenc

Re: [PATCH v4 3/3] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-07 Thread Alex Smith
Hi, On 06/09/2015 22:21, Ezequiel Garcia wrote: > On 27 Jul 03:21 PM, Alex Smith wrote: >> Add a driver for NAND devices connected to the NEMC on JZ4780 SoCs, as >> well as the hardware BCH controller. DMA is not currently implemented. >> >> While older 47xx SoCs

Re: [PATCH v4 1/3] mtd: nand: increase ready wait timeout and report timeouts

2015-09-07 Thread Alex Smith
Hi Ezequiel, Thanks for reviewing the series. On 06/09/2015 21:37, Ezequiel Garcia wrote: > On 27 Jul 02:50 PM, Alex Smith wrote: >> If nand_wait_ready() times out, this is silently ignored, and its >> caller will then proceed to read from/write to the chip before it is >

Re: [PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-09-07 Thread Alex Smith
On 06/09/2015 21:38, Ezequiel Garcia wrote: > On 27 Jul 02:50 PM, Alex Smith wrote: >> Hi, >> >> This series adds support for the BCH controller and NAND devices on >> the Ingenic JZ4780 SoC. >> >> Tested on the MIPS Creator Ci20 board. All dependenc

Re: [PATCH v4 3/3] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-09-07 Thread Alex Smith
Hi, On 06/09/2015 22:21, Ezequiel Garcia wrote: > On 27 Jul 03:21 PM, Alex Smith wrote: >> Add a driver for NAND devices connected to the NEMC on JZ4780 SoCs, as >> well as the hardware BCH controller. DMA is not currently implemented. >> >> While older 47xx SoCs

Re: [PATCH v4 1/3] mtd: nand: increase ready wait timeout and report timeouts

2015-09-07 Thread Alex Smith
Hi Ezequiel, Thanks for reviewing the series. On 06/09/2015 21:37, Ezequiel Garcia wrote: > On 27 Jul 02:50 PM, Alex Smith wrote: >> If nand_wait_ready() times out, this is silently ignored, and its >> caller will then proceed to read from/write to the chip before it is >

Re: [PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-08-26 Thread Alex Smith
On 18/08/2015 13:39, Alex Smith wrote: > On 27/07/2015 14:50, Alex Smith wrote: >> Hi, >> >> This series adds support for the BCH controller and NAND devices on >> the Ingenic JZ4780 SoC. >> >> Tested on the MIPS Creator Ci20 board. All dependencies are now

Re: [PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-08-26 Thread Alex Smith
On 18/08/2015 13:39, Alex Smith wrote: On 27/07/2015 14:50, Alex Smith wrote: Hi, This series adds support for the BCH controller and NAND devices on the Ingenic JZ4780 SoC. Tested on the MIPS Creator Ci20 board. All dependencies are now in mainline so it should be possible to compile test

Re: [PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-08-18 Thread Alex Smith
On 27/07/2015 14:50, Alex Smith wrote: > Hi, > > This series adds support for the BCH controller and NAND devices on > the Ingenic JZ4780 SoC. > > Tested on the MIPS Creator Ci20 board. All dependencies are now in > mainline so it should be possible to compile test n

Re: [PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-08-18 Thread Alex Smith
On 27/07/2015 14:50, Alex Smith wrote: Hi, This series adds support for the BCH controller and NAND devices on the Ingenic JZ4780 SoC. Tested on the MIPS Creator Ci20 board. All dependencies are now in mainline so it should be possible to compile test now. This version of the series

[PATCH v4 3/3] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-07-27 Thread Alex Smith
implementing a common driver for them quite messy. Signed-off-by: Alex Smith Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux-...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- v3 -> v4: - Rebase to 4.2-rc4 - Change ECC_HW_OOB_FIRST to ECC_HW, reading

[PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-07-27 Thread Alex Smith
an additional patch to fix an issue that was encountered in the external Ci20 3.18 kernel branch. Review and feedback welcome. Thanks, Alex Alex Smith (3): mtd: nand: increase ready wait timeout and report timeouts dt-bindings: binding for jz4780-{nand,bch} mtd: nand: jz4780: driver for NAND

[PATCH v4 2/3] dt-bindings: binding for jz4780-{nand,bch}

2015-07-27 Thread Alex Smith
Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller, used by the jz4780_{nand,bch} drivers. Signed-off-by: Alex Smith Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux-...@lists.infradead.org Cc: devicet

[PATCH v4 1/3] mtd: nand: increase ready wait timeout and report timeouts

2015-07-27 Thread Alex Smith
meout does occur so that it is easier to pinpoint any problems in future caused by the chip not becoming ready. Signed-off-by: Alex Smith Cc: Zubair Lutfullah Kakakhel Cc: David Woodhouse Cc: Brian Norris Cc: linux-...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- v3 -> v4: - New

[PATCH v4 1/3] mtd: nand: increase ready wait timeout and report timeouts

2015-07-27 Thread Alex Smith
occur so that it is easier to pinpoint any problems in future caused by the chip not becoming ready. Signed-off-by: Alex Smith alex.sm...@imgtec.com Cc: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Cc: David Woodhouse dw...@infradead.org Cc: Brian Norris computersforpe...@gmail.com Cc: linux

[PATCH v4 2/3] dt-bindings: binding for jz4780-{nand,bch}

2015-07-27 Thread Alex Smith
Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, as well as the hardware BCH controller, used by the jz4780_{nand,bch} drivers. Signed-off-by: Alex Smith alex.sm...@imgtec.com Cc: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Cc: David Woodhouse dw...@infradead.org Cc

[PATCH v4 0/3] mtd: nand: jz4780: Add NAND and BCH drivers

2015-07-27 Thread Alex Smith
an additional patch to fix an issue that was encountered in the external Ci20 3.18 kernel branch. Review and feedback welcome. Thanks, Alex Alex Smith (3): mtd: nand: increase ready wait timeout and report timeouts dt-bindings: binding for jz4780-{nand,bch} mtd: nand: jz4780: driver for NAND

[PATCH v4 3/3] mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs

2015-07-27 Thread Alex Smith
implementing a common driver for them quite messy. Signed-off-by: Alex Smith alex.sm...@imgtec.com Cc: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com Cc: David Woodhouse dw...@infradead.org Cc: Brian Norris computersforpe...@gmail.com Cc: linux-...@lists.infradead.org Cc: linux-kernel

Re: question about drivers/dma/dma-jz4780.c

2015-07-24 Thread Alex Smith
On 24/07/2015 07:30, Vinod Koul wrote: On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote: Yes for dmaengine drivers I do ask this question which typically ends up in driver invoking devm_irq_free() in driver's remove callback IMHO don't think devm irq calls are very useful, they do

Re: question about drivers/dma/dma-jz4780.c

2015-07-24 Thread Alex Smith
On 24/07/2015 07:30, Vinod Koul wrote: On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote: Yes for dmaengine drivers I do ask this question which typically ends up in driver invoking devm_irq_free() in driver's remove callback IMHO don't think devm irq calls are very useful, they do

Re: question about drivers/dma/dma-jz4780.c

2015-07-22 Thread Alex Smith
On 21/07/2015 05:15, Vinod Koul wrote: On Mon, Jul 20, 2015 at 10:28:14AM +0200, Julia Lawall wrote: On Mon, 20 Jul 2015, Alex Smith wrote: On 19/07/2015 10:08, Julia Lawall wrote: The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs using devm_request_irq. The probe

Re: question about drivers/dma/dma-jz4780.c

2015-07-22 Thread Alex Smith
On 21/07/2015 05:15, Vinod Koul wrote: On Mon, Jul 20, 2015 at 10:28:14AM +0200, Julia Lawall wrote: On Mon, 20 Jul 2015, Alex Smith wrote: On 19/07/2015 10:08, Julia Lawall wrote: The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs using devm_request_irq. The probe

Re: question about drivers/dma/dma-jz4780.c

2015-07-20 Thread Alex Smith
On 19/07/2015 10:08, Julia Lawall wrote: The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs using devm_request_irq. The probe function then ends with: err_unregister_dev: dma_async_device_unregister(dd); err_disable_clk:

Re: question about drivers/dma/dma-jz4780.c

2015-07-20 Thread Alex Smith
On 19/07/2015 10:08, Julia Lawall wrote: The file drivers/dma/dma-jz4780.c has a probe function that sets up irqs using devm_request_irq. The probe function then ends with: err_unregister_dev: dma_async_device_unregister(dd); err_disable_clk: clk_disable_unprepare(jzdma-clk);

[PATCH] x86, doc: Remove cmdline_size from list of fields to be filled in for EFI handover

2015-03-28 Thread Alex Smith
The cmdline_size field in setup_header is listed as read-only, and is never read by the kernel. Therefore, there is no need for it to be set by a boot loader implementing the EFI handover protocol, so remove it from the list of fields required to be set by a boot loader. Signed-off-by: Alex Smith

[PATCH] x86, doc: Remove cmdline_size from list of fields to be filled in for EFI handover

2015-03-28 Thread Alex Smith
The cmdline_size field in setup_header is listed as read-only, and is never read by the kernel. Therefore, there is no need for it to be set by a boot loader implementing the EFI handover protocol, so remove it from the list of fields required to be set by a boot loader. Signed-off-by: Alex Smith

Re: [PATCH_V3 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-28 Thread Alex Smith
On 27 February 2015 at 09:20, Zubair Lutfullah Kakakhel wrote: > Hi Alex, > > On 26/02/15 20:04, Alex Smith wrote: >> Hi Zubair, >> >> On 26 February 2015 at 12:43, Zubair Lutfullah Kakakhel >> wrote: >>> From: Alex Smith >>> >>> Ad

Re: [PATCH_V3 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-28 Thread Alex Smith
On 27 February 2015 at 09:20, Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: Hi Alex, On 26/02/15 20:04, Alex Smith wrote: Hi Zubair, On 26 February 2015 at 12:43, Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: From: Alex Smith alex.sm...@imgtec.com Add device

Re: [PATCH_V3 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-26 Thread Alex Smith
Hi Zubair, On 26 February 2015 at 12:43, Zubair Lutfullah Kakakhel wrote: > From: Alex Smith > > Add device tree bindings for the DMA controller on JZ4780 SoCs, used by > the dma-jz4780 driver. > > Signed-off-by: Alex Smith > Signed-off-by: Zubair Lutfullah Kakakhe

Re: [PATCH_V3 1/3] dt-bindings: dma: Add binding for jz4780-dma

2015-02-26 Thread Alex Smith
Hi Zubair, On 26 February 2015 at 12:43, Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com wrote: From: Alex Smith alex.sm...@imgtec.com Add device tree bindings for the DMA controller on JZ4780 SoCs, used by the dma-jz4780 driver. Signed-off-by: Alex Smith alex.sm...@imgtec.com Signed

[PATCH] recordmcount/MIPS: Fix possible incorrect mcount_loc table entries in modules

2014-06-17 Thread Alex Smith
. Signed-off-by: Alex Smith Cc: linux-kernel@vger.kernel.org Cc: sta...@vger.kernel.org --- scripts/recordmcount.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h index 9d1421e63ff8..49b582a225b0 100644 --- a/scripts/recordmcount.h

[PATCH] recordmcount/MIPS: Fix possible incorrect mcount_loc table entries in modules

2014-06-17 Thread Alex Smith
. Signed-off-by: Alex Smith alex.sm...@imgtec.com Cc: linux-kernel@vger.kernel.org Cc: sta...@vger.kernel.org --- scripts/recordmcount.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h index 9d1421e63ff8..49b582a225b0 100644

Re: Oops in pwc v4l driver

2007-09-08 Thread Alex Smith
On 03/09/2007, Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Hi Alex, > > On 02/09/07, Alex Smith <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I found an old Philips Askey VC010 webcam and attempted to get it > > working on Linux (latest git, x86_64). &g

Re: Oops in pwc v4l driver

2007-09-08 Thread Alex Smith
On 03/09/2007, Michal Piotrowski [EMAIL PROTECTED] wrote: Hi Alex, On 02/09/07, Alex Smith [EMAIL PROTECTED] wrote: Hi, I found an old Philips Askey VC010 webcam and attempted to get it working on Linux (latest git, x86_64). Is this a regression? Does 2.6.22 work fine? Not sure, I

Oops in pwc v4l driver

2007-09-02 Thread Alex Smith
: mplayer -cache 128 -tv driver=v4l:width=640:height=480:outfmt=i420:device=/dev/video1 -vc rawi420 -vo xv tv:// Thanks, Alex -- Alex Smith - http://www.alex-smith.me.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

Oops in pwc v4l driver

2007-09-02 Thread Alex Smith
: mplayer -cache 128 -tv driver=v4l:width=640:height=480:outfmt=i420:device=/dev/video1 -vc rawi420 -vo xv tv:// Thanks, Alex -- Alex Smith - http://www.alex-smith.me.uk - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: 2.6.23-rc2 compile warnings & 1 section mismatch

2007-08-06 Thread Alex Smith
On 04/08/07, tla <[EMAIL PROTECTED]> wrote: > Hi, > > The following warnings (17) and section mismatch (1) were observed > when compiling linux 2.6.23-rc2. > *snip* > LD .tmp_vmlinux1 > KSYM.tmp_kallsyms1.S > AS .tmp_kallsyms1.o > LD .tmp_vmlinux2 > KSYM

Re: 2.6.23-rc2 compile warnings 1 section mismatch

2007-08-06 Thread Alex Smith
On 04/08/07, tla [EMAIL PROTECTED] wrote: Hi, The following warnings (17) and section mismatch (1) were observed when compiling linux 2.6.23-rc2. *snip* LD .tmp_vmlinux1 KSYM.tmp_kallsyms1.S AS .tmp_kallsyms1.o LD .tmp_vmlinux2 KSYM.tmp_kallsyms2.S