[PATCH 2/3] blk-mq: bitmap tag: fix race on blk_mq_bitmap_tags::wake_cnt

2014-06-12 Thread Alexander Gordeev
valid value with the batch value (and likely prevents the issue from being severe) which is still incorrect and should be a lesser. Cc: Ming Lei Cc: Jens Axboe Signed-off-by: Alexander Gordeev --- block/blk-mq-tag.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) d

[PATCH 1/3] blk-mq: bitmap tag: fix races on shared ::wake_index fields

2014-06-12 Thread Alexander Gordeev
Fix racy updates of shared blk_mq_bitmap_tags::wake_index and blk_mq_hw_ctx::wake_index fields. Cc: Ming Lei tom.leim...@gmail.com Cc: Jens Axboe ax...@kernel.dk Signed-off-by: Alexander Gordeev agord...@redhat.com --- block/blk-mq-tag.c | 32 +--- block/blk-mq

[PATCH 2/3] blk-mq: bitmap tag: fix race on blk_mq_bitmap_tags::wake_cnt

2014-06-12 Thread Alexander Gordeev
with the batch value (and likely prevents the issue from being severe) which is still incorrect and should be a lesser. Cc: Ming Lei tom.leim...@gmail.com Cc: Jens Axboe ax...@kernel.dk Signed-off-by: Alexander Gordeev agord...@redhat.com --- block/blk-mq-tag.c | 14 -- 1 files changed, 12

[PATCH 0/3] blk-mq: bitmap tag: Fix few races

2014-06-12 Thread Alexander Gordeev
Hi Jens, This series is against for-3.16/blk-mq-tagging branch. Cc: Ming Lei tom.leim...@gmail.com Cc: Jens Axboe ax...@kernel.dk Alexander Gordeev (3): blk-mq: bitmap tag: fix races on shared ::wake_index fields blk-mq: bitmap tag: fix race on blk_mq_bitmap_tags::wake_cnt blk-mq: bitmap

[PATCH 3/3] blk-mq: bitmap tag: clean-up bt_get() function

2014-06-12 Thread Alexander Gordeev
: Jens Axboe ax...@kernel.dk Signed-off-by: Alexander Gordeev agord...@redhat.com --- block/blk-mq-tag.c | 27 +++ 1 files changed, 7 insertions(+), 20 deletions(-) diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index 5579fae..dc1f684 100644 --- a/block/blk-mq-tag.c

[PATCH 3/3] AHCI: Use pci_enable_msi_partial() to conserve on 10/16 MSIs

2014-06-10 Thread Alexander Gordeev
-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- drivers/ata/ahci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 6070781..0c7a0f3 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1194,7 +1194,7 @@ static

[PATCH 0/3] Add pci_enable_msi_partial() to conserve MSI-related resources

2014-06-10 Thread Alexander Gordeev
-...@lists.ozlabs.org Cc: linux-s...@vger.kernel.org Cc: x...@kernel.org Cc: xen-de...@lists.xenproject.org Cc: io...@lists.linux-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Alexander Gordeev (3): PCI/MSI: Add pci_enable_msi_partial() PCI/MSI/x86: Support

[PATCH 2/3] PCI/MSI/x86: Support pci_enable_msi_partial()

2014-06-10 Thread Alexander Gordeev
-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- arch/x86/include/asm/pci.h |3 ++- arch/x86/include/asm/x86_init.h |3 ++- arch/x86/kernel/apic/io_apic.c |2 +- arch/x86/kernel/x86_init.c |2 +- arch/x86/pci/xen.c

[PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-06-10 Thread Alexander Gordeev
Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- Documentation/PCI/MSI-HOWTO.txt | 36 ++-- arch/mips/pci/msi-octeon.c |2 +- arch/powerpc/kernel/msi.c |4 +- arch/s390/pci/pci.c |2 +- arch/x86/ker

[PATCH 3/3] AHCI: Use pci_enable_msi_partial() to conserve on 10/16 MSIs

2014-06-10 Thread Alexander Gordeev
-...@vger.kernel.org Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/ata/ahci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 6070781..0c7a0f3 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1194,7

[PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-06-10 Thread Alexander Gordeev
: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev agord...@redhat.com --- Documentation/PCI/MSI-HOWTO.txt | 36 ++-- arch/mips/pci/msi-octeon.c |2 +- arch/powerpc/kernel/msi.c |4 +- arch/s390/pci/pci.c |2

[PATCH 0/3] Add pci_enable_msi_partial() to conserve MSI-related resources

2014-06-10 Thread Alexander Gordeev
-...@lists.ozlabs.org Cc: linux-s...@vger.kernel.org Cc: x...@kernel.org Cc: xen-de...@lists.xenproject.org Cc: io...@lists.linux-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Alexander Gordeev (3): PCI/MSI: Add pci_enable_msi_partial() PCI/MSI/x86: Support

[PATCH 2/3] PCI/MSI/x86: Support pci_enable_msi_partial()

2014-06-10 Thread Alexander Gordeev
-foundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev agord...@redhat.com --- arch/x86/include/asm/pci.h |3 ++- arch/x86/include/asm/x86_init.h |3 ++- arch/x86/kernel/apic/io_apic.c |2 +- arch/x86/kernel/x86_init.c |2 +- arch

Re: blk-mq: bitmap tag: performance degradation?

2014-06-05 Thread Alexander Gordeev
bitmap tags on a 48 CPU box with NVMe device indeed shows almost the same performance/cache rate as the stock kernel. -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

Re: blk-mq: bitmap tag: performance degradation?

2014-06-05 Thread Alexander Gordeev
indeed shows almost the same performance/cache rate as the stock kernel. -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

blk-mq: bitmap tag: performance degradation?

2014-06-04 Thread Alexander Gordeev
-misses:k 69.446112553 seconds time elapsed Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

blk-mq: bitmap tag: performance degradation?

2014-06-04 Thread Alexander Gordeev
-misses:k 69.446112553 seconds time elapsed Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-28 Thread Alexander Gordeev
On Tue, May 27, 2014 at 05:19:50PM -0600, Bjorn Helgaas wrote: > I assume this is being handled by Matt and/or Alexandre (listed in > MAINTAINERS). Let me know if I should do anything. Hi Bjorn, No worries, the patch is in Andrew's tree already. -- Regards, Alexander Gordeev

Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-28 Thread Alexander Gordeev
On Tue, May 27, 2014 at 05:19:50PM -0600, Bjorn Helgaas wrote: I assume this is being handled by Matt and/or Alexandre (listed in MAINTAINERS). Let me know if I should do anything. Hi Bjorn, No worries, the patch is in Andrew's tree already. -- Regards, Alexander Gordeev agord...@redhat.com

Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-13 Thread Alexander Gordeev
On Tue, May 13, 2014 at 02:46:34PM -0700, Andrew Morton wrote: > On Tue, 13 May 2014 17:01:32 +0200 Alexander Gordeev > wrote: > > > As result of deprecation of MSI-X/MSI enablement functions > > pci_enable_msix() and pci_enable_msi_block() all drivers > > usin

Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-13 Thread Alexander Gordeev
On Tue, May 13, 2014 at 05:01:32PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enab

[PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-13 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Matt Porter Cc: Alexandre Bounine Cc: linux-...@vger.kernel.org --- drivers/rapidio/devices/tsi721.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c index

[PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-13 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Matt Porter mpor...@kernel.crashing.org Cc: Alexandre Bounine alexandre.boun...@idt.com Cc: linux-...@vger.kernel.org --- drivers/rapidio/devices/tsi721.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers

Re: [PATCH v2 RESEND] rapidio/tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-13 Thread Alexander Gordeev
On Tue, May 13, 2014 at 02:46:34PM -0700, Andrew Morton wrote: On Tue, 13 May 2014 17:01:32 +0200 Alexander Gordeev agord...@redhat.com wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces

Re: [PATCH] ntp: make is_error_status() use its argument

2014-05-12 Thread Alexander Gordeev
No objections from me, of course. Good catch. В Mon, 12 May 2014 10:54:29 -0700 John Stultz пишет: > On 05/12/2014 06:35 AM, George Spelvin wrote: > > It's an inline function always called with the global time_status > > as an argument, so there's zero functional difference, but the > >

Re: [PATCH] ntp: make is_error_status() use its argument

2014-05-12 Thread Alexander Gordeev
No objections from me, of course. Good catch. В Mon, 12 May 2014 10:54:29 -0700 John Stultz john.stu...@linaro.org пишет: On 05/12/2014 06:35 AM, George Spelvin wrote: It's an inline function always called with the global time_status as an argument, so there's zero functional difference,

Re: [PATCH v1.1 2/16 update 2] arcmsr: Adding code to support MSI-X interrupt

2014-05-06 Thread Alexander Gordeev
uA; > > - uint32_t intmask_org; > > - intmask_org = arcmsr_disable_outbound_ints(acb); > > writel(ARCMSR_SIGNATURE_SET_CONFIG, \ > > >message_rwbuffer[0]); > > wr

Re: [PATCH v1.1 2/16 update 2] arcmsr: Adding code to support MSI-X interrupt

2014-05-06 Thread Alexander Gordeev
at http://vger.kernel.org/majordomo-info.html -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH RFC 0/2] percpu_ida: Take into account CPU topology when stealing tags

2014-05-01 Thread Alexander Gordeev
On Thu, May 01, 2014 at 11:24:42PM +0200, Alexander Gordeev wrote: > On Tue, Apr 22, 2014 at 01:56:29PM +0200, Peter Zijlstra wrote: > > I've not had time to revisit/finish them, but you should definitely > > clean up the percpu_ida stuff and reduce existing contention before >

Re: [PATCH RFC 0/2] percpu_ida: Take into account CPU topology when stealing tags

2014-05-01 Thread Alexander Gordeev
err = fn(pool->freelist[i], data); if (err) break; } - spin_unlock(>lock); -out: - local_irq_restore(flags); + spin_unlock_irqrestore(>lock, flags); + return err; } EXPORT_SYMBOL_GPL(percpu_ida_for_each_free); -

Re: [PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-05-01 Thread Alexander Gordeev
i_irqs() anyway. In fact, I think arch_msi_check_device() could be eliminated, but I do not want to engage with PPC folks at this stage ;) > arch_setup_msi_irqs() is clearly not stateless, but I assume > free_msi_irqs() is enough to clean up any state if we fail. > > Bjorn -- Regards, Al

Re: [PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-05-01 Thread Alexander Gordeev
in arch_setup_msi_irqs() anyway. In fact, I think arch_msi_check_device() could be eliminated, but I do not want to engage with PPC folks at this stage ;) arch_setup_msi_irqs() is clearly not stateless, but I assume free_msi_irqs() is enough to clean up any state if we fail. Bjorn -- Regards, Alexander

Re: [PATCH RFC 0/2] percpu_ida: Take into account CPU topology when stealing tags

2014-05-01 Thread Alexander Gordeev
); + spin_unlock_irqrestore(pool-lock, flags); + return err; } EXPORT_SYMBOL_GPL(percpu_ida_for_each_free); -- 1.7.7.6 -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH RFC 0/2] percpu_ida: Take into account CPU topology when stealing tags

2014-05-01 Thread Alexander Gordeev
On Thu, May 01, 2014 at 11:24:42PM +0200, Alexander Gordeev wrote: On Tue, Apr 22, 2014 at 01:56:29PM +0200, Peter Zijlstra wrote: I've not had time to revisit/finish them, but you should definitely clean up the percpu_ida stuff and reduce existing contention before going overboard. Hi

Re: [PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-04-30 Thread Alexander Gordeev
On Mon, Apr 14, 2014 at 03:28:34PM +0200, Alexander Gordeev wrote: > There are no users of pci_enable_msi_block() function have > left. Obsolete it in favor of pci_enable_msi_range() and > pci_enable_msi_exact() functions. Hi Bjorn, How about this one? Thanks! -- Regards, Alexande

Re: [PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-04-30 Thread Alexander Gordeev
On Mon, Apr 14, 2014 at 03:28:34PM +0200, Alexander Gordeev wrote: There are no users of pci_enable_msi_block() function have left. Obsolete it in favor of pci_enable_msi_range() and pci_enable_msi_exact() functions. Hi Bjorn, How about this one? Thanks! -- Regards, Alexander Gordeev agord

[PATCH v2 net-next 2/2] qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
: Shahed Shaikh Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH net-next 2/2] qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
; + return err; At this point "err" could only be -ENOSPC. I am not sure why returning "err" is better, but I'll repost if you insist. > > Thanks, > Shahed > -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH net-next 1/2] i40evf: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Mitch Williams Cc: Jesse Brandeburg Cc: Linux NICS Cc: e1000-de...@lists.sourceforge.net Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 31 -- 1 files changed, 11 insertions

[PATCH net-next 0/2] Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
-...@vger.kernel.org Alexander Gordeev (2): i40evf: Use pci_enable_msix_range() instead of pci_enable_msix() qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix() drivers/net/ethernet/intel/i40evf/i40evf_main.c | 31 -- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

[PATCH net-next 2/2] qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
: Shahed Shaikh Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic

[PATCH net-next 2/2] qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
: Shahed Shaikh shahed.sha...@qlogic.com Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

[PATCH net-next 0/2] Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
...@lists.sourceforge.net Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Alexander Gordeev (2): i40evf: Use pci_enable_msix_range() instead of pci_enable_msix() qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix() drivers/net/ethernet/intel/i40evf

[PATCH net-next 1/2] i40evf: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Mitch Williams mitch.a.willi...@intel.com Cc: Jesse Brandeburg jesse.brandeb...@intel.com Cc: Linux NICS linux.n...@intel.com Cc: e1000-de...@lists.sourceforge.net Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/net/ethernet

Re: [PATCH net-next 2/2] qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
!adapter-drv_rss_rings) - return -ENOSPC; + return err; At this point err could only be -ENOSPC. I am not sure why returning err is better, but I'll repost if you insist. Thanks, Shahed -- Regards, Alexander Gordeev agord...@redhat.com

[PATCH v2 net-next 2/2] qlcnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-25 Thread Alexander Gordeev
: Shahed Shaikh shahed.sha...@qlogic.com Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions

[PATCH RESEND 0/2] percpu_ida: Couple of tweaks

2014-04-22 Thread Alexander Gordeev
Hello, The patches are against 3.15-rc2 Cc: Kent Overstreet Cc: Peter Zijlstra Cc: Jens Axboe Cc: "Nicholas A. Bellinger" Alexander Gordeev (2): percpu_ida: Move waking up waiters out of atomic contexts percpu_ida: Sanity check initialization parameters lib/percpu_id

[PATCH RESEND 2/2] percpu_ida: Sanity check initialization parameters

2014-04-22 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev Cc: Kent Overstreet Cc: Peter Zijlstra Cc: Jens Axboe Cc: "Nicholas A. Bellinger" Acked-by: Kent Overstreet --- lib/percpu_ida.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/percpu_ida.c b/lib/percpu_ida.c ind

[PATCH RESEND 1/2] percpu_ida: Move waking up waiters out of atomic contexts

2014-04-22 Thread Alexander Gordeev
Currently percpu_ida_free() waikes up waiters always with local interrupts disabled and sometimes with pool->lock held. Yet, it does not appear there is any reason why it could not be done out of these atomic contexts. Signed-off-by: Alexander Gordeev Cc: Kent Overstreet Cc: Peter Zijlstra

Re: [PATCH RFC 0/2] percpu_ida: Take into account CPU topology when stealing tags

2014-04-22 Thread Alexander Gordeev
On Wed, Mar 26, 2014 at 02:34:22PM +0100, Alexander Gordeev wrote: > But other systems (more dense?) showed increased cache-hit rate > up to 20%, i.e. this one: Hello Gentlemen, Any feedback on this? Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from thi

Re: [PATCH RFC 0/2] percpu_ida: Take into account CPU topology when stealing tags

2014-04-22 Thread Alexander Gordeev
On Wed, Mar 26, 2014 at 02:34:22PM +0100, Alexander Gordeev wrote: But other systems (more dense?) showed increased cache-hit rate up to 20%, i.e. this one: Hello Gentlemen, Any feedback on this? Thanks! -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list

[PATCH RESEND 1/2] percpu_ida: Move waking up waiters out of atomic contexts

2014-04-22 Thread Alexander Gordeev
Currently percpu_ida_free() waikes up waiters always with local interrupts disabled and sometimes with pool-lock held. Yet, it does not appear there is any reason why it could not be done out of these atomic contexts. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Kent Overstreet k

[PATCH RESEND 0/2] percpu_ida: Couple of tweaks

2014-04-22 Thread Alexander Gordeev
Hello, The patches are against 3.15-rc2 Cc: Kent Overstreet k...@daterainc.com Cc: Peter Zijlstra pet...@infradead.org Cc: Jens Axboe ax...@kernel.dk Cc: Nicholas A. Bellinger n...@linux-iscsi.org Alexander Gordeev (2): percpu_ida: Move waking up waiters out of atomic contexts percpu_ida

[PATCH RESEND 2/2] percpu_ida: Sanity check initialization parameters

2014-04-22 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Kent Overstreet k...@daterainc.com Cc: Peter Zijlstra pet...@infradead.org Cc: Jens Axboe ax...@kernel.dk Cc: Nicholas A. Bellinger n...@linux-iscsi.org Acked-by: Kent Overstreet k...@daterainc.com --- lib/percpu_ida.c |5 + 1 files

[PATCH RESEND 1/2] skd: Use pci_enable_msix_exact() instead of pci_enable_msix_range()

2014-04-21 Thread Alexander Gordeev
Function pci_enable_msix_exact() is a variation of pci_enable_msix_range() that allows a device driver to request a particular number of MSI-X interrupts, rather than any number within a specified range. Signed-off-by: Alexander Gordeev Cc: Jens Axboe Cc: Bartlomiej Zolnierkiewicz Cc: Kyungmin

[PATCH RESEND 2/2] cciss: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Mike Miller Cc: iss_storage...@hp.com Cc: Jens Axboe Cc: linux-...@vger.kernel.org --- drivers/block/cciss.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 73894ca..4595c22 100644

[PATCH RESEND 0/2] : block: Use pci_enable_msix_exact()

2014-04-21 Thread Alexander Gordeev
Alexander Gordeev (2): skd: Use pci_enable_msix_exact() instead of pci_enable_msix_range() cciss: Use pci_enable_msix_exact() instead of pci_enable_msix() drivers/block/cciss.c|6 +- drivers/block/skd_main.c |7 +++ 2 files changed, 4 insertions(+), 9 deletions(-) -- 1.7.7.6

[PATCH v2 RESEND] portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org --- drivers/pci/pcie/portdrv_core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 986f8ea..0b1efb2 100644

Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enab

Re: [PATCH v2] kvm: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Sat, Feb 22, 2014 at 09:58:10AM +0100, Paolo Bonzini wrote: > Il 22/02/2014 09:50, Alexander Gordeev ha scritto: > >Commit d158fc7 ("Merge tag 'pci-v3.14-fixes-1'") in Linus's tree has it. > > > >pci_enable_msix() is going to be removed once all driver

Re: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Fri, Mar 07, 2014 at 01:35:34PM +, Bounine, Alexandre wrote: > > From: Alexander Gordeev [mailto:agord...@redhat.com] > > Sent: Thursday, March 06, 2014 3:11 PM > > To: linux-kernel@vger.kernel.org > > Cc: Alexander Gordeev; Matt Porter; Bounine, Alexandre; linux-

Re: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Fri, Mar 07, 2014 at 01:35:34PM +, Bounine, Alexandre wrote: From: Alexander Gordeev [mailto:agord...@redhat.com] Sent: Thursday, March 06, 2014 3:11 PM To: linux-kernel@vger.kernel.org Cc: Alexander Gordeev; Matt Porter; Bounine, Alexandre; linux- p...@vger.kernel.org Subject

Re: [PATCH v2] kvm: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Sat, Feb 22, 2014 at 09:58:10AM +0100, Paolo Bonzini wrote: Il 22/02/2014 09:50, Alexander Gordeev ha scritto: Commit d158fc7 (Merge tag 'pci-v3.14-fixes-1') in Linus's tree has it. pci_enable_msix() is going to be removed once all drivers updated with new interface. So, do I have

Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact

[PATCH v2 RESEND] portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org --- drivers/pci/pcie/portdrv_core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c

[PATCH RESEND 0/2] : block: Use pci_enable_msix_exact()

2014-04-21 Thread Alexander Gordeev
mike.mil...@hp.com Cc: iss_storage...@hp.com Cc: linux-...@vger.kernel.org Alexander Gordeev (2): skd: Use pci_enable_msix_exact() instead of pci_enable_msix_range() cciss: Use pci_enable_msix_exact() instead of pci_enable_msix() drivers/block/cciss.c|6 +- drivers/block/skd_main.c

[PATCH RESEND 2/2] cciss: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-21 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Mike Miller mike.mil...@hp.com Cc: iss_storage...@hp.com Cc: Jens Axboe ax...@kernel.dk Cc: linux-...@vger.kernel.org --- drivers/block/cciss.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/block/cciss.c b

[PATCH RESEND 1/2] skd: Use pci_enable_msix_exact() instead of pci_enable_msix_range()

2014-04-21 Thread Alexander Gordeev
Function pci_enable_msix_exact() is a variation of pci_enable_msix_range() that allows a device driver to request a particular number of MSI-X interrupts, rather than any number within a specified range. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Jens Axboe ax...@kernel.dk Cc

[PATCH 1/1] ahci: Do not receive interrupts sent by dummy ports

2014-04-17 Thread Alexander Gordeev
and prevents the described issue. Signed-off-by: Alexander Gordeev Cc: Tejun Heo Cc: David Milburn Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 44d40c7

[PATCH 0/1] ahci: Do not receive interrupts sent by dummy ports

2014-04-17 Thread Alexander Gordeev
Tejun, David, I would expect handle_bad_irq()->print_irq_desc() gets called if dummy port interrupt arrived. Could be a spurious interrupt complain as well. Cc: Tejun Heo Cc: David Milburn Cc: linux-...@vger.kernel.org Alexander Gordeev (1): ahci: Do not receive interrupts sent by du

Re: [PATCH v2 0/2] ahci: Tweaks to the driver's PCI function

2014-04-17 Thread Alexander Gordeev
On Thu, Apr 17, 2014 at 09:28:06AM -0400, Tejun Heo wrote: > On Thu, Apr 17, 2014 at 02:13:48PM +0200, Alexander Gordeev wrote: > > Changes since v1: > > - ahci_is_mrsm() open-coded inside ahci_init_interrupt() > > - changelog elaborated > > > &

Re: [PATCH 1/2] ahci: Ensure "MSI Revert to Single Message" mode is not enforced

2014-04-17 Thread Alexander Gordeev
n. Yes, I think it needs to go to -stable. > Thanks. > > -- > tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

[PATCH v2 1/2] ahci: Ensure "MSI Revert to Single Message" mode is not enforced

2014-04-17 Thread Alexander Gordeev
tx; - nvec = pci_msi_vec_count(pdev); + nvec = 8; if (nvec < 0) goto intx; Signed-off-by: Alexander Gordeev Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c | 11 ++- drivers/ata/ahci.h |1 + 2 files changed, 11 insertions(+), 1 deletions(-) diff --git

[PATCH v2 0/2] ahci: Tweaks to the driver's PCI function

2014-04-17 Thread Alexander Gordeev
Changes since v1: - ahci_is_mrsm() open-coded inside ahci_init_interrupt() - changelog elaborated Cc: linux-...@vger.kernel.org Alexander Gordeev (2): ahci: Ensure "MSI Revert to Single Message" mode is not enforced ahci: Use pci_enable_msi_exact

[PATCH v2 2/2] ahci: Use pci_enable_msi_exact() instead of pci_enable_msi_range()

2014-04-17 Thread Alexander Gordeev
The driver calls pci_enable_msi_range() function with the range of [nvec..nvec] which what pci_enable_msi_exact() function is for. Signed-off-by: Alexander Gordeev Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 2/2] ahci: Use pci_enable_msi_exact() instead of pci_enable_msi_range()

2014-04-17 Thread Alexander Gordeev
The driver calls pci_enable_msi_range() function with the range of [nvec..nvec] which what pci_enable_msi_exact() function is for. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c |8 1 files changed, 4 insertions(+), 4

[PATCH v2 0/2] ahci: Tweaks to the driver's PCI function

2014-04-17 Thread Alexander Gordeev
Changes since v1: - ahci_is_mrsm() open-coded inside ahci_init_interrupt() - changelog elaborated Cc: linux-...@vger.kernel.org Alexander Gordeev (2): ahci: Ensure MSI Revert to Single Message mode is not enforced ahci: Use pci_enable_msi_exact() instead

[PATCH v2 1/2] ahci: Ensure MSI Revert to Single Message mode is not enforced

2014-04-17 Thread Alexander Gordeev
(pdev); + nvec = 8; if (nvec 0) goto intx; Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c | 11 ++- drivers/ata/ahci.h |1 + 2 files changed, 11 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 1/2] ahci: Ensure MSI Revert to Single Message mode is not enforced

2014-04-17 Thread Alexander Gordeev
it needs to go to -stable. Thanks. -- tejun -- Regards, Alexander Gordeev agord...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/2] ahci: Tweaks to the driver's PCI function

2014-04-17 Thread Alexander Gordeev
On Thu, Apr 17, 2014 at 09:28:06AM -0400, Tejun Heo wrote: On Thu, Apr 17, 2014 at 02:13:48PM +0200, Alexander Gordeev wrote: Changes since v1: - ahci_is_mrsm() open-coded inside ahci_init_interrupt() - changelog elaborated Cc: linux-...@vger.kernel.org Alexander Gordeev

[PATCH 1/1] ahci: Do not receive interrupts sent by dummy ports

2014-04-17 Thread Alexander Gordeev
and prevents the described issue. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: David Milburn dmilb...@redhat.com Cc: linux-...@vger.kernel.org --- drivers/ata/ahci.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git

[PATCH 0/1] ahci: Do not receive interrupts sent by dummy ports

2014-04-17 Thread Alexander Gordeev
Tejun, David, I would expect handle_bad_irq()-print_irq_desc() gets called if dummy port interrupt arrived. Could be a spurious interrupt complain as well. Cc: Tejun Heo t...@kernel.org Cc: David Milburn dmilb...@redhat.com Cc: linux-...@vger.kernel.org Alexander Gordeev (1): ahci: Do

[PATCH] qlcnic: Fix MSI-X initialization code

2014-04-15 Thread Alexander Gordeev
. Cc: Shahed Shaikh Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 28 - 1 files changed, 16 insertions(+), 12 deletions(-) diff --git

[PATCH] crypto/ccp: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-15 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Tom Lendacky Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/crypto/ccp/ccp-pci.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/c

[PATCH] crypto/ccp: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-15 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Tom Lendacky thomas.lenda...@amd.com Cc: Herbert Xu herb...@gondor.apana.org.au Cc: David S. Miller da...@davemloft.net Cc: linux-cry...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/crypto/ccp/ccp-pci.c |7 +++ 1 files

[PATCH] qlcnic: Fix MSI-X initialization code

2014-04-15 Thread Alexander Gordeev
. Cc: Shahed Shaikh shahed.sha...@qlogic.com Cc: dept-hsglinuxnic...@qlogic.com Cc: net...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 28 - 1 files changed, 16

Re: [PATCH v2 RESEND 2/4] portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
On Wed, Mar 12, 2014 at 09:56:34PM -0600, Bjorn Helgaas wrote: > On Thu, Mar 06, 2014 at 09:11:22PM +0100, Alexander Gordeev wrote: > > As result of deprecation of MSI-X/MSI enablement functions > > pci_enable_msix() and pci_enable_msi_block() all drivers > > using thes

[PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-04-14 Thread Alexander Gordeev
-by: Alexander Gordeev Cc: linux-m...@linux-mips.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-s...@vger.kernel.org Cc: x...@kernel.org Cc: linux-...@vger.kernel.org --- drivers/pci/msi.c | 79 +- include/linux/pci.h |5 +-- 2 files changed, 34

Re: [PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block()

2014-04-14 Thread Alexander Gordeev
On Mon, Apr 14, 2014 at 09:14:07AM +0200, Alexander Gordeev wrote: > @@ -1244,7 +1241,7 @@ static inline void pcie_set_ecrc_checking(struct > pci_dev *dev) { } > static inline void pcie_ecrc_get_policy(char *str) { } > #endif > > -#define pci_enable_msi(pdev) pci_enable

[PATCH v2 RESEND 03/23] bfa: Cleanup bfad_setup_intr() function

2014-04-14 Thread Alexander Gordeev
Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH v2 RESEND 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
...@vmware.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Alexander Gordeev (23): be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() bfa: Do not call pci_enable_msix() after it failed once bfa: Cleanup bfad_setup_intr() function bfa: Use pci_enable_msix_exact

[PATCH v2 RESEND 02/23] bfa: Do not call pci_enable_msix() after it failed once

2014-04-14 Thread Alexander Gordeev
Function pci_enable_msix() should not be called in case it threw a negative errno from a previous call. Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Anil Gurumurthy --- drivers/scsi/bfa

[PATCH v2 RESEND 06/23] csiostor: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Naresh Kumar Inna Cc: Arvind Bhushan Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/csiostor/csio_hw.h |2 +- drivers/scsi/csiostor/csio_isr.c | 22 +- 2 files changed, 10 insertions(+), 14 deletions

[PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Jayamohan Kallickal Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b

[PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Anil Gurumurthy Cc: Vijaya Mohan Guvva Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/bfa/bfad.c | 20 ++-- 1 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi

[PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix()

2014-04-14 Thread Alexander Gordeev
There is no need to call pci_disable_msix() in case the previous call to pci_enable_msix() failed Signed-off-by: Alexander Gordeev Cc: Naresh Kumar Inna Cc: Arvind Bhushan Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/csiostor/csio_isr.c |4 +--- 1 files

[PATCH v2 RESEND 07/23] fnic: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Hiral Patel Cc: Suma Ramars Cc: Brian Uchino Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/fnic/fnic_isr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fnic/fnic_isr.c b/drivers/scsi

[PATCH v2 RESEND 12/23] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: James Smart Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/lpfc/lpfc_init.c | 38 +- 1 files changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi

[PATCH v2 RESEND 11/23] lpfc: Remove superfluous call to pci_disable_msix()

2014-04-14 Thread Alexander Gordeev
There is no need to call pci_disable_msix() in case the previous call to pci_enable_msix() failed Signed-off-by: Alexander Gordeev Cc: James Smart Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org Acked-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c |9 ++--- 1 files

[PATCH v2 RESEND 08/23] isci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-14 Thread Alexander Gordeev
. Signed-off-by: Alexander Gordeev Cc: Lukasz Dorau Cc: Maciej Patelczyk Cc: Dave Jiang Cc: intel-linux-...@intel.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org --- drivers/scsi/isci/init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/isci

<    3   4   5   6   7   8   9   10   11   12   >