Re: [RFC PATCH 5/9] media: vb2: add support for requests

2018-01-17 Thread Alexandre Courbot
On Tue, Jan 16, 2018 at 7:37 PM, Hans Verkuil wrote: > On 01/16/2018 10:39 AM, Alexandre Courbot wrote: >> On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil wrote: >>> On 01/15/2018 09:24 AM, Alexandre Courbot wrote: >>>> On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil

Re: [RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl

2018-01-16 Thread Alexandre Courbot
On Mon, Jan 15, 2018 at 6:19 PM, Hans Verkuil wrote: > On 01/15/2018 09:24 AM, Alexandre Courbot wrote: >> On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil wrote: >>> On 12/15/17 08:56, Alexandre Courbot wrote: >>>> Support the request argument of the QBUF ioctl. >

Re: [RFC PATCH 5/9] media: vb2: add support for requests

2018-01-16 Thread Alexandre Courbot
On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil wrote: > On 01/15/2018 09:24 AM, Alexandre Courbot wrote: >> On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote: >>> On 12/15/17 08:56, Alexandre Courbot wrote: >>>> Add throttling support for buffers when requests ar

Re: [PATCH v7 1/6] [media] vb2: add is_unordered callback for drivers

2018-01-15 Thread Alexandre Courbot
On Mon, Jan 15, 2018 at 9:01 PM, Gustavo Padovan wrote: > 2018-01-15 Alexandre Courbot : > >> On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote: >> > From: Gustavo Padovan >> > >> > Explicit synchronization benefits a lot from ordered queues, they fit

Re: [RFC PATCH 5/9] media: vb2: add support for requests

2018-01-15 Thread Alexandre Courbot
On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote: > On 12/15/17 08:56, Alexandre Courbot wrote: >> Add throttling support for buffers when requests are in use on a given >> queue. Buffers associated to a request are kept into the vb2 queue until >> the request becomes a

Re: [RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl

2018-01-15 Thread Alexandre Courbot
On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil wrote: > On 12/15/17 08:56, Alexandre Courbot wrote: >> Support the request argument of the QBUF ioctl. >> >> Signed-off-by: Alexandre Courbot >> --- >> drivers/media/v4l2-core/v4l2-ioctl.c | 93 >>

Re: [RFC PATCH 4/9] videodev2.h: Add request field to v4l2_buffer

2018-01-15 Thread Alexandre Courbot
On Fri, Jan 12, 2018 at 7:22 PM, Hans Verkuil wrote: > On 12/15/17 08:56, Alexandre Courbot wrote: >> From: Hans Verkuil >> >> When queuing buffers allow for passing the request ID that >> should be associated with this buffer. >> >> Signed-off-by: Hans V

Re: [RFC PATCH 0/9] media: base request API support

2018-01-15 Thread Alexandre Courbot
Hi Hans, On Fri, Jan 12, 2018 at 8:45 PM, Hans Verkuil wrote: > Hi Alexandre, > > On 12/15/17 08:56, Alexandre Courbot wrote: >> Here is a new attempt at the request API, following the UAPI we agreed on in >> Prague. Hopefully this can be used as the basis to move forward. &

Re: [PATCH v7 5/6] [media] vb2: add out-fence support to QBUF

2018-01-14 Thread Alexandre Courbot
On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote: > /* > * vb2_start_streaming() - Attempt to start streaming. > * @q: videobuf2 queue > @@ -1489,18 +1562,16 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int > index, void *pb, > if (vb->in_fence) { >

Re: [PATCH v7 1/6] [media] vb2: add is_unordered callback for drivers

2018-01-14 Thread Alexandre Courbot
On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Explicit synchronization benefits a lot from ordered queues, they fit > better in a pipeline with DRM for example so create a opt-in way for > drivers notify videobuf2 that the queue is unordered. > > Drivers don'

Re: [RFC PATCH 9/9] media: vim2m: add request support

2017-12-20 Thread Alexandre Courbot
On Tue, Dec 19, 2017 at 5:53 AM, Gustavo Padovan wrote: > Hi Alex, > > 2017-12-15 Alexandre Courbot : > >> Set the necessary ops for supporting requests in vim2m. >> >> Signed-off-by: Alexandre Courbot >> --- >> drivers/media/platform/vim2m.c | 22 +++

Re: [RFC PATCH 0/9] media: base request API support

2017-12-20 Thread Alexandre Courbot
On Sat, Dec 16, 2017 at 6:04 AM, Nicolas Dufresne wrote: > Le vendredi 15 décembre 2017 à 16:56 +0900, Alexandre Courbot a écrit : >> Here is a new attempt at the request API, following the UAPI we agreed on in >> Prague. Hopefully this can be used as the basis to move forward. &g

Re: [RFC PATCH 0/9] media: base request API support

2017-12-20 Thread Alexandre Courbot
On Sat, Dec 16, 2017 at 6:02 AM, Nicolas Dufresne wrote: > Le vendredi 15 décembre 2017 à 16:56 +0900, Alexandre Courbot a écrit : >> Here is a new attempt at the request API, following the UAPI we agreed on in >> Prague. Hopefully this can be used as the basis to move forward. &g

[RFC PATCH 2/9] media: request: add generic queue

2017-12-14 Thread Alexandre Courbot
Add a generic request queue that supports most use-case and should be usable as-is by drivers without special hardware features. The generic queue stores the requests into a FIFO list and executes them sequentially. Signed-off-by: Alexandre Courbot --- drivers/media/Makefile

[RFC PATCH 4/9] videodev2.h: Add request field to v4l2_buffer

2017-12-14 Thread Alexandre Courbot
From: Hans Verkuil When queuing buffers allow for passing the request ID that should be associated with this buffer. Signed-off-by: Hans Verkuil [acour...@chromium.org: make request ID 32-bit] Signed-off-by: Alexandre Courbot --- drivers/media/usb/cpia2/cpia2_v4l.c | 2 +- drivers

[RFC PATCH 8/9] media: vim2m: add media device

2017-12-14 Thread Alexandre Courbot
Request API requires a media node. Add one to the vim2m driver so we can use requests with it. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vim2m.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media

[RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl

2017-12-14 Thread Alexandre Courbot
Support the request argument of the QBUF ioctl. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ioctl.c | 93 +++- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2

[RFC PATCH 5/9] media: vb2: add support for requests

2017-12-14 Thread Alexandre Courbot
x27;s buffers. Also add support for the request parameter when handling the QBUF ioctl. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/videobuf2-core.c | 59 drivers/media/v4l2-core/videobuf2-v4l2.c | 29 +++- include/media/videobuf2-c

[RFC PATCH 3/9] media: request: add generic entity ops

2017-12-14 Thread Alexandre Courbot
Add skeleton ops for generic entities. The intent is to provide a generic mechanism to apply request parameters to entities using regular media/v4l2 functions. Signed-off-by: Alexandre Courbot --- drivers/media/Makefile | 3 +- drivers/media/media-request-entity-generic.c

[RFC PATCH 9/9] media: vim2m: add request support

2017-12-14 Thread Alexandre Courbot
Set the necessary ops for supporting requests in vim2m. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vim2m.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index a32e8a7950eb

[RFC PATCH 7/9] media: v4l2-mem2mem: add request support

2017-12-14 Thread Alexandre Courbot
Support request API in the mem2mem framework. Drivers that specify ops for the queue and entities can support requests seamlessly. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-mem2mem.c | 34 ++ include/media/v4l2-mem2mem.h | 19

[RFC PATCH 1/9] media: add request API core and UAPI

2017-12-14 Thread Alexandre Courbot
. Signed-off-by: Alexandre Courbot --- drivers/media/Makefile | 3 +- drivers/media/media-device.c | 6 + drivers/media/media-request.c| 390 +++ drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- include/media/media-device.h

[RFC PATCH 0/9] media: base request API support

2017-12-14 Thread Alexandre Courbot
to be sufficient most of the time though). A very simple test program exercising this API is available here (don't forget to adapt the /dev/media0 hardcoding): https://gist.github.com/Gnurou/dbc3776ed97ea7d4ce6041ea15eb0438 Looking forward to your feedback and comments! Alexandre Courbot (8):

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-19 Thread Alexandre Courbot
On Fri, Nov 17, 2017 at 10:01 PM, Gustavo Padovan wrote: > 2017-11-17 Alexandre Courbot : > >> Hi Gustavo, >> >> I am coming a bit late in this series' review, so apologies if some of my >> comments have already have been discussed in an earlier revision. >&g

Re: [RFC v5 10/11] [media] vb2: add out-fence support to QBUF

2017-11-16 Thread Alexandre Courbot
On Thursday, November 16, 2017 2:10:56 AM JST, Gustavo Padovan wrote: From: Gustavo Padovan If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create an out_fence and send its fd to userspace on the fence_fd field as a return arg for the QBUF call. The fence is signaled on buffer_d

Re: [RFC v5 09/11] [media] vb2: add infrastructure to support out-fences

2017-11-16 Thread Alexandre Courbot
On Friday, November 17, 2017 4:19:00 PM JST, Alexandre Courbot wrote: On Thursday, November 16, 2017 2:10:55 AM JST, Gustavo Padovan wrote: From: Gustavo Padovan Add vb2_setup_out_fence() and the needed members to struct vb2_buffer. v3: - Do not hold yet another ref to the out_fence

Re: [RFC v5 09/11] [media] vb2: add infrastructure to support out-fences

2017-11-16 Thread Alexandre Courbot
On Thursday, November 16, 2017 2:10:55 AM JST, Gustavo Padovan wrote: From: Gustavo Padovan Add vb2_setup_out_fence() and the needed members to struct vb2_buffer. v3: - Do not hold yet another ref to the out_fence (Brian Starkey) v2: - change it to reflect fd_install at DQEVENT

Re: [RFC v5 08/11] [media] vb2: add videobuf2 dma-buf fence helpers

2017-11-16 Thread Alexandre Courbot
On Friday, November 17, 2017 4:02:56 PM JST, Alexandre Courbot wrote: On Thursday, November 16, 2017 2:10:54 AM JST, Gustavo Padovan wrote: From: Javier Martinez Canillas Add a videobuf2-fence.h header file that contains different helpers for DMA buffer sharing explicit fence support in

Re: [RFC v5 08/11] [media] vb2: add videobuf2 dma-buf fence helpers

2017-11-16 Thread Alexandre Courbot
On Thursday, November 16, 2017 2:10:54 AM JST, Gustavo Padovan wrote: From: Javier Martinez Canillas Add a videobuf2-fence.h header file that contains different helpers for DMA buffer sharing explicit fence support in videobuf2. v2: - use fence context provided by the caller in vb2_fence_a

Re: [RFC v5 07/11] [media] vb2: add in-fence support to QBUF

2017-11-16 Thread Alexandre Courbot
Hi Gustavo, I am coming a bit late in this series' review, so apologies if some of my comments have already have been discussed in an earlier revision. On Thursday, November 16, 2017 2:10:53 AM JST, Gustavo Padovan wrote: From: Gustavo Padovan Receive in-fence from userspace and add support f

Re: [RFC v5 03/11] [media] vb2: add 'ordered_in_driver' property to queues

2017-11-16 Thread Alexandre Courbot
On Thursday, November 16, 2017 2:10:49 AM JST, Gustavo Padovan wrote: From: Gustavo Padovan We use ordered_in_driver property to optimize for the case where the driver can deliver the buffers in an ordered fashion. When it is ordered we can use the same fence context for all fences, but when it

Re: [RFC PATCH 0/9] V4L2 Jobs API WIP

2017-10-23 Thread Alexandre Courbot
Hi Sakari, thanks for the feedback! On Thu, Oct 19, 2017 at 11:43 PM, Sakari Ailus wrote: > Hi Alexandre, > > On Thu, Sep 28, 2017 at 06:50:18PM +0900, Alexandre Courbot wrote: >> Hi everyone, >> >> Here is a new attempt at the "request" (which I prop

Re: [RFC PATCH 0/9] V4L2 Jobs API WIP

2017-10-23 Thread Alexandre Courbot
vice node!). V4L2 is still fairly new to me, so I am probably still confused, but aren't /dev/mediaX nodes created by the media subsystem currently? Cheers, Alex. > > Obviously, if we go into that direction, then that will have an obvious impact > on the jobs API, especially if we want t

Re: [RFC PATCH 2/9] [media] v4l2-core: add core jobs API support

2017-10-23 Thread Alexandre Courbot
Hi Hans, On Mon, Oct 16, 2017 at 7:01 PM, Hans Verkuil wrote: >> +static long v4l2_jobqueue_device_do_ioctl(struct file *filp, unsigned int >> cmd, >> + void *arg) >> +{ >> + switch (cmd) { >> + case VIDIOC_JOBQUEUE_INIT: >> +

[RFC PATCH 2/9] [media] v4l2-core: add core jobs API support

2017-09-28 Thread Alexandre Courbot
Add core support code for jobs API. This manages the life cycle of jobs and creation of a jobs queue, as well as the interface for job states. It also exposes the user-space jobs API. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/Makefile| 3 +- drivers/media/v4l2

[RFC PATCH 3/9] [media] videobuf2: add support for jobs API

2017-09-28 Thread Alexandre Courbot
: Alexandre Courbot --- drivers/media/v4l2-core/videobuf2-core.c | 33 include/media/videobuf2-core.h | 16 2 files changed, 45 insertions(+), 4 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core

[RFC PATCH 5/9] [media] v4l2-job: add generic jobs ops

2017-09-28 Thread Alexandre Courbot
supported at the moment. - No support for try_ctrl yet. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/Makefile | 3 +- drivers/media/v4l2-core/v4l2-job-generic.c | 394 + include/media/v4l2-job-generic.h | 47 3 files changed, 443

[RFC PATCH 7/9] [media] vim2m: add jobs API support

2017-09-28 Thread Alexandre Courbot
Add support for jobs in vim2m, using the generic state handler. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vim2m.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index 970b9b6dab25

[RFC PATCH 9/9] [media] document jobs API

2017-09-28 Thread Alexandre Courbot
Still a work-in-progress, but hopefully conveys the general idea. Signed-off-by: Alexandre Courbot --- Documentation/media/intro.rst | 2 + Documentation/media/media_uapi.rst | 1 + Documentation/media/uapi/jobs/jobs-api.rst | 23

[RFC PATCH 8/9] [media] vivid: add jobs API support for capture device

2017-09-28 Thread Alexandre Courbot
Add support for jobs in the vivid capture device, using the generic state handler. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vivid/vivid-core.c| 16 drivers/media/platform/vivid/vivid-core.h| 2 ++ drivers/media/platform/vivid/vivid-kthread

[RFC PATCH 4/9] [media] v4l2-ctrls: add support for jobs API

2017-09-28 Thread Alexandre Courbot
controls in jobs. Doing this properly will probably require more changes to the control framework, but the current form is enough to demonstrate the general ideas. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ctrls.c | 50 include/media/v4l2

[RFC PATCH 1/9] [media] v4l2-core: add v4l2_is_v4l2_file function

2017-09-28 Thread Alexandre Courbot
Add a function that checks whether a given open file is a v4l2 device instance. This will be useful for job queue creation as we are passed a set of FDs and we need to make this check. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-dev.c | 6 ++ include/media/v4l2-dev.h

[RFC PATCH 6/9] [media] m2m: add generic support for jobs API

2017-09-28 Thread Alexandre Courbot
Add a v4l2_mem_ctx_job_init() function that drivers using m2m can call at init time in order to set the state handler. Also make sure to call v4l2_jobqueue_job_finish() when the jobs API is used and all buffers for the current job have been processed. Signed-off-by: Alexandre Courbot

[RFC PATCH 0/9] V4L2 Jobs API WIP

2017-09-28 Thread Alexandre Courbot
or understood immediately. In particular I apologize for not reusing any of the previous attempts - I was just more comfortable laying down my ideas from scratch. If this proposal is not dismissed as complete garbage I will also be happy to discuss it in-person at the mini-summit in Prague. :) Ch

Re: [PATCH] [media] media-ioc-g-topology.rst: fix typos

2017-06-09 Thread Alexandre Courbot
On Fri, Jun 9, 2017 at 2:51 AM, Mauro Carvalho Chehab wrote: > Em Wed, 7 Jun 2017 18:33:02 +0900 > Alexandre Courbot escreveu: > >> Fix what seems to be a few typos induced by copy/paste. >> >> Signed-off-by: Alexandre Courbot >> --- >> Docume

[PATCH] [media] media-ioc-g-topology.rst: fix typos

2017-06-07 Thread Alexandre Courbot
Fix what seems to be a few typos induced by copy/paste. Signed-off-by: Alexandre Courbot --- Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst b

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-05-30 Thread Alexandre Courbot
On Tue, May 30, 2017 at 5:30 PM, Sylwester Nawrocki wrote: > Hi, > > On 05/29/2017 09:08 PM, Jacek Anaszewski wrote: >> >> This patch seems to have lost somehow. Could you help merging it? > > > It's not lost, it has been on my todo queue. I have applied it now. Awesome, thanks!

Re: [PATCH] Lower the log level of debug outputs

2017-05-30 Thread Alexandre Courbot
mething like "[media] vb2: core: Lower the log level of debug outputs" Otherwise, Acked-by: Alexandre Courbot > --- > drivers/media/v4l2-core/videobuf2-core.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/v4l2-core/videobuf

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-05-29 Thread Alexandre Courbot
Hi everyone, On Thu, Apr 27, 2017 at 4:35 AM, Jacek Anaszewski wrote: > On 04/26/2017 04:54 AM, Alexandre Courbot wrote: >> On Wed, Apr 26, 2017 at 4:15 AM, Jacek Anaszewski >> wrote: >>> Hi Alexandre, >>> >>> Thanks for the patch. >>>

Re: [PATCH] MAINTAINERS: remove self from GPIO maintainers

2017-05-23 Thread Alexandre Courbot
On Tue, May 23, 2017 at 5:14 PM, Linus Walleij wrote: > On Fri, May 12, 2017 at 7:01 PM, Alexandre Courbot wrote: > >> From: Alexandre Courbot >> >> I have not been able to dedicate time to the GPIO subsystem since quite >> some time, and I don't see the sit

Re: [PATCH] MAINTAINERS: remove self from GPIO maintainers

2017-05-15 Thread Alexandre Courbot
On Fri, May 12, 2017 at 12:00 PM, Andy Shevchenko wrote: > On Fri, May 12, 2017 at 8:01 PM, Alexandre Courbot wrote: >> From: Alexandre Courbot >> >> I have not been able to dedicate time to the GPIO subsystem since quite >> some time, and I don't see the situat

[PATCH] MAINTAINERS: remove self from GPIO maintainers

2017-05-12 Thread Alexandre Courbot
From: Alexandre Courbot I have not been able to dedicate time to the GPIO subsystem since quite some time, and I don't see the situation improving in the near future. Update the maintainers list to reflect this unfortunate fact. Signed-off-by: Alexandre Courbot --- Linus, I apologize fo

Re: [PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-25 Thread Alexandre Courbot
On Wed, Apr 26, 2017 at 4:15 AM, Jacek Anaszewski wrote: > Hi Alexandre, > > Thanks for the patch. > > On 04/25/2017 08:19 AM, Alexandre Courbot wrote: >> v4l2_m2m_job_finish(), which is called from the interrupt handler with >> slock acquired, can call the devic

[PATCH] [media] s5p-jpeg: fix recursive spinlock acquisition

2017-04-24 Thread Alexandre Courbot
v4l2_m2m_job_finish(). This is safe to do as the state of the hardware cannot change before v4l2_m2m_job_finish() is called anyway. Signed-off-by: Alexandre Courbot --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH v2] dt-bindings: Add documentation for GP10B GPU

2017-04-08 Thread Alexandre Courbot
On Fri, Mar 31, 2017 at 9:56 PM, Thierry Reding wrote: > On Thu, Mar 30, 2017 at 06:26:44PM +0900, Alexandre Courbot wrote: >> GP10B's definition is mostly similar to GK20A's and GM20B's. The only >> noticeable difference is the use of power domains instead of a

[PATCH v2] arm64: tegra: Add GPU node for Tegra 186

2017-03-30 Thread Alexandre Courbot
Add the DT node for the GP10B GPU on Tegra 186. Signed-off-by: Alexandre Courbot --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi index

[PATCH v2] dt-bindings: Add documentation for GP10B GPU

2017-03-30 Thread Alexandre Courbot
GP10B's definition is mostly similar to GK20A's and GM20B's. The only noticeable difference is the use of power domains instead of a regulator for power supply. Signed-off-by: Alexandre Courbot --- Changes since v1: - It's much better when it compiles. .../devicetree

[PATCH 2/2] arm64: tegra: Add GPU node for Tegra 186

2017-03-30 Thread Alexandre Courbot
Add the DT node for the GP10B GPU on Tegra 186. Signed-off-by: Alexandre Courbot --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi index

[PATCH 1/2] dt-bindings: Add documentation for GP10B GPU

2017-03-30 Thread Alexandre Courbot
GP10B's definition is mostly similar to GK20A's and GM20B's. The only noticeable difference is the use of power domains instead of a regulator for power supply. Signed-off-by: Alexandre Courbot --- .../devicetree/bindings/gpu/nvidia,gk20a.txt | 25 +-

[PATCH] MAINTAINERS: Remove self from Tegra maintainers

2017-03-05 Thread Alexandre Courbot
I have not been doing any Tegra maintainance work for a while, and this is unlikely to change in the foreseeable future. Better reflect the actual state of things by removing myself from the list. Signed-off-by: Alexandre Courbot --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git

Re: Issue with DRM and "reimplement IDR and IDA using the radix tree"

2016-12-16 Thread Alexandre Courbot
On 12/17/2016 01:16 AM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, Dec 14, 2016 at 11:08:20PM +0900, Alexandre Courbot wrote: >> Forgot to add the most relevant list for this issue (linux-next). >> >> Stephen, maybe you will want to temporarily r

Re: Issue with DRM and "reimplement IDR and IDA using the radix tree"

2016-12-14 Thread Alexandre Courbot
Forgot to add the most relevant list for this issue (linux-next). Stephen, maybe you will want to temporarily revert this patch until this is cleared? This probably affects other users than DRM. On 12/13/2016 04:14 PM, Alexandre Courbot wrote: > Hi Matthew, > > Trying the latest -ne

Issue with DRM and "reimplement IDR and IDA using the radix tree"

2016-12-12 Thread Alexandre Courbot
Hi Matthew, Trying the latest -next on the Jetson TK1 board (with two different DRM devices and display and render), I noticed that the GPU device probe always failed with error -ENOSPC. After investigating I figured out that this was due to the minor device allocation failing when a second DRM de

Re: [PATCH] drm/tegra: add tiling FB modifiers

2016-11-08 Thread Alexandre Courbot
On 11/08/2016 06:07 PM, Erik Faye-Lund wrote: > On Tue, Nov 8, 2016 at 8:50 AM, Alexandre Courbot wrote: >> Add FB modifiers to allow user-space to specify that a surface is in one >> of the two tiling formats supported by Tegra chips, and add support in >> the tegradrm

[PATCH] drm/tegra: add tiling FB modifiers

2016-11-07 Thread Alexandre Courbot
is intended to replace the dedicated IOCTL enabled by TEGRA_STAGING and to provide a non-staging alternative to that solution. Signed-off-by: Alexandre Courbot --- drivers/gpu/drm/tegra/drm.c | 2 ++ drivers/gpu/drm/tegra/fb.c| 23 +++--- include/uapi/drm/drm_fourcc.h | 45

Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply

2016-11-07 Thread Alexandre Courbot
vdd_gpu: sd6 { >>>> regulator-name = "+VDD_GPU_AP"; >>>> regulator-min-microvolt = <65>; >>>> regulator-max-microvolt = >>>> <120>; >>>> >>> >>> Looks good to me. I see the following error when booting but looking at the >>> code appears to be benign. Thierry, Alex, is this normal/okay? >> >> I have the same messages and asked Alexandre about them the other day. He >> told >> me that it looks normal. > > Ok great. Hopefully, Alex can ACK then. Apologies for the (very) delayed reply. Yes, the messages you are seeing are part of the normal probe sequence on Tegra. So this looks good to me. Acked-by: Alexandre Courbot

Re: [PATCH] drm/nouveau/tegra: Fix error handling

2016-11-01 Thread Alexandre Courbot
On Mon, Oct 31, 2016 at 3:35 PM, Christophe JAILLET wrote: > 'iommu_domain_alloc()' returns NULL in case of error, not an error pointer. > So test it accordingly. > > Signed-off-by: Christophe JAILLET Reviewed-by: Alexandre Courbot Indeed. Thanks for the fix!

Re: [Nouveau] Nouveau regression since kernel 4.3: loading NVIDIA's firwmare files

2016-10-30 Thread Alexandre Courbot
On Mon, Oct 31, 2016 at 1:34 AM, Ilia Mirkin wrote: > Hi Alex, > > As you're well-aware, your commit > 8539b37acef73949861a16808b60cb8b5b9b3bab (drm/nouveau/gr: use > NVIDIA-provided external firmwares) broke tons of existing setups for > people who were using extracted firmware files (stored in t

Re: [PATCH v5 0/3] drm/nouveau: set DMA mask before mapping scratch page

2016-10-17 Thread Alexandre Courbot
On Mon, Oct 17, 2016 at 5:12 AM, Ard Biesheuvel wrote: > On 7 October 2016 at 09:12, Alexandre Courbot wrote: >> On Fri, Oct 7, 2016 at 12:49 AM, Ard Biesheuvel >> wrote: >>> This v4 is now a 3 piece series (since v4), after Alexandre pointed out that >>> bot

Re: [PATCH v5 0/3] drm/nouveau: set DMA mask before mapping scratch page

2016-10-07 Thread Alexandre Courbot
E references, which is not > defined on all architectures > v2: replace incorrect comparison of dma_addr_t type var against NULL > > Ard Biesheuvel (3): > drm/nouveau: set streaming DMA mask early > drm/nouveau/fb/gf100: defer DMA mapping of scratch page to oneinit() > hook > drm/nouveau/fb/nv50: defer DMA mapping of scratch page to oneinit() > hook The series, Reviewed-by: Alexandre Courbot Thanks!

Re: [Nouveau] [PATCH v4 3/3] drm/nouveau/fb/nv50: defer DMA mapping of scratch page to init() hook

2016-10-02 Thread Alexandre Courbot
On Mon, Sep 26, 2016 at 9:32 PM, Ard Biesheuvel wrote: > The 100c08 scratch page is mapped using dma_map_page() before the TTM > layer has had a chance to set the DMA mask. This means we are still > running with the default of 32 when this code executes, and this causes > problems for platforms wi

Re: [Nouveau] [PATCH v4 2/3] drm/nouveau/fb/gf100: defer DMA mapping of scratch page to init() hook

2016-10-02 Thread Alexandre Courbot
On Mon, Sep 26, 2016 at 9:32 PM, Ard Biesheuvel wrote: > The 100c10 scratch page is mapped using dma_map_page() before the TTM > layer has had a chance to set the DMA mask. This means we are still > running with the default of 32 when this code executes, and this causes > problems for platforms wi

Re: [Nouveau] [PATCH v4 1/3] drm/nouveau: set streaming DMA mask early

2016-10-02 Thread Alexandre Courbot
On Mon, Sep 26, 2016 at 9:32 PM, Ard Biesheuvel wrote: > Some subdevices (i.e., fb/nv50.c and fb/gf100.c) map a scratch page using > dma_map_page() way before the TTM layer has had a chance to set the DMA > mask. This may prevent the driver from loading at all on platforms whose > system memory is

Re: [Nouveau] [PATCH] drm/nouveau/secboot/gm20b: Fix return value in case of error

2016-09-25 Thread Alexandre Courbot
On Sat, Sep 24, 2016 at 6:06 AM, Christophe JAILLET wrote: > If 'ioremap()' returns 0, 'gm20b_tegra_read_wpr()' will return 0 as well, > which means success. > Return -ENOMEM instead Reviewed-by: Alexandre Courbot > > Signed-off-by: Christophe JAILLET > -

Re: [PATCH linux-firmware 06/12] WHENCE: Remove references to two nvidia firmware files that were never added

2016-09-17 Thread Alexandre Courbot
On 09/18/2016 11:02 AM, Ben Hutchings wrote: > * PGP Signed by an unknown key > > Signed-off-by: Ben Hutchings Stupid copy-paste. Thanks for catching this! Reviewed-by: Alexandre Courbot > --- > WHENCE | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a

[PATCH] drm/ttm: remove cpu_address member from ttm_tt

2016-09-16 Thread Alexandre Courbot
Patch 3d50d4dcb0 exposed the CPU address of DMA-allocated pages as returned by dma_alloc_coherent because Nouveau on Tegra needed it. This is not required anymore - as there were no other users for it, remove it and save some memory for everyone. Signed-off-by: Alexandre Courbot --- drivers

Re: [PATCH] arm64: tegra: Add missing Smaug revision

2016-09-16 Thread Alexandre Courbot
Not seeing this patch in -next, can someone pick it? On Fri, Jul 1, 2016 at 1:15 AM, Andrew Bresticker wrote: > On Wed, Jun 29, 2016 at 1:52 AM, Alexandre Courbot > wrote: >> The "google,smaug-rev2" string is missing from the compatible list of >> Smaug's DT

Re: [PATCH] drm/nouveau/tegra: Modify error handling

2016-08-23 Thread Alexandre Courbot
tement S; > @@ > > *e = iommu_domain_alloc(...); > if (IS_ERR(e)) S > > Signed-off-by: Amitoj Kaur Chawla Reviewed-by: Alexandre Courbot

Re: [Nouveau] [PATCH v3] drm/nouveau/fb/nv50: set DMA mask before mapping scratch page

2016-07-15 Thread Alexandre Courbot
On Sat, Jul 16, 2016 at 4:45 AM, Ard Biesheuvel wrote: > On 15 July 2016 at 07:52, Alexandre Courbot wrote: >> On Fri, Jul 8, 2016 at 1:59 AM, Ard Biesheuvel >> wrote: >>> The 100c08 scratch page is mapped using dma_map_page() before the TTM >>> layer has had a

Re: [Nouveau] [PATCH v3] drm/nouveau/fb/nv50: set DMA mask before mapping scratch page

2016-07-14 Thread Alexandre Courbot
On Fri, Jul 8, 2016 at 1:59 AM, Ard Biesheuvel wrote: > The 100c08 scratch page is mapped using dma_map_page() before the TTM > layer has had a chance to set the DMA mask. This means we are still > running with the default of 32 when this code executes, and this causes > problems for platforms wit

Re: [PATCH V2 04/10] firmware: tegra: add IVC library

2016-07-07 Thread Alexandre Courbot
On Tue, Jul 5, 2016 at 6:04 PM, Joseph Lo wrote: > The Inter-VM communication (IVC) is a communication protocol, which is > designed for interprocessor communication (IPC) or the communication > between the hypervisor and the virtual machine with a guest OS on it. So > it can be translated as inte

Re: [PATCH V2 05/10] firmware: tegra: add BPMP support

2016-07-07 Thread Alexandre Courbot
On Thu, Jul 7, 2016 at 5:17 PM, Joseph Lo wrote: > On 07/06/2016 07:39 PM, Alexandre Courbot wrote: >> >> Sorry, I will probably need to do several passes on this one to >> understand everything, but here is what I can say after a first look: >> >> On Tue, Jul 5,

Re: [Nouveau] [PATCH v2 0/7] lib: string: add functions to case-convert strings

2016-07-06 Thread Alexandre Courbot
On Wed, Jul 6, 2016 at 7:56 AM, Joe Perches wrote: > On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote: >> On 5 July 2016 at 15:14, Joe Perches wrote: >> > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: >> > > This series introduces a family of generic string case conversion >> > > fu

Re: [PATCH V2 05/10] firmware: tegra: add BPMP support

2016-07-06 Thread Alexandre Courbot
On Thu, Jul 7, 2016 at 1:47 AM, Matt Longnecker wrote: > Alex, > > > On 07/06/2016 04:39 AM, Alexandre Courbot wrote: >>> >>> diff --git a/include/soc/tegra/bpmp_abi.h b/include/soc/tegra/bpmp_abi.h >>> >new file mode 100644 >>> >index 00

Re: [patch] drm/tegra: sor: Double free on error

2016-07-06 Thread Alexandre Courbot
On Mon, Jul 4, 2016 at 4:45 PM, Dan Carpenter wrote: > "brick" is allocated with devm_kzalloc() so freeing it with kfree() > leads to a double free. We can just delete it. That makes perfect sense. Reviewed-by: Alexandre Courbot

Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware Synchronization Primitives) driver

2016-07-06 Thread Alexandre Courbot
On Wed, Jul 6, 2016 at 6:06 PM, Joseph Lo wrote: > On 07/06/2016 03:05 PM, Alexandre Courbot wrote: >> >> On Tue, Jul 5, 2016 at 6:04 PM, Joseph Lo wrote: >>> >>> The Tegra HSP mailbox driver implements the signaling doorbell-based >>> interprocessor

Re: [PATCH V2 05/10] firmware: tegra: add BPMP support

2016-07-06 Thread Alexandre Courbot
Sorry, I will probably need to do several passes on this one to understand everything, but here is what I can say after a first look: On Tue, Jul 5, 2016 at 6:04 PM, Joseph Lo wrote: > The Tegra BPMP (Boot and Power Management Processor) is designed for the > booting process handling, offloading

Re: [PATCH V2 03/10] Documentation: dt-bindings: firmware: tegra: add bindings of the BPMP

2016-07-06 Thread Alexandre Courbot
On Tue, Jul 5, 2016 at 6:04 PM, Joseph Lo wrote: > The BPMP is a specific processor in Tegra chip, which is designed for > booting process handling and offloading the power management, clock > management, and reset control tasks from the CPU. The binding document > defines the resources that would

Re: [PATCH V2 02/10] mailbox: tegra-hsp: Add HSP(Hardware Synchronization Primitives) driver

2016-07-06 Thread Alexandre Courbot
On Tue, Jul 5, 2016 at 6:04 PM, Joseph Lo wrote: > The Tegra HSP mailbox driver implements the signaling doorbell-based > interprocessor communication (IPC) for remote processors currently. The > HSP HW modules support some different features for that, which are > shared mailboxes, shared semaphor

Re: [PATCH] gpio: of: Allow overriding the device node

2016-07-05 Thread Alexandre Courbot
the GPIO device's ->of_node field that > is set using the procedure described above. Acked-by: Alexandre Courbot

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-03 Thread Alexandre Courbot
On Mon, Jul 4, 2016 at 10:37 AM, Alexandre Courbot wrote: > On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer > wrote: >> On 1 July 2016 at 18:18, Alexandre Courbot wrote: >>> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer wrote: >>>> Call strtolower() rather than

Re: [PATCH] drm/tegra: fix error handling

2016-07-03 Thread Alexandre Courbot
On Sun, Jul 3, 2016 at 3:18 PM, Christophe JAILLET wrote: > This is likely that checking 'gr3d->clk_secondary' instead of 'gr3d->clk' > is expected here. Very likely indeed. Reviewed-by: Alexandre Courbot Thanks!

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-03 Thread Alexandre Courbot
On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer wrote: > On 1 July 2016 at 18:18, Alexandre Courbot wrote: >> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer wrote: >>> Call strtolower() rather than walking the string explicitly to convert >>> it to lowercase. >>

Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function

2016-07-01 Thread Alexandre Courbot
On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer wrote: > Call strtolower() rather than walking the string explicitly to convert > it to lowercase. > > Signed-off-by: Markus Mayer > --- > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > d

Re: [RESEND PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-06-30 Thread Alexandre Courbot
On Thu, Jun 30, 2016 at 2:21 AM, Rhyland Klein wrote: > Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and > the BA27XXX battery driver. These are all used on the Tegra210 Smaug > platform. Tested-by: Alexandre Courbot Can see the bq27742 in /sys and query its state.

Re: [PATCH 5/5] pwm: tegra: Add support for Tegra186

2016-06-30 Thread Alexandre Courbot
On Wed, Jun 22, 2016 at 8:47 PM, Laxman Dewangan wrote: > Tegra186 has PWM controller with only one output instead of > 4 output in earlier generation SoCs. > > Add support for Tegra186 and find the number of PWM output > based on driver data. Reviewed-by: Alexandre Courbot

[PATCH] arm64: tegra: Enable all cores on Jetson TX1

2016-06-30 Thread Alexandre Courbot
Enable PSCI firmware and all 4 cores of T210 on Jetson TX1. Signed-off-by: Alexandre Courbot --- Not sure why this was not done - in any case this seems to work fine and performance is obviously improved (especially boot time). arch/arm64/boot/dts/nvidia/tegra210-p2371-2180.dts | 23

Re: [PATCH v3] arm: tegra124: remove commas from unit addresses

2016-06-29 Thread Alexandre Courbot
former mainline U-Boot version was looking for that particular notation in order to perform required fix-ups on it. Tested-by: Alexandre Courbot Confirmed that GPU still probes and is usable after this.

Re: [PATCH] arm64: tegra: Add missing Smaug revision

2016-06-29 Thread Alexandre Courbot
On Wed, Jun 29, 2016 at 6:02 PM, Jon Hunter wrote: > > On 29/06/16 09:52, Alexandre Courbot wrote: >> The "google,smaug-rev2" string is missing from the compatible list of >> Smaug's DT. The differences of rev2 are not relevant at our current >> level of su

[PATCH] arm64: tegra: Add missing Smaug revision

2016-06-29 Thread Alexandre Courbot
The "google,smaug-rev2" string is missing from the compatible list of Smaug's DT. The differences of rev2 are not relevant at our current level of support and it boots just fine, so add it. Signed-off-by: Alexandre Courbot --- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts

<    1   2   3   4   5   6   7   8   9   10   >