Re: [PATCH 1/3 RFC v2] selftests: introduce testing abstractions

2013-04-26 Thread Alexandru Copot
On Thu, Apr 25, 2013 at 9:19 PM, Daniel Borkmann wrote: > Usually I associate sth named assert() that it does an ungraceful exit. > Maybe __test() or __check()? This looks like a good idea, will do. >> + va_list vl; >> + const char *m; >> + char msg[BUFSIZ]; >> + >> + if

Re: [PATCH 1/3 RFC v2] selftests: introduce testing abstractions

2013-04-26 Thread Alexandru Copot
On Thu, Apr 25, 2013 at 9:19 PM, Daniel Borkmann dbork...@redhat.com wrote: Usually I associate sth named assert() that it does an ungraceful exit. Maybe __test() or __check()? This looks like a good idea, will do. + va_list vl; + const char *m; + char msg[BUFSIZ]; + +

Re: [PATCH 0/3 RFC v2] selftests: Basic framework for tests

2013-04-25 Thread Alexandru Copot
On Thu, Apr 25, 2013 at 2:27 PM, Daniel Borkmann wrote: >> Signed-of-by Alexandru Copot > > > It's: Signed-off-by: Alexandru Copot > > You have this wrong in all your patches. I know, it was copy-pasted and I saw it just after sending. But for now it's fine, these a

[PATCH 2/3 RFC v2] selftests/net: update socket test to use new testing framework

2013-04-25 Thread Alexandru Copot
Signed-of-by Alexandru Copot Cc: Daniel Baluta --- tools/testing/selftests/net/Makefile | 14 +++-- tools/testing/selftests/net/socket.c | 108 +-- 2 files changed, 88 insertions(+), 34 deletions(-) diff --git a/tools/testing/selftests/net/Makefile b/tools

[PATCH 1/3 RFC v2] selftests: introduce testing abstractions

2013-04-25 Thread Alexandru Copot
Signed-of-by Alexandru Copot Cc: Daniel Baluta --- tools/testing/selftests/Makefile| 3 +- tools/testing/selftests/lib/Makefile| 14 +++ tools/testing/selftests/lib/selftests.c | 57 tools/testing/selftests/lib/selftests.h | 67

[PATCH 3/3 RFC v2] selftests/net: add socket options test with IPv6 testcases

2013-04-25 Thread Alexandru Copot
Only a part of the boolean socket options for IPv6 are tested. Signed-of-by Alexandru Copot Cc: Daniel Baluta --- tools/testing/selftests/net/Makefile | 3 +- tools/testing/selftests/net/run_netsocktests | 10 ++ tools/testing/selftests/net/sockopt.c| 185

[PATCH 0/3 RFC v2] selftests: Basic framework for tests

2013-04-25 Thread Alexandru Copot
the new framework and the third patch creates new tests for [set/get]sockopt with some IPV6_* options. Signed-of-by Alexandru Copot Cc: Daniel Baluta Changes since v1: - moved the implementation to selftests/lib - use goto instead of directly returning Alexandru Copot (3): selftests: introduce

[PATCH 0/3 RFC v2] selftests: Basic framework for tests

2013-04-25 Thread Alexandru Copot
the new framework and the third patch creates new tests for [set/get]sockopt with some IPV6_* options. Signed-of-by Alexandru Copot alex.miha...@gmail.com Cc: Daniel Baluta dbal...@ixiacom.com Changes since v1: - moved the implementation to selftests/lib - use goto instead of directly returning

[PATCH 1/3 RFC v2] selftests: introduce testing abstractions

2013-04-25 Thread Alexandru Copot
Signed-of-by Alexandru Copot alex.miha...@gmail.com Cc: Daniel Baluta dbal...@ixiacom.com --- tools/testing/selftests/Makefile| 3 +- tools/testing/selftests/lib/Makefile| 14 +++ tools/testing/selftests/lib/selftests.c | 57 tools/testing/selftests

[PATCH 3/3 RFC v2] selftests/net: add socket options test with IPv6 testcases

2013-04-25 Thread Alexandru Copot
Only a part of the boolean socket options for IPv6 are tested. Signed-of-by Alexandru Copot alex.miha...@gmail.com Cc: Daniel Baluta dbal...@ixiacom.com --- tools/testing/selftests/net/Makefile | 3 +- tools/testing/selftests/net/run_netsocktests | 10 ++ tools/testing/selftests/net

[PATCH 2/3 RFC v2] selftests/net: update socket test to use new testing framework

2013-04-25 Thread Alexandru Copot
Signed-of-by Alexandru Copot alex.miha...@gmail.com Cc: Daniel Baluta dbal...@ixiacom.com --- tools/testing/selftests/net/Makefile | 14 +++-- tools/testing/selftests/net/socket.c | 108 +-- 2 files changed, 88 insertions(+), 34 deletions(-) diff --git a/tools

Re: [PATCH 0/3 RFC v2] selftests: Basic framework for tests

2013-04-25 Thread Alexandru Copot
On Thu, Apr 25, 2013 at 2:27 PM, Daniel Borkmann dbork...@redhat.com wrote: Signed-of-by Alexandru Copot alex.miha...@gmail.com It's: Signed-off-by: Alexandru Copot alex.miha...@gmail.com You have this wrong in all your patches. I know, it was copy-pasted and I saw it just after sending

[PATCH net-next] audit: pass int* to nlmsg_next

2013-03-28 Thread Alexandru Copot
‘int’ Fix this by sending the intended pointer. Signed-off-by: Alexandru Copot --- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/audit.c b/kernel/audit.c index 4dbb047..488f85f 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -925,7 +925,7

[PATCH net-next] audit: pass int* to nlmsg_next

2013-03-28 Thread Alexandru Copot
‘int’ Fix this by sending the intended pointer. Signed-off-by: Alexandru Copot alex.miha...@gmail.com --- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/audit.c b/kernel/audit.c index 4dbb047..488f85f 100644 --- a/kernel/audit.c +++ b/kernel/audit.c

[PATCH] virtio: suppress kmemleak false positive

2013-01-18 Thread Alexandru Copot
tirq+0x18b/0x220 [] __do_softirq+0xe1/0x1c0 [] call_softirq+0x1c/0x30 Seems the function vring_add_indirect stores an array of struct vring_desc by using virt_to_phys and kmemleak doesn't track the pointer. The following patch can fix this. Signed-off-by: Alexandru Copot CC: Dan

[PATCH] virtio: suppress kmemleak false positive

2013-01-18 Thread Alexandru Copot
] call_softirq+0x1c/0x30 Seems the function vring_add_indirect stores an array of struct vring_desc by using virt_to_phys and kmemleak doesn't track the pointer. The following patch can fix this. Signed-off-by: Alexandru Copot alex.miha...@gmail.com CC: Daniel Baluta dbal...@ixiacom.com --- drivers

[PATCH] virtio: suppress kmemleak false positive

2013-01-11 Thread Alexandru Copot
tirq+0x18b/0x220 [] __do_softirq+0xe1/0x1c0 [] call_softirq+0x1c/0x30 Seems the function vring_add_indirect stores an array of struct vring_desc by using virt_to_phys and kmemleak doesn't track the pointer. The following patch can fix this. Signed-off-by: Alexandru Copot CC: Dan

[PATCH] virtio: suppress kmemleak false positive

2013-01-11 Thread Alexandru Copot
] call_softirq+0x1c/0x30 Seems the function vring_add_indirect stores an array of struct vring_desc by using virt_to_phys and kmemleak doesn't track the pointer. The following patch can fix this. Signed-off-by: Alexandru Copot alex.miha...@gmail.com CC: Daniel Baluta dbal...@ixiacom.com --- drivers