le will cleanup the corresponding umh.
Just like if the kernel module does kmalloc() it should kfree() it
in the exit code.
Signed-off-by: Alexei Starovoitov
---
fs/exec.c | 38 +++
include/linux/binfmts.h | 1 +
include/linux/umh.h | 12 +
kernel/umh.c
%rbp,%rdx
e8: add$0xff28,%rdx
ef: mov0x0(%r13),%r14
f3: movq $0x0,-0x48(%rbp)
fb: mov%rdx,0x0(%r14)
ff: mov0x0(%rbx),%rdi
103: movzbq 0x0(%rdi),%rsi
Signed-off-by: Alexei Starovoitov
---
include/linux/bpf_verifier.h | 1 +
kernel/bpf/ve
On Mon, May 21, 2018 at 02:29:30PM +0200, Eugene Syromiatnikov wrote:
> Hello.
>
> This patch set adds ability to set default values for
> kernel.unprivileged_bpf_disable, net.core.bpf_jit_harden,
> net.core.bpf_jit_kallsyms sysctl knobs as well as option to override
> them via a boot-time kernel
On Sun, May 13, 2018 at 07:33:18PM +0200, Alban Crequy wrote:
>
> +BPF_CALL_2(bpf_get_current_cgroup_ino, u32, hierarchy, u64, flags)
> +{
> + // TODO: pick the correct hierarchy instead of the mem controller
> + struct cgroup *cgrp = task_cgroup(current, memory_cgrp_id);
> +
> + if (
Commit-ID: b1ae32dbab50ed19cfc16d225b0fb0114fb13025
Gitweb: https://git.kernel.org/tip/b1ae32dbab50ed19cfc16d225b0fb0114fb13025
Author: Alexei Starovoitov
AuthorDate: Sun, 13 May 2018 12:32:22 -0700
Committer: Thomas Gleixner
CommitDate: Sun, 13 May 2018 21:49:14 +0200
x86/cpufeature
On Sat, May 12, 2018 at 10:30:02PM +0200, Thomas Gleixner wrote:
> On Sat, 12 May 2018, Alexei Starovoitov wrote:
> > On Thu, May 10, 2018 at 10:58 AM, Alexei Starovoitov
> > wrote:
> > > I see no option, but to fix the kernel.
> > > Regardless whether it'
On Thu, May 10, 2018 at 10:58 AM, Alexei Starovoitov
wrote:
> I see no option, but to fix the kernel.
> Regardless whether it's called user space breakage or kernel breakage.
Peter,
could you please ack the patch or better yet take it into tip tree
and send to Linus asap ?
rc5 is
On Mon, May 07, 2018 at 04:30:02PM -0700, Luis R. Rodriguez wrote:
> This makes it clearer this code is part of the coredump code, and
> is not an exported generic helper from kernel/umh.c.
>
> Signed-off-by: Luis R. Rodriguez
> ---
> fs/coredump.c | 9 +
> 1 file changed, 5 insertions(+
, please. And likely linux-security-module@ and Jessica too.
>
> > On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote:
> >> Introduce helper:
> >> int fork_usermode_blob(void *data, size_t len, struct umh_info *info);
> >> struct umh_info {
On Thu, May 10, 2018 at 06:20:28PM +0200, Borislav Petkov wrote:
> On Thu, May 10, 2018 at 08:52:42AM -0700, Alexei Starovoitov wrote:
> > That makes me wonder what happened with "we do not break user space" rule?
>
> As someone already pointed out on IRC, arch/x86/incl
On Thu, May 10, 2018 at 12:06:34PM +0200, Peter Zijlstra wrote:
> On Thu, May 03, 2018 at 08:31:19PM -0700, Yonghong Song wrote:
>
> > This approach is preferred since the already deployed bcc scripts, or
> > any other bpf applicaitons utilizing LLVM JIT compilation functionality,
> > will continu
On Mon, May 07, 2018 at 06:51:24PM +, Luis R. Rodriguez wrote:
> > Notice that _binary_net_bpfilter_bpfilter_umh_start - end
> > is placed into .init.rodata section, so it's freed as soon as __init
> > function of bpfilter.ko is finished.
> > As part of __init the bpfilter.ko does first request
On Mon, May 07, 2018 at 06:39:31PM +, Luis R. Rodriguez wrote:
>
> > Are you saying make 'static struct vfsmount *shm_mnt;'
> > global and use it here? so no init_tmpfs() necessary?
> > I think that can work, but feels that having two
> > tmpfs mounts (one for shmem and one for umh) is cleaner
On Sat, May 05, 2018 at 12:48:24AM -0400, Jann Horn wrote:
> On Thu, May 3, 2018 at 12:36 AM, Alexei Starovoitov wrote:
> > Introduce helper:
> > int fork_usermode_blob(void *data, size_t len, struct umh_info *info);
> > struct umh_info {
> >struct file *pip
On Fri, May 04, 2018 at 07:56:43PM +, Luis R. Rodriguez wrote:
> What a mighty short list of reviewers. Adding some more. My review below.
> I'd appreciate a Cc on future versions of these patches.
sure.
> On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote:
On Thu, May 03, 2018 at 03:23:55PM +0100, Edward Cree wrote:
> On 03/05/18 05:36, Alexei Starovoitov wrote:
> > bpfilter.ko consists of bpfilter_kern.c (normal kernel module code)
> > and user mode helper code that is embedded into bpfilter.ko
> >
> > The steps t
From: "David S. Miller"
parse iptable binary blobs into bpfilter internal data structures
bpfilter.ko only passing the [gs]etsockopt commands from kernel to umh
All parsing is done inside umh
Signed-off-by: David S. Miller
Signed-off-by: Alexei Starovoitov
---
include/uapi/linux/
that rmmod of the kernel module will cleanup the corresponding umh.
Just like if the kernel module does kmalloc() it should kfree() it in the exit
code.
Signed-off-by: Alexei Starovoitov
---
fs/exec.c | 38 ---
include/linux/binfmts.h | 1 +
include/linux/umh.h
From: Daniel Borkmann
Signed-off-by: Daniel Borkmann
---
net/bpfilter/Makefile | 2 +-
net/bpfilter/bpfilter_mod.h | 285 ++-
net/bpfilter/ctor.c | 57 +
net/bpfilter/gen.c | 290 ++
tails in patches 1 and 2 that are ready to land.
Patches 3 and 4 are still rough. They were mainly used for
testing and to demonstrate how bpfilter is building on top.
The patch 4 approach of converting one iptable rule to few bpf
instructions will certainly change in the future, since it doesn'
sure that umh is healthy. If not it will kill it via pid.
Later bpfilter_process_sockopt() will be called from bpfilter hooks
in get/setsockopt() to pass iptable commands into umh via bpfilter.ko
If admin does 'rmmod bpfilter' the __exit code bpfilter.ko will
kill umh as well.
Signed
On Sat, Apr 21, 2018 at 12:37:01PM -0700, Eric Biggers wrote:
> [+bpf maintainers and netdev]
>
> On Mon, Nov 06, 2017 at 03:56:01AM -0800, syzbot wrote:
> > Hello,
> >
> > syzkaller hit the following crash on
> > 5cb0512c02ecd7e6214e912e4c150f4219ac78e0
> > git://git.kernel.org/pub/scm/linux/ker
On Thu, Apr 26, 2018 at 05:57:49PM +0800, Wang YanQing wrote:
> All the testcases for BPF_PROG_TYPE_PERF_EVENT program type in
> test_verifier(kselftest) report below errors on x86_32:
> "
> 172/p unpriv: spill/fill of different pointers ldx FAIL
> Unexpected error message!
> 0: (bf) r6 = r10
> 1:
On 4/27/18 5:13 AM, Daniel Borkmann wrote:
Hi Ingo,
On 04/27/2018 01:00 PM, tip-bot for Ingo Molnar wrote:
Commit-ID: 5f26c50143f58f256535bee8d93a105f36d4d2da
Gitweb: https://git.kernel.org/tip/5f26c50143f58f256535bee8d93a105f36d4d2da
Author: Ingo Molnar
AuthorDate: Fri, 27 Apr 2018 1
On Wed, Apr 25, 2018 at 12:17:13PM +0200, Jiri Olsa wrote:
> On Mon, Apr 23, 2018 at 02:11:36PM -0600, Alexei Starovoitov wrote:
> > On Mon, Apr 23, 2018 at 08:59:24AM +0200, Jiri Olsa wrote:
> > > hi,
> > > sending the change to store and dump the license
> > >
On Wed, Apr 25, 2018 at 05:25:47PM +0800, Leo Yan wrote:
>
> If we have concern for security issue, should we remove support for
> 'bpf_jit_enable = 2' and modify the doc to reflect this change?
I suggest to fix the doc.
On Mon, Apr 23, 2018 at 08:59:24AM +0200, Jiri Olsa wrote:
> hi,
> sending the change to store and dump the license
> info for loaded BPF programs. It's important for
> us get the license info, when investigating on
> screwed up machine.
hmm. boolean flag whether bpf prog is gpl or not
is already
On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote:
> On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote:
> > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote:
> > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the
> &g
On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote:
> The code defines macro 'PAGE_OFFSET' and uses it to decide if the
> address is in kernel space or not. But different architecture has
> different 'PAGE_OFFSET' so this program cannot be used for all
> platforms.
>
> This commit changes to
On Mon, Apr 16, 2018 at 08:43:31AM -0700, Eric Dumazet wrote:
>
>
> On 04/16/2018 08:33 AM, Yafang Shao wrote:
> > tcp_rcv_space_adjust is called every time data is copied to user space,
> > introducing a tcp tracepoint for which could show us when the packet is
> > copied to user.
> > This could
On 4/13/18 11:19 AM, Peter Zijlstra wrote:
On Tue, Apr 10, 2018 at 02:28:04PM -0700, Alexei Starovoitov wrote:
Instead of
#ifdef CC_HAVE_ASM_GOTO
we can replace it with
#ifndef __BPF__
or some other name,
I would prefer the BPF specific hack; otherwise we might be encouraging
people to build
On Fri, Apr 13, 2018 at 03:22:37PM +0200, Jesper Dangaard Brouer wrote:
> Hi Peter,
>
> Your commit d0266046ad54 ("x86: Remove FAST_FEATURE_TESTS") broke build
> for several samples/bpf programs. I'm unsure what the best way forward
> is to unbreak these...
>
> The issue is that these samples are
On 4/10/18 2:07 PM, Peter Zijlstra wrote:
On Tue, Apr 10, 2018 at 01:42:59PM -0700, Yonghong Song wrote:
Commit d0266046ad54 ("x86: Remove FAST_FEATURE_TESTS")
removed X86_FAST_FEATURE_TESTS and make macro static_cpu_has() always
use __always_inline function _static_cpu_has() funciton.
The stati
On 4/9/18 9:45 PM, Ravi Bangoria wrote:
Hi Song,
On 12/07/2017 04:15 AM, Song Liu wrote:
With current kernel, user space tools can only create/destroy [k,u]probes
with a text-based API (kprobe_events and uprobe_events in tracefs). This
approach relies on user space to clean up the [k,u]probe af
On 27/02/2018 17:39, Andy Lutomirski wrote:
> >>>> On Tue, Feb 27, 2018 at 5:32 AM, Alexei Starovoitov
> >>>> wrote:
> >>>>> On Tue, Feb 27, 2018 at 05:20:55AM +, Andy Lutomirski wrote:
> >>>>>> On Tue, Feb 27, 201
On Sun, Apr 08, 2018 at 04:07:42PM +0800, joeyli wrote:
>
> > If the only thing that folks are paranoid about is reading
> > arbitrary kernel memory with bpf_probe_read() helper
> > then preferred patch would be to disable it during verification
> > when in lockdown mode
>
> Sorry for I didn't fu
On Thu, Apr 05, 2018 at 05:16:36PM +0200, Jiri Olsa wrote:
> hi,
> eBPF programs loaded for kprobes are allowed to read kernel
> internal structures. We check the provided kernel version
> to ensure that the program is loaded for the proper kernel.
>
> The problem is that the version check is not
On Tue, Apr 3, 2018 at 9:26 AM, Andy Lutomirski wrote:
> On Tue, Apr 3, 2018 at 8:41 AM, Alexei Starovoitov
> wrote:
>> On Tue, Apr 03, 2018 at 08:11:07AM -0700, Andy Lutomirski wrote:
>>> >
>>> >> "bpf: Restrict kernel image access functions when the
On Tue, Apr 03, 2018 at 08:11:07AM -0700, Andy Lutomirski wrote:
> >
> >> "bpf: Restrict kernel image access functions when the kernel is locked
> >> down":
> >> This patch just sucks in general.
> >
> > Yes - but that's what Alexei Star
On Tue, Mar 27, 2018 at 10:20:10AM +0800, Du, Changbin wrote:
> On Mon, Mar 26, 2018 at 07:55:13AM -0700, Alexei Starovoitov wrote:
> > On Mon, Mar 26, 2018 at 05:23:28PM +0800, changbin...@intel.com wrote:
> > > Signed-off-by: Changbin Du
> > > ---
> > > tool
; WARN_ON_ONCE() to stay on the safe side.
>
> Signed-off-by: Mathieu Desnoyers
> CC: Steven Rostedt
> CC: Alexei Starovoitov
> CC: Peter Zijlstra
> CC: Ingo Molnar
Mathieu, that's not enough.
Commit log is also wrong.
It needs to state that something like this is need
On Mon, Mar 26, 2018 at 05:23:28PM +0800, changbin...@intel.com wrote:
> From: Changbin Du
>
> This patch fixed below errors of missing head files.
>
> tools/testing/selftests$ make
> ...
> clang -I. -I./include/uapi -I../../../include/uapi
> -Wno-compare-distinct-pointer-types \
>-O2 -
On 3/22/18 3:15 PM, Andy Lutomirski wrote:
On Thu, Mar 22, 2018 at 8:54 PM, Luis R. Rodriguez wrote:
If we can ensure that these usermode modules don't take *any time at all* on
their init *from the start*, it would be wonderful and we'd end up avoiding
some really odd corner case issues later.
On Thu, Mar 22, 2018 at 10:33:43AM +0100, Ingo Molnar wrote:
>
> - I think the BPF JIT, whose byte code machine languge is used by an
>increasing number of kernel subsystems, could benefit from having vector
> ops.
>It would possibly allow the handling of floating point types.
this is o
On Wed, Mar 21, 2018 at 01:38:45AM +0100, Daniel Borkmann wrote:
> On 03/21/2018 01:36 AM, Linus Torvalds wrote:
> > On Tue, Mar 20, 2018 at 5:18 PM, Daniel Borkmann
> > wrote:
> >> Prasad reported that he has seen crashes in BPF subsystem with netd
> >> on Android with arm64 in the form of (note
On Mon, Mar 12, 2018 at 10:43:11AM +0100, Jiri Olsa wrote:
> diff --git a/tools/perf/util/bpf-userapi.h b/tools/perf/util/bpf-userapi.h
> new file mode 100644
> index ..63f2b4c13a5c
> --- /dev/null
> +++ b/tools/perf/util/bpf-userapi.h
> @@ -0,0 +1,11 @@
> +#ifndef __BPF_USERAPI_H
> +#d
On 3/12/18 5:02 AM, Edward Cree wrote:
On 09/03/18 18:58, Alexei Starovoitov wrote:
It's not waiting for the whole thing, because once bpfilter starts it
stays running/sleeping because it's stateful.
So, this has been bugging me a bit.
If bpfilter takes a signal and crashes, all
On 3/10/18 7:34 AM, Luis R. Rodriguez wrote:
Also,
Alexei you never answered my questions out aliases with the umh modules.
Long term this important to consider.
aliases always felt like a crutch to me.
I can see an argument when they're used as 'alias pci:* foo'
but the way it's used in netwo
On 3/9/18 11:38 AM, Linus Torvalds wrote:
On Fri, Mar 9, 2018 at 11:12 AM, Linus Torvalds
wrote:
How are you going to handle five processes doing the same setup concurrently?
Side note: it's not just serialization. It's also "is it actually up
and running".
The rule for "request_module()" (
On 3/9/18 11:37 AM, Andy Lutomirski wrote:
On Fri, Mar 9, 2018 at 6:55 PM, David Miller wrote:
From: Alexei Starovoitov
Date: Fri, 9 Mar 2018 10:50:49 -0800
On 3/9/18 10:23 AM, Andy Lutomirski wrote:
It might not be totally crazy to back it by tmpfs.
interesting. how do you propose to do
On 3/9/18 10:50 AM, Linus Torvalds wrote:
On Fri, Mar 9, 2018 at 10:43 AM, Kees Cook wrote:
Module loading (via kernel_read_file()) already uses
deny_write_access(), and so does do_open_execat(). As long as module
loading doesn't call allow_write_access() before the execve() has
started in the
On 3/9/18 10:23 AM, Andy Lutomirski wrote:
On Mar 9, 2018, at 10:15 AM, Greg KH wrote:
Oh, and for the record, I like Andy's proposal as well as dumping this
into a kernel module "blob" with the exception that this now would take
up unswapable memory, which isn't the nicest and is one bi
On 3/9/18 8:24 AM, Andy Lutomirski wrote:
On Fri, Mar 9, 2018 at 3:39 PM, Alexei Starovoitov wrote:
On 3/9/18 7:16 AM, Andy Lutomirski wrote:
On Mar 8, 2018, at 9:08 PM, Alexei Starovoitov wrote:
On 3/8/18 7:54 PM, Andy Lutomirski wrote:
On Mar 8, 2018, at 7:06 PM, Linus Torvalds
On 3/9/18 7:16 AM, Andy Lutomirski wrote:
On Mar 8, 2018, at 9:08 PM, Alexei Starovoitov wrote:
On 3/8/18 7:54 PM, Andy Lutomirski wrote:
On Mar 8, 2018, at 7:06 PM, Linus Torvalds
wrote:
Honestly, that "read twice" thing may be what scuttles this.
Initially, I thought it
On 3/8/18 7:54 PM, Andy Lutomirski wrote:
On Mar 8, 2018, at 7:06 PM, Linus Torvalds
wrote:
Honestly, that "read twice" thing may be what scuttles this.
Initially, I thought it was a non-issue, because anybody who controls
the module subdirectory enough to rewrite files would be in a posi
On Fri, Mar 09, 2018 at 02:12:24AM +, Andy Lutomirski wrote:
> On Fri, Mar 9, 2018 at 1:20 AM, Alexei Starovoitov
> wrote:
> > On Fri, Mar 09, 2018 at 12:59:36AM +, Andy Lutomirski wrote:
> >>
> >> Alexei, can you give an example use case? I'm sure it
On Fri, Mar 09, 2018 at 01:04:39AM +, Andy Lutomirski wrote:
> On Fri, Mar 9, 2018 at 12:57 AM, Alexei Starovoitov wrote:
> > On 3/8/18 4:24 PM, Kees Cook wrote:
> >>
> >> As Andy asked earlier, why not DYN too to catch PIE executables? Seems
> >> like fo
On Fri, Mar 09, 2018 at 12:59:36AM +, Andy Lutomirski wrote:
>
> Alexei, can you give an example use case? I'm sure it's upthread
> somewhere, but I'm having trouble finding it.
at the time of iptable's setsockopt() the kernel will do
err = request_module("bpfilter");
once.
The rough POC cod
On 3/8/18 4:24 PM, Kees Cook wrote:
How is this not marked [RFC]? :)
On Mon, Mar 5, 2018 at 5:34 PM, Alexei Starovoitov wrote:
As the first step in development of bpfilter project [1] the request_module()
code is extended to allow user mode helpers to be invoked. Idea is that
user mode
On 3/7/18 5:23 PM, Luis R. Rodriguez wrote:
request_module() has its own world though too. How often in your proof of
concept is request_module() called? How many times do you envision it being
called?
once.
+static int run_umh(struct file *file)
+{
+ struct subprocess_info *sub_info =
combining multiple answers...
On 3/6/18 3:05 AM, Greg KH wrote:
Any chance you can add a field to your "umh module" type such that a
normal 'modinfo' program will be able to notice it is different easily?
ok. handling of modinfo turned out to be straightforward.
kmod tooling worked fine with
On 3/5/18 6:13 PM, Randy Dunlap wrote:
Hi,
On 03/05/2018 05:34 PM, Alexei Starovoitov wrote:
diff --git a/kernel/module.c b/kernel/module.c
index ad2d420024f6..6cfa35795741 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3669,6 +3683,17 @@ static int load_module(struct load_info
dule infra doesn't do any accounting
of them. They don't appear in "lsmod" and cannot be "rmmod".
Multiple request_module("umh") will load multiple umh.ko processes.
Similar to kernel modules the kernel will be tainted if "umh module"
has invalid signa
On 3/5/18 3:56 PM, Daniel Borkmann wrote:
On 03/01/2018 05:19 AM, Alexei Starovoitov wrote:
Introduce BPF_PROG_TYPE_RAW_TRACEPOINT bpf program type to access
kernel internal arguments of the tracepoints in their raw form.
From bpf program point of view the access to the arguments look like
raw_tp_fd with their own
bpf program. The kernel will execute all tracepoint probes
and all attached bpf programs.
In the future bpf_raw_tracepoints can be extended with
query/introspection logic.
Signed-off-by: Alexei Starovoitov
---
include/linux/bpf_types.h| 1 +
include/linux/trace_events.h |
rnel.
Make it more useful with ability to stop for_each() loop depending
via callback return value.
In such form it's used in subsequent patch.
Signed-off-by: Alexei Starovoitov
---
include/linux/tracepoint-defs.h | 1 +
include/linux/tracepoint.h | 32 +++-
empty raw_tracepoint bpf program to test overhead
Signed-off-by: Alexei Starovoitov
---
samples/bpf/Makefile| 1 +
samples/bpf/bpf_load.c | 13 +
samples/bpf/test_overhead_raw_tp_kern.c | 17 +
samples/bpf/test_overhead_user.c
patch enforces that all tracepoints args are either integers
or pointers and fit into 64-bit.
Signed-off-by: Alexei Starovoitov
---
arch/x86/xen/mmu_pv.c| 16 +-
drivers/gpu/drm/i915/i915_trace.h| 13 +++--
drivers/infiniband/hw/hfi1/file_ops.c| 2
Signed-off-by: Alexei Starovoitov
---
tools/include/uapi/linux/bpf.h | 11 +++
tools/lib/bpf/bpf.c| 10 ++
tools/lib/bpf/bpf.h| 1 +
3 files changed, 22 insertions(+)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index
89K 697K750K755K
Alexei Starovoitov (5):
treewide: remove struct-pass-by-value from tracepoints arguments
tracepoint: compute num_args at build time
bpf: introduce BPF_RAW_TRACEPOINT
libbpf: add bpf_raw_tracepoint_open helper
samples/bpf: raw tracepoint test
arch/x86/xe
On Tue, Feb 27, 2018 at 05:20:55AM +, Andy Lutomirski wrote:
> On Tue, Feb 27, 2018 at 4:54 AM, Alexei Starovoitov
> wrote:
> > On Tue, Feb 27, 2018 at 04:40:34AM +, Andy Lutomirski wrote:
> >> On Tue, Feb 27, 2018 at 2:08 AM, Alexei Starovoitov
> >> wrote:
On Tue, Feb 27, 2018 at 04:40:34AM +, Andy Lutomirski wrote:
> On Tue, Feb 27, 2018 at 2:08 AM, Alexei Starovoitov
> wrote:
> > On Tue, Feb 27, 2018 at 01:41:15AM +0100, Mickaël Salaün wrote:
> >> The seccomp(2) syscall can be used by a task to apply a Landlock program
On Tue, Feb 27, 2018 at 01:41:15AM +0100, Mickaël Salaün wrote:
> The seccomp(2) syscall can be used by a task to apply a Landlock program
> to itself. As a seccomp filter, a Landlock program is enforced for the
> current task and all its future children. A program is immutable and a
> task can onl
st_maps: test_maps.c:955: run_parallel: Assertion `status == 0' failed.
> Aborted
> not ok 1..3 selftests: test_maps [FAIL]
> ---
> after this patch, the rest tests will be continue when it occurs a ENOMEM
> failure
>
> CC: Alexei Starovoitov
> CC:
the same
> changes to the tools/ version. This is part is put in a separate
> patch in case the two files are back ported separately.
>
> Signed-off-by: Song Liu
> Signed-off-by: Peter Zijlstra (Intel)
> Reviewed-by: Yonghong Song
> Reviewed-by: Josef Bacik
> Acked-b
On Mon, Feb 12, 2018 at 09:28:33AM +0100, Daniel Borkmann wrote:
> On 02/12/2018 06:47 AM, Yonghong Song wrote:
> > On 2/11/18 11:18 AM, Mathieu Malaterre wrote:
> >> On Sun, Feb 11, 2018 at 5:54 PM, Alexei Starovoitov
> >> wrote:
> >>> On Sun, Feb
On Sun, Feb 11, 2018 at 7:24 AM, Mathieu Malaterre wrote:
> Alexei,
>
> Could you please comment on why I am seeing those memleaks being
> reported on my ppc32 system ? Should they be marked as false positive
> ?
>
> System is Mac Mini G4, git/master (4.15.0+), ppc.
>
> Thanks for your time
>
> $
On Fri, Feb 09, 2018 at 03:01:57PM +0100, Daniel Borkmann wrote:
> On 02/09/2018 06:14 AM, Li Zhijian wrote:
> > Hi
> >
> > INTEL 0-Day noticed that bpf/test_maps has different results at different
> > platforms.
> > when it fails, the details are like
>
> Sorry for the late reply and thanks for
On Sun, Feb 04, 2018 at 12:57:47PM +0900, Masami Hiramatsu wrote:
>
> > I based some of the code from kprobes too. But I wanted this to be
> > simpler, and as such, not as powerful as kprobes. More of a "poor mans"
> > kprobe ;-) Where you are limited to functions and their arguments. If
> > you n
On Sat, Feb 03, 2018 at 04:17:32PM -0500, Steven Rostedt wrote:
> On Sat, 3 Feb 2018 12:52:08 -0800
> Alexei Starovoitov wrote:
>
> > It's a user space job.
>
> BTW, I asked around at DevConf.cz, and nobody I talked with (besides
> Arnaldo), have used eBPF. The &
On Sat, Feb 03, 2018 at 04:08:24PM -0500, Steven Rostedt wrote:
> On Sat, 3 Feb 2018 12:52:08 -0800
> Alexei Starovoitov wrote:
>
> > On Sat, Feb 03, 2018 at 02:02:17PM -0500, Steven Rostedt wrote:
> > >
> > > From those that were asking about having "tra
On Sat, Feb 03, 2018 at 02:02:17PM -0500, Steven Rostedt wrote:
>
> From those that were asking about having "trace markers" (ie.
> Facebook), they told us they can cope with kernel changes.
There is some misunderstanding here.
We never asked for this interface.
We're perfectly fine with existing
On Wed, Jan 31, 2018 at 05:53:13PM +0100, Daniel Borkmann wrote:
> On 01/30/2018 09:50 PM, Eric Leblond wrote:
> > Hello Daniel,
> >
> > No problem with the delay in the answer. I'm doing far worse.
> >
> > Here is an updated version:
> > - add if_link.h in uapi and remove the definition
> > - fi
On Fri, Feb 02, 2018 at 06:58:01AM -0800, syzbot wrote:
> Hello,
>
> syzbot hit the following crash on bpf-next commit
> b2fe5fa68642860e7de76167c3111623aa0d5de1 (Wed Jan 31 22:31:10 2018 +)
> Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
>
> So far this crash happened 15
tests/bpf/
and convert to use libbpf.a instead of obsolete bpf_load.c
Please use this approach for landlock as well.
> Signed-off-by: Mickaël Salaün
> Cc: Alexei Starovoitov
> Cc: Daniel Borkmann
> ---
>
> This is not a complet fix because the call to multi_depend with
> $
On Fri, Jan 26, 2018 at 12:54:02AM +0100, Mickaël Salaün wrote:
> Make the code more readable.
>
> Signed-off-by: Mickaël Salaün
> Cc: Alexei Starovoitov
> Cc: Daniel Borkmann
> ---
> kernel/bpf/syscall.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
ble to dump
> stackmaps independent of other maps.
>
> Tested on x86 and arm64 machines.
>
> [1] https://lwn.net/Articles/744522/
> [2] https://github.com/joelagnel/bpfd/issues/8
>
> Cc: Alexei Starovoitov
> Cc: Daniel Borkmann
> Cc: Brendan Gr
On Sat, Jan 20, 2018 at 8:56 AM, Alexei Starovoitov
wrote:
> On Fri, Jan 19, 2018 at 10:58:44PM -0800, Dan Williams wrote:
>> On Thu, Jan 18, 2018 at 4:01 PM, Dan Williams
>> wrote:
>> > Changes since v3 [1]
>> > * Drop 'ifence_array_ptr' and associat
On Fri, Jan 19, 2018 at 10:58:44PM -0800, Dan Williams wrote:
> On Thu, Jan 18, 2018 at 4:01 PM, Dan Williams
> wrote:
> > Changes since v3 [1]
> > * Drop 'ifence_array_ptr' and associated compile-time + run-time
> > switching and just use the masking approach all the time.
> >
> > * Convert 'g
On Sat, Jan 20, 2018 at 03:00:37AM +0100, Daniel Borkmann wrote:
> On 01/19/2018 12:43 AM, Eric Leblond wrote:
> > Hello,
> >
> > This patchset rebases the libbpf code on latest bpf-next code and addresses
> > remarks by Daniel.
>
> Ok, I think it's a good start. We should later on clean up the
>
On Wed, Jan 17, 2018 at 03:47:35PM -0500, Theodore Ts'o wrote:
> On Wed, Jan 17, 2018 at 12:09:18PM +0100, Dmitry Vyukov wrote:
> > On Wed, Jan 17, 2018 at 10:49 AM, Daniel Borkmann
> > wrote:
> > > Don't know if there's such a possibility, but it would be nice if we could
> > > target fuzzing fo
On Sun, Jan 14, 2018 at 01:18:35PM +0200, Karim Eshapa wrote:
> >> Use pointers to structure as arguments to function instead of coping
> >> structures and less stack size. Also transfer TNUM(_v, _m) to
> >> tnum.h file to be used in differnet files for creating anonymous structures
> >> statically
On Sun, Jan 14, 2018 at 12:03:42AM +0200, Karim Eshapa wrote:
> Use pointers to structure as arguments to function instead of coping
> structures and less stack size. Also transfer TNUM(_v, _m) to
> tnum.h file to be used in differnet files for creating anonymous structures
> statically.
>
> Signe
On Sat, Jan 13, 2018 at 02:42:19PM +0200, Karim Eshapa wrote:
> I noticed that most of functions here have structure arguements and return
> structure, all these structures passed and returned are delt in passing and
> assignment like memcpy a structure.In addition it takes size in stack while
>
On Sat, Jan 13, 2018 at 02:53:33AM +0900, Masami Hiramatsu wrote:
> Hi,
>
> Here are the 5th version of patches to moving error injection
> table from kprobes. This version fixes a bug and update
> fail-function to support multiple function error injection.
>
> Here is the previous version:
>
>
On Fri, Jan 12, 2018 at 05:21:54PM +0100, Daniel Borkmann wrote:
> On 01/12/2018 04:56 PM, Alexei Starovoitov wrote:
> > On Fri, Jan 12, 2018 at 11:45:42AM +0100, Daniel Borkmann wrote:
> >> On 01/12/2018 05:21 AM, Alexei Starovoitov wrote:
> >>> On Thu, Jan 11, 2
On Fri, Jan 12, 2018 at 11:45:42AM +0100, Daniel Borkmann wrote:
> On 01/12/2018 05:21 AM, Alexei Starovoitov wrote:
> > On Thu, Jan 11, 2018 at 10:11:45PM -0500, David Miller wrote:
> >> From: Alexei Starovoitov
> >> Date: Wed, 10 Jan 2018 17:58:54 -0800
> >>
On Thu, Jan 11, 2018 at 10:11:45PM -0500, David Miller wrote:
> From: Alexei Starovoitov
> Date: Wed, 10 Jan 2018 17:58:54 -0800
>
> > On Thu, Jan 11, 2018 at 11:53:55AM +1100, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> After merging the net-n
On Thu, Jan 11, 2018 at 10:57:51AM -0800, Dave Hansen wrote:
> On 01/11/2018 10:51 AM, Linus Torvalds wrote:
> > On Thu, Jan 11, 2018 at 10:38 AM, Dave Hansen
> > wrote:
> >> On 01/11/2018 10:32 AM, Josh Poimboeuf wrote:
> hmm. Exposing cr3 to user space will make it trivial for user process
On Thu, Jan 11, 2018 at 09:02:55AM -0800, Andy Lutomirski wrote:
> On Thu, Jan 11, 2018 at 7:51 AM, Dave Hansen
> wrote:
> > On 01/11/2018 07:44 AM, Willy Tarreau wrote:
> >>> I think we also need to be able to dump the actual
> >>> CR3 value that we entered the kernel with before we start doing t
501 - 600 of 2189 matches
Mail list logo
