Re: Unwinding regression with 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link")

Hi Laura, On Fri, Dec 14, 2018 at 1:48 PM Laura Abbott wrote: > Hi, > > There are two reports of a regression with unwinding with > 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") > > https://bugzilla.kernel.org/show_bug.cgi?id=201741 >

"x86/mm: Introduce the 'no5lvl' kernel parameter" broke SETUP_DTB?

age -drive file=root.ext4" on x86_64_defconfig with CONFIG_OF_UNITTEST enabled. If the FDT is unpacked successfully, the /proc/device-tree/firmware/android/compatible file will exist, and contain the string "android,firmware" instead of junk. I'm still looking into the root cause for this, but I just wanted to let you know. Alistair.

"x86/mm: Introduce the 'no5lvl' kernel parameter" broke SETUP_DTB?

age -drive file=root.ext4" on x86_64_defconfig with CONFIG_OF_UNITTEST enabled. If the FDT is unpacked successfully, the /proc/device-tree/firmware/android/compatible file will exist, and contain the string "android,firmware" instead of junk. I'm still looking into the root cause for this, but I just wanted to let you know. Alistair.

Re: [PATCH] Trivial numbering change in comments.

very welcome. > > Thanks so much! > Ray > > Signed-off-by: Ray Clinton Acked-by: Alistair Strachan > --- > drivers/staging/android/uapi/vsoc_shm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/uapi/vsoc_shm.

Re: [PATCH] Trivial numbering change in comments.

very welcome. > > Thanks so much! > Ray > > Signed-off-by: Ray Clinton Acked-by: Alistair Strachan > --- > drivers/staging/android/uapi/vsoc_shm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/uapi/vsoc_shm.

[tip:x86/vdso] x86: vdso: Use $LD instead of $CC to link

Commit-ID: 379d98ddf41344273d9718556f761420f4dc80b3 Gitweb: https://git.kernel.org/tip/379d98ddf41344273d9718556f761420f4dc80b3 Author: Alistair Strachan AuthorDate: Fri, 3 Aug 2018 10:39:31 -0700 Committer: Thomas Gleixner CommitDate: Sun, 5 Aug 2018 22:33:50 +0200 x86: vdso: Use $LD

[tip:x86/vdso] x86: vdso: Use $LD instead of $CC to link

Commit-ID: 379d98ddf41344273d9718556f761420f4dc80b3 Gitweb: https://git.kernel.org/tip/379d98ddf41344273d9718556f761420f4dc80b3 Author: Alistair Strachan AuthorDate: Fri, 3 Aug 2018 10:39:31 -0700 Committer: Thomas Gleixner CommitDate: Sun, 5 Aug 2018 22:33:50 +0200 x86: vdso: Use $LD

Re: native_save_fl() causes a warning

On Fri, Aug 3, 2018 at 9:38 AM Nick Desaulniers wrote: > > On Fri, Aug 3, 2018 at 6:10 AM Jean Delvare wrote: > > > > Hi Nick, > > > > It seems that this linux kernel commit of yours: > > > > commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 > > Author: Nick Desaulniers > > Date: Thu Jun 21

Re: native_save_fl() causes a warning

On Fri, Aug 3, 2018 at 9:38 AM Nick Desaulniers wrote: > > On Fri, Aug 3, 2018 at 6:10 AM Jean Delvare wrote: > > > > Hi Nick, > > > > It seems that this linux kernel commit of yours: > > > > commit d0a8d9378d16eb3c69bd8e6d23779fbdbee3a8c7 > > Author: Nick Desaulniers > > Date: Thu Jun 21

[PATCH v2] x86: vdso: Use $LD instead of $CC to link

.com Cc: j...@joelfernandes.org Signed-off-by: Alistair Strachan Acked-by: Andy Lutomirski --- v2: Updated changelog and rediffed Supersedes "x86: vdso: Fix leaky vdso link with CC=clang" arch/x86/entry/vdso/Makefile | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) d

[PATCH v2] x86: vdso: Use $LD instead of $CC to link

.com Cc: j...@joelfernandes.org Signed-off-by: Alistair Strachan Acked-by: Andy Lutomirski --- v2: Updated changelog and rediffed Supersedes "x86: vdso: Fix leaky vdso link with CC=clang" arch/x86/entry/vdso/Makefile | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) d

Re: [PATCH] x86: vdso: Use $LD instead of $CC to link

On Fri, Aug 3, 2018 at 3:26 AM Thomas Gleixner wrote: > > On Wed, 18 Jul 2018, Alistair Strachan wrote: > > export CPPFLAGS_vdso.lds += -P -C > > > > -VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \ > > - -Wl,--no-undefined \ > &

Re: [PATCH] x86: vdso: Use $LD instead of $CC to link

On Fri, Aug 3, 2018 at 3:26 AM Thomas Gleixner wrote: > > On Wed, 18 Jul 2018, Alistair Strachan wrote: > > export CPPFLAGS_vdso.lds += -P -C > > > > -VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \ > > - -Wl,--no-undefined \ > &

[PATCH] x86: vdso: Use $LD instead of $CC to link

Cc: "H. Peter Anvin" Cc: Greg Kroah-Hartman Cc: x...@kernel.org Cc: kernel-t...@android.com Cc: j...@joelfernandes.com Signed-off-by: Alistair Strachan --- Supersedes "x86: vdso: Fix leaky vdso link with CC=clang" arch/x86/entry/vdso/Makefile | 22 +

[PATCH] x86: vdso: Use $LD instead of $CC to link

Cc: "H. Peter Anvin" Cc: Greg Kroah-Hartman Cc: x...@kernel.org Cc: kernel-t...@android.com Cc: j...@joelfernandes.com Signed-off-by: Alistair Strachan --- Supersedes "x86: vdso: Fix leaky vdso link with CC=clang" arch/x86/entry/vdso/Makefile | 22 +

Re: WARNING: lock held when returning to user space in fuse_lock_inode

se by doing something (looking up ./file0/file0) and the one that > >> reads the fuse device (returning with the LOOKUP request for "file0"). > >> The second one will return with that lock held, but it's not the one > >> that acquired it, so there's no b

Re: WARNING: lock held when returning to user space in fuse_lock_inode

se by doing something (looking up ./file0/file0) and the one that > >> reads the fuse device (returning with the LOOKUP request for "file0"). > >> The second one will return with that lock held, but it's not the one > >> that acquired it, so there's no b

Re: [PATCH] x86: vdso: Fix leaky vdso link with CC=clang

On Thu, Jul 12, 2018 at 4:20 PM Andy Lutomirski wrote: > > > On Jul 12, 2018, at 3:06 PM, H. Peter Anvin wrote: > > > >> On 07/12/18 13:37, Alistair Strachan wrote: > >>> On Thu, Jul 12, 2018 at 1:25 PM H. Peter Anvin wrote: > >>>> On 07/12

Re: [PATCH] x86: vdso: Fix leaky vdso link with CC=clang

On Thu, Jul 12, 2018 at 4:20 PM Andy Lutomirski wrote: > > > On Jul 12, 2018, at 3:06 PM, H. Peter Anvin wrote: > > > >> On 07/12/18 13:37, Alistair Strachan wrote: > >>> On Thu, Jul 12, 2018 at 1:25 PM H. Peter Anvin wrote: > >>>> On 07/12

Re: [PATCH] x86: vdso: Fix leaky vdso link with CC=clang

On Thu, Jul 12, 2018 at 1:25 PM H. Peter Anvin wrote: > On 07/12/18 13:10, Alistair Strachan wrote: > > The vdso{32,64}.so can fail to link with CC=clang when clang tries to > > find a suitable GCC toolchain to link these libraries with. > > > > /usr/bin/ld: arch/x86/

Re: [PATCH] x86: vdso: Fix leaky vdso link with CC=clang

On Thu, Jul 12, 2018 at 1:25 PM H. Peter Anvin wrote: > On 07/12/18 13:10, Alistair Strachan wrote: > > The vdso{32,64}.so can fail to link with CC=clang when clang tries to > > find a suitable GCC toolchain to link these libraries with. > > > > /usr/bin/ld: arch/x86/

[PATCH] x86: vdso: Fix leaky vdso link with CC=clang

KBUILD_CFLAGS. These flags direct clang to the appropriate toolchain to link the vdsos. Cc: Andy Lutomirski Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Greg Kroah-Hartman Cc: x...@kernel.org Cc: kernel-t...@android.com Cc: j...@joelfernandes.com Signed-off-by: Alistai

[PATCH] x86: vdso: Fix leaky vdso link with CC=clang

KBUILD_CFLAGS. These flags direct clang to the appropriate toolchain to link the vdsos. Cc: Andy Lutomirski Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Greg Kroah-Hartman Cc: x...@kernel.org Cc: kernel-t...@android.com Cc: j...@joelfernandes.com Signed-off-by: Alistai

Re: [PATCH] staging: android/vsoc: stop using 'timespec'

On Mon, Jun 18, 2018 at 8:09 AM Arnd Bergmann wrote: > > The timespec structure suffers from the y2038 overflow and should not > be used. This changes handle_vsoc_cond_wait() to use ktime_t directly. > > Signed-off-by: Arnd Bergmann Tested-by: Alistair Strachan > ---

Re: [PATCH] staging: android/vsoc: stop using 'timespec'

On Mon, Jun 18, 2018 at 8:09 AM Arnd Bergmann wrote: > > The timespec structure suffers from the y2038 overflow and should not > be used. This changes handle_vsoc_cond_wait() to use ktime_t directly. > > Signed-off-by: Arnd Bergmann Tested-by: Alistair Strachan > ---

[PATCH 2/2 v2] staging: android: ashmem: Fix mmap size validation

...@android.com Cc: Joel Fernandes Signed-off-by: Alistair Strachan --- v2: Removed unnecessary use of unlikely() macro drivers/staging/android/ashmem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index c6386e4f5c9b

[PATCH 2/2 v2] staging: android: ashmem: Fix mmap size validation

...@android.com Cc: Joel Fernandes Signed-off-by: Alistair Strachan --- v2: Removed unnecessary use of unlikely() macro drivers/staging/android/ashmem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index c6386e4f5c9b

[PATCH 1/2] staging: android: ashmem: Remove use of unlikely()

Signed-off-by: Alistair Strachan --- drivers/staging/android/ashmem.c | 34 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index a1a0025b59e0..c6386e4f5c9b 100644 --- a/drivers/staging

[PATCH 1/2] staging: android: ashmem: Remove use of unlikely()

Signed-off-by: Alistair Strachan --- drivers/staging/android/ashmem.c | 34 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index a1a0025b59e0..c6386e4f5c9b 100644 --- a/drivers/staging

Re: [PATCH] staging: android: ashmem: Fix mmap size validation

HI Greg, On Tue, Jun 19, 2018 at 4:01 PM Greg Kroah-Hartman wrote: > > On Tue, Jun 19, 2018 at 03:24:44PM -0700, Alistair Strachan wrote: > > The ashmem driver did not check that the size/offset of the vma passed > > to its .mmap() function was not larger than the ashmem objec

Re: [PATCH] staging: android: ashmem: Fix mmap size validation

HI Greg, On Tue, Jun 19, 2018 at 4:01 PM Greg Kroah-Hartman wrote: > > On Tue, Jun 19, 2018 at 03:24:44PM -0700, Alistair Strachan wrote: > > The ashmem driver did not check that the size/offset of the vma passed > > to its .mmap() function was not larger than the ashmem objec

[PATCH] staging: android: ashmem: Fix mmap size validation

-by: Alistair Strachan --- drivers/staging/android/ashmem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index a1a0025b59e0..1eeedb529a10 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android/ashmem.c

[PATCH] staging: android: ashmem: Fix mmap size validation

-by: Alistair Strachan --- drivers/staging/android/ashmem.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index a1a0025b59e0..1eeedb529a10 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android/ashmem.c

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

On Monday, 18 June 2018 2:46:33 PM AEST Benjamin Herrenschmidt wrote: > On Mon, 2018-06-18 at 14:09 +1000, Alistair Popple wrote: > > On Sunday, 17 June 2018 11:22:11 AM AEST Benjamin Herrenschmidt wrote: > > > On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote: &

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

On Monday, 18 June 2018 2:46:33 PM AEST Benjamin Herrenschmidt wrote: > On Mon, 2018-06-18 at 14:09 +1000, Alistair Popple wrote: > > On Sunday, 17 June 2018 11:22:11 AM AEST Benjamin Herrenschmidt wrote: > > > On Sun, 2018-06-17 at 11:17 +1000, Benjamin Herrenschmidt wrote: &

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

> + break; > + msleep(1); > + } The rc handling above took me a little while to grok but I didn't come up with a cleaner alternative and I think it's correct. - Alistair > > > > That said, cronus does a bunch of other stupid things that I

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

> + break; > + msleep(1); > + } The rc handling above took me a little while to grok but I didn't come up with a cleaner alternative and I think it's correct. - Alistair > > > > That said, cronus does a bunch of other stupid things that I

Re: [PATCH v2] proc: Simplify and fix proc by removing the kernel mount

pid namespace implementation, maintaining > kernel mounts of proc is removed. > > In addition removing the unnecessary complexity of the kernel mount > fixes a regression that caused the proc mount options to be ignored. > Now that the initial mount of proc comes from userspace, those mount >

Re: [PATCH v2] proc: Simplify and fix proc by removing the kernel mount

pid namespace implementation, maintaining > kernel mounts of proc is removed. > > In addition removing the unnecessary complexity of the kernel mount > fixes a regression that caused the proc mount options to be ignored. > Now that the initial mount of proc comes from userspace, those mount >

Re: [PATCH] proc: Fix parsing of mount parameters.

On Mon, Jun 11, 2018 at 6:22 PM Eric W. Biederman wrote: > > Alistair Strachan writes: > > > In commit e94591d0d90c "proc: Convert proc_mount to use mount_ns" > > the parsing of mount parameters for the proc filesystem was broken. > > > &

Re: [PATCH] proc: Fix parsing of mount parameters.

On Mon, Jun 11, 2018 at 6:22 PM Eric W. Biederman wrote: > > Alistair Strachan writes: > > > In commit e94591d0d90c "proc: Convert proc_mount to use mount_ns" > > the parsing of mount parameters for the proc filesystem was broken. > > > &

[PATCH] proc: Fix parsing of mount parameters.

t;proc: Convert proc_mount to use mount_ns") Signed-off-by: Alistair Strachan Cc: Seth Forshee Cc: Djalal Harouni Cc: "Eric W. Biederman" Cc: kernel-t...@android.com Cc: linux-kernel@vger.kernel.org --- fs/proc/inode.c| 4 fs/proc/internal.h | 1 - fs/proc/root.c

[PATCH] proc: Fix parsing of mount parameters.

t;proc: Convert proc_mount to use mount_ns") Signed-off-by: Alistair Strachan Cc: Seth Forshee Cc: Djalal Harouni Cc: "Eric W. Biederman" Cc: kernel-t...@android.com Cc: linux-kernel@vger.kernel.org --- fs/proc/inode.c| 4 fs/proc/internal.h | 1 - fs/proc/root.c

Re: [clang] stack protector and f1f029c7bf

(Resent plain text) On Thu, May 24, 2018 at 11:24 AM Nick Desaulniers wrote: > On Thu, May 24, 2018 at 11:20 AM wrote: > > A stack canary on an *inlined* function? That's bound to break things > elsewhere too sooner or later. > But it's *not* inlined

Re: [clang] stack protector and f1f029c7bf

(Resent plain text) On Thu, May 24, 2018 at 11:24 AM Nick Desaulniers wrote: > On Thu, May 24, 2018 at 11:20 AM wrote: > > A stack canary on an *inlined* function? That's bound to break things > elsewhere too sooner or later. > But it's *not* inlined by GCC or Clang. FWIW, GCC can also

[PATCH 1/3] staging: Android: vsoc: Create wc kernel mapping for region shm.

de...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Alistair Strachan <astrac...@google.com> --- drivers/staging/android/TODO | 1 - drivers/staging/android/vsoc.c | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/android/TODO

[PATCH 1/3] staging: Android: vsoc: Create wc kernel mapping for region shm.

Map the region shm as write-combining instead of uncachable. Cc: Greg Kroah-Hartman Cc: Arve Hjønnevåg Cc: Todd Kjos Cc: Martijn Coenen Cc: Greg Hartman Cc: de...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Alistair Strachan --- drivers/staging/android/TODO | 1

[PATCH 2/3] staging: Android: vsoc: Fix a i386-randconfig warning.

> Cc: Todd Kjos <tk...@android.com> Cc: Martijn Coenen <m...@android.com> Cc: Greg Hartman <ghart...@google.com> Cc: de...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Alistair Strachan <astrac...@google.com> --- drivers/staging/android/vsoc.c | 4 ++-- 1 file

[PATCH 2/3] staging: Android: vsoc: Fix a i386-randconfig warning.

an Cc: de...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Alistair Strachan --- drivers/staging/android/vsoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/vsoc.c b/drivers/staging/android/vsoc.c index 794137b7751f..3e6e4af7d6a1 100644 ---

[PATCH 3/3] staging: Android: Fix sparse warnings in vsoc driver.

Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Arve Hjønnevåg <a...@android.com> Cc: Todd Kjos <tk...@android.com> Cc: Martijn Coenen <m...@android.com> Cc: Greg Hartman <ghart...@google.com> Cc: de...@driverdev.osuosl.org Cc: kernel-t...@android.com Si

[PATCH 3/3] staging: Android: Fix sparse warnings in vsoc driver.

Cc: Greg Kroah-Hartman Cc: Arve Hjønnevåg Cc: Todd Kjos Cc: Martijn Coenen Cc: Greg Hartman Cc: de...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Alistair Strachan --- drivers/staging/android/vsoc.c | 100 - 1 file changed, 49 insertions

[PATCH v2] staging: Android: Add 'vsoc' driver for cuttlefish.

against 4.16, added TODO, fixed checkpatch issues] Signed-off-by: Alistair Strachan <astrac...@google.com> --- v2: addressed issues with class_create() failure handling and redundant null pointer checks noticed by Dan Carpenter drivers/staging/android/Kconfig |9 + drivers/s

[PATCH v2] staging: Android: Add 'vsoc' driver for cuttlefish.

...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Greg Hartman [astrachan: rebased against 4.16, added TODO, fixed checkpatch issues] Signed-off-by: Alistair Strachan --- v2: addressed issues with class_create() failure handling and redundant null pointer checks noticed by Dan

[PATCH] staging: Android: Add 'vsoc' driver for cuttlefish.

ve Hjønnevåg <a...@android.com> Cc: Todd Kjos <tk...@android.com> Cc: Martijn Coenen <m...@android.com> Cc: de...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Greg Hartman <ghart...@google.com> [astrachan: rebased against 4.16, added TODO, fixed checkpatch issues] Sign

[PATCH] staging: Android: Add 'vsoc' driver for cuttlefish.

...@driverdev.osuosl.org Cc: kernel-t...@android.com Signed-off-by: Greg Hartman [astrachan: rebased against 4.16, added TODO, fixed checkpatch issues] Signed-off-by: Alistair Strachan --- drivers/staging/android/Kconfig |9 + drivers/staging/android/Makefile|1 + drivers/staging/android/TODO

Re: [PATCH v3 4/4] 44x/fsp2: add irq error handlers

On Friday, 8 December 2017 6:41:02 PM AEDT Ivan Mikhaylov wrote: > add irq error handlers for cmu, plb, opb, mcue, conf > with debug information output in case of problems. > > Signed-off-by: Ivan Mikhaylov <i...@de.ibm.com> Acked-by: Alistair Popple <alist...@popple.

Re: [PATCH v3 4/4] 44x/fsp2: add irq error handlers

On Friday, 8 December 2017 6:41:02 PM AEDT Ivan Mikhaylov wrote: > add irq error handlers for cmu, plb, opb, mcue, conf > with debug information output in case of problems. > > Signed-off-by: Ivan Mikhaylov Acked-by: Alistair Popple > --- > arch/powerpc/platforms

Re: [PATCH 1/4] 44x/fsp2: add fsp2 headers

Hi Ivan, Does it make sense to have these in a seperate include file? From what I could see these defines were only used in fsp2.c so you could just put them directly in there. - Alistair On Thursday, 2 November 2017 4:07:03 PM AEDT Ivan Mikhaylov wrote: > * add cmu, plbX, l2 regis

Re: [PATCH 4/4] 44x/fsp2: add irq error handlers

take an argument for the handler to make sure each node has the right debug info printed. Eg: node_irq_request(FSP2_CMU_ERR, cmu_err_handler); node_irq_request(FSP2_BUS_ERR, bus_err_handler); node_irq_request(FSP2_CONF_ERR, conf_err_handler); node_irq_request(FSP2_OPB

Re: [PATCH 1/4] 44x/fsp2: add fsp2 headers

Hi Ivan, Does it make sense to have these in a seperate include file? From what I could see these defines were only used in fsp2.c so you could just put them directly in there. - Alistair On Thursday, 2 November 2017 4:07:03 PM AEDT Ivan Mikhaylov wrote: > * add cmu, plbX, l2 regis

Re: [PATCH 4/4] 44x/fsp2: add irq error handlers

the handler to make sure each node has the right debug info printed. Eg: node_irq_request(FSP2_CMU_ERR, cmu_err_handler); node_irq_request(FSP2_BUS_ERR, bus_err_handler); node_irq_request(FSP2_CONF_ERR, conf_err_handler); node_irq_request(FSP2_OPBD_ERR, opbd_err_hand

Re: [PATCH 3/4] 44x/fsp2: tvsense workaround for dd1

It would be good if you could provide a more detailed description of the problem (like in the comment below) and what this patch does to address it. Feel free to add my reviewed by as well. - Alistair > Signed-off-by: Ivan Mikhaylov <i...@de.ibm.com> > --- > arch/powerpc/pla

Re: [PATCH 2/4] 44x/fsp2: l2 setup with error clear

I'm not familiar with the hardware setup going on here so I can't comment on it's correctness but the code looks ok. A commit message describing why this particular setup is needed would be nice though. Reviewed-by: Alistair Popple <alist...@popple.id.au> On Thursday, 2 November 2017 4:07

Re: [PATCH 3/4] 44x/fsp2: tvsense workaround for dd1

It would be good if you could provide a more detailed description of the problem (like in the comment below) and what this patch does to address it. Feel free to add my reviewed by as well. - Alistair > Signed-off-by: Ivan Mikhaylov > --- > arch/powerpc/platforms/44x/fsp2.c | 17

Re: [PATCH 2/4] 44x/fsp2: l2 setup with error clear

I'm not familiar with the hardware setup going on here so I can't comment on it's correctness but the code looks ok. A commit message describing why this particular setup is needed would be nice though. Reviewed-by: Alistair Popple On Thursday, 2 November 2017 4:07:04 PM AEDT Ivan Mikhaylov

[PATCH] powerpc/powernv: Fix TCE kill on NVLink2

This patch adds an equivalent IODA2 version of the function which uses the correct invalidation method depending on PHB model and changes all external callers to use it instead. Fixes: 616badd2fb49 ("powerpc/powernv: Use OPAL call for TCE kill on NVLink2") Signed-off-by: Alistair Popple &l

[PATCH] powerpc/powernv: Fix TCE kill on NVLink2

This patch adds an equivalent IODA2 version of the function which uses the correct invalidation method depending on PHB model and changes all external callers to use it instead. Fixes: 616badd2fb49 ("powerpc/powernv: Use OPAL call for TCE kill on NVLink2") Signed-off-by: Alis

[PATCH v2 1/3] drivers/of/base.c: Add of_property_read_u64_index

There is of_property_read_u32_index but no u64 variant. This patch adds one similar to the u32 version for u64. Signed-off-by: Alistair Popple <alist...@popple.id.au> Acked-by: Rob Herring <r...@kernel.org> --- drivers/of/base.c | 31 +++ include/lin

[PATCH v2 3/3] powerpc/powernv: Introduce address translation services for Nvlink2

of when a device should stop issuing address translation requests (ATRs). It also adds a fault handler to allow device drivers to demand fault pages in. Signed-off-by: Alistair Popple <alist...@popple.id.au> --- Changes since v1: - Moved exported function call prototypes to an externally acce

[PATCH v2 1/3] drivers/of/base.c: Add of_property_read_u64_index

There is of_property_read_u32_index but no u64 variant. This patch adds one similar to the u32 version for u64. Signed-off-by: Alistair Popple Acked-by: Rob Herring --- drivers/of/base.c | 31 +++ include/linux/of.h | 3 +++ 2 files changed, 34 insertions(+) diff

[PATCH v2 3/3] powerpc/powernv: Introduce address translation services for Nvlink2

of when a device should stop issuing address translation requests (ATRs). It also adds a fault handler to allow device drivers to demand fault pages in. Signed-off-by: Alistair Popple --- Changes since v1: - Moved exported function call prototypes to an externally accessable header. - Fixed

[PATCH v2 2/3] powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev

-off-by: Alistair Popple <alist...@popple.id.au> --- arch/powerpc/platforms/powernv/npu-dma.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c index 1c383f3..050bd5d 100644 --- a/arch/p

[PATCH v2 2/3] powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev

-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/npu-dma.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c index 1c383f3..050bd5d 100644 --- a/arch/powerpc/platforms/powernv/npu-dma.c

[PATCH 1/3] drivers/of/base.c: Add of_property_read_u64_index

There is of_property_read_u32_index but no u64 variant. This patch adds one similar to the u32 version for u64. Signed-off-by: Alistair Popple <alist...@popple.id.au> --- drivers/of/base.c | 31 +++ include/linux/of.h | 3 +++ 2 files changed, 34 insertions(+)

[PATCH 1/3] drivers/of/base.c: Add of_property_read_u64_index

There is of_property_read_u32_index but no u64 variant. This patch adds one similar to the u32 version for u64. Signed-off-by: Alistair Popple --- drivers/of/base.c | 31 +++ include/linux/of.h | 3 +++ 2 files changed, 34 insertions(+) diff --git a/drivers

[PATCH 2/3] powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev

. Signed-off-by: Alistair Popple <alist...@popple.id.au> --- arch/powerpc/platforms/powernv/npu-dma.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c index 1c383f3..050bd5d 100644 --- a/arch/p

[PATCH 2/3] powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev

. Signed-off-by: Alistair Popple --- arch/powerpc/platforms/powernv/npu-dma.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c index 1c383f3..050bd5d 100644 --- a/arch/powerpc/platforms/powernv/npu

[PATCH 3/3] powerpc/powernv: Introduce address translation services for Nvlink2

of when a device should stop issuing address translation requests (ATRs). It also adds a fault handler to allow device drivers to demand fault pages in. Signed-off-by: Alistair Popple <alist...@popple.id.au> --- arch/powerpc/include/asm/book3s/64/mmu.h | 6 + arch/powerpc/include/as

[PATCH 3/3] powerpc/powernv: Introduce address translation services for Nvlink2

of when a device should stop issuing address translation requests (ATRs). It also adds a fault handler to allow device drivers to demand fault pages in. Signed-off-by: Alistair Popple --- arch/powerpc/include/asm/book3s/64/mmu.h | 6 + arch/powerpc/include/asm/opal-api.h| 5

Re: [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes

his patch seems fairly independent perhaps it is worth sending as a separate fix if it is not going to make it into this release? Regards, Alistair > The use case at hand is accelerator or device memory, which may be > unusable until post-boot initialization of the memory link. Such a node >

Re: [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes

his patch seems fairly independent perhaps it is worth sending as a separate fix if it is not going to make it into this release? Regards, Alistair > The use case at hand is accelerator or device memory, which may be > unusable until post-boot initialization of the memory link. Such a node >

Re: [PATCH] powerpc/powernv: Initialise nest mmu

On Mon, 15 Aug 2016 04:51:59 PM Alistair Popple wrote: > POWER9 contains an off core mmu called the nest mmu (NMMU). This is > used by other hardware units on the chip to translate virtual > addresses into real addresses. The unit attempting an address > translation provides

Re: [PATCH] powerpc/powernv: Initialise nest mmu

On Mon, 15 Aug 2016 04:51:59 PM Alistair Popple wrote: > POWER9 contains an off core mmu called the nest mmu (NMMU). This is > used by other hardware units on the chip to translate virtual > addresses into real addresses. The unit attempting an address > translation provides

Re: [PATCH] powerpc/powernv: Initialise nest mmu

Balbir, > > + /* Update partition table control register on all Nest MMUs */ > > + opal_nmmu_set_ptcr(-1UL, __pa(partition_tb) | (PATB_SIZE_SHIFT - 12)); > > + > > Just wondering if > > 1. Instead of using -1 for all cpus, we should do > for_each_online_cpu() { >

Re: [PATCH] powerpc/powernv: Initialise nest mmu

Balbir, > > + /* Update partition table control register on all Nest MMUs */ > > + opal_nmmu_set_ptcr(-1UL, __pa(partition_tb) | (PATB_SIZE_SHIFT - 12)); > > + > > Just wondering if > > 1. Instead of using -1 for all cpus, we should do > for_each_online_cpu() { >

[PATCH] powerpc/powernv: Initialise nest mmu

address of the partition table (ie. the PTCR) which needs to be programmed into the NMMU. This patch adds a call to OPAL to set the PTCR for the nest mmu in opal_init(). Signed-off-by: Alistair Popple <alist...@popple.id.au> --- This patch depends on a new OPAL call which has yet to be

[PATCH] powerpc/powernv: Initialise nest mmu

address of the partition table (ie. the PTCR) which needs to be programmed into the NMMU. This patch adds a call to OPAL to set the PTCR for the nest mmu in opal_init(). Signed-off-by: Alistair Popple --- This patch depends on a new OPAL call which has yet to be added to skiboot, although

Re: [PATCH kernel v4 10/11] powerpc/powernv/npu: Rework TCE Kill handling

On Thu, 5 May 2016 14:23:20 Alexey Kardashevskiy wrote: > On 05/03/2016 05:37 PM, Alistair Popple wrote: > > On Fri, 29 Apr 2016 18:55:23 Alexey Kardashevskiy wrote: > >> The pnv_ioda_pe struct keeps an array of peers. At the moment it is only > >> used to link

Re: [PATCH kernel v4 10/11] powerpc/powernv/npu: Rework TCE Kill handling

On Thu, 5 May 2016 14:23:20 Alexey Kardashevskiy wrote: > On 05/03/2016 05:37 PM, Alistair Popple wrote: > > On Fri, 29 Apr 2016 18:55:23 Alexey Kardashevskiy wrote: > >> The pnv_ioda_pe struct keeps an array of peers. At the moment it is only > >> used to link

Re: [PATCH kernel v4 11/11] powerpc/powernv/npu: Enable NVLink pass through

On Thu, 5 May 2016 15:49:18 Alexey Kardashevskiy wrote: > On 05/04/2016 12:08 AM, Alistair Popple wrote: > > Hi Alexey, > > > > On Fri, 29 Apr 2016 18:55:24 Alexey Kardashevskiy wrote: > >> IBM POWER8 NVlink systems come with Tesla K40-ish GPUs each of which > &

Re: [PATCH kernel v4 11/11] powerpc/powernv/npu: Enable NVLink pass through

On Thu, 5 May 2016 15:49:18 Alexey Kardashevskiy wrote: > On 05/04/2016 12:08 AM, Alistair Popple wrote: > > Hi Alexey, > > > > On Fri, 29 Apr 2016 18:55:24 Alexey Kardashevskiy wrote: > >> IBM POWER8 NVlink systems come with Tesla K40-ish GPUs each of which > &

Re: [PATCH kernel v4 11/11] powerpc/powernv/npu: Enable NVLink pass through

NPU) > + return 0; > + > + *ptmppe = >ioda.pe_array[pdn->pe_number]; > + > + return 1; > +} > + > +/* > + * This returns PE of associated NPU. > + * This assumes that NPU is in the same IOMMU group with GP

Re: [PATCH kernel v4 11/11] powerpc/powernv/npu: Enable NVLink pass through

struct pci_dn *pdn = pci_get_pdn(pdev); > + > + if (!pdn || pdn->pe_number == IODA_INVALID_PE) > + return 0; > + > + hose = pci_bus_to_host(pdev->bus); > + phb = hose->private_data; > + if (phb->type != PNV_PHB_NPU) > +

Re: [PATCH kernel v4 10/11] powerpc/powernv/npu: Rework TCE Kill handling

ed anymore. Happy to see it go. I'm not too familiar with iommu groups but based on the code and what you have described to me both here and offline everything looks good to me. One pretty minor style comment below. Reviewed-By: Alistair Popple <alist...@popple.id.au> > While we are he

Re: [PATCH kernel v4 10/11] powerpc/powernv/npu: Rework TCE Kill handling

ed anymore. Happy to see it go. I'm not too familiar with iommu groups but based on the code and what you have described to me both here and offline everything looks good to me. One pretty minor style comment below. Reviewed-By: Alistair Popple > While we are here, add TCE cache invalida

Re: [PATCH kernel v4 09/11] powerpc/powernv/npu: Add set/unset window helpers

* We don't initialise npu_pe->tce32_table as we always use > @@ -248,6 +289,10 @@ static int pnv_npu_dma_set_bypass(struct pnv_ioda_pe *npe) > if (phb->type != PNV_PHB_NPU || !npe->pdev) > return -EINVAL; > > + rc = pnv_npu_unset_window(npe); As noted

Re: [PATCH kernel v4 09/11] powerpc/powernv/npu: Add set/unset window helpers

->tce32_table as we always use > @@ -248,6 +289,10 @@ static int pnv_npu_dma_set_bypass(struct pnv_ioda_pe *npe) > if (phb->type != PNV_PHB_NPU || !npe->pdev) > return -EINVAL; > > + rc = pnv_npu_unset_window(npe); As noted in the commit message y

Re: [PATCH kernel v4 08/11] powerpc/powernv/ioda2: Export debug helper pe_level_printk()

On Tue, 3 May 2016 15:46:33 Alistair Popple wrote: > There's one call to pr_warn() in pnv_npu_disable_bypass() that could arguably > be converted to pe_warn(), but we can clean that up later as the patch looks > fine and I'm assuming subsequent patches make use of these. And i

Re: [PATCH kernel v4 08/11] powerpc/powernv/ioda2: Export debug helper pe_level_printk()

On Tue, 3 May 2016 15:46:33 Alistair Popple wrote: > There's one call to pr_warn() in pnv_npu_disable_bypass() that could arguably > be converted to pe_warn(), but we can clean that up later as the patch looks > fine and I'm assuming subsequent patches make use of these. And i

Re: [PATCH kernel v4 08/11] powerpc/powernv/ioda2: Export debug helper pe_level_printk()

There's one call to pr_warn() in pnv_npu_disable_bypass() that could arguably be converted to pe_warn(), but we can clean that up later as the patch looks fine and I'm assuming subsequent patches make use of these. Reviewed-By: Alistair Popple <alist...@popple.id.au> On Fri, 29 Apr 2016

<    1   2   3   4   5   6   7   8   9   10   >