On 4/12/2021 11:19 AM, Perry Yuan wrote:
From: Perry Yuan
(...)
diff --git a/drivers/platform/x86/dell/dell-laptop.c
b/drivers/platform/x86/dell/dell-laptop.c
index 70edc5bb3a14..e7ffc0b81208 100644
--- a/drivers/platform/x86/dell/dell-laptop.c
+++
On 3/11/2021 11:24 AM, Jaroslav Kysela wrote:
Dne 11. 03. 21 v 6:50 Chris Chiu napsal(a):
On Tue, Mar 9, 2021 at 11:29 PM Cezary Rojewski
wrote:
On 2021-03-09 1:19 PM, Chris Chiu wrote:
Hi Guys,
We have received reports that on some Kabylake laptops (Acer Swift
SF314-54/55 and Lenovo
On 12/31/2020 11:50 AM, Christian Labisch wrote:
Hi Lars-Peter,
Thank you, please find attached the requested information from both kernels.
I freshly installed the fedora kernel 5.10.4 to give you the latest results.
Regards,
Christian
Christian Labisch
Red Hat Accelerator
On 12/10/2020 1:14 PM, Lukasz Majczak wrote:
+ kcontrol = dobj->control.kcontrol;
+ if(!kcontrol)
+ continue;
Small nitpick, there should be space between if and opening parenthesis
as recommended by coding style.
Thanks,
Amadeusz
The following commit has been merged into the efi/urgent branch of tip:
Commit-ID: 50bdcf047503e30126327d0be4f0ad7337106d68
Gitweb:
https://git.kernel.org/tip/50bdcf047503e30126327d0be4f0ad7337106d68
Author:Amadeusz Sławiński
AuthorDate:Mon, 23 Nov 2020 12:28:17 -05:00
Looks ok and tests on our side also pass.
Reviewed-by: Amadeusz Sławiński
On 7/17/2020 11:55 PM, Gustavo A. R. Silva wrote:
One-element arrays are being deprecated[1]. Replace the one-element
array with a simple value type 'u8 reserved'[2], once it seems this
is just a placeholder
On 6/29/2020 9:50 AM, Vinod Koul wrote:
So we had some discussions of the stream states, so I thought it is a
good idea to document the state transitions, so add it documentation
Reviewed-by: Charles Keepax
Signed-off-by: Vinod Koul
---
.../sound/designs/compress-offload.rst| 51
On 6/29/2020 11:34 AM, Vinod Koul wrote:
>
> Not sure, this is not in the version I posted, arrow is from setup ->
> prepare. See
https://lore.kernel.org/alsa-devel/20200629075002.11436-2-vk...@kernel.org/
>
> I don't know how it got reversed in your version, maybe the MUA messed
> up??
>
Ah...
On 5/7/2020 11:56 AM, Takashi Iwai wrote:
On Thu, 07 May 2020 10:23:02 +0200,
Greg Kroah-Hartman wrote:
On Thu, May 07, 2020 at 04:04:25PM +0800, butt3rflyh4ck wrote:
I report a bug (in linux-5.7-rc1) found by syzkaller.
kernel config:
On 4/30/2020 5:38 PM, Lu, Brent wrote:
Hi,
yes that seems bit weird. It is bit better as it does not modify common code,
but still... Maybe going back to your original idea of replacing memcpy, try
replacing it with readq? It should generate one instruction read (although it is
only for
On 4/28/2020 7:29 PM, Lu, Brent wrote:
I've looked at the code and byt_is_dsp_busy seems suspicious to me.
Can you check if following change fixes problem for you:(...)
We seem to treat SST_IPCX as 32 bit register instead of 64 one, which may
explain wrong behaviour. (Specification says it
From: Amadeusz Sławiński
oem_table_id is 8 chars long, so we need to limit it, otherwise it
may print some unprintable characters into dmesg.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-nhlt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc
Series of small fixes:
* fixes few issues found during checking code with static checkers
* fix few prints
* define function in header, like it should be
* release topology when done with it
Amadeusz Sławiński (6):
ASoC: Intel: Skylake: Use correct function to access iomem space
ASoC: Intel
From: Amadeusz Sławiński
We use snd_soc_dapm_new_control_unlocked for topology and have local
declaration, instead declare it properly in header like already declared
snd_soc_dapm_new_control.
Signed-off-by: Amadeusz Sławiński
---
include/sound/soc-dapm.h | 3 +++
sound/soc/soc-topology.c | 6
From: Amadeusz Sławiński
If ipc->ops.reply_msg_match is NULL, we may end up using uninitialized
mask value.
reported by smatch:
sound/soc/intel/common/sst-ipc.c:266 sst_ipc_reply_find_msg() error:
uninitialized symbol 'mask'.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/common/
Currently topology is kept in memory while driver is running. It's
unnecessary, as it's only needed during parsing.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-topology.c | 20 ++--
sound/soc/intel/skylake/skl.h | 1 -
2 files changed, 10
From: Amadeusz Sławiński
For copying from __iomem, we should use __ioread32_copy.
reported by sparse:
sound/soc/intel/skylake/skl-debug.c:437:34: warning: incorrect type in argument
1 (different address spaces)
sound/soc/intel/skylake/skl-debug.c:437:34:expected void [noderef]
*to
sound
From: Amadeusz Sławiński
When we are printing module params, we were actually printing module id
instead of type, but debug message was saying that number we get is type.
So print module type, as it is useful when debugging paths, but also
keep printing module id, as it is used in all other logs
Hi,
this is last patch left from series fixing driver reload problems.
Rebased onto latest for-next in Marks tree.
Amadeusz Sławiński (1):
ASoC: Intel: Skylake: Remove static table index when parsing topology
sound/soc/intel/skylake/skl-topology.c | 34 +-
1 file
Currently when we remove and reload driver we use previous ref_count
value to start iterating over skl->modules which leads to out of table
access. To fix this just inline the function and calculate indexes
everytime we parse UUID token.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/in
ned-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-topology.c | 34 +-
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c
b/sound/soc/intel/skylake/skl-topology.c
index 6241e35213af..6f991af7af23 100
On Thu, 20 Jun 2019 08:17:33 +0200
Pierre-Louis Bossart wrote:
> > Could you please give a bit more context on what error you see
> > when this happens?
>
> Hi,
>
> I get Oops. This is what happens with all other patches in this
> series and only this one
On Tue, 18 Jun 2019 08:58:22 -0700
Ranjani Sridharan wrote:
> On Tue, 2019-06-18 at 13:00 +0200, Amadeusz Sławiński wrote:
> > On Mon, 17 Jun 2019 13:51:42 -0700
> > Ranjani Sridharan wrote:
> >
> > > On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński w
On Mon, 17 Jun 2019 13:51:42 -0700
Ranjani Sridharan wrote:
> On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote:
> > When we unload Skylake driver we may end up calling
> > hdac_component_master_unbind(), it uses acomp->audio_ops, which we
> > set
> > in
ferentiate, between them,
always assign bus->idx = 0;
This fixes a problem when we unload and reload machine driver idx gets
incremented, so .codec_name would've needed to be set to "ehdaudio1D2"
after first reload and so on.
Signed-off-by: Amadeusz Sławiński
---
sound/hda/ext/hdac_ex
s just use
data->avail_clk_cnt as index, so it can be reset back in
unregister_src_clk.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-ssp-clk.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c
b/sound/
Currently debugfs has no cleanup function. Add skl_debufs_exit function
so we can clean after ourselves properly.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-debug.c | 9 +
sound/soc/intel/skylake/skl.h | 5 +
2 files changed, 14 insertions(+)
diff --git
in it.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-pcm.c | 8 ++--
sound/soc/intel/skylake/skl-topology.c | 15 +++
sound/soc/intel/skylake/skl-topology.h | 2 ++
sound/soc/intel/skylake/skl.c | 2 --
4 files changed, 23 insertions(+), 4 deletions
Currently when we remove and reload driver we use previous ref_count
value to start iterating over skl->modules which leads to out of table
access. To fix this just inline the function and calculate indexes
everytime we parse UUID token.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/in
When we unload Skylake driver we may end up calling
hdac_component_master_unbind(), it uses acomp->audio_ops, which we set
in hdmi_codec_probe(), so we need to set it to NULL in hdmi_codec_remove(),
otherwise we will dereference no longer existing pointer.
Signed-off-by: Amadeusz Sławiń
Provide helper functions and use them to free dtexts and dvalues in
topology. This is followup cleanup after related changes in this area as
suggested in:
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-January/144761.html
Signed-off-by: Amadeusz Sławiński
---
sound/soc/soc
There are a few soc_tplg_dapm_widget_*_create functions with similar
content, but slightly different flow, unify their flow and make sure
that we go to error handler and free memory in case of failure.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/soc-topology.c | 77
reproducible with:
while true; do modprobe snd_soc_skl; rmmod snd_soc_skl; done
(with the assumption that relevant drivers are added to blacklist on
system boot)
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-pcm.c | 3 ---
sound/soc/intel/skylake/skl.c | 5 -
2 files
When we unload and reload machine driver, we shouldn't return that we
failed to initialize. This allows to reload machine driver, without
having to unload whole stack.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-pcm.c | 5 -
1 file changed, 5 deletions(-)
diff --git
patches to see what they do.
This series was tested on SKL, BXT, GLK & KBL.
Changes from previous patchset:
* followed suggetion by Pierre in "ALSA: hdac: Fix codec name after
machine driver is unloaded and reloaded"
* dropped patches which were merged
Amadeusz Sławiński (11):
Change kzalloc to devm_kzalloc, so compr gets automatically freed when
it's no longer needed.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/soc-compress.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
On Mon, 10 Jun 2019 09:17:21 +0200
Cezary Rojewski wrote:
> On 2019-06-05 15:45, Amadeusz Sławiński wrote:
> > When we remove component we need to reverse things which were done
> > on init, this consists of topology cleanup, lists cleanup and
> > releasing firmware.
>
On Thu, 6 Jun 2019 13:42:42 +0100
Srinivas Kandagatla wrote:
> This patch adds sidetone support via one of the 3 RX Mix paths
> using IIR1 and IIR2.
> IIR1 can be feed by any Decimators or RX paths, and IIRx can also be
> looped back to RX mixers to provide sidetone functionality.
> Two IIR
On Wed, 5 Jun 2019 10:06:47 -0500
Pierre-Louis Bossart wrote:
> On 6/5/19 8:45 AM, Amadeusz Sławiński wrote:
> > During the integration of HDaudio support, we changed the way in
> > which we get hdev in snd_hdac_ext_bus_device_init() to use one
> > preallocated with de
When component is being removed we should disable jack, otherwise some
codecs will try to trigger interrupt using freed structures.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/soc-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index
Provide helper functions and use them to free dtexts and dvalues in
topology. This is followup cleanup after related changes in this area as
suggested in:
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-January/144761.html
Signed-off-by: Amadeusz Sławiński
---
sound/soc/soc
From: Amadeusz Sławiński
This resets internal index used for enumarating codecs. This will only
work on assumption that platform has one codec. Anyway if there is more,
it won't work with current machine drivers, because we can't guarantee
order in which they are enumerated. This workarounds
reproducible with:
while true; do modprobe snd_soc_skl; rmmod snd_soc_skl; done
(with the assumption that relevant drivers are added to blacklist on
system boot)
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-pcm.c | 3 ---
sound/soc/intel/skylake/skl.c | 5 -
2 files
When we unload Skylake driver we may end up calling
hdac_component_master_unbind(), it uses acomp->audio_ops, which we set
in hdmi_codec_probe(), so we need to set it to NULL in hdmi_codec_remove(),
otherwise we will dereference no longer existing pointer.
Signed-off-by: Amadeusz Sławiń
When we unload and reload machine driver, we shouldn't return that we
failed to initialize. This allows to reload machine driver, without
having to unload whole stack.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-pcm.c | 5 -
1 file changed, 5 deletions(-)
diff --git
There are a few soc_tplg_dapm_widget_*_create functions with similar
content, but slightly different flow, unify their flow and make sure
that we go to error handler and free memory in case of failure.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/soc-topology.c | 77
s just use
data->avail_clk_cnt as index, so it can be reset back in
unregister_src_clk.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-ssp-clk.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c
b/sound/
t set it to NULL, next time the rt274_irq runs it will call
snd_soc_jack_report with first argument being invalid pointer and there
will be Oops.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/codecs/rt274.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs
Change kzalloc to devm_kzalloc, so compr gets automatically freed when
it's no longer needed.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/soc-compress.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c
Currently debugfs has no cleanup function. Add skl_debufs_exit function
so we can clean after ourselves properly.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-debug.c | 9 +
sound/soc/intel/skylake/skl.h | 5 +
2 files changed, 14 insertions(+)
diff --git
in it.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/intel/skylake/skl-pcm.c | 8 ++--
sound/soc/intel/skylake/skl-topology.c | 15 +++
sound/soc/intel/skylake/skl-topology.h | 2 ++
sound/soc/intel/skylake/skl.c | 2 --
4 files changed, 23 insertions(+), 4 deletions
Currently when we remove and reload driver we use previous ref_count
value to start iterating over skl->modules which leads to out of table
access. To fix this just inline the function and calculate indexes
everytime we parse UUID token.
Signed-off-by: Amadeusz Sławiński
---
sound/soc/in
from
snd_hdac_ext_bus_device_init")
Reviewed-by: Takashi Iwai
Signed-off-by: Amadeusz Sławiński
Signed-off-by: Pierre-Louis Bossart
---
sound/hda/ext/hdac_ext_bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c
index c203af71a099..f33ba58b7
ated patch on SOF side (with discussion):
https://mailman.alsa-project.org/pipermail/alsa-devel/2019-May/149640.html
It is included in this patchset for completeness.
Amadeusz Sławiński (14):
ASoC: Intel: Skylake: Initialize lists before access so they are safe
to use
ALSA: hdac: fix me
hda_widget_sysfs_reinit() can free underlying codec->widgets structure
on which widget_tree_create() operates. Add locking to prevent such
issues from happening.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110382
Signed-off-by: Amadeusz Sławiński
---
Changes since v1:
- Mo
hda_widget_sysfs_reinit() can free underlying codec->widgets structure
on which widget_tree_create() operates. Add locking to prevent such
issues from happening.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110382
Signed-off-by: Amadeusz Sławiński
---
include/sound/hdaudio.h |
fix typo after a recent commit causing headphones to have no sound
Fixes: ad43d528a7ac (ALSA: usb-audio: Define registers for CM6206)
Signed-off-by: Amadeusz Sławiński
---
sound/usb/quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/quirks.c b/sound/usb
Hey,
so I've been getting system instability problems after shutting down
virtual machine with GPU pass-through in 4.17-rc series and I finally
got around to bisecting it.
Seems to be caused by 356e88ebe4473a3663cf3d14727ce293a4526d34
and problem seems to be gone after reverting it.
trce from
Hey,
so I've been getting system instability problems after shutting down
virtual machine with GPU pass-through in 4.17-rc series and I finally
got around to bisecting it.
Seems to be caused by 356e88ebe4473a3663cf3d14727ce293a4526d34
and problem seems to be gone after reverting it.
trce from
cleanup to consolidate type used for len variables
Signed-off-by: Amadeusz Sławiński <amadeusz.slawin...@tieto.com>
---
drivers/net/wireless/ath/ath10k/core.c | 2 +-
drivers/net/wireless/ath/ath10k/debug.c| 49 +++---
drivers/net/wireless/ath/ath10k/spec
I wanted to take a look and it's apparently in other header
Signed-off-by: Amadeusz Sławiński <amadeusz.slawin...@tieto.com>
---
drivers/net/wireless/ath/ath10k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h
b/drivers/net/wi
cleanup to consolidate type used for len variables
Signed-off-by: Amadeusz Sławiński
---
drivers/net/wireless/ath/ath10k/core.c | 2 +-
drivers/net/wireless/ath/ath10k/debug.c| 49 +++---
drivers/net/wireless/ath/ath10k/spectral.c | 7 +++--
3 files changed, 29
I wanted to take a look and it's apparently in other header
Signed-off-by: Amadeusz Sławiński
---
drivers/net/wireless/ath/ath10k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h
b/drivers/net/wireless/ath/ath10k/wmi.h
index
it adds unnecessary level of indirection, while we just access structure
field
Signed-off-by: Amadeusz Sławiński <amadeusz.slawin...@tieto.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 68 +--
drivers/net/wireless/ath/ath10k/mac.h | 7 +---
drive
it adds unnecessary level of indirection, while we just access structure
field
Signed-off-by: Amadeusz Sławiński
---
drivers/net/wireless/ath/ath10k/mac.c | 68 +--
drivers/net/wireless/ath/ath10k/mac.h | 7 +---
drivers/net/wireless/ath/ath10k/p2p.c | 2
cleanup patch to make use of ieee80211_ac_from_tid() to retrieve ac from
ieee802_1d_to_ac[]
Signed-off-by: Amadeusz Sławiński <amadeusz.slawin...@tieto.com>
---
net/mac80211/rx.c | 2 +-
net/mac80211/status.c | 2 +-
net/mac80211/tx.c | 4 ++--
3 files changed, 4 insertions
cleanup patch to make use of ieee80211_ac_from_tid() to retrieve ac from
ieee802_1d_to_ac[]
Signed-off-by: Amadeusz Sławiński
---
net/mac80211/rx.c | 2 +-
net/mac80211/status.c | 2 +-
net/mac80211/tx.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/net
cleanup patch to make use of set_sta_flag()/clear_sta_flag() in places
where we access sta->_flags
Signed-off-by: Amadeusz Sławiński <amadeusz.slawin...@tieto.com>
---
net/mac80211/sta_info.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/mac80211/s
cleanup patch to make use of set_sta_flag()/clear_sta_flag() in places
where we access sta->_flags
Signed-off-by: Amadeusz Sławiński
---
net/mac80211/sta_info.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_inf
When we retrieve imtu value from userspace we should use 16 bit pointer
cast instead of 32 as it's defined that way in headers. Fixes setsockopt
calls on big-endian platforms.
Signed-off-by: Amadeusz Sławiński <amadeusz.slawin...@tieto.com>
---
net/bluetooth/l2cap_sock.c | 2 +-
1 file c
When we retrieve imtu value from userspace we should use 16 bit pointer
cast instead of 32 as it's defined that way in headers. Fixes setsockopt
calls on big-endian platforms.
Signed-off-by: Amadeusz Sławiński
---
net/bluetooth/l2cap_sock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
71 matches
Mail list logo
