Re: [PATCH] mlx5: avoid unused variable warning

2016-05-18 Thread Amir Vadai"
e ("net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef") > --- Acked-By: Amir Vadai <a...@vadai.me> Thanks Arnd.

Re: [PATCH] mlx5: avoid unused variable warning

2016-05-18 Thread Amir Vadai"
declared but not used here. I could not come up > with a nicer workaround, but this seems to do the trick. > > Signed-off-by: Arnd Bergmann > Fixes: aad7e08d39bd ("net/mlx5e: Hardware offloaded flower filter statistics > support") > Fixes: 00175aec941e ("net/sched: M

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc->affinity instead of irq_desc

2015-05-07 Thread Amir Vadai
On 5/5/2015 5:53 PM, Thomas Gleixner wrote: > On Tue, 5 May 2015, Amir Vadai wrote: > >> On Mon, May 4, 2015 at 6:10 PM, Thomas Gleixner wrote: >>> On Mon, 4 May 2015, Amir Vadai wrote: >>> >>>> On Mon, May 4, 2015 at 6:15 AM, Jiang Liu >>>&g

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc-affinity instead of irq_desc

2015-05-07 Thread Amir Vadai
On 5/5/2015 5:53 PM, Thomas Gleixner wrote: On Tue, 5 May 2015, Amir Vadai wrote: On Mon, May 4, 2015 at 6:10 PM, Thomas Gleixner t...@linutronix.de wrote: On Mon, 4 May 2015, Amir Vadai wrote: On Mon, May 4, 2015 at 6:15 AM, Jiang Liu jiang@linux.intel.com wrote: The field 'affinity

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc->affinity instead of irq_desc

2015-05-05 Thread Amir Vadai
On Mon, May 4, 2015 at 6:10 PM, Thomas Gleixner wrote: > On Mon, 4 May 2015, Amir Vadai wrote: > >> On Mon, May 4, 2015 at 6:15 AM, Jiang Liu wrote: >> > The field 'affinity' in irq_desc won't change once the irq_desc data >> > structure is created. So ca

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc->affinity instead of irq_desc

2015-05-05 Thread Amir Vadai
On Mon, May 4, 2015 at 5:00 PM, Jiang Liu wrote: > On 2015/5/4 20:10, Amir Vadai wrote: >> On Mon, May 4, 2015 at 6:15 AM, Jiang Liu wrote: >>> The field 'affinity' in irq_desc won't change once the irq_desc data >>> structure is created. So cache irq_desc-&g

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc-affinity instead of irq_desc

2015-05-05 Thread Amir Vadai
On Mon, May 4, 2015 at 5:00 PM, Jiang Liu jiang@linux.intel.com wrote: On 2015/5/4 20:10, Amir Vadai wrote: On Mon, May 4, 2015 at 6:15 AM, Jiang Liu jiang@linux.intel.com wrote: The field 'affinity' in irq_desc won't change once the irq_desc data structure is created. So cache

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc-affinity instead of irq_desc

2015-05-05 Thread Amir Vadai
On Mon, May 4, 2015 at 6:10 PM, Thomas Gleixner t...@linutronix.de wrote: On Mon, 4 May 2015, Amir Vadai wrote: On Mon, May 4, 2015 at 6:15 AM, Jiang Liu jiang@linux.intel.com wrote: The field 'affinity' in irq_desc won't change once the irq_desc data structure is created. So cache

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc->affinity instead of irq_desc

2015-05-04 Thread Amir Vadai
On Mon, May 4, 2015 at 6:15 AM, Jiang Liu wrote: > The field 'affinity' in irq_desc won't change once the irq_desc data > structure is created. So cache irq_desc->affinity instead of irq_desc. > This also helps to hide struct irq_desc from device drivers. Hi Jiang, I might not understand the

Re: [RFC v1 07/11] net/mlx4: Cache irq_desc-affinity instead of irq_desc

2015-05-04 Thread Amir Vadai
On Mon, May 4, 2015 at 6:15 AM, Jiang Liu jiang@linux.intel.com wrote: The field 'affinity' in irq_desc won't change once the irq_desc data structure is created. So cache irq_desc-affinity instead of irq_desc. This also helps to hide struct irq_desc from device drivers. Hi Jiang, I might

Re: [PATCH] mlx4_en: Use correct loop cursor in error path.

2015-04-30 Thread Amir Vadai
On Thu, Apr 30, 2015 at 1:59 AM, Benjamin Poirier wrote: > Signed-off-by: Benjamin Poirier > Fixes: 9e311e7 ("net/mlx4_en: Use affinity hint") > --- Good catch. Acked-by: Amir Vadai Thanks, Amir -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH] mlx4_en: Use correct loop cursor in error path.

2015-04-30 Thread Amir Vadai
On Thu, Apr 30, 2015 at 1:59 AM, Benjamin Poirier bpoir...@suse.de wrote: Signed-off-by: Benjamin Poirier bpoir...@suse.de Fixes: 9e311e7 (net/mlx4_en: Use affinity hint) --- Good catch. Acked-by: Amir Vadai am...@mellanox.com Thanks, Amir -- To unsubscribe from this list: send the line

Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits

2015-01-08 Thread Amir Vadai
On 1/6/2015 7:36 PM, David Decotigny wrote: > Interesting. It seems that the band-aid I was proposing is already > obsolete. We could still use the remaining reserved 16 bits to encode > 5 more bits per mask (that is: 53 bits / mask total). But if I > understand you, it would allow us to survive

Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits

2015-01-08 Thread Amir Vadai
On 1/6/2015 7:36 PM, David Decotigny wrote: Interesting. It seems that the band-aid I was proposing is already obsolete. We could still use the remaining reserved 16 bits to encode 5 more bits per mask (that is: 53 bits / mask total). But if I understand you, it would allow us to survive only

Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits

2015-01-06 Thread Amir Vadai
On 1/6/2015 4:54 AM, David Decotigny wrote: > This patch series increases the width of the supported/advertising > ethtool masks from 32 bits to 48. This should allow to breathe for a > couple more years (or... months?). Hi, Nice work. What worries me is that it is going to be for weeks more than

Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits

2015-01-06 Thread Amir Vadai
On 1/6/2015 4:54 AM, David Decotigny wrote: This patch series increases the width of the supported/advertising ethtool masks from 32 bits to 48. This should allow to breathe for a couple more years (or... months?). Hi, Nice work. What worries me is that it is going to be for weeks more than

Re: mlx4: don't duplicate kvfree()

2014-11-20 Thread Amir Vadai
kfree(buddy->bits[i]); > + kvfree(buddy->bits[i]); > > kfree(buddy->bits); > kfree(buddy->num_free); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.o

Re: mlx4: don't duplicate kvfree()

2014-11-20 Thread Amir Vadai
); -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ Thanks Al Acked-by: Amir Vadai am...@mellanox.com

Re: [PATCH net-next] mellanox: Change en_print to return void

2014-09-22 Thread Amir Vadai
anox/mlx4/en_main.c | 17 +++-- > drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 ++-- > 2 files changed, 9 insertions(+), 12 deletions(-) Thanks Joe. Acked-By: Amir Vadai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [PATCH net-next] mellanox: Change en_print to return void

2014-09-22 Thread Amir Vadai
+++-- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 ++-- 2 files changed, 9 insertions(+), 12 deletions(-) Thanks Joe. Acked-By: Amir Vadai am...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-02 Thread Amir Vadai
On 6/2/2014 8:13 AM, Eric Dumazet wrote: On Sun, 2014-06-01 at 21:56 -0700, David Miller wrote: Indeed you have to provide a dummy version for a non-SMP build etc. I'm reverting. Hi David. I think your revert took one wrong commit. # git show ee39facbf82e73e468c504d2b40e83e2d223c28c |

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-02 Thread Amir Vadai
On 6/2/2014 8:13 AM, Eric Dumazet wrote: On Sun, 2014-06-01 at 21:56 -0700, David Miller wrote: Indeed you have to provide a dummy version for a non-SMP build etc. I'm reverting. Hi David. I think your revert took one wrong commit. # git show ee39facbf82e73e468c504d2b40e83e2d223c28c |

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-27 Thread Amir Vadai
On 5/26/2014 3:39 PM, Thomas Gleixner wrote: [...] The rmap _IS_ instantiated by the driver, and both the driver and the networking core know about it. So it's not completely different consumers. Just because it's a library does not mean it's disjunct from the code which uses it. Aside of

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-27 Thread Amir Vadai
On 5/26/2014 3:39 PM, Thomas Gleixner wrote: [...] The rmap _IS_ instantiated by the driver, and both the driver and the networking core know about it. So it's not completely different consumers. Just because it's a library does not mean it's disjunct from the code which uses it. Aside of

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Amir Vadai
On 5/26/2014 2:34 PM, Thomas Gleixner wrote: On Mon, 26 May 2014, Amir Vadai wrote: On 5/26/2014 2:15 PM, Thomas Gleixner wrote: On Sun, 25 May 2014, Amir Vadai wrote: In order to do that, I need to add a new irq affinity notification callback (In addition to the existing cpu_rmap

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Amir Vadai
On 5/26/2014 2:15 PM, Thomas Gleixner wrote: On Sun, 25 May 2014, Amir Vadai wrote: In order to do that, I need to add a new irq affinity notification callback (In addition to the existing cpu_rmap notification). For that I would like to extend irq_set_affinity_notifier() to have a notifier

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Amir Vadai
On 5/26/2014 2:15 PM, Thomas Gleixner wrote: On Sun, 25 May 2014, Amir Vadai wrote: In order to do that, I need to add a new irq affinity notification callback (In addition to the existing cpu_rmap notification). For that I would like to extend irq_set_affinity_notifier() to have a notifier

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-26 Thread Amir Vadai
On 5/26/2014 2:34 PM, Thomas Gleixner wrote: On Mon, 26 May 2014, Amir Vadai wrote: On 5/26/2014 2:15 PM, Thomas Gleixner wrote: On Sun, 25 May 2014, Amir Vadai wrote: In order to do that, I need to add a new irq affinity notification callback (In addition to the existing cpu_rmap

[PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-05-25 Thread Amir Vadai
cores close to it. To accomplish this, we use cpumask_set_cpu_local_first(), that sets the affinity hint according the following policy: First it maps IRQs to “close” numa cores. If these are exhausted, the remaining IRQs are mapped to “far” numa cores. Signed-off-by: Yuval Atias Signed-off-by: Amir

[PATCH net-next V6 0/2] cpumask,net: Affinity hint helper function

2014-05-25 Thread Amir Vadai
h 1/2: net: Utility function to get affinity_hint by policy - Fixed error flow to return -EINVAL on error (thanks govind) - Patch 2/2: net/mlx4_en: Use affinity hint - Set ring->affinity_hint to NULL on error Changes from V0: - Fixed small style issues Amir Vadai (1): cpumask: Utility functio

[PATCH net-next V6 1/2] cpumask: Utility function to set n'th cpu - local cpu first

2014-05-25 Thread Amir Vadai
networking devices to calculate the irq affinity mask, such that as many local cpu's as possible will be utilized to handle the mq device irq's. Signed-off-by: Amir Vadai --- include/linux/cpumask.h | 2 ++ lib/cpumask.c | 64 + 2 files chan

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-25 Thread Amir Vadai
On 5/25/2014 3:15 PM, Amir Vadai wrote: Hi, I'm working for Mellanox on mlx4_en NIC driver. We need to be able to be notified on irq affinity changes. This is because, during non-stop full bandwidth traffic, napi will poll constantly and no interrupt will be fired. Because of that, even

Extend irq_set_affinity_notifier() to use a call chain

2014-05-25 Thread Amir Vadai
Hi, I'm working for Mellanox on mlx4_en NIC driver. We need to be able to be notified on irq affinity changes. This is because, during non-stop full bandwidth traffic, napi will poll constantly and no interrupt will be fired. Because of that, even if the user changes the irq affinity, polling

Extend irq_set_affinity_notifier() to use a call chain

2014-05-25 Thread Amir Vadai
Hi, I'm working for Mellanox on mlx4_en NIC driver. We need to be able to be notified on irq affinity changes. This is because, during non-stop full bandwidth traffic, napi will poll constantly and no interrupt will be fired. Because of that, even if the user changes the irq affinity, polling

Re: Extend irq_set_affinity_notifier() to use a call chain

2014-05-25 Thread Amir Vadai
On 5/25/2014 3:15 PM, Amir Vadai wrote: Hi, I'm working for Mellanox on mlx4_en NIC driver. We need to be able to be notified on irq affinity changes. This is because, during non-stop full bandwidth traffic, napi will poll constantly and no interrupt will be fired. Because of that, even

[PATCH net-next V6 0/2] cpumask,net: Affinity hint helper function

2014-05-25 Thread Amir Vadai
function to get affinity_hint by policy - Fixed error flow to return -EINVAL on error (thanks govind) - Patch 2/2: net/mlx4_en: Use affinity hint - Set ring-affinity_hint to NULL on error Changes from V0: - Fixed small style issues Amir Vadai (1): cpumask: Utility function to set n'th cpu

[PATCH net-next V6 1/2] cpumask: Utility function to set n'th cpu - local cpu first

2014-05-25 Thread Amir Vadai
to calculate the irq affinity mask, such that as many local cpu's as possible will be utilized to handle the mq device irq's. Signed-off-by: Amir Vadai am...@mellanox.com --- include/linux/cpumask.h | 2 ++ lib/cpumask.c | 64 + 2 files changed, 66

[PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-05-25 Thread Amir Vadai
yuv...@mellanox.com Signed-off-by: Amir Vadai am...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 6 +- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 30 ++ drivers/net/ethernet/mellanox/mlx4

[PATCH net-next] genirq: Eliminate explicit dependency between IRQ affinity notifiers and CONFIG_SMP

2014-05-20 Thread Amir Vadai
SMP configuration. Fixes: 2eacc23 ("net/mlx4_core: Enforce irq affinity changes immediatly") Signed-off-by: Eyal Perry Signed-off-by: Amir Vadai --- include/linux/interrupt.h | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-)

[PATCH net-next] genirq: Eliminate explicit dependency between IRQ affinity notifiers and CONFIG_SMP

2014-05-20 Thread Amir Vadai
for irq_set_affinity_notifier() under non SMP configuration. Fixes: 2eacc23 (net/mlx4_core: Enforce irq affinity changes immediatly) Signed-off-by: Eyal Perry eya...@mellanox.com Signed-off-by: Amir Vadai am...@mellanox.com --- include/linux/interrupt.h | 46 ++ 1 file

Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()

2014-05-18 Thread Amir Vadai
, variable 'port_up' is left uninitialized and the behaviour is undetermined. Detected by Coverity - CID 751497. Signed-off-by: Christian Engelmayer --- Acked-By: Amir Vadai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH] net/mlx4_en: Fix uninitialized use of 'port_up' in mlx4_en_set_channels()

2014-05-18 Thread Amir Vadai
, variable 'port_up' is left uninitialized and the behaviour is undetermined. Detected by Coverity - CID 751497. Signed-off-by: Christian Engelmayer cenge...@gmx.at --- Acked-By: Amir Vadai am...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] mellanox: Logging message cleanups

2014-05-05 Thread Amir Vadai
;phy_wqe_gid is " -"enforced on this ib port\n"); + mlx4_err(dev, "phy_wqe_gid is enforced on this ib port\n"); err = -EPROTONOSUPPORT; goto out; } [...] Acked-By: Amir Vadai Thanks, Amir -

Re: [PATCH] mellanox: Logging message cleanups

2014-05-05 Thread Amir Vadai
is -enforced on this ib port\n); + mlx4_err(dev, phy_wqe_gid is enforced on this ib port\n); err = -EPROTONOSUPPORT; goto out; } [...] Acked-By: Amir Vadai am...@mellanox.com Thanks, Amir

[PATCH net-next V5 0/2] irq,net: Affinity hint helper function

2014-03-11 Thread Amir Vadai
Changes from V0: - Fixed small style issues Amir Vadai (1): irq: Utility function to get affinity_hint by policy Yuval Atias (1): net/mlx4_en: Use affinity hint drivers/infiniband/hw/mlx4/main.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 6 ++- drivers/net/ethe

[PATCH net-next V5 1/2] irq: Utility function to get affinity_hint by policy

2014-03-11 Thread Amir Vadai
Bhargava CC: Govindarajulu Varadarajan Signed-off-by: Amir Vadai --- include/linux/interrupt.h | 9 kernel/irq/manage.c | 58 +++ 2 files changed, 67 insertions(+) diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h index

[PATCH net-next V5 2/2] net/mlx4_en: Use affinity hint

2014-03-11 Thread Amir Vadai
-by: Amir Vadai --- drivers/infiniband/hw/mlx4/main.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 6 +- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 30 ++ drivers/net/ethernet/mellanox/mlx4/eq.c| 14 +++- drivers/net/ethernet

[PATCH net-next V5 1/2] irq: Utility function to get affinity_hint by policy

2014-03-11 Thread Amir Vadai
Bhargava pra...@redhat.com CC: Govindarajulu Varadarajan gvara...@cisco.com Signed-off-by: Amir Vadai am...@mellanox.com --- include/linux/interrupt.h | 9 kernel/irq/manage.c | 58 +++ 2 files changed, 67 insertions(+) diff --git

[PATCH net-next V5 2/2] net/mlx4_en: Use affinity hint

2014-03-11 Thread Amir Vadai
Atias yuv...@mellanox.com Signed-off-by: Amir Vadai am...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 6 +- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 30 ++ drivers/net/ethernet/mellanox

[PATCH net-next V5 0/2] irq,net: Affinity hint helper function

2014-03-11 Thread Amir Vadai
: - Fixed small style issues Amir Vadai (1): irq: Utility function to get affinity_hint by policy Yuval Atias (1): net/mlx4_en: Use affinity hint drivers/infiniband/hw/mlx4/main.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_cq.c | 6 ++- drivers/net/ethernet/mellanox/mlx4

[PATCH net-next] net/mlx4_en: mlx4_en_verify_params() can be static

2014-03-05 Thread Amir Vadai
it be static? CC: net...@vger.kernel.org CC: linux-kernel@vger.kernel.org CC: Eugenia Emantayev Signed-off-by: Fengguang Wu Signed-off-by: Amir Vadai --- drivers/net/ethernet/mellanox/mlx4/en_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4

[PATCH net-next] net/mlx4_en: mlx4_en_verify_params() can be static

2014-03-05 Thread Amir Vadai
' was not declared. Should it be static? CC: net...@vger.kernel.org CC: linux-kernel@vger.kernel.org CC: Eugenia Emantayev euge...@mellanox.com Signed-off-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Amir Vadai am...@mellanox.com --- drivers/net/ethernet/mellanox/mlx4/en_main.c | 2 +- 1 file

Re: mlx4_core: DMA-API: device driver tries to sync DMA memory it has not allocated

2014-02-27 Thread Amir Vadai
On 10/12/13 14:44 +0100, Gerald Schaefer wrote: > Hi, > > During network stress test with CONFIG_DMA_API_DEBUG=y we get the following > message on the server side: > > [57523.955982] mlx4_core :00:00.0: DMA-API: device driver tries to sync > DMA memory it has not allocated [device

Re: mlx4_core: DMA-API: device driver tries to sync DMA memory it has not allocated

2014-02-27 Thread Amir Vadai
On 10/12/13 14:44 +0100, Gerald Schaefer wrote: Hi, During network stress test with CONFIG_DMA_API_DEBUG=y we get the following message on the server side: [57523.955982] mlx4_core :00:00.0: DMA-API: device driver tries to sync DMA memory it has not allocated [device

Re: ixgbevf: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread Amir Vadai
On 18/02/14 14:01 +0200, Amir Vadai wrote: > On 18/02/14 11:11 +0100, Alexander Gordeev wrote: > > As result of deprecation of MSI-X/MSI enablement functions > > pci_enable_msix() and pci_enable_msi_block() all drivers > > using these two interfaces need to be updat

Re: ixgbevf: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread Amir Vadai
> interfaces. > > Signed-off-by: Alexander Gordeev > Cc: Jeff Kirsher > Cc: Jesse Brandeburg > Cc: Bruce Allan > Cc: e1000-de...@lists.sourceforge.net > Cc: net...@vger.kernel.org > Cc: linux-...@vger.kernel.org > --- Acked-By: Amir Vadai -- To unsubscribe from t

Re: ixgbevf: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread Amir Vadai
-By: Amir Vadai am...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: ixgbevf: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread Amir Vadai
On 18/02/14 14:01 +0200, Amir Vadai wrote: On 18/02/14 11:11 +0100, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new

Re: mlx4: Use pci_enable_msix_range()

2014-02-02 Thread Amir Vadai
> interfaces. > > Signed-off-by: Alexander Gordeev > --- > drivers/net/ethernet/mellanox/mlx4/main.c | 19 --- > 1 files changed, 4 insertions(+), 15 deletions(-) > Acked By: Amir Vadai -- To unsubscribe from this list: send the line "unsubscribe

Re: mlx4: Use pci_enable_msix_range()

2014-02-02 Thread Amir Vadai
. Signed-off-by: Alexander Gordeev agord...@redhat.com --- drivers/net/ethernet/mellanox/mlx4/main.c | 19 --- 1 files changed, 4 insertions(+), 15 deletions(-) Acked By: Amir Vadai am...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: net/mlx4_core: clean up two functions

2014-01-13 Thread Amir Vadai
On 13/01/14 11:13 -0800, David Miller wrote: > From: Paul Bolle > Date: Tue, 07 Jan 2014 14:00:22 +0100 > > > 0) These two patches are very similar. They both clean up a function to > > help GCC understand the codeflow. Both help silence a warning. > > > > 1) Compile tested only (on 32 bits

Re: net/mlx4_core: clean up two functions

2014-01-13 Thread Amir Vadai
On 13/01/14 11:13 -0800, David Miller wrote: From: Paul Bolle pebo...@tiscali.nl Date: Tue, 07 Jan 2014 14:00:22 +0100 0) These two patches are very similar. They both clean up a function to help GCC understand the codeflow. Both help silence a warning. 1) Compile tested only (on 32

Re: net: mlx4: slight optimization of addr compare

2013-12-29 Thread Amir Vadai
On 27/12/13 14:48 +0800, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > to instead of memcmp. > > Cc: Amir Vadai > Signed-off-by: Ding Tianhong > --- > drivers/net/ethernet/mellanox/mlx4/en_netdev.c| 4 ++-- > drivers/net/ethernet/mellanox

Re: net: mlx4: slight optimization of addr compare

2013-12-29 Thread Amir Vadai
On 27/12/13 14:48 +0800, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal to instead of memcmp. Cc: Amir Vadai am...@mellanox.com Signed-off-by: Ding Tianhong dingtianh...@huawei.com --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c| 4 ++-- drivers/net/ethernet

Re: [PATCH RFC net-next] net: epoll support for busy poll

2013-08-27 Thread Amir Vadai
On 26/08/2013 09:03, Eliezer Tamir wrote: > On 26/08/2013 00:30, Amir Vadai wrote: >> I'm on vacation, will test and have some inputs later this week when I be >> back. >> > Hello Amir, > > Ping me when you get back and I will send you my latest so you can > play

Re: [PATCH RFC net-next] net: epoll support for busy poll

2013-08-27 Thread Amir Vadai
On 26/08/2013 09:03, Eliezer Tamir wrote: On 26/08/2013 00:30, Amir Vadai wrote: I'm on vacation, will test and have some inputs later this week when I be back. Hello Amir, Ping me when you get back and I will send you my latest so you can play with it. Hi Eliezer, You can send

Re: [PATCH] sockperf: add SO_LL socketop support

2013-06-12 Thread Amir Vadai
On 11/06/2013 17:26, Eliezer Tamir wrote: > Add lls socket option support to sockperf. > Right now we always get the option before set to show the option is > working properly. We should probably remove that in an official release. > use --lls (value in usecs) to override global setting. > --- >

Re: [PATCH] sockperf: add SO_LL socketop support

2013-06-12 Thread Amir Vadai
On 11/06/2013 17:26, Eliezer Tamir wrote: Add lls socket option support to sockperf. Right now we always get the option before set to show the option is working properly. We should probably remove that in an official release. use --lls (value in usecs) to override global setting. ---

Re: [PATCH v8 net-next 2/7] net: add low latency socket poll

2013-06-03 Thread Amir Vadai
On 03/06/2013 11:01, Eliezer Tamir wrote: > diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c > index 741db5fc..ae98c95 100644 > --- a/net/core/sysctl_net_core.c > +++ b/net/core/sysctl_net_core.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > >

Re: [PATCH v8 net-next 0/7] net: low latency Ethernet device polling

2013-06-03 Thread Amir Vadai
Acked-By: Amir Vadai Nice work Eliezer :) On 03/06/2013 11:01, Eliezer Tamir wrote: > David, > > Here is v8 with yet more fixes. > > Please consider applying. > > Thanks to everyone for their input. > > -Eliezer > > change log: > v8 > - split out ud

Re: [PATCH v8 net-next 0/7] net: low latency Ethernet device polling

2013-06-03 Thread Amir Vadai
Acked-By: Amir Vadai am...@mellanox.com Nice work Eliezer :) On 03/06/2013 11:01, Eliezer Tamir wrote: David, Here is v8 with yet more fixes. Please consider applying. Thanks to everyone for their input. -Eliezer change log: v8 - split out udp and select/poll into seperate

Re: [PATCH v8 net-next 2/7] net: add low latency socket poll

2013-06-03 Thread Amir Vadai
On 03/06/2013 11:01, Eliezer Tamir wrote: diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 741db5fc..ae98c95 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -19,6 +19,7 @@ #include net/ip.h #include net/sock.h #include

Re: [PATCH v7 net-next 2/5] net: implement support for low latency socket polling

2013-05-30 Thread Amir Vadai
On 30/05/2013 14:41, Eliezer Tamir wrote: > diff --git a/fs/select.c b/fs/select.c > index 8c1c96c..f116bf0 100644 > --- a/fs/select.c > +++ b/fs/select.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > > #include > > @@ -400,6 +401,7 @@ int do_select(int n,

Re: [PATCH v7 net-next 2/5] net: implement support for low latency socket polling

2013-05-30 Thread Amir Vadai
On 30/05/2013 14:41, Eliezer Tamir wrote: diff --git a/fs/select.c b/fs/select.c index 8c1c96c..f116bf0 100644 --- a/fs/select.c +++ b/fs/select.c @@ -27,6 +27,7 @@ #include linux/rcupdate.h #include linux/hrtimer.h #include linux/sched/rt.h +#include net/ll_poll.h #include

Re: [PATCH 85/86] mlx4_en: fix allocation of CPU affinity reverse-map

2013-03-28 Thread Amir Vadai
This fix introduced a bug in SRIOV. Should squash into it, the upstream commit: f74d525bc973f2003b55b1f71f377e31fb5d3c8b - "net/mlx4_en: Disable RFS in SRIOV virtual functions" Thanks, Amir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 85/86] mlx4_en: fix allocation of CPU affinity reverse-map

2013-03-28 Thread Amir Vadai
This fix introduced a bug in SRIOV. Should squash into it, the upstream commit: f74d525bc973f2003b55b1f71f377e31fb5d3c8b - net/mlx4_en: Disable RFS in SRIOV virtual functions Thanks, Amir -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: linux-next: build failure after merge of the akpm tree

2013-02-11 Thread Amir Vadai
rcu_read_lock(); > - hlist_for_each_entry_rcu(entry, n, bucket, > hlist) { > + hlist_for_each_entry_rcu(entry, bucket, hlist) { > if (ether_addr_equal_64bits(entry->mac, >

Re: linux-next: build failure after merge of the akpm tree

2013-02-11 Thread Amir Vadai
) { if (ether_addr_equal_64bits(entry-mac, ethh-h_source)) { rcu_read_unlock(); Acked-By: Amir Vadai am...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

2013-01-07 Thread Amir Vadai
/cpu_rmap.c| 63 + 3 files changed, 62 insertions(+), 19 deletions(-) Acked-by: Amir Vadai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

2013-01-07 Thread Amir Vadai
/cpu_rmap.c| 63 + 3 files changed, 62 insertions(+), 19 deletions(-) Acked-by: Amir Vadai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

2013-01-07 Thread Amir Vadai
|5 lib/cpu_rmap.c| 63 + 3 files changed, 62 insertions(+), 19 deletions(-) Acked-by: Amir Vadai am...@mellano.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v4] lib: cpu_rmap: avoid flushing all workqueues

2013-01-07 Thread Amir Vadai
|5 lib/cpu_rmap.c| 63 + 3 files changed, 62 insertions(+), 19 deletions(-) Acked-by: Amir Vadai am...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord