On Thu, Nov 26, 2020 at 2:16 AM Ansuel Smith wrote:
> > > };
> > > @@ -441,6 +442,10 @@ enum regfield_ids {
> > > CRIT_THRESH_14,
> > > CRIT_THRESH_15,
> > >
> > > + /* VER_0 MIN MAX THRESH */
> > > + MIN_THRESH_0,
> > > + MAX_THRESH_0,
> > > +
> >
> > Consider
Hi Ansuel,
See comments inline.
On Fri, Aug 14, 2020 at 7:12 PM Ansuel Smith wrote:
>
> VER_0 is used to describe device based on tsens version before v0.1.
> These device are devices based on msm8960 for example apq8064 or
> ipq806x.
>
> Signed-off-by: Ansuel Smith
> ---
>
Hi Ansuel,
My apologies for being tardy in reviewing this series. Career changes...
On Fri, Aug 14, 2020 at 7:12 PM Ansuel Smith wrote:
>
> Use the driver get_temp function instead of force to use the generic get
> temp function. This is needed as tsens v0 version use a custom function
> to get
Hi Ansuel,
Just a quick note to say that I'm not ignoring this, just on
vacations. I'll be back to review this in a few days.
Regards,
Amit
On Fri, Aug 14, 2020 at 7:12 PM Ansuel Smith wrote:
>
> This patchset convert msm8960 to reg_filed, use int_common instead
> of a custom function and fix
Fix up documentation of the struct members to reflect reality. Also
fixup a stray whitespace.
Signed-off-by: Amit Kucheria
---
include/linux/powercap.h | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/include/linux/powercap.h b/include/linux/powercap.h
index
sm8250 has 24 thermal sensors split across two tsens controllers. Add
the thermal zones to expose them and wireup the cpus to throttle on
crossing passive temperature thresholds.
Signed-off-by: Amit Kucheria
---
Depends on
https://lore.kernel.org/r/20200908075716.30357-1-manivannan.sadhasi
er. When an allocated power budget is
> not used by a device, the siblings can share this free power until the
> device needs more power.
>
> The algorithm was presented during the ELC:
>
> https://ossna2020.sched.com/event/c3Wf/ideas-for-finer-grained-control-over-your-heat
On Tue, Sep 8, 2020 at 1:27 PM Manivannan Sadhasivam
wrote:
>
> devm_platform_ioremap_resource() is the combination of
> platform_get_resource() and devm_ioremap_resource(). Hence, use it to
> simplify the code a bit.
>
> Signed-off-by: Manivannan Sadhasivam
Reviewed
On Tue, Sep 8, 2020 at 8:40 PM Manivannan Sadhasivam
wrote:
>
> On 0908, Amit Kucheria wrote:
> > On Tue, Sep 8, 2020 at 1:27 PM Manivannan Sadhasivam
> > wrote:
> > >
> > > For preparing the driver to handle further SoC revisions, let's use the
> &
On Tue, Sep 8, 2020 at 1:27 PM Manivannan Sadhasivam
wrote:
>
> From: Bjorn Andersson
>
> Add cpufreq HW device node to scale 4-Silver/3-Gold/1-Gold+ cores
> on SM8250 SoCs.
>
> Signed-off-by: Bjorn Andersson
> Signed-off-by: Manivannan Sadhasivam
Reviewed-by: Amit K
On Tue, Sep 8, 2020 at 5:18 PM Amit Kucheria wrote:
>
> On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote:
> >
> > On 08-09-20, 16:41, Manivannan Sadhasivam wrote:
> > > On 0908, Viresh Kumar wrote:
> > > > On 08-09-20, 13:27, Manivannan Sadhasivam wr
On Tue, Sep 8, 2020 at 1:27 PM Manivannan Sadhasivam
wrote:
>
> Document the SM8250 SoC specific compatible for Qualcomm Cpufreq HW. The
> hardware block which carries out CPUFreq operations on SM8250 SoC is
> called EPSS.
>
> Signed-off-by: Manivannan Sadhasivam
Reviewed
On Tue, Sep 8, 2020 at 1:27 PM Manivannan Sadhasivam
wrote:
>
> For preparing the driver to handle further SoC revisions, let's use the
> of_match data for getting the device specific offsets and row size instead
> of defining them globally.
>
> Signed-off-by: Manivannan Sadhasivam
> ---
>
On Tue, Sep 8, 2020 at 1:27 PM Manivannan Sadhasivam
wrote:
>
> SM8250 SoC uses EPSS block for carrying out the cpufreq duties. Hence, add
> support for it in the driver with relevant of_match data.
>
> Signed-off-by: Manivannan Sadhasivam
Reviewed-by: Amit Kucheria
> ---
On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote:
>
> On 08-09-20, 16:41, Manivannan Sadhasivam wrote:
> > On 0908, Viresh Kumar wrote:
> > > On 08-09-20, 13:27, Manivannan Sadhasivam wrote:
> > > > Use regmap for accessing cpufreq registers in hardware.
> > >
> > > Why ? Please mention why a
ature.
>
> However, ->get_max_state of backlight will assign max brightness of 1024
> to states. The memory size can be getting 1MB+ due to states * states.
> That is so large to trigger kmalloc() warning.
>
> So, let's use kvzalloc() to avoid the issue, also change kfree -&g
On Wed, Jul 15, 2020 at 12:25 PM wrote:
>
> From: Yuantian Tang
>
> There are 7 thermal zones in ls208xa soc. Add the other thermal zone
> nodes to enable them.
>
> Signed-off-by: Yuantian Tang
Reviewed-by: Amit Kucheria
> ---
> v2:
> - remove usel
igned-off-by: Yuantian Tang
Reviewed-by: Amit Kucheria
> ---
> v2:
> - remove useless alert trip
>
> .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 94 +++
> 1 file changed, 56 insertions(+), 38 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/
On Tue, Aug 18, 2020 at 12:00 PM Yue Hu wrote:
>
> From: Yue Hu
>
> We observed warning about kzalloc() when register thermal cooling device
> in backlight_device_register(). backlight display can be a cooling device
> since reducing screen brightness will can help reduce temperature.
>
>
On Tue, Aug 18, 2020 at 12:00 PM Yue Hu wrote:
>
> From: Yue Hu
>
> We observed warning about kzalloc() when register thermal cooling device
> in backlight_device_register(). backlight display can be a cooling device
> since reducing screen brightness will can help reduce temperature.
>
>
On Tue, Aug 11, 2020 at 6:48 PM wrote:
>
>
>
> > -Messaggio originale-----
> > Da: Amit Kucheria
> >
> > > if (IS_ERR(priv->rf[i]))
> > > return PTR_ERR(priv->rf[i]);
> > &
On Sat, Jul 25, 2020 at 11:44 PM Ansuel Smith wrote:
>
> Covert msm9860 driver to reg_filed to use the init_common
typo: field
> function.
>
> Signed-off-by: Ansuel Smith
> ---
> drivers/thermal/qcom/tsens-8960.c | 74 +++
> 1 file changed, 74 insertions(+)
>
>
On Sat, Jul 25, 2020 at 11:44 PM Ansuel Smith wrote:
>
> VER_0 is used to describe device based on tsens version before v0.1.
> These device are devices based on msm8960 for example apq8064 or
> ipq806x.
>
> Signed-off-by: Ansuel Smith
> ---
> drivers/thermal/qcom/tsens.c | 160
On Thu, Jul 30, 2020 at 11:40 AM Viresh Kumar wrote:
>
> On 30-07-20, 11:29, Amit Kucheria wrote:
> > On Thu, Jul 30, 2020 at 9:38 AM Viresh Kumar
> > wrote:
> > >
> > > It is not possible for cached_resolved_idx to be invalid here as the
> > > cpufr
On Thu, Jul 30, 2020 at 9:38 AM Viresh Kumar wrote:
>
> It is not possible for cached_resolved_idx to be invalid here as the
> cpufreq core always sets index to a positive value.
>
> Change its type to unsigned int and fix qcom usage a bit.
Shouldn't you fix up idx in
On Tue, Jul 28, 2020 at 4:40 AM Daniel Lezcano
wrote:
>
> Now the calls to enable/disable a thermal zone are centralized in a
> call to a function, we can add in these the corresponding netlink
> notifications.
>
> Signed-off-by: Daniel Lezcano
Reviewed-by: Amit Kucheria
gt; the MAINTAINERS entry.
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains:
>
> warning: no file matchesF:drivers/thermal/power_allocator.c
>
> Update the file entry in MAINTAINERS to the new file name.
>
> Signed-off-by: Lukas Bulwahn
Acked-by: Ami
On Wed, Jul 22, 2020 at 12:52 AM wrote:
>
>
>
> > -Messaggio originale-----
> > Da: Amit Kucheria
> > Inviato: lunedì 20 luglio 2020 11:41
> > A: Ansuel Smith
> > Cc: Rob Herring ; Andy Gross ;
> > Bjorn Andersson ; Zhang Rui
> > ; Da
e kind of
> clarity.
>
> Reported-by: Randy Dunlap
> Signed-off-by: Daniel Lezcano
Reviewed-by: Amit Kucheria
> ---
> drivers/thermal/Kconfig | 10
> drivers/thermal/Makefile | 5 +-
> drivers/thermal/thermal_core.h| 20 +--
> drivers/thermal
On Tue, Jul 21, 2020 at 11:27 AM Amit Kucheria wrote:
>
>
>
> On Tue, 21 Jul, 2020, 05:06 Stephen Boyd, wrote:
>>
>> Quoting Amit Kucheria (2020-07-20 02:41:44)
>> > On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith wrote:
>> > >
>> > &
On Mon, Jul 20, 2020 at 5:13 PM Amit Kucheria wrote:
>
> Now that we have yaml bindings for the thermal subsystem, get rid of the
> old bindings (thermal.txt).
>
> Replace all references to thermal.txt in the Documentation with a link
> to the appropriate YAML bindings using th
to the thermal-sensor-cells property,
replace with a pointer to thermal-sensor.yaml
- If the reference is to the cooling-cells property, replace with a
pointer to thermal-cooling-devices.yaml
- If the reference is generic thermal bindings, replace with a
reference to thermal*.yaml.
Signed-off-by: Amit
On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith wrote:
>
> Document the use of bindings used for ipq8064 SoCs tsens.
> ipq8064 use the same gcc regs and is set as a child of the qcom gcc.
>
> Signed-off-by: Ansuel Smith
> ---
> .../bindings/thermal/qcom-tsens.yaml | 50 ---
Hi Ansuel,
On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith wrote:
>
> Add custom set_trip function for 8960 needed to set trip point to the
> tsens driver for 8960 driver.
Please describe why it needs a custom function please.
>
> Signed-off-by: Ansuel Smith
> ---
>
On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith wrote:
>
> Devices based on 8060 tsens driver (ipq8064) use the reg of the gcc
typo: 8960
> driver. Try to load the regmap of the parent as they share the same
> regs.
>
> Signed-off-by: Ansuel Smith
> ---
> drivers/thermal/qcom/tsens-8960.c | 12
On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith wrote:
>
> Add support for child probing needed for tsens driver that share the
> seme regs of gcc for this platform.
Typo: same
>
> Signed-off-by: Ansuel Smith
> ---
> drivers/clk/qcom/gcc-ipq806x.c | 2 +-
> 1 file changed, 1 insertion(+), 1
Hi Ansuel,
Thanks for this patch.
On Thu, Jul 16, 2020 at 7:58 AM Ansuel Smith wrote:
>
> Add interrupt support for 9860 tsens driver used to set thermal trip
> point for the system.
typo: 8960
You've used the names 8960 and ipq8064 interchangeably throughout the
series. AFAICT, msm8960,
Marek Szyprowski
> Signed-off-by: Daniel Lezcano
Reviewed-by: Amit Kucheria
> ---
> drivers/thermal/thermal_core.c| 4
> drivers/thermal/thermal_netlink.c | 3 +--
> drivers/thermal/thermal_netlink.h | 6 ++
> 3 files changed, 11 insertions(+), 2 deletions(-)
&
fs_initcall since we had
removed netlink support from the thermal framework and we wanted to
initialise it as quickly as possible after cpufreq to allow early
mitigation possibility.
Given the addition of the new netlink-based API to thermal framework,
I think moving to postcore_initcall is an acceptable compromise.
Reviewed-by: Amit Kucheria
> --
> 2.17.1
>
the generic netlink
> family to the core_initcall and comes after the netlink protocol
> initialization.
>
> Signed-off-by: Daniel Lezcano
Reviewed-by: Amit Kucheria
> ---
> net/netlink/genetlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netli
t; Signed-off-by: Daniel Lezcano
Reviewed-by: Amit Kucheria
> ---
> drivers/thermal/thermal_core.c| 21 +
> drivers/thermal/thermal_helpers.c | 11 +--
> drivers/thermal/thermal_sysfs.c | 15 ++-
> 3 files changed, 44 insertions(+),
gt; thermal zone temperature sampling.
>
> Also, a list of commands to discover the thermal setup is added and
> can be extended when needed.
>
> Signed-off-by: Daniel Lezcano
Reviewed-by: Amit Kucheria
> ---
> v3:
> - Fixed changelog from Amit Kucheria sug
ing devices, let's define a set of
> helpers where we pass a callback as a parameter to be called for each
> thermal entity.
>
> We keep the self-encapsulation and ensure the locks are correctly
> taken when looking at the list.
>
> Acked-by: Zhang Rui
> Signed-off-by: D
clock_cooling has no in-kernel users. It has never found any use in
drivers as far as I can tell.
Remove the code.
Signed-off-by: Amit Kucheria
---
drivers/thermal/Kconfig | 10 -
drivers/thermal/Makefile| 3 -
drivers/thermal/clock_cooling.c | 445
On Wed, Jul 1, 2020 at 3:15 PM Daniel Lezcano wrote:
>
> On 01/07/2020 11:33, Amit Kucheria wrote:
> > On Wed, Jul 1, 2020 at 2:56 PM Daniel Lezcano
> > wrote:
> >>
> >> On 30/06/2020 13:47, Amit Kucheria wrote:
> >>> On Thu, Jun
On Wed, Jul 1, 2020 at 2:56 PM Daniel Lezcano wrote:
>
> On 30/06/2020 13:47, Amit Kucheria wrote:
> > On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano
> > wrote:
> >>
> >> In order to set the scene for the new generic netlink thermal
> >> management an
On Wed, Jul 1, 2020 at 1:27 PM Zhang Rui wrote:
>
> On Wed, 2020-07-01 at 09:35 +0200, Daniel Lezcano wrote:
> > On 30/06/2020 17:09, Zhang Rui wrote:
> > > Hi, Daniel,
> > >
> > > seems that you forgot to cc linux-pm mailing list.
> > >
> &
On Tue, Jun 30, 2020 at 8:40 PM Zhang Rui wrote:
>
> Hi, Daniel,
>
> seems that you forgot to cc linux-pm mailing list.
>
> On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote:
> > On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano
> > wrote:
> > >
> &
in the message. Passing an integer is more efficient
> than passing an entire string.
>
> This change provides a function returning back a thermal zone pointer
> corresponding to the identifier passed as parameter.
>
> Signed-off-by: Daniel Lezcano
Reviewed-by: Amit Ku
On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano
wrote:
>
> The generic netlink protocol is implemented but the different
> notification functions are not yet connected to the core code.
>
> These changes add the notification calls in the different
> corresponding places.
>
> Signed-off-by: Daniel
On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano
wrote:
>
> In order to set the scene for the new generic netlink thermal
> management and notifications, let remove the old dead code remaining
s/management/management api/
s/let/let's/
> in the uapi headers.
>
> Signed-off-by: Daniel Lezcano
>
On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano
wrote:
>
> Initially the thermal framework had a very simple notification
> mechanism to send generic netlink messages to the userspace.
>
> The notification function was never called from anywhere and the
> corresponding dead code was removed. It
On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano
wrote:
>
> The cdev, tz and governor list, as well as their respective locks are
> statically defined in the thermal_core.c file.
>
> In order to give a sane access to these list, like browsing all the
> thermal zones or all the cooling devices,
On Tue, Jun 30, 2020 at 12:07 PM Andy Tang wrote:
>
>
>
> > -Original Message-
> > From: Amit Kucheria
> > Sent: 2020年6月30日 13:37
> > To: Andy Tang
> > Cc: Shawn Guo ; Leo Li ; Rob
> > Herring ; lakml ;
> > open list:OPEN FIR
Emails currently go to different mailboxes. Switch to the kernel.org
address so I can forward them to a single mailbox.
Signed-off-by: Amit Kucheria
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 2 +-
MAINTAINERS | 4 ++--
2 files
On Tue, Jun 30, 2020 at 10:58 AM Andy Tang wrote:
>
>
>
> > -Original Message-
> > From: Amit Kucheria
> > Sent: 2020年6月30日 13:12
> > To: Andy Tang
> > Cc: Shawn Guo ; Leo Li ; Rob
> > Herring ; lakml ;
> > open list:OPEN FIR
On Tue, Jun 30, 2020 at 8:56 AM wrote:
>
> From: Yuantian Tang
>
> There are 2 thermal zones in ls1088a soc. Add the other thermal zone
> node to enable it.
> Also update the values in calibration table to make the temperatures
> monitored more precise.
>
> Signed-off-by: Yuantian Tang
> ---
>
d.
> >
> > Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support")
> > Signed-off-by: Tiezhu Yang
>
> Good catch. Thanks.
> Reviewed-by: Baolin Wang
Reviewed-by: Amit Kucheria
> > ---
> > drivers/thermal/sprd_thermal.c | 4 ++--
&g
Hi,
A patch to fix this was already submitted on 27th May.
I believe Daniel plans to send it as fixes for -rc4.
Regards,
Amit
On Sun, Jun 28, 2020 at 11:34 AM kernel test robot wrote:
>
>
> Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into
> tsens.c")
> Signed-off-by:
On Wed, Jun 24, 2020 at 8:32 PM Konrad Dybcio wrote:
>
> Interesting, the downstream DTS only mentions the 0x010AD one..
> Are you sure you're not looking at 636/660?
>
I looked a bit closer. So there are two instances of the controller
but the platform doesn't have as many sensors. So using
On Tue, Jun 23, 2020 at 11:39 PM Konrad Dybcio wrote:
>
> Enable tsens on this SoC using tsens-v2 driver.
>
> Signed-off-by: Konrad Dybcio
> ---
> .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++
> 2 files
On Tue, Apr 14, 2020 at 10:14 PM Rob Herring wrote:
>
> On Wed, 1 Apr 2020 20:35:50 +0530, Amit Kucheria wrote:
> > Now that we have yaml bindings for the thermal subsystem, get rid of the
> > old bindings (thermal.txt).
> >
> > Replace all references to th
On Mon, Jun 15, 2020 at 2:37 PM Wang Qing wrote:
>
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Wang Qing
Acked-by: Amit Kucheria
> ---
> drivers/thermal/thermal_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> mode change
e target frequency should be 1416000KHz, not 1512000KHz.
>
> Fixes: 349d39dc5739 ("thermal: cpu_cooling: merge frequency and power tables")
> Cc: # v4.13+
> Signed-off-by: Finley Xiao
> Acked-by: Viresh Kumar
Reviewed-by: Amit Kucheria
> ---
> drivers/ther
t; Fixes: 349d39dc5739 ("thermal: cpu_cooling: merge frequency and power tables")
> Signed-off-by: Finley Xiao
Reviewed-by: Amit Kucheria
> ---
> drivers/thermal/cpufreq_cooling.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers
On Thu, Jun 18, 2020 at 1:49 PM Lee Jones wrote:
>
> On Mon, 08 Jun 2020, Neil Armstrong wrote:
>
> > The new Khadas VIM2, VIM3 and Edge boards embeds an on-board microcontroller
> > connected via I2C.
> >
> > This Microcontroller is present on the Khadas VIM1, VIM2, VIM3 and Edge
> > boards.
> >
as cell of the Khadas
> > MCU MFD driver.
> >
> > Signed-off-by: Neil Armstrong
> > Reviewed-by: Amit Kucheria
>
> Is this an Ack?
Acked-by: Amit Kucheria
> If so, do you require a pull-request?
I'll let Daniel comment about the PR but AFAICT, this can get me
On Sun, Jun 21, 2020 at 12:51 PM Bjorn Andersson
wrote:
>
> On Mon 08 Jun 23:44 PDT 2020, Amit Kucheria wrote:
>
> > sm8250 has 24 thermal sensors split across two tsens controllers. Add
> > the thermal zones to expose them and wireup the cpus to throttle on
> > c
eil Armstrong
Reviewed-by: Amit Kucheria
> ---
> drivers/thermal/Kconfig | 11 ++
> drivers/thermal/Makefile | 1 +
> drivers/thermal/khadas_mcu_fan.c | 174 +++
> 3 files changed, 186 insertions(+)
> create mode 100644 drive
On Mon, Jun 8, 2020 at 2:47 PM Neil Armstrong wrote:
>
> Add the Khadas MCU node with active FAN thermal nodes for all the
> Khadas VIM3 variants.
>
> Signed-off-by: Neil Armstrong
Reviewed-by: Amit Kucheria
> ---
> .../boot/dts/amlogic/meson-khadas-vim3.dtsi | 23 +++
Added tsens bindings for sm8150 and sm8250
Signed-off-by: Amit Kucheria
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
b/Documentation/devicetree/bindings/thermal/qcom
sm8250 has 24 thermal sensors split across two tsens controllers. Add
the thermal zones to expose them and wireup the cpus to throttle on
crossing passive temperature thresholds.
Update the comment in the drivers to list the SoCs it supports.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot
sm8150 has 27 thermal sensors split across two tsens controllers. Add
the thermal zones to expose them and wireup the cpus to throttle their
frequencies on crossing passive temperature thresholds.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 811
Add two new compatibles, the devicetree entries for the thermal zones and
wire it up to the cpufreq cooling device.
Amit Kucheria (3):
dt-bindings: thermal: qcom-tsens: Add compatible for sm8150, sm8250
arm64: dts: qcom: sm8150: Add thermal zones and throttling support
arm64: dts: qcom
On Tue, May 5, 2020 at 3:07 AM David Rientjes wrote:
>
> On Mon, 4 May 2020, Emanuele Giuseppe Esposito wrote:
>
> > There is currently no common way for Linux kernel subsystems to expose
> > statistics to userspace shared throughout the Linux kernel; subsystems
> > have to take care of gathering
Hi Srinivas,
On Wed, May 20, 2020 at 11:46 PM Srinivas Pandruvada
wrote:
>
> On Wed, 2020-05-20 at 09:58 +0530, Amit Kucheria wrote:
> > On Tue, May 19, 2020 at 5:10 AM Srinivas Pandruvada
> > wrote:
> > > On Mon, 2020-05-18 at 18:37 +0200, Daniel Lezcano wrote:
On Sun, May 17, 2020 at 4:17 PM Manaf Meethalavalappu Pallikunhi
wrote:
>
> TSENS IP v2.6+ adds zeroc interrupt support. It triggers set
As I re-read through these patches, shouldn't we just call it the
"cold" interrupt?
> interrupt when aggregated minimum temperature of all TSENS falls
> below
On Mon, May 4, 2020 at 11:47 PM Srinivas Pandruvada
wrote:
>
> Use the new framework to send notifications for:
> - Setting temperature threshold for notification to avoid polling
> - Send THERMAL_TRIP_REACHED event on reaching threshold
> - Send THERMAL_TRIP_UPDATE when firmware change the the
On Mon, May 4, 2020 at 11:47 PM Srinivas Pandruvada
wrote:
>
> This change adds an optional feature to add a new device entry
> /dev/thermal_notify.
>
> When config CONFIG_THERMAL_USER_EVENT_INTERFACE is selected, this new
> device entry is created.
>
> Thermal core or any thermal driver can use
On Mon, May 4, 2020 at 11:47 PM Srinivas Pandruvada
wrote:
>
> Add new attribute in the thermal syfs for setting temperature sampling
> interval when CONFIG_THERMAL_USER_EVENT_INTERFACE is defined. The default
> value is 0, which means no polling.
>
> At this interval user space will get an event
On Tue, May 19, 2020 at 5:10 AM Srinivas Pandruvada
wrote:
>
> On Mon, 2020-05-18 at 18:37 +0200, Daniel Lezcano wrote:
> > On 04/05/2020 20:16, Srinivas Pandruvada wrote:
> > > Add new attributes in thermal syfs when a thermal drivers provides
> > > callbacks for them and
On Sun, May 17, 2020 at 3:58 PM wrote:
>
> On 2020-05-05 17:39, Amit Kucheria wrote:
> > Hi Manaf,
> >
> > Typo: fix zeorC in subject line.
> Done
> >
> > Please rebase this patch[1] on top of my patch merging tsens-common.c
> > and tsens.c.
> >
ds.
>
> Signed-off-by: Neil Armstrong
> Reviewed-by: Rob Herring
Reviewed-by: Amit Kucheria
> ---
> .../devicetree/bindings/mfd/khadas,mcu.yaml | 44 +++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/khadas,
On Tue, May 12, 2020 at 6:56 PM Neil Armstrong wrote:
>
> The new Khadas VIM2 and VIM3 boards controls the cooling fan via the
> on-board microcontroller.
>
> This implements the FAN control as thermal devices and as cell of the Khadas
> MCU MFD driver.
>
> Signed-off-by: Neil Armstrong
> ---
>
ch holds por and num_por values and populate
> that in driver probe.
>
> Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos")
> Reported-by: Rahul Ankushrao Kawadgave
> Signed-off-by: Vinod Koul
Otherwise,
Reviewed-by: Amit Kucheria
> ---
> .../ether
initialisation in the file.
Fixes: 9a434cee773a ("firmware: qcom_scm: Dynamically support SMCCC and legacy
conventions")
Signed-off-by: Amit Kucheria
---
drivers/firmware/qcom_scm.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/firmware/qcom_scm.c b/driver
Sort headers to make it easier to read and find duplicate headers.
Signed-off-by: Amit Kucheria
---
drivers/thermal/user_space.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/user_space.c b/drivers/thermal/user_space.c
index 293cffd9c8ad..82a7198bbe71
Bang-bang governor source file is prefixed with gov_. Do the same for
other governors for consistency so they're easy to find in the sources.
Signed-off-by: Amit Kucheria
---
drivers/thermal/Makefile | 8
drivers/thermal/{fair_share.c
cpufreq_cooling cannot be modular, remove the unnecessary module.h
include and replace with export.h to handle EXPORT_SYMBOL family of
macros.
Signed-off-by: Amit Kucheria
---
drivers/thermal/cpufreq_cooling.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal
It is preferable to include export.h when you are using EXPORT_SYMBOL
family of macros.
Signed-off-by: Amit Kucheria
---
drivers/thermal/thermal_helpers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/thermal_helpers.c
b/drivers/thermal/thermal_helpers.c
index
Sort headers to make it easier to read and find duplicate headers.
Signed-off-by: Amit Kucheria
---
drivers/thermal/cpufreq_cooling.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/cpufreq_cooling.c
b/drivers/thermal/cpufreq_cooling.c
index
Core thermal framework code files should start with thermal_*.
of-thermal.c does not follow this pattern and can easily be confused
with platform driver.
Fix this by renaming it to thermal_of.c
Signed-off-by: Amit Kucheria
---
drivers/thermal/Makefile | 2 +-
drivers
Sort headers to make it easier to read and find duplicate headers.
Signed-off-by: Amit Kucheria
---
drivers/thermal/of-thermal.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 874a47d6923f
Sort headers to make it easier to read and find duplicate headers.
Signed-off-by: Amit Kucheria
---
drivers/thermal/thermal_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/thermal_helpers.c
b/drivers/thermal/thermal_helpers.c
index 2ba756af76b7
It is preferable to include export.h when you are using EXPORT_SYMBOL
family of macros.
Signed-off-by: Amit Kucheria
---
drivers/thermal/thermal_hwmon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index e43ae551592d
So no loss of information.
Signed-off-by: Amit Kucheria
---
drivers/thermal/thermal_core.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 9a321dc548c8..286920e06277 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drive
It is preferrable to include export.h when you are using EXPORT_SYMBOL
family of macros.
Signed-off-by: Amit Kucheria
---
drivers/thermal/clock_cooling.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/clock_cooling.c b/drivers/thermal/clock_cooling.c
index fd6bc6eefc88
, the names of the source files for the governors and core have some
inconsistencies and the last couple of patches rename them.
Build and boot tested on some ARM boards.
Amit Kucheria (14):
thermal/core: Get rid of MODULE_* tags
thermal/core: Replace module.h with export.h
thermal/drivers
Thermal core cannot be modular, remove the unnecessary module.h include
and replace with export.h to handle EXPORT_SYMBOL family of macros.
Signed-off-by: Amit Kucheria
---
drivers/thermal/thermal_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal
Sort headers to make it easier to read and find duplicate headers.
Signed-off-by: Amit Kucheria
---
drivers/thermal/thermal_hwmon.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index c8d2620f2e42
1 - 100 of 1222 matches
Mail list logo