Hi Stephen ,
Could you please help get this merged ?
Thanks
-Amit
On Fri, Sep 11, 2020 at 10:59 AM Amit Singh Tomar wrote:
>
> This commit adds device tree binding reset constants for mmc controller
> present on Actions S700 Soc.
>
> Reviewed-by: Manivannan Sadhasivam
> Acked-by: Rob Herring
Hi,
> Fixed regulators are used to nicely model the regulators which aren't tied to
> any PMIC. But for some cases we use them to represent supplies when there is
> no support for the specific PMIC present in the kernel and they are turned
> on/configured by the bootloader (this is what happening
Hi,
> But this regulator is only used for the eMMC there, which we apparently
> don't have on the Cubieboard 7?
We do have eMMC present on Cubieboard 7 (both the versions of Cubieboard7), and
the regulator name is similar to what is used in
"s900-bubblegum-96.dts" .i.e. "vcc_3v1".
But Since
Hi,
On Sun, Jul 12, 2020 at 11:00 PM Manivannan Sadhasivam
wrote:
>
> On Thu, Jul 02, 2020 at 08:22:56PM +0530, Amit Singh Tomar wrote:
> > This commit adds uSD support for Cubieboard7 board based on Actions Semi
> > S700 SoC. SD0 is connected to uSD slot. Since there is no PMIC support
> >
On Fri, Jul 3, 2020 at 12:48 PM Amit Tomer wrote:
>
> Hi Rob,
>
>
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org
Hi Rob,
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
> --upgrade
>
> Please check and re-submit.
I wasn't able to reproduce it, even after
Hi,
On Tue, Jun 30, 2020 at 7:54 PM Vinod Koul wrote:
>
> On 30-06-20, 15:17, Amit Tomer wrote:
> > Hi Vinod,
> >
> > On Mon, Jun 29, 2020 at 3:22 PM Vinod Koul wrote:
> >
> > > If you use of_device_get_match_data() you will not fall into this :)
>
Hi Vinod,
On Mon, Jun 29, 2020 at 3:22 PM Vinod Koul wrote:
> If you use of_device_get_match_data() you will not fall into this :)
But again, of_device_get_match_data() returns void *, and we need
"uintptr_t" in order to type cast it properly (at-least without
warning).
Also, while looking
Hi Vinod,
Thanks for having a look and providing the comments.
> Is the .compatible documented, Documentation patch should come before
> the driver use patch in a series
Yes, this new compatible string is documented in patch (05/10).
I would make it as a patch (1/10).
> > static int
Hi,
On Wed, Jun 24, 2020 at 3:06 PM André Przywara wrote:
>
> On 24/06/2020 07:15, Vinod Koul wrote:
>
> Hi,
>
> > On 09-06-20, 15:47, Amit Singh Tomar wrote:
> >
> >> @@ -372,6 +383,7 @@ static inline int owl_dma_cfg_lli(struct owl_dma_vchan
> >> *vchan,
> >>
Hi,
Thanks for having a look.
On Wed, Jun 3, 2020 at 12:52 PM Manivannan Sadhasivam
wrote:
> Individual comments for these enums?
I was expecting this comment , and thought these fields are self explanatory
But if you prefer to have description about it, I would have it in next version.
>
Hi,
On Wed, May 20, 2020 at 12:03 AM Rob Herring wrote:
>
> On Tue, May 19, 2020 at 11:49:25PM +0530, Amit Singh Tomar wrote:
> > This commit adds device tree binding reset constants for mmc controller
> > present on Actions S700 Soc.
> >
> > Signed-off-by: Amit Singh Tomar
> > ---
> > Changes
> Oh, and... u-b...@linux.nxdi.nxp.com bounces because that domain is
> not resolvable - I guess that is internal to NXP, and this patch
> should have remained within NXP and not been posted publically.
Yeah, realized it just after sending my reply. It is for internal NXP list.
Had it been for
> From what I can tell, these patches are not for the kernel. The
> filenames don't match th kernel layout.
These files looks to be from U-boot, and must be intended for U-boot
as I see U-boot mailing
address in recipient's address?
Hello ,
> @@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy)
> val = readl(phy->pmu + REG_PMU_UNK_H3);
> writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
> } else {
> + /* A64 needs also this unknown bit */
> + if
Hello ,
> @@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy)
> val = readl(phy->pmu + REG_PMU_UNK_H3);
> writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
> } else {
> + /* A64 needs also this unknown bit */
> + if
Sorry to intervene but just trying to learn from your comments.
> You have plenty, and that's the whole of your device space. *All of it*. So
> just take the base address of your PCIe controller, and be done with
> it.
but isn't few of PCIe controller's registers itself are mapped
here(base
Sorry to intervene but just trying to learn from your comments.
> You have plenty, and that's the whole of your device space. *All of it*. So
> just take the base address of your PCIe controller, and be done with
> it.
but isn't few of PCIe controller's registers itself are mapped
here(base
> Without #ifdefs if we compile driver for legacy, MSI structures will not be
> available and we get compile time error.
Sorry for nitpicking but at least can we use elegant version of
#ifdefs .i.e. #if IS_ENABLED() here ?
Thanks,
Amit.
--
To unsubscribe from this list: send the line
> Without #ifdefs if we compile driver for legacy, MSI structures will not be
> available and we get compile time error.
Sorry for nitpicking but at least can we use elegant version of
#ifdefs .i.e. #if IS_ENABLED() here ?
Thanks,
Amit.
--
To unsubscribe from this list: send the line
20 matches
Mail list logo
