Re: about pca955x led driver gpio management

2017-10-24 Thread Andrea Scian - DAVE Embedded Systems
Il 24/10/2017 07:51, Cédric Le Goater ha scritto: On 10/17/2017 11:16 AM, Andrea Scian - DAVE Embedded Systems wrote: On 10/17/2017 10:20 AM, Andrea Scian - DAVE Embedded Systems wrote: Il 17/10/2017 10:18, Cédric Le Goater ha scritto: On 10/17/2017 09:36 AM, Andrea Scian - DAVE Embedded

Re: about pca955x led driver gpio management

2017-10-24 Thread Andrea Scian - DAVE Embedded Systems
Il 24/10/2017 07:51, Cédric Le Goater ha scritto: On 10/17/2017 11:16 AM, Andrea Scian - DAVE Embedded Systems wrote: On 10/17/2017 10:20 AM, Andrea Scian - DAVE Embedded Systems wrote: Il 17/10/2017 10:18, Cédric Le Goater ha scritto: On 10/17/2017 09:36 AM, Andrea Scian - DAVE Embedded

Re: about pca955x led driver gpio management

2017-10-17 Thread Andrea Scian - DAVE Embedded Systems
On 10/17/2017 10:20 AM, Andrea Scian - DAVE Embedded Systems wrote: Il 17/10/2017 10:18, Cédric Le Goater ha scritto: On 10/17/2017 09:36 AM, Andrea Scian - DAVE Embedded Systems wrote: Dear all, I'm working on an iMX6 based board with a PCA9555 which is used both to drive LEDs and manage

Re: about pca955x led driver gpio management

2017-10-17 Thread Andrea Scian - DAVE Embedded Systems
On 10/17/2017 10:20 AM, Andrea Scian - DAVE Embedded Systems wrote: Il 17/10/2017 10:18, Cédric Le Goater ha scritto: On 10/17/2017 09:36 AM, Andrea Scian - DAVE Embedded Systems wrote: Dear all, I'm working on an iMX6 based board with a PCA9555 which is used both to drive LEDs and manage

Re: about pca955x led driver gpio management

2017-10-17 Thread Andrea Scian - DAVE Embedded Systems
Il 17/10/2017 10:18, Cédric Le Goater ha scritto: On 10/17/2017 09:36 AM, Andrea Scian - DAVE Embedded Systems wrote: Dear all, I'm working on an iMX6 based board with a PCA9555 which is used both to drive LEDs and manage some GPIOs. The PCA9555 chip and the PCA955[0-3] chips have different

Re: about pca955x led driver gpio management

2017-10-17 Thread Andrea Scian - DAVE Embedded Systems
Il 17/10/2017 10:18, Cédric Le Goater ha scritto: On 10/17/2017 09:36 AM, Andrea Scian - DAVE Embedded Systems wrote: Dear all, I'm working on an iMX6 based board with a PCA9555 which is used both to drive LEDs and manage some GPIOs. The PCA9555 chip and the PCA955[0-3] chips have different

about pca955x led driver gpio management

2017-10-17 Thread Andrea Scian - DAVE Embedded Systems
having an array of GPIO index to map offset -> pca955x->leds[] index or just register all pins as GPIOs and then just report the busy state) WDYT? Kind Regards, -- Andrea SCIAN *DAVE Embedded Systems* via Talponedo 29/A 33080 Porcia (PN) - Italy Telephone: +39.0434.921215 Telef

about pca955x led driver gpio management

2017-10-17 Thread Andrea Scian - DAVE Embedded Systems
having an array of GPIO index to map offset -> pca955x->leds[] index or just register all pins as GPIOs and then just report the busy state) WDYT? Kind Regards, -- Andrea SCIAN *DAVE Embedded Systems* via Talponedo 29/A 33080 Porcia (PN) - Italy Telephone: +39.0434.921215 Telef

Re: [PATCH v2 5/6] mtd: nand: gpmi: correct bitflip for erased NAND page

2015-08-18 Thread Andrea Scian
Il 18/08/2015 05:25, Han Xu ha scritto: i.MX6QP and i.MX7D BCH module integrated a new feature to detect the bitflip number for erased NAND page. So for these two platform, set the erase threshold to gf/2 and if bitflip detected, GPMI driver will correct the data to all 0xFF. Please also fix

Re: [PATCH v2 5/6] mtd: nand: gpmi: correct bitflip for erased NAND page

2015-08-18 Thread Andrea Scian
Il 18/08/2015 05:25, Han Xu ha scritto: i.MX6QP and i.MX7D BCH module integrated a new feature to detect the bitflip number for erased NAND page. So for these two platform, set the erase threshold to gf/2 and if bitflip detected, GPMI driver will correct the data to all 0xFF. Please also fix

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-05 Thread Andrea Scian
Il 04/08/2015 09:21, Richard Weinberger ha scritto: Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: I'm not sure whether introducing a read-before-write check is the best solution. At least we need hard numbers for slow/old SLC NANDs too. We can enable the feature only for MLC, AFAIK

Re: [PATCH] can: xilinx: fix RX FIFO overflow error handling

2015-08-05 Thread Andrea Scian - DAVE Embedded Systems
Michal, Kedar, Any feedback regarding my patch? Have you ever experienced such a problem? Andrea SCIAN *DAVE Embedded Systems* via Talponedo 29/A 33080 Porcia (PN) - Italy Telephone: +39.0434.921215 Telefax: +39.0434.1994030 web: www.dave.eu <http://www.dave.eu> Il 24/07/2015 06:15,

Re: [PATCH] can: xilinx: fix RX FIFO overflow error handling

2015-08-05 Thread Andrea Scian - DAVE Embedded Systems
Michal, Kedar, Any feedback regarding my patch? Have you ever experienced such a problem? Andrea SCIAN *DAVE Embedded Systems* via Talponedo 29/A 33080 Porcia (PN) - Italy Telephone: +39.0434.921215 Telefax: +39.0434.1994030 web: www.dave.eu http://www.dave.eu Il 24/07/2015 06:15, Michal

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-05 Thread Andrea Scian
Il 04/08/2015 09:21, Richard Weinberger ha scritto: Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: I'm not sure whether introducing a read-before-write check is the best solution. At least we need hard numbers for slow/old SLC NANDs too. We can enable the feature only for MLC, AFAIK

Re: [RFC PATCH 1/2] mtd: nand: add nand_check_erased helper functions

2015-08-04 Thread Andrea Scian
Boris, sorry for the later review. I'm trying to run your patch on our systems. See below Il 31/07/2015 09:10, Boris Brezillon ha scritto: On Thu, 30 Jul 2015 19:34:53 +0200 Boris Brezillon wrote: Add two helper functions to help NAND controller drivers test whether a specific NAND region

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-04 Thread Andrea Scian
Richard, Il 03/08/2015 21:32, Richard Weinberger ha scritto: Am 03.08.2015 um 15:39 schrieb Andrea Scian: I think I can find some time to do some performance tests on real hardware. Can you please help me in finding: - which benchmark to use (currently I'm using bonnie++ on UBIFS, maybe I can

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-04 Thread Andrea Scian
Richard, Il 03/08/2015 21:32, Richard Weinberger ha scritto: Am 03.08.2015 um 15:39 schrieb Andrea Scian: I think I can find some time to do some performance tests on real hardware. Can you please help me in finding: - which benchmark to use (currently I'm using bonnie++ on UBIFS, maybe I can

Re: [RFC PATCH 1/2] mtd: nand: add nand_check_erased helper functions

2015-08-04 Thread Andrea Scian
Boris, sorry for the later review. I'm trying to run your patch on our systems. See below Il 31/07/2015 09:10, Boris Brezillon ha scritto: On Thu, 30 Jul 2015 19:34:53 +0200 Boris Brezillon boris.brezil...@free-electrons.com wrote: Add two helper functions to help NAND controller drivers

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Il 03/08/2015 14:42, Boris Brezillon ha scritto: Adding Artem and Richard in the loop. thanks ;-) On Mon, 3 Aug 2015 13:16:02 +0200 Andrea Scian wrote: Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian wrote: Il 31/07/2015

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian wrote: Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian r...@dave-tech.it wrote: Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian r...@dave-tech.it wrote: Boris, Il 31/07/2015 12:32

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Il 03/08/2015 14:42, Boris Brezillon ha scritto: Adding Artem and Richard in the loop. thanks ;-) On Mon, 3 Aug 2015 13:16:02 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian r

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian wrote: Dear Boris, Il 30/07/2015 19:34, Boris

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian wrote: Dear Boris, Il 30/07/2015 19:34, Boris Brezillon ha scritto: The default NAND read functions are relying on an underlying controller to correct

Re: [RFC PATCH 1/2] mtd: nand: add nand_check_erased helper functions

2015-07-31 Thread Andrea Scian
Boris, Il 31/07/2015 12:21, Boris Brezillon ha scritto: Hi Andrea, On Fri, 31 Jul 2015 12:06:32 +0200 Andrea Scian wrote: Dear Boris, thanks for pointing this out again. I'm on the same topic too, using iMX6 (I'll try to test you patch on the next days, if I found some spare time

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
before reporting an ECC failure. I'm still wondering if chip->ecc.strength is the right threshold. Did you see my comments here [1]? WDYT? Maybe we can have this discussion in a separate thread, if you want ;-) Kind Regards, -- Andrea SCIAN DAVE Embedded Systems [1] h

Re: [RFC PATCH 1/2] mtd: nand: add nand_check_erased helper functions

2015-07-31 Thread Andrea Scian
eady did the check for you (e.g. if you have an iMXQP as we saw in latest days), but I think it's a minor one, because you'll face this situation very very unlikely. -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, Il 30/07/2015 19:34, Boris Brezillon ha scritto: The default NAND read functions are relying on an underlying

Re: [RFC PATCH 1/2] mtd: nand: add nand_check_erased helper functions

2015-07-31 Thread Andrea Scian
Boris, Il 31/07/2015 12:21, Boris Brezillon ha scritto: Hi Andrea, On Fri, 31 Jul 2015 12:06:32 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, thanks for pointing this out again. I'm on the same topic too, using iMX6 (I'll try to test you patch on the next days, if I found some

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian r...@dave-tech.it wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian r...@dave-tech.it wrote: Dear

Re: [RFC PATCH 1/2] mtd: nand: add nand_check_erased helper functions

2015-07-31 Thread Andrea Scian
if the lower layer already did the check for you (e.g. if you have an iMXQP as we saw in latest days), but I think it's a minor one, because you'll face this situation very very unlikely. -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list: send the line unsubscribe linux

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
before reporting an ECC failure. I'm still wondering if chip-ecc.strength is the right threshold. Did you see my comments here [1]? WDYT? Maybe we can have this discussion in a separate thread, if you want ;-) Kind Regards, -- Andrea SCIAN DAVE Embedded Systems [1] http://lists.infradead.org

Re: [PATCH 5/6] mtd: nand: gpmi: correct bitflip for erased NAND page

2015-07-29 Thread Andrea Scian
arding this patch, but I think this is an interesting point to discuss about. Any comment is welcome Kind Regards, -- Andrea SCIAN DAVE Embedded Systems [1] http://lists.infradead.org/pipermail/linux-mtd/2015-July/060168.html [2] http://lists.infradead.org/pipermail/linux-mtd/2015-January/0573

Re: [PATCH 5/6] mtd: nand: gpmi: correct bitflip for erased NAND page

2015-07-29 Thread Andrea Scian
this patch? Kind regards and TIA, -- Andrea SCIAN DAVE Embedded Systems [1] http://article.gmane.org/gmane.linux.drivers.mtd/52216 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 5/6] mtd: nand: gpmi: correct bitflip for erased NAND page

2015-07-29 Thread Andrea Scian
this is an interesting point to discuss about. Any comment is welcome Kind Regards, -- Andrea SCIAN DAVE Embedded Systems [1] http://lists.infradead.org/pipermail/linux-mtd/2015-July/060168.html [2] http://lists.infradead.org/pipermail/linux-mtd/2015-January/057334.html -- To unsubscribe from

Re: [PATCH 5/6] mtd: nand: gpmi: correct bitflip for erased NAND page

2015-07-29 Thread Andrea Scian
this patch? Kind regards and TIA, -- Andrea SCIAN DAVE Embedded Systems [1] http://article.gmane.org/gmane.linux.drivers.mtd/52216 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [rtc-linux] [PATCH] driver: rtc: pcf2127: use OFS flag to detect unreliable date and warn the user

2015-06-15 Thread Andrea Scian
Hi Alexandre, On 12/06/2015 09:42, Alexandre Belloni wrote: On 10/06/2015 at 17:21:57 +0200, Andrea Scian wrote : I would return -EINVAL here because the result might still pass rtc_valid_tm() but be outdated. At first look I agree with you, but a bit later they say: /* the clock can give

Re: [rtc-linux] [PATCH] driver: rtc: pcf2127: use OFS flag to detect unreliable date and warn the user

2015-06-15 Thread Andrea Scian
Hi Alexandre, On 12/06/2015 09:42, Alexandre Belloni wrote: On 10/06/2015 at 17:21:57 +0200, Andrea Scian wrote : I would return -EINVAL here because the result might still pass rtc_valid_tm() but be outdated. At first look I agree with you, but a bit later they say: /* the clock can give

Re: [rtc-linux] [PATCH] driver: rtc: pcf2127: use OFS flag to detect unreliable date and warn the user

2015-06-10 Thread Andrea Scian
Dear Alexandre, On 08/06/2015 17:42, Alexandre Belloni wrote: Hi, This seems ok, a few comments below: On 26/05/2015 at 10:17:40 +0200, r...@dave-tech.it wrote : From: Andrea Scian I'm using PCF2127 in a custom ARM-based board and, by looking into PCF2127 datasheet I've found that, in my

Re: [rtc-linux] [PATCH] driver: rtc: pcf2127: use OFS flag to detect unreliable date and warn the user

2015-06-10 Thread Andrea Scian
Dear Alexandre, On 08/06/2015 17:42, Alexandre Belloni wrote: Hi, This seems ok, a few comments below: On 26/05/2015 at 10:17:40 +0200, r...@dave-tech.it wrote : From: Andrea Scian andrea.sc...@dave.eu I'm using PCF2127 in a custom ARM-based board and, by looking into PCF2127 datasheet

Re: [PATCH 4/4] UBI: Implement bitrot checking (linux-mtd Digest, Vol 145, Issue 24)

2015-04-12 Thread Andrea Scian
Il 12/04/2015 23:01, Richard Weinberger ha scritto: Am 12.04.2015 um 22:42 schrieb Andrea Scian: Il 12/04/2015 18:55, Richard Weinberger ha scritto: Am 12.04.2015 um 18:43 schrieb Boris Brezillon: On Sun, 12 Apr 2015 18:09:23 +0200 Richard Weinberger wrote: Am 12.04.2015 um 16:12 schrieb

Re: [PATCH 4/4] UBI: Implement bitrot checking (linux-mtd Digest, Vol 145, Issue 24)

2015-04-12 Thread Andrea Scian
ry ;-) ) Kind Regards, Andrea SCIAN -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/4] UBI: Implement bitrot checking (linux-mtd Digest, Vol 145, Issue 24)

2015-04-12 Thread Andrea Scian
more than one sysfs entry ;-) ) Kind Regards, Andrea SCIAN -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] UBI: Implement bitrot checking (linux-mtd Digest, Vol 145, Issue 24)

2015-04-12 Thread Andrea Scian
Il 12/04/2015 23:01, Richard Weinberger ha scritto: Am 12.04.2015 um 22:42 schrieb Andrea Scian: Il 12/04/2015 18:55, Richard Weinberger ha scritto: Am 12.04.2015 um 18:43 schrieb Boris Brezillon: On Sun, 12 Apr 2015 18:09:23 +0200 Richard Weinberger rich...@nod.at wrote: Am 12.04.2015 um

Re: [PATCH 4/4] UBI: Implement bitrot checking

2015-04-08 Thread Andrea Scian
Il 08/04/2015 12:34, Richard Weinberger ha scritto: > Am 02.04.2015 um 21:19 schrieb Andrea Scian: >> Il 02/04/2015 19:54, Richard Weinberger ha scritto: >>> Hi! >>> >>> Am 02.04.2015 um 19:34 schrieb Andrea Scian: >>>> Richard, >>>

Re: [PATCH 4/4] UBI: Implement bitrot checking

2015-04-08 Thread Andrea Scian
Il 08/04/2015 12:34, Richard Weinberger ha scritto: Am 02.04.2015 um 21:19 schrieb Andrea Scian: Il 02/04/2015 19:54, Richard Weinberger ha scritto: Hi! Am 02.04.2015 um 19:34 schrieb Andrea Scian: Richard, Il 29/03/2015 14:13, Richard Weinberger ha scritto: + mutex_lock(ubi-buf_mutex

Re: [PATCH] mtd: Add simple read disturb test

2015-04-02 Thread Andrea Scian
ide mtd-utils, I think it's better to start creating tests there, as userspace tools, whenever this is possible. Do we have any reason to have MTD tests as kernel module? (performance?) Kind Regards, -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH 4/4] UBI: Implement bitrot checking

2015-04-02 Thread Andrea Scian
Il 02/04/2015 19:54, Richard Weinberger ha scritto: > Hi! > > Am 02.04.2015 um 19:34 schrieb Andrea Scian: >> Richard, >> >> Il 29/03/2015 14:13, Richard Weinberger ha scritto: >>> + mutex_lock(>buf_mutex); >>> + err = ubi_io_r

Re: [PATCH 4/4] UBI: Implement bitrot checking

2015-04-02 Thread Andrea Scian
nd 1E-4 (for devices with 1k-2k P/E cycle after 100k-300k read-without-P/E) Having a few bitflips on a block read is more that usual and current ECC can correct more that 16 bit error over 512/1KiB. WDYT? Kind Regards, -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list:

Re: [PATCH] mtd: Add simple read disturb test

2015-04-02 Thread Andrea Scian
this is possible. Do we have any reason to have MTD tests as kernel module? (performance?) Kind Regards, -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 4/4] UBI: Implement bitrot checking

2015-04-02 Thread Andrea Scian
Il 02/04/2015 19:54, Richard Weinberger ha scritto: Hi! Am 02.04.2015 um 19:34 schrieb Andrea Scian: Richard, Il 29/03/2015 14:13, Richard Weinberger ha scritto: + mutex_lock(ubi-buf_mutex); + err = ubi_io_read(ubi, ubi-peb_buf, e-pnum, 0, ubi-peb_size); + mutex_unlock(ubi-buf_mutex

Re: [PATCH 4/4] UBI: Implement bitrot checking

2015-04-02 Thread Andrea Scian
read-without-P/E) Having a few bitflips on a block read is more that usual and current ECC can correct more that 16 bit error over 512/1KiB. WDYT? Kind Regards, -- Andrea SCIAN DAVE Embedded Systems -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body