Re: [patch 2/5] VFS: pass open file to ->getattr()

2007-09-21 Thread Andreas Dilger
struct file *file); It's not much of an inode operation anymore if you need to pass a file to it... Since the attributes are really part of the inode and not the file, this seems like a bit of a hack. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.

Re: [PATCH] JBD: use GFP_NOFS in kmalloc

2007-09-19 Thread Andreas Dilger
;it's in a filesystem, so it should be GFP_NOFS"? We are only doing journal setup during mount so there shouldn't be any problem using GFP_KERNEL. I don't think it will inject any defect into the code, but I don't think it is needed either. Cheers, Andreas -- Andreas Dilger

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Andreas Dilger
f(*new_transaction), > - GFP_NOFS|__GFP_NOFAIL); > + new_transaction = kmalloc(sizeof(*new_transaction), GFP_NOFS); This should probably be a __GFP_NOFAIL if we are trying to start a new handle in truncate, as there is no way to propagate an error to the caller. Cheers, Andreas --

Re: [PATCH] Ext4: Uninitialized Block Groups

2007-09-18 Thread Andreas Dilger
d around 2.6.15 or so, so e.g. RHEL4 doesn't have it). I forgot to remove it from the upstream submission, and since it didn't cause problems nobody else complained... Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: s

Re: [PATCH] ext34: ensure do_split leaves enough free space in both blocks

2007-09-17 Thread Andreas Dilger
> memcpy(de->name, name, namelen) will overshoot the buffer and actually > > corrupt memory.) > > So this looks like 2.6.22 and 2.6.23 material, but the timing is getting > pretty squeezy. Could people please give this change an extra-close > review, let me know? I

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Andreas Dilger
solaris and ZFS ports) so perhaps those performance > critical parts that remain kernel space will be easier to merge. This is also true - when that is done the only parts that will remain in the kernel are the network drivers. With some network stacks there is even direct userspace accelerati

Re: Distributed storage. Move away from char device ioctls.

2007-09-15 Thread Andreas Dilger
exists, and I think btrfs may have laid claim to the current generation of filesystems. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] [187/2many] MAINTAINERS - EXT3 FILE SYSTEM

2007-08-13 Thread Andreas Dilger
On Aug 13, 2007 02:59 -0600, Andreas Dilger wrote: > > EXT3 FILE SYSTEM > > You may as well have fs/jbd/* and include/linux/jbd.h for ext3. Ignore this, there is a separate section for that already... Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File

Re: [PATCH] [188/2many] MAINTAINERS - EXT4 FILE SYSTEM

2007-08-13 Thread Andreas Dilger
> F: include/linux/ext3* > > EXT4 FILE SYSTEM > -P: Stephen Tweedie, Andrew Morton > -M: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] > +P: Stephen Tweedie > +M: [EMAIL PROTECTED] > +P: Andrew Morton > +M: [EMAIL PROTECTED] > +P: Andreas Dilger

Re: [PATCH] [187/2many] MAINTAINERS - EXT3 FILE SYSTEM

2007-08-13 Thread Andreas Dilger
@@ -1796,10 +1796,16 @@ F:fs/ext2/ > F: include/linux/ext2* > > EXT3 FILE SYSTEM > -P: Stephen Tweedie, Andrew Morton > -M: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] > +P: Stephen Tweedie > +M: [EMAIL PROTECTED] > +P: Andrew Morton > +

Re: [PATCH] obsolete fragment from ext4

2007-08-10 Thread Andreas Dilger
> Another patch posted on linux-ext4 removing fragment supporting from > e2fsprogs. > I tested both patch. > > > Signed-Off-By: Coly Li <[EMAIL PROTECTED]> Acked-by: Andreas Dilger <[EMAIL PROTECTED]> Cheers, Andreas -- Andreas Dilger Principal Software Engineer Clus

Re: [RFC 12/26] ext2 white-out support

2007-07-31 Thread Andreas Dilger
x-ext4. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-24 Thread Andreas Dilger
_bits = ilog2(EXT4_ADDR_PER_BLOCK(sb)); > > + sbi->s_desc_per_block_bits = ilog2(EXT4_DESC_PER_BLOCK(sb)); For the ext[234] code there has only ever been power-of-two values for ADDR_PER_BLOCK() and DESC_PER_BLOCK(). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster F

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-07-20 Thread Andreas Dilger
ON() to see if percpu sum doesn't match > computed sum. I saw few stacks in a 24 hour run of fsx runs. That could just be because the filesystem is changing between these two checks... Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To

Re: [PATCH 1/5][TAKE8] manpage for fallocate

2007-07-19 Thread Andreas Dilger
ites are guaranteed to never require > allocation of file data." ? > --Mark In the worst case, the unwritten extent could be zero-filled before the write is done, so no exent split is needed. We discussed this recently for the ext4 fallocate, but didn't consider it important e

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-16 Thread Andreas Dilger
t; > cleanup: > kfree(b_entry_name); I don't think you should have brelse(bh) inside the loop, since it is allocated before the loop starts. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the l

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-13 Thread Andreas Dilger
;buffer" and "b_entry_name" are leaked in ext4_expand_extra_isize() if the while loop is run more than one time (again a relatively rare event). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-13 Thread Andreas Dilger
the same process, since the journal handle is also held in current->journal_info so the handle does not need to be passed as an argument all over the VFS. > This seems to boot... albeit I did not push it hard. Can you please also make a patch for jbd2. Cheers, Andreas -- Andreas Dilger Pri

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-07-12 Thread Andreas Dilger
y just dropping the FALLOC_FL_DEALLOCATE and FALLOC_FL_DEL_DATA from the interface. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-11 Thread Andreas Dilger
for NFSv4 because it only uses the inequality check. Having the full 64 bits available eliminates the risk of collisions, and given that the spec mandates a 64-bit version I'm sure someone will take full advantage of it in NFS at some point. Cheers, Andreas -- Andreas Dilger Principal Softw

Re: [EXT4 set 8][PATCH 1/1]Add journal checksums

2007-07-11 Thread Andreas Dilger
k with a single copy for now. > > > @@ -328,6 +360,7 @@ static int do_one_pass(journal_t *journa > > > unsigned intsequence; > > > int blocktype; > > > int tag_bytes = journal_tag_bytes(journal); > >

Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.

2007-07-11 Thread Andreas Dilger
> > + inode->i_nlink = 1; > > + EXT4_SET_RO_COMPAT_FEATURE(inode->i_sb, > > + EXT4_FEATURE_RO_COMPAT_DIR_NLINK); > > + } > > + } > > +} > > Why do we set EXT4_FEATURE_RO_COMPAT_DIR_NLINK if i_nlink==2? Because that

Re: [EXT4 set 5][PATCH 1/1] expand inode i_extra_isize to support features in larger inode

2007-07-11 Thread Andreas Dilger
> + EXT4_I(inode)->i_file_acl); > > + error = -EIO; > > + goto cleanup; > > + } > > + base = BHDR(bh); > > + first = BFIRST(bh); > > + end = bh->b_data + bh->

Re: [EXT4 set 4][PATCH 5/5] i_version: noversion mount option to disable inode version updates

2007-07-11 Thread Andreas Dilger
rsion updates on disk default to OFF unless NFSv4 has exported the filesystem at least once, and then it should set a persistent flag in the superblock indicating that i_version updates are needed. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To u

Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update

2007-07-11 Thread Andreas Dilger
are confusing i_generation (the instance of this inode number) with i_version (whether this file has been modified)? Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [EXT4 set 4][PATCH 3/5] i_version:ext4 inode version read/store

2007-07-11 Thread Andreas Dilger
t; > There's no comparison with EXT4_GOOD_OLD_INODE_SIZE here... Because this is the in-memory version and it is always valid (set to zero if there is extra space in the on-disk inode). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscri

Re: [EXT4 set 4][PATCH 2/5] i_version: Add hi 32 bit inode version on ext4 on-disk inode

2007-07-11 Thread Andreas Dilger
On Jul 10, 2007 16:30 -0700, Andrew Morton wrote: > > Signed-off-by: Mingming Cao <[EMAIL PROTECTED]> > > Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> > > Signed-off-by: Kalpak Shah <[EMAIL PROTECTED]> > > --- >

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-11 Thread Andreas Dilger
internal-only changes which need ext4_mark_inode_dirty(). We had a patch to disable ext4 inode versioning by a flag the superblock, but we dropped it at the last minute because it needed some updates and we didn't want to wait on that for submitting these changes upstream. Cheers, Andreas -- And

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-11 Thread Andreas Dilger
topic, but they aren't attached to the patch. s_want_extra_isize is just an override for sizeof(ext4_inode) in case the sysadmin wants to reserve more fields in new inodes. There is also s_min_extra_isize which is what the kernel and e2fsck guarantee that will be available in all in-use inodes

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-11 Thread Andreas Dilger
.info/?l=linux-ext4&m=115091699809181&w=2 > > Andreas or Kalpak, is changelog from the original patch is accurate to > apply here? Mostly, yes, but the name of the feature flag has changed. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc

Re: [ANNOUNCE] util-linux-ng 2.13-rc1

2007-07-05 Thread Andreas Dilger
brary so that e2fsprogs could use it. The only issue is the increased maintenance and packaging of separate libraries. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [EXT4 set 3][PATCH 1/1] ext4 nanosecond timestamp

2007-07-04 Thread Andreas Dilger
t;Missed this one. > >Thanks. Will update ext4 patch queue tonight with this fix. > > IIRC in the conference call it was decided to not to apply this patch. > Andreas may be able to update better. I wasn't on the most recent concall, and I've forgotten the details

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-03 Thread Andreas Dilger
be ordered between all inodes, is set by Lustre to be a transaction number). Instead of trying to incorporate this unused code into ext4 we just turn off the ext4 version code and let Lustre control this directly. It may even be that NFSv4 will need to control the version numbers itself... Ch

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-03 Thread Andreas Dilger
t systems we only ever had a 32-bit in-memory version anyway so using only the low 32 bits of i_version in f_version is no more racy than in the past. For 64-bit systems using the full on-disk i_version is possible. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Syste

Re: [EXT4 set 4][PATCH 4/5] i_version:ext4 inode version update

2007-07-03 Thread Andreas Dilger
do we set the qutoa file inodes version to 1 > during write ? Hmm, I thought we had previously fixed this? Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-07-01 Thread Andreas Dilger
(default keep prealloc) */ The other possible flags that were proposed, to avoid confusing backup and HSM applications when preallocated space is added or removed from a file (you don't want a backup app to re-backup a file that was migrated via HSM): FA_FL_NO_MTIME 0x10 /* keep same mt

Re: [PATCH 0/6][TAKE5] fallocate system call

2007-06-28 Thread Andreas Dilger
incremental over the previous set). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [AppArmor 00/44] AppArmor security module overview

2007-06-27 Thread Andreas Dilger
Any chance you can remove linux-fsdevel from the CC list? I don't think this has anything to do with filesystems. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH 7/7][TAKE5] ext4: support new modes

2007-06-26 Thread Andreas Dilger
hanism we now have - we can encode the various different behaviours in any way we want and leave it to the caller. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Andreas Dilger
On Jun 26, 2007 16:15 +0530, Amit K. Arora wrote: > On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote: > > In XFS one of the (many) ALLOC modes is to zero existing data on allocate. > > For ext4 all this would mean is calling ext4_ext_mark_uninitialized() on > &

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Andreas Dilger
On Jun 26, 2007 16:02 +0530, Amit K. Arora wrote: > On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote: > > Can you clarify - what is the current behaviour when ENOSPC (or some other > > error) is hit? Does it keep the current fallocate() or does it free it? > >

Re: vm/fs meetup in september?

2007-06-25 Thread Andreas Dilger
SIZE. I'll let the rest of you duke it out as long as at least one of them makes it into the kernel. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH 7/7][TAKE5] ext4: support new modes

2007-06-25 Thread Andreas Dilger
anging ctime, if that is required even though the file is not visibly changing. Maybe the ctime update should be implicit if the size or mtime are changing? Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-25 Thread Andreas Dilger
* default is keep existing data */ so that it doesn't imply this is only for DEALLOC. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-25 Thread Andreas Dilger
ot sure if this makes sense at all. > On Mon, Jun 25, 2007 at 07:15:00PM +0530, Amit K. Arora wrote: > > Implement new flags and values for mode argument. > > > > This patch implements the new flags and values for the "mode" argument > > of the fallocate syste

Re: [36/37] Large blocksize support for ext2

2007-06-20 Thread Andreas Dilger
past 64kB blocksize in any case. > > There shouldn't be a problem with increasing EXT{2,3,4}_MAX_BLOCK_SIZE to > > 32kB (AFAIK), but I haven't looked into this in a while. > > I'd love to see such a patch. That is also useful for arches that have > PAGE_SIZE &

Re: [36/37] Large blocksize support for ext2

2007-06-20 Thread Andreas Dilger
would break. There shouldn't be a problem with increasing EXT{2,3,4}_MAX_BLOCK_SIZE to 32kB (AFAIK), but I haven't looked into this in a while. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "uns

Re: [34/37] Large blocksize support in ramfs

2007-06-20 Thread Andreas Dilger
order = simple_strtoul(options, NULL, 10); This is probably a bad name for a mount option. What about "order=10"? Otherwise you prevent any other option from being used in the future. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsub

Re: Versioning file system

2007-06-18 Thread Andreas Dilger
he filesystem and RAID layers can move beyond "ignorance is bliss" when talking to each other would be great. Not rebuilding empty parts of the fs, limit parity resync to parts of the fs that were in the previous transaction, use fs-supplied checksums to verify on-disk data is correct,

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-06-14 Thread Andreas Dilger
On Jun 14, 2007 22:04 +1000, David Chinner wrote: > On Thu, Jun 14, 2007 at 03:14:58AM -0600, Andreas Dilger wrote: > > > B FA_DEALLOCATE > > > removes the underlying disk space with the given range. The disk space > > > shall be removed regardless of it'

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-06-14 Thread Andreas Dilger
not. In some (primitive) implementations it might no longer be possible to distinguish between unwritten extents and zero-filled blocks, though at this point DEALLOC of zero-filled blocks might not be harmful either. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File S

Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-04 Thread Andreas Dilger
eas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-25 Thread Andreas Dilger
lock is all about in the end). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

Re: [RFC 4/5] inode reservation v0.1 (benchmark result)

2007-05-24 Thread Andreas Dilger
what the mapping turns out to be - the goal is to place inodes with a similar hash into nearby inodes, and this heuristic works relatively well for that. Once the given leaf block's inode range is full then new inodes can be allocated from a new window as it was done for the newly-created d

Re: Software raid0 will crash the file-system, when each disk is 5TB

2007-05-16 Thread Andreas Dilger
your kernel has CONFIG_LBD enabled. The kernel doesn't check if the block layer can actually write to a block device > 2TB. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [PATCH 0/5][TAKE2] fallocate system call

2007-05-14 Thread Andreas Dilger
cation for whatever reason (interrupt, out of space, etc) like a regular write(2) call. In this case the return type needs to also be an loff_t to match @len. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "u

Re: [RFC][PATCH 13/14] ext3 whiteout support

2007-05-14 Thread Andreas Dilger
It isn't listed in the e2fsprogs repo. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [PATCH 2/2] file capabilities: accomodate >32 bit capabilities

2007-05-10 Thread Andreas Dilger
On May 08, 2007 16:49 -0500, Serge E. Hallyn wrote: > Quoting Andreas Dilger ([EMAIL PROTECTED]): > > One of the important use cases I can see today is the ability to > > split the heavily-overloaded e.g. CAP_SYS_ADMIN into much more fine > > grained attributes. > >

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-09 Thread Andreas Dilger
l allocation/ >unallocation ? I would say yes. If glibc does the fallback fallocate via write() the mtime/ctime will be updated, so it makes sense to be consistent for both methods. Also, it just makes sense from the "this file was modified" point of view. Cheers, Andreas -- Andr

Re: [PATCH 2/2] file capabilities: accomodate >32 bit capabilities

2007-05-08 Thread Andreas Dilger
n old kernel is relatively harmless if the old kernel doesn't know what they are. It's like having a key to a door that you don't know where it is. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send th

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Andreas Dilger
.g. indirect blocks). One of the design goals for sys_fallocate() was to allow FA_DELALLOC to deallocate unwritten extents in a safe manner. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-07 Thread Andreas Dilger
On May 07, 2007 19:02 -0400, Jeff Garzik wrote: > Andreas Dilger wrote: > >Actually, this is a non-issue. The reason that it is handled for > >extent-only is that this is the only way to allocate space in the > >filesystem without doing the explicit zeroing. > > P

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-07 Thread Andreas Dilger
do manual zero-filling of the file in userspace. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: JBD: ext2online wants too many credits (744 > 256)

2007-05-07 Thread Andreas Dilger
with the journal that is probably also a good and easy place to start (e.g. may be as easy as just giving a goal block of s_blocks_count / 2 to the journal create code). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: sen

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-07 Thread Andreas Dilger
then truncate_mutex is not needed. > > + ret = ext4_ext_get_blocks(handle, inode, block, > > + max_blocks, &map_bh, > > + EXT4_CREATE_UNINITIALIZED_EXT, 0); > > + BUG_ON(!ret); >

Re: JBD: ext2online wants too many credits (744 > 256)

2007-05-07 Thread Andreas Dilger
the right solution is for this. If you know you will be resizing the fs you could increase the initial journal size at mke2fs time (-J size=16). Alternately, it is possible resize to an intermediate size and then delete and recreate the journal via tune2fs (which would be the larger size by defa

Re: [PATCH 0/5] fallocate system call

2007-05-03 Thread Andreas Dilger
. I think I'd agree - it may be useful to allow preallocation beyond EOF for some kinds of applications (e.g. PVR preallocating live TV in 10 minute segments or something, but not knowing in advance how long the show will actually be recorded or the final encoded size). Cheers, Andreas -- A

Re: [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation)

2007-04-27 Thread Andreas Dilger
was fixed. There definitely are some problems with the ext3 journal commit though. If the journal is full it will cause the whole journal to checkpoint out to the filesystem synchronously even if just space for a small transaction is needed. That is doubly bad if you have a very large jour

Re: [RFC][PATCH] ChunkFS: fs fission for faster fsck

2007-04-25 Thread Andreas Dilger
re only a fsck of the corrupt chunk is done would not find the cnode references. Maybe there needs to be per-chunk info which contains a list/bitmap of other chunks that have cnodes shared with each chunk? Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.

Re: ChunkFS - measuring cross-chunk references

2007-04-23 Thread Andreas Dilger
ue to inode block references, or because of e.g. directories referencing inodes in another chunk. Also, is it considered a cross-chunk reference if a directory entry is referencing an inode in another group? Should there be a continuation inode in the local group, or is the directory entry itself e

Re: [PATCH] fix ext2 allocator overflows above 31 bit blocks

2007-04-20 Thread Andreas Dilger
re needs to be some limits imposed for the sake of usability. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: Interface for the new fallocate() system call

2007-04-18 Thread Andreas Dilger
mode" can then be made part of it. We need at least mode="unallocate" or a separate funallocate() call to allow allocated-but-unwritten blocks to be unallocated without actually punching out written data. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster F

Re: [PATCH 5/13] ext4: use zero_user_page

2007-04-10 Thread Andreas Dilger
ernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Would have been better to CC the filesystem maintainers directly (which was one of the reasons Andrew wanted per-fs patches so they can be Ack/Nack independently. Looks good in any case, Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> > diff -

Re: Add a norecovery option to ext3/4?

2007-04-09 Thread Andreas Dilger
l? If that disk was actually in use on another system but just exported via a SAN to this node you've potentially corrupted the filesystem. It's a bad idea to just go ahead and mount filesystems that you aren't told to mount. Cheers, Andreas -- Andreas Dilger Principal Software Engi

Re: Interface for the new fallocate() system call

2007-04-06 Thread Andreas Dilger
; mode) > { > return sys_fallocate(fd, offset, len, mode); > } Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mo

[PATCH] clarify CONFIG_DEBUG_INFO help text

2007-03-27 Thread Andreas Dilger
ut it is only enabling the "gcc -g" compile option in the Makefile. Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]> --- ./lib/Kconfig.debug.orig2007-02-07 17:10:34.0 -0700 +++ ./lib/Kconfig.debug 2007-03-27 13:32:17.0 -0600 @@ -322,6 +322,9 @@ help

Re: [PATCH] ext3: dirindex error pointer issues

2007-03-04 Thread Andreas Dilger
ntry() it appears like we should "goto journal_error" to report an error after the failed call to do_split(), instead of just "goto cleanup" so that we report an error in the filesystem. Not 100% sure of this. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster Fi

Re: [RFC] Heads up on sys_fallocate()

2007-03-02 Thread Andreas Dilger
llocate" would do for persistent allocations and it would be useful for files that were not preallocated. For filesystems that don't implement punch glibc() would do zero-filling of the punched area I guess (to make it equivalent to reading from a hole in the file). Cheers, Andreas -- A

Re: [PATCH/RFC] Delete JFFS (version 1)

2006-12-12 Thread Andreas Dilger
or removal in > + 2.6.21. See Documentation/feature-removal-schedule.txt > + It would be better to have a printk in the module init, since users with upstream builds won't see the config help. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc.

Re: [PATCH] ext3: htree entry integrity checking

2006-11-16 Thread Andreas Dilger
KB-10-11-2006.html Would also be good to CC linux-ext4, where the ext3 maintainers live. Hmm, maybe we need to update MAINTAINERS with the new list address? Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line

Re: [Ext2-devel] Re: CheckFS: Checkpoints and Block Level Incremental Backup (BLIB)

2005-08-02 Thread Andreas Dilger
ted patch. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Ext2-devel] OOM problems still left in 2.6.13-rc3

2005-07-29 Thread Andreas Dilger
mmit(journal, wait_tid); > +goto retry; > + } > + may_free &= ret; What kind of effect does this have on filesystem performance? This would apparently make truncate be synchronous with journal commit due to truncate_{partial,complete}_page->do_invalidatepage->journal_invali

Re: [2.6 patch] fs/jbd/: cleanups

2005-07-20 Thread Andreas Dilger
wing write-only global variable: > - journal.c: current_journal > - remove the following unneeded EXPORT_SYMBOL: > - journal.c: journal_recover > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andreas Dilger <[EMAIL PROTECTED]&g

Re: [Ext2-devel] [RFC] [PATCH 2/4]delayed allocation for ext3

2005-07-18 Thread Andreas Dilger
k(KERN_WARNING "EXT3-fs: Ignoring delall option - " > + "its supported only with writeback mode\n"); Should be "ignoring delalloc option". Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send

Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Andreas Dilger
On Jul 13, 2005 00:43 +0200, Adrian Bunk wrote: > On Tue, Jul 12, 2005 at 04:32:44PM -0600, Andreas Dilger wrote: > > I don't mind removing this function, but it shouldn't be put inside #ifdef > > JBD_DEBUG, as that would remove the check from the compiler-parsed code &

Re: [2.6 patch] fs/jbd/: possible cleanups

2005-07-12 Thread Andreas Dilger
nal_bad_superblock_size(); > + > + > ret = journal_init_caches(); > if (ret != 0) > journal_destroy_caches(); > --- linux-2.6.12-rc6-mm1-full/fs/jbd/revoke.c.old 2005-06-14 > 03:58:36.0 +0200 > +++ linux-2.6.12-rc6-mm1-full/fs/jbd/revoke.c 2005-

Re: Adding a field to ext2_dir_entry_2

2005-04-04 Thread Andreas Dilger
y. This key must be stored in the inode along with the ownership info (it can be an EA, and possibly a fast EA or fixed inode field in a large inode). Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. pgp4ctWP2BNB4.pgp Description: PGP signature

Re: Adding a field to ext2_dir_entry_2

2005-04-04 Thread Andreas Dilger
any other version of Linux. What is more important is why you want to do this - there are other mechanisms that may be more appropriate depending on what you are doing. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. pgpgk0QSCZcUK.pgp Description: PGP signature

Re: Industry db benchmark result on recent 2.6 kernels

2005-04-02 Thread Andreas Dilger
ssue isn't the storage capacity, but rather the ability to have lots of heads seeking concurrently to access the many database tables. At one large site I used to work at, the database ran on hundreds of 1, 2, and 4GB disks long after they could be replaced by many fewer, larger disks... Che

Re: Directory link count wrapping on Linux/XFS/i386?

2005-03-30 Thread Andreas Dilger
no longer optimizes subdirectory traversal and checks each entries filetype to see if it should recurse. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. pgpE2YlgGszUT.pgp Description: PGP signature

Re: huge filesystems

2005-03-14 Thread Andreas Dilger
ve to hack the > partition tables and fake out dsfs with 3TB abd 4TB drives created with > RAID 0 controllers and hardware. This needs to get fixed. Use a different partition format (e.g. EFI or devicemapper) or none at all. That is better than just ignoring the whole thing and some user think

Re: Exuberant ctags can tag files names too

2005-03-14 Thread Andreas Dilger
as the --extra=+f support, so I doubt it will hurt many people to make it default. Cheers, Andreas -- Andreas Dilger http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: huge filesystems

2005-03-14 Thread Andreas Dilger
ilesystems > 2TB so I don't think it has really been tested very much. Cheers, Andreas -- Andreas Dilger http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [Ext2-devel] Re: [CHECKER] crash after fsync causing serious FS corruptions (ext2, 2.6.11)

2005-03-07 Thread Andreas Dilger
to disk. Now we > end up with a file system where a block is shared by two files. > > I'm not sure how the invalid block number warning is triggered. If B file was larger than 48kB, and you are filling it with e.g. 0xffe then this could overwrite file A's indirect block from the

Re: [PATCH] whitespace cleanups for fs/cifs/file.c

2005-03-07 Thread Andreas Dilger
gt;private_data and initialize the masses of fields would be good. Is it possible that pCifsInode can ever be NULL??? Similarly, "if (buf)" on line 196 is needless, as it has already been checked on line 153 (and we abort in that case). Also, kfree() can handle NULL pointers.

Re: O_DIRECT on 2.4 ext3

2005-03-01 Thread Andreas Dilger
though there was a patch at one time. Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/ pgpRKdFyTZvk0.pgp Description: PGP signature

Re: [2.6 patch] unexport do_settimeofday

2005-02-25 Thread Andreas Dilger
see any use for it, lets get rid of it because it's not useful" changing is just a source of grief for anyone that doesn't have their code in the kernel. Cheers, Andreas -- Andreas Dilger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH] ext3: Fix sparse -Wbitwise warnings.

2005-02-15 Thread Andreas Dilger
k) ) != 0) > > be enough to satisfy sparse? Or we could cast "mask" to the appropriate type (I'm not sure what sparse uses to determine this). Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/ pgphLeAEUOvy0.pgp Description: PGP signature

Re: Ext2/3 32-bit stat() wrap for ~2TB files

2005-02-11 Thread Andreas Dilger
for the largest files with extents. Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/ pgpUNyrXspuZc.pgp Description: PGP signature

Re: Ext2/3 32-bit stat() wrap for ~2TB files

2005-02-11 Thread Andreas Dilger
> res = (512LL << 32) - (1 << bits); So, for the quick fix we could reduce this by the number of expected [td]indirect blocks and submit that to 2.4 also. Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/ pgpgDW3JowkjV.pgp Description: PGP signature

<    1   2   3   4   5   6   7   >