[PATCH] i386: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
This fix is needed for AMD family 10h CPUs. It prevents auto select of mwait_idle for AMD CPUs. MWAIT does not enter C-states on family 10h and more power saving is reached by entering C1 with default_idle. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu

[PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
for benchmarking. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> --- arch/x86_64/kernel/process.c|9 +++-- arch/x86_64/kernel/setup.c |4 include/asm-x86_64/cpufeature.h |1 + 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/x86_64/kernel/process.c

[PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
for benchmarking. Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] --- arch/x86_64/kernel/process.c|9 +++-- arch/x86_64/kernel/setup.c |4 include/asm-x86_64/cpufeature.h |1 + 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/x86_64/kernel/process.c b/arch

[PATCH] i386: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
This fix is needed for AMD family 10h CPUs. It prevents auto select of mwait_idle for AMD CPUs. MWAIT does not enter C-states on family 10h and more power saving is reached by entering C1 with default_idle. Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] --- arch/i386/kernel/cpu/amd.c

Re: [PATCH] x86_64: prevent auto select of mwait_idle for AMD CPUs

2007-04-10 Thread Andreas Herrmann
Actually I have also written patches to clear the MWAIT flag for AMD CPUs. But after re-reading of specs (also Intel's specs) I preferred to keep the MWAIT flag but to introduce a MWAIT_NO_CSTATE flag. I think this is the cleaner solution. Regards, Andreas - To unsubscribe from this list:

[PATCH RFC] x86: clear X86_FEATURE_MWAIT for AMD Fam10 CPU

2007-04-05 Thread Andreas Herrmann
Hi, I send this as RFC because I won't manage it to test it before end of Easter but want to have a consensus about how the final patch should look like. Andi, what do you finally prefer? (1) Something like the attached patch or (2) a version which keeps to the MWAIT flag for Fam10 but

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
On Thu, Apr 05, 2007 at 05:37:17PM +0200, Andi Kleen wrote: > > > > > This patch will enable default_idle for non-Intel > > > > CPUs even if mwait is supported. > > > > > > It would be better to clear MONITOR/MWAIT in the AMD specific > > > CPU initialize code than add workarounds everywhere

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
On Thu, Apr 05, 2007 at 04:24:45PM +0200, Andi Kleen wrote: > On Thursday 05 April 2007 16:00:45 Andreas Herrmann wrote: > > > > Commit 991528d7348667924176f3e29addea0675298944 > > introduced mwait_idle which is supposed to work > > for Intel CPUs starting with C

[PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
Commit 991528d7348667924176f3e29addea0675298944 introduced mwait_idle which is supposed to work for Intel CPUs starting with Core Duo. AMD Fam10 processors won't enter C1 on mwait. This patch will enable default_idle for non-Intel CPUs even if mwait is supported. Signed-off-by: Andreas Herrmann

[PATCH RFC] x86: clear X86_FEATURE_MWAIT for AMD Fam10 CPU

2007-04-05 Thread Andreas Herrmann
Hi, I send this as RFC because I won't manage it to test it before end of Easter but want to have a consensus about how the final patch should look like. Andi, what do you finally prefer? (1) Something like the attached patch or (2) a version which keeps to the MWAIT flag for Fam10 but

[PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
Commit 991528d7348667924176f3e29addea0675298944 introduced mwait_idle which is supposed to work for Intel CPUs starting with Core Duo. AMD Fam10 processors won't enter C1 on mwait. This patch will enable default_idle for non-Intel CPUs even if mwait is supported. Signed-off-by: Andreas Herrmann

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
On Thu, Apr 05, 2007 at 04:24:45PM +0200, Andi Kleen wrote: On Thursday 05 April 2007 16:00:45 Andreas Herrmann wrote: Commit 991528d7348667924176f3e29addea0675298944 introduced mwait_idle which is supposed to work for Intel CPUs starting with Core Duo. AMD Fam10 processors won't

Re: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread Andreas Herrmann
On Thu, Apr 05, 2007 at 05:37:17PM +0200, Andi Kleen wrote: This patch will enable default_idle for non-Intel CPUs even if mwait is supported. It would be better to clear MONITOR/MWAIT in the AMD specific CPU initialize code than add workarounds everywhere else. Why is

Re: [discuss] [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Tue, Feb 06, 2007 at 10:54:23AM -0700, [EMAIL PROTECTED] wrote: > "Andreas Herrmann" <[EMAIL PROTECTED]> writes: > > On Mon, Feb 05, 2007 at 05:26:12PM -0700, [EMAIL PROTECTED] wrote: > >> "Andreas Herrmann" <[EMAIL PROTECTED]> writes: > >

Re: [discuss] [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Tue, Feb 06, 2007 at 11:54:57AM +0100, Andi Kleen wrote: > On Tuesday 06 February 2007 10:53, Jan Beulich wrote: > > >> I don't think I remember a restriction here, at least not below 44 bits > > >> (that's where pfn-s would need to become 64-bit wide). > > > > > >The i386 mm code only supports

Re: [discuss] [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Tue, Feb 06, 2007 at 09:31:45AM +, Jan Beulich wrote: > >>> Andi Kleen <[EMAIL PROTECTED]> 06.02.07 08:53 >>> > >On Monday 05 February 2007 23:50, Siddha, Suresh B wrote: > >> On Mon, Feb 05, 2007 at 06:19:59PM +0100, Andreas Herrmann wrote: >

Re: [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Mon, Feb 05, 2007 at 05:26:12PM -0700, [EMAIL PROTECTED] wrote: > "Andreas Herrmann" <[EMAIL PROTECTED]> writes: > > mtrr: fix issues with large addresses > > > > Fixes some issues with /proc/mtrr interface: > > o If physical address size cro

Re: [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Mon, Feb 05, 2007 at 05:26:12PM -0700, [EMAIL PROTECTED] wrote: Andreas Herrmann [EMAIL PROTECTED] writes: mtrr: fix issues with large addresses Fixes some issues with /proc/mtrr interface: o If physical address size crosses the 44 bit boundary size_or_mask is evaluated wrong o

Re: [discuss] [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Tue, Feb 06, 2007 at 09:31:45AM +, Jan Beulich wrote: Andi Kleen [EMAIL PROTECTED] 06.02.07 08:53 On Monday 05 February 2007 23:50, Siddha, Suresh B wrote: On Mon, Feb 05, 2007 at 06:19:59PM +0100, Andreas Herrmann wrote: o added check to restrict base address to 36 bit on i386

Re: [discuss] [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Tue, Feb 06, 2007 at 11:54:57AM +0100, Andi Kleen wrote: On Tuesday 06 February 2007 10:53, Jan Beulich wrote: I don't think I remember a restriction here, at least not below 44 bits (that's where pfn-s would need to become 64-bit wide). The i386 mm code only supports 4 entries in

Re: [discuss] [patch] mtrr: fix issues with large addresses

2007-02-06 Thread Andreas Herrmann
On Tue, Feb 06, 2007 at 10:54:23AM -0700, [EMAIL PROTECTED] wrote: Andreas Herrmann [EMAIL PROTECTED] writes: On Mon, Feb 05, 2007 at 05:26:12PM -0700, [EMAIL PROTECTED] wrote: Andreas Herrmann [EMAIL PROTECTED] writes: The limit is per cpu not per architecture. So if you run a cpu

[patch] mtrr: fix issues with large addresses

2007-02-05 Thread Andreas Herrmann
than 44 bit o added check to restrict base address to 36 bit on i386 Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> -- diff --git a/arch/i386/kernel/cpu/mtrr/generic.c b/arch/i386/kernel/cpu/mtrr/generic.c index f77fc53..aa21d15 100644 --- a/arch/i386/kernel/cpu/mtrr/generic.c +++ b/arc

[patch] mtrr: fix issues with large addresses

2007-02-05 Thread Andreas Herrmann
than 44 bit o added check to restrict base address to 36 bit on i386 Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] -- diff --git a/arch/i386/kernel/cpu/mtrr/generic.c b/arch/i386/kernel/cpu/mtrr/generic.c index f77fc53..aa21d15 100644 --- a/arch/i386/kernel/cpu/mtrr/generic.c +++ b/arch/i386

[patch] mtrr: fix size_or_mask and size_and_mask

2007-01-22 Thread Andreas Herrmann
mtrr: fix size_or_mask and size_and_mask This fixes two bugs in /proc/mtrr interface: o If physical address size crosses the 44 bit boundary size_or_mask is evaluated wrong. o size_and_mask limits width of physical base address for an MTRR to be less than 44 bits. Signed-off-by: Andreas

[patch] mtrr: fix size_or_mask and size_and_mask

2007-01-22 Thread Andreas Herrmann
mtrr: fix size_or_mask and size_and_mask This fixes two bugs in /proc/mtrr interface: o If physical address size crosses the 44 bit boundary size_or_mask is evaluated wrong. o size_and_mask limits width of physical base address for an MTRR to be less than 44 bits. Signed-off-by: Andreas

Re: [PATCH] zfcp: add rports to enable scsi_add_device to work again

2005-08-29 Thread Andreas Herrmann
On 27.08.2005 19:38 James Bottomley <[EMAIL PROTECTED]> wrote: > > this patch fixes a severe problem with 2.6.13-rc7. > > > > Due to recent SCSI changes it is not possible to add any > > LUNs to the zfcp device driver anymore. With registration > > of remote ports this is fixed. > >

Re: [PATCH] zfcp: add rports to enable scsi_add_device to work again

2005-08-29 Thread Andreas Herrmann
On 27.08.2005 19:38 James Bottomley [EMAIL PROTECTED] wrote: this patch fixes a severe problem with 2.6.13-rc7. Due to recent SCSI changes it is not possible to add any LUNs to the zfcp device driver anymore. With registration of remote ports this is fixed. Please

[PATCH] zfcp: add rports to enable scsi_add_device to work again

2005-08-27 Thread Andreas Herrmann
then please integrate it in 2.6.13.1 Thanks a lot. Regards, Andreas Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diffstat: zfcp_aux.c | 29 +++-- zfcp_ccw.c | 10 ++ zfcp_def.h |2 +- zfcp_erp.c | 25 ++--- zfcp

[PATCH] zfcp: add rports to enable scsi_add_device to work again

2005-08-27 Thread Andreas Herrmann
then please integrate it in 2.6.13.1 Thanks a lot. Regards, Andreas Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] diffstat: zfcp_aux.c | 29 +++-- zfcp_ccw.c | 10 ++ zfcp_def.h |2 +- zfcp_erp.c | 25 ++--- zfcp_ext.h

Re: [PATCH] remove name length check in a workqueue

2005-08-11 Thread Andreas Herrmann
Simon Derr <[EMAIL PROTECTED]> wrote: > It is sufficient to have a few HBAs and to insmod/rmmod the driver a few > times. > Since the host_no is choosen with a mere counter increment > in scsi_host_alloc(): > shost->host_no = scsi_host_next_hn++; /* XXX(hch): still

Re: [PATCH] remove name length check in a workqueue

2005-08-11 Thread Andreas Herrmann
Simon Derr [EMAIL PROTECTED] wrote: It is sufficient to have a few HBAs and to insmod/rmmod the driver a few times. Since the host_no is choosen with a mere counter increment in scsi_host_alloc(): shost-host_no = scsi_host_next_hn++; /* XXX(hch): still racy */

[PATCH] zfcp: fix compile error

2005-04-21 Thread Andreas Herrmann
will fix the problem. Sorry, for any inconvenience. Regards, Andreas zfcp: fix compile error Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> diff -bBrauN linux-2.6.x/drivers/s390/scsi-orig/zfcp_aux.c linux-2.6.x/drivers/s390/scsi/zfcp_aux.c --- linux-2.6.x/drivers/s390/scsi-orig/zfcp_aux.c

[PATCH] zfcp: fix compile error

2005-04-21 Thread Andreas Herrmann
, Andreas zfcp: fix compile error Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] diff -bBrauN linux-2.6.x/drivers/s390/scsi-orig/zfcp_aux.c linux-2.6.x/drivers/s390/scsi/zfcp_aux.c --- linux-2.6.x/drivers/s390/scsi-orig/zfcp_aux.c 2005-04-21 12:36:44.0 +0200 +++ linux-2.6.x

<    1   2   3   4