[PATCH v3] dmaengine: fsl-edma: disable clks on all error paths

by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- V2->V3: in V2 i added the clk_disable_unprepare() directly into the error paths. Vinod Koul then suggested to modify fsl_disable_clocks() and consistent

[PATCH v3] dmaengine: fsl-edma: disable clks on all error paths

by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek --- V2->V3: in V2 i added the clk_disable_unprepare() directly into the error paths. Vinod Koul then suggested to modify fsl_disable_clocks() and consistently invoke that to disable + unprepare clocks. driv

[PATCH] usb: dwc3: of-simple: fix missing clk_disable_unprepare

t;usb: dwc3: ep0: fix setup_packet_pending initialization") Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- NOTE: This was only compile-tested drivers/usb/dwc3/dwc3-of-simple.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/

[PATCH] usb: dwc3: of-simple: fix missing clk_disable_unprepare

t;usb: dwc3: ep0: fix setup_packet_pending initialization") Signed-off-by: Andreas Platschek --- NOTE: This was only compile-tested drivers/usb/dwc3/dwc3-of-simple.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb

[PATCH 2/2] rtc: omap: fix unbalanced clk_prepare_enable/clk_disable_unprepare

There are 2 error paths after clk_prepare_enable() was called, where clk_disable_unprepare() is missing. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- drivers/rtc/rtc-omap.c | 5 - 1 file chan

[PATCH 2/2] rtc: omap: fix unbalanced clk_prepare_enable/clk_disable_unprepare

There are 2 error paths after clk_prepare_enable() was called, where clk_disable_unprepare() is missing. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek --- drivers/rtc/rtc-omap.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH 1/2] rtc: omap: check for clk_prepare_enable() error

clk_prepare_enable() returns an error -> check it. Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- drivers/rtc/rtc-omap.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 1d6

[PATCH 1/2] rtc: omap: check for clk_prepare_enable() error

clk_prepare_enable() returns an error -> check it. Signed-off-by: Andreas Platschek --- drivers/rtc/rtc-omap.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index 1d666ac9ef70..ad309feb7d11 100644 --- a/driv

[PATCH 0/2] rtc: omap: clk_prepare_enable error handling

The unbalanced clk_prepare_enable/clk_disable_unprepare were found by Linux Driver Verification project (linuxtesting.org). While going through the report from LDV, the missing check of the return value from clk_prepare_enable() was found. Andreas Platschek (2): rtc: omap: check

[PATCH 0/2] rtc: omap: clk_prepare_enable error handling

The unbalanced clk_prepare_enable/clk_disable_unprepare were found by Linux Driver Verification project (linuxtesting.org). While going through the report from LDV, the missing check of the return value from clk_prepare_enable() was found. Andreas Platschek (2): rtc: omap: check

[PATCH v2] dmaengine: fsl-edma: disable clks on all error paths

Previously enabled clks are only disabled if clk_prepare_enable() fails. However, there are other error paths were the previously enabled clocks are not disabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek <andreas.platsc...@opentech

[PATCH v2] dmaengine: fsl-edma: disable clks on all error paths

Previously enabled clks are only disabled if clk_prepare_enable() fails. However, there are other error paths were the previously enabled clocks are not disabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek --- drivers/dma/fsl-edma.c | 13

Re: [PATCH] dmaengine: fsl-edma: disable clks on all error paths

Hi, On Wed, 06 Dec 2017, Andreas Platschek wrote: > Previously enabled clks are only disabled if clk_prepare_enable() fails. > However, there are other error paths were the previously enabled > clocks are not disabled. > > Found by Linux Driver Verification project (l

Re: [PATCH] dmaengine: fsl-edma: disable clks on all error paths

Hi, On Wed, 06 Dec 2017, Andreas Platschek wrote: > Previously enabled clks are only disabled if clk_prepare_enable() fails. > However, there are other error paths were the previously enabled > clocks are not disabled. > > Found by Linux Driver Verification project (l

[PATCH] dmaengine: fsl-edma: disable clks on all error paths

Previously enabled clks are only disabled if clk_prepare_enable() fails. However, there are other error paths were the previously enabled clocks are not disabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek <andreas.platsc...@opentech

[PATCH] dmaengine: fsl-edma: disable clks on all error paths

Previously enabled clks are only disabled if clk_prepare_enable() fails. However, there are other error paths were the previously enabled clocks are not disabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Andreas Platschek --- drivers/dma/fsl-edma.c | 13

[PATCH 1/2] trace-cmd: Makefile - link all trace-* objects into ctracecmd.so

racecmd.so: undefined symbol: get_file_content linking the objects that contain those symbols fixes the problem. Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- Makefile |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index

[PATCH 0/2] trace-cmd: fix building of the python interface

Build the python interface I experienced some problems, the following changes fixed those problems. Andreas Platschek (2): trace-cmd: Makefile - link all trace-* objects into ctracecmd.so trace-cmd: python interface: add global variables to swig interface Makefile|3 ++- ctracecmd.i

[PATCH 1/2] trace-cmd: Makefile - link all trace-* objects into ctracecmd.so

racecmd.so: undefined symbol: get_file_content linking the objects that contain those symbols fixes the problem. Signed-off-by: Andreas Platschek --- Makefile |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 62cb25b..f86cb77 100644 --- a/Make

[PATCH 0/2] trace-cmd: fix building of the python interface

Build the python interface I experienced some problems, the following changes fixed those problems. Andreas Platschek (2): trace-cmd: Makefile - link all trace-* objects into ctracecmd.so trace-cmd: python interface: add global variables to swig interface Makefile|3 ++- ctracecmd.i

[PATCH 2/2] trace-cmd: python interface: add global variables to swig interface

/home/andi/working_git/trace-cmd/ctracecmd.so: undefined symbol: silence_warnings Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- ctracecmd.i |2 ++ 1 file changed, 2 insertions(+) diff --git a/ctracecmd.i b/ctracecmd.i index e91d068..7800470 100644 --- a/ctracecmd.i +

[PATCH 2/2] trace-cmd: python interface: add global variables to swig interface

/home/andi/working_git/trace-cmd/ctracecmd.so: undefined symbol: silence_warnings Signed-off-by: Andreas Platschek --- ctracecmd.i |2 ++ 1 file changed, 2 insertions(+) diff --git a/ctracecmd.i b/ctracecmd.i index e91d068..7800470 100644 --- a/ctracecmd.i +++ b/ctracecmd.i @@ -35,6 +35,8 @@

[PATCH 0/2] Kconfig: fix references to documenation

Documentation of development tools (ubsan, kmemleak, etc.) was moved and renamed during sphinxification of Documentation. References to this Documentation thus need to be fixed. Andreas Platschek (2): Kconfig: lib/Kconfig.debug: fix references to Documenation Kconfig: lib/Kconfig.ubsan fix

[PATCH 0/2] Kconfig: fix references to documenation

Documentation of development tools (ubsan, kmemleak, etc.) was moved and renamed during sphinxification of Documentation. References to this Documentation thus need to be fixed. Andreas Platschek (2): Kconfig: lib/Kconfig.debug: fix references to Documenation Kconfig: lib/Kconfig.ubsan fix

[PATCH 2/2] Kconfig: lib/Kconfig.ubsan fix reference to ubsan documentation

Documenation/ubsan.txt was moved to Documentation/dev-tools/ubsan.rst, this fixes the reference. Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- lib/Kconfig.ubsan | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig.ubsan b/lib/Kconfig

[PATCH 2/2] Kconfig: lib/Kconfig.ubsan fix reference to ubsan documentation

Documenation/ubsan.txt was moved to Documentation/dev-tools/ubsan.rst, this fixes the reference. Signed-off-by: Andreas Platschek --- lib/Kconfig.ubsan | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan index bc6e651..a669c19 100644

[PATCH 1/2] Kconfig: lib/Kconfig.debug: fix references to Documenation

Documentation on development tools was moved to Documentation/devl-tools and sphinxified (renamed from .txt to .rst). References in lib/Kconfig.debug need to be updated to the new location. Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- lib/Kconfig.debug | 8 -

[PATCH 1/2] Kconfig: lib/Kconfig.debug: fix references to Documenation

Documentation on development tools was moved to Documentation/devl-tools and sphinxified (renamed from .txt to .rst). References in lib/Kconfig.debug need to be updated to the new location. Signed-off-by: Andreas Platschek --- lib/Kconfig.debug | 8 1 file changed, 4 insertions(+), 4

[PATCH] Makefile: fix reference to sparse documentation

Documenation/sparse.txt was moved to Documentation/dev-tools/sparse.rst, this fixes the reference. Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d8c784d..d7157a1

[PATCH] Makefile: fix reference to sparse documentation

Documenation/sparse.txt was moved to Documentation/dev-tools/sparse.rst, this fixes the reference. Signed-off-by: Andreas Platschek --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d8c784d..d7157a1 100644 --- a/Makefile +++ b/Makefile

[PATCH] kmemleak: fix reference to Documentation

Documentation/kmemleak.txt was moved to Documentation/dev-tools/kmemleak.rst, this fixes the reference to the new location. Signed-off-by: Andreas Platschek <andreas.platsc...@opentech.at> --- mm/kmemleak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmemleak.

[PATCH] kmemleak: fix reference to Documentation

Documentation/kmemleak.txt was moved to Documentation/dev-tools/kmemleak.rst, this fixes the reference to the new location. Signed-off-by: Andreas Platschek --- mm/kmemleak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index a5e453c..d00fae0

Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()

Hi, On 11/22/2013 09:09 AM, walter harms wrote: > > Am 21.11.2013 20:12, schrieb Andreas Platschek: >> Use tty_write_lock()/tty_write_unlock() consistently. >> >> This takes care of the following sparse warning: >> drivers/tty/tty_io.c:1169:17: warning: context imbal

Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()

Hi, On 11/22/2013 09:09 AM, walter harms wrote: Am 21.11.2013 20:12, schrieb Andreas Platschek: Use tty_write_lock()/tty_write_unlock() consistently. This takes care of the following sparse warning: drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message

[PATCH] driver-core: only call kfree() if memory was allocated

There are several cases where we could bail out of show_uevent() before kzalloc() is even called. In those cases we don't want to call kfree(). In addition the error handling of kzalloc() is now using the single point of exit as well. Signed-off-by: Andreas Platschek --- drivers/base/core.c

[PATCH] driver-core: only call kfree() if memory was allocated

There are several cases where we could bail out of show_uevent() before kzalloc() is even called. In those cases we don't want to call kfree(). In addition the error handling of kzalloc() is now using the single point of exit as well. Signed-off-by: Andreas Platschek andi.platsc...@gmail.com

[PATCH] tty: Remove dead code

-> The ledptrs[] array is never initialized. -> There is no place where kbd->ledmode is set to LED_SHOW_MEM therefore the if statement does not make much sense. -> Since LED_SHOW_MEM is not used, it can be removed from the header file as well. Signed-off-by: Andreas Platschek

[PATCH] tty: Remove dead code

- The ledptrs[] array is never initialized. - There is no place where kbd-ledmode is set to LED_SHOW_MEM therefore the if statement does not make much sense. - Since LED_SHOW_MEM is not used, it can be removed from the header file as well. Signed-off-by: Andreas Platschek andi.platsc