On Sat, Feb 20, 2021 at 08:12:45PM +0100, Álvaro Fernández Rojas wrote:
> Hi Andrew,
>
> I ran rngtest and this is what I got:
> root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000
> rngtest 6.10
> Copyright (c) 2004 by Henrique de Moraes Holschuh
> This is free software; see t
or 0 for unknown).
How did you determine this device produces 1000 bits of true entropy
per 1024?
Andrew
e)
> {
> ...
> }
>
> and calling that from both these locations to configure the PHY for
> 10GBASE-R, 1000BASE-X and SGMII modes.
Agreed. This got me confused, wondering where the SGMII handling was.
Andrew
is does not seem very
reliable, and likely to cause confusion. It works sometimes, not
others. I'm not sure this is a good idea.
> +static void mv_remove(struct phy_device *phydev)
> +{
> + struct device *dev = >mdio.dev;
> + struct mv_data *priv = phydev->priv;
> +
> + if (priv)
> + devm_kfree(dev, priv);
Why can devm_kfree(). The point of devm_ is that it frees itself.
Andrew
> If in doubt, leaving the patch as is would be fine with me.
The patch is O.K. as is, no need to export something so simple for a
single users. When the next user come along, we can reconsider.
Andrew
On Fri, 19 Feb 2021 01:54:30 + Anton Altaparmakov wrote:
> Hi Andrew,
>
> Can you please push this one upstream? Thanks a lot in advance!
The changelog is a bit brief...
>
> > On 17 Feb 2021, at 15:59, Rustam Kovhaev wrote:
> >
> > we should check
ssing both offsets in the one system call may block if the
data registers are not ready.
Signed-off-by: Andrew Jeffery
---
Documentation/ABI/testing/dev-raw-kcs | 25 ++
drivers/char/ipmi/Kconfig | 17 +
drivers/char/ipmi/Makefile| 1 +
drivers/char/ipmi/kcs_bmc_cdev_ra
Given the deprecated binding, improve the ability to detect issues in
the platform devicetrees. Further, a subsequent patch will introduce a
new interrupts property for specifying SerIRQ behaviour, so convert
before we do any further additions.
Signed-off-by: Andrew Jeffery
---
.../bindings
file. The code
continues to build into the same module.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/Makefile| 2 +-
drivers/char/ipmi/kcs_bmc.c | 423 +
drivers/char/ipmi/kcs_bmc.h | 10 +-
drivers/char/ipmi/kcs_bmc_cdev_ipmi.c
Input Buffer Full Interrupt Enable (IBFIE) is typoed as IBFIF for some
registers in the datasheet. Fix the driver to use the sensible acronym.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc_aspeed.c | 24
1 file changed, 12 insertions(+), 12 deletions
Strengthen the distinction between code that abstracts the
implementation of the KCS behaviours (device drivers) and code that
exploits KCS behaviours (clients). Neither needs to know about the APIs
required by the other, so provide separate headers.
Signed-off-by: Andrew Jeffery
---
drivers
Apply the SerIRQ ID and level/sense behaviours from the devicetree if
provided.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc_aspeed.c | 126 +
1 file changed, 126 insertions(+)
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c
b/drivers/char/ipmi
an OBE interrupt for the BMC. Instead we pretend it has one by
polling the status register waiting for the Output Buffer Full (OBF) bit
to clear, and generating an event when OBE is observed.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc.c | 6 ++
drivers/char/ipmi
Now that we have untangled the data-structures, split the userspace
interface out into its own module. Userspace interfaces and drivers are
registered to the KCS BMC core to support arbitrary binding of either.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/Kconfig | 13
as required.
Finally, now that it is free of client data, `struct kcs_bmc` is renamed
to `struct kcs_bmc_device` to contrast `struct kcs_bmc_client`.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc.c | 68 -
drivers/char/ipmi/kcs_bmc.h | 86 +-
drivers
devices to describe SerIRQ properties.
Signed-off-by: Andrew Jeffery
---
.../bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 14 ++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml
b/Documentation/devicetree/bindings/ipmi
From: "Chia-Wei, Wang"
Add check against LPC device v2 compatible string to
ensure that the fixed device tree layout is adopted.
The LPC register offsets are also fixed accordingly.
Signed-off-by: Chia-Wei Wang
Reviewed-by: Andrew Jeffery
Tested-by: Andrew Jeffery
---
drivers/
Enable more efficient implementation of read-modify-write sequences.
Both device drivers for the KCS BMC stack use regmaps. The new callback
allows us to exploit regmap_update_bits().
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc.c | 7 +--
drivers/char/ipmi/kcs_bmc.h
a layer off the onion and turn the data-structures inside out by
exploiting container_of() and embedding `struct kcs_device` in the
driver private data.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc.c | 15 +--
drivers/char/ipmi/kcs_bmc.h | 12 ++
drivers
Unpack and remove the aspeed_kcs_probe_of_v[12]() functions to aid
rearranging how the private device-driver memory is allocated.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc_aspeed.c | 146 ++---
1 file changed, 68 insertions(+), 78 deletions(-)
diff
Rename the functions in preparation for separating the IPMI chardev out
from the KCS BMC core.
Signed-off-by: Andrew Jeffery
---
drivers/char/ipmi/kcs_bmc.c | 52 ++---
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/drivers/char/ipmi/kcs_bmc.c b
From: "Chia-Wei, Wang"
Add check against LPC device v2 compatible string to
ensure that the fixed device tree layout is adopted.
The LPC register offsets are also fixed accordingly.
Signed-off-by: Chia-Wei Wang
Reviewed-by: Andrew Jeffery
Tested-by: Andrew Jeffery
Acked-by: Lin
From: "Chia-Wei, Wang"
Add check against LPC device v2 compatible string to
ensure that the fixed device tree layout is adopted.
The LPC register offsets are also fixed accordingly.
Signed-off-by: Chia-Wei Wang
Reviewed-by: Andrew Jeffery
Acked-by: Haiyue Wang
Acked-by: Cor
Signed-off-by: Chia-Wei Wang
Reviewed-by: Andrew Jeffery
Acked-by: Rob Herring
---
.../devicetree/bindings/mfd/aspeed-lpc.txt| 100 +-
1 file changed, 25 insertions(+), 75 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
b/Documentation/devicetre
uot;
"aspeed,ast2500-lpc-v2"
"aspeed,ast2600-lpc-v2"
Signed-off-by: Chia-Wei Wang
Reviewed-by: Andrew Jeffery
Tested-by: Andrew Jeffery
---
arch/arm/boot/dts/aspeed-g4.dtsi | 68 +++--
arch/arm/boot/dts/aspeed-g5.dtsi | 119 +---
tem.
Note that this work touches the Nuvoton driver as well as ASPEED's, but
I don't have the capability to test those changes or the IPMI chardev
path. Tested-by tags would be much appreciated if you can exercise one
or both.
Please review!
Andrew
[0]
https://www.intel.com/content/dam/www/program/de
eculation, at half the size of `ret; lfence`.
With a gcc toolchain, it does actually work if you macro 'ret' (and
retl/q) to be .byte 0xc3, 0xcc, but this doesn't work for Clang IAS
which refuses to macro real instructions.
What would be massively helpful if is the toolchains could have their
existing ARM straight-line-speculation support hooked up appropriately
so we get some new code gen options on x86, and don't have to resort to
the macro bodges above.
~Andrew
On Thu, 18 Feb 2021 14:36:31 -0700 Jens Axboe wrote:
> Currently we cap the batch count at max(32, 2*nr_online_cpus), which these
> days is kind of silly as systems have gotten much bigger than in 2009 when
> this heuristic was introduced.
>
> Bump it to capping it at 256 instead. This has a
On Mon, 15 Feb 2021 11:32:01 -0800 Daniel Gimpelevich
wrote:
> On Thu, 2019-03-21 at 15:15 -0700, Andrew Morton wrote:
> > On Thu, 21 Mar 2019 08:13:08 -0700 Daniel Walker wrote:
> > > On Wed, Mar 20, 2019 at 08:14:33PM -0700, Andrew Morton wrote:
> > > > The pa
On Wed, Feb 17, 2021 at 12:25:57PM -0800, Florian Fainelli wrote:
> We have no in-tree users, also update the sfp-phylink.rst documentation
> to indicate that phy_attach_direct() is used instead of of_phy_attach().
>
> Signed-off-by: Florian Fainelli
Reviewed-by: Andrew Lunn
Andrew
On Wed, 17 Feb 2021 10:49:25 -0800 Mike Kravetz wrote:
> page structs are not guaranteed to be contiguous for gigantic pages. The
> routine update_and_free_page can encounter a gigantic page, yet it assumes
> page structs are contiguous when setting page flags in subpages.
>
> If
5.dtsi ?
Did you check the other dts files. Do any others have the same
problem?
Andrew
> > We hope that the following patches can be on the basis of the fixed LPC
> > layout.
>
> Andrew has expressed his support for your changes. I will take time to
> closely review your proposal this week.
>
> We will set the goal of having this rework merged for the next merge w
or 5G COPPER, 2500Base-X for 2.5G copper, and SGMII for
old school 10/100/1G Ethernet.
Mainline Linux has no support for it, but some 'vendor crap' will do a
manual negotiation, simply trying different speeds and see if the
SERDES establishes link. There is nothing standardised for this, as
far as i know.
Andrew
er 4 pools.
So you are saying, there is currently no cost for turning it on. So it
seems like you should just turn it on, and forget the module
parameter. When QoS features are added which require more than 8 pools
you can then address the issue of if this should be configurable.
Andrew
On Sun, Feb 14, 2021 at 01:00:42PM -0800, Stephen Boyd wrote:
> Quoting Andrew Lunn (2021-02-13 08:04:34)
> > > I'm trying to see if we can make lives better for everyone by exposing
> > > the warnings by default in the drivers/clk/ directory now that there are
>
On Fri, Feb 12, 2021 at 04:12:20PM +0100, Maxime Chevallier wrote:
> +static void mvneta_setup_rx_prio_map(struct mvneta_port *pp)
> +{
> + int i;
> + u32 val = 0;
Hi Maxime
Reverse Chrismtass tree please.
Andrew
hich applies the
patch and does a W=1 build, and will report any new warnings. But it
does not email the developer, as far as i know. It is up to you as the
maintainer to reject the patch and say why.
Andrew
rnet PHY subsystem is W=1 clean, and most of he network stack
is. But keeping it clean is not so easy, when developers do sometimes
add new warnings, since they have no idea the code is W=1 clean.
You are also not the only one asking for such a feature. RDMA also
asked recently.
Arnd, do you plan to push the patches?
Andrew
know the hardware, but the descriptions seem to fit the code,
and i did not spot anything odd.
Reviewed-by: Andrew Lunn
Andrew
On Fri, 12 Feb 2021 22:01:38 +0100 Andrey Konovalov
wrote:
> On Fri, Feb 12, 2021 at 9:54 PM Andrew Morton
> wrote:
> >
> > On Fri, 12 Feb 2021 21:21:39 +0100 Andrey Konovalov
> > wrote:
> >
> > > > > The wrappers aren't defined when tests aren'
On Fri, 12 Feb 2021 21:21:39 +0100 Andrey Konovalov
wrote:
> > > The wrappers aren't defined when tests aren't enabled to avoid misuse.
> > > The mte_() functions aren't exported directly to avoid having low-level
> > > KASAN ifdefs in the arch code.
> > >
> >
> > Please confirm that this is
On Fri, 12 Feb 2021 21:08:52 +0100 Andrey Konovalov
wrote:
> Currently, building KASAN-KUnit tests as a module fails with:
>
> ERROR: modpost: "mte_enable_kernel" [lib/test_kasan.ko] undefined!
> ERROR: modpost: "mte_set_report_once" [lib/test_kasan.ko] undefined!
>
> This change adds KASAN
broken it never really worked?
Andrew
t; {0x16b2, 0x7000},
> {0x16b4, 0x0814},
> };
> + struct device *dev = >mdio.dev;
> unsigned int i;
> u16 reg;
> + int ret;
Hard to say from the limited context, but is reverse christmass tree
being preserved here?
Andrew
ems like a generic solution that works for PHY and for any
> device that is force bound.
I don't know if there is any other case in the kernel where a fallback
driver is force bound on a device. But i agree this should be
generic. And hidden away in the drive core, with maybe a new call?
Andrew
coded on? Or we should try to detect when
underruns are happening a lot, and dynamically turn it on for a while?
Andrew
On Wed, 10 Feb 2021 16:33:07 -0800 Ira Weiny wrote:
> > Signed-off-by: Ira Weiny
>
> This already has my signed off by so I'm not going to 'review'. With Prathu's
> testing information I hope this can land.
>
> Andrew did you see this patch?
I did now ;)
Tossed o
automatically do the right thing, removing the
configuration knob, and just making it all simpler for the user to
use.
Andrew
On Thu, Feb 11, 2021 at 10:21:03AM +, Jon Hunter wrote:
>
> On 10/02/2021 22:56, Andrew Lunn wrote:
> > On Wed, Feb 10, 2021 at 02:13:48PM -0800, Saravana Kannan wrote:
> >> Hi,
> >>
> >> This email was triggered by this other email[1].
> >
>
g a
reset, or a clock, or a regulator. But we don't really care about
that. In order that the DT was accepted into the kernel, there must be
a device specific driver which uses those properties. So the kernel
installation is broken, that hardware specific driver is missing.
Andrew
./selftests/kvm/include/perf_test_util.h| 18 +--
> tools/testing/selftests/kvm/lib/kvm_util.c| 36 ++---
> .../selftests/kvm/lib/perf_test_util.c| 139 ++
> .../kvm/memslot_modification_stress_test.c| 16 +-
> 7 files changed, 145 insertions(+), 141 deletions(-)
>
> --
> 2.30.0.478.g8a0d178c01-goog
>
For the series
Reviewed-by: Andrew Jones
Thanks,
drew
value
> */
> +#define QCA807X_CONTROL_DAC_DSP_VOLT_HALF_BIAS_SHORT 7
Are these really properties of the board? That is what device tree is
supposed to be about. These seem like configuration options. Which
suggests they should actually be a PHY tunable.
Andrew
break;
> + case 500:
> + tx_driver_strength = 11;
> + break;
> + case 600:
> + tx_driver_strength = 12;
> + break;
> + default:
> + tx_driver_strength = 12;
> + break;
Please return -EINVAL here. The value in DT is not valid, so you
should error out. If there is no value at all, then it is O.K. to
default to 12.
Andrew
On Wed, Feb 10, 2021 at 01:55:22PM +0100, Robert Marko wrote:
Hi Robert
Could you move the GPIO driver into a patch of its own, and Cc: the
GPIO maintainer and list for that patch please.
Andrew
alle
Reviewed-by: Andrew Lunn
Andrew
fallback driver will not be needed.
Andrew
. Use the specific
driver for the hardware. But the generic driver can at least get you
going, allow you to scp the correct driver onto the system, etc.
Andrew
> I guess it boils down to: how hard should we try to get the driver
> behave correctly if the user is changing registers.
All bets are off if root starts messing with the PHY state from
userspace. Its a foot gun, don't be surprised with what happens when
you use it.
Andrew
hat
> the description is missing and that is to be added. However, should reg
> & port node index match for the net dev?
> If it should be the same, then the same can be acheived by renaming a
> label (lanx) as well.
The label should match whatever the text on the device case says. So
it is fine if port 2 says lan3 on the front panel. However, port@2
should have reg=<2>. Please change it to port@7. This is a generic DT
requirement, not specific to DSA.
Andrew
igned-off-by: Geert Uytterhoeven
Reviewed-by: Andrew Lunn
Andrew
ab16() stood out, and
made me wonder about endianness. Will this work correctly on big and
little endian hosts?
Andrew
On Tue, Feb 09, 2021 at 05:40:51PM +0100, Michael Walle wrote:
> Implement the operations to set desired mode and retrieve the current
> mode.
>
> This feature was tested with an IP101G.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
. Because
> of this and because the RX packet counter is more likely to overflow,
> than the error counters implement only support for the error counters.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
change the page select register before linux is started. The page select
> register is _not_ reset with a soft reset of the PHY.
>
> Add read_page()/write_page() support for the IP101G and use it
> accordingly.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
alle
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 05:40:46PM +0100, Michael Walle wrote:
> The PHY core already resets the PHY before .config_init() if a
> .soft_reset() op is registered. Drop the open-coded ip1xx_reset().
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 05:40:45PM +0100, Michael Walle wrote:
> Don't sometimes use the address operator and sometimes not. Drop it and
> make the code look uniform.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
d up to date, because this could
cause a regression if wrong.
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 05:40:43PM +0100, Michael Walle wrote:
> Simpify the initializations of the structures. There is no functional
> change.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
> This will change reporting PORT_MII to either PORT_TP or PORT_FIBRE;
> except for the genphy fallback driver.
>
> Suggested-by: Andrew Lunn
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
get() is not talking the lock. It could see
speed, duplex, and port while they have _UNKNOWN values, or port is
part way through a flip flop. I think we need to take the lock here.
phy_ethtool_ksettings_set() should also probably take the lock.
Andrew
e reasonably easy to do via
direct hardware access, rather than using the SDK RPC. Getting values
like that should be easy to synchronise.
Andrew
On Tue, 9 Feb 2021 14:03:29 -0800 Ira Weiny wrote:
> On Tue, Feb 09, 2021 at 01:58:37PM -0800, Andrew Morton wrote:
> > On Tue, 9 Feb 2021 13:52:29 -0800 Ira Weiny wrote:
> >
> > > >
> > > > Let's please queue this up separately.
> > >
On Tue, 9 Feb 2021 13:52:29 -0800 Ira Weiny wrote:
> >
> > Let's please queue this up separately.
>
> Ok can I retain your Ack on the move part of the patch?
I missed that.
> Note that it does change kmap_atomic() to kmap_local_page() currently.
>
> Would you prefer a separate change for
On Tue, 9 Feb 2021 12:52:49 -0800 Ira Weiny wrote:
> On Tue, Feb 09, 2021 at 11:09:31AM -0800, Andrew Morton wrote:
> > On Tue, 9 Feb 2021 16:11:23 +0100 David Sterba wrote:
> >
> > > On Fri, Feb 05, 2021 at 03:23:00PM -0800, ira.we...@intel.com wrote:
On Tue, 9 Feb 2021 15:21:28 +0900 Naoya Horiguchi
wrote:
> Currently hwpoison code checks PageAnon() for thp and refuses to handle
> errors on non-anonymous thps (just for historical reason). We now
> support non-anonymou thp like shmem one, so this patch suggests to enable
> to handle shmem
> window and then I can prepare a separate pull with just the cleanups.
> Removing an inter-tree patch dependency was a sufficient reason for
> Linus in the past for such pull requests.
It would be best to merge [1/4] via the btrfs tree. Please add my
Acked-by: Andrew Morton
Althoug
On Tue, 9 Feb 2021 17:02:56 + Catalin Marinas
wrote:
> On Tue, Feb 09, 2021 at 04:32:30PM +0100, Andrey Konovalov wrote:
> > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c
> > index a66c2806fc4d..788ef0c3a25e 100644
> > --- a/arch/arm64/kernel/mte.c
> > +++
t the kernel process is, there are
a lot of developers, and not many maintainers. So the processes need
to make the life of maintainers easier, and not spamming them helps.
Andrew
nel? I don't think it
is that bad. We can point out the problems with Marvell's model. We
can put in review effort for Microchip, make their driver better. And
we can encourage the 3rd and 4th vendors in the enterprise switch
space to follow Microchips lead.
Andrew
moving the #define, it
will fail at compile time, making it obvious the support has been
removed?
Otherwise:
Reviewed-by: Andrew Lunn
Andrew
On Tue, Feb 09, 2021 at 02:00:18AM +0100, Michael Walle wrote:
> genphy_read_status() is already the default for the .read_status() op.
> Drop the unnecessary references.
>
> Signed-off-by: Michael Walle
Reviewed-by: Andrew Lunn
Andrew
e comparison between Microchip Sparx5 and
Marvell Prestera. They offer similar capabilities. Both have a CPU on
them. As you say Marvell is pushing their SDK into this CPU, black
box. Microchip decided to open everything, no firmware, the kernel
driver is directly accessing the hardware, the datasheet is available,
and microchip engineers are here on the list.
I really hope that Sparx5 takes off, and displaces Prestera. In terms
of being able to solve issues, we the community can work with
Sparx5. Prestera is too much a black box.
Andrew
On Mon, 8 Feb 2021 13:08:20 +0200 Mike Rapoport wrote:
> There could be struct pages that are not backed by actual physical memory.
> This can happen when the actual memory bank is not a multiple of
> SECTION_SIZE or when an architecture does not register memory holes
> reserved by the firmware
.
And as Jakub pointed out, nobody is going to review 60 patches all at
once. Please submit one series at a time, get it merged, and then
move onto the next.
Andrew
On Mon, Feb 08, 2021 at 05:03:30PM +0300, Serge Semin wrote:
> There has been no user of the denoted array of the device private data
> since commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into
> core"). Discard it then.
>
> Signed-off-by: Serge Semin
> Hi Andrew,
>
> I honestly tried to find any doc with a glimpse of errata for RTL8211E
> PHY, but with no luck. Official datasheet didn't have any info regarding
> possible hw bugs too. Thus I had no choice but to find a fix of the
> problem myself.
>
> It took me som
4-bit architecture but s390, so prevent this option from being
> > > selected there.
> >
> > Quick grep suggests the same for alpha. Am I wrong?
>
> No, it appears you are right. Looks like my grep missed alpha somehow.
>
> Andrew, do you prefer an additional p
ed to enable the RXC stopping in LPI mode.
Hi Serge
Is this listed in an Errata from Realtek?
Andrew
copied it to
> the wrong directory before sending this series.
Hi Samuel
This patch looks correct. But i don't see it in i2c/for-next, where as
e5c02cf54154 is. I just want to make sure it does not get lost...
Andrew
u_set_cpuid(data->vm, VCPU_ID, kvm_get_supported_cpuid());
This vcpu_set_cpuid() call, which causes problems for non-x86 builds,
is now embedded in vm_create_default() and therefore redundant here.
Otherwise this looks good to me. I'll try to find some time to test
it on an AArch64 machine configured to use 4k pages on the host.
Reviewed-by: Andrew Jones
Thanks,
drew
On 08/02/2021 10:36, Jan Beulich wrote:
> On 08.02.2021 11:23, Andrew Cooper wrote:
>> On 08/02/2021 09:50, Jan Beulich wrote:
>>> On 08.02.2021 10:44, Andrew Cooper wrote:
>>>> On 06/02/2021 10:49, Juergen Gross wrote:
>>>>> The ring buffer for use
On 08/02/2021 10:25, Jürgen Groß wrote:
> On 08.02.21 11:23, Andrew Cooper wrote:
>> On 08/02/2021 09:50, Jan Beulich wrote:
>>> On 08.02.2021 10:44, Andrew Cooper wrote:
>>>> On 06/02/2021 10:49, Juergen Gross wrote:
>>>>> The ring buffer for use
On 08/02/2021 09:50, Jan Beulich wrote:
> On 08.02.2021 10:44, Andrew Cooper wrote:
>> On 06/02/2021 10:49, Juergen Gross wrote:
>>> The ring buffer for user events is used in the local system only, so
>>> smp barriers are fine for ensuring consistency.
>>
On Mon, Feb 08, 2021 at 11:16:41AM +0100, Andrew Jones wrote:
> > diff --git a/tools/testing/selftests/kvm/lib/rbtree.c
> > b/tools/testing/selftests/kvm/lib/rbtree.c
> > new file mode 100644
> > index ..a703f0194ea3
> > --- /dev/null
> > +++ b/tool
-8,6 +8,9 @@
> #ifndef SELFTEST_KVM_UTIL_INTERNAL_H
> #define SELFTEST_KVM_UTIL_INTERNAL_H
>
> +#include "linux/hashtable.h"
> +#include "linux/rbtree.h"
> +
> #include "sparsebit.h"
>
> #define KVM_DEV_PATH "/dev/kvm"
> @@ -20,7 +23,9 @@ struct userspace_mem_region {
> void *host_mem;
> void *mmap_start;
> size_t mmap_size;
> - struct list_head list;
> + struct rb_node gpa_node;
> + struct rb_node hva_node;
> + struct hlist_node slot_node;
> };
>
> struct vcpu {
> @@ -33,6 +38,12 @@ struct vcpu {
> uint32_t dirty_gfns_count;
> };
>
> +struct userspace_mem_regions {
> + struct rb_root gpa_tree;
> + struct rb_root hva_tree;
> + DECLARE_HASHTABLE(slot_hash, 9);
> +};
> +
> struct kvm_vm {
> int mode;
> unsigned long type;
> @@ -45,7 +56,7 @@ struct kvm_vm {
> unsigned int va_bits;
> uint64_t max_gfn;
> struct list_head vcpus;
> - struct list_head userspace_mem_regions;
> + struct userspace_mem_regions regions;
> struct sparsebit *vpages_valid;
> struct sparsebit *vpages_mapped;
> bool has_irqchip;
> diff --git a/tools/testing/selftests/kvm/lib/rbtree.c
> b/tools/testing/selftests/kvm/lib/rbtree.c
> new file mode 100644
> index ..a703f0194ea3
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/lib/rbtree.c
> @@ -0,0 +1 @@
> +#include "../../../../lib/rbtree.c"
>
We shouldn't dip into kernel code like this. We can use tools/lib/rbtree.c
though.
Besides the rbtree.c thing,
Reviewed-by: Andrew Jones
On 06/02/2021 10:49, Juergen Gross wrote:
> The ring buffer for user events is used in the local system only, so
> smp barriers are fine for ensuring consistency.
>
> Reported-by: Andrew Cooper
> Signed-off-by: Juergen Gross
These need to be virt_* to not break in UP bui
+ priv->cm3_base = devm_ioremap_resource(>dev, res);
> + if (IS_ERR(priv->cm3_base))
> + return PTR_ERR(priv->cm3_base);
> +
> + return 0;
> +}
This looks much better. Thanks
Reviewed-by: Andrew Lunn
Andrew
On Sun, Feb 07, 2021 at 08:38:43PM +0200, stef...@marvell.com wrote:
> From: Stefan Chulski
>
> Patch adds CM3 address space PPv2.3 description.
>
> Signed-off-by: Stefan Chulski
> ---
> Documentation/devicetree/bindings/net/marvell-pp2.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2
501 - 600 of 40832 matches
Mail list logo
