Re: [PATCH v3] nvmem: mtk-efuse: Remove EFUSE register write support

Hi Chih-En, On Wed, 2020-08-26 at 16:39 +0800, Chih-En Hsu wrote: > This patch is to remove function "mtk_reg_write" since > Mediatek EFUSE hardware only supports read functionality > for NVMEM consumers. Acked-by: Andrew-CT Chen > > Fixes: ba360fd040e3 ("

Re: [PATCH v2] nvmem: mtk-efuse: Remove EFUSE register write support

Hi Chih-En, On Wed, 2020-08-26 at 14:21 +0800, Chih-En Hsu wrote: > This patch is to remove function "mtk_reg_write" since > Mediatek EFUSE hardware only supports read functionality > for NVMEM consumers. The fixed patch should be ba360fd040e34 ("nvmem: mtk-efuse: remove nvmem regmap

Re: [PATCH] [media] VPU: mediatek: fix dereference of pdev before checking it is null

check if pdev is null and only then > deference pdev when initializing vpu. > > Found with static analysis by CoverityScan, CID 1357797 > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- Reviewed-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com&g

Re: [PATCH] [media] VPU: mediatek: fix dereference of pdev before checking it is null

hen > deference pdev when initializing vpu. > > Found with static analysis by CoverityScan, CID 1357797 > > Signed-off-by: Colin Ian King > --- Reviewed-by: Andrew-CT Chen > drivers/media/platform/mtk-vpu/mtk_vpu.c | 6 -- > 1 file changed, 4 insertions(+), 2 delet

Re: [PATCH] [media] VPU: mediatek: fix null pointer dereference on pdev

On Wed, 2016-09-07 at 18:10 +0100, Colin King wrote: > From: Colin Ian King > > pdev is being null checked, however, prior to that it is being > dereferenced by platform_get_drvdata. Move the assignments of > vpu and run to after the pdev null check to avoid a

Re: [PATCH] [media] VPU: mediatek: fix null pointer dereference on pdev

On Wed, 2016-09-07 at 18:10 +0100, Colin King wrote: > From: Colin Ian King > > pdev is being null checked, however, prior to that it is being > dereferenced by platform_get_drvdata. Move the assignments of > vpu and run to after the pdev null check to avoid a potential > null pointer

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

On Fri, 2016-07-01 at 14:00 +0200, Hans Verkuil wrote: > On 07/01/2016 01:53 PM, andrew-ct chen wrote: > > On Fri, 2016-07-01 at 12:11 +0200, Hans Verkuil wrote: > >> On 06/16/2016 12:54 PM, Mauro Carvalho Chehab wrote: > >>> Em Tue, 14 Jun 2016 19:08:08 +0

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

On Fri, 2016-07-01 at 14:00 +0200, Hans Verkuil wrote: > On 07/01/2016 01:53 PM, andrew-ct chen wrote: > > On Fri, 2016-07-01 at 12:11 +0200, Hans Verkuil wrote: > >> On 06/16/2016 12:54 PM, Mauro Carvalho Chehab wrote: > >>> Em Tue, 14 Jun 2016 19:08:08 +08

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

On Fri, 2016-07-01 at 12:11 +0200, Hans Verkuil wrote: > On 06/16/2016 12:54 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 14 Jun 2016 19:08:08 +0800 > > tiffany lin escreveu: > > > >> Hi Mauro, > >> > >> > >> On Wed, 2016-06-08 at 07:13 +0900, Hans Verkuil wrote: > >>>

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

On Fri, 2016-07-01 at 12:11 +0200, Hans Verkuil wrote: > On 06/16/2016 12:54 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 14 Jun 2016 19:08:08 +0800 > > tiffany lin escreveu: > > > >> Hi Mauro, > >> > >> > >> On Wed, 2016-06-08 at 07:13 +0900, Hans Verkuil wrote: > >>> > >>> On 06/07/2016 11:22

Re: [PATCH 08/12] nvmem: mtk-efuse: remove nvmem regmap dependency

works on our platform. This driver doesn't support "efuse write". I will send another patch for fixing this. Acked-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> Andrew > drivers/nvmem/Kconfig | 1 - > drivers/nvmem/mtk-efuse.c | 47 > ---

Re: [PATCH 08/12] nvmem: mtk-efuse: remove nvmem regmap dependency

support "efuse write". I will send another patch for fixing this. Acked-by: Andrew-CT Chen Andrew > drivers/nvmem/Kconfig | 1 - > drivers/nvmem/mtk-efuse.c | 47 > --- > 2 files changed, 32 insertions(+), 16 deletions(-) >

Re: [PATCH] VPU: mediatek: fix platform_no_drv_owner.cocci warnings

On Fri, 2016-04-22 at 15:08 +0200, Julia Lawall wrote: > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > CC: Andrew-CT Chen <andrew-ct.c...@mediatek.com> > Signed-off-by:

Re: [PATCH] VPU: mediatek: fix platform_no_drv_owner.cocci warnings

On Fri, 2016-04-22 at 15:08 +0200, Julia Lawall wrote: > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > CC: Andrew-CT Chen > Signed-off-by: Fengguang Wu > Signed-off-by: Julia

Re: [PATCH] VPU: mediatek: fix simple_open.cocci warnings

On Fri, 2016-04-22 at 15:12 +0200, Julia Lawall wrote: > Remove an open coded simple_open() function > and replace file operations references to the function > with simple_open() instead. > > Generated by: scripts/coccinelle/api/simple_open.cocci > > CC: Andrew

Re: [PATCH] VPU: mediatek: fix simple_open.cocci warnings

On Fri, 2016-04-22 at 15:12 +0200, Julia Lawall wrote: > Remove an open coded simple_open() function > and replace file operations references to the function > with simple_open() instead. > > Generated by: scripts/coccinelle/api/simple_open.cocci > > CC: Andrew-

Re: [PATCH v7 2/8] [media] VPU: mediatek: support Mediatek VPU

On Mon, 2016-04-25 at 09:40 +0200, Hans Verkuil wrote: > On 04/22/2016 06:25 AM, Tiffany Lin wrote: > > From: Andrew-CT Chen <andrew-ct.c...@mediatek.com> > > > > The VPU driver for hw video codec embedded in Mediatek's MT8173 SOCs. > > It is able to handle vide

Re: [PATCH v7 2/8] [media] VPU: mediatek: support Mediatek VPU

On Mon, 2016-04-25 at 09:40 +0200, Hans Verkuil wrote: > On 04/22/2016 06:25 AM, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > The VPU driver for hw video codec embedded in Mediatek's MT8173 SOCs. > > It is able to handle video decoding/encoding of in a range

Re: [PATCH v4 2/8] [media] VPU: mediatek: support Mediatek VPU

/encode instance > > opens a device node, vpu driver will download vpu firmware to the device. > > A decode/encode instant will decode/encode a frame using VPU > > interface to interrupt vpu to handle decoding/encoding jobs. > > > > Signed-off-by: Andrew-CT

Re: [PATCH v4 2/8] [media] VPU: mediatek: support Mediatek VPU

s a device node, vpu driver will download vpu firmware to the device. > > A decode/encode instant will decode/encode a frame using VPU > > interface to interrupt vpu to handle decoding/encoding jobs. > > > > Signed-off-by: Andrew-CT Chen > > Signed-off-by: Tiffany Lin

[PATCH] nvmem: mediatek: Fix later provider initialization

Possibly, provider driver initialization is later than consumer driver. Use function subsys_initcall to initialize NVMEM provider early to ensure NVMEM consumer doesn't need to -EPROBE_DEFER. Signed-off-by: Andrew-CT Chen --- drivers/nvmem/mtk-efuse.c | 23 ++- 1 file

[PATCH] nvmem: mediatek: Fix later provider initialization

Possibly, provider driver initialization is later than consumer driver. Use function subsys_initcall to initialize NVMEM provider early to ensure NVMEM consumer doesn't need to -EPROBE_DEFER. Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> --- drivers/nvmem/mtk-efuse.

Re: [RESEND RFC/PATCH 3/8] media: platform: mtk-vpu: Support Mediatek VPU

On Mon, 2015-11-30 at 15:36 +, Daniel Thompson wrote: > On 30 November 2015 at 11:43, andrew-ct chen > wrote: > > On Fri, 2015-11-27 at 12:21 +, Daniel Thompson wrote: > >> On 27/11/15 12:10, andrew-ct chen wrote: > >> >>> + > >> >>&g

Re: [RESEND RFC/PATCH 3/8] media: platform: mtk-vpu: Support Mediatek VPU

On Mon, 2015-11-30 at 15:36 +, Daniel Thompson wrote: > On 30 November 2015 at 11:43, andrew-ct chen > <andrew-ct.c...@mediatek.com> wrote: > > On Fri, 2015-11-27 at 12:21 +, Daniel Thompson wrote: > >> On 27/11/15 12:10, andrew-ct chen wrote: > >> &

Re: [RESEND RFC/PATCH 3/8] media: platform: mtk-vpu: Support Mediatek VPU

On Fri, 2015-11-27 at 12:21 +, Daniel Thompson wrote: > On 27/11/15 12:10, andrew-ct chen wrote: > >>> + > >>> > >+ memcpy((void *)send_obj->share_buf, buf, len); > >>> > >+ send_obj->len = len; > >>> > >+

Re: [RESEND RFC/PATCH 3/8] media: platform: mtk-vpu: Support Mediatek VPU

On Fri, 2015-11-27 at 12:21 +, Daniel Thompson wrote: > On 27/11/15 12:10, andrew-ct chen wrote: > >>> + > >>> > >+ memcpy((void *)send_obj->share_buf, buf, len); > >>> > >+ send_obj->len = len; > >>> > >+

Re: [RESEND RFC/PATCH 3/8] media: platform: mtk-vpu: Support Mediatek VPU

Thanks a lot for your review comments. On Wed, 2015-11-25 at 16:11 +, Daniel Thompson wrote: > On 17/11/15 12:54, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > The VPU driver for hw video codec embedded in Mediatek's MT8173 SOCs. > > It is able to han

Re: [RESEND RFC/PATCH 3/8] media: platform: mtk-vpu: Support Mediatek VPU

Thanks a lot for your review comments. On Wed, 2015-11-25 at 16:11 +, Daniel Thompson wrote: > On 17/11/15 12:54, Tiffany Lin wrote: > > From: Andrew-CT Chen <andrew-ct.c...@mediatek.com> > > > > The VPU driver for hw video codec embedded in Mediatek's MT8173 SOC

[PATCH v2 1/3] dt-bindings: add document of mediatek efuse driver

Add Mediatek MT8173 EFUSE Devicetree binding file Signed-off-by: Andrew-CT Chen --- .../devicetree/bindings/nvmem/mtk-efuse.txt| 36 ++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/mtk-efuse.txt diff --git

[PATCH v2 3/3] dts: arm64: Add EFUSE device node

Add Mediatek MT8173 EFUSE device node Signed-off-by: Andrew-CT Chen --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 4dd5f93..d67e23b 100644 --- a/arch

[PATCH v2 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

Add Mediatek EFUSE driver to access hardware data like thermal sensor calibration or HDMI impedance. Signed-off-by: Andrew-CT Chen --- drivers/nvmem/Kconfig | 11 ++ drivers/nvmem/Makefile| 2 ++ drivers/nvmem/mtk-efuse.c | 89 +++ 3

[PATCH v2 0/3] Mediatek EFUSE Support

. Change in v2: 1. Rebase to 4.4-rc1 2. Modify the driver Makefile for more consistent with other drivers 3. Modify the compatible string to "mediatek,mt8173-efuse" and "mediatek,efuse" Andrew-CT Chen (3): dt-bindings: add document of mediatek efuse driver nvmem: mediatek: Add M

[PATCH v2 0/3] Mediatek EFUSE Support

. Change in v2: 1. Rebase to 4.4-rc1 2. Modify the driver Makefile for more consistent with other drivers 3. Modify the compatible string to "mediatek,mt8173-efuse" and "mediatek,efuse" Andrew-CT Chen (3): dt-bindings: add document of mediatek efuse driver nvmem: mediatek: Add M

[PATCH v2 1/3] dt-bindings: add document of mediatek efuse driver

Add Mediatek MT8173 EFUSE Devicetree binding file Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> --- .../devicetree/bindings/nvmem/mtk-efuse.txt| 36 ++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvm

[PATCH v2 3/3] dts: arm64: Add EFUSE device node

Add Mediatek MT8173 EFUSE device node Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi

[PATCH v2 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

Add Mediatek EFUSE driver to access hardware data like thermal sensor calibration or HDMI impedance. Signed-off-by: Andrew-CT Chen <andrew-ct.c...@mediatek.com> --- drivers/nvmem/Kconfig | 11 ++ drivers/nvmem/Makefile| 2 ++ drivers/nvmem/mtk-efuse.

Re: [RESEND RFC/PATCH 1/8] dt-bindings: Add a binding for Mediatek Video Processor Unit

On Tue, 2015-11-17 at 14:13 +, Mark Rutland wrote: > On Tue, Nov 17, 2015 at 08:54:38PM +0800, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > Add a DT binding documentation of Video Processor Unit for the > > MT8173 SoC from Mediatek. > >

Re: [RESEND RFC/PATCH 1/8] dt-bindings: Add a binding for Mediatek Video Processor Unit

On Tue, 2015-11-17 at 14:13 +, Mark Rutland wrote: > On Tue, Nov 17, 2015 at 08:54:38PM +0800, Tiffany Lin wrote: > > From: Andrew-CT Chen <andrew-ct.c...@mediatek.com> > > > > Add a DT binding documentation of Video Processor Unit for the > > MT8173 SoC f

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

On Tue, 2015-10-27 at 13:32 +0800, andrew-ct chen wrote: > On Mon, 2015-10-26 at 09:56 +, Srinivas Kandagatla wrote: > > On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: > > > From: Andrew-CT Chen > > > > > > Add Mediatek EFUSE driver to access har

Re: [PATCH 1/3] dt-bindings: add document of mediatek efuse driver

On Tue, 2015-10-27 at 13:32 +0800, andrew-ct chen wrote: > On Mon, 2015-10-26 at 10:55 +, Srinivas Kandagatla wrote: > > > > On 26/10/15 10:23, Sascha Hauer wrote: > > > On Mon, Oct 26, 2015 at 09:56:14AM +, Srinivas Kandagatla wrote: > > >> > >

Re: [PATCH 1/3] dt-bindings: add document of mediatek efuse driver

On Tue, 2015-10-27 at 13:32 +0800, andrew-ct chen wrote: > On Mon, 2015-10-26 at 10:55 +, Srinivas Kandagatla wrote: > > > > On 26/10/15 10:23, Sascha Hauer wrote: > > > On Mon, Oct 26, 2015 at 09:56:14AM +, Srinivas Kandagatla wrote: > > >> > >

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

On Tue, 2015-10-27 at 13:32 +0800, andrew-ct chen wrote: > On Mon, 2015-10-26 at 09:56 +, Srinivas Kandagatla wrote: > > On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: > > > From: Andrew-CT Chen <andrew-ct.c...@mediatek.com> > > > > > > Add Med

Re: [PATCH 1/3] dt-bindings: add document of mediatek efuse driver

On Mon, 2015-10-26 at 10:55 +, Srinivas Kandagatla wrote: > > On 26/10/15 10:23, Sascha Hauer wrote: > > On Mon, Oct 26, 2015 at 09:56:14AM +, Srinivas Kandagatla wrote: > >> > >> > >> On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: >

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

On Mon, 2015-10-26 at 09:56 +, Srinivas Kandagatla wrote: > On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: > > From: Andrew-CT Chen > > > > Add Mediatek EFUSE driver to access hardware data like > > thermal sensor calibration or HDMI impedance. > >

Re: [PATCH 2/3] nvmem: mediatek: Add Mediatek EFUSE driver

On Mon, 2015-10-26 at 09:56 +, Srinivas Kandagatla wrote: > On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: > > From: Andrew-CT Chen <andrew-ct.c...@mediatek.com> > > > > Add Mediatek EFUSE driver to access hardware data like > > thermal sen

Re: [PATCH 1/3] dt-bindings: add document of mediatek efuse driver

On Mon, 2015-10-26 at 10:55 +, Srinivas Kandagatla wrote: > > On 26/10/15 10:23, Sascha Hauer wrote: > > On Mon, Oct 26, 2015 at 09:56:14AM +, Srinivas Kandagatla wrote: > >> > >> > >> On 16/10/15 09:39, andrew-ct.c...@mediatek.com wrote: