Re: [Cluster-devel] [PATCH] fs: gfs2: prevent OOB access in gfs2_read_sb()

2020-10-14 Thread Andrew Price
On 13/10/2020 16:26, Anant Thazhemadam wrote: In gfs2_read_sb(), if the condition (d != sdp->sd_heightsize[x - 1] || m) isn't satisfied (in the first 11 iterations), the loop continues, and begins to perform out-of-bounds access. Fix this out-of-bounds access by introducing a condition

Re: [Cluster-devel] KASAN: slab-out-of-bounds Write in gfs2_fill_super

2020-10-14 Thread Andrew Price
On 14/10/2020 13:19, Anant Thazhemadam wrote: On 30/09/20 7:52 pm, Andrew Price wrote: On 30/09/2020 13:39, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:    fb0155a0 Merge tag 'nfs-for-5.9-3' of git://git.linux-nfs... git tree:   upstream console output: https

Re: [Cluster-devel] general protection fault in gfs2_rgrp_dump

2020-10-07 Thread Andrew Price
On 06/10/2020 13:48, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:7575fdda Merge tag 'platform-drivers-x86-v5.9-2' of git://.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14abb7c790 kernel config:

Re: [Cluster-devel] [PATCH] gfs2: gfs2_read_sb: put gfs2_assert inside the loop

2020-10-05 Thread Andrew Price
On 03/10/2020 07:31, Fox Chen wrote: for (x = 2;; x++) { ... gfs2_assert(sdp, x <= GFS2_MAX_META_HEIGHT); <--- after ... if (d != sdp->sd_heightsize[x - 1] || m) break; sdp->sd_heightsize[x] = space; } sdp->sd_max_height = x

Re: [Cluster-devel] KASAN: slab-out-of-bounds Write in gfs2_fill_super

2020-09-30 Thread Andrew Price
On 30/09/2020 13:39, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:fb0155a0 Merge tag 'nfs-for-5.9-3' of git://git.linux-nfs... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13458c0f90 kernel config:

Re: general protection fault in gfs2_withdraw

2020-09-30 Thread Andrew Price
On 29/09/2020 06:34, syzbot wrote: syzbot has bisected this issue to: commit 601ef0d52e9617588fcff3df26953592f2eb44ac Author: Bob Peterson Date: Tue Jan 28 19:23:45 2020 + gfs2: Force withdraw to replay journals and wait for it to finish bisection log:

Re: [Cluster-devel] general protection fault in gfs2_withdraw

2020-09-28 Thread Andrew Price
On 26/09/2020 18:21, syzbot wrote: syzbot has found a reproducer for the following issue on: HEAD commit:7c7ec322 Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11f2ff2790 kernel config:

Re: [RFC PATCH 1/4] vfs: Create fs_context-aware mount_bdev() replacement

2019-03-27 Thread Andrew Price
On 27/03/2019 11:23, David Howells wrote: Andrew Price wrote: + up_write(>s_umount); + blkdev_put(bdev, fc->bdev_mode); + down_write(>s_umount); fc->bdev should be NULLed here (or, on the way out of sget_fc() might be more appropriate)

Re: [RFC PATCH 1/4] vfs: Create fs_context-aware mount_bdev() replacement

2019-03-26 Thread Andrew Price
Hi David, I've been testing gfs2 on top of this patch and it seems... On 19/03/2019 16:23, David Howells wrote: Create a function, vfs_get_block_super(), that is fs_context-aware and a replacement for mount_bdev(). It caches the block device pointer and file open mode in the fs_context struct

Re: [Cluster-devel] [PATCH] dlm: config: Fix ENOMEM failures in make_cluster()

2016-03-29 Thread Andrew Price
On 22/03/16 17:36, Andrew Price wrote: Commit 1ae1602de0 "configfs: switch ->default groups to a linked list" left the NULL gps pointer behind after removing the kcalloc() call which made it non-NULL. It also left the !gps check in place so make_cluster() now fails with E

Re: [Cluster-devel] [PATCH] dlm: config: Fix ENOMEM failures in make_cluster()

2016-03-29 Thread Andrew Price
On 22/03/16 17:36, Andrew Price wrote: Commit 1ae1602de0 "configfs: switch ->default groups to a linked list" left the NULL gps pointer behind after removing the kcalloc() call which made it non-NULL. It also left the !gps check in place so make_cluster() now fails with E

[PATCH] dlm: config: Fix ENOMEM failures in make_cluster()

2016-03-22 Thread Andrew Price
riable to fix that. Reviewed-by: Bob Peterson <rpete...@redhat.com> Reviewed-by: Andreas Gruenbacher <agrue...@redhat.com> Signed-off-by: Andrew Price <anpr...@redhat.com> --- fs/dlm/config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/config.c

[PATCH] dlm: config: Fix ENOMEM failures in make_cluster()

2016-03-22 Thread Andrew Price
riable to fix that. Reviewed-by: Bob Peterson Reviewed-by: Andreas Gruenbacher Signed-off-by: Andrew Price --- fs/dlm/config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/config.c b/fs/dlm/config.c index 5191121..1669f62 100644 --- a/fs/dlm/config.c +++ b/fs

Re: rcu: fix hlist_bl_set_first_rcu annotation

2013-02-14 Thread Andrew Price
Hi, On 03/02/13 18:39, Paul E. McKenney wrote: On Wed, Jan 30, 2013 at 07:07:57PM +, Steven Whitehouse wrote: Abhi noticed that we were getting a complaint from the RCU subsystem about access of an RCU protected list under the write side bit lock. This patch adds additional annotation to

Re: rcu: fix hlist_bl_set_first_rcu annotation

2013-02-14 Thread Andrew Price
Hi, On 03/02/13 18:39, Paul E. McKenney wrote: On Wed, Jan 30, 2013 at 07:07:57PM +, Steven Whitehouse wrote: Abhi noticed that we were getting a complaint from the RCU subsystem about access of an RCU protected list under the write side bit lock. This patch adds additional annotation to