[PATCH v5 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-26 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda --- v5: removed extra parenthesis (kbuild test robot) v4: added missing reg property in connector's port node (Krzysztof) --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31

[PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

2018-02-26 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v5: func

[PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

2018-02-26 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v5: function renamed to extcon_find_edev_by_node (Andy) v2: changed label

[PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-26 Thread Andrzej Hajda
ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v5: updated extcon API This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence,

[PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-26 Thread Andrzej Hajda
Signed-off-by: Andrzej Hajda --- v5: updated extcon API This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get state logic. Code finding extcon node is hacky IMO, I guess

[PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

2018-02-26 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v4: - improved 'type' description (Rob), - improved description of 2nd example (Rob). v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting. v2: -

[PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

2018-02-26 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda --- v4: - improved 'type' description (Rob), - improved description of 2nd example (Rob). v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting. v2: - moved connector type(A,B,C

[PATCH v5 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-02-26 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-commo

[PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-02-26 Thread Andrzej Hajda
binding descriptions, added missing reg in dts. v3: Separate binding for Samsung 11-pin connector, added full-blown USB-C example. v2: I have addressed comments by Rob and Laurent, thanks Changes in datail are described in the patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add

[PATCH v5 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-02-26 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts

[PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-02-26 Thread Andrzej Hajda
binding descriptions, added missing reg in dts. v3: Separate binding for Samsung 11-pin connector, added full-blown USB-C example. v2: I have addressed comments by Rob and Laurent, thanks Changes in datail are described in the patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add

[PATCH v5 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

2018-02-26 Thread Andrzej Hajda
Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Reviewed-by: Rob Herring <r...@kernel.org> --- v4: - removed description of property inherited from usb-connector (Rob), - f

[PATCH v5 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

2018-02-26 Thread Andrzej Hajda
Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda Reviewed-by: Rob Herring --- v4: - removed description of property inherited from usb-connector (Rob), - fixed example description. --- .../connector/samsung

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-26 Thread Andrzej Hajda
On 26.02.2018 16:21, Krzysztof Kozlowski wrote: > On Wed, Feb 21, 2018 at 9:55 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.ha...@samsung.c

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-26 Thread Andrzej Hajda
On 26.02.2018 16:21, Krzysztof Kozlowski wrote: > On Wed, Feb 21, 2018 at 9:55 AM, Andrzej Hajda wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda >> --- >> v4: >> - added

Re: [PATCH v4 5/6] extcon: add possibility to get extcon device by OF node

2018-02-21 Thread Andrzej Hajda
On 21.02.2018 15:27, Andy Shevchenko wrote: > On Wed, Feb 21, 2018 at 10:55 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> Since extcon property is not allowed in DT, extcon subsystem requires >> another way to get extcon device. Lets try the simplest approach - g

Re: [PATCH v4 5/6] extcon: add possibility to get extcon device by OF node

2018-02-21 Thread Andrzej Hajda
On 21.02.2018 15:27, Andy Shevchenko wrote: > On Wed, Feb 21, 2018 at 10:55 AM, Andrzej Hajda wrote: >> Since extcon property is not allowed in DT, extcon subsystem requires >> another way to get extcon device. Lets try the simplest approach - get >

[PATCH v4 5/6] extcon: add possibility to get extcon device by OF node

2018-02-21 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v2: changed label to

[PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-21 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v4: - added missing reg property in connector's port node (Krzysztof) --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 --

[PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-21 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda --- v4: - added missing reg property in connector's port node (Krzysztof) --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 -- 1 file changed, 29 insertions

[PATCH v4 5/6] extcon: add possibility to get extcon device by OF node

2018-02-21 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v2: changed label to follow local convention (Chanwoo) --- drivers/extcon

[PATCH v4 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-21 Thread Andrzej Hajda
ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[PATCH v4 1/6] dt-bindings: add bindings for USB physical connector

2018-02-21 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v4: - improved 'type' description (Rob), - improved description of 2nd example (Rob). v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting. v2: -

[PATCH v4 1/6] dt-bindings: add bindings for USB physical connector

2018-02-21 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda --- v4: - improved 'type' description (Rob), - improved description of 2nd example (Rob). v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting. v2: - moved connector type(A,B,C

[PATCH v4 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-21 Thread Andrzej Hajda
Signed-off-by: Andrzej Hajda --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get state logic. Code finding extcon node is hacky IMO, I guess ultimately it should be done

[PATCH v4 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

2018-02-21 Thread Andrzej Hajda
Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Reviewed-by: Rob Herring <r...@kernel.org> --- v4: - removed description of property inherited from usb-connector (Rob), - f

[PATCH v4 0/6] dt-bindings: add bindings for USB physical connector

2018-02-21 Thread Andrzej Hajda
binding for Samsung 11-pin connector, added full-blown USB-C example. v2: I have addressed comments by Rob and Laurent, thanks Changes in datail are described in the patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add bindings for USB physical connector dt-bindings: add bindings

[PATCH v4 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

2018-02-21 Thread Andrzej Hajda
Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda Reviewed-by: Rob Herring --- v4: - removed description of property inherited from usb-connector (Rob), - fixed example description. --- .../connector/samsung

[PATCH v4 0/6] dt-bindings: add bindings for USB physical connector

2018-02-21 Thread Andrzej Hajda
binding for Samsung 11-pin connector, added full-blown USB-C example. v2: I have addressed comments by Rob and Laurent, thanks Changes in datail are described in the patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add bindings for USB physical connector dt-bindings: add bindings

[PATCH v4 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-02-21 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-commo

[PATCH v4 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-02-21 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts

Re: [RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

2018-02-20 Thread Andrzej Hajda
On 19.02.2018 15:28, Rob Herring wrote: > On Thu, Feb 15, 2018 at 11:39:15AM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to

Re: [RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

2018-02-20 Thread Andrzej Hajda
On 19.02.2018 15:28, Rob Herring wrote: > On Thu, Feb 15, 2018 at 11:39:15AM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to

Re: [RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-15 Thread Andrzej Hajda
On 15.02.2018 13:14, Krzysztof Kozlowski wrote: > On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.ha...@samsung

Re: [RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-15 Thread Andrzej Hajda
On 15.02.2018 13:14, Krzysztof Kozlowski wrote: > On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda >> --- >> .../boot/dts/exy

[RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-15 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH v2 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-02-15 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-commo

[RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-15 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2

[RFC PATCH v2 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-02-15 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts

[RFC PATCH v2 5/6] extcon: add possibility to get extcon device by OF node

2018-02-15 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v2: changed label to

[RFC PATCH v2 5/6] extcon: add possibility to get extcon device by OF node

2018-02-15 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v2: changed label to follow local convention (Chanwoo) --- drivers/extcon

[RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

2018-02-15 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting v2: - moved connector type(A,B,C) to compatible string (Rob), - renamed size property to typ

[RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

2018-02-15 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda --- v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting v2: - moved connector type(A,B,C) to compatible string (Rob), - renamed size property to type (Rob), - changed type

[RFC PATCH v2 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-15 Thread Andrzej Hajda
ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH v2 0/6] dt-bindings: add bindings for USB physical connector

2018-02-15 Thread Andrzej Hajda
are also described in patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add bindings for USB physical connector dt-bindings: add bindings for Samsung micro-USB 11-pin connector arm64: dts: exynos: add micro-USB connector node to TM2 platforms arm64: dts: exynos: add OF graph between MHL

[RFC PATCH v2 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-15 Thread Andrzej Hajda
Signed-off-by: Andrzej Hajda --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get state logic. Code finding extcon node is hacky IMO, I guess ultimately it should be done

[RFC PATCH v2 0/6] dt-bindings: add bindings for USB physical connector

2018-02-15 Thread Andrzej Hajda
are also described in patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add bindings for USB physical connector dt-bindings: add bindings for Samsung micro-USB 11-pin connector arm64: dts: exynos: add micro-USB connector node to TM2 platforms arm64: dts: exynos: add OF graph between MHL

[RFC PATCH v2 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

2018-02-15 Thread Andrzej Hajda
Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../connector/samsung,usb-connector-11pin.txt | 51 ++ 1 file changed, 51 insertions(+) create mode

[RFC PATCH v2 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

2018-02-15 Thread Andrzej Hajda
Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda --- .../connector/samsung,usb-connector-11pin.txt | 51 ++ 1 file changed, 51 insertions(+) create mode 100644 Documentation

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-02-08 Thread Andrzej Hajda
On 07.02.2018 22:43, Rob Herring wrote: > On Mon, Feb 05, 2018 at 10:06:35AM +0100, Andrzej Hajda wrote: >> On 05.02.2018 07:08, Rob Herring wrote: >>> On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: >>>> These bindings allow to describe most

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-02-08 Thread Andrzej Hajda
On 07.02.2018 22:43, Rob Herring wrote: > On Mon, Feb 05, 2018 at 10:06:35AM +0100, Andrzej Hajda wrote: >> On 05.02.2018 07:08, Rob Herring wrote: >>> On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: >>>> These bindings allow to describe most

Re: [PATCH v2] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-07 Thread Andrzej Hajda
On 06.02.2018 09:42, Philippe Cornu wrote: > Add support for the Synopsys DesignWare MIPI DSI version 1.31 > Two registers need to be updated/added for supporting 1.31: > * PHY_TMR_CFG 0x9c (updated) > 1.30 [31:24] phy_hs2lp_time >[23:16] phy_lp2hs_time >[14: 0] max_rd_time > >

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-07 Thread Andrzej Hajda
On 04.02.2018 22:31, Philippe Cornu wrote: > This patch adds the DCS/GENERIC DSI read feature. > > Signed-off-by: Philippe Cornu > --- Queued to drm-misc-next. -- Regards Andrzej

Re: [PATCH v2] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-07 Thread Andrzej Hajda
On 06.02.2018 09:42, Philippe Cornu wrote: > Add support for the Synopsys DesignWare MIPI DSI version 1.31 > Two registers need to be updated/added for supporting 1.31: > * PHY_TMR_CFG 0x9c (updated) > 1.30 [31:24] phy_hs2lp_time >[23:16] phy_lp2hs_time >[14: 0] max_rd_time > >

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-07 Thread Andrzej Hajda
On 04.02.2018 22:31, Philippe Cornu wrote: > This patch adds the DCS/GENERIC DSI read feature. > > Signed-off-by: Philippe Cornu > --- Queued to drm-misc-next. -- Regards Andrzej

Re: [PATCH v2] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-06 Thread Andrzej Hajda
14: 0] max_rd_time > > 1.31 [25:16] phy_hs2lp_time >[ 9: 0] phy_lp2hs_time > > * PHY_TMR_RD_CFG 0xf4 (new) > 1.31 [14: 0] max_rd_time > > Signed-off-by: Philippe Cornu <philippe.co...@st.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> If

Re: [PATCH v2] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-06 Thread Andrzej Hajda
14: 0] max_rd_time > > 1.31 [25:16] phy_hs2lp_time >[ 9: 0] phy_lp2hs_time > > * PHY_TMR_RD_CFG 0xf4 (new) > 1.31 [14: 0] max_rd_time > > Signed-off-by: Philippe Cornu Reviewed-by: Andrzej Hajda If there will be no objections I will merge it this week.  -- Regards Andrzej

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-05 Thread Andrzej Hajda
On 22.01.2018 16:08, Philippe Cornu wrote: > From: Philippe CORNU > > Add support for the Synopsys DesignWare MIPI DSI version 1.31 > Two registers need to be updated/added for supporting 1.31: > * PHY_TMR_CFG 0x9c (updated) > 1.30 [31:24] phy_hs2lp_time >[23:16]

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-05 Thread Andrzej Hajda
On 22.01.2018 16:08, Philippe Cornu wrote: > From: Philippe CORNU > > Add support for the Synopsys DesignWare MIPI DSI version 1.31 > Two registers need to be updated/added for supporting 1.31: > * PHY_TMR_CFG 0x9c (updated) > 1.30 [31:24] phy_hs2lp_time >[23:16] phy_lp2hs_time >

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-05 Thread Andrzej Hajda
On 04.02.2018 22:31, Philippe Cornu wrote: > This patch adds the DCS/GENERIC DSI read feature. > > Signed-off-by: Philippe Cornu <philippe.co...@st.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> If there will be no objections I will merge it at the end of the week.

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-05 Thread Andrzej Hajda
On 04.02.2018 22:31, Philippe Cornu wrote: > This patch adds the DCS/GENERIC DSI read feature. > > Signed-off-by: Philippe Cornu Reviewed-by: Andrzej Hajda If there will be no objections I will merge it at the end of the week.  -- Regards Andrzej > --- > Extra notes: > D

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-02-05 Thread Andrzej Hajda
On 05.02.2018 07:08, Rob Herring wrote: > On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-02-05 Thread Andrzej Hajda
On 05.02.2018 07:08, Rob Herring wrote: > On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to

Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-02-01 Thread Andrzej Hajda
On 01.02.2018 08:50, Krzysztof Kozlowski wrote: > On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete &

Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-02-01 Thread Andrzej Hajda
On 01.02.2018 08:50, Krzysztof Kozlowski wrote: > On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete >> extcon pr

[PATCH 0/2] USB: dwc3: get extcon device by OF graph bindings

2018-01-31 Thread Andrzej Hajda
PHY -> MUIC -> USB-connector ^ MHL-bridge-^ More details and proposition of generic solution in first patch [1]: https://marc.info/?i=20180131134435.12216-1-a.hajda%40samsung.com Regards Andrzej Andrzej Hajda (2): USB: dwc3: get extc

[PATCH 0/2] USB: dwc3: get extcon device by OF graph bindings

2018-01-31 Thread Andrzej Hajda
PHY -> MUIC -> USB-connector ^ MHL-bridge-^ More details and proposition of generic solution in first patch [1]: https://marc.info/?i=20180131134435.12216-1-a.hajda%40samsung.com Regards Andrzej Andrzej Hajda (2): USB: dwc3: get extc

[PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

2018-01-31 Thread Andrzej Hajda
extcon device is used to detect host/device connection. Since extcon OF property is deprecated, alternative method should be added. This method uses OF graph bindings to locate extcon. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- Hi all, This patch implements alternative method

[PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

2018-01-31 Thread Andrzej Hajda
extcon device is used to detect host/device connection. Since extcon OF property is deprecated, alternative method should be added. This method uses OF graph bindings to locate extcon. Signed-off-by: Andrzej Hajda --- Hi all, This patch implements alternative method to get extcon from DWC3

[PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-01-31 Thread Andrzej Hajda
OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dts

[PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-01-31 Thread Andrzej Hajda
OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 18 +- 1 file

[RFC PATCH v2 3/5] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-01-31 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH v2 3/5] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-01-31 Thread Andrzej Hajda
OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2

[RFC PATCH v2 5/5] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-01-31 Thread Andrzej Hajda
ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH v2 5/5] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-01-31 Thread Andrzej Hajda
Signed-off-by: Andrzej Hajda --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get state logic. Code finding extcon node is hacky IMO, I guess ultimately it should be done

[RFC PATCH v2 4/5] extcon: add possibility to get extcon device by OF node

2018-01-31 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v2: changed label to

[RFC PATCH v2 4/5] extcon: add possibility to get extcon device by OF node

2018-01-31 Thread Andrzej Hajda
Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v2: changed label to follow local convention (Chanwoo) --- drivers/extcon

[RFC PATCH v2 0/5] dt-bindings: add bindings for USB physical connector

2018-01-31 Thread Andrzej Hajda
Hi, This patchset introduces USB physical connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. In v2 I have addressed comments by Rob and Laurent, thanks Changes are described in patches. Regards Andrzej Andrzej Hajda (4

[RFC PATCH v2 0/5] dt-bindings: add bindings for USB physical connector

2018-01-31 Thread Andrzej Hajda
Hi, This patchset introduces USB physical connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. In v2 I have addressed comments by Rob and Laurent, thanks Changes are described in patches. Regards Andrzej Andrzej Hajda (4

[RFC PATCH v2 2/5] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-01-31 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.d

[RFC PATCH v2 2/5] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-01-31 Thread Andrzej Hajda
Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts

[RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-01-31 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v2: - moved connector type(A,B,C) to compatible string (Rob), - renamed size property to type (Rob), - changed type description to be less confusing (Laurent), - removed vendor specific compatibles (implied by grap

[RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

2018-01-31 Thread Andrzej Hajda
appropriate graph bindings. Signed-off-by: Andrzej Hajda --- v2: - moved connector type(A,B,C) to compatible string (Rob), - renamed size property to type (Rob), - changed type description to be less confusing (Laurent), - removed vendor specific compatibles (implied by graph port number), - added

Re: [PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

2018-01-25 Thread Andrzej Hajda
On 24.01.2018 19:37, Brian Norris wrote: > Hi Philippe, > > On Wed, Jan 24, 2018 at 01:33:54PM +, Philippe CORNU wrote: >> On 01/23/2018 10:38 PM, Brian Norris wrote: >>> Hi Philippe, >>> >>> On Tue, Jan 23, 2018 at 6:26 AM, Philippe Cornu >>> wrote: The

Re: [PATCH v1 1/2] drm/bridge/synopsys: dsi: Fix dsi_host_transfer() return value

2018-01-25 Thread Andrzej Hajda
On 24.01.2018 19:37, Brian Norris wrote: > Hi Philippe, > > On Wed, Jan 24, 2018 at 01:33:54PM +, Philippe CORNU wrote: >> On 01/23/2018 10:38 PM, Brian Norris wrote: >>> Hi Philippe, >>> >>> On Tue, Jan 23, 2018 at 6:26 AM, Philippe Cornu >>> wrote: The dw_mipi_dsi_host_transfer() must

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-25 Thread Andrzej Hajda
On 24.01.2018 10:51, Philippe CORNU wrote: > Hi Brian, > > On 01/23/2018 10:15 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: >>> On 01/11/2018 12:16 PM, Philippe CORNU wrote: To be honest, I do not really like the memcpy here too

Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-25 Thread Andrzej Hajda
On 24.01.2018 10:51, Philippe CORNU wrote: > Hi Brian, > > On 01/23/2018 10:15 PM, Brian Norris wrote: >> Hi Philippe, >> >> On Thu, Jan 18, 2018 at 11:40:48AM +, Philippe CORNU wrote: >>> On 01/11/2018 12:16 PM, Philippe CORNU wrote: To be honest, I do not really like the memcpy here too

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-15 Thread Andrzej Hajda
On 15.01.2018 15:40, Philippe CORNU wrote: > Hi Andrzej, > > On 01/15/2018 02:52 PM, Andrzej Hajda wrote: >> On 12.01.2018 17:25, Philippe Cornu wrote: >>> The pixel clock is optional. When available, it offers a better >>> preciseness for timing computations a

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-15 Thread Andrzej Hajda
On 15.01.2018 15:40, Philippe CORNU wrote: > Hi Andrzej, > > On 01/15/2018 02:52 PM, Andrzej Hajda wrote: >> On 12.01.2018 17:25, Philippe Cornu wrote: >>> The pixel clock is optional. When available, it offers a better >>> preciseness for timing computations a

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-15 Thread Andrzej Hajda
Philippe Cornu <philippe.co...@st.com> > --- > Changes in v2: Improve px_clk probing in case of ENOENT dt returned value > (thanks to Philipp Zabel & Andrzej Hajda comments) > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 26 -- > 1 file changed, 20 i

Re: [PATCH v2] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-15 Thread Andrzej Hajda
Philippe Cornu > --- > Changes in v2: Improve px_clk probing in case of ENOENT dt returned value > (thanks to Philipp Zabel & Andrzej Hajda comments) > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 26 -- > 1 file changed, 20 insertions(+), 6 deletion

Re: [PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

2018-01-15 Thread Andrzej Hajda
to PTR_ERR_OR_ZERO, but this is also OK. Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej > --- > drivers/gpu/drm/drm_mipi_dsi.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers

Re: [PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

2018-01-15 Thread Andrzej Hajda
but this is also OK. Reviewed-by: Andrzej Hajda  -- Regards Andrzej > --- > drivers/gpu/drm/drm_mipi_dsi.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 4b47226b90d4..bc73b7f5b

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-11 Thread Andrzej Hajda
On 11.01.2018 14:51, Philippe CORNU wrote: > Hi Brian & All *DSI DRM experts*, > > 1) Re-reading this patch, I realize that the returned value of > dw_mipi_dsi_host_transfer() is not correct: we should return the number > of transfered/received bytes... > > so I think there are two solutions:

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-11 Thread Andrzej Hajda
On 11.01.2018 14:51, Philippe CORNU wrote: > Hi Brian & All *DSI DRM experts*, > > 1) Re-reading this patch, I realize that the returned value of > dw_mipi_dsi_host_transfer() is not correct: we should return the number > of transfered/received bytes... > > so I think there are two solutions:

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write()

2018-01-10 Thread Andrzej Hajda
ader, sizeof(packet->header)); > + return dw_mipi_dsi_gen_pkt_hdr_write(dsi, le32_to_cpu(word)); You could create and use appropriate helper, lets say: u32 le_to_cpup(const u8 *p, int count) {     __le32 r = 0;     memcpy(, p, count);     return le32_to_cpu(r); } With or without this change: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej > } > > static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host,

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write()

2018-01-10 Thread Andrzej Hajda
)); > + return dw_mipi_dsi_gen_pkt_hdr_write(dsi, le32_to_cpu(word)); You could create and use appropriate helper, lets say: u32 le_to_cpup(const u8 *p, int count) {     __le32 r = 0;     memcpy(, p, count);     return le32_to_cpu(r); } With or without this change: Reviewed-by: Andrzej Hajda  -- Regards Andrzej > } > > static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host,

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2018-01-09 Thread Andrzej Hajda
On 09.01.2018 14:37, Laurent Pinchart wrote: > Hi Philippe, > > On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote: >> Hi Archit, Andrzej & Laurent, >> >> Regarding this patch from Brian, I think it could be nice to merge it >> (1xAcked-by, 2xReviewed-by). >> >> Could you please have a

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2018-01-09 Thread Andrzej Hajda
On 09.01.2018 14:37, Laurent Pinchart wrote: > Hi Philippe, > > On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote: >> Hi Archit, Andrzej & Laurent, >> >> Regarding this patch from Brian, I think it could be nice to merge it >> (1xAcked-by, 2xReviewed-by). >> >> Could you please have a

Re: [PATCH] drm/bridge: analogix_dp: Use relaxed MMIO accessors

2017-12-19 Thread Andrzej Hajda
On 18.12.2017 12:39, Marc Zyngier wrote: > The analogix DP bridge is entierely driven via MMIO accesses, and > does not do any DMA that requires coherency with the CPU. Yet, the > driver uses the non-relaxed accessors, forcing strong barriers to > be emitted on architectures with a relaxed memory

<    1   2   3   4   5   6   7   8   9   10   >