Re: [PATCH] drm/bridge: analogix_dp: Use relaxed MMIO accessors

On 18.12.2017 12:39, Marc Zyngier wrote: > The analogix DP bridge is entierely driven via MMIO accesses, and > does not do any DMA that requires coherency with the CPU. Yet, the > driver uses the non-relaxed accessors, forcing strong barriers to > be emitted on architectures with a relaxed memory

Re: [PATCH 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

On 06.10.2017 23:30, Shuah Khan wrote: > Driver calls request_firmware() whenever the device is opened for the > first time. As the device gets opened and closed, dev->num_inst == 1 > is true several times. This is not necessary since the firmware is saved > in the fw_buf. s5p_mfc_load_firmware()

Re: [PATCH 2/2] media: s5p-mfc: fix lock confection - request_firmware() once and keep state

On 06.10.2017 23:30, Shuah Khan wrote: > Driver calls request_firmware() whenever the device is opened for the > first time. As the device gets opened and closed, dev->num_inst == 1 > is true several times. This is not necessary since the firmware is saved > in the fw_buf. s5p_mfc_load_firmware()

Re: [PATCH 1/2] media: s5p-mfc: check for firmware allocation before requesting firmware

Hi Shuah, On 06.10.2017 23:30, Shuah Khan wrote: > Check if firmware is allocated before requesting firmware instead of > requesting firmware only to release it if firmware is not allocated. > > Signed-off-by: Shuah Khan > --- >

Re: [PATCH 1/2] media: s5p-mfc: check for firmware allocation before requesting firmware

Hi Shuah, On 06.10.2017 23:30, Shuah Khan wrote: > Check if firmware is allocated before requesting firmware instead of > requesting firmware only to release it if firmware is not allocated. > > Signed-off-by: Shuah Khan > --- > drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 10 +- > 1

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

On 26.10.2017 18:09, Philippe Cornu wrote: > The pixel clock is optional. When available, it offers a better > preciseness for timing computations. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 24 ++-- > 1

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

On 26.10.2017 18:09, Philippe Cornu wrote: > The pixel clock is optional. When available, it offers a better > preciseness for timing computations. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 24 ++-- > 1 file changed, 18

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Laurent, Thank you for the review. On 18.10.2017 17:11, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patch. > > On Thursday, 28 September 2017 16:07:27 EEST Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >>

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Laurent, Thank you for the review. On 18.10.2017 17:11, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patch. > > On Thursday, 28 September 2017 16:07:27 EEST Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >>

Re: [PATCH v5 4/9] drm/bridge: analogix_dp: Fix connector & encoder cleanup

} > > + rockchip_drm_psr_register(>encoder, analogix_dp_psr_set); You are changing here order of calls: psr_reg after bind, it does not seem to be related to patch subject. Anyway psr_register can fail and its result is not checked, but it can be addressed in separate patch. So may

Re: [PATCH v5 4/9] drm/bridge: analogix_dp: Fix connector & encoder cleanup

rockchip_drm_psr_register(>encoder, analogix_dp_psr_set); You are changing here order of calls: psr_reg after bind, it does not seem to be related to patch subject. Anyway psr_register can fail and its result is not checked, but it can be addressed in separate patch. So maybe it would be better to leave the o

Re: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's drvdata

sting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa <tf...@chromium.org> > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Thanks for making it a bit saner. Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>  -- Regards Andrzej

Re: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's drvdata

same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa > Signed-off-by: Jeffy Chen Thanks for making it a bit saner. Reviewed-by: Andrzej Hajda  -- Regards Andrzej

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

On 06.10.2017 19:23, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:10 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> Hi Rob, >> >> Thanks for review. >> >> On 06.10.2017 01:12, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 03:07:27PM +0200,

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

On 06.10.2017 19:23, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:10 AM, Andrzej Hajda wrote: >> Hi Rob, >> >> Thanks for review. >> >> On 06.10.2017 01:12, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >>

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Rob, Thanks for review. On 06.10.2017 01:12, Rob Herring wrote: > On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB conne

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Rob, Thanks for review. On 06.10.2017 01:12, Rob Herring wrote: > On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB conne

[RFC PATCH 4/4] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH 4/4] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

Signed-off-by: Andrzej Hajda --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get state logic. Code finding extcon node is hacky IMO, I guess ultimately it should be done

[RFC PATCH 0/4] dt-bindings: add bindings for USB physical connector

Hi, This patchset introduces USB connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. Regards Andrzej Andrzej Hajda (3): dt-bindings: add bindings for USB physical connector arm64: dts: exynos: add micro-USB connector

[RFC PATCH 0/4] dt-bindings: add bindings for USB physical connector

Hi, This patchset introduces USB connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. Regards Andrzej Andrzej Hajda (3): dt-bindings: add bindings for USB physical connector arm64: dts: exynos: add micro-USB connector

[RFC PATCH 3/4] extcon: add possibility to get extcon device by of node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/extcon/extcon.c | 44 ++-- i

[RFC PATCH 3/4] extcon: add possibility to get extcon device by of node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda --- drivers/extcon/extcon.c | 44 ++-- include/linux/extcon.h | 6

[RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- There are few things for discussion (IMO): 1. vendor specific connectors, I have added them here, but maybe better is to place them in separate files. 2. physical connector description - I have split it to

[RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda --- There are few things for discussion (IMO): 1. vendor specific connectors, I have added them here, but maybe better is to place them in separate files. 2. physical connector description - I have split it to three properties: type(a,b,ab,c

[RFC PATCH 2/4] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 47 -- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH 2/4] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 47 -- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2

Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

Unable to get reset control: %d\n", ret); > - return ERR_PTR(ret); > - } > + dev_err(dev, "Unable to get reset control: %d\n", ret); I think in case of deferred probing it shouldn't be dev_err, but this is rather suggestion. > + return ERR_PTR(ret); return apb_rst; With this fixed: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > } > > if (apb_rst) {

Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

R(ret); > - } > + dev_err(dev, "Unable to get reset control: %d\n", ret); I think in case of deferred probing it shouldn't be dev_err, but this is rather suggestion. > + return ERR_PTR(ret); return apb_rst; With this fixed: Reviewed-by: Andrzej Hajda -- Regards Andrzej > } > > if (apb_rst) {

Re: [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

NU <philippe.co...@st.com> > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

hilippe CORNU > Reviewed-by: Laurent Pinchart Reviewed-by: Andrzej Hajda -- Regards Andrzej

Re: [PATCH v3 1/3] drm/bridge/synopsys: dsi: Constify funcs structures

ic struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > +static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > .mode_set = dw_mipi_dsi_bridge_mode_set, > .enable = dw_mipi_dsi_bridge_enable, > .post_disable = dw_mipi_dsi_bridge_post_disable, Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 1/3] drm/bridge/synopsys: dsi: Constify funcs structures

truct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = { > .mode_set = dw_mipi_dsi_bridge_mode_set, > .enable = dw_mipi_dsi_bridge_enable, > .post_disable = dw_mipi_dsi_bridge_post_disable, Reviewed-by: Andrzej Hajda -- Regards Andrzej

Re: [PATCH v6 2/5] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

t; However, we can maintain a more exact vrefresh value (not just the > integer approximation), by scaling by the ratio of our clocks. > > v2: Use math suggested by Andrzej Hajda instead. > v3: Simplify math now that adjusted_mode->clock isn't padded. > > Signed-off-by: Eric An

Re: [PATCH v6 2/5] drm/vc4: Avoid using vrefresh==0 mode in DSI htotal math.

t; However, we can maintain a more exact vrefresh value (not just the > integer approximation), by scaling by the ratio of our clocks. > > v2: Use math suggested by Andrzej Hajda instead. > v3: Simplify math now that adjusted_mode->clock isn't padded. > > Signed-off-by: Er

Re: [PATCH 15/18] drm/panel: Add Huarui LHR050H41 panel driver

On 13.07.2017 16:13, Maxime Ripard wrote: > The LHR050H41 panel is the panel shipped with the BananaPi M2-Magic. Add a > driver for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/panel/Kconfig | 9 +- >

Re: [PATCH 15/18] drm/panel: Add Huarui LHR050H41 panel driver

On 13.07.2017 16:13, Maxime Ripard wrote: > The LHR050H41 panel is the panel shipped with the BananaPi M2-Magic. Add a > driver for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/panel/Kconfig | 9 +- > drivers/gpu/drm/panel/Makefile | 1 +- >

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

On 12.07.2017 15:25, Andrzej Hajda wrote: > On 27.06.2017 04:11, Hoegeun Kwon wrote: >> This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver >> which uses mipi_dsi bus to communicate with panel. The panel has >> 320×320 resolution in 1.63" physical

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

On 12.07.2017 15:25, Andrzej Hajda wrote: > On 27.06.2017 04:11, Hoegeun Kwon wrote: >> This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver >> which uses mipi_dsi bus to communicate with panel. The panel has >> 320×320 resolution in 1.63" physical

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

t; +} > + > +static int s6e63j0x03_prepare(struct drm_panel *panel) > +{ > + struct s6e63j0x03 *ctx = panel_to_s6e63j0x03(panel); > + int ret; > + > + ret = s6e63j0x03_power_on(ctx); > + if (ret < 0) > + return ret; > + > + r

Re: [PATCH v3 2/3] drm/panel: Add support for s6e63j0x03 panel driver

rn ret; > + > + ret = s6e63j0x03_apply_mtp_key(ctx, false); > + if (ret < 0) > + return ret; > + > + return 0; > +} > + > +static int s6e63j0x03_prepare(struct drm_panel *panel) > +{ > + struct s6e63j0x03 *ctx = panel_to_s6e63j0x03(panel); > +

Re: [PATCH] s5k5baf: remove unnecessary static in s5k5baf_get_selection()

and after the code change: > > before: >textdata bss dec hex filename > 277655656 320 3374183cd drivers/media/i2c/s5k5baf.o > > after: >textdata bss dec hex filename > 277335600 256 335898335 drivers/med

Re: [PATCH] s5k5baf: remove unnecessary static in s5k5baf_get_selection()

and after the code change: > > before: >textdata bss dec hex filename > 277655656 320 3374183cd drivers/media/i2c/s5k5baf.o > > after: >textdata bss dec hex filename > 277335600 256 335898335 drivers/media/i

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 17:22, Eric Anholt wrote: > Andrzej Hajda <a.ha...@samsung.com> writes: > >> On 29.06.2017 07:03, Archit Taneja wrote: >>> On 06/28/2017 01:28 AM, Eric Anholt wrote: >>>> When a mipi_dsi_host is registered, the DT is walked to find any child >

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 17:22, Eric Anholt wrote: > Andrzej Hajda writes: > >> On 29.06.2017 07:03, Archit Taneja wrote: >>> On 06/28/2017 01:28 AM, Eric Anholt wrote: >>>> When a mipi_dsi_host is registered, the DT is walked to find any child >>>> nodes w

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 07:03, Archit Taneja wrote: > > On 06/28/2017 01:28 AM, Eric Anholt wrote: >> When a mipi_dsi_host is registered, the DT is walked to find any child >> nodes with compatible strings. Those get registered as DSI devices, >> and most DSI panel drivers are mipi_dsi_drivers that attach

Re: [PATCH 6/8] drm: Allow DSI devices to be registered before the host registers.

On 29.06.2017 07:03, Archit Taneja wrote: > > On 06/28/2017 01:28 AM, Eric Anholt wrote: >> When a mipi_dsi_host is registered, the DT is walked to find any child >> nodes with compatible strings. Those get registered as DSI devices, >> and most DSI panel drivers are mipi_dsi_drivers that attach

Re: [PATCH 5/8] drm/vc4: Delay DSI host registration until the panel has probed.

ma_mask; > int ret; > @@ -1599,6 +1577,20 @@ static int vc4_dsi_bind(struct device *dev, struct > device *master, void *data) > return ret; > } > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > +

Re: [PATCH 5/8] drm/vc4: Delay DSI host registration until the panel has probed.

k; > int ret; > @@ -1599,6 +1577,20 @@ static int vc4_dsi_bind(struct device *dev, struct > device *master, void *data) > return ret; > } > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > +

Re: [PATCH 4/8] drm/bridge: Add a devm_ allocator for panel bridge.

void *res) > +{ > + struct drm_bridge *bridge = *(struct drm_bridge **)res; > + > + drm_panel_bridge_remove(bridge); I guess more elegant would be: struct drm_bridge **bridge = res; drm_panel_bridge_remove(*bridge); I am still not convinced to the idea of this panel_bridge stu

Re: [PATCH 4/8] drm/bridge: Add a devm_ allocator for panel bridge.

ridge *bridge = *(struct drm_bridge **)res; > + > + drm_panel_bridge_remove(bridge); I guess more elegant would be: struct drm_bridge **bridge = res; drm_panel_bridge_remove(*bridge); I am still not convinced to the idea of this panel_bridge stuff, but this is different i

Re: [PATCH 3/8] drm/vc4: Use drm_mode_vrefresh() in DSI fixup, in case vrefresh is 0.

On 27.06.2017 21:58, Eric Anholt wrote: > I'm not sure what changed where I started getting vrefresh=0 from the > mode to be fixed up. It can be a case of low pixel_clock value, maybe it should be investigated further, unless there is execution path with forgotten mode->vrefresh =

Re: [PATCH 3/8] drm/vc4: Use drm_mode_vrefresh() in DSI fixup, in case vrefresh is 0.

On 27.06.2017 21:58, Eric Anholt wrote: > I'm not sure what changed where I started getting vrefresh=0 from the > mode to be fixed up. It can be a case of low pixel_clock value, maybe it should be investigated further, unless there is execution path with forgotten mode->vrefresh =

Re: [PATCH 2/8] drm/vc4: Fix misleading name of the continuous flag.

On 27.06.2017 21:58, Eric Anholt wrote: > The logic was all right in the end, the name was just backwards. > > Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH 2/8] drm/vc4: Fix misleading name of the continuous flag.

On 27.06.2017 21:58, Eric Anholt wrote: > The logic was all right in the end, the name was just backwards. > > Signed-off-by: Eric Anholt Reviewed-by: Andrzej Hajda -- Regards Andrzej

Re: [PATCH 1/8] drm/vc4: Fix DSI T_INIT timing.

olt.net> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH 1/8] drm/vc4: Fix DSI T_INIT timing.

On 27.06.2017 21:58, Eric Anholt wrote: > The DPHY spec requires a much larger T_INIT than I was specifying > before. In the absence of clear specs from the slave of what their > timing is, just use the value that the firmware was using. > > Signed-off-by: Eric Anholt Reviewed-by

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

On 27.06.2017 11:13, Inki Dae wrote: > Hi Andrzej, > > 2017년 06월 26일 16:02에 Andrzej Hajda 이(가) 쓴 글: >> Hi Shuah, >> >> >> On 24.06.2017 02:56, Shuah Khan wrote: >>> Fix to call of_node_put() right after of_drm_find_bridge() instead of >>> hol

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

On 27.06.2017 11:13, Inki Dae wrote: > Hi Andrzej, > > 2017년 06월 26일 16:02에 Andrzej Hajda 이(가) 쓴 글: >> Hi Shuah, >> >> >> On 24.06.2017 02:56, Shuah Khan wrote: >>> Fix to call of_node_put() right after of_drm_find_bridge() instead of >>> hol

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

Hi Shuah, On 24.06.2017 02:56, Shuah Khan wrote: > Fix to call of_node_put() right after of_drm_find_bridge() instead of > holding on to it until exynos_dsi_remove(). I think the current implementation is OK, node is get in probe and put in remove. There could be many bind/unbind during

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

Hi Shuah, On 24.06.2017 02:56, Shuah Khan wrote: > Fix to call of_node_put() right after of_drm_find_bridge() instead of > holding on to it until exynos_dsi_remove(). I think the current implementation is OK, node is get in probe and put in remove. There could be many bind/unbind during

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 15:34, Boris Brezillon wrote: > On Thu, 22 Jun 2017 15:16:47 +0200 > Andrzej Hajda <a.ha...@samsung.com> wrote: > >> On 22.06.2017 14:41, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 14:29:07 +0200 >>> Andrzej Hajda <a.ha...@samsung.com>

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 15:34, Boris Brezillon wrote: > On Thu, 22 Jun 2017 15:16:47 +0200 > Andrzej Hajda wrote: > >> On 22.06.2017 14:41, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 14:29:07 +0200 >>> Andrzej Hajda wrote: >>> >>>> On 22.06.201

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 14:41, Boris Brezillon wrote: > On Thu, 22 Jun 2017 14:29:07 +0200 > Andrzej Hajda <a.ha...@samsung.com> wrote: > >> On 22.06.2017 11:23, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 13:47:43 +0530 >>> Archit Taneja <arch...@codeaurora.org

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 14:41, Boris Brezillon wrote: > On Thu, 22 Jun 2017 14:29:07 +0200 > Andrzej Hajda wrote: > >> On 22.06.2017 11:23, Boris Brezillon wrote: >>> On Thu, 22 Jun 2017 13:47:43 +0530 >>> Archit Taneja wrote: >>> >>>> On 06/22/2017

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 11:23, Boris Brezillon wrote: > On Thu, 22 Jun 2017 13:47:43 +0530 > Archit Taneja wrote: > >> On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: >>> 2017-06-20 19:31 GMT+02:00 Eric Anholt : Archit Taneja writes:

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

On 22.06.2017 11:23, Boris Brezillon wrote: > On Thu, 22 Jun 2017 13:47:43 +0530 > Archit Taneja wrote: > >> On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: >>> 2017-06-20 19:31 GMT+02:00 Eric Anholt : Archit Taneja writes: > On 06/16/2017 08:13 PM, Eric Anholt wrote: >>

Re: [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data.

dec hex filename > 11231 176 0 114072c8f > drivers/gpu/drm/exynos/exynos_mixer.o > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/

Re: [PATCH] drm: exynos: constify mixer_match_types and *_mxr_drv_data.

dec hex filename > 11231 176 0 114072c8f > drivers/gpu/drm/exynos/exynos_mixer.o > > Signed-off-by: Arvind Yadav Reviewed-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 10 +- > 1 file changed, 5 in

Re: [PATCH] drm: exynos: hdmi: make of_device_ids const.

drm/exynos/exynos_hdmi.o > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] drm: exynos: hdmi: make of_device_ids const.

drm/exynos/exynos_hdmi.o > > Signed-off-by: Arvind Yadav Reviewed-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c > b/drive

Re: [PATCH v2 2/4] drm/panel: Add support for s6e63j0x03 panel driver

On 15.06.2017 12:03, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical panel. This panel is used in > Samsung Galaxy Gear 2. > > Signed-off-by: Inki Dae

Re: [PATCH v2 2/4] drm/panel: Add support for s6e63j0x03 panel driver

On 15.06.2017 12:03, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical panel. This panel is used in > Samsung Galaxy Gear 2. > > Signed-off-by: Inki Dae

Re: [PATCH 2/3] drm/panel: Add support for s6e63j0x03 panel driver

Hi Hoegeun, Nice to see patches completing support for mainlined platforms. On 09.06.2017 06:59, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical

Re: [PATCH 2/3] drm/panel: Add support for s6e63j0x03 panel driver

Hi Hoegeun, Nice to see patches completing support for mainlined platforms. On 09.06.2017 06:59, Hoegeun Kwon wrote: > This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver > which uses mipi_dsi bus to communicate with panel. The panel has > 320×320 resolution in 1.63" physical

Re: [PATCH 1/3] dt-bindings: Add support for samsung s6e63j0x03 panel binding

voltage supply for analog circuits > + - reset-gpios: a GPIO spec for the reset pin (active high) Usually reset gpios is active low, also driver code suggests it, if it is true please fix example also. With above comments addressed: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>

Re: [PATCH 1/3] dt-bindings: Add support for samsung s6e63j0x03 panel binding

its > + - reset-gpios: a GPIO spec for the reset pin (active high) Usually reset gpios is active low, also driver code suggests it, if it is true please fix example also. With above comments addressed: Reviewed-by: Andrzej Hajda -- Regards Andrzej > +

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

On 15.05.2017 11:30, Daniel Vetter wrote: > On Mon, May 15, 2017 at 10:39:35AM +0200, Andrzej Hajda wrote: >> On 11.05.2017 11:06, Jose Abreu wrote: >>> This changes the connector probe helper function to use the new >>> encoder->mode_valid(), bridge->mode_valid()

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

On 15.05.2017 11:30, Daniel Vetter wrote: > On Mon, May 15, 2017 at 10:39:35AM +0200, Andrzej Hajda wrote: >> On 11.05.2017 11:06, Jose Abreu wrote: >>> This changes the connector probe helper function to use the new >>> encoder->mode_valid(), bridge->mode_valid()

Re: [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback

t; Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a.ha..

Re: [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback

Alexey Brodkin > Cc: Ville Syrjälä > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Andrzej Hajda > Cc: Archit Taneja Reviewed-by: Andrzej Hajda -- Regards Andrzej

Re: [PATCH v3 5/6] drm: Use mode_valid() in atomic modeset

el.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a.ha...@samsung.com> > Cc: Archit Taneja <arch...@codeaurora.org> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej

Re: [PATCH v3 5/6] drm: Use mode_valid() in atomic modeset

so that we can make sure that the mode will > be accepted in every components. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Ville Syrjälä > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Andrzej Hajda > Cc: Archit Taneja Reviewed-by: Andrzej Hajda -- Regards Andrzej

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

DE_OK. > > Signed-off-by: Jose Abreu <joab...@synopsys.com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave

Re: [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

gt; > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Ville Syrjälä > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Andrzej Hajda > Cc: Archit Taneja > --- > > Changes v2->v3: > - Call also bridge->mode_valid (

Re: [PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid()

com> > Cc: Carlos Palminha <palmi...@synopsys.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Dave Airlie <airl...@linux.ie> > Cc: Andrzej Hajda <a

Re: [PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid()

yrjälä > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Andrzej Hajda > Cc: Archit Taneja > --- > Changes v2->v3: > - Move helpers to drm_probe_helper.c (Daniel) > - Squeeze patches that introduce the helpers into a single > one (Daniel) > > driv

Re: [PATCH v3 0/6] Introduce new mode validation callbacks

e helper >> drm: Use mode_valid() in atomic modeset >> drm: arc: Use crtc->mode_valid() callback >> >> Cc: Carlos Palminha <palmi...@synopsys.com> >> Cc: Alexey Brodkin <abrod...@synopsys.com> >> Cc: Ville Syrjälä <ville.syrj...@linux

Re: [PATCH v3 0/6] Introduce new mode validation callbacks

obe helper >> drm: Use mode_valid() in atomic modeset >> drm: arc: Use crtc->mode_valid() callback >> >> Cc: Carlos Palminha >> Cc: Alexey Brodkin >> Cc: Ville Syrjälä >> Cc: Daniel Vetter >> Cc: Dave Airlie >> Cc: Andrzej Hajda >

Re: [PATCH v4 3/3] mfd: arizona: Refactor arizona_poll_reg

Hi Charles, On 15.03.2017 15:58, Charles Keepax wrote: > Currently, we specify the timeout in terms of the number of polls but it > is more clear from a user of the functions perspective to specify the > timeout directly in milliseconds, as such update the function to these new > semantics. > >

Re: [PATCH v4 3/3] mfd: arizona: Refactor arizona_poll_reg

Hi Charles, On 15.03.2017 15:58, Charles Keepax wrote: > Currently, we specify the timeout in terms of the number of polls but it > is more clear from a user of the functions perspective to specify the > timeout directly in milliseconds, as such update the function to these new > semantics. > >

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

On 04.05.2017 14:35, Thierry Reding wrote: > On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: >> On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: >>> Laurent Pinchart writes: >>> Hi Daniel, On Wednesday 03 May

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

On 04.05.2017 14:35, Thierry Reding wrote: > On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: >> On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: >>> Laurent Pinchart writes: >>> Hi Daniel, On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: > On Wed, May

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Jose, On 26.04.2017 12:48, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if the crtc has

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Jose, On 26.04.2017 12:48, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if the crtc has

Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag

ge/parade-ps8622.c > index 1dcec3b..ada2186 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8622.c > +++ b/drivers/gpu/drm/bridge/parade-ps8622.c > @@ -28,10 +28,10 @@ > #include > #include > > -#include "drmP.h" > -#include "drm_crtc.

Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag

dcec3b..ada2186 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8622.c > +++ b/drivers/gpu/drm/bridge/parade-ps8622.c > @@ -28,10 +28,10 @@ > #include > #include > > -#include "drmP.h" > -#include "drm_crtc.h" > -#include "drm_crtc_helper.h&

Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

On 18.04.2017 09:44, Hoegeun Kwon wrote: > On 04/18/2017 03:00 PM, Andrzej Hajda wrote: >> On 17.04.2017 08:02, Hoegeun Kwon wrote: >>> This patch add the panel device tree node for s6e3hf2 display >>> controller to TM2e dts. >>> >>> Signed-off-by: Hoe

Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

On 18.04.2017 09:44, Hoegeun Kwon wrote: > On 04/18/2017 03:00 PM, Andrzej Hajda wrote: >> On 17.04.2017 08:02, Hoegeun Kwon wrote: >>> This patch add the panel device tree node for s6e3hf2 display >>> controller to TM2e dts. >>> >>> Signed-off-by: Hoeg

Re: [PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

t is not necessary and generates useless interrupts. Beside this: Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> -- Regards Andrzej > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/b

<    1   2   3   4   5   6   7   8   9   10   >