On Fri, Nov 09, 2012 at 09:38:12AM +0800, Tao Ma wrote:
> From: Tao Ma
>
> In 9c0ece069, Linus removes feature-removal-schedule.txt from Documentation,
> but there is still some reference to this file. So remove them.
>
> Cc: Andrew Morton
> Cc: Andy Whitcroft
&g
my $asm_volatile =
qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
if ($line =~ /\bvolatile\b/ $line !~ /$asm_volatile/) {
--
1.7.0.4
Looks sane and cirtainly if the file is gone we are gaining nothing with
this code.
Acked-by: Andy Whitcroft a...@canonical.com
-apw
On Thu, Nov 08, 2012 at 09:50:33PM +0800, Tao Ma wrote:
> From: Tao Ma
>
> In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation,
> but there is still some reference to this file. So remove them.
>
> Cc: Andrew Morton
> Cc: Andy Whitcroft
> Cc:
On Thu, Nov 08, 2012 at 09:50:33PM +0800, Tao Ma wrote:
From: Tao Ma boyu...@taobao.com
In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation,
but there is still some reference to this file. So remove them.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andy
On Tue, Nov 06, 2012 at 03:36:25PM -0800, Andrew Morton wrote:
> On Thu, 1 Nov 2012 00:12:18 -0700
> Joe Perches wrote:
>
> > Linux kernel doesn't like floating point, say so.
> >
> > ...
> >
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2332,6 +2332,13 @@ sub process
On Tue, Nov 06, 2012 at 03:36:25PM -0800, Andrew Morton wrote:
On Thu, 1 Nov 2012 00:12:18 -0700
Joe Perches j...@perches.com wrote:
Linux kernel doesn't like floating point, say so.
...
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2332,6 +2332,13 @@ sub process
EXPERIMENTAL while it is being phased out.
>
> Cc: Andy Whitcroft
> Signed-off-by: Kees Cook
> ---
> scripts/checkpatch.pl |7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 21a9f5d..37dc932 10075
it is being phased out.
Cc: Andy Whitcroft a...@canonical.com
Signed-off-by: Kees Cook keesc...@chromium.org
---
scripts/checkpatch.pl |7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 21a9f5d..37dc932 100755
--- a/scripts
On Thu, Oct 11, 2012 at 10:04:28PM +0800, Jeremy Kerr wrote:
> Hi Andy,
>
> >@@ -969,16 +970,18 @@
> > return -ENOMEM;
> >
> > list_for_each_entry_safe(entry, n, >list, list) {
> >-struct inode *inode;
> > struct dentry *dentry, *root = efivarfs_sb->s_root;
Ensure we free both the name and inode on error when building the
individual variables.
Signed-off-by: Andy Whitcroft
---
drivers/firmware/efivars.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware
When d_make_root() fails it will automatically drop the reference
on the root inode. We should not be doing so as well.
Signed-off-by: Andy Whitcroft
---
drivers/firmware/efivars.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/firmware
d_alloc_name() copies the passed name to new storage, once complete we
no longer need our name.
Signed-off-by: Andy Whitcroft
---
drivers/firmware/efivars.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 79f3e4e..dcb34ae
verify so deserve review.
On top of 7b218e8e5d433fc8b531ce911926e06de3e6f1f6 in Matt Flemmings efi.git
repo.
-apw
Andy Whitcroft (5):
efivarfs: efivarfs_file_read ensure we free data in error paths
efivarfs: efivarfs_create() ensure we drop our reference on inode on error
efivarfs
Signed-off-by: Andy Whitcroft
---
drivers/firmware/efivars.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 4b12a8fd..ae50d2f 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
Signed-off-by: Andy Whitcroft
---
drivers/firmware/efivars.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index ae50d2f..0bbf742 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index ae50d2f..0bbf742 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 4b12a8fd..ae50d2f 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers
verify so deserve review.
On top of 7b218e8e5d433fc8b531ce911926e06de3e6f1f6 in Matt Flemmings efi.git
repo.
-apw
Andy Whitcroft (5):
efivarfs: efivarfs_file_read ensure we free data in error paths
efivarfs: efivarfs_create() ensure we drop our reference on inode on error
efivarfs
d_alloc_name() copies the passed name to new storage, once complete we
no longer need our name.
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index
When d_make_root() fails it will automatically drop the reference
on the root inode. We should not be doing so as well.
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers
Ensure we free both the name and inode on error when building the
individual variables.
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers
On Thu, Oct 11, 2012 at 10:04:28PM +0800, Jeremy Kerr wrote:
Hi Andy,
@@ -969,16 +970,18 @@
return -ENOMEM;
list_for_each_entry_safe(entry, n, efivars-list, list) {
-struct inode *inode;
struct dentry *dentry, *root = efivarfs_sb-s_root;
-
the notional permissions on the file permit write. This prevents
a copy_up occuring on the file and fails the write.
Switch to using inode permissions directly when the lower layer is
read-only.
BugLink: http://bugs.launchpad.net/bugs/1039402
Signed-off-by: Andy Whitcroft
---
fs/namei.c
://bugs.launchpad.net/bugs/1039402
Signed-off-by: Andy Whitcroft
---
fs/overlayfs/copy_up.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 87dbeee..b0b4229 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs
this, using the inode
permissions when the lowerlayer is read-only. This seems to work as
expected in my limited testing.
Comments on both approaches appreciated.
-apw
Andy Whitcroft (2):
ovl: copy_up_xattr may fail when the upper filesystem does not
support the same xattrs
overlayfs: when
this, using the inode
permissions when the lowerlayer is read-only. This seems to work as
expected in my limited testing.
Comments on both approaches appreciated.
-apw
Andy Whitcroft (2):
ovl: copy_up_xattr may fail when the upper filesystem does not
support the same xattrs
overlayfs: when
://bugs.launchpad.net/bugs/1039402
Signed-off-by: Andy Whitcroft a...@canonical.com
---
fs/overlayfs/copy_up.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 87dbeee..b0b4229 100644
--- a/fs/overlayfs/copy_up.c
the notional permissions on the file permit write. This prevents
a copy_up occuring on the file and fails the write.
Switch to using inode permissions directly when the lower layer is
read-only.
BugLink: http://bugs.launchpad.net/bugs/1039402
Signed-off-by: Andy Whitcroft a...@canonical.com
---
fs
On Fri, Aug 17, 2012 at 08:53:53PM +0200, Olaf Hering wrote:
> On Fri, Aug 17, Ben Hutchings wrote:
>
> > You are never going to have a 'works everywhere' solution for
> > Linux guests.
>
> The hook is the solution.
>
> > How are these distribution-specific integration scripts going
> > to get
On Fri, Aug 17, 2012 at 08:53:53PM +0200, Olaf Hering wrote:
On Fri, Aug 17, Ben Hutchings wrote:
You are never going to have a 'works everywhere' solution for
Linux guests.
The hook is the solution.
How are these distribution-specific integration scripts going
to get installed in
On Wed, Aug 15, 2012 at 09:59:51AM -0700, Casey Schaufler wrote:
> On 8/15/2012 8:48 AM, Miklos Szeredi wrote:
> > From: Andy Whitcroft
> >
> > When checking permissions on an overlayfs inode we do not take into
> > account either device cgroup restrictio
On Wed, Aug 15, 2012 at 09:59:51AM -0700, Casey Schaufler wrote:
On 8/15/2012 8:48 AM, Miklos Szeredi wrote:
From: Andy Whitcroft a...@canonical.com
When checking permissions on an overlayfs inode we do not take into
account either device cgroup restrictions nor security permissions
launchpad.net/bugs/944386
Signed-off-by: Andy Whitcroft
---
fs/overlayfs/dir.c |2 ++
fs/overlayfs/overlayfs.h |6 ++
fs/overlayfs/super.c |1 +
3 files changed, 9 insertions(+)
After a long hiatus I have had time to look into the issues
highlighted by th
/bugs/944386
Signed-off-by: Andy Whitcroft a...@canonical.com
---
fs/overlayfs/dir.c |2 ++
fs/overlayfs/overlayfs.h |6 ++
fs/overlayfs/super.c |1 +
3 files changed, 9 insertions(+)
After a long hiatus I have had time to look into the issues
highlighted
~ tr/;/;/) == 1 &&
> + $stmts !~ /^\s*(if|while|for|switch)\b/) {
> WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
> "Single statement macros should
> not use a do {} while (0) loop\n"
On Thu, Aug 02, 2012 at 10:00:04AM +0200, Schrober wrote:
> Hi,
>
> I think your check for SINGLE_STATEMENT_DO_WHILE_MACRO is wrong. Just to give
> an example:
>
> #define foobar(x) \
> do { \
> if (pizza_ready(x)) \
> eat_pizza(x); \
> } while
On Thu, Aug 02, 2012 at 10:00:04AM +0200, Schrober wrote:
Hi,
I think your check for SINGLE_STATEMENT_DO_WHILE_MACRO is wrong. Just to give
an example:
#define foobar(x) \
do { \
if (pizza_ready(x)) \
eat_pizza(x); \
} while (0)
if
{} while (0) loop\n . $herectx);
}
Looks reasonable enough.
Acked-by: Andy Whitcroft a...@canonical.com
-apw
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Mon, Jul 23, 2012 at 10:26:29AM -0700, Tony Luck wrote:
> checkpatch just gave me:
>
>WARNING: Non-standard signature: Suggested-by:
Seems reasonable indeed.
> There are over 500 instances of 'Suggested-by:', and it seems
> to have some value in tracking history and awarding credit
>
On Mon, Jul 23, 2012 at 10:26:29AM -0700, Tony Luck wrote:
checkpatch just gave me:
WARNING: Non-standard signature: Suggested-by:
Seems reasonable indeed.
There are over 500 instances of 'Suggested-by:', and it seems
to have some value in tracking history and awarding credit
where it
On Tue, Feb 26, 2008 at 11:49:48AM +0100, Ingo Molnar wrote:
>
> * Andy Whitcroft <[EMAIL PROTECTED]> wrote:
>
> > Ok, so that would be the following, work for everyone?
> >
> > WARNING: mutexes are preferred for single holder semaphores
> > #1: F
On Mon, Feb 25, 2008 at 06:34:49PM -0500, Christoph Hellwig wrote:
> On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
> > the things which it finds.
> >
> > > +static DECLARE_MUTEX(kmmio_init_mutex);
> >
> > That's not a mutex.
> >
> > > + down(_init_mutex);
> >
> > It's a
On Mon, Feb 25, 2008 at 09:42:00PM -0500, Pavel Roskin wrote:
> Quoting Christoph Hellwig <[EMAIL PROTECTED]>:
>
> >On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
> >>the things which it finds.
> >>
> >>> +static DECLARE_MUTEX(kmmio_init_mutex);
> >>
> >>That's not a mutex.
> >>
>
On Mon, Feb 25, 2008 at 09:42:00PM -0500, Pavel Roskin wrote:
Quoting Christoph Hellwig [EMAIL PROTECTED]:
On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
the things which it finds.
+static DECLARE_MUTEX(kmmio_init_mutex);
That's not a mutex.
+
On Mon, Feb 25, 2008 at 06:34:49PM -0500, Christoph Hellwig wrote:
On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
the things which it finds.
+static DECLARE_MUTEX(kmmio_init_mutex);
That's not a mutex.
+ down(kmmio_init_mutex);
It's a semaphore. Please do
On Tue, Feb 26, 2008 at 11:49:48AM +0100, Ingo Molnar wrote:
* Andy Whitcroft [EMAIL PROTECTED] wrote:
Ok, so that would be the following, work for everyone?
WARNING: mutexes are preferred for single holder semaphores
#1: FILE: Z95.c:1:
+ DECLARE_MUTEX(foo);
WARNING
On Mon, Feb 25, 2008 at 07:53:20PM +0100, Jörn Engel wrote:
> On Mon, 25 February 2008 09:48:22 -0800, Dave Hansen wrote:
> > On Mon, 2008-02-25 at 15:07 +0000, Andy Whitcroft wrote:
> > > shrink_page_list() would be expected to be passed pages pulled from
> > > the a
On Sun, Feb 24, 2008 at 03:47:11PM +0100, Jörn Engel wrote:
> While tracking down some unrelated bug I noticed that shrink_page_list()
> keeps testing very low page numbers (aka kernel text) until deciding
> that the page lacks a mapping and cannot get freed. Looks like a waste
> of cpu and
On Mon, Feb 25, 2008 at 10:21:01AM +0330, Paolo Ciarrocchi wrote:
> On 2/25/08, Andy Whitcroft
> > As we want the messages to be as short as possible, I am leaning towards
> > standardising on:
> >
> > spaces prohibited
> > spaces required
> >
> in that
On Mon, Feb 25, 2008 at 10:21:01AM +0330, Paolo Ciarrocchi wrote:
On 2/25/08, Andy Whitcroft
As we want the messages to be as short as possible, I am leaning towards
standardising on:
spaces prohibited where
spaces required where
in that case i would prefer:
space not required
On Sun, Feb 24, 2008 at 03:47:11PM +0100, Jörn Engel wrote:
While tracking down some unrelated bug I noticed that shrink_page_list()
keeps testing very low page numbers (aka kernel text) until deciding
that the page lacks a mapping and cannot get freed. Looks like a waste
of cpu and
On Mon, Feb 25, 2008 at 07:53:20PM +0100, Jörn Engel wrote:
On Mon, 25 February 2008 09:48:22 -0800, Dave Hansen wrote:
On Mon, 2008-02-25 at 15:07 +, Andy Whitcroft wrote:
shrink_page_list() would be expected to be passed pages pulled from
the active or inactive lists via
On Fri, Feb 22, 2008 at 02:26:12PM +0100, Andi Kleen wrote:
> At some point checkpatch.pl would need to be updated to know about this
> exception too, that would be the next step.
Cirtainly we have exceptions for docstrings, so that shouldn't be a
problem if this were accepted.
-apw
--
To
On Sat, Feb 23, 2008 at 01:55:32PM +0100, Christer Weinigel wrote:
> Andi Kleen wrote:
> >RFC: Update coding standard to avoid split up printk format strings
>
> While we're talking about checkpatch.pl, I'd definitely like to teach
> checkpatch about "list_for_each" and friends.
>
>
On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
> On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <[EMAIL PROTECTED]> wrote:
> [...]
> > How about:
> > - WARN("no space between function name and
> > open parenthesis '('\n" . $herecurr);
> > +
On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy [EMAIL PROTECTED] wrote:
[...]
How about:
- WARN(no space between function name and
open parenthesis '('\n . $herecurr);
+
On Sat, Feb 23, 2008 at 01:55:32PM +0100, Christer Weinigel wrote:
Andi Kleen wrote:
RFC: Update coding standard to avoid split up printk format strings
While we're talking about checkpatch.pl, I'd definitely like to teach
checkpatch about list_for_each and friends.
list_for_each is flow
On Fri, Feb 22, 2008 at 02:26:12PM +0100, Andi Kleen wrote:
At some point checkpatch.pl would need to be updated to know about this
exception too, that would be the next step.
Cirtainly we have exceptions for docstrings, so that shouldn't be a
problem if this were accepted.
-apw
--
To
to the hugepage pool, drop the pool locks and then clear
page private. In either case the page may have been reallocated. BAD.
Make sure we clear out page private before we free the page.
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
---
mm/hugetlb.c |2 +-
1 files changed, 1 inse
On Tue, Feb 19, 2008 at 12:03:37AM +0100, Dmitry Adamushko wrote:
>
> Hi,
>
>
> [ description ]
>
> Subject: kthread: add a memory barrier to kthread_stop()
>
> 'kthread' threads do a check in the following order:
> - set_current_state(TASK_INTERRUPTIBLE);
> - kthread_should_stop();
>
> and
On Tue, Feb 19, 2008 at 12:03:37AM +0100, Dmitry Adamushko wrote:
Hi,
[ description ]
Subject: kthread: add a memory barrier to kthread_stop()
'kthread' threads do a check in the following order:
- set_current_state(TASK_INTERRUPTIBLE);
- kthread_should_stop();
and
to the hugepage pool, drop the pool locks and then clear
page private. In either case the page may have been reallocated. BAD.
Make sure we clear out page private before we free the page.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
mm/hugetlb.c |2 +-
1 files changed, 1 insertions
This version brings a number of minor fixes updating the type detector and
the unary tracker. It also brings a few small fixes for false positives.
It also reverts the --file warning. Of note:
- limit CVS checks to added lines
- improved type detections
- fixes to the unary tracker
Andy
This version brings a number of minor fixes updating the type detector and
the unary tracker. It also brings a few small fixes for false positives.
It also reverts the --file warning. Of note:
- limit CVS checks to added lines
- improved type detections
- fixes to the unary tracker
Andy
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote:
> Hi,
>
> On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote:
> > People, who do cleanups - I'm not talking about running lindent here -
> > read through the code while they fix it up.
> >
> > Actually they find bugs
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote:
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner [EMAIL PROTECTED] wrote:
People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix it up.
Actually they find bugs that way or at
On Fri, Feb 15, 2008 at 06:31:43PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> I have created today's linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git.
>
> Between each merge, the tree was built with allmodconfig for both
> powerpc and x86_64.
>
> You can
On Thu, Feb 14, 2008 at 11:31:28AM -0800, Harvey Harrison wrote:
> fastcall no longer exists in tree, remove it from checkpatch.
>
> Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
Seems to be true :) Have sucked this up for 0.15. Thanks.
-apw
> ---
> scripts/checkpatch.pl |3 +--
>
On Thu, Feb 14, 2008 at 11:31:28AM -0800, Harvey Harrison wrote:
fastcall no longer exists in tree, remove it from checkpatch.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
Seems to be true :) Have sucked this up for 0.15. Thanks.
-apw
---
scripts/checkpatch.pl |3 +--
1 files
On Fri, Feb 15, 2008 at 06:31:43PM +1100, Stephen Rothwell wrote:
Hi all,
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git.
Between each merge, the tree was built with allmodconfig for both
powerpc and x86_64.
You can see which
On Fri, Feb 15, 2008 at 12:35:37AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> I have created the first cut of the linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git.
>
> Things to know about this tree:
>
> It has two branches - master and stable. Stable is
On Wed, Feb 13, 2008 at 08:43:58PM +0100, Jan Engelhardt wrote:
>
> On Feb 10 2008 15:33, Marcin Slusarz wrote:
> >Checkpatch in current mainline outputs following errors:
> >
> >$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
> >ERROR: need consistent spacing around '*' (ctx:WxV)
> >#205:
On Wed, Feb 13, 2008 at 08:43:58PM +0100, Jan Engelhardt wrote:
On Feb 10 2008 15:33, Marcin Slusarz wrote:
Checkpatch in current mainline outputs following errors:
$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
ERROR: need consistent spacing around '*' (ctx:WxV)
#205: FILE:
On Fri, Feb 15, 2008 at 12:35:37AM +1100, Stephen Rothwell wrote:
Hi all,
I have created the first cut of the linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git.
Things to know about this tree:
It has two branches - master and stable. Stable is
On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote:
> OK, but the return type doesn't have to be in the patched line, it could be in
> a synchronization line or even missing if the function has a long multi-line
> argument
> list.
Ok, I guess thats fair criticism. Could you check out
On Mon, Feb 11, 2008 at 06:05:48PM +0200, Benny Halevy wrote:
> I saw this too with checkpatch.pl version 0.12
> It seems like checkpatch.pl knows only about types derived
> from @typeList by build_types.
>
> Example below...
>
> Benny
>
> $ cat < Signed-off-by: [EMAIL PROTECTED]
> ---
> diff
On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote:
> Hi
>
> Checkpatch in current mainline outputs following errors:
>
> $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #205: FILE: fs/udf/misc.c:205:
> + tag *tag_p;
>
On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote:
Hi
Checkpatch in current mainline outputs following errors:
$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
ERROR: need consistent spacing around '*' (ctx:WxV)
#205: FILE: fs/udf/misc.c:205:
+ tag *tag_p;
On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote:
OK, but the return type doesn't have to be in the patched line, it could be in
a synchronization line or even missing if the function has a long multi-line
argument
list.
Ok, I guess thats fair criticism. Could you check out the
On Mon, Feb 11, 2008 at 06:05:48PM +0200, Benny Halevy wrote:
I saw this too with checkpatch.pl version 0.12
It seems like checkpatch.pl knows only about types derived
from @typeList by build_types.
Example below...
Benny
$ cat EOF | scripts/checkpatch.pl -
Signed-off-by: [EMAIL
On Tue, Feb 05, 2008 at 09:26:47PM +0200, Benny Halevy wrote:
> Was version 0.13 NACKed?
It was picked up by Andrew for -mm according to my email. I do not
think there has been an -mm release since then however. This patch is
relative to that version.
-apw
--
To unsubscribe from this list:
On Tue, Feb 05, 2008 at 09:26:47PM +0200, Benny Halevy wrote:
Was version 0.13 NACKed?
It was picked up by Andrew for -mm according to my email. I do not
think there has been an -mm release since then however. This patch is
relative to that version.
-apw
--
To unsubscribe from this list: send
On Mon, Jan 28, 2008 at 12:28:41PM -0800, Christoph Lameter wrote:
> Core code for mmu notifiers.
>
> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
> Signed-off-by: Andrea Arcangeli <[EMAIL PROTECTED]>
>
> ---
> include/linux/list.h | 14 ++
> include/linux/mm_types.h |
a warning when --file mode is used
Andy Whitcroft (14):
Version: 0.14
clean up some space violations in checkpatch.pl
a completly empty file should not provoke a whinge
reset report lines buffers between files
unary ++/-- may abutt close braces
__typeof__ is also
a warning when --file mode is used
Andy Whitcroft (14):
Version: 0.14
clean up some space violations in checkpatch.pl
a completly empty file should not provoke a whinge
reset report lines buffers between files
unary ++/-- may abutt close braces
__typeof__ is also
On Mon, Jan 28, 2008 at 12:28:41PM -0800, Christoph Lameter wrote:
Core code for mmu notifiers.
Signed-off-by: Christoph Lameter [EMAIL PROTECTED]
Signed-off-by: Andrea Arcangeli [EMAIL PROTECTED]
---
include/linux/list.h | 14 ++
include/linux/mm_types.h |6 +
On Tue, Jan 29, 2008 at 05:17:28PM -0600, Timur Tabi wrote:
> checkpatch.pl thinks that __asm__ is a function name, so it complains about
> a space between the function name and a parenthesis when it sees
> "__asm__ ("mov ax,bx")".
>
> This change will also encourage developers to use '__asm__'
; static unsigned long clear_active_flags(struct list_head *page_list)
Yeah that is a silly typo.
Acked-by: Andy Whitcroft <[EMAIL PROTECTED]>
-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo
*page_list)
Yeah that is a silly typo.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
-apw
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On Tue, Jan 29, 2008 at 05:17:28PM -0600, Timur Tabi wrote:
checkpatch.pl thinks that __asm__ is a function name, so it complains about
a space between the function name and a parenthesis when it sees
__asm__ (mov ax,bx).
This change will also encourage developers to use '__asm__' instead of
On Thu, Jan 24, 2008 at 01:18:48AM +0100, Roel Kluin wrote:
> Joe Perches wrote:
> > On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
> >> ---
> >> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
> >> index ebf9e21..dcfb459
On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:
> Deprecate checkpatch.pl --file mode; add warning; add --file-force
>
> As discussed on linux-kernel checkpatch.pl only patches for whole
> files have a significant cost. Better such changes should be only
> done together with other
On Mon, Jan 14, 2008 at 11:29:13PM +0100, Paolo Ciarrocchi wrote:
> Hi Andy,
> When I started using checkpatch I was confused by the following WARN message:
>
> no space between function name and open parenthesis
>
> I thought the problem was that a space was missing while the truth is the
On Tue, Jan 22, 2008 at 02:20:48PM +0100, Paolo Ciarrocchi wrote:
> On Jan 14, 2008 11:23 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
> > Add a filename option (default to 0)
> > in order to get the following summary output:
> > ./scripts/checkpatch.pl --filename --file
On Mon, Jan 14, 2008 at 11:19:48PM +0100, Bartlomiej Zolnierkiewicz wrote:
>
> __FUNCTION__ is gcc specific, __func__ is C99
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Research seems to indicate this is indeed sensible as __FUNCTION__ can
cause -Werror to trip. Have
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote:
> > int __initdata user_defined_memmap = 0;
>
> checkpatch should have told you that this "= 0" shouldn't be there. But it
> doesn't.
Ok, this line would be correctly picked up if it was being added by this
author, but this line
On Sun, Jan 27, 2008 at 09:32:57PM -0800, Andrew Morton wrote:
> On Sat, 26 Jan 2008 23:52:48 +0530 Abhishek Sagar <[EMAIL PROTECTED]> wrote:
>
> > This is a repost of a patch which was reviewed earlier at:
> > http://lkml.org/lkml/2007/11/13/58 (thanks to Jim Keniston and Srinivasa
> > for
On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:
Deprecate checkpatch.pl --file mode; add warning; add --file-force
As discussed on linux-kernel checkpatch.pl only patches for whole
files have a significant cost. Better such changes should be only
done together with other
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this = 0 shouldn't be there. But it
doesn't.
Ok, this line would be correctly picked up if it was being added by this
author, but this line is in
On Tue, Jan 22, 2008 at 02:20:48PM +0100, Paolo Ciarrocchi wrote:
On Jan 14, 2008 11:23 PM, Paolo Ciarrocchi [EMAIL PROTECTED] wrote:
Add a filename option (default to 0)
in order to get the following summary output:
./scripts/checkpatch.pl --filename --file ./arch/sparc/kernel/apc.c
...
201 - 300 of 940 matches
Mail list logo
