Fix error message by checkpath.pl
open brace '{' following struct/enum go on the same line
Patch applied by running fix inplace capability of checkpatch:
checkpatch.pl -f *.[ch] --types OPEN_BRACE --fix-inplace
Signed-off-by: Anson Jacob
---
drivers/usb/gadget/function/rndis
Fix checkpatch.pl warning:
ERROR: trailing whitespace
Signed-off-by: Anson Jacob
---
Changes in v2:
- Add Checkpatch warning info to the commit message.
include/linux/module.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/module.h b/include/linux/module.h
On Wed, Oct 19, 2016 at 06:11:59PM -0400, Jessica Yu wrote:
> It would be nice to mention the exact checkpatch.pl error this fixes,
> and include that in the changelog. Other than that, looks good to me.
Thank you for your comments, will send a revised patch.
remove whitespace on blank line
Signed-off-by: Anson Jacob
---
include/linux/module.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index 0c3207d..91df94f 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
Fix checkpatch.pl warning:
Missing a blank line after declarations
Signed-off-by: Anson Jacob
---
drivers/staging/i4l/act2000/act2000_isa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/i4l/act2000/act2000_isa.c
b/drivers/staging/i4l/act2000/act2000_isa.c
index 1d93151
Fix checkpatch.pl warning:
braces {} are not necessary for single statement blocks
Signed-off-by: Anson Jacob
---
drivers/staging/i4l/act2000/act2000_isa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/i4l/act2000/act2000_isa.c
b/drivers/staging/i4l
Fix checkpatch.pl warning:
braces {} are not necessary for single statement blocks
Missing a blank line after declarations
Signed-off-by: Anson Jacob
---
drivers/staging/i4l/act2000/act2000_isa.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/i4l
Fix checkpatch.pl warning:
line over 80 characters
Signed-off-by: Anson Jacob
---
drivers/staging/i4l/act2000/act2000.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/i4l/act2000/act2000.h
b/drivers/staging/i4l/act2000/act2000.h
index 321d437..16be456
Fix checkpath.pl warning:
trailing statements should be on next line
open brace '{' following function declarations go on the next line
Signed-off-by: Anson Jacob
---
drivers/staging/i4l/act2000/capi.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drive
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Fix Commenting Style
Anson Jacob (2):
staging: fsl-mc: dpmng-cmd: Fix checkpatch warning
staging: fsl-mc: dprc-cmd: Fix checkpatch warning
drivers/staging/fsl-mc/bus/dpmng-cmd.h | 15 ---
drivers/staging/fsl-mc
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Fix Commenting Style
Signed-off-by: Anson Jacob
---
drivers/staging/fsl-mc/bus/dprc-cmd.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc-cmd.h
b/drivers
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Fix Commenting Style
Signed-off-by: Anson Jacob
---
drivers/staging/fsl-mc/bus/dpmng-cmd.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpmng-cmd.h
b/drivers
Fix checkpatch.pl warning:
Please use a blank line after function/struct/union/enum declarations
Move macro definition to the top of the file
Aligne macro definitions
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4 ++--
1 file changed, 2 insertions(+), 2
Fix checkpatch.pl warning for 'Statements should start on a tabstop'
Convert single line block comment to single line comment
Align single line comment
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/ni_atmio.c | 11 ---
1 file changed, 4 insertions(+), 7
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Block comments starts with /* followed by comments on the next line
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/jr3_pci.h | 290
Fix checkpatch.pl warning for
Comparisons should place the constant on the right side of the test
Remove extra space after /*
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/s626.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi
Fix checkpatch.pl warning 'line over 80 characters'
Remove extra space after /*
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 170 ++-
1 file changed, 89 insertions(+), 81 deletions(-)
diff --git a/drivers/staging/come
Fix checkpatch.pl warning 'line over 80 characters'
Remove extra space after /*
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/jr3_pci.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
b/drive
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 148 ++-
1 file changed, 77 insertions(+), 71 deletions(-)
diff --git a
Align macro definitions
Anson Jacob (8):
staging: comedi: cb_pcidas64.c: Fix checkpatch warning
staging: comedi: cb_pcidas64: Fix commenting style
staging: comedi: jr3_pci.h: Fix checkpatch warning
staging: comedi: ni_atmio.c: Fix checkpatch warning
staging: comedi
Remove additional space after /*
Convert single line block comment into single line comment
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 431 +--
1 file changed, 214 insertions(+), 217 deletions(-)
diff --git a/drivers/staging/comedi
On Sat, Aug 27, 2016 at 12:23:58AM +0300, Andrey Utkin wrote:
> On Fri, Aug 26, 2016 at 02:33:08PM -0400, Anson Jacob wrote:
> >
> > - /* Default_FS contains the full scale that is used if the user does */
> > - /* not set a full scale. */
> > + /*
>
Fix checkpatch.pl warning for
Comparisons should place the constant on the right side of the test
Remove extra space after /*
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/s626.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi
Fix checkpatch.pl warning 'line over 80 characters'
Remove extra space after /*
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/jr3_pci.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
b/drive
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 148 ++-
1 file changed, 77 insertions(+), 71 deletions(-)
diff --git a
Fix checkpatch.pl warning for 'Statements should start on a tabstop'
Convert single line block comment to single line comment
Align single line comment
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/ni_atmio.c | 11 ---
1 file changed, 4 insertions(+), 7
Fix checkpatch.pl warning 'line over 80 characters'
Remove extra space after /*
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 170 ++-
1 file changed, 89 insertions(+), 81 deletions(-)
diff --git a/drivers/staging/come
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Block comments starts with /* followed by comments on the next line
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/jr3_pci.h | 290
Remove additional space after /*
Convert single line block comment into single line comment
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 431 +--
1 file changed, 214 insertions(+), 217 deletions(-)
diff --git a/drivers/staging/comedi
single line comment
Block comments starts with /* followed by comments on the next line
Anson Jacob (7):
staging: comedi: cb_pcidas64.c: Fix checkpatch warning
staging: comedi: cb_pcidas64: Fix commenting style
staging: comedi: jr3_pci.h: Fix checkpatch warning
staging: comedi: ni_atmio.c
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fb_s6d1121.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_s6d1121.c
b/drivers/staging/fbtft/fb_s6d1121.c
index
Fix checkpatch.pl warning for
Comparisons should place the constant on the right side of the test
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/s626.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.h
b/drivers/staging
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fb_ssd1306.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/staging
Thank you for your comments.
On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote:
>
> > +#define CHANNEL_BITS(x)((x) & 0x7)
> > +#define CHANNEL_MASK 0x7
>
> No uniform alignment. Please get everything in a row.
> If it's hard or this part of driver is expected
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fb_ssd1289.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1289.c
b/drivers/staging/fbtft/fb_ssd1289.c
index
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Anson Jacob (9):
staging: fbtft: fb_s6d02a1.c: Fix checkpatch warning
staging: fbtft: fb_s6d1121.c: Fix checkpatch warning
staging: fbtft: fb_ssd1289: Fix checkpatch
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fb_s6d02a1.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fb_tls8204.c | 57 +++---
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a
Fix checkpatch.pl warning 'line over 80 characters'
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
b/drivers/staging/comedi/drivers/jr3_pci.c
ind
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fbtft_device.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fb_ssd1331.c | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c
b/drivers
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fb_st7735r.c | 43 +++---
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a
Fix checkpath.pl warning:
line over 80 characters
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Statements should start on a tabstop
Comparisons should place the constant on the right side of the test
Anson Jacob (6):
staging: comedi: cb_pcidas64.c
Fix checkpatch.pl warning 'line over 80 characters'
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 82
1 file changed, 46 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_at_a2150.c
b/drive
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/jr3_pci.h | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/fbtft/fbtft-bus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c
b
Fix checkpatch.pl warning for 'Statements should start on a tabstop'
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/ni_atmio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
b/drivers/staging/come
Fix checkpatch.pl warning
Block comments use * on subsequent lines
Signed-off-by: Anson Jacob
---
drivers/staging/emxx_udc/emxx_udc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index 3b56b28
Fix checkpatch.pl warning:
Block comments use * on subsequent lines
Block comments use a trailing */ on a separate line
Signed-off-by: Anson Jacob
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 105 ++-
1 file changed, 55 insertions(+), 50 deletions(-)
diff --git a
Fix checkpatch.pl 'line over 80 characters' warning
Signed-off-by: Anson Jacob
---
drivers/staging/android/lowmemorykiller.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/lowmemorykiller.c
b/drivers/staging/android/lowmemorykill
Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments
Signed-off-by: Anson Jacob
---
drivers/staging/vt6655/rxtx.c | 41 -
1 file changed, 24 inserti
On Mon, Aug 22, 2016 at 04:36:26PM -0400, Greg Kroah-Hartman wrote:
> On Mon, Aug 22, 2016 at 12:54:12PM -0400, Anson Jacob wrote:
> > *** BLURB HERE ***
>
> You forgot the blurb :)
>
Sorry about that. Uploaded a new patchset with blurb :)
Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments
Signed-off-by: Anson Jacob
---
drivers/staging/vt6655/rf.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments
Anson Jacob (2):
staging: vt6655: rf.c: Fix checkpatch warning
staging: vt6655: rxtx.c: Fix checkpatch warning
drivers/stagin
Fix checkpatch.pl warning for line over 80 characters
Signed-off-by: Anson Jacob
---
drivers/staging/vt6656/usbpipe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index f546553..e9b6b21 100644
--- a
Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments
Signed-off-by: Anson Jacob
---
drivers/staging/vt6655/rf.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments
Signed-off-by: Anson Jacob
---
drivers/staging/vt6655/rxtx.c | 41 -
1 file changed, 24 inserti
*** BLURB HERE ***
Anson Jacob (2):
staging: vt6655: rf.c: Fix checkpatch warning
staging: vt6655: rxtx.c: Fix checkpatch warning
drivers/staging/vt6655/rf.c | 19 ---
drivers/staging/vt6655/rxtx.c | 41 -
2 files changed, 36
fix checkpatch.pl warning
Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Anson Jacob
---
drivers/staging/lustre/lustre/include/cl_object.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lustre/in
convert spaces to tab
fix the following error messages from checkpatch.pl
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
Signed-off-by: Anson Jacob
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 +-
1 file changed, 1 insertion
fix checkpatch.pl warning about 'line over 80 characters'.
Signed-off-by: Anson Jacob
---
drivers/staging/dgnc/dgnc_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 3092abe..88d2
Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments
Signed-off-by: Anson Jacob
---
drivers/staging/vt6655/power.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --g
Fix warning by checkpatch.pl
Add * for block comments on subsequent lines
Signed-off-by: Anson Jacob
---
drivers/staging/vt6655/device_main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
better TX throughput */
Signed-off-by: Anson Jacob
---
drivers/staging/vt6655/channel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
index b7d43a5..029a8df 100644
--- a/drivers/staging/vt6655/channel.c
+++ b
64 matches
Mail list logo
