[PATCH v3 net-next] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-24 Thread Antonio Borneo
ad actual speed to detect downshift") is working fine also for this phy and it's trivial re-using it to restore the downshift detection on rtl8211f. Add the phy specific read_status() pointing to the existing function rtlgen_read_status(). Signed-off-by: Antonio Borneo Link: https://lore.kernel.org/

[PATCH] net: stmmac: fix incorrect merge of patch upstream

2020-11-24 Thread Antonio Borneo
ps. Fixes: 757926247836 ("net: stmmac: add flexible PPS to dwmac 4.10a") Cc: sta...@vger.kernel.org # v5.6+ Signed-off-by: Antonio Borneo Reported-by: Ahmad Fatoum --- To: Alexandre Torgue To: Jose Abreu To: "David S. Miller" To: Jakub Kicinski Cc: Maxime Coquelin Cc: net...@vger.ke

Re: [PATCH v2] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-24 Thread Antonio Borneo
On Tue, 2020-11-24 at 23:22 +0100, Heiner Kallweit wrote: > Am 24.11.2020 um 22:59 schrieb Antonio Borneo: > > The rtl8211f supports downshift and before commit 5502b218e001 > > ("net: phy: use phy_resolve_aneg_linkmode in genphy_read_status") > > the read-back of

[PATCH v2] net: phy: realtek: read actual speed on rtl8211f to detect downshift

2020-11-24 Thread Antonio Borneo
ad actual speed to detect downshift") is working fine also for this phy and it's trivial re-using it to restore the downshift detection on rtl8211f. Add the phy specific read_status() pointing to the existing function rtlgen_read_status(). Signed-off-by: Antonio Borneo Link: https://lore.kernel.org/

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

2020-11-24 Thread Antonio Borneo
On Tue, 2020-11-24 at 10:20 -0800, Jakub Kicinski wrote: > On Tue, 24 Nov 2020 15:23:27 +0100 Antonio Borneo wrote: > > On Tue, 2020-11-24 at 15:15 +0100, Ahmad Fatoum wrote: > > > On 10.10.19 00:26, Jakub Kicinski wrote: > > > > On Mon, 7 Oct 2019 17:43:

Re: [PATCH] net: phy: fix auto-negotiation in case of 'down-shift'

2020-11-24 Thread Antonio Borneo
On Tue, 2020-11-24 at 15:37 +, Russell King - ARM Linux admin wrote: > On Tue, Nov 24, 2020 at 04:17:42PM +0100, Antonio Borneo wrote: > > On Tue, 2020-11-24 at 14:56 +, Russell King - ARM Linux admin wrote: > > > Userspace doesn't expect the advertising mask

Re: [PATCH] net: phy: fix auto-negotiation in case of 'down-shift'

2020-11-24 Thread Antonio Borneo
On Tue, 2020-11-24 at 15:17 +, Russell King - ARM Linux admin wrote: > On Tue, Nov 24, 2020 at 04:03:40PM +0100, Heiner Kallweit wrote: > > Am 24.11.2020 um 15:38 schrieb Antonio Borneo: > > > If the auto-negotiation fails to establish a gigabit link, the phy > >

Re: [PATCH] net: phy: fix auto-negotiation in case of 'down-shift'

2020-11-24 Thread Antonio Borneo
On Tue, 2020-11-24 at 14:56 +, Russell King - ARM Linux admin wrote: > On Tue, Nov 24, 2020 at 03:38:48PM +0100, Antonio Borneo wrote: > > If the auto-negotiation fails to establish a gigabit link, the phy > > can try to 'down-shift': it resets the bits in MII_CTRL1000 to >

[PATCH] net: phy: fix auto-negotiation in case of 'down-shift'

2020-11-24 Thread Antonio Borneo
s") Cc: sta...@vger.kernel.org # v5.1+ Signed-off-by: Antonio Borneo Link: https://lore.kernel.org/r/478f871a-583d-01f1-9cc5-2eea56d8c...@huawei.com --- To: Andrew Lunn To: Heiner Kallweit To: Russell King To: "David S. Miller" To: Jakub Kicinski To: net...@vger.kernel.org To: Yo

Re: [PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

2020-11-24 Thread Antonio Borneo
On Tue, 2020-11-24 at 15:15 +0100, Ahmad Fatoum wrote: > Hello Jakub, > > On 10.10.19 00:26, Jakub Kicinski wrote: > > On Mon, 7 Oct 2019 17:43:06 +0200, Antonio Borneo wrote: > > > All the registers and the functionalities used in the callback > > > dwmac5_fle

[PATCH] drm/connector: fix minor typos in comments

2020-06-26 Thread Antonio Borneo
Some of these comments are part of the Linux GPU Driver Developer's Guide. Fix some minor typo in the comments and remove a repeated 'the'. Signed-off-by: Antonio Borneo --- drivers/gpu/drm/drm_connector.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

[PATCH v2] usbip: tools: add in man page how to load the client's module

2020-06-25 Thread Antonio Borneo
;vhci-hcd" that has no immediate assonance with usbip. Add in usbip.8 the command to add the module vhci-hcd, similarly as it's already present in usbipd.8 for usbip-host. While there, rephrase the description of the command "usbip list --remote=server". Signed-off-by: Antoni

[PATCH] usbip: tools: fix build error for multiple definition

2020-06-17 Thread Antonio Borneo
With GCC 10, building usbip triggers error for multiple definition of 'udev_context', in: - libsrc/vhci_driver.c:18 and - libsrc/usbip_host_common.c:27. Declare as extern the definition in libsrc/usbip_host_common.c. Signed-off-by: Antonio Borneo --- tools/usb/usbip/libsrc/usbip_host_common.c

[PATCH] usbip: tools: fix module name in man page

2020-06-17 Thread Antonio Borneo
Commit 64e62426f40d ("staging: usbip: edit Kconfig and rename CONFIG options") renamed the module usbip as usbip-host, but the example in the man page still reports the old module name. Fix the module name in usbipd.8 Signed-off-by: Antonio Borneo Fixes: 64e62426f40d ("stagi

[PATCH] usbip: tools: add in man page how to load the client's module

2020-06-17 Thread Antonio Borneo
;vhci-hcd" that has no immediate assonance with usbip. Add in usbip.8 the command to add the module vhci-hcd, similarly as it's already present in usbipd.8 for usbip-host. Signed-off-by: Antonio Borneo --- tools/usb/usbip/doc/usbip.8 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools

[PATCH] staging: rtl8723bs: fix typo of "mechanism" in comment

2019-10-07 Thread Antonio Borneo
Fix typo s/mechansim/mechanism/ Signed-off-by: Antonio Borneo --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c index 6e4a1fcb8790

[PATCH] net: stmmac: add flexible PPS to dwmac 4.10a

2019-10-07 Thread Antonio Borneo
QoS Databook 5.00a September 2017 Signed-off-by: Antonio Borneo --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index 2cb9c53f93b8

[PATCH] net: stmmac: fix length of PTP clock's name string

2019-10-07 Thread Antonio Borneo
t should just be 'A short "friendly name" to identify the clock'. Replace it with "stmmac ptp". Signed-off-by: Antonio Borneo Fixes: 92ba6888510c ("stmmac: add the support for PTP hw clock driver") --- drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 2 +- 1 file cha

[PATCH] net: stmmac: fix disabling flexible PPS output

2019-10-07 Thread Antonio Borneo
-by: Antonio Borneo Fixes: 9a8a02c9d46d ("net: stmmac: Add Flexible PPS support") --- drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac5.c b/drivers/net/ethernet/stmicro/stmmac/dwmac5.c index 3f

[PATCH] ptp: fix typo of "mechanism" in Kconfig help text

2019-10-07 Thread Antonio Borneo
Fix typo s/mechansim/mechanism/ Signed-off-by: Antonio Borneo --- drivers/ptp/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index 960961fb0d7c..0517272a268e 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig

Re: [PATCH v2] checkpatch: fix multiple const * types

2019-09-04 Thread Antonio Borneo
Hi Joe, can this series be queued for merge ? I just found I mess-up the mail thread references, so here are the latest versions: [1/4 V2] https://lore.kernel.org/lkml/20190508174347.13901-1-borneo.anto...@gmail.com/ [2/4] dropped [3/4]

[PATCH v5] checkpatch: add command-line option for TAB size

2019-05-09 Thread Antonio Borneo
size of 4 characters [2]). Replace the magic value 8 with a variable. Add a command-line option "--tab-size" to let the user select a TAB size value other than 8. [1] http://openocd.org/ [2] http://openocd.org/doc/doxygen/html/stylec.html#styleformat Signed-off-by: Antonio Borneo

Re: [PATCH v4] checkpatch: add command-line option for TAB size

2019-05-09 Thread Antonio Borneo
On Thu, May 9, 2019 at 10:03 AM Joe Perches wrote: > > On Thu, 2019-05-09 at 09:21 +0200, Antonio Borneo wrote: > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -2224,7 +2229,7 @@ sub string_find_replace { > > sub tabify { > > my

[PATCH v4] checkpatch: add command-line option for TAB size

2019-05-09 Thread Antonio Borneo
size of 4 characters [2]). Replace the magic value 8 with a variable. Add a command-line option "--tab-size" to let the user select a TAB size value other than 8. [1] http://openocd.org/ [2] http://openocd.org/doc/doxygen/html/stylec.html#styleformat Signed-off-by: Antonio Borneo

Re: [PATCH v2] checkpatch: add command-line option for TAB size

2019-05-08 Thread Antonio Borneo
On Wed, May 8, 2019 at 11:14 PM Elliott, Robert (Servers) wrote: ... > Checking for 0 before using the value in division and modulo > operations would be prudent. True! >From command line, $tabsize is parsed as integer so I should sort out any non-positive value. Will add a check after

[PATCH v3] checkpatch: add command-line option for TAB size

2019-05-08 Thread Antonio Borneo
size of 4 characters [2]). Replace the magic value 8 with a variable. Add a command-line option "--tab-size" to let the user select a TAB size value other than 8. [1] http://openocd.org/ [2] http://openocd.org/doc/doxygen/html/stylec.html#styleformat Signed-off-by: Antonio Borneo

Re: [PATCH v2] checkpatch: add command-line option for TAB size

2019-05-08 Thread Antonio Borneo
On Wed, May 8, 2019 at 7:56 PM Joe Perches wrote: > > On Wed, 2019-05-08 at 19:43 +0200, Antonio Borneo wrote: > > The size of 8 characters used for both TAB and indentation is > > embedded as magic value allover the checkpatch script, and this > > makes the script le

[PATCH v2] checkpatch: fix multiple const * types

2019-05-08 Thread Antonio Borneo
r 0 times) with "{0,4}" (Match no more than 4 times) in the regular expression. Fix also the similar test for types in unusual order. Signed-off-by: Antonio Borneo Fixes: 1574a29f8e76 ("checkpatch: allow multiple const * types") --- v1->v2 use a max match {0,4} i

[PATCH v2] checkpatch: add command-line option for TAB size

2019-05-08 Thread Antonio Borneo
]). [1] http://openocd.org/ [2] http://openocd.org/doc/doxygen/html/stylec.html#styleformat Signed-off-by: Antonio Borneo Signed-off-by: Erik Ahlén Signed-off-by: Spencer Oliver --- V1 -> V2 add the command line option scripts/checkpatch.pl | 23 +-- 1 file change

Re: [PATCH 4/4] checkpatch: replace magic value for TAB size

2019-05-08 Thread Antonio Borneo
On Wed, May 8, 2019 at 4:52 PM Joe Perches wrote: ... > > In these cases the script will be probably modified and adapted, > > so there is no need (at least for the moment) to expose this > > setting on the script's command line. > > Disagree. Probably getter to add a --tabsize= option now. Ok,

Re: [PATCH 1/4] checkpatch: fix multiple const * types

2019-05-08 Thread Antonio Borneo
On Wed, May 8, 2019 at 4:51 PM Joe Perches wrote: ... > It might be better to use a max match like {0,4} instead of * > > perl is pretty memory intensive at multiple unrestricted matches > of somewhat complex patterns. Agree! Will send a V2! Thanks for the review! Antonio

[PATCH 4/4] checkpatch: replace magic value for TAB size

2019-05-08 Thread Antonio Borneo
es the script will be probably modified and adapted, so there is no need (at least for the moment) to expose this setting on the script's command line. [1] http://openocd.org/ [2] http://openocd.org/doc/doxygen/html/stylec.html#styleformat Signed-off-by: Antonio Borneo Signed-off-by: Erik Ahlé

[PATCH 3/4] checkpatch: fix minor typo and mixed space+tab in indentation

2019-05-08 Thread Antonio Borneo
Fix spelling of "concatenation". Don't use tab after space in indentation. Signed-off-by: Antonio Borneo --- scripts/checkpatch.pl | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 9a247183b65c..373ad345f

[PATCH 1/4] checkpatch: fix multiple const * types

2019-05-08 Thread Antonio Borneo
or 0 times) with "*" (Match 0 or more times) in the regular expression. Fix also the similar test for types in unusual order. Signed-off-by: Antonio Borneo Fixes: 1574a29f8e76 ("checkpatch: allow multiple const * types") --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 i

[PATCH 2/4] checkpatch: add --fix for warning LINE_CONTINUATIONS

2019-05-08 Thread Antonio Borneo
The warning LINE_CONTINUATIONS does not offer a --fix. Add the trivial --fix. In case of consecutive lines with the same issue, this will fix only the first line. Signed-off-by: Antonio Borneo --- scripts/checkpatch.pl | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH V2 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-09-08 Thread Antonio Borneo
On Fri, Sep 7, 2018 at 3:15 PM Pascal PAILLET-LME wrote: > > From: pascal paillet > > The stpmic1 PMIC embeds several regulators and witches with > different capabilities. While fixing Kconfig, as Mark suggest, would you mind to fix also the typo s/witches/switches/ in the commit message?

Re: [PATCH V2 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-09-08 Thread Antonio Borneo
On Fri, Sep 7, 2018 at 3:15 PM Pascal PAILLET-LME wrote: > > From: pascal paillet > > The stpmic1 PMIC embeds several regulators and witches with > different capabilities. While fixing Kconfig, as Mark suggest, would you mind to fix also the typo s/witches/switches/ in the commit message?

[PATCH] mtd: mchp23k256: propagate return value of spi_sync()

2017-12-10 Thread Antonio Borneo
The call to spi_sync() can fail. Check the return value and propagate it. Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- To: David Woodhouse <dw...@infradead.org> To: Brian Norris <computersforpe...@gmail.com> To: Boris Brezillon <boris.brezil...@free-electrons

[PATCH] mtd: mchp23k256: propagate return value of spi_sync()

2017-12-10 Thread Antonio Borneo
The call to spi_sync() can fail. Check the return value and propagate it. Signed-off-by: Antonio Borneo --- To: David Woodhouse To: Brian Norris To: Boris Brezillon To: Marek Vasut To: Richard Weinberger To: Cyrille Pitchen To: Andrew Lunn To: Chris Packham To: Rob Herring To: linux

[PATCH V2] ttyport: trivial fix for some typo in comments

2017-09-08 Thread Antonio Borneo
Fix some minor typo spotted in comments: - s/wit ha/with a/ - s/doestroyed/destroyed/ Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- Changes: V1 -> V2 add commit message To: Greg Kroah-Hartman <gre...@linuxfoundation.org> To: Jiri Slaby <jsl...@suse.com>

[PATCH V2] ttyport: trivial fix for some typo in comments

2017-09-08 Thread Antonio Borneo
Fix some minor typo spotted in comments: - s/wit ha/with a/ - s/doestroyed/destroyed/ Signed-off-by: Antonio Borneo --- Changes: V1 -> V2 add commit message To: Greg Kroah-Hartman To: Jiri Slaby Cc: Jiri Kosina Cc: linux-kernel@vger.kernel.org --- drivers/tty/tty_port.c | 4 ++-- 1 f

[PATCH] ttyport: trivial fix for some typo in comments

2017-09-07 Thread Antonio Borneo
Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- To: Greg Kroah-Hartman <gre...@linuxfoundation.org> To: Jiri Slaby <jsl...@suse.com> Cc: Jiri Kosina <triv...@kernel.org> Cc: linux-kernel@vger.kernel.org --- drivers/tty/tty_port.c | 4 ++-- 1 file changed, 2 in

[PATCH] ttyport: trivial fix for some typo in comments

2017-09-07 Thread Antonio Borneo
Signed-off-by: Antonio Borneo --- To: Greg Kroah-Hartman To: Jiri Slaby Cc: Jiri Kosina Cc: linux-kernel@vger.kernel.org --- drivers/tty/tty_port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index 6b13719..1286f24

Re: [PATCH v5] serio: PS/2 gpio bit banging driver for serio bus

2017-08-03 Thread Antonio Borneo
Hi Danilo, just two minor issues below On Thu, Aug 3, 2017 at 5:43 PM, Danilo Krummrich wrote: > This driver provides PS/2 serio bus support by implementing bit banging > with the GPIO API. The GPIO pins, data and clock, can be configured with > a node in the

Re: [PATCH v5] serio: PS/2 gpio bit banging driver for serio bus

2017-08-03 Thread Antonio Borneo
Hi Danilo, just two minor issues below On Thu, Aug 3, 2017 at 5:43 PM, Danilo Krummrich wrote: > This driver provides PS/2 serio bus support by implementing bit banging > with the GPIO API. The GPIO pins, data and clock, can be configured with > a node in the device tree or by generic device

[PATCH v2 1/3] dmaengine: k3dma: fix non-cyclic mode

2017-08-01 Thread Antonio Borneo
dma on SPI, the issue popped out. The fix re-applies the initialization to ds_run/ds_done in k3_dma_start_txd() that were removed by the commit above. Also, one of the calls to k3_dma_start_txd() is triggered by (ds_done != NULL), so remove the noisy and useless call to WARN_ON_ONCE(). Signed-off-by: Anto

[PATCH v2 1/3] dmaengine: k3dma: fix non-cyclic mode

2017-08-01 Thread Antonio Borneo
dma on SPI, the issue popped out. The fix re-applies the initialization to ds_run/ds_done in k3_dma_start_txd() that were removed by the commit above. Also, one of the calls to k3_dma_start_txd() is triggered by (ds_done != NULL), so remove the noisy and useless call to WARN_ON_ONCE(). Signed-off-by: Anto

[PATCH v2 3/3] dmaengine: k3dma: remove useless ON_WARN_ONCE()

2017-08-01 Thread Antonio Borneo
descriptor the behaviour of ds_run/ds_done is properly fixed. The remaining ON_WARN_ONCE() are never triggered and can be removed. Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- To: dmaeng...@vger.kernel.org To: Vinod Koul <vinod.k...@intel.com> To: Dan Williams <dan

[PATCH v2 3/3] dmaengine: k3dma: remove useless ON_WARN_ONCE()

2017-08-01 Thread Antonio Borneo
descriptor the behaviour of ds_run/ds_done is properly fixed. The remaining ON_WARN_ONCE() are never triggered and can be removed. Signed-off-by: Antonio Borneo --- To: dmaeng...@vger.kernel.org To: Vinod Koul To: Dan Williams Cc: linux-kernel@vger.kernel.org Cc: John Stultz Cc: Zhangfei Gao --

[PATCH v2 0/3] dmaengine: k3dma: Fix non-cyclic mode

2017-08-01 Thread Antonio Borneo
ouble free introduced in the same commit - cosmetic removal of useless ON_WARN_ONCE() Thread in https://patchwork.kernel.org/patch/9833791/ v1 -> v2 - split the patch - change patch title to "dmaengine: ..." Antonio Borneo (3): dmaengine: k3dma: fix non-cyclic mode dmaengine:

[PATCH v2 2/3] dmaengine: k3dma: fix double free of descriptor

2017-08-01 Thread Antonio Borneo
as a flag: when not NULL it signals that the descriptor has been consumed. No need to free it because it would be free by vchan_complete(). The fix takes back the code changed by the commit above: - remove the free on the descriptor; - initialize ds_done to NULL for the next run. Signed-off-b

[PATCH v2 2/3] dmaengine: k3dma: fix double free of descriptor

2017-08-01 Thread Antonio Borneo
as a flag: when not NULL it signals that the descriptor has been consumed. No need to free it because it would be free by vchan_complete(). The fix takes back the code changed by the commit above: - remove the free on the descriptor; - initialize ds_done to NULL for the next run. Signed-off-b

[PATCH v2 0/3] dmaengine: k3dma: Fix non-cyclic mode

2017-08-01 Thread Antonio Borneo
ouble free introduced in the same commit - cosmetic removal of useless ON_WARN_ONCE() Thread in https://patchwork.kernel.org/patch/9833791/ v1 -> v2 - split the patch - change patch title to "dmaengine: ..." Antonio Borneo (3): dmaengine: k3dma: fix non-cyclic mode dmaengine:

Re: [PATCH v2 0/3] ASoC: fix unbalanced of_node_get()/of_node_put()

2017-07-30 Thread Antonio Borneo
On Fri, Jul 28, 2017 at 12:07 PM, Mark Brown <broo...@kernel.org> wrote: > On Fri, Jul 28, 2017 at 01:26:09AM +0200, Antonio Borneo wrote: >> From: Antonio Borneo <borneo.anto...@gmail.com> >> >> On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers sever

Re: [PATCH v2 0/3] ASoC: fix unbalanced of_node_get()/of_node_put()

2017-07-30 Thread Antonio Borneo
On Fri, Jul 28, 2017 at 12:07 PM, Mark Brown wrote: > On Fri, Jul 28, 2017 at 01:26:09AM +0200, Antonio Borneo wrote: >> From: Antonio Borneo >> >> On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several >> errors at kernel boot, like >> OF: ERR

Re: device property: Fix usecount for of_graph_get_port_parent()

2017-07-30 Thread Antonio Borneo
card-utils.c > @@ -263,6 +263,9 @@ static int asoc_simple_card_get_dai_id(struct device_node > *ep) > id = i; > i++; > } > + > + of_node_put(node); > + > if (id < 0) > return -ENODEV; > > @@ -282,11 +285,6 @@ int asoc_simple_card_parse_graph_dai(struct device_node > *ep, > if (!dai_name) > return 0; > > - /* > -* of_graph_get_port_parent() will call > -* of_node_put(). So, call of_node_get() here > -*/ > - of_node_get(ep); > node = of_graph_get_port_parent(ep); > > /* Get dai->name */ > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -4113,6 +4113,8 @@ int snd_soc_get_dai_id(struct device_node *ep) > } > mutex_unlock(_mutex); > > + of_node_put(node); > + > return ret; > } > EXPORT_SYMBOL_GPL(snd_soc_get_dai_id); Tested on Hikey board, and it fixes the issue reported in https://patchwork.kernel.org/patch/9863961/ but I cannot test the part regarding audio-graph-scu-card Tested-by: Antonio Borneo <borneo.anto...@gmail.com>

Re: device property: Fix usecount for of_graph_get_port_parent()

2017-07-30 Thread Antonio Borneo
soc/generic/simple-card-utils.c > +++ b/sound/soc/generic/simple-card-utils.c > @@ -263,6 +263,9 @@ static int asoc_simple_card_get_dai_id(struct device_node > *ep) > id = i; > i++; > } > + > + of_node_put(node); > + > if (id < 0) > return -ENODEV; > > @@ -282,11 +285,6 @@ int asoc_simple_card_parse_graph_dai(struct device_node > *ep, > if (!dai_name) > return 0; > > - /* > -* of_graph_get_port_parent() will call > -* of_node_put(). So, call of_node_get() here > -*/ > - of_node_get(ep); > node = of_graph_get_port_parent(ep); > > /* Get dai->name */ > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -4113,6 +4113,8 @@ int snd_soc_get_dai_id(struct device_node *ep) > } > mutex_unlock(_mutex); > > + of_node_put(node); > + > return ret; > } > EXPORT_SYMBOL_GPL(snd_soc_get_dai_id); Tested on Hikey board, and it fixes the issue reported in https://patchwork.kernel.org/patch/9863961/ but I cannot test the part regarding audio-graph-scu-card Tested-by: Antonio Borneo

[PATCH v2 0/3] ASoC: fix unbalanced of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo <borneo.anto...@gmail.com> On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0 OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0/endpoint each fo

[PATCH v2 0/3] ASoC: fix unbalanced of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0 OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0/endpoint each followed by stack dump. Fixed

[PATCH v2 3/3] ASoC: simple-card-utils: fix unbalanced of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo <borneo.anto...@gmail.com> On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like the following one OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0/endpoint each followed by stack dump. of_graph_get_port_parent()

[PATCH v2 3/3] ASoC: simple-card-utils: fix unbalanced of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like the following one OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0/endpoint each followed by stack dump. of_graph_get_port_parent() walks through the parents looking

[PATCH v2 2/3] ASoC: soc-core: fix unbalanced of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo <borneo.anto...@gmail.com> On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like the following one OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0/endpoint each followed by stack dump. of_graph_get_port_parent()

[PATCH v2 1/3] ASoC: fix use of of_node_put() in of_for_each_phandle() loops

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo <borneo.anto...@gmail.com> On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like the following one OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0 each followed by stack dump. Each iteration of of_for_each_p

[PATCH v2 2/3] ASoC: soc-core: fix unbalanced of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like the following one OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0/endpoint each followed by stack dump. of_graph_get_port_parent() walks through the parents looking

[PATCH v2 1/3] ASoC: fix use of of_node_put() in of_for_each_phandle() loops

2017-07-27 Thread Antonio Borneo
From: Antonio Borneo On Hikey target board, enabling CONFIG_OF_DYNAMIC triggers several errors at kernel boot, like the following one OF: ERROR: Bad of_node_put() on /soc/i2s@f7118000/ports/port@0 each followed by stack dump. Each iteration of of_for_each_phandle(){} already provides the needed

Re: [PATCH] ASoC: fix balance of of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
Hi Mark, thanks for the review. On Wed, Jul 26, 2017 at 1:37 PM, Mark Brown <broo...@kernel.org> wrote: > On Tue, Jul 25, 2017 at 11:49:52PM +0200, Antonio Borneo wrote: > >> Fixed by: >> - removing of_node_put() in the body of of_for_each_phandle(){}, >>

Re: [PATCH] ASoC: fix balance of of_node_get()/of_node_put()

2017-07-27 Thread Antonio Borneo
Hi Mark, thanks for the review. On Wed, Jul 26, 2017 at 1:37 PM, Mark Brown wrote: > On Tue, Jul 25, 2017 at 11:49:52PM +0200, Antonio Borneo wrote: > >> Fixed by: >> - removing of_node_put() in the body of of_for_each_phandle(){}, >> since already provided at each i

[PATCH] ASoC: fix balance of of_node_get()/of_node_put()

2017-07-25 Thread Antonio Borneo
branch dev/hikey-mainline-WIP Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- To: Liam Girdwood <lgirdw...@gmail.com> To: Mark Brown <broo...@kernel.org> To: Jaroslav Kysela <pe...@perex.cz> To: Takashi Iwai <ti...@suse.com> To: alsa-de...@alsa-project.org Cc

[PATCH] ASoC: fix balance of of_node_get()/of_node_put()

2017-07-25 Thread Antonio Borneo
branch dev/hikey-mainline-WIP Signed-off-by: Antonio Borneo --- To: Liam Girdwood To: Mark Brown To: Jaroslav Kysela To: Takashi Iwai To: alsa-de...@alsa-project.org Cc: linux-kernel@vger.kernel.org Cc: Wei Xu Cc: John Stultz Cc: linux-arm-ker...@lists.infradead.org --- sound/soc/generic/audio

Re: [PATCH] dma: k3dma: Fix non-cyclic mode

2017-07-19 Thread Antonio Borneo
On Wed, Jul 19, 2017 at 5:47 AM, Vinod Koul <vinod.k...@intel.com> wrote: > On Wed, Jul 19, 2017 at 12:29:55AM +0200, Antonio Borneo wrote: >> On Tue, Jul 18, 2017 at 5:58 PM, Vinod Koul <vinod.k...@intel.com> wrote: >> > On Mon, Jul 10, 2017 at 01:53:43PM -0700,

Re: [PATCH] dma: k3dma: Fix non-cyclic mode

2017-07-19 Thread Antonio Borneo
On Wed, Jul 19, 2017 at 5:47 AM, Vinod Koul wrote: > On Wed, Jul 19, 2017 at 12:29:55AM +0200, Antonio Borneo wrote: >> On Tue, Jul 18, 2017 at 5:58 PM, Vinod Koul wrote: >> > On Mon, Jul 10, 2017 at 01:53:43PM -0700, John Stultz wrote: >> >> From: Anto

Re: [PATCH] dma: k3dma: Fix non-cyclic mode

2017-07-18 Thread Antonio Borneo
On Tue, Jul 18, 2017 at 5:58 PM, Vinod Koul <vinod.k...@intel.com> wrote: > On Mon, Jul 10, 2017 at 01:53:43PM -0700, John Stultz wrote: >> From: Antonio Borneo <borneo.anto...@gmail.com> >> >> Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma:

Re: [PATCH] dma: k3dma: Fix non-cyclic mode

2017-07-18 Thread Antonio Borneo
On Tue, Jul 18, 2017 at 5:58 PM, Vinod Koul wrote: > On Mon, Jul 10, 2017 at 01:53:43PM -0700, John Stultz wrote: >> From: Antonio Borneo >> >> Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma: Fix >> memory handling in preparation for cyclic mode&qu

Re: [PATCH] arm64: dts: hi6220: enable DMA in spi0

2017-03-21 Thread Antonio Borneo
On Tue, Mar 21, 2017 at 8:08 AM, Guodong Xu <guodong...@linaro.org> wrote: > From: Wang Xiaoyin <hw.wangxiao...@hisilicon.com> > > Enable DMA in spi0. Hi Guodong, Xiaoyin, added linux-spi in copy. Actually the patch does not enable the DMA. The commit message is not co

Re: [PATCH] arm64: dts: hi6220: enable DMA in spi0

2017-03-21 Thread Antonio Borneo
On Tue, Mar 21, 2017 at 8:08 AM, Guodong Xu wrote: > From: Wang Xiaoyin > > Enable DMA in spi0. Hi Guodong, Xiaoyin, added linux-spi in copy. Actually the patch does not enable the DMA. The commit message is not correct. > Cc: Antonio Borneo > Signed-off-by: Zhong Kaihu

[PATCH] spi: pl022: Document property values

2017-03-20 Thread Antonio Borneo
The property "pl022,com-mode" can only assume one of the values of the enum ssp_mode, defined in include/linux/amba/pl022.h List the possible numeric values and report the associated meaning. Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- To: Mark Brown <broo...@

[PATCH] spi: pl022: Document property values

2017-03-20 Thread Antonio Borneo
The property "pl022,com-mode" can only assume one of the values of the enum ssp_mode, defined in include/linux/amba/pl022.h List the possible numeric values and report the associated meaning. Signed-off-by: Antonio Borneo --- To: Mark Brown To: Rob Herring To: Mark Rutland

[PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties

2017-03-20 Thread Antonio Borneo
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are not documented in DT binding and don't exist in the driver code. They have no effect and can be removed. Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- Cc: Mark Brown <broo...@kern

[PATCH 2/4] ARM: SPEAr: DT: Remove nonexistent properties

2017-03-20 Thread Antonio Borneo
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are not documented in DT binding and don't exist in the driver code. They have no effect and can be removed. Signed-off-by: Antonio Borneo --- Cc: Mark Brown Cc: Rob Herring Cc: Mark Rutland To: Viresh Kumar T

[PATCH 3/4] arm64: dts: amd: Remove nonexistent property

2017-03-20 Thread Antonio Borneo
The property "pl022,hierarchy" is not documented in DT binding and doesn't exist in the driver code. It has no effect and can be removed. Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- Cc: Mark Brown <broo...@kernel.org> Cc: Rob Herring <robh...@ker

[PATCH 4/4] arm64: dts: NS2: Remove nonexistent properties

2017-03-20 Thread Antonio Borneo
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are not documented in DT binding and don't exist in the driver code. They have no effect and can be removed. Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- Cc: Mark Brown <broo...@kern

[PATCH 3/4] arm64: dts: amd: Remove nonexistent property

2017-03-20 Thread Antonio Borneo
The property "pl022,hierarchy" is not documented in DT binding and doesn't exist in the driver code. It has no effect and can be removed. Signed-off-by: Antonio Borneo --- Cc: Mark Brown Cc: Rob Herring Cc: Mark Rutland Cc: Viresh Kumar Cc: Shiraz Hashim Cc: Russell King To: Bri

[PATCH 4/4] arm64: dts: NS2: Remove nonexistent properties

2017-03-20 Thread Antonio Borneo
The properties "pl022,hierarchy" and "pl022,slave-tx-disable" are not documented in DT binding and don't exist in the driver code. They have no effect and can be removed. Signed-off-by: Antonio Borneo --- Cc: Mark Brown Cc: Rob Herring Cc: Mark Rutland Cc: Viresh Kumar C

[PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example

2017-03-20 Thread Antonio Borneo
he end of the file. [1] https://lkml.org/lkml/2012/7/9/421 [2] https://lkml.org/lkml/2012/8/21/427 [3] https://lkml.org/lkml/2012/8/21/436 Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> --- To: Mark Brown <broo...@kernel.org> To: Rob Herring <robh...@kernel.org> To: Mark

[PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example

2017-03-20 Thread Antonio Borneo
he end of the file. [1] https://lkml.org/lkml/2012/7/9/421 [2] https://lkml.org/lkml/2012/8/21/427 [3] https://lkml.org/lkml/2012/8/21/436 Signed-off-by: Antonio Borneo --- To: Mark Brown To: Rob Herring To: Mark Rutland Cc: Viresh Kumar Cc: Shiraz Hashim Cc: Russell King Cc: Brijesh Singh Cc:

Re: [PATCH RFC] HID: cp2112: add IRQ chip handling

2016-11-26 Thread Antonio Borneo
On Mon, Nov 21, 2016 at 12:07 PM, Benjamin Tissoires wrote: > The GPIO part doesn't provide interrupts when GPIO are toggled. > So use a polling mechanism if someone requests a GPIO as an IRQ. > > Signed-off-by: Benjamin Tissoires >

Re: [PATCH RFC] HID: cp2112: add IRQ chip handling

2016-11-26 Thread Antonio Borneo
On Mon, Nov 21, 2016 at 12:07 PM, Benjamin Tissoires wrote: > The GPIO part doesn't provide interrupts when GPIO are toggled. > So use a polling mechanism if someone requests a GPIO as an IRQ. > > Signed-off-by: Benjamin Tissoires > --- > > I am currently running this patch in my local tree. >

[PATCH] Documentation: arm: fix location of the alignment trap interface

2016-07-01 Thread Antonio Borneo
Commit 1ada1441e73a0f51296bfae527acbeae61ff0d52 ("[ARM] 5348/1: fix documentation wrt location of the alignment trap interface") left one location incorrect. Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com> To: Jonathan Corbet <cor...@lwn.net> To: linux-...@vger.

[PATCH] Documentation: arm: fix location of the alignment trap interface

2016-07-01 Thread Antonio Borneo
Commit 1ada1441e73a0f51296bfae527acbeae61ff0d52 ("[ARM] 5348/1: fix documentation wrt location of the alignment trap interface") left one location incorrect. Signed-off-by: Antonio Borneo To: Jonathan Corbet To: linux-...@vger.kernel.org Cc: Nicolas Pitre Cc: Russell King Cc: li

Re: [PATCH] HID: cp2112: fix to force single data-report reply

2015-07-11 Thread Antonio Borneo
On Wed, Jul 8, 2015 at 6:41 PM, Jiri Kosina wrote: > On Wed, 8 Jul 2015, Ellen Wang wrote: > >> > > Works as described. Thank you! >> > > >> > > By the way, I tested the code with and without your fix on my rev 2 chip, >> > > and >> > > it behaved the same way as you describe on your rev 1 chip.

Re: [PATCH] HID: cp2112: fix to force single data-report reply

2015-07-11 Thread Antonio Borneo
On Wed, Jul 8, 2015 at 6:41 PM, Jiri Kosina jkos...@suse.com wrote: On Wed, 8 Jul 2015, Ellen Wang wrote: Works as described. Thank you! By the way, I tested the code with and without your fix on my rev 2 chip, and it behaved the same way as you describe on your rev 1 chip.

Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA

2015-06-27 Thread Antonio Borneo
On Fri, Jun 26, 2015 at 9:21 PM, Sergei Shtylyov wrote: > Hello. > > On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote: > >> If NO_DMA=y: > > >> ERROR: "dma_sync_single_for_cpu" >> [drivers/net/ethernet/via/via-rhine.ko] undefined! >> ERROR: "dma_set_mask"

Re: [PATCH] net: via: VIA_RHINE and VIA_VELOCITY should depend on HAS_DMA

2015-06-27 Thread Antonio Borneo
On Fri, Jun 26, 2015 at 9:21 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 6/26/2015 3:08 PM, Geert Uytterhoeven wrote: If NO_DMA=y: ERROR: dma_sync_single_for_cpu [drivers/net/ethernet/via/via-rhine.ko] undefined! ERROR: dma_set_mask

[PATCH 5/6] wireless: cw1200: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Solomon Peachy To: Kalle Valo To: linux-wirel...@vger.kernel.org

[PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Alan Ott To: Alexander Aring To: Varka Bhadram To: linux-w

[PATCH 3/6] staging: mt29f_spinand: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Greg Kroah-Hartman To: de...@driverdev.osuosl.org Cc: linux-kernel

[PATCH 6/6] [media] s5c73m3: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Mauro Carvalho Chehab To: Kyungmin Park To: Andrzej Hajda

[PATCH 2/6] iio: ssp_sensors: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Jonathan Cameron To: Lars-Peter Clausen To: Karol Wrona To: linux

[PATCH 1/6] ASoC: wm0010: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Jaroslav Kysela To: Takashi Iwai To: Liam Girdwood To: Mark Brown

[PATCH 0/6] Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
message from Lars-Peter; only minor reformat to stay in 75 char/line and fix the name of spi_register_driver(). Regards, Antonio Antonio Borneo (6): ASoC: wm0010: Remove redundant spi driver bus initialization iio: ssp_sensors: Remove redundant spi driver bus initialization staging

  1   2   >