Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code match

On 12/14/2017 04:48 PM, Mauro Carvalho Chehab wrote: Em Tue, 19 Sep 2017 13:13:52 +0100 Nigel Kettlewell escreveu: [re-sending as plain text] Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. Using firmware v4.0.11 the 292e would

Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code match

On 12/14/2017 04:48 PM, Mauro Carvalho Chehab wrote: Em Tue, 19 Sep 2017 13:13:52 +0100 Nigel Kettlewell escreveu: [re-sending as plain text] Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. Using firmware v4.0.11 the 292e would work once and then hang on

Re: [media-af9013] question about return value in function af9013_wr_regs()

Gustavo A. R. Silva kirjoitti 2017-06-09 00:51: Hello everybody, While looking into Coverity ID 1227035 I ran into the following piece of code at drivers/media/dvb-frontends/af9013.c:595: The issue here is that the value stored in variable _ret_ at line 608, is not being evaluated as it

Re: [media-af9013] question about return value in function af9013_wr_regs()

Gustavo A. R. Silva kirjoitti 2017-06-09 00:51: Hello everybody, While looking into Coverity ID 1227035 I ran into the following piece of code at drivers/media/dvb-frontends/af9013.c:595: The issue here is that the value stored in variable _ret_ at line 608, is not being evaluated as it

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 05/15/2017 11:28 PM, Andreas Kemnade wrote: Hi, On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari <cr...@iki.fi> wrote: On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si2

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 05/15/2017 11:28 PM, Andreas Kemnade wrote: Hi, On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari wrote: On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si268 got the command 0101

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si268 got the command 0101. It still accepts commands but the answer is just ff. So read the chip id before that so the information is

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si268 got the command 0101. It still accepts commands but the answer is just ff. So read the chip id before that so the information is

Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

On 03/03/2017 08:35 PM, Brüns, Stefan wrote: On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote: The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and dvbsky driver are

Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

On 03/03/2017 08:35 PM, Brüns, Stefan wrote: On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote: The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and dvbsky driver are

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

On 02/16/2017 10:48 AM, Antti Palosaari wrote: On 02/16/2017 01:31 AM, Stefan Bruens wrote: +/* attach demod */ +memset(_config, 0, sizeof(si2168_config)); prefer sizeof dst You mean sizeof(struct si2168_config) ? yeah. See chapter 14 from kernel coding style documentation

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

On 02/16/2017 10:48 AM, Antti Palosaari wrote: On 02/16/2017 01:31 AM, Stefan Bruens wrote: +/* attach demod */ +memset(_config, 0, sizeof(si2168_config)); prefer sizeof dst You mean sizeof(struct si2168_config) ? yeah. See chapter 14 from kernel coding style documentation

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

coding style. Old code could be bad, but imho you could make new code better even it makes existing diver coding style slightly inconsistent. On Mittwoch, 15. Februar 2017 10:27:09 CET Antti Palosaari wrote: On 02/15/2017 03:51 AM, Stefan Brüns wrote: [...] diff --git a/drivers/media/usb/dvb

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

coding style. Old code could be bad, but imho you could make new code better even it makes existing diver coding style slightly inconsistent. On Mittwoch, 15. Februar 2017 10:27:09 CET Antti Palosaari wrote: On 02/15/2017 03:51 AM, Stefan Brüns wrote: [...] diff --git a/drivers/media/usb/dvb

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

On 02/15/2017 03:51 AM, Stefan Brüns wrote: Mygica T230 DVB-T/T2/C USB stick support. It uses the same FX2/Si2168 bridge/demodulator combo as the other devices supported by the driver, but uses the Si2141 tuner. Several DVB-T (MPEG2) and DVB-T2 (H.265) channels were tested, as well as the

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

On 02/15/2017 03:51 AM, Stefan Brüns wrote: Mygica T230 DVB-T/T2/C USB stick support. It uses the same FX2/Si2168 bridge/demodulator combo as the other devices supported by the driver, but uses the Si2141 tuner. Several DVB-T (MPEG2) and DVB-T2 (H.265) channels were tested, as well as the

Re: [PATCH 0/3] Add support for MyGica T230C DVB-T2 stick

On 02/12/2017 05:26 PM, Stefan Brüns wrote: The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and cxusb driver are mostly addition of the required IDs and some glue code.

Re: [PATCH 0/3] Add support for MyGica T230C DVB-T2 stick

On 02/12/2017 05:26 PM, Stefan Brüns wrote: The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and cxusb driver are mostly addition of the required IDs and some glue code.

Re: How should I use kernel-defined i2c structs in this driver

On 05/26/2016 04:59 PM, Andrey Utkin wrote: Could anybody please give a hint - which kernel-defined i2c objects, and how many of them, I need to define and use to substitute these driver-defined functions i2c_read(), i2c_write() ?

Re: How should I use kernel-defined i2c structs in this driver

On 05/26/2016 04:59 PM, Andrey Utkin wrote: Could anybody please give a hint - which kernel-defined i2c objects, and how many of them, I need to define and use to substitute these driver-defined functions i2c_read(), i2c_write() ?

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

On 04/29/2016 12:16 PM, Peter Rosin wrote: On 2016-04-29 09:16, Wolfram Sang wrote: Yes, obviously... I'll make that change locally and wait for the rest. Another nit: You could use '--strict' with checkpatch and see if you want to fix the issues reported. I am not keen on those (except for

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

On 04/29/2016 12:16 PM, Peter Rosin wrote: On 2016-04-29 09:16, Wolfram Sang wrote: Yes, obviously... I'll make that change locally and wait for the rest. Another nit: You could use '--strict' with checkpatch and see if you want to fix the issues reported. I am not keen on those (except for

Re: [PATCH v7 00/24] i2c mux cleanup and locking update

On 04/20/2016 06:17 PM, Peter Rosin wrote: Retested all the previously tested + now I tested also cx231xx with Hauppauge 930C HD device having eeprom other mux port and demod on the other port. [media] si2168: change the i2c gate to be mux-locked [media] m88ds3103: convert to use an

Re: [PATCH v7 00/24] i2c mux cleanup and locking update

On 04/20/2016 06:17 PM, Peter Rosin wrote: Retested all the previously tested + now I tested also cx231xx with Hauppauge 930C HD device having eeprom other mux port and demod on the other port. [media] si2168: change the i2c gate to be mux-locked [media] m88ds3103: convert to use an

Re: [PATCH v4 00/18] i2c mux cleanup and locking update

lare that the i2c gate is self-locked b52f766 [media] si2168: convert to use an explicit i2c mux core 4ba9115 [media] rtl2832: convert to use an explicit i2c mux core 3f1778b [media] rtl2830: convert to use an explicit i2c mux core 5c8bfc8 [media] m88ds3103: convert to use an explicit i2c mux core Re

Re: [PATCH v4 00/18] i2c mux cleanup and locking update

lare that the i2c gate is self-locked b52f766 [media] si2168: convert to use an explicit i2c mux core 4ba9115 [media] rtl2832: convert to use an explicit i2c mux core 3f1778b [media] rtl2830: convert to use an explicit i2c mux core 5c8bfc8 [media] m88ds3103: convert to use an explicit i2c mux core

Re: m88ds3103: Undefined division

On 02/19/2016 12:10 PM, Peter Rosin wrote: Hi! I'm looking at this code in drivers/media/dvb-frontends/m88ds3103.c in the m88ds3103_set_frontend() function, line 600 (give or take): s32tmp = 0x1 * (tuner_frequency - c->frequency); s32tmp = DIV_ROUND_CLOSEST(s32tmp,

Re: m88ds3103: Undefined division

On 02/19/2016 12:10 PM, Peter Rosin wrote: Hi! I'm looking at this code in drivers/media/dvb-frontends/m88ds3103.c in the m88ds3103_set_frontend() function, line 600 (give or take): s32tmp = 0x1 * (tuner_frequency - c->frequency); s32tmp = DIV_ROUND_CLOSEST(s32tmp,

Re: [PATCH v2 0/8] i2c mux cleanup and locking update

On 01/05/2016 05:57 PM, Peter Rosin wrote: From: Peter Rosin Hi! I have a pair of boards with this i2c topology: GPIO ---| -- BAT1 | v / I2C -+--B---+ MUX | \ EEPROM

Re: [PATCH v2 0/8] i2c mux cleanup and locking update

On 01/05/2016 05:57 PM, Peter Rosin wrote: From: Peter Rosin Hi! I have a pair of boards with this i2c topology: GPIO ---| -- BAT1 | v / I2C -+--B---+ MUX | \

Re: [PATCH] [media] hackrf: don't emit dev debug on a kfree'd or null dev

On 11/11/2015 05:05 PM, Colin King wrote: From: Colin Ian King Static analysis with smatch detected a couple of issues: drivers/media/usb/hackrf/hackrf.c:1533 hackrf_probe() error: we previously assumed 'dev' could be null (see line 1366) drivers/media/usb/hackrf/hackrf.c:1533

Re: [PATCH] [media] hackrf: don't emit dev debug on a kfree'd or null dev

On 11/11/2015 05:05 PM, Colin King wrote: From: Colin Ian King Static analysis with smatch detected a couple of issues: drivers/media/usb/hackrf/hackrf.c:1533 hackrf_probe() error: we previously assumed 'dev' could be null (see line 1366)

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

On 06/03/2015 07:37 PM, David Howells wrote: Malcolm Priestley wrote: Yes, also, the workqueue appears not to be initialized when using the dvb attached method. I'm not sure what you're referring to. It's initialised in ts2020_probe() just after the ts2020_priv struct is allocated - the

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

On 05/28/2015 11:07 PM, Malcolm Priestley wrote: On 28/05/15 11:08, David Howells wrote: Malcolm Priestley wrote: Statistics polling can not be done by lmedm04 driver's implementation of M88RS2000/TS2020 because I2C messages stop the devices demuxer. I did make tests (using that same

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

On 05/28/2015 11:07 PM, Malcolm Priestley wrote: On 28/05/15 11:08, David Howells wrote: Malcolm Priestley tvbox...@gmail.com wrote: Statistics polling can not be done by lmedm04 driver's implementation of M88RS2000/TS2020 because I2C messages stop the devices demuxer. I did make tests

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

On 06/03/2015 07:37 PM, David Howells wrote: Malcolm Priestley tvbox...@gmail.com wrote: Yes, also, the workqueue appears not to be initialized when using the dvb attached method. I'm not sure what you're referring to. It's initialised in ts2020_probe() just after the ts2020_priv struct is

Re: [PATCH] m88ts2022: Nested loops shouldn't use the same index variable

On 03/20/2015 03:37 PM, David Howells wrote: There are a pair of nested loops inside m88ts2022_cmd() that use the same index variable, but for different things. Split the variable. Signed-off-by: David Howells Reviewed-by: Antti Palosaari regards Antti --- drivers/media/tuners

Re: [PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

On 03/20/2015 01:14 PM, Javi Merino wrote: Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: Antti Palosaari Cc: Mauro Carvalho Chehab Signed-off-by: Javi Merino Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari

Re: [PATCH 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

On 03/20/2015 01:14 PM, Javi Merino wrote: Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab mche...@osg.samsung.com Signed-off-by: Javi Merino javi.mer...@arm.com Acked

Re: [PATCH] m88ts2022: Nested loops shouldn't use the same index variable

On 03/20/2015 03:37 PM, David Howells wrote: There are a pair of nested loops inside m88ts2022_cmd() that use the same index variable, but for different things. Split the variable. Signed-off-by: David Howells dhowe...@redhat.com Reviewed-by: Antti Palosaari cr...@iki.fi regards Antti

Re: [PATCH] si2168: tda10071: m88ds3103: Fix trivial typos

On 02/26/2015 12:13 PM, Yannick Guerrini wrote: Change 'firmare' to 'firmware' Signed-off-by: Yannick Guerrini Acked-by: Antti Palosaari Antti --- drivers/media/dvb-frontends/m88ds3103.c | 2 +- drivers/media/dvb-frontends/si2168_priv.h | 2 +- drivers/media/dvb-frontends

Re: [PATCH] si2168: tda10071: m88ds3103: Fix trivial typos

On 02/26/2015 12:13 PM, Yannick Guerrini wrote: Change 'firmare' to 'firmware' Signed-off-by: Yannick Guerrini yguerr...@tomshardware.fr Acked-by: Antti Palosaari cr...@iki.fi Antti --- drivers/media/dvb-frontends/m88ds3103.c | 2 +- drivers/media/dvb-frontends/si2168_priv.h | 2

Re: [PATCH v2] rtl2832: remove compiler warning

to err. It is still nice to avoid compiler warnings. Signed-off-by: Luis de Bethencourt Reviewed-by: Antti Palosaari Antti --- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media

Re: [PATCH v2] rtl2832: remove compiler warning

to err. It is still nice to avoid compiler warnings. Signed-off-by: Luis de Bethencourt luis...@samsung.com Reviewed-by: Antti Palosaari cr...@iki.fi Antti --- drivers/media/dvb-frontends/rtl2832.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb

Re: [PATCH] rtl2832: remove compiler warning

On 02/09/2015 12:44 AM, Luis de Bethencourt wrote: Cleaning the following compiler warning: rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set tmp, this line would never run because we go to

Re: [PATCH] rtl2832: remove compiler warning

On 02/09/2015 12:44 AM, Luis de Bethencourt wrote: Cleaning the following compiler warning: rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set tmp, this line would never run because we go to

Re: [PATCH] media:dvb-frontends: Change setting of variable interval to the correct values in the function, hd29l2_get_frontend for the switch statement checking the frame header

Yet another bad patch. Do not touch whole driver unless you understand and can test your patches! Antti On 02/03/2015 05:52 AM, Nicholas Krause wrote: This changes the switch statement checking the frame header of the pointer, c as a pointer to a structure of type,dtv_frontend_properties to

Re: [PATCH] media:dvb-frontends: Change setting of variable interval to the correct values in the function, hd29l2_get_frontend for the switch statement checking the frame header

Yet another bad patch. Do not touch whole driver unless you understand and can test your patches! Antti On 02/03/2015 05:52 AM, Nicholas Krause wrote: This changes the switch statement checking the frame header of the pointer, c as a pointer to a structure of type,dtv_frontend_properties to

Re: [PATCH] media:dvb-frontends:Change setting of dtv_frontend_properties modulation to the correct value in the function,hd29l2_get_frontend

Moikka! That patch is not correct and will not even compile. Problem is that QAM_4NR and QAM_4 are not defined (OK, QPSK is QAM-4). regards Antti On 02/02/2015 04:34 PM, Nicholas Krause wrote: Changes the values in the switch statement of the function,d29l2_get_frontend to use the proper

Re: [PATCH] media:dvb-frontends:Change setting of dtv_frontend_properties modulation to the correct value in the function,hd29l2_get_frontend

Moikka! That patch is not correct and will not even compile. Problem is that QAM_4NR and QAM_4 are not defined (OK, QPSK is QAM-4). regards Antti On 02/02/2015 04:34 PM, Nicholas Krause wrote: Changes the values in the switch statement of the function,d29l2_get_frontend to use the proper

Re: [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/

On 10/02/2014 07:45 PM, Joe Perches wrote: On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote: Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall escreveu: Fixed various coding style issues, including strings over 80 characters long and many deprecated printk's have been replaced

Re: [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/

On 10/02/2014 07:45 PM, Joe Perches wrote: On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote: Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall amber.rose.thr...@gmail.com escreveu: Fixed various coding style issues, including strings over 80 characters long and many deprecated

Re: [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)

Moikka! On 09/19/2014 10:55 PM, Luca Olivetti wrote: El 19/09/14 21:22, Frank Schäfer ha escrit: So symbol_request() returns pointers.!= NULL A closer look at the definition of symbol_request() shows, that it does nothing if CONFIG_MODULES is disabled (it just returns its argument). One

Re: [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)

Moikka! On 09/19/2014 10:55 PM, Luca Olivetti wrote: El 19/09/14 21:22, Frank Schäfer ha escrit: So symbol_request() returns pointers.!= NULL A closer look at the definition of symbol_request() shows, that it does nothing if CONFIG_MODULES is disabled (it just returns its argument). One

[PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

on commit 347f7a3763601d7b466898d1f10080b7083ac4a3 Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a Reported-by: Jeff Mahoney Signed-off-by: Antti Palosaari --- drivers/media/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

On 08/22/2014 06:24 PM, Jeff Mahoney wrote: On Fri Aug 22 11:17:22 2014, Antti Palosaari wrote: Moikka! On 08/22/2014 06:00 PM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Antti - Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) enables

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

Moikka! On 08/22/2014 06:00 PM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Antti - Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) enables CONFIG_SPI globally for a driver that won't even be enabled in many cases. Is there a reason USB_MSI2500

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

Moikka! On 08/22/2014 06:00 PM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Antti - Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) enables CONFIG_SPI globally for a driver that won't even be enabled in many cases. Is there a reason USB_MSI2500

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

On 08/22/2014 06:24 PM, Jeff Mahoney wrote: On Fri Aug 22 11:17:22 2014, Antti Palosaari wrote: Moikka! On 08/22/2014 06:00 PM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Antti - Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) enables

[PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

on commit 347f7a3763601d7b466898d1f10080b7083ac4a3 Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a Reported-by: Jeff Mahoney je...@suse.com Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/Kconfig b

Re: [PATCH] media: em28xx-dvb unregister i2c tuner and demod after fe detach

Moikka! On 07/15/2014 08:29 PM, Shuah Khan wrote: On 07/12/2014 02:14 PM, Antti Palosaari wrote: Moikka Shuah! I suspect that patch makes no sense. On DVB there is runtime PM controlled by DVB frontend. It wakes up all FE sub-devices when frontend device is opened and sleeps when closed. FE

Re: [PATCH] media: em28xx-dvb unregister i2c tuner and demod after fe detach

Moikka! On 07/15/2014 08:29 PM, Shuah Khan wrote: On 07/12/2014 02:14 PM, Antti Palosaari wrote: Moikka Shuah! I suspect that patch makes no sense. On DVB there is runtime PM controlled by DVB frontend. It wakes up all FE sub-devices when frontend device is opened and sleeps when closed. FE

Re: [PATCH] media: em28xx-dvb - fix em28xx_dvb_resume() to not unregister i2c and dvb

Reviewed-by: Antti Palosaari Antti On 07/09/2014 04:21 PM, Shuah Khan wrote: em28xx_dvb_resume() unregisters i2c tuner, i2c demod, and dvb. This erroneous cleanup results in i2c tuner, i2c demod, and dvb devices unregistered and removed during resume. This error is a result of merge conflict

Re: [PATCH] media: em28xx - add error handling for KWORLD dvb_attach failures

Looks correct! All the other devices, excluding those few PCTV ones I have added, has that same bug... Deadlocks if tuner attach fails. Reviewed-by: Antti Palosaari regards Antti On 07/09/2014 11:36 PM, Shuah Khan wrote: Add error hanlding when EM2870_BOARD_KWORLD_A340 dvb_attach() for fe

Re: [PATCH] media: em28xx-dvb unregister i2c tuner and demod after fe detach

Moikka Shuah! I suspect that patch makes no sense. On DVB there is runtime PM controlled by DVB frontend. It wakes up all FE sub-devices when frontend device is opened and sleeps when closed. FE release() is not relevant at all for those sub-devices which are implemented as a proper I2C

Re: [PATCH] media: em28xx-dvb unregister i2c tuner and demod after fe detach

Moikka Shuah! I suspect that patch makes no sense. On DVB there is runtime PM controlled by DVB frontend. It wakes up all FE sub-devices when frontend device is opened and sleeps when closed. FE release() is not relevant at all for those sub-devices which are implemented as a proper I2C

Re: [PATCH] media: em28xx - add error handling for KWORLD dvb_attach failures

Looks correct! All the other devices, excluding those few PCTV ones I have added, has that same bug... Deadlocks if tuner attach fails. Reviewed-by: Antti Palosaari cr...@iki.fi regards Antti On 07/09/2014 11:36 PM, Shuah Khan wrote: Add error hanlding when EM2870_BOARD_KWORLD_A340

Re: [PATCH] media: em28xx-dvb - fix em28xx_dvb_resume() to not unregister i2c and dvb

Reviewed-by: Antti Palosaari cr...@iki.fi Antti On 07/09/2014 04:21 PM, Shuah Khan wrote: em28xx_dvb_resume() unregisters i2c tuner, i2c demod, and dvb. This erroneous cleanup results in i2c tuner, i2c demod, and dvb devices unregistered and removed during resume. This error is a result

Re: [PATCH 1/1] dvb-frontends: remove unnecessary break after goto

Moikka Fabian! I have no reason to decline that patch (I will apply it) even it has hardly meaning. But is there now some new tool which warns that kind of issues? regards Atnti On 07/08/2014 08:23 PM, Fabian Frederick wrote: Cc: Antti Palosaari Cc: Mauro Carvalho Chehab Cc: linux-me

Re: [PATCH 1/1] dvb-frontends: remove unnecessary break after goto

Moikka Fabian! I have no reason to decline that patch (I will apply it) even it has hardly meaning. But is there now some new tool which warns that kind of issues? regards Atnti On 07/08/2014 08:23 PM, Fabian Frederick wrote: Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab m.che

Re: [PATCH 1/1] staging: media: msi3101: sdr-msi3101.c - replace with time_before_eq()

Moikka! That is already fixed by someone else and patch is somewhere Mauro or Hans queue. regards Antti On 06/29/2014 08:20 AM, Anil Belur wrote: From: Anil Belur - this fix replaces jiffies interval comparision with safer function to avoid any overflow and wrap around ? Signed-off-by:

Re: [PATCH 1/1] staging: media: msi3101: sdr-msi3101.c - replace with time_before_eq()

Moikka! That is already fixed by someone else and patch is somewhere Mauro or Hans queue. regards Antti On 06/29/2014 08:20 AM, Anil Belur wrote: From: Anil Belur ask...@gmail.com - this fix replaces jiffies interval comparision with safer function to avoid any overflow and wrap around ?

Re: [PATCH] msi3103: Use time_before_eq()

Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Mauro, pick that from patchwork to 3.16. I am not going to PULL request it. regards Antti On 05/25/2014 03:39 PM, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons are modified to use

Re: [PATCH] msi3103: Use time_before_eq()

Acked-by: Antti Palosaari cr...@iki.fi Reviewed-by: Antti Palosaari cr...@iki.fi Mauro, pick that from patchwork to 3.16. I am not going to PULL request it. regards Antti On 05/25/2014 03:39 PM, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons

Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()

On 05/17/2014 07:05 PM, Martin Kepplinger wrote: don't reinvent dev_dbg(). remove dprintk() in as102_drv.c. use the common kernel coding style. Signed-off-by: Martin Kepplinger Reviewed-by: Antti Palosaari --- this applies to next-20140516. any more suggestions? more cleanup can be done

Re: [PATCH] staging: media: as102: replace custom dprintk() with dev_dbg()

you forget to remove debug parameter itself. Antti On 05/17/2014 04:16 PM, Martin Kepplinger wrote: don't reinvent dev_dbg(). use the common kernel coding style. Signed-off-by: Martin Kepplinger --- this applies to next-20140516. drivers/staging/media/as102/as102_drv.c | 11 +++

Re: [PATCH] staging: media: as102: replace custom dprintk() with dev_dbg()

you forget to remove debug parameter itself. Antti On 05/17/2014 04:16 PM, Martin Kepplinger wrote: don't reinvent dev_dbg(). use the common kernel coding style. Signed-off-by: Martin Kepplinger mart...@posteo.de --- this applies to next-20140516. drivers/staging/media/as102/as102_drv.c |

Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()

On 05/17/2014 07:05 PM, Martin Kepplinger wrote: don't reinvent dev_dbg(). remove dprintk() in as102_drv.c. use the common kernel coding style. Signed-off-by: Martin Kepplinger mart...@posteo.de Reviewed-by: Antti Palosaari cr...@iki.fi --- this applies to next-20140516. any more

Re: randconfig build error with next-20140324, in drivers/media/tuners/e4000.c

Already fixed https://patchwork.linuxtv.org/patch/23115/ On 24.03.2014 20:38, Jim Davis wrote: Building with the attached random configuration file, warning: (DVB_USB_RTL28XXU) selects MEDIA_TUNER_E4000 which has unmet direct dependencies ((MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT

Re: randconfig build error with next-20140324, in drivers/media/tuners/e4000.c

Already fixed https://patchwork.linuxtv.org/patch/23115/ On 24.03.2014 20:38, Jim Davis wrote: Building with the attached random configuration file, warning: (DVB_USB_RTL28XXU) selects MEDIA_TUNER_E4000 which has unmet direct dependencies ((MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT

Re: [PATCH v2 1/2] [media] rtl28xxu: add USB ID for Genius TVGo DVB-T03

Applied, thanks! Antti On 26.02.2014 20:33, Jan Vcelak wrote: 0458:707f KYE Systems Corp. (Mouse Systems) TVGo DVB-T03 [RTL2832] The USB dongle uses RTL2832U demodulator and FC0012 tuner. Signed-off-by: Jan Vcelak --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 ++ 1 file changed, 2

Re: [PATCH v2 2/2] [media] rtl28xxu: add chipset version comments into device list

Applied, thanks! Antti On 26.02.2014 20:33, Jan Vcelak wrote: Signed-off-by: Jan Vcelak --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index

Re: [PATCH] [media] rtl28xxu: add USB ID for Genius TVGo DVB-T03

Thank for the patch. Even I didn't added any comment to driver ID list, which apparently should be there, that empty line before "Astrometa DVB-T2" entry was there because I wanted to separate RTL2832P entries from RTL2832U entries (different chipset version). So if possible, could you

Re: [PATCH] [media] rtl28xxu: add USB ID for Genius TVGo DVB-T03

Thank for the patch. Even I didn't added any comment to driver ID list, which apparently should be there, that empty line before Astrometa DVB-T2 entry was there because I wanted to separate RTL2832P entries from RTL2832U entries (different chipset version). So if possible, could you provide

Re: [PATCH v2 1/2] [media] rtl28xxu: add USB ID for Genius TVGo DVB-T03

Applied, thanks! Antti On 26.02.2014 20:33, Jan Vcelak wrote: 0458:707f KYE Systems Corp. (Mouse Systems) TVGo DVB-T03 [RTL2832] The USB dongle uses RTL2832U demodulator and FC0012 tuner. Signed-off-by: Jan Vcelak j...@fcelda.cz --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 ++ 1 file

Re: [PATCH v2 2/2] [media] rtl28xxu: add chipset version comments into device list

Applied, thanks! Antti On 26.02.2014 20:33, Jan Vcelak wrote: Signed-off-by: Jan Vcelak j...@fcelda.cz --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index

Re: video4linux device name request for Software Defined Radio

Hi device manager, On 16.12.2013 20:11, Antti Palosaari wrote: Hello, We need new video4linux device name for Software Defined Radio devices. Device numbers are allocated dynamically. Desired device name was /dev/sdr, but as it seems to be already reserved, it was made decision to apply /dev

Re: video4linux device name request for Software Defined Radio

Hi device manager, On 16.12.2013 20:11, Antti Palosaari wrote: Hello, We need new video4linux device name for Software Defined Radio devices. Device numbers are allocated dynamically. Desired device name was /dev/sdr, but as it seems to be already reserved, it was made decision to apply /dev

Re: stable regression: tda18271_read_regs: [1-0060|M] ERROR: i2c_transfer returned: -19

Off-topic, Cc:s dropped, related to DVB / V4L2 tuner communication problems. On 17.12.2013 07:39, Devin Heitmueller wrote: Hi Connor, On Tue, Dec 17, 2013 at 12:28 AM, Connor Behan wrote: Thanks for the detailed answer. I have tried your patch and updated the wiki page. Would a 950 or 950Q

Re: stable regression: tda18271_read_regs: [1-0060|M] ERROR: i2c_transfer returned: -19

Off-topic, Cc:s dropped, related to DVB / V4L2 tuner communication problems. On 17.12.2013 07:39, Devin Heitmueller wrote: Hi Connor, On Tue, Dec 17, 2013 at 12:28 AM, Connor Behan connor.be...@gmail.com wrote: Thanks for the detailed answer. I have tried your patch and updated the wiki page.

Re: randconfig build error with next-20130917, in drivers/staging/media/msi3101

Hello Jim, That is maybe 5th times I got that same bug report :-] It is already fixed. Mauro tends to handle pending patches once per release candidate, so I think fix will be in next very soon (during this week). https://patchwork.kernel.org/patch/2856771/

Re: randconfig build error with next-20130917, in drivers/staging/media/msi3101

Hello Jim, That is maybe 5th times I got that same bug report :-] It is already fixed. Mauro tends to handle pending patches once per release candidate, so I think fix will be in next very soon (during this week). https://patchwork.kernel.org/patch/2856771/

Re: [PATCH -next] staging/media: fix msi3101 build errors

' drivers/built-in.o:(.rodata+0x355a0): undefined reference to `vb2_fop_release' drivers/built-in.o:(.data+0x23b40): undefined reference to `vb2_ops_wait_prepare' drivers/built-in.o:(.data+0x23b44): undefined reference to `vb2_ops_wait_finish' Signed-off-by: Randy Dunlap Cc: Antti Palosaari

Re: [PATCH -next] staging/media: fix msi3101 build errors

...@infradead.org Cc: Antti Palosaari cr...@iki.fi --- drivers/staging/media/msi3101/Kconfig |2 ++ 1 file changed, 2 insertions(+) --- linux-next-20130912.orig/drivers/staging/media/msi3101/Kconfig +++ linux-next-20130912/drivers/staging/media/msi3101/Kconfig @@ -1,3 +1,5 @@ config

Re: [PATCH 12/18] MAINTAINERS: Update it913x patterns

On 07/22/2013 03:15 AM, Joe Perches wrote: commit d7104bffcfb ("[media] MAINTAINERS: add drivers/media/tuners/it913x*") used the incorrect file patterns. Fix it. Signed-off-by: Joe Perches cc: Antti Palosaari cc: Mauro Carvalho Chehab Acked-by: Antti Palosaari PS. It wasn't t

Re: [PATCH 12/18] MAINTAINERS: Update it913x patterns

On 07/22/2013 03:15 AM, Joe Perches wrote: commit d7104bffcfb ([media] MAINTAINERS: add drivers/media/tuners/it913x*) used the incorrect file patterns. Fix it. Signed-off-by: Joe Perches j...@perches.com cc: Antti Palosaari cr...@iki.fi cc: Mauro Carvalho Chehab mche...@redhat.com Acked

Re: [PATCH] [media] rtl28xxu: Add USB ID for Leadtek WinFast DTV Dongle mini

On 05/15/2013 02:42 AM, Miroslav Šustek wrote: USB ID 0413:6a03 is Leadtek WinFast DTV Dongle mini. Decoder Realtek RTL2832U and tuner Infineon TUA9001. Signed-off-by: Miroslav Šustek Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2

Re: [PATCH] [media] rtl28xxu: Add USB ID for Leadtek WinFast DTV Dongle mini

On 05/15/2013 02:42 AM, Miroslav Šustek wrote: USB ID 0413:6a03 is Leadtek WinFast DTV Dongle mini. Decoder Realtek RTL2832U and tuner Infineon TUA9001. Signed-off-by: Miroslav Šustek sustmid...@centrum.cz Acked-by: Antti Palosaari cr...@iki.fi Reviewed-by: Antti Palosaari cr...@iki.fi

Re: [PATCH 2/2] [media] anysee: Grammar s/report the/report to/

On 04/24/2013 02:36 PM, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/anysee.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2

Re: [PATCH 1/2] [media] anysee: Initialize ret = 0 in anysee_frontend_attach()

to zero to fix this. Signed-off-by: Geert Uytterhoeven Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/anysee.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb

  1   2   >