[PATCH 4/7] efi: gsmi: fix false dependency on CONFIG_EFI_VARS

2020-09-23 Thread Ard Biesheuvel
-off-by: Ard Biesheuvel --- drivers/firmware/google/Kconfig | 2 +- drivers/firmware/google/gsmi.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig index a3a6ca659ffa..97968aece54f 100644 --- a/drivers

[PATCH 7/7] efi: efivars: remove deprecated sysfs interface

2020-09-23 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- Note: for reference only - please read cover letter before replying. Documentation/ABI/stable/sysfs-firmware-efi-vars | 75 --- drivers/firmware/efi/Kconfig | 12 - drivers/firmware/efi/Makefile| 1 - drivers/firmware

[PATCH 3/7] efi: efivars: un-export efivars_sysfs_init()

2020-09-23 Thread Ard Biesheuvel
efivars_sysfs_init() is only used locally in the source file that defines it, so make it static and unexport it. Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/efivars.c | 3 +-- include/linux/efi.h| 4 2 files changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH 1/7] efi: pstore: disentangle from deprecated efivars module

2020-09-23 Thread Ard Biesheuvel
EFI pstore's dependency on it. Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/Kconfig | 2 +- drivers/firmware/efi/efi-pstore.c | 76 ++-- drivers/firmware/efi/efivars.c| 41 +-- include/linux/efi.h | 4 -- 4 files changed, 74 insertions

[PATCH 0/7] efi: deprecate/remove efivars sysfs interface

2020-09-23 Thread Ard Biesheuvel
dependencies [true or false] on the efivars.c code and its CONFIG_EFI_VARS Kconfig symbol, so it can be disabled [or dropped] cleanly. Cc: Matthew Garrett Cc: Peter Jones Cc: Kees Cook Cc: Anton Vorontsov Cc: Colin Cross Cc: Tony Luck Ard Biesheuvel (7): efi: pstore: disentangle from deprecated

[PATCH 2/7] efi: pstore: move workqueue handling out of efivars

2020-09-23 Thread Ard Biesheuvel
the workqueue like we did before, so we can run it unconditionally. Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/efi-pstore.c | 7 +-- drivers/firmware/efi/vars.c | 21 include/linux/efi.h | 3 --- 3 files changed, 5 insertions(+), 26

Re: [PATCH v4] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-23 Thread Ard Biesheuvel
On Wed, 23 Sep 2020 at 16:05, Borislav Petkov wrote: > > Smita, > > pls sync the time of the box where you create the patch: > > Date: Fri, 4 Sep 2020 09:04:44 -0500 > > but your mail headers have: > > Received: from ... with mapi id 15.20.3370.019; Fri, 18 Sep 2020 14:49:12 > + >

Re: [PATCH] arm64: crypto: Add an option to assume NEON XOR is the fastest

2020-09-23 Thread Ard Biesheuvel
On Wed, 23 Sep 2020 at 02:39, Doug Anderson wrote: > > Hi, > > On Tue, Sep 22, 2020 at 3:30 AM Ard Biesheuvel wrote: > > > > On Tue, 22 Sep 2020 at 10:26, David Laight wrote: > > > > > > From: Douglas Anderson > > > > Sent: 22 Septembe

Re: [PATCH] arm64: crypto: Add an option to assume NEON XOR is the fastest

2020-09-22 Thread Ard Biesheuvel
On Tue, 22 Sep 2020 at 10:26, David Laight wrote: > > From: Douglas Anderson > > Sent: 22 September 2020 01:26 > > > > On every boot time we see messages like this: > > > > [0.025360] calling calibrate_xor_blocks+0x0/0x134 @ 1 > > [0.025363] xor: measuring software checksum speed > > [

[PATCH] tpm: of: avoid __va() translation for event log address

2020-09-22 Thread Ard Biesheuvel
mapping otherwise. Cc: Peter Huewe Cc: Jarkko Sakkinen Cc: Jason Gunthorpe Signed-off-by: Ard Biesheuvel --- drivers/char/tpm/eventlog/of.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/char/tpm/eventlog/of.c b/drivers/char/tpm/eventlog/of.c index

Re: [PATCH] arm64: crypto: Add an option to assume NEON XOR is the fastest

2020-09-22 Thread Ard Biesheuvel
On Tue, 22 Sep 2020 at 02:27, Douglas Anderson wrote: > > On every boot time we see messages like this: > > [0.025360] calling calibrate_xor_blocks+0x0/0x134 @ 1 > [0.025363] xor: measuring software checksum speed > [0.035351]8regs : 3952.000 MB/sec > [0.045384]

Re: [PATCH V2 1/3] efi: Support for MOK variable config table

2020-09-21 Thread Ard Biesheuvel
On Mon, 21 Sep 2020 at 18:19, Arvind Sankar wrote: > > On Fri, Sep 04, 2020 at 09:31:05PM -0400, Lenny Szubowicz wrote: > > Because of system-specific EFI firmware limitations, EFI volatile > > variables may not be capable of holding the required contents of > > the Machine Owner Key (MOK)

Re: [PATCH v2 2/2] ARM: support PHYS_OFFSET minimum aligned at 64KiB boundary

2020-09-21 Thread Ard Biesheuvel
On Mon, 21 Sep 2020 at 05:35, Leizhen (ThunderTown) wrote: > > > > On 2020/9/17 22:00, Ard Biesheuvel wrote: > > On Tue, 15 Sep 2020 at 22:06, Russell King - ARM Linux admin > > wrote: > >> > >> On Tue, Sep 15, 2020 at 09:16:15PM +0800, Zhen Lei wrote:

Re: [PATCH v2] arm64: Enable PCI write-combine resources under sysfs

2020-09-18 Thread Ard Biesheuvel
d by multiple non-x86 archs to expose write combine > > semantics to user space. We enable this on arm64 to give userspace on > > arm64 an equivalent mechanism for utilizing write combining with PCI > > devices. > > > > Cc: Benjamin Herrenschmidt > > Cc: Bjorn Helgaas > > Cc: Catalin Marinas > > Cc: Jason Gunthorpe > > Cc: Lorenzo Pieralisi > > Cc: Will Deacon > > Signed-off-by: Clint Sbisa > > Acked-by: Catalin Marinas > Acked-by: Ard Biesheuvel

[tip: efi/core] efi/libstub: Export efi_low_alloc_above() to other units

2020-09-18 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/core branch of tip: Commit-ID: 1a895dbf4b66456bfb7da646cc9b1be3e24f4a1d Gitweb: https://git.kernel.org/tip/1a895dbf4b66456bfb7da646cc9b1be3e24f4a1d Author:Ard Biesheuvel AuthorDate:Wed, 09 Sep 2020 16:16:20 +03:00

[tip: efi/core] efi/libstub: arm32: Base FDT and initrd placement on image address

2020-09-18 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/core branch of tip: Commit-ID: 6208857b8f7ebdfe84e1be7573be4552a5896a0d Gitweb: https://git.kernel.org/tip/6208857b8f7ebdfe84e1be7573be4552a5896a0d Author:Ard Biesheuvel AuthorDate:Thu, 10 Sep 2020 17:09:45 +03:00

[tip: efi/core] efi/libstub: arm32: Use low allocation for the uncompressed kernel

2020-09-18 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/core branch of tip: Commit-ID: 762cd288fc4a24a372f36408e69b1885967f94bb Gitweb: https://git.kernel.org/tip/762cd288fc4a24a372f36408e69b1885967f94bb Author:Ard Biesheuvel AuthorDate:Wed, 09 Sep 2020 17:11:50 +03:00

[tip: efi/urgent] efi: efibc: check for efivars write capability

2020-09-18 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 46908326c6b801201f1e46f5ed0db6e85bef74ae Gitweb: https://git.kernel.org/tip/46908326c6b801201f1e46f5ed0db6e85bef74ae Author:Ard Biesheuvel AuthorDate:Tue, 15 Sep 2020 18:12:09 +03:00

Re: [PATCH AUTOSEL 4.9 23/90] efi/arm: Defer probe of PCIe backed efifb on DT systems

2020-09-18 Thread Ard Biesheuvel
On Fri, 18 Sep 2020 at 05:15, Sasha Levin wrote: > > From: Ard Biesheuvel > > [ Upstream commit 64c8a0cd0a535891d5905c3a1651150f0f141439 ] > > The new of_devlink support breaks PCIe probing on ARM platforms booting > via UEFI if the firmware exposes a EFI framebuffer that

Re: [PATCH v2 2/2] ARM: support PHYS_OFFSET minimum aligned at 64KiB boundary

2020-09-17 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 22:06, Russell King - ARM Linux admin wrote: > > On Tue, Sep 15, 2020 at 09:16:15PM +0800, Zhen Lei wrote: > > Currently, only support the kernels where the base of physical memory is > > at a 16MiB boundary. Because the add/sub instructions only contains 8bits > >

Re: [PATCH v3 2/2] ARM: support PHYS_OFFSET minimum aligned at 64KiB boundary

2020-09-17 Thread Ard Biesheuvel
On Thu, 17 Sep 2020 at 05:16, Leizhen (ThunderTown) wrote: > > > > On 2020/9/16 19:15, Ard Biesheuvel wrote: > > (+ Arnd, Nico) > > > > On Wed, 16 Sep 2020 at 05:51, Zhen Lei wrote: > >> > >> Currently, only support the kernels where the bas

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-17 Thread Ard Biesheuvel
On Wed, 16 Sep 2020 at 21:32, Linus Torvalds wrote: > > But something like a driver list walking thing should not be doing > different things behind peoples back depending on whether they hold > spinlocks or not. It should either just work regardless, or there > should be a flag (or special

Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record

2020-09-16 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 20:19, Borislav Petkov wrote: > > On Tue, Sep 15, 2020 at 08:12:31PM +0300, Ard Biesheuvel wrote: > > Boris - do you anticipate any conflicts? If so, please take these via > > the EDAC tree - the CPER code is mostly self contained so I don't > &

Re: [PATCH v3 2/2] ARM: support PHYS_OFFSET minimum aligned at 64KiB boundary

2020-09-16 Thread Ard Biesheuvel
(+ Arnd, Nico) On Wed, 16 Sep 2020 at 05:51, Zhen Lei wrote: > > Currently, only support the kernels where the base of physical memory is > at a 16MiB boundary. Because the add/sub instructions only contains 8bits > unrotated value. But we can use one more "add/sub" instructions to handle > bits

Re: [PATCH v1] soc: fsl: rcpm: Add ACPI support

2020-09-16 Thread Ard Biesheuvel
On 9/16/20 3:32 AM, Ran Wang wrote: Hi Ard, On Tuesday, September 15, 2020 7:10 PM, Ard Biesheuvel wrote: Subject: Re: [PATCH v1] soc: fsl: rcpm: Add ACPI support On 9/15/20 1:06 PM, kuldip dwivedi wrote: Add ACPI support in fsl RCPM driver. This is required to support ACPI S3 state. S3

Re: [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates

2020-09-15 Thread Ard Biesheuvel
24 ++-- > 3 files changed, 53 insertions(+), 6 deletions(-) > For the series, Acked-by: Ard Biesheuvel

Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 19:33, Borislav Petkov wrote: > > On Wed, Aug 19, 2020 at 09:35:43AM -0500, Alex Kluver wrote: > > Memory errors could be printed with incorrect row values since the DIMM > > size has outgrown the 16 bit row field in the CPER structure. UEFI > > Specification Version 2.8

Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 20:07, Ard Biesheuvel wrote: > > On Tue, 15 Sep 2020 at 19:33, Borislav Petkov wrote: > > > > On Wed, Aug 19, 2020 at 09:35:43AM -0500, Alex Kluver wrote: > > > Memory errors could be printed with incorrect row values since the DIMM > > &

Re: [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 15:45, Horia Geantă wrote: > > On 9/15/2020 1:26 PM, Ard Biesheuvel wrote: > > On Tue, 15 Sep 2020 at 13:02, Horia Geantă wrote: > >> > >> On 9/14/2020 9:20 PM, Ard Biesheuvel wrote: > >>> On Mon, 14 Sep 2020 at 20:12, Horia Gean

Re: [PATCH v1] soc: fsl: rcpm: Add ACPI support

2020-09-15 Thread Ard Biesheuvel
On 9/15/20 1:06 PM, kuldip dwivedi wrote: Add ACPI support in fsl RCPM driver. This is required to support ACPI S3 state. S3 is the ACPI sleep state that is known as "sleep" or "suspend to RAM". It essentially turns off most power of the system but keeps memory powered. Signed-off-by: tanveer

Re: [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 13:02, Horia Geantă wrote: > > On 9/14/2020 9:20 PM, Ard Biesheuvel wrote: > > On Mon, 14 Sep 2020 at 20:12, Horia Geantă wrote: > >> > >> On 9/14/2020 7:28 PM, Ard Biesheuvel wrote: > >>> On Mon, 14 Sep 2020 at 19:24, Horia Geantă

Re: [PATCH] crypto: lib/chacha20poly1305 - Set SG_MITER_ATOMIC unconditionally

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 13:05, Herbert Xu wrote: > > On Tue, Sep 15, 2020 at 01:02:10PM +0300, Ard Biesheuvel wrote: > > > > > I'd rather go for a preemptible/sleepable version of highmem mapping > > > which is in itself consistent for both highmen and not highmem.

Re: [PATCH] crypto: lib/chacha20poly1305 - Set SG_MITER_ATOMIC unconditionally

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 12:34, Thomas Gleixner wrote: > > On Tue, Sep 15 2020 at 17:05, Herbert Xu wrote: > > On Mon, Sep 14, 2020 at 11:55:53PM -0700, Linus Torvalds wrote: > >> > >> Maybe we could hide it behind a debug option, at least. > >> > >> Or, alterantively, introduce a new

Re: [PATCH] crypto: lib/chacha20poly1305 - Set SG_MITER_ATOMIC unconditionally

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 10:05, Herbert Xu wrote: > > On Mon, Sep 14, 2020 at 11:55:53PM -0700, Linus Torvalds wrote: > > > > Maybe we could hide it behind a debug option, at least. > > > > Or, alterantively, introduce a new "debug_preempt_count" that doesn't > > actually disable preemption, but

Re: [PATCH] crypto: lib/chacha20poly1305 - Set SG_MITER_ATOMIC unconditionally

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 09:56, Linus Torvalds wrote: > > On Mon, Sep 14, 2020 at 11:45 PM Linus Torvalds > wrote: > > > > I mean, I did find one case that didn't set it (cb710-mmc.c), but > > pattern-matching to the other mmc cases, that one looks like it > > _should_ have set the atomic flag

Re: [patch 00/13] preempt: Make preempt count unconditional

2020-09-15 Thread Ard Biesheuvel
On Tue, 15 Sep 2020 at 01:43, Linus Torvalds wrote: > > On Mon, Sep 14, 2020 at 3:24 PM Linus Torvalds > wrote: > > > > Ard and Herbert added to participants: see > > chacha20poly1305_crypt_sg_inplace(), which does > > > > flags = SG_MITER_TO_SG; > > if (!preemptible()) > >

Re: [PATCH] crypto: lib/chacha20poly1305 - Set SG_MITER_ATOMIC unconditionally

2020-09-15 Thread Ard Biesheuvel
(+ Jason) On Tue, 15 Sep 2020 at 06:30, Herbert Xu wrote: > > I trimmed the cc as the mailing lists appear to be blocking this > email because of it. > > On Mon, Sep 14, 2020 at 03:37:49PM -0700, Linus Torvalds wrote: > > > > So it _looks_ like this code started using kmap() - probably back when

Re: [PATCH v7 5/9] RISC-V: Add PE/COFF header for EFI stub

2020-09-14 Thread Ard Biesheuvel
On Sat, 12 Sep 2020 at 05:04, Atish Patra wrote: > > On Fri, Sep 11, 2020 at 6:09 AM Ard Biesheuvel wrote: > > > > On Fri, 28 Aug 2020 at 20:20, Atish Patra wrote: > > > > > > Linux kernel Image can appear as an EFI application With appropriate > >

Re: [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV

2020-09-14 Thread Ard Biesheuvel
On Mon, 14 Sep 2020 at 20:12, Horia Geantă wrote: > > On 9/14/2020 7:28 PM, Ard Biesheuvel wrote: > > On Mon, 14 Sep 2020 at 19:24, Horia Geantă wrote: > >> > >> On 9/9/2020 1:10 AM, Herbert Xu wrote: > >>> On Tue, Sep 08, 2020 at 01:35:04PM +0300,

Re: [PATCH RESEND 1/9] crypto: caam/jr - add fallback for XTS with more than 8B IV

2020-09-14 Thread Ard Biesheuvel
On Mon, 14 Sep 2020 at 19:24, Horia Geantă wrote: > > On 9/9/2020 1:10 AM, Herbert Xu wrote: > > On Tue, Sep 08, 2020 at 01:35:04PM +0300, Horia Geantă wrote: > >> > >>> Just go with the get_unaligned unconditionally. > >> > >> Won't this lead to sub-optimal code for ARMv7 > >> in case the IV is

Re: [PATCH v2] x86/boot/compressed: Disable relocation relaxation

2020-09-13 Thread Ard Biesheuvel
e able to > > send it in for the next -rc? It shouldn't hurt the tip/x86/boot series, > > and we can add a revert on top of that later. > > > > Thanks. > > Ping. > > https://lore.kernel.org/lkml/20200812004308.1448603-1-nived...@alum.mit.edu/ Acked-by: Ard Biesheuvel

Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain

2020-09-11 Thread Ard Biesheuvel
On Thu, 3 Sep 2020 at 09:34, Punit Agrawal wrote: > > Hi Smita, > > Smita Koralahalli Channabasappa writes: > > > On 8/31/20 12:05 AM, Punit Agrawal wrote: > > > >> Hi Smita, > >> > >> A couple of comments below - > >> > >> Smita Koralahalli writes: > >> > >> [...] > >> > >> > >>> diff --git

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Ard Biesheuvel
On Fri, 11 Sep 2020 at 20:18, Lenny Szubowicz wrote: > > On 9/11/20 11:59 AM, Mimi Zohar wrote: > > On Fri, 2020-09-11 at 11:54 -0400, Lenny Szubowicz wrote: > >> On 9/11/20 11:02 AM, Ard Biesheuvel wrote: > >>> On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrot

Re: [PATCH 1/6] efistub: pass uefi secureboot flag via fdt params

2020-09-11 Thread Ard Biesheuvel
On Fri, 4 Sep 2020 at 10:29, Chester Lin wrote: > > Add a new UEFI parameter: "linux,uefi-secure-boot" in fdt boot params > as other architectures have done in their own boot data. For example, > the boot_params->secure_boot in x86. > > Signed-off-by: Chester Lin Why do we need this flag? Can't

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Ard Biesheuvel
On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: > > Move the loading of certs from the UEFI MokListRT into a separate > routine to facilitate additional MokList functionality. > > There is no visible functional change as a result of this patch. > Although the UEFI dbx certs are now loaded

Re: [PATCH V2 0/3] integrity: Load certs from EFI MOK config table

2020-09-11 Thread Ard Biesheuvel
On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: > > Because of system-specific EFI firmware limitations, EFI volatile > variables may not be capable of holding the required contents of > the Machine Owner Key (MOK) certificate store when the certificate > list grows above some size.

Re: [PATCH v7 5/9] RISC-V: Add PE/COFF header for EFI stub

2020-09-11 Thread Ard Biesheuvel
image sections according to PE/COFF section alignment ] > Signed-off-by: Ard Biesheuvel > Reviewed-by: Anup Patel Since you need to respin this anyway, one comment below on a thing that I spotted while revisiting these patches. > --- > arch/riscv/include/asm/sections.h | 13

Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

2020-09-11 Thread Ard Biesheuvel
On 9/11/20 1:00 PM, Mark Brown wrote: On Fri, Sep 11, 2020 at 01:58:06PM +0530, kuldip dwivedi wrote: /* find the resources - configuration register address space */ res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fspi_base"); +#ifdef CONFIG_ACPI + res =

Re: [PATCH v7 71/72] x86/efi: Add GHCB mappings when SEV-ES is active

2020-09-10 Thread Ard Biesheuvel
On Wed, 9 Sep 2020 at 16:49, Tom Lendacky wrote: > > On 9/9/20 7:44 AM, Laszlo Ersek wrote: > > On 09/09/20 10:27, Ard Biesheuvel wrote: > >> (adding Laszlo and Brijesh) > >> > >> On Tue, 8 Sep 2020 at 20:46, Borislav Petkov wrote: > >&

Re: [PATCH v5] test_firmware: Test platform fw loading on non-EFI systems

2020-09-10 Thread Ard Biesheuvel
, since this is changing the "how" of the patch... > --- > drivers/firmware/efi/embedded-firmware.c | 10 +- > include/linux/efi_embedded_fw.h | 6 ++ > lib/test_firmware.c | 9 + > 3 files changed, 16 insertions(+), 9 deleti

Re: [PATCH 1/1] efi/libstub: DRAM base calculation

2020-09-10 Thread Ard Biesheuvel
On Wed, 9 Sep 2020 at 23:37, Atish Patra wrote: > > On Wed, Sep 9, 2020 at 1:17 AM Ard Biesheuvel wrote: > > > > (+ Atish, Palmer) > > > > On Fri, 4 Sep 2020 at 18:50, Heinrich Schuchardt wrote: > > > > > > In the memory map the

Re: [PATCH 1/1] efi/libstub: DRAM base calculation

2020-09-09 Thread Ard Biesheuvel
On Wed, 9 Sep 2020 at 13:44, Maxim Uvarov wrote: > > On Wed, 9 Sep 2020 at 11:17, Ard Biesheuvel wrote: > > > > (+ Atish, Palmer) > > > > On Fri, 4 Sep 2020 at 18:50, Heinrich Schuchardt wrote: > > > > > > In the memory map the

Re: [PATCH v7 71/72] x86/efi: Add GHCB mappings when SEV-ES is active

2020-09-09 Thread Ard Biesheuvel
(adding Laszlo and Brijesh) On Tue, 8 Sep 2020 at 20:46, Borislav Petkov wrote: > > + Ard so that he can ack the efi bits. > > On Mon, Sep 07, 2020 at 03:16:12PM +0200, Joerg Roedel wrote: > > From: Tom Lendacky > > > > Calling down to EFI runtime services can result in the firmware performing

Re: [PATCH 1/1] efi/libstub: DRAM base calculation

2020-09-09 Thread Ard Biesheuvel
(+ Atish, Palmer) On Fri, 4 Sep 2020 at 18:50, Heinrich Schuchardt wrote: > > In the memory map the regions with the lowest addresses may be of type > EFI_RESERVED_TYPE. The reserved areas may be discontinuous relative to the > rest of the memory. So for calculating the maximum loading address

Re: [PATCH v7 0/9] Add UEFI support for RISC-V

2020-09-09 Thread Ard Biesheuvel
On Wed, 9 Sep 2020 at 04:16, Palmer Dabbelt wrote: > > On Fri, 28 Aug 2020 10:20:27 PDT (-0700), Atish Patra wrote: > > This series adds UEFI support for RISC-V. > > > > Linux kernel: v5.9-rc2 > > U-Boot: v2020.07 > > OpenSBI: master > > > > Patch 1-3 are generic riscv feature addition required

Re: [PATCH] arm64/module: set trampoline section flags regardless of CONFIG_DYNAMIC_FTRACE

2020-09-02 Thread Ard Biesheuvel
check in > module_frob_arch_sections() > so that the section flags for .text.ftrace_trampoline get properly set to > SHF_EXECINSTR|SHF_ALLOC, without SHF_WRITE. > > Link: http://lore.kernel.org/r/20200831094651.GA16385@linux-8ccs > Acked-by: Will Deacon > Signed-off-by: Jessica Yu Acked-by: Ard Bies

Re: [PATCH] gss_krb5: Fix memleak in krb5_make_rc4_seq_num

2020-08-31 Thread Ard Biesheuvel
On Sat, 29 Aug 2020 at 18:43, J. Bruce Fields wrote: > > This code is rarely if ever used, and there are pending patches to > remove it completely, so I don't think it's worth trying to fix a rare > memory leak at this point. > > --b. > FYI I just submitted v3 of my series removing this code to

Re: [PATCH 2/3] ia64: remove unneeded header includes from

2020-08-31 Thread Ard Biesheuvel
; - for u8, u64, size_t, etc. > - for KERNEL_STACK_SIZE > > The other header includes are actually unneeded. > > previously included 436 headers, and now it includes > only 138. I confirmed is still self-contained. > > Signed-off-by: Masahiro Yamada Acked-by: Ard Biesheuvel > -

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-31 Thread Ard Biesheuvel
On Mon, 31 Aug 2020 at 13:43, Masahiro Yamada wrote: > > On Mon, Aug 31, 2020 at 6:47 PM Jessica Yu wrote: > > > > +++ Will Deacon [21/08/20 13:30 +0100]: > > [snipped] > > >> > > > So module_enforce_rwx_sections() is already called after > > >> > > > module_frob_arch_sections() - which really

Re: lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes

2020-08-27 Thread Ard Biesheuvel
On Thu, 27 Aug 2020 at 11:20, Arnd Bergmann wrote: > > On Thu, Aug 27, 2020 at 10:42 AM Ard Biesheuvel wrote: > > > > In that case, I suppose we should simply disable instrumentation for > > chacha_permute()? It is a straight-forward arithmetic transformation > > o

Re: lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes

2020-08-27 Thread Ard Biesheuvel
On Thu, 27 Aug 2020 at 10:33, Arnd Bergmann wrote: > > On Thu, Aug 27, 2020 at 10:10 AM Ard Biesheuvel wrote: > > On Thu, 27 Aug 2020 at 10:06, Herbert Xu > > wrote: > > > > > > On Thu, Aug 27, 2020 at 11:52:50AM +0800, kernel test robot wrote: > > &

Re: lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes

2020-08-27 Thread Ard Biesheuvel
(+ Arnd) On Thu, 27 Aug 2020 at 10:06, Herbert Xu wrote: > > On Thu, Aug 27, 2020 at 11:52:50AM +0800, kernel test robot wrote: > > > > First bad commit (maybe != root cause): > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head:

Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-27 Thread Ard Biesheuvel
x the original iwd 1.8 + WPA > Enterprise issue. > > Thank you! > > Caleb Jorden > Thanks for confirming. > > From: Herbert Xu > Sent: Thursday, August 27, 2020 3:49 AM > To: Ard Biesheuvel > Cc: Denis Kenzior; Andrew Zabor

Re: [v2 PATCH] crypto: af_alg - Work around empty control messages without MSG_MORE

2020-08-27 Thread Ard Biesheuvel
On Thu, 27 Aug 2020 at 09:15, Herbert Xu wrote: > > On Thu, Aug 27, 2020 at 08:40:01AM +0200, Ard Biesheuvel wrote: > > > > It is part of iwd - just build that and run 'make check' > > > > With your patch applied, the occurrence of sendmsg() in > > ope

Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-27 Thread Ard Biesheuvel
On Thu, 27 Aug 2020 at 00:19, Herbert Xu wrote: > > On Wed, Aug 26, 2020 at 05:42:27PM +0200, Ard Biesheuvel wrote: > > > > I still get a failure in aes_siv_encrypt(), which does not occur with > > the kernel side fix applied. > > Where is this test from? I can

Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-26 Thread Ard Biesheuvel
On Wed, 26 Aug 2020 at 17:33, Denis Kenzior wrote: > > Hi Herbert, > > On 8/26/20 9:19 AM, Herbert Xu wrote: > > On Wed, Aug 26, 2020 at 08:57:17AM -0500, Denis Kenzior wrote: > >> > >> I'm just waking up now, so I might seem dense, but for my education, can > >> you > >> tell me why we need to

Re: [PATCH] crypto: af_alg - Work around empty control messages without MSG_MORE

2020-08-26 Thread Ard Biesheuvel
: f3c802a1f300 ("crypto: algif_aead - Only wake up when...") > Cc: > Signed-off-by: Herbert Xu > Applied this onto v5.4.60, and it makes the iwd selftests pass again Acked-by: Ard Biesheuvel Tested-by: Ard Biesheuvel > diff --git a/crypto/af_alg.c b/crypto/af_alg.c &

Re: [PATCH v2] efi/efivars: Create efivars mount point via efivars abstraction

2020-08-26 Thread Ard Biesheuvel
On Wed, 26 Aug 2020 at 02:46, Lee, Chun-Yi wrote: > > This patch creates efivars mount point when active efivars abstraction > be set. It is useful for userland to determine the availability of efivars > filesystem. > > Cc: Matthias Brugger > Cc: Fabian Vogt > Cc: Ili

Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-26 Thread Ard Biesheuvel
On Wed, 26 Aug 2020 at 13:50, Herbert Xu wrote: > > On Wed, Aug 26, 2020 at 12:40:14PM +0200, Ard Biesheuvel wrote: > > > > It would be helpful if someone could explain for the non-mac80211 > > enlightened readers how iwd's EAP-PEAPv0 + MSCHAPv2 support relies on &

Re: [PATCH v6 0/9] Add UEFI support for RISC-V

2020-08-26 Thread Ard Biesheuvel
On Tue, 25 Aug 2020 at 20:04, Palmer Dabbelt wrote: > > On Wed, 19 Aug 2020 15:24:16 PDT (-0700), Atish Patra wrote: > > This series adds UEFI support for RISC-V. > > > > Linux kernel: v5.9-rc1 > > U-Boot: v2020.07 > > OpenSBI: master > > > > Patch 1-3 are generic riscv feature addition required

Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise

2020-08-26 Thread Ard Biesheuvel
On Wed, 26 Aug 2020 at 08:18, Paul Menzel wrote: > > > Dear Caleb, > > > Thank you for the report. Linux has a no regression policy, so the > correct forum to report this to is the Linux kernel folks. I am adding > the crypto and stable folks to the receiver list. > > Am 26.08.20 um 07:51 schrieb

Re: [PATCH v7 10/10] Drivers: hv: Enable Hyper-V code to be built on ARM64

2020-08-24 Thread Ard Biesheuvel
On Mon, 24 Aug 2020 at 18:48, Michael Kelley wrote: > > Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on > ARM64, causing the Hyper-V specific code to be built. > > Signed-off-by: Michael Kelley > --- > drivers/hv/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [PATCH v7 09/10] arm64: efi: Export screen_info

2020-08-24 Thread Ard Biesheuvel
On Mon, 24 Aug 2020 at 18:48, Michael Kelley wrote: > > The Hyper-V frame buffer driver may be built as a module, and > it needs access to screen_info. So export screen_info. > > Signed-off-by: Michael Kelley Acked-by: Ard Biesheuvel > --- > arch/arm64/kernel/efi.c | 1 +

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-22 Thread Ard Biesheuvel
(+ Masahiro) On Fri, 21 Aug 2020 at 14:30, Will Deacon wrote: > > On Fri, Aug 21, 2020 at 02:27:05PM +0200, Ard Biesheuvel wrote: > > On Fri, 21 Aug 2020 at 14:20, Will Deacon wrote: > > > > > > On Thu, Aug 13, 2020 at 03:07:13PM +0200, Ard Biesheuvel wrote: > &

[tip: efi/urgent] Documentation: efi: remove description of efi=old_map

2020-08-22 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: fb1201aececc59990b75ef59fca93ae4aa1e1444 Gitweb: https://git.kernel.org/tip/fb1201aececc59990b75ef59fca93ae4aa1e1444 Author:Ard Biesheuvel AuthorDate:Mon, 17 Aug 2020 12:00:17 +02:00

[tip: efi/urgent] efi/x86: Move 32-bit code into efi_32.c

2020-08-22 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 39ada88f9c862c1ff8929ff67e0d1199c7af73fe Gitweb: https://git.kernel.org/tip/39ada88f9c862c1ff8929ff67e0d1199c7af73fe Author:Ard Biesheuvel AuthorDate:Thu, 13 Aug 2020 19:38:17 +02:00

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-21 Thread Ard Biesheuvel
On Fri, 21 Aug 2020 at 14:20, Will Deacon wrote: > > On Thu, Aug 13, 2020 at 03:07:13PM +0200, Ard Biesheuvel wrote: > > On Thu, 13 Aug 2020 at 15:04, Jessica Yu wrote: > > > > > > +++ Ard Biesheuvel [13/08/20 10:36 +0200]: > > > >On Wed, 12 Aug 20

Re: [PATCH] efi/efivars: create efivars mount point when get variable services are available

2020-08-20 Thread Ard Biesheuvel
seful for userland to determine the availability of efivars > filesystem. > > Cc: Ilias Apalodimas > Cc: Ard Biesheuvel > Signed-off-by: "Lee, Chun-Yi" Hello Joey, This is not the right check to perform here: the efivarfs code could be instantiated using a different efiv

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-20 Thread Ard Biesheuvel
On Thu, 20 Aug 2020 at 11:30, Roger Pau Monné wrote: > > On Wed, Aug 19, 2020 at 01:33:39PM +0200, Norbert Kaminski wrote: > > > > On 19.08.2020 10:19, Roger Pau Monné wrote: > > > On Tue, Aug 18, 2020 at 08:40:18PM +0200, Marek Marczykowski-Górecki > > > wrote: > > > > On Tue, Aug 18, 2020 at

Re: [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device

2020-08-19 Thread Ard Biesheuvel
gt; slightly differently on this hardware, so it requires its own > > identifier. > > > > Cc: Rob Herring > > Cc: Ard Biesheuvel > > Acked-by: Rob Herring > > Signed-off-by: Masahisa Kojima > > I applied these patches: > > http://git.infradead.org/users/jjs/linux-tpmdd.git/log/refs/heads/master > Thanks Jarkko

Re: [PATCH 1/4] Makefile: add -fno-builtin-stpcpy

2020-08-18 Thread Ard Biesheuvel
On Tue, 18 Aug 2020 at 09:25, Greg KH wrote: > > On Tue, Aug 18, 2020 at 09:10:01AM +0200, Ard Biesheuvel wrote: > > On Tue, 18 Aug 2020 at 00:02, Nick Desaulniers > > wrote: > > > > > > LLVM implemented a recent "libcall optimization" that lowers c

Re: [PATCH 1/4] Makefile: add -fno-builtin-stpcpy

2020-08-18 Thread Ard Biesheuvel
On Tue, 18 Aug 2020 at 00:02, Nick Desaulniers wrote: > > LLVM implemented a recent "libcall optimization" that lowers calls to > `sprintf(dest, "%s", str)` where the return value is used to > `stpcpy(dest, str) - dest`. This generally avoids the machinery involved > in parsing format strings.

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-17 Thread Ard Biesheuvel
Hi Marek, On Sun, 16 Aug 2020 at 02:20, Marek Marczykowski-Górecki wrote: > > In case of Xen PV dom0, Xen passes along info about system tables (see > arch/x86/xen/efi.c), but not the memory map from EFI. This makes sense > as it is Xen responsible for managing physical memory address space. >

[tip: x86/boot] x86/boot/compressed: Move .got.plt entries out of the .got section

2020-08-14 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the x86/boot branch of tip: Commit-ID: 262b5cae67a672404da0dcbd009efc1227ad51e4 Gitweb: https://git.kernel.org/tip/262b5cae67a672404da0dcbd009efc1227ad51e4 Author:Ard Biesheuvel AuthorDate:Fri, 31 Jul 2020 16:07:45 -07:00

[tip: x86/boot] x86/boot/compressed: Force hidden visibility for all symbol references

2020-08-14 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the x86/boot branch of tip: Commit-ID: e544ea57ac0734bca752eb2d8635fecbe932c356 Gitweb: https://git.kernel.org/tip/e544ea57ac0734bca752eb2d8635fecbe932c356 Author:Ard Biesheuvel AuthorDate:Fri, 31 Jul 2020 16:07:46 -07:00

[tip: x86/boot] x86/boot/compressed: Get rid of GOT fixup code

2020-08-14 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the x86/boot branch of tip: Commit-ID: 423e4d198a036689de73fd6b073fc4349c4fa1ee Gitweb: https://git.kernel.org/tip/423e4d198a036689de73fd6b073fc4349c4fa1ee Author:Ard Biesheuvel AuthorDate:Fri, 31 Jul 2020 16:07:47 -07:00

Re: linux-next: new build warnings after binutils update

2020-08-14 Thread Ard Biesheuvel
On Fri, 14 Aug 2020 at 12:22, Ingo Molnar wrote: > > > * Ard Biesheuvel wrote: > > > (+ Arvind, Kees) > > > > On Thu, 13 Aug 2020 at 22:58, Stephen Rothwell > > wrote: > > > > > > Hi all, > > > > > > After upgadin

Re: [PATCH v5 8/9] RISC-V: Add EFI runtime services

2020-08-14 Thread Ard Biesheuvel
On Thu, 13 Aug 2020 at 01:48, Atish Patra wrote: > > This patch adds EFI runtime service support for RISC-V. > > Signed-off-by: Atish Patra Acked-by: Ard Biesheuvel > --- > arch/riscv/Kconfig | 2 + > arch/riscv/include/asm/efi.h|

Re: [PATCH v5 7/9] efi: Rename arm-init to efi-init common for all arch

2020-08-14 Thread Ard Biesheuvel
: Atish Patra Acked-by: Ard Biesheuvel Note to the maintainer: to the extent possible, please put the patches in this series that touch drivers/firmware/efi on a separate branch based on v5.9-rc1, and merge that into your for-v5.10 branch at the appropriate spot. I don't have anything queued in the E

Re: linux-next: new build warnings after binutils update

2020-08-14 Thread Ard Biesheuvel
(+ Arvind, Kees) On Thu, 13 Aug 2020 at 22:58, Stephen Rothwell wrote: > > Hi all, > > After upgading some software, builds of Linus' tree now produce these > warnings: > > x86_64-linux-gnu-ld: arch/x86/boot/compressed/head_64.o: warning: relocation > in read-only section `.head.text' >

Re: [PATCH] edac,ghes,cper: Add Row Extension to Memory Error Record

2020-08-14 Thread Ard Biesheuvel
On Mon, 27 Jul 2020 at 20:15, Alex Kluver wrote: > > Memory errors could be printed with incorrect row values since the DIMM > size has outgrown the 16 bit row field in the CPER structure. UEFI > Specification Version 2.8 has increased the size of row by allowing it to > use the first 2 bits from

Re: [PATCH 0/3] Three small fixes to cmdline parsing

2020-08-14 Thread Ard Biesheuvel
On Thu, 13 Aug 2020 at 20:58, Arvind Sankar wrote: > > First 2 are resends: > https://lore.kernel.org/linux-efi/20200725155916.1376773-1-nived...@alum.mit.edu/ > https://lore.kernel.org/linux-efi/20200729193300.598448-1-nived...@alum.mit.edu/ > > Arvind Sankar (3): > efi/libstub: Stop parsing

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-13 Thread Ard Biesheuvel
On Thu, 13 Aug 2020 at 15:04, Jessica Yu wrote: > > +++ Ard Biesheuvel [13/08/20 10:36 +0200]: > >On Wed, 12 Aug 2020 at 22:00, Peter Zijlstra wrote: > >> > >> On Wed, Aug 12, 2020 at 06:37:57PM +0200, Ard Biesheuvel wrote: > >> > I know there is

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-13 Thread Ard Biesheuvel
On Wed, 12 Aug 2020 at 22:00, Peter Zijlstra wrote: > > On Wed, Aug 12, 2020 at 06:37:57PM +0200, Ard Biesheuvel wrote: > > I know there is little we can do at this point, apart from ignoring > > the permissions - perhaps we should just defer the w^x check until

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-12 Thread Ard Biesheuvel
module_frob_arch_sections On Wed, 12 Aug 2020 at 18:00, Jessica Yu wrote: > > +++ Szabolcs Nagy [12/08/20 15:15 +0100]: > >The 08/12/2020 13:56, Will Deacon wrote: > >> On Wed, Aug 12, 2020 at 12:40:05PM +0200, pet...@infradead.org wrote: > >> > On Wed, Aug

Re: [PATCH v2] module: Harden STRICT_MODULE_RWX

2020-08-12 Thread Ard Biesheuvel
On Tue, 11 Aug 2020 at 18:01, Jessica Yu wrote: > > +++ Mauro Carvalho Chehab [11/08/20 17:27 +0200]: > >Em Tue, 11 Aug 2020 16:55:24 +0200 > >pet...@infradead.org escreveu: > > > >> On Tue, Aug 11, 2020 at 04:34:27PM +0200, Mauro Carvalho Chehab wrote: > >> > [33] .plt PROGBITS

Re: [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-08-04 Thread Ard Biesheuvel
On Sat, 25 Jul 2020 at 10:06, Ard Biesheuvel wrote: > > On Sat, 18 Jul 2020 at 11:18, Ard Biesheuvel wrote: > > > > On Fri, 3 Jul 2020 at 02:04, Ard Biesheuvel wrote: > > > > > > On Thu, 2 Jul 2020 at 20:21, Ard Biesheuvel wrote: > > > > > >

Re: [RFC PATCH v1 0/3] put arm64 kvm_config on a diet

2020-08-04 Thread Ard Biesheuvel
On Tue, 4 Aug 2020 at 14:45, Alex Bennée wrote: > > Hi, > > When building guest kernels for virtualisation we were bringing in a > bunch of stuff from physical hardware which we don't need for our > idealised fixable virtual PCI devices. This series makes some Kconfig > changes to allow the

Re: [PATCH v2 2/5] efi: provide empty efi_enter_virtual_mode implementation

2020-08-04 Thread Ard Biesheuvel
t; is annodated with __no_sanitize_address. > > Reported-by: kernel test robot > Signed-off-by: Andrey Konovalov Acked-by: Ard Biesheuvel > --- > include/linux/efi.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/efi.h b/include/linux/efi.h &g

Re: [RFT PATCH v4 0/9] Add UEFI support for RISC-V

2020-07-31 Thread Ard Biesheuvel
On Thu, 30 Jul 2020 at 02:36, Atish Patra wrote: > > This series adds UEFI support for RISC-V. > > Linux kernel: 5.8-rc7 + 1 exception vector setup patch (queued for for-next) > U-Boot: v2020.07 > OpenSBI: master > > This series depends on early setup of exeception vector patch >

<    1   2   3   4   5   6   7   8   9   10   >