Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-29 Thread Ard Biesheuvel
On Wed, 29 Jul 2020 at 04:51, Masami Hiramatsu wrote: > > On Tue, 28 Jul 2020 20:51:08 +0300 > Ard Biesheuvel wrote: > > > On Tue, 28 Jul 2020 at 16:35, Masami Hiramatsu wrote: > > > > > > On Tue, 28 Jul 2020 13:56:43 +0300 > > > Ard Biesheuvel wrot

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Ard Biesheuvel
On Tue, 28 Jul 2020 at 16:35, Masami Hiramatsu wrote: > > On Tue, 28 Jul 2020 13:56:43 +0300 > Ard Biesheuvel wrote: > > > On Tue, 28 Jul 2020 at 11:17, Masami Hiramatsu wrote: > > > > Masami or Peter should correct me if I am wrong, but it seems to me >

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-28 Thread Ard Biesheuvel
On Tue, 28 Jul 2020 at 11:17, Masami Hiramatsu wrote: > > On Sun, 26 Jul 2020 19:06:20 +0300 > Ard Biesheuvel wrote: > > > On Sun, 26 Jul 2020 at 11:14, Mike Rapoport wrote: > > > > > > On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > &

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-26 Thread Ard Biesheuvel
On Sun, 26 Jul 2020 at 11:14, Mike Rapoport wrote: > > On Sat, Jul 25, 2020 at 06:16:48AM +0300, Jarkko Sakkinen wrote: > > On Fri, Jul 24, 2020 at 11:27:46AM +0200, Ingo Molnar wrote: > > > > > > * Jarkko Sakkinen wrote: > > > > > > > Use text_alloc() and text_free() instead of module_alloc()

Re: [GIT PULL] EFI fixes for v5.8-rc

2020-07-25 Thread Ard Biesheuvel
On Sat, 25 Jul 2020 at 13:26, Ingo Molnar wrote: > > > * Ard Biesheuvel wrote: > > > Ping again? > > Sorry about the delay - sending it to Linus now. > Thanks Ingo

Re: [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-07-25 Thread Ard Biesheuvel
On Sat, 18 Jul 2020 at 11:18, Ard Biesheuvel wrote: > > On Fri, 3 Jul 2020 at 02:04, Ard Biesheuvel wrote: > > > > On Thu, 2 Jul 2020 at 20:21, Ard Biesheuvel wrote: > > > > > > On Thu, 2 Jul 2020 at 19:50, Eric Biggers wrote: > > > > >

Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()

2020-07-24 Thread Ard Biesheuvel
On Fri, 24 Jul 2020 at 12:27, Ingo Molnar wrote: > > > * Jarkko Sakkinen wrote: > > > Use text_alloc() and text_free() instead of module_alloc() and > > module_memfree() when an arch provides them. > > > > Cc: linux...@kvack.org > > Cc: Andi Kleen > > Cc: Masami Hiramatsu > > Cc: Peter

[tip: efi/urgent] efi/efivars: Expose RT service availability via efivars abstraction

2020-07-22 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: f88814cc2578c121e6edef686365036db72af0ed Gitweb: https://git.kernel.org/tip/f88814cc2578c121e6edef686365036db72af0ed Author:Ard Biesheuvel AuthorDate:Wed, 08 Jul 2020 13:01:57 +03:00

[tip: efi/urgent] efi: Revert "efi/x86: Fix build with gcc 4"

2020-07-22 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 769e0fe1171e95d90ea5a2d6d0b2bdc7d5d2e7b2 Gitweb: https://git.kernel.org/tip/769e0fe1171e95d90ea5a2d6d0b2bdc7d5d2e7b2 Author:Ard Biesheuvel AuthorDate:Thu, 09 Jul 2020 09:59:57 +03:00

Re: [RFT PATCH v3 1/9] RISC-V: Move DT mapping outof fixmap

2020-07-21 Thread Ard Biesheuvel
On Tue, 21 Jul 2020 at 11:57, Arnd Bergmann wrote: > > On Tue, Jul 21, 2020 at 6:18 AM Atish Patra wrote: > > On Sat, Jul 18, 2020 at 2:24 AM Arnd Bergmann wrote: > > > On Sat, Jul 18, 2020 at 3:05 AM Atish Patra wrote: > > > > That's what the original code was doing. A fixmap entry was added

Re: [GIT PULL] EFI fixes for v5.8-rc

2020-07-20 Thread Ard Biesheuvel
On Sat, 18 Jul 2020 at 08:54, Ard Biesheuvel wrote: > > On Thu, 9 Jul 2020 at 16:28, Ard Biesheuvel wrote: > > > > The following changes since commit 2a55280a3675203496d302463b941834228b9875: > > > > efi/libstub: arm: Print CPU boot mode and MMU state at boot (

Re: [PATCH 1/1] riscv: Enable compiler optimizations

2020-07-20 Thread Ard Biesheuvel
On Sun, 19 Jul 2020 at 07:45, Palmer Dabbelt wrote: > > On Tue, 07 Jul 2020 22:43:54 PDT (-0700), maoche...@eswin.com wrote: > > Enable ARCH_HAS_FAST_MULTIPLIER and ARCH_SUPPORTS_INT128 for better > > code generation. > > These 2 configurations works fine on GCC-9.3 and GCC-10.1 > > > >

Re: [PATCH for v5.9] arm64: Replace HTTP links with HTTPS ones

2020-07-19 Thread Ard Biesheuvel
On Sun, 19 Jul 2020 at 19:29, Alexander A. Klimov wrote: > > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't

Re: [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-07-18 Thread Ard Biesheuvel
On Fri, 3 Jul 2020 at 02:04, Ard Biesheuvel wrote: > > On Thu, 2 Jul 2020 at 20:21, Ard Biesheuvel wrote: > > > > On Thu, 2 Jul 2020 at 19:50, Eric Biggers wrote: > > > > > > [+linux-wireless, Marcel Holtmann, and Denis Kenzior] > > > > &

Re: [GIT PULL] EFI fixes for v5.8-rc

2020-07-17 Thread Ard Biesheuvel
On Thu, 9 Jul 2020 at 16:28, Ard Biesheuvel wrote: > > The following changes since commit 2a55280a3675203496d302463b941834228b9875: > > efi/libstub: arm: Print CPU boot mode and MMU state at boot (2020-06-17 > 15:29:11 +0200) > > are available in the Git rep

Re: [PATCH v5 0/7] x86/boot: Remove run-time relocations from compressed kernel

2020-07-17 Thread Ard Biesheuvel
On Fri, 17 Jul 2020 at 21:17, Nick Desaulniers wrote: > > On Fri, Jul 17, 2020 at 6:46 AM Arvind Sankar wrote: > > > > On Tue, Jul 14, 2020 at 08:41:26PM -0400, Arvind Sankar wrote: > > > The compressed kernel currently contains bogus run-time relocations in > > > the startup code in

Re: [PATCH] crypto: xts: use memmove to avoid overlapped memory copy

2020-07-17 Thread Ard Biesheuvel
On Fri, 17 Jul 2020 at 08:21, Herbert Xu wrote: > > On Thu, Jul 16, 2020 at 06:56:30PM +0300, Ard Biesheuvel wrote: > > On Thu, 16 Jul 2020 at 18:29, Colin King wrote: > > > > > > From: Colin Ian King > > > > > > There is a memcpy that perfor

Re: [PATCH] crypto: xts: use memmove to avoid overlapped memory copy

2020-07-16 Thread Ard Biesheuvel
On Thu, 16 Jul 2020 at 18:29, Colin King wrote: > > From: Colin Ian King > > There is a memcpy that performs a potential overlapped memory copy > from source b to destination b + 1. Fix this by using the safer > memmove instead. > > Addresses-Coverity: ("Overlapping buffer in memory copy") >

Re: [PATCH v5 6/7] x86/boot: Remove run-time relocations from head_{32,64}.S

2020-07-15 Thread Ard Biesheuvel
ted-by is inappropriate here. > > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=25754 > > > > Reviewed-by: Kees Cook > > Reviewed-by: Ard Biesheuvel > > Reviewed-by: Fangrui Song > > Signed-off-by: Arvind Sankar > > --- > > arch/x8

Re: [PATCH 1/3] lib: Add a generic copy_oldmem_page()

2020-07-15 Thread Ard Biesheuvel
On Mon, 13 Jul 2020 at 16:06, Christoph Hellwig wrote: > > On Fri, Jul 10, 2020 at 08:55:42PM -0700, Palmer Dabbelt wrote: > > +ssize_t copy_oldmem_page(unsigned long pfn, char *buf, > > + size_t csize, unsigned long offset, > > + int userbuf) > > +{ > >

Re: [PATCH] arch/x86/boot: Don't add the EFI stub to targets

2020-07-15 Thread Ard Biesheuvel
into efi-obj-y. > > [0] See scripts/Makefile.build near the end: > # Create directories for object files if they do not exist > > Signed-off-by: Arvind Sankar Acked-by: Ard Biesheuvel > --- > arch/x86/boot/compressed/Makefile | 4 ++-- > 1 file changed, 2

Re: [PATCH v3 2/7] x86/boot/compressed: Force hidden visibility for all symbol references

2020-07-14 Thread Ard Biesheuvel
On Tue, 14 Jul 2020 at 12:21, Sedat Dilek wrote: > > On Mon, Jun 29, 2020 at 4:09 PM Arvind Sankar wrote: > > > > From: Ard Biesheuvel > > > > Eliminate all GOT entries in the decompressor binary, by forcing hidden > > visibility for all symbol re

Re: arm-linux-gnueabi-ld: section .rodata VMA overlaps section .bss VMA

2020-07-11 Thread Ard Biesheuvel
On Sat, 11 Jul 2020 at 19:03, Arnd Bergmann wrote: > > On Sat, Jul 11, 2020 at 5:00 PM Ard Biesheuvel wrote: > > On Sat, 11 Jul 2020 at 15:30, Russell King - ARM Linux admin > > wrote: > > > > > > I doubt anyone is going to fix this; it's an XIP kerne

Re: arm-linux-gnueabi-ld: section .rodata VMA overlaps section .bss VMA

2020-07-11 Thread Ard Biesheuvel
(+ Arnd) On Sat, 11 Jul 2020 at 15:30, Russell King - ARM Linux admin wrote: > > I doubt anyone is going to fix this; it's an XIP kernel, and it looks > like the .data and .rodata sections are correctly placed as per the > configuration, but for some reason the .text (and sections that follow) >

Re: [PATCH v2] efi: avoid error message when booting under Xen

2020-07-10 Thread Ard Biesheuvel
ixes: 38ac0287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes when > mapping the FB") > Signed-off-by: Juergen Gross Acked-by: Ard Biesheuvel > --- > drivers/video/fbdev/efifb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [PATCH] efi: avoid error message when booting under Xen

2020-07-10 Thread Ard Biesheuvel
On Fri, 10 Jul 2020 at 16:38, Jürgen Groß wrote: > > On 10.07.20 15:27, Ard Biesheuvel wrote: > > On Fri, 10 Jul 2020 at 13:17, Bartlomiej Zolnierkiewicz > > wrote: > >> > >> > >> [ added EFI Maintainer & ML to Cc: ] > >>

Re: [PATCH] efi: avoid error message when booting under Xen

2020-07-10 Thread Ard Biesheuvel
On Fri, 10 Jul 2020 at 13:17, Bartlomiej Zolnierkiewicz wrote: > > > [ added EFI Maintainer & ML to Cc: ] > > Hi, > > On 7/9/20 11:17 AM, Jürgen Groß wrote: > > On 28.06.20 10:50, Jürgen Groß wrote: > >> Ping? > >> > >> On 10.06.20 16:10, Juergen Gross wrote: > >>> efifb_probe() will issue an

[GIT PULL] EFI fixes for v5.8-rc

2020-07-09 Thread Ard Biesheuvel
anups from Arvind -------- Ard Biesheuvel (2): efi/efivars: Expose RT service availability via efivars abstraction efi: Revert "efi/x86: Fix build with gcc 4" Arvind Sankar (2): efi/x86: Remove unused variables efi

Re: [PATCH] arm64/module-plts: Consider the special case where plt_max_entries is 0

2020-07-09 Thread Ard Biesheuvel
On Thu, 9 Jul 2020 at 09:50, 彭浩(Richard) wrote: > > On Wed, 8 Jul 2020 at 13:03, 彭浩(Richard) wrote: > >> > >> > >> On Tue, Jul 07, 2020 at 07:46:08AM -0400, Peng Hao wrote: > >> >> If plt_max_entries is 0, a warning is triggered. > >> >> WARNING: CPU: 200 PID: 3000 at

Re: [PATCH] efi/libstub: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER should not default to yes

2020-07-09 Thread Ard Biesheuvel
On Thu, 25 Jun 2020 at 19:11, Ard Biesheuvel wrote: > > On Tue, 23 Jun 2020 at 17:09, Geert Uytterhoeven > wrote: > > > > EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER is deprecated, so it should not > > be enabled by default. > > > > In light of commit 4da0b2b7e6

Re: [PATCH v3 1/2] tpm: tis: add support for MMIO TPM on SynQuacer

2020-07-08 Thread Ard Biesheuvel
pported, and so we'll need to provide a separate module > that take this into account. > > Signed-off-by: Ard Biesheuvel > Signed-off-by: Masahisa Kojima Hello Masahisa, This looks fine to me, but I won't be able to test it any time soon, unfortunately. One suggestion: cou

Re: [PATCH] arm64/module-plts: Consider the special case where plt_max_entries is 0

2020-07-08 Thread Ard Biesheuvel
On Wed, 8 Jul 2020 at 13:03, 彭浩(Richard) wrote: > > > On Tue, Jul 07, 2020 at 07:46:08AM -0400, Peng Hao wrote: > >> If plt_max_entries is 0, a warning is triggered. > >> WARNING: CPU: 200 PID: 3000 at arch/arm64/kernel/module-plts.c:97 > >> module_emit_plt_entry+0xa4/0x150 > > > > Which kernel

Re: [PATCH] arm64/module-plts: Consider the special case where plt_max_entries is 0

2020-07-08 Thread Ard Biesheuvel
On Wed, 8 Jul 2020 at 11:25, Will Deacon wrote: > > [+Ard] > > On Tue, Jul 07, 2020 at 07:46:08AM -0400, Peng Hao wrote: > > If plt_max_entries is 0, a warning is triggered. > > WARNING: CPU: 200 PID: 3000 at arch/arm64/kernel/module-plts.c:97 > > module_emit_plt_entry+0xa4/0x150 > > Which

Re: [RFC PATCH v2 00/11] Add UEFI support for RISC-V

2020-07-07 Thread Ard Biesheuvel
On Mon, 6 Jul 2020 at 20:26, Atish Patra wrote: > > This series adds UEFI support for RISC-V. > > Linux kernel: 5.8-rc4 > U-Boot: master > OpenSBI: master > > Patch 1-6 are preparatory patches that fixes some of the geric efi and riscv > issues. > > Patch 7-9 adds the efi stub support for RISC-V

Re: [PATCH v2] arm64/module: Optimize module load time by optimizing PLT counting

2020-07-04 Thread Ard Biesheuvel
On Sat, 4 Jul 2020 at 14:09, Will Deacon wrote: > > On Fri, Jul 03, 2020 at 05:47:24PM -0700, Saravana Kannan wrote: > > On Thu, Jul 2, 2020 at 8:30 AM Ard Biesheuvel wrote: > > > On Tue, 23 Jun 2020 at 03:27, Saravana Kannan > > > wrote: > > > > di

Re: [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-07-02 Thread Ard Biesheuvel
On Thu, 2 Jul 2020 at 20:21, Ard Biesheuvel wrote: > > On Thu, 2 Jul 2020 at 19:50, Eric Biggers wrote: > > > > [+linux-wireless, Marcel Holtmann, and Denis Kenzior] > > > > On Thu, Jul 02, 2020 at 12:19:44PM +0200, Ard Biesheuvel wrote: > > > Remov

Re: [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-07-02 Thread Ard Biesheuvel
On Thu, 2 Jul 2020 at 19:50, Eric Biggers wrote: > > [+linux-wireless, Marcel Holtmann, and Denis Kenzior] > > On Thu, Jul 02, 2020 at 12:19:44PM +0200, Ard Biesheuvel wrote: > > Remove the generic ecb(arc4) skcipher, which is slightly cumbersome from > > a maintenance pe

Re: [PATCH v2] arm64/module: Optimize module load time by optimizing PLT counting

2020-07-02 Thread Ard Biesheuvel
40 > IPA 809763 > audio 460616 > gpu 652720 > > Total time to load all these modules: 247 > > Time saved during boot for just these 6 modules: 390 ms >

[RFC PATCH 2/7] staging/rtl8192u: switch to RC4 library interface

2020-07-02 Thread Ard Biesheuvel
Switch to the ARC4 library interface, to remove the pointless dependency on the skcipher API, from which we will hopefully be able to drop ecb(arc4) skcipher support. Signed-off-by: Ard Biesheuvel --- drivers/staging/rtl8192u/Kconfig | 1 + drivers/staging/rtl8192u

[RFC PATCH 0/7] crypto: get rid of ecb(arc4)

2020-07-02 Thread Ard Biesheuvel
verdev.osuosl.org Cc: linux-...@vger.kernel.org Ard Biesheuvel (7): staging/rtl8192e: switch to RC4 library interface staging/rtl8192u: switch to RC4 library interface SUNRPC: remove RC4-HMAC-MD5 support from KerberosV crypto: remove ARC4 support from the skcipher API crypto: n2 - remo

[RFC PATCH 1/7] staging/rtl8192e: switch to RC4 library interface

2020-07-02 Thread Ard Biesheuvel
Switch to the ARC4 library interface, to remove the pointless dependency on the skcipher API, from which we will hopefully be able to drop ecb(arc4) skcipher support. Signed-off-by: Ard Biesheuvel --- drivers/staging/rtl8192e/Kconfig | 4 +- drivers/staging/rtl8192e

[RFC PATCH 7/7] crypto: tcrypt - remove ecb(arc4) testing/benchmarking support

2020-07-02 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- crypto/tcrypt.c | 21 +-- crypto/testmgr.c | 7 --- crypto/testmgr.h | 62 3 files changed, 1 insertion(+), 89 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index ba0b7702f2e9..72828c4acd3a 100644 --- a/crypto/tcrypt.c

[RFC PATCH 6/7] crypto: bcm-iproc - remove ecb(arc4) support

2020-07-02 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- drivers/crypto/bcm/cipher.c | 96 +--- drivers/crypto/bcm/cipher.h | 1 - drivers/crypto/bcm/spu.c| 23 + drivers/crypto/bcm/spu.h| 1 - drivers/crypto/bcm/spu2.c | 12 +-- drivers/crypto/bcm/spu2.h | 1 - 6 files changed, 6

[RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-07-02 Thread Ard Biesheuvel
we have in the tree, we can safely drop this code now it no longer has any users. Signed-off-by: Ard Biesheuvel --- crypto/Kconfig | 12 crypto/Makefile | 1 - crypto/arc4.c| 76

[RFC PATCH 5/7] crypto: n2 - remove ecb(arc4) support

2020-07-02 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- drivers/crypto/n2_core.c | 46 1 file changed, 46 deletions(-) diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c index 6a828bbecea4..c347e58cd9a1 100644 --- a/drivers/crypto/n2_core.c +++ b/drivers/crypto/n2_core.c @@ -662,7

[RFC PATCH 3/7] SUNRPC: remove RC4-HMAC-MD5 support from KerberosV

2020-07-02 Thread Ard Biesheuvel
interoperability with Windows NT/2000 systems that have not received any updates since 2008 (but are connected to a network nonetheless) [0] https://tools.ietf.org/html/rfc4757 [1] https://tools.ietf.org/html/rfc8429 Signed-off-by: Ard Biesheuvel --- include/linux/sunrpc/gss_krb5.h | 11

Re: [patch 13/13] Remove (now unused) EFI_UV1_MEMMAP from efi.h

2020-07-01 Thread Ard Biesheuvel
On Wed, 1 Jul 2020 at 16:18, wrote: > > With UV1 support removed, EFI_UV1_MEMMAP is no longer used. > > Signed-off-by: Steve Wahl Reviewed-by: Ard Biesheuvel > --- > arch/x86/include/asm/efi.h | 20 ++-- > 1 file changed, 2 insertions(+), 18 deletions(

Re: [patch 12/13] Remove uv bios and efi code related to (now unused) EFI_UV1_MEMMAP

2020-07-01 Thread Ard Biesheuvel
On Wed, 1 Jul 2020 at 16:18, wrote: > > With UV1 removed, EFI_UV1_MEMMAP is not used. Remove code used by it > in arch/x86/platform/uv/bios_uv.c and turn off code in > arch/x86/platform/efi/efi.c that referenced this code. > > Signed-off-by: Steve Wahl Reviewed-

Re: [patch 11/13] Remove references to no-longer-used efi_have_uv1_memmap()

2020-07-01 Thread Ard Biesheuvel
On Wed, 1 Jul 2020 at 16:18, wrote: > > In removing UV1 support, efi_have_uv1_memmap is no longer used. > > Signed-off-by: Steve Wahl Reviewed-by: Ard Biesheuvel > --- > arch/x86/kernel/kexec-bzimage64.c |9 - > arch/x86/platform/efi/efi.c | 14 +++--

Re: [patch 10/13] Delete SGI UV1 detection.

2020-07-01 Thread Ard Biesheuvel
On Wed, 1 Jul 2020 at 16:18, wrote: > > As a part of UV1 platform removal, don't try to recognize the platform > through DMI to set the EFI_UV1_MEMMAP bit. > > Signed-off-by: Steve Wahl Reviewed-by: Ard Biesheuvel > --- > arch/x86/platform/efi/quirks.c | 23 ---

Re: [patch 09/13] Remove efi=old_map command line option

2020-07-01 Thread Ard Biesheuvel
On Wed, 1 Jul 2020 at 16:18, wrote: > > As a part of UV1 platform removal, delete the efi=old_map option, > which should no longer be needed. > > Signed-off-by: Steve Wahl Noting that the diffstat does not reflect the patch, but this is explained in the cover letter. Acked-by:

Re: [PATCH v3 7/7] x86/boot: Check that there are no runtime relocations

2020-07-01 Thread Ard Biesheuvel
On Wed, 1 Jul 2020 at 01:28, Arvind Sankar wrote: > > On Tue, Jun 30, 2020 at 03:00:43PM -0700, Fangrui Song wrote: > > * Ard Biesheuvel > > > On Tue, 30 Jun 2020 at 01:34, Fangrui Song wrote: > > > > If the executable is purely static, it does not need to hav

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-30 Thread Ard Biesheuvel
On Tue, 30 Jun 2020 at 20:53, Peter Jones wrote: > > On Tue, Jun 16, 2020 at 11:08:38AM +0200, Ard Biesheuvel wrote: > > (cc Matthew and Peter) > > > > On Tue, 16 Jun 2020 at 01:28, Tyler Hicks > > wrote: > > > > > > Require that the TCG

Re: [PATCH v3 7/7] x86/boot: Check that there are no runtime relocations

2020-06-30 Thread Ard Biesheuvel
On Tue, 30 Jun 2020 at 01:34, Fangrui Song wrote: > > On 2020-06-29, Ard Biesheuvel wrote: > >On Mon, 29 Jun 2020 at 19:37, Fangrui Song wrote: > >> > >> On 2020-06-29, Arvind Sankar wrote: > >> >On Mon, Jun 29, 2020 at 09:20:31AM -0700, Kees Cook wr

Re: [PATCH v4 05/17] ctype: Work around Clang -mbranch-protection=none bug

2020-06-29 Thread Ard Biesheuvel
On Mon, 29 Jun 2020 at 17:06, Kees Cook wrote: > > On Mon, Jun 29, 2020 at 10:15:47AM +0200, Ard Biesheuvel wrote: > > On Mon, 29 Jun 2020 at 08:18, Kees Cook wrote: > > > > > > In preparation for building efi/libstub with -mbranch-protection=none > > >

Re: [PATCH v4 05/17] ctype: Work around Clang -mbranch-protection=none bug

2020-06-29 Thread Ard Biesheuvel
t files without code[2]. > > [1] > https://lore.kernel.org/lkml/CAMj1kXHck12juGi=E=p4hwp_8vqhq+-x3vbmc3tgerwdq-x...@mail.gmail.com > [2] https://bugs.llvm.org/show_bug.cgi?id=46480 > > Cc: Ard Biesheuvel > Cc: Will Deacon > Cc: Dave Martin > Cc: clang-built-li...@g

Re: [PATCH v3 7/7] x86/boot: Check that there are no runtime relocations

2020-06-29 Thread Ard Biesheuvel
On Mon, 29 Jun 2020 at 19:37, Fangrui Song wrote: > > On 2020-06-29, Arvind Sankar wrote: > >On Mon, Jun 29, 2020 at 09:20:31AM -0700, Kees Cook wrote: > >> On Mon, Jun 29, 2020 at 06:11:59PM +0200, Ard Biesheuvel wrote: > >> > On Mon, 29 Ju

Re: [PATCH v3 1/7] x86/boot/compressed: Move .got.plt entries out of the .got section

2020-06-29 Thread Ard Biesheuvel
On Mon, 29 Jun 2020 at 17:50, Arvind Sankar wrote: > > On Mon, Jun 29, 2020 at 08:48:05AM -0700, Kees Cook wrote: > > On Mon, Jun 29, 2020 at 10:09:22AM -0400, Arvind Sankar wrote: > > > > This is also being done on arm64, and the section was specified slightly > > differently (with INFO) which

Re: [PATCH v3 7/7] x86/boot: Check that there are no runtime relocations

2020-06-29 Thread Ard Biesheuvel
ions in the object files. > > > > Drop the tests for -fPIE compiler option and -pie linker option, as they > > are available in all supported gcc and binutils versions (as well as > > clang and lld). > > > > Signed-off-by: Arvind Sankar > > Reviewed-by: Ar

Re: [GIT PULL] EFI fixes

2020-06-28 Thread Ard Biesheuvel
On Sun, 28 Jun 2020 at 20:57, Linus Torvalds wrote: > > On Sun, Jun 28, 2020 at 11:26 AM Ingo Molnar wrote: > > > > - Fix build regression on v4.8 and older > > Interesting. > > It's perhaps yet another reason to just skip gcc-4.8 too, since > apparently 4.9 works. > +1 > gcc-4.9 really has a

Re: [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-27 Thread Ard Biesheuvel
On Sat, 27 Jun 2020 at 00:03, Ard Biesheuvel wrote: > > On Fri, 26 Jun 2020 at 23:56, Atish Patra wrote: > > > > On Thu, Jun 25, 2020 at 7:43 PM Heinrich Schuchardt > > wrote: > > > > > > On 6/26/20 1:45 AM, Atish Patra wrote: > > > > 32b

Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page

2020-06-27 Thread Ard Biesheuvel
On Sat, 27 Jun 2020 at 09:57, Christoph Hellwig wrote: > > On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, > > > VMALLOC_END, > > > + GFP_KERNEL, PAGE

Re: [PATCH 1/2] kbuild: remove cc-option test of -fno-stack-protector

2020-06-27 Thread Ard Biesheuvel
ile adds -fno-stack-protector twice, first > unconditionally, and second conditionally. I removed the second one. > > Signed-off-by: Masahiro Yamada Acked-by: Ard Biesheuvel > --- > > Documentation/kbuild/kconfig-language.rst | 4 ++-- > Makefile

Re: [PATCH 2/2] kbuild: remove cc-option test of -ffreestanding

2020-06-27 Thread Ard Biesheuvel
compilers know -ffreestanding. > > I confirmed GCC 4.8 and Clang manuals document this option. > > Get rid of cc-option from -ffreestanding. > > Signed-off-by: Masahiro Yamada Acked-by: Ard Biesheuvel > --- > > arch/s390/Makefile| 2 +- > arch/x8

Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page

2020-06-27 Thread Ard Biesheuvel
On Thu, 18 Jun 2020 at 08:44, Christoph Hellwig wrote: > > Use PAGE_KERNEL_ROX directly instead of allocating RWX and setting the > page read-only just after the allocation. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/probes/kprobes.c | 12 +++- > 1 file changed, 3

Re: [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds

2020-06-26 Thread Ard Biesheuvel
On Fri, 26 Jun 2020 at 23:56, Atish Patra wrote: > > On Thu, Jun 25, 2020 at 7:43 PM Heinrich Schuchardt > wrote: > > > > On 6/26/20 1:45 AM, Atish Patra wrote: > > > 32bit gcc doesn't support modulo operation on 64 bit data. It results in > > > a __umoddi3 error while building EFI for 32 bit.

Re: [PATCH v3 08/15] arm64: kvm: Split hyp/switch.c to VHE/nVHE

2020-06-25 Thread Ard Biesheuvel
On Thu, 25 Jun 2020 at 10:16, Marc Zyngier wrote: > > On 2020-06-25 06:03, kernel test robot wrote: > > Hi David, > > > > Thank you for the patch! Perhaps something to improve: > > > > [auto build test WARNING on linus/master] > > [also build test WARNING on v5.8-rc2 next-20200624] > > [cannot

Re: [PATCH] efi/libstub: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER should not default to yes

2020-06-25 Thread Ard Biesheuvel
On Tue, 23 Jun 2020 at 17:09, Geert Uytterhoeven wrote: > > EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER is deprecated, so it should not > be enabled by default. > > In light of commit 4da0b2b7e67524cc ("efi/libstub: Re-enable command > line initrd loading for x86"), keep the default for X86. > >

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 20:23, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 19:16, Dave Martin wrote: > > > > On Wed, Jun 24, 2020 at 06:40:48PM +0200, Ard Biesheuvel wrote: > > > On Wed, 24 Jun 2020 at 18:29, Dave Martin wrote: > > > > > > >

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 19:16, Dave Martin wrote: > > On Wed, Jun 24, 2020 at 06:40:48PM +0200, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 18:29, Dave Martin wrote: > > > > > > On Wed, Jun 24, 2020 at 05:48:41PM +0200, Ard Biesheuvel wrote: > > > &g

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 18:29, Dave Martin wrote: > > On Wed, Jun 24, 2020 at 05:48:41PM +0200, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 17:45, Kees Cook wrote: > > > > > > On Wed, Jun 24, 2020 at 05:31:06PM +0200, Ard Biesheuvel wrote: > > > &g

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 17:45, Kees Cook wrote: > > On Wed, Jun 24, 2020 at 05:31:06PM +0200, Ard Biesheuvel wrote: > > On Wed, 24 Jun 2020 at 17:21, Kees Cook wrote: > > > > > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > > > > I'm

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 17:21, Kees Cook wrote: > > On Wed, Jun 24, 2020 at 12:46:32PM +0200, Ard Biesheuvel wrote: > > I'm not sure if there is a point to having PAC and/or BTI in the EFI > > stub, given that it runs under the control of the firmware, with its > >

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-24 Thread Ard Biesheuvel
On Wed, 24 Jun 2020 at 12:44, Will Deacon wrote: > > On Tue, Jun 23, 2020 at 09:44:11PM -0700, Kees Cook wrote: > > On Tue, Jun 23, 2020 at 08:31:42PM -0700, 'Fangrui Song' via Clang Built > > Linux wrote: > > > On 2020-06-23, Kees Cook wrote: > > > > In preparation for adding

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Ard Biesheuvel
On Tue, 23 Jun 2020 at 23:06, Kees Cook wrote: > > On Tue, Jun 23, 2020 at 04:59:39PM +0200, Ard Biesheuvel wrote: > > On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > > > > > On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > > > > We d

Re: [PATCH v2 2/2] arm64/build: Warn on orphan section placement

2020-06-23 Thread Ard Biesheuvel
On Tue, 23 Jun 2020 at 16:52, Will Deacon wrote: > > On Mon, Jun 22, 2020 at 01:58:15PM -0700, Kees Cook wrote: > > We don't want to depend on the linker's orphan section placement > > heuristics as these can vary between linkers, and may change between > > versions. All sections need to be

[tip: efi/urgent] efi/libstub: arm: Print CPU boot mode and MMU state at boot

2020-06-19 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 2a55280a3675203496d302463b941834228b9875 Gitweb: https://git.kernel.org/tip/2a55280a3675203496d302463b941834228b9875 Author:Ard Biesheuvel AuthorDate:Sun, 07 Jun 2020 15:41:35 +02:00

[tip: efi/urgent] efi/libstub: arm: Omit arch specific config table matching array on arm64

2020-06-19 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 62956be8f95b93e9f91ffe2e5aa9c0e411af5a14 Gitweb: https://git.kernel.org/tip/62956be8f95b93e9f91ffe2e5aa9c0e411af5a14 Author:Ard Biesheuvel AuthorDate:Tue, 16 Jun 2020 12:53:30 +02:00

[tip: efi/urgent] efi/libstub: Fix missing-prototype warning for skip_spaces()

2020-06-19 Thread tip-bot2 for Ard Biesheuvel
The following commit has been merged into the efi/urgent branch of tip: Commit-ID: 24552d10339f13d2174e013002da3ed90e26adda Gitweb: https://git.kernel.org/tip/24552d10339f13d2174e013002da3ed90e26adda Author:Ard Biesheuvel AuthorDate:Mon, 15 Jun 2020 12:31:14 +02:00

[GIT PULL] EFI fixes for v5.8

2020-06-18 Thread Ard Biesheuvel
introduced stub routines - Allow support for SSDT overrides via EFI variables to be disabled - Report CPU mode and MMU state upon entry for 32-bit ARM - Use the correct stack pointer alignment when entering from mixed mode Ard Biesheuvel (3

Re: [PATCH] Make it possible to disable efivar_ssdt entirely

2020-06-17 Thread Ard Biesheuvel
On Tue, 16 Jun 2020 at 00:47, Ard Biesheuvel wrote: > > On Mon, 15 Jun 2020 at 22:24, Peter Jones wrote: > > > > In most cases, such as CONFIG_ACPI_CUSTOM_DSDT and > > CONFIG_ACPI_TABLE_UPGRADE, boot-time modifications to firmware tables > > are tied to specif

Re: [PATCH] acpi: disallow loading configfs acpi tables when locked down

2020-06-17 Thread Ard Biesheuvel
On Wed, 17 Jun 2020 at 00:21, Jason A. Donenfeld wrote: > > Hi Rafael, Len, > > Looks like I should have CC'd you on this patch. This is probably > something we should get into 5.8-rc2, so that it can then get put into > stable kernels, as some people think this is security sensitive. > Bigger

[PATCH] ACPI: avoid relocations for table signature array

2020-06-17 Thread Ard Biesheuvel
ept from __init code. Signed-off-by: Ard Biesheuvel --- drivers/acpi/tables.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 0e905c3d1645..ada36bc40c2b 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/table

Re: [PATCH v1] arm64/module: Optimize module load time by optimizing PLT counting

2020-06-17 Thread Ard Biesheuvel
boot time are we talking about here? It would be interesting to > know if there are bigger potential savings elsewhere. > Also, 'some module' vs 'some other module' doesn't really say anything. Please explain which modules and their sizes. > > This commit also disables the sorting

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-06-16 Thread Ard Biesheuvel
(cc Matthew and Peter) On Tue, 16 Jun 2020 at 01:28, Tyler Hicks wrote: > > Require that the TCG_PCR_EVENT2.digests.count value strictly matches the > value of TCG_EfiSpecIdEvent.numberOfAlgorithms in the event field of the > TCG_PCClientPCREvent event log header. Also require that >

Re: [PATCH 1/1] efi/libstub: Add libstub/random.c to the documentation tree

2020-06-16 Thread Ard Biesheuvel
UEFI Support > UEFI stub library functions > > Signed-off-by: Heinrich Schuchardt Acked-by: Ard Biesheuvel > --- > Documentation/driver-api/firmware/efi/index.rst | 4 > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/driver-api/fir

Re: [PATCH 1/1] efi/libstub: descriptions for stub helper functions

2020-06-16 Thread Ard Biesheuvel
On Tue, 16 Jun 2020 at 01:42, Heinrich Schuchardt wrote: > > Provide missing descriptions for EFI stub helper functions. > Adjust formatting of existing descriptions to kernel style. > > Signed-off-by: Heinrich Schuchardt Queued as a fix, thanks. > --- >

Re: [PATCH] Make it possible to disable efivar_ssdt entirely

2020-06-15 Thread Ard Biesheuvel
On Mon, 15 Jun 2020 at 22:24, Peter Jones wrote: > > In most cases, such as CONFIG_ACPI_CUSTOM_DSDT and > CONFIG_ACPI_TABLE_UPGRADE, boot-time modifications to firmware tables > are tied to specific Kconfig options. Currently this is not the case > for modifying the ACPI SSDT via the efivar_ssdt

Re: [PATCH v2 2/2] efi/libstub: refactor Makefile to not use lib-y syntax

2020-06-15 Thread Ard Biesheuvel
On Mon, 15 Jun 2020 at 16:15, Masahiro Yamada wrote: > > On Mon, Jun 15, 2020 at 7:41 PM Ard Biesheuvel wrote: > > > > On Mon, 15 Jun 2020 at 12:26, Ard Biesheuvel wrote: > > > > > > On Thu, 4 Jun 2020 at 04:20, Masahiro Yamada wrote: > > > >

Re: [PATCH v2 2/2] efi/libstub: refactor Makefile to not use lib-y syntax

2020-06-15 Thread Ard Biesheuvel
On Mon, 15 Jun 2020 at 12:26, Ard Biesheuvel wrote: > > On Thu, 4 Jun 2020 at 04:20, Masahiro Yamada wrote: > > > > Documentation/kbuild/makefiles.rst says: > > > > Use of lib-y is normally restricted to `lib/` and `arch/*/lib`. > > > > Thi

Re: [PATCH v2 2/2] efi/libstub: refactor Makefile to not use lib-y syntax

2020-06-15 Thread Ard Biesheuvel
On Thu, 4 Jun 2020 at 04:20, Masahiro Yamada wrote: > > Documentation/kbuild/makefiles.rst says: > > Use of lib-y is normally restricted to `lib/` and `arch/*/lib`. > > This is because lib-y is inteded to be hooked to KBUILD_VMLINUX_LIBS, > which is passed down to scripts/link-vmlinux.sh. > >

Re: [PATCH] efi: Replace zero-length array and use struct_size() helper

2020-06-15 Thread Ard Biesheuvel
On Fri, 29 May 2020 at 19:32, Gustavo A. R. Silva wrote: > > On Fri, May 29, 2020 at 01:31:54AM -0700, Kees Cook wrote: > > On Wed, May 27, 2020 at 12:14:25PM -0500, Gustavo A. R. Silva wrote: > > > The current codebase makes use of the zero-length array language > > > extension to the C90

Re: [PATCH 0/2] Couple of efivarfs fixes

2020-06-15 Thread Ard Biesheuvel
On Thu, 28 May 2020 at 21:49, Tony Luck wrote: > > 1) Some apps want to monitor changes in EFI variables, but reading the >file and comparing is inefficient. Just have Linnux update the >modification time when a file is written > > 2) A rate limited read can return -EINTR ... very

Re: [PATCH] efi/esrt: Fix reference count leak in esre_create_sysfs_entry.

2020-06-15 Thread Ard Biesheuvel
uct esre_entry *entry = to_entry(kobj); >list_del(>list); >kfree(entry); > } > > In this case, if we call both kobject_put() and kfree(), a double-free will > be introduced. > Thanks for the explanation Queued in efi/urgent. > On Fri, May 29, 2020

Re: [PATCH] efi/libstub: Fix build error with libstub

2020-06-10 Thread Ard Biesheuvel
On Wed, 10 Jun 2020 at 10:59, Nathan Chancellor wrote: > > On Wed, Jun 10, 2020 at 03:14:46PM +0800, Zhenzhong Duan wrote: > > Got below error during build: > > > > In file included from drivers/firmware/efi/libstub/efi-stub-helper.c:16:0: > > drivers/firmware/efi/libstub/efi-stub-helper.c:

Re: [PATCH v2 1/2] efi/libstub/arm64: link stub lib.a conditionally

2020-06-10 Thread Ard Biesheuvel
On Wed, 10 Jun 2020 at 09:58, Will Deacon wrote: > > On Thu, Jun 04, 2020 at 11:20:30AM +0900, Masahiro Yamada wrote: > > Since commit 799c43415442 ("kbuild: thin archives make default for > > all archs"), core-y is passed to the linker with --whole-archive. > > Hence, the whole of stub library

Re: [PATCH] efi/libstub: refactor Makefile to not use lib-y syntax

2020-06-03 Thread Ard Biesheuvel
On Wed, 3 Jun 2020 at 13:23, Masahiro Yamada wrote: > > On Wed, Jun 3, 2020 at 6:16 PM Ard Biesheuvel wrote: > > > > On Wed, 3 Jun 2020 at 11:15, Masahiro Yamada wrote: > > > > > > On Wed, Jun 3, 2020 at 6:02 PM Ard Biesheuvel wrote: > > > > >

Re: arm64 build issue and mainline crash (was Re: linux-next: Tree for Jun 3)

2020-06-03 Thread Ard Biesheuvel
On Wed, 3 Jun 2020 at 14:20, Stephen Rothwell wrote: > > Hi all, > > Just resending to get past the infradead.org mail filters (hopefully). > > On Wed, 3 Jun 2020 22:13:41 +1000 Stephen Rothwell > wrote: > > > > Hi John, > > > > On Wed, 3 Jun 2020 12:45:18 +0100 John Garry wrote: > > > > > >

Re: linux-next: arm64 build failed - aarch64-linux-gnu-ld: cannot find ./drivers/firmware/efi/libstub/lib.abuilt-in.a: No such file or directory

2020-06-03 Thread Ard Biesheuvel
On Wed, 3 Jun 2020 at 14:31, Naresh Kamboju wrote: > > arm64 build failed on Linux-next 20200603. > > make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=arm64 > CROSS_COMPILE=aarch64-linux-gnu- HOSTCC=gcc CC="sccache > aarch64-linux-gnu-gcc" O=build Image > # > aarch64-linux-gnu-ld: cannot

Re: [PATCH] efi/libstub: refactor Makefile to not use lib-y syntax

2020-06-03 Thread Ard Biesheuvel
On Wed, 3 Jun 2020 at 11:15, Masahiro Yamada wrote: > > On Wed, Jun 3, 2020 at 6:02 PM Ard Biesheuvel wrote: > > > > On Wed, 3 Jun 2020 at 10:59, Masahiro Yamada wrote: > > > > > > On Wed, Jun 3, 2020 at 5:45 PM Ard Biesheuvel wrote: > > > > >

<    1   2   3   4   5   6   7   8   9   10   >