Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-19 Thread Armin Schindler
On Tue, 19 Feb 2008, Andi Kleen wrote: On Tue, Feb 19, 2008 at 10:56:22AM +0100, Sam Ravnborg wrote: If noone in the isdn community step up and take some responsibility for the current isdn drivers in Linux then we should just delete them. So you're saying anything that has no active

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-19 Thread Armin Schindler
On Tue, 19 Feb 2008, Andi Kleen wrote: On Tue, Feb 19, 2008 at 10:56:22AM +0100, Sam Ravnborg wrote: If noone in the isdn community step up and take some responsibility for the current isdn drivers in Linux then we should just delete them. So you're saying anything that has no active

Re: [PATCH 18/30] isdn: eicon - get rid of a pointless vmalloc() return value cast

2007-08-24 Thread Armin Schindler
vmalloc() returns void*. No need to cast in drivers/isdn/hardware/eicon/platform.h::diva_os_malloc() Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: Armin Schindler <[EMAIL PROTECTED]> --- drivers/isdn/hardware/eicon/platform.h |2 +- 1 files changed, 1 insertions(+),

Re: [PATCH 18/30] isdn: eicon - get rid of a pointless vmalloc() return value cast

2007-08-24 Thread Armin Schindler
vmalloc() returns void*. No need to cast in drivers/isdn/hardware/eicon/platform.h::diva_os_malloc() Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Acked-by: Armin Schindler [EMAIL PROTECTED] --- drivers/isdn/hardware/eicon/platform.h |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH] Leak in eicon/idifunc.c

2007-06-07 Thread Armin Schindler
Hi, coverity spotted a possible leak in the idifunc.c file (bug id #1252), in um_new_card(), if the diva_user_mode_idi_create_adapter() fails, we dont free the memory allocated for card Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> Acked-by: Armin Schindler <[EMAIL PROTECTED]>

Re: [PATCH] isdn/diva: fix section mismatch

2007-06-07 Thread Armin Schindler
ed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Acked-by: Armin Schindler <[EMAIL PROTECTED]> --- drivers/isdn/hardware/eicon/divasfunc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2622-rc4.orig/drivers/isdn/hardware/eicon/divasfunc.c +++ linux-2622-rc4/drivers/i

Re: [PATCH] isdn/diva: fix section mismatch

2007-06-07 Thread Armin Schindler
-by: Randy Dunlap [EMAIL PROTECTED] Acked-by: Armin Schindler [EMAIL PROTECTED] --- drivers/isdn/hardware/eicon/divasfunc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2622-rc4.orig/drivers/isdn/hardware/eicon/divasfunc.c +++ linux-2622-rc4/drivers/isdn/hardware/eicon

[PATCH] Leak in eicon/idifunc.c

2007-06-07 Thread Armin Schindler
Hi, coverity spotted a possible leak in the idifunc.c file (bug id #1252), in um_new_card(), if the diva_user_mode_idi_create_adapter() fails, we dont free the memory allocated for card Signed-off-by: Eric Sesterhenn [EMAIL PROTECTED] Acked-by: Armin Schindler [EMAIL PROTECTED] --- linux-2.6

Re: [RFC: 2.6 patch] fix ISDN_CAPI<->ISDN_DIVAS

2007-03-29 Thread Armin Schindler
On Thu, 29 Mar 2007, Adrian Bunk wrote: > On Thu, Mar 29, 2007 at 01:06:12PM +0200, Armin Schindler wrote: > > On Sat, 24 Mar 2007, Adrian Bunk wrote: > > > On Sat, Mar 24, 2007 at 02:49:42PM +0100, Armin Schindler wrote: > > > > On Sat, 24 Mar 2007, Adrian Bunk

Re: [RFC: 2.6 patch] fix ISDN_CAPI<->ISDN_DIVAS

2007-03-29 Thread Armin Schindler
On Sat, 24 Mar 2007, Adrian Bunk wrote: > On Sat, Mar 24, 2007 at 02:49:42PM +0100, Armin Schindler wrote: > > On Sat, 24 Mar 2007, Adrian Bunk wrote: > > > Randy Dunlap reported in kernel Bugzilla #8241 the following compile > > > error with CONFIG_ISDN_

Re: [RFC: 2.6 patch] fix ISDN_CAPI-ISDN_DIVAS

2007-03-29 Thread Armin Schindler
On Sat, 24 Mar 2007, Adrian Bunk wrote: On Sat, Mar 24, 2007 at 02:49:42PM +0100, Armin Schindler wrote: On Sat, 24 Mar 2007, Adrian Bunk wrote: Randy Dunlap reported in kernel Bugzilla #8241 the following compile error with CONFIG_ISDN_CAPI=m, CONFIG_ISDN_DIVAS=y: -- snip

Re: [RFC: 2.6 patch] fix ISDN_CAPI-ISDN_DIVAS

2007-03-29 Thread Armin Schindler
On Thu, 29 Mar 2007, Adrian Bunk wrote: On Thu, Mar 29, 2007 at 01:06:12PM +0200, Armin Schindler wrote: On Sat, 24 Mar 2007, Adrian Bunk wrote: On Sat, Mar 24, 2007 at 02:49:42PM +0100, Armin Schindler wrote: On Sat, 24 Mar 2007, Adrian Bunk wrote: Randy Dunlap reported in kernel

Re: [RFC: 2.6 patch] fix ISDN_CAPI<->ISDN_DIVAS

2007-03-24 Thread Armin Schindler
On Sat, 24 Mar 2007, Adrian Bunk wrote: > Randy Dunlap reported in kernel Bugzilla #8241 the following compile > error with CONFIG_ISDN_CAPI=m, CONFIG_ISDN_DIVAS=y: > > <-- snip --> > > ... > WARNING: "DIVA_DIDD_Read" [drivers/isdn/hardware/eicon/divacapi.ko] undefined! > WARNING:

Re: [RFC: 2.6 patch] fix ISDN_CAPI-ISDN_DIVAS

2007-03-24 Thread Armin Schindler
On Sat, 24 Mar 2007, Adrian Bunk wrote: Randy Dunlap reported in kernel Bugzilla #8241 the following compile error with CONFIG_ISDN_CAPI=m, CONFIG_ISDN_DIVAS=y: -- snip -- ... WARNING: DIVA_DIDD_Read [drivers/isdn/hardware/eicon/divacapi.ko] undefined! WARNING: DIVA_DIDD_Read

[PATCH] drivers/isdn/hardware/eicon/: remove unused header files

2007-03-11 Thread Armin Schindler
Hi all, as pointed out by Robert P. J. Day, here is a patch to remove unused header files from Eicon/Dialogic ISDN driver. Signed-off-by: Armin Schindler <[EMAIL PROTECTED]> --- diff -Nur linux-2.6.20.1.orig/drivers/isdn/hardware/eicon/dbgioctl.h linux-2.6.20.1/drivers/isdn/hardware

[PATCH] drivers/isdn/hardware/eicon/: remove unused header files

2007-03-11 Thread Armin Schindler
Hi all, as pointed out by Robert P. J. Day, here is a patch to remove unused header files from Eicon/Dialogic ISDN driver. Signed-off-by: Armin Schindler [EMAIL PROTECTED] --- diff -Nur linux-2.6.20.1.orig/drivers/isdn/hardware/eicon/dbgioctl.h linux-2.6.20.1/drivers/isdn/hardware/eicon

Re: dead(?) header files in the source tree

2007-03-10 Thread Armin Schindler
On Fri, 9 Mar 2007, Robert P. J. Day wrote: > > following up on an earlier post by stefan richter, i wrote a > brute-force little script that scanned the source tree, looking for > header files that weren't included from *anywhere* in the tree. what > turned up was the following: > >

Re: dead(?) header files in the source tree

2007-03-10 Thread Armin Schindler
On Fri, 9 Mar 2007, Robert P. J. Day wrote: following up on an earlier post by stefan richter, i wrote a brute-force little script that scanned the source tree, looking for header files that weren't included from *anywhere* in the tree. what turned up was the following:

Re: [2.6 patch] drivers/isdn/: make some code static

2005-04-19 Thread Armin Schindler
On Tue, 19 Apr 2005, Adrian Bunk wrote: > This patch makes some needlessly global code static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> For the hardware/eicon part: Signed-off-by: Armin Schindler <[EMAIL PROTECTED]> > --- > > drivers/isdn/ha

Re: [2.6 patch] drivers/isdn/: make some code static

2005-04-19 Thread Armin Schindler
On Tue, 19 Apr 2005, Adrian Bunk wrote: This patch makes some needlessly global code static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] For the hardware/eicon part: Signed-off-by: Armin Schindler [EMAIL PROTECTED] --- drivers/isdn/hardware/eicon/dadapter.c |2 +- drivers/isdn

[PATCH] 2.6 ISDN Eicon driver: code cleanups

2005-02-11 Thread Armin Schindler
bincdAai5MuZi.bin Description: Binary data

[PATCH] 2.6 ISDN Eicon driver: convert to pci_register_driver

2005-02-11 Thread Armin Schindler
Description: convert from pci_module_init to pci_register_driver Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Armin Schindler <[EMAIL PROTECTED]> diff -u linux.orig/drivers/isdn/hardware/eicon/divasmain.c linux/drivers/isdn/hardware/eicon/divasmain.c --

[PATCH] 2.6 ISDN Eicon driver: convert to pci_register_driver

2005-02-11 Thread Armin Schindler
Description: convert from pci_module_init to pci_register_driver Signed-off-by: Christophe Lucas [EMAIL PROTECTED] Signed-off-by: Armin Schindler [EMAIL PROTECTED] diff -u linux.orig/drivers/isdn/hardware/eicon/divasmain.c linux/drivers/isdn/hardware/eicon/divasmain.c --- linux.orig/drivers

[PATCH] 2.6 ISDN Eicon driver: code cleanups

2005-02-11 Thread Armin Schindler
bincdAai5MuZi.bin Description: Binary data

Re: RFC: [2.6 patch] Eicon: disable debuglib for modules

2005-02-09 Thread Armin Schindler
On Mon, 20 Dec 2004, Adrian Bunk wrote: > > > Is there a good reason why debuglib is enabled for modules? > > > > Yes. > > Without it, there would be no possibility to use the maintainance module > > to debug the isdn/card/capi interaction. > > > > > If not, I'd propose the patch below to

Re: RFC: [2.6 patch] Eicon: disable debuglib for modules

2005-02-09 Thread Armin Schindler
On Mon, 20 Dec 2004, Adrian Bunk wrote: Is there a good reason why debuglib is enabled for modules? Yes. Without it, there would be no possibility to use the maintainance module to debug the isdn/card/capi interaction. If not, I'd propose the patch below to disable it. I

Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-08 Thread Armin Schindler
On Wed, 9 Feb 2005, Adrian Bunk wrote: > On Sun, Feb 06, 2005 at 11:18:18AM +0100, Armin Schindler wrote: > > > Hi Adrian, > > Hi Armin, > > > thanks for the proposed patch. > > Making the functions static is a good idea, I will check and test this. > > R

Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-08 Thread Armin Schindler
On Wed, 9 Feb 2005, Adrian Bunk wrote: On Sun, Feb 06, 2005 at 11:18:18AM +0100, Armin Schindler wrote: Hi Adrian, Hi Armin, thanks for the proposed patch. Making the functions static is a good idea, I will check and test this. Removing some functions, especially from io.* and di

Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-06 Thread Armin Schindler
Hi Adrian, thanks for the proposed patch. Making the functions static is a good idea, I will check and test this. Removing some functions, especially from io.* and di.* is not good. These functions are mainly used with other sub-drivers which are not part of the kernel. I will check if they are

Re: [2.6 patch] drivers/isdn/hardware/eicon/: misc possible cleanups

2005-02-06 Thread Armin Schindler
Hi Adrian, thanks for the proposed patch. Making the functions static is a good idea, I will check and test this. Removing some functions, especially from io.* and di.* is not good. These functions are mainly used with other sub-drivers which are not part of the kernel. I will check if they are

[PATCH 3/3] 2.6 ISDN Eicon driver: remove unused code

2005-01-31 Thread Armin Schindler
Remove code from platform independent code, which is not used in Linux. Signed-off-by: Armin Schindler <[EMAIL PROTECTED]> diff -Nur linux.orig/drivers/isdn/hardware/eicon/io.c linux/drivers/isdn/hardware/eicon/io.c --- linux.orig/drivers/isdn/hardware/eicon/io.c 2005-01-31 12:33:10.120

[PATCH 2/3] 2.6 ISDN Eicon driver: vfree()

2005-01-31 Thread Armin Schindler
Removed check for NULL pointer before doing vfree(), it's done in vfree(). Signed-off-by: Armin Schindler <[EMAIL PROTECTED]> diff -Nur linux.orig/drivers/isdn/hardware/eicon/platform.h linux/drivers/isdn/hardware/eicon/platform.h --- linux.orig/drivers/isdn/hardware/eicon/platform.h 2

[PATCH 1/3] 2.6 ISDN Eicon driver: add missing uaccess

2005-01-31 Thread Armin Schindler
This patch adds asm/uaccess.h to files which uses copy_to/from_user() and adds the use of the drivers internal API call to copy_to/from_user() in platform independent code. Signed-off-by: Armin Schindler <[EMAIL PROTECTED]> diff -Nur linux.orig/drivers/isdn/hardware/eicon/divamnt.c

[PATCH 3/3] 2.6 ISDN Eicon driver: remove unused code

2005-01-31 Thread Armin Schindler
Remove code from platform independent code, which is not used in Linux. Signed-off-by: Armin Schindler [EMAIL PROTECTED] diff -Nur linux.orig/drivers/isdn/hardware/eicon/io.c linux/drivers/isdn/hardware/eicon/io.c --- linux.orig/drivers/isdn/hardware/eicon/io.c 2005-01-31 12:33:10.120377277

Checking 'hlt' instruction

2001-07-04 Thread Armin Schindler
Hi all, I have a problem with the startup of my 2.4.3 kernel on a STPC Atlas (486), it hangs on the 'hlt' check. With a standard BIOS it works, but I'm writing my own bootloader to remove the BIOS, which works pretty good so far. Only when I use the 'no-hlt' parameter the kernel boots. Can

Checking 'hlt' instruction

2001-07-04 Thread Armin Schindler
Hi all, I have a problem with the startup of my 2.4.3 kernel on a STPC Atlas (486), it hangs on the 'hlt' check. With a standard BIOS it works, but I'm writing my own bootloader to remove the BIOS, which works pretty good so far. Only when I use the 'no-hlt' parameter the kernel boots. Can

Re: [kbuild-devel] Dead symbol elimination, stage 1

2001-04-21 Thread Armin Schindler
On Thu, 19 Apr 2001, Kai Germaschewski wrote: > On Thu, 19 Apr 2001, Eric S. Raymond wrote: > > > The following patch cleans dead symbols out of the defconfigs in the 2.4.4pre4 > > source tree. It corrects a typo involving CONFIG_GEN_RTC. Another typo > > involving CONFIG_SOUND_YMPCI doesn't

Re: [kbuild-devel] Dead symbol elimination, stage 1

2001-04-21 Thread Armin Schindler
On Thu, 19 Apr 2001, Kai Germaschewski wrote: On Thu, 19 Apr 2001, Eric S. Raymond wrote: The following patch cleans dead symbols out of the defconfigs in the 2.4.4pre4 source tree. It corrects a typo involving CONFIG_GEN_RTC. Another typo involving CONFIG_SOUND_YMPCI doesn't need to be

lock_kernel() ?

2001-01-16 Thread Armin Schindler
Hi all, I'm writing a driver which uses also kernel_threads and file operations (/dev and /proc). I was not able yet to find out why and when to use [un]lock_kernel() Can someone please give me a hint where to find some infos in using lock_kernel() for 2.2 and 2.4. What exactly is/must be

lock_kernel() ?

2001-01-16 Thread Armin Schindler
Hi all, I'm writing a driver which uses also kernel_threads and file operations (/dev and /proc). I was not able yet to find out why and when to use [un]lock_kernel() Can someone please give me a hint where to find some infos in using lock_kernel() for 2.2 and 2.4. What exactly is/must be

SMP Problem with RTL8139

2001-01-14 Thread Armin Schindler
Hi all, I need help with the following problem on my Dual Pentium III 550Mhz with kernel 2.2.17 SMP and RTL8139 as eth0 : Sometimes the message eth0: RTL8139 Interrupt line blocked, status 1. appears which doesn't seem to cause problems, but yesterday the message eth0: SMP simultanous

SMP Problem with RTL8139

2001-01-14 Thread Armin Schindler
Hi all, I need help with the following problem on my Dual Pentium III 550Mhz with kernel 2.2.17 SMP and RTL8139 as eth0 : Sometimes the message eth0: RTL8139 Interrupt line blocked, status 1. appears which doesn't seem to cause problems, but yesterday the message eth0: SMP simultanous

Re: Patch: test13-pre2 fails "make xconfig" in isdn/Config.in

2000-12-16 Thread Armin Schindler
On Sat, 16 Dec 2000, Gunther Mayer wrote: This patch does not fix all problems in isdn/eicon. A bigger patch is on the way. Thanx, Armin > Hi Linus, > apply this patch if like to fix this obvious error > with "make xconfig" on plain tree: > ./tkparse < ../arch/i386/config.in >>

Re: doubly defined symbols in drivers/isdn/eicon (240t13p2)

2000-12-16 Thread Armin Schindler
The last Makefile changes broke some parts in the isdn tree. Patch is on the way. Armin On Sat, 16 Dec 2000, Rasmus Andersen wrote: > Hi. > > When I try to compile kernel 240test13pre2 I get the following: > > > rm -f eicon_drv.o > ld -m elf_i386 -r -o eicon_drv.o eicon.o divas.o > divas.o:

Re: doubly defined symbols in drivers/isdn/eicon (240t13p2)

2000-12-16 Thread Armin Schindler
The last Makefile changes broke some parts in the isdn tree. Patch is on the way. Armin On Sat, 16 Dec 2000, Rasmus Andersen wrote: Hi. When I try to compile kernel 240test13pre2 I get the following: rm -f eicon_drv.o ld -m elf_i386 -r -o eicon_drv.o eicon.o divas.o divas.o: In

Re: Patch: test13-pre2 fails make xconfig in isdn/Config.in

2000-12-16 Thread Armin Schindler
On Sat, 16 Dec 2000, Gunther Mayer wrote: This patch does not fix all problems in isdn/eicon. A bigger patch is on the way. Thanx, Armin Hi Linus, apply this patch if like to fix this obvious error with "make xconfig" on plain tree: ./tkparse ../arch/i386/config.in kconfig.tk

Q: tq_scheduler slower on SMP ?

2000-12-03 Thread Armin Schindler
Hi, with kernel 2.2.17 I need to have a function in my driver to handle some data. I used BH with tq_immediate, but I found out, that my function need to be called outside of interrupt context, but still as soon as I need it. So I decided to use the tq_scheduler queue and put my function on the

Q: tq_scheduler slower on SMP ?

2000-12-03 Thread Armin Schindler
Hi, with kernel 2.2.17 I need to have a function in my driver to handle some data. I used BH with tq_immediate, but I found out, that my function need to be called outside of interrupt context, but still as soon as I need it. So I decided to use the tq_scheduler queue and put my function on the

lock_kernel() in kernel thread

2000-10-13 Thread Armin Schindler
Hi, I was wondering why it is necessary for the usb_hub_thread() in drivers/usb/hub.c to have the big kernel lock with lock_kernel() ? What is it with lock_kernel() anyway ? extern __inline__ void lock_kernel(void) { #if 1 if (!++current->lock_depth) spin_lock(_flag);

lock_kernel() in kernel thread

2000-10-13 Thread Armin Schindler
Hi, I was wondering why it is necessary for the usb_hub_thread() in drivers/usb/hub.c to have the big kernel lock with lock_kernel() ? What is it with lock_kernel() anyway ? extern __inline__ void lock_kernel(void) { #if 1 if (!++current-lock_depth)