Re: [PATCH] perf symbols: turn dso__fprintf_symbols_by_name into void function

2021-03-08 Thread Arnaldo Carvalho de Melo
pos = rb_entry(nd, struct symbol_name_rb_node, rb_node); > fprintf(fp, "%s\n", pos->sym.name); > } > - > - return ret; The class__fprintf* functions follow the fprintf semantics, i.e. return how many bytes were printed, so the fix should instead be

Re: [PATCH] tools include: Add __sum16 and __wsum definitions.

2021-03-08 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 08, 2021 at 02:37:32PM +0100, Daniel Borkmann escreveu: > On 3/7/21 11:30 PM, Ian Rogers wrote: > > This adds definitions available in the uapi version. > > > > Explanation: > > In the kernel include of types.h the uapi version is included. > > In tools the uapi/linux/types.h and linux

[GIT PULL] perf tools changes for v5.12: take 2

2021-03-07 Thread Arnaldo Carvalho de Melo
ass gcc check on some 32-bit arches. - Update UAPI copies from the kernel sources. - Fix regression on feature detection 'make clean' target. Signed-off-by: Arnaldo Carvalho de Melo Andreas Wendleder (1): perf tools:

Re: [GIT PULL] perf tools fixes for v5.12

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 06, 2021 at 11:53:00AM -0300, Arnaldo Carvalho de Melo escreveu: > Hi Linus, > > Please consider pulling, > Arnaldo Carvalho de Melo (13): > tools headers UAPI: Update tools's copy of drm.h headers > tools headers UAPI: Sync drm/i915_drm.h

Re: [PATCH 1/2] Perf: Clean generated directory, other archs.

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 03, 2021 at 07:32:46PM +0100, Gon Solo escreveu: You forgot to add an explanation here and to add your: Signed-off-by: Gon Solo In this case a: Suggested-by: Arnaldo Carvalho de Melo Is also appropriate, since I pointed you in this direction. Please take a look at

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 06, 2021 at 08:02:24PM +0100, Martin Liška escreveu: > On 3/6/21 3:31 PM, Arnaldo Carvalho de Melo wrote: > > I see, it works only when pressing on source code lines: > > Hey. > > Yes, I forgot to explicitly mention that. Some requests, send the mail inline, not

Re: [PATCH RESEND WITH CCs v3 4/4] perf tools: determine if LR is the return address

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 06, 2021 at 09:55:32AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Mar 05, 2021 at 10:54:03AM +0200, James Clark escreveu: > > I've tested this patchset on a few different applications and have seen it > > significantly improve > > quality of frame

[GIT PULL] perf tools fixes for v5.12

2021-03-06 Thread Arnaldo Carvalho de Melo
fixing the build with MUSL libc. - Tighten snprintf() string precision to pass gcc check on some 32-bit arches. - Update UAPI copies from the kernel sources. - Fix regression on feature detection 'make clean' target. Signed-off-by: Arnaldo Carvalho de Melo ---

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 15, 2021 at 01:34:29PM +0100, Martin Liška escreveu: > On 2/12/21 9:34 PM, Arnaldo Carvalho de Melo wrote: > > Another idea is to, when requested, reserve one line at the bottom to > > show what is the source codefile:line for where the TUI cursor is, i.e. > >

Re: [PATCH] tool/perf/bench: fix misspellings using codespell

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 05, 2021 at 01:22:12AM -0800, menglong8.d...@gmail.com escreveu: > From: Xiong Zhenwu > > $ codespell ./tool/perf/bench > tools/perf/bench/inject-buildid.c:375: tihs ==> this > > Fix a typo found by codespell. Thanks, applied. - Arnaldo > Signed-off-by: Xiong Zhenwu > --- >

Re: [PATCH] perf config: add annotate.demangle{,_kernel}

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 11:08:12AM +0100, Martin Liška escreveu: > On 2/26/21 11:03 AM, Martin Liška wrote: > > On 2/23/21 8:49 PM, Arnaldo Carvalho de Melo wrote: > > > Please consider making this configurable (if not already) via > > > ~/.perfconfig, 'perf c

Re: [PATCH RESEND WITH CCs v3 4/4] perf tools: determine if LR is the return address

2021-03-06 Thread Arnaldo Carvalho de Melo
> > with any leaf call, for example an application with many different > > calls to malloc() would always omit the calling frame, even if it > > can be determined. > > > > ./perf record --call-graph fp ./a.out > > ./perf report > > > > currently

Re: [PATCH 1/3] perf skel: Remove some unused variables.

2021-03-06 Thread Arnaldo Carvalho de Melo
Em Sat, Mar 06, 2021 at 12:08:38AM -0800, Ian Rogers escreveu: > Fixes -Wall warnings. Thanks, tested all with: $ make BUILD_BPF_SKEL=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin Which makes me realize we need to turn both python3 and building the bpf skel to be the default...

Re: [PATCH] perf metricgroup: Fix segmentation fault for metrics with no pmu event

2021-03-05 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 03, 2021 at 08:28:23AM +, John Garry escreveu: > On 03/02/2021 00:46, Jin, Yao wrote: > > > > > > This should be fixed in v5.11-rc6 - please check it. > > > > > > 9c880c24cb0d perf metricgroup: Fix for metrics containing duration_time > > > > > > Thanks, > > > John > > > > Oh, I

Re: [PATCH v3 5/8] perf cs-etm: Support PID tracing in config

2021-03-05 Thread Arnaldo Carvalho de Melo
Em Sat, Feb 06, 2021 at 11:08:30PM +0800, Leo Yan escreveu: > From: Suzuki K Poulose > > If the kernel is running at EL2, the pid of a task is exposed via VMID > instead of the CONTEXTID. Add support for this in the perf tool. > > This patch respects user setting if user has specified any confi

Re: [PATCH v3 4/8] perf cs-etm: Fix bitmap for option

2021-03-05 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 09, 2021 at 09:58:55AM +0800, Leo Yan escreveu: > On Mon, Feb 08, 2021 at 01:46:41PM -0700, Mathieu Poirier wrote: > > On Sat, Feb 06, 2021 at 11:08:29PM +0800, Leo Yan wrote: > > > From: Suzuki K Poulose > > > > > > When set option with macros ETM_OPT_CTXTID and ETM_OPT_TS, it wrongl

Re: [PATCH] perf trace: Fix race in signal handling

2021-03-05 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 02, 2021 at 03:41:20PM +0100, Michael Petlan escreveu: > Since a lot of stuff happens before the SIGINT signal handler is registered > (scanning /proc/*, etc.), on bigger systems, such as Cavium Sabre CN99xx, > it may happen that first interrupt signal is lost and perf isn't correctly >

Re: [PATCH] perf report: Fix -F for branch & mem modes

2021-03-04 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 04, 2021 at 12:15:58PM +0530, Athira Rajeev escreveu: > > On 04-Mar-2021, at 11:59 AM, Ravi Bangoria > > wrote: > > > > perf report fails to add valid additional fields with -F when > > used with branch or mem modes. Fix it. > > > > Before patch: > > > > $ ./perf record -b > > $

Re: [PATCH] perf record: Fix continue profiling after draining the buffer

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 22, 2021 at 09:31:51AM +0800, Yang Jihong escreveu: > Hello, > > On 2021/2/19 1:09, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 18, 2021 at 10:20:53AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Feb 05, 2021 at 11:46:12AM +0100, Jiri Olsa escre

Re: [PATCH 1/2] perf test: Fix sample-parsing fails on non-x86 platforms

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 03, 2021 at 08:01:24AM -0800, kan.li...@linux.intel.com escreveu: > From: Kan Liang > > Executing perf test 27 fails on s390: > [root@t35lp46 perf]# ./perf test -Fv 27 > 27: Sample parsing > --- start --- > end > Sample parsing: FAILED! > [root@t35lp46 perf]# > > The

Re: [PATCH] perf report: Create option to disable raw event ordering

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 22, 2021 at 10:32:40PM +0100, Jiri Olsa escreveu: > On Fri, Feb 19, 2021 at 03:00:05PM +0800, Jin Yao wrote: > > Warning "dso not found" is reported when using "perf report -D". > > > > 66702781413407 0x32c0 [0x30]: PERF_RECORD_SAMPLE(IP, 0x2): 28177/28177: > > 0x55e493e00563 period:

Re: [PATCH 1/2] perf archive: Fix filtering of empty build-ids

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 02:50:20PM +0100, Jiri Olsa escreveu: > On Fri, Feb 19, 2021 at 11:09:32AM -0500, Nicholas Fraser wrote: > > A non-existent build-id used to be treated as all-zero SHA-1 hash. > > Build-ids are now variable width. A non-existent build-id is an empty > > string and "perf buil

Re: [PATCH] perf daemon: Fix compile error with Asan

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 12:06:46PM +0100, Jiri Olsa escreveu: > On Wed, Feb 24, 2021 at 04:14:38PM +0900, Namhyung Kim wrote: > > I'm seeing a build failure when build with address sanitizer. > > It seems we could write to the name[100] if the var is longer. > > > > $ make EXTRA_CFLAGS=-fsanitiz

Re: [PATCH] perf metric: remove unneeded semicolon

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 02:07:00PM +0800, Jiapeng Chong escreveu: > Fix the following coccicheck warnings: > > ./tools/perf/tests/parse-metric.c:101:2-3: Unneeded semicolon. Thanks, applied. - Arnaldo > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > tools/perf/tests/parse-

Re: [PATCH v2 1/2] libperf: Add perf_evlist__reset_id_hash()

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 05:12:37PM +0100, Jiri Olsa escreveu: > On Thu, Feb 25, 2021 at 12:51:47PM +0900, Namhyung Kim wrote: > > Add the perf_evlist__reset_id_hash() function as an internal function > > so that it can be called by perf to reset the hash table. This is > > necessary for perf stat

Re: [PATCH v9] perf stat: Fix wrong skipping for per-die aggregation

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 31, 2021 at 11:27:08PM +0100, Jiri Olsa escreveu: > On Thu, Jan 28, 2021 at 09:34:17AM +0800, Jin Yao wrote: > > Uncore becomes die-scope on Xeon Cascade Lake-AP and perf has supported > > --per-die aggregation yet. > > > > One issue is found in check_per_pkg() for uncore events runnin

Re: [PATCH 04/11] perf test: Fix cpu and thread map leaks in sw_clock_freq test

2021-03-03 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 02, 2021 at 02:03:05PM +0100, Jiri Olsa escreveu: > On Tue, Mar 02, 2021 at 10:50:15AM +0900, Namhyung Kim wrote: > > SNIP > > > > > err = -ENOMEM; > > > > pr_debug("Not enough memory to create thread/cpu maps\n"); > > > > - goto out_free_maps;

[PATCH 1/1] tools headers: Update syscall.tbl files to support mount_setattr

2021-03-02 Thread Arnaldo Carvalho de Melo
/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl' diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl Cc: Adrian Hunter Cc: Christian Brauner Cc: Ian Rogers Cc: Jiri Olsa Cc: Namh

Re: [PATCH 0/6] coresight: Patches for v5.12 (perf tools)

2021-03-02 Thread Arnaldo Carvalho de Melo
On March 2, 2021 2:02:17 PM GMT-03:00, Mike Leach wrote: >On Tue, 2 Mar 2021 at 16:42, Mathieu Poirier > wrote: >> >> On Tue, Mar 02, 2021 at 01:24:27PM -0300, Arnaldo Carvalho de Melo >wrote: >> > Can you please try one more time, these are the

Re: [PATCH 0/6] coresight: Patches for v5.12 (perf tools)

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 02, 2021 at 02:23:14PM +, Mike Leach escreveu: > On Tue, 2 Mar 2021 at 12:52, Arnaldo Carvalho de Melo wrote: > > Em Wed, Feb 24, 2021 at 09:48:29AM -0700, Mathieu Poirier escreveu: > > > I noticed there is a couple of patchsets [1][2] that haven't made it

Re: [PATCH] perf bench numa: Fix the condition checks for max number of numa nodes

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 02:28:27PM +0530, Srikar Dronamraju escreveu: > * Athira Rajeev [2021-02-25 11:50:02]: > > > In systems having higher node numbers available like node > > 255, perf numa bench will fail with SIGABORT. > > > > <<>> > > perf: bench/numa.c:1416: init: Assertion `!(g->p.nr_no

Re: [PATCH] [perf] powerpc: Remove unsupported metrics

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 11:03:11AM +0530, kajoljain escreveu: > > > On 2/24/21 11:44 PM, Paul A. Clarke wrote: > > Several metrics are defined based on unsupported / non-existent > > events, and silently discarded. Remove them for good code hygiene > > and to avoid confusion. > > > > Hi Paul,

Re: [PATCH] perf: fix ccache usage in $(CC) when generating arch errno table

2021-03-02 Thread Arnaldo Carvalho de Melo
: Normalize gcc parameter when generating arch errno table") And applied to perf/urgent. - Arnaldo > Signed-off-by: Antonio Terceiro > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: J

Re: [PATCH 1/2] perf daemon: Fix control fifo permissions

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 01, 2021 at 01:25:09PM +0100, Jiri Olsa escreveu: > Add proper mode for mkfifo calls to get read and > write permissions for user. We can't use O_RDWR > in here, changing to standard permission value. Thanks, applied both patches to perf/urgent. - Arnaldo > Fixes: 6a6d1804a190 ("pe

Re: [PATCH 0/6] coresight: Patches for v5.12 (perf tools)

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 09:48:29AM -0700, Mathieu Poirier escreveu: > Good day Arnaldo, > > I noticed there is a couple of patchsets [1][2] that haven't made it > to your tree for the coming v5.12 cycle. Do you think that can still > be done? Thanks, applied, unfortunately the window is closed

Re: [PATCH] perf tools: Fix event's pmu name parsing

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 01, 2021 at 01:23:15PM +0100, Jiri Olsa escreveu: > Jin Yao reported parser error for software event: > > # perf stat -e software/r1a/ -a -- sleep 1 > event syntax error: 'software/r1a/' >\___ parser error > > This happens after commit 8c3b1ba0e7ea, where n

Re: [PATCH 0/6] coresight: Patches for v5.12 (perf tools)

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 09:48:29AM -0700, Mathieu Poirier escreveu: > Good day Arnaldo, > > I noticed there is a couple of patchsets [1][2] that haven't made it > to your tree for the coming v5.12 cycle. Do you think that can still > be done? > > I tallied the patches here to make it easier for

Re: [PATCH] perf tools: Fix documentation of verbose options

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 10:31:44AM -0800, Ian Rogers escreveu: > Option doesn't take a value, make sure the man pages agree. For example: > > $ perf evlist --verbose=1 > Error: option `verbose' takes no value Thanks, applied. - Arnaldo > Signed-off-by: Ian Rogers > --- > tools/perf/Documen

Re: [PATCH v2] perf docs: Add man pages to see also

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 22, 2021 at 10:01:12AM -0800, Ian Rogers escreveu: > On Thu, Nov 19, 2020 at 10:30 PM Ian Rogers wrote: > > > > Add all other man pages to the "see also" list except for > > perf-script-perl and perf-script-python that are linked to from > > perf-script. > > > > v2. Fix accidentally li

Re: [PATCH] perf diff: Don't crash on freeing errno-session

2021-03-02 Thread Arnaldo Carvalho de Melo
find it easier to follow with IS_ERR() check in the same function. > > After some time it's still obvious why the check is needed, and with > > temp variable it's possible to make the same mistake. > > > > Cc: Alexander Shishkin > > Cc: Arnaldo Carvalho de Melo

Re: [PATCH] perf trace: Ensure read cmdlines are null terminated.

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 01, 2021 at 04:50:50PM +0900, Namhyung Kim escreveu: > Hi Ian, > > On Sat, Feb 27, 2021 at 7:14 AM Ian Rogers wrote: > > > > Issue detected by address sanitizer. > > > > Fixes: cd4ceb63438e (perf util: Save pid-cmdline mapping into tracing > > header) > > Signed-off-by: Ian Rogers >

Re: [PATCH] perf buildid-cache: Add test for PE executable

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Sat, Feb 27, 2021 at 11:17:01AM +0100, Jiri Olsa escreveu: > On Fri, Feb 26, 2021 at 08:47:36PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 25, 2021 at 09:35:04PM +0100, Jiri Olsa escreveu: > > > On Wed, Feb 24, 2021 at 02:59:16PM -0500, Nicholas Fraser w

Re: [PATCH] perf stat: improve readability of shadow stats

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 02, 2021 at 11:08:40AM +0900, Namhyung Kim escreveu: > On Tue, Mar 2, 2021 at 4:19 AM Jiri Olsa wrote: > > > > On Tue, Mar 02, 2021 at 01:24:02AM +0800, Changbin Du wrote: > > > This does follow two changes: > > > 1) Select appropriate unit between K/M/G. > > > 2) Use 'cpu-sec' ins

Re: [PATCH] Perf: Clean generated directory.

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 01, 2021 at 07:56:42PM +0100, Gon Solo escreveu: > From: Andreas Wendleder > > Remove generated directory tools/perf/arch/x86/include/generated. Thanks applied. There is one more, consider fixing it too: $ make -C tools/perf clean make: Entering directory '/home/acme/git/perf/t

Re: [PATCH v2 0/3] Add some perf support for mips

2021-03-01 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 08:49:29PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 26, 2021 at 09:11:17AM +0800, Tiezhu Yang escreveu: > > Sorry for the late reply. I asked for a leave yesterday. > > asm/perf_regs.h is a new added file in the patch #1, > > the pat

Re: [PATCH v2 0/3] Add some perf support for mips

2021-02-26 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 26, 2021 at 09:11:17AM +0800, Tiezhu Yang escreveu: > On 02/25/2021 09:12 PM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Feb 25, 2021 at 10:10:12AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Feb 25, 2021 at 09:49:56AM -0300, Arnaldo Carvalho de Me

Re: [PATCH] perf buildid-cache: Add test for PE executable

2021-02-26 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 09:35:04PM +0100, Jiri Olsa escreveu: > On Wed, Feb 24, 2021 at 02:59:16PM -0500, Nicholas Fraser wrote: > > From 9fd0b3889f00ad13662879767d833309d8a035b6 Mon Sep 17 00:00:00 2001 > > From: Nicholas Fraser > > Date: Thu, 18 Feb 2021 13:24:03 -0500 > > Subject: [PATCH] perf

Re: [PATCH] perf tools: Move feature cleanup under tools/build

2021-02-26 Thread Arnaldo Carvalho de Melo
;s cleanup under build Makefile, so it now checks that > there's existing OUTPUT directory before calling the clean. > > Cc: Sedat Dilek > Fixes: 211a741cd3e1 ("tools: Factor Clang, LLC and LLVM utils definitions") > Reported-by: Arnaldo Carvalho de Melo >

Re: [PATCH v1] perf: cast (struct timeval).tv_sec when printing

2021-02-25 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 05:33:50PM +0100, Jiri Olsa escreveu: > On Wed, Feb 24, 2021 at 06:24:10PM +, pierre.gond...@arm.com wrote: > > From: Pierre Gondois > > > > The musl-libc [1] defines (struct timeval).tv_sec as a > > 'long long' for arm and other architectures. The default > > build ha

Re: [PATCH v2 0/3] Add some perf support for mips

2021-02-25 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 10:10:12AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Feb 25, 2021 at 09:49:56AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Feb 24, 2021 at 10:16:55AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Mon, Feb 22, 2021 at 02:43:39PM

Re: [PATCH v2 0/3] Add some perf support for mips

2021-02-25 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 25, 2021 at 09:49:56AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Feb 24, 2021 at 10:16:55AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Feb 22, 2021 at 02:43:39PM +0800, Tiezhu Yang escreveu: > > > On 02/04/2021 11:35 AM, Tiezhu Yang wrote: >

Re: [PATCH v2 0/3] Add some perf support for mips

2021-02-25 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 10:16:55AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Feb 22, 2021 at 02:43:39PM +0800, Tiezhu Yang escreveu: > > On 02/04/2021 11:35 AM, Tiezhu Yang wrote: > > > v2: add R26 and R27 to the enum perf_event_mips_regs in patch #1 > >

Re: [PATCH 0/6] coresight: Patches for v5.12 (perf tools)

2021-02-24 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 24, 2021 at 09:48:29AM -0700, Mathieu Poirier escreveu: > Good day Arnaldo, > > I noticed there is a couple of patchsets [1][2] that haven't made it > to your tree for the coming v5.12 cycle. Do you think that can still > be done? Sure, I'll go thru them, hopefully we'll get it in v

Re: [PATCH v2 0/3] Add some perf support for mips

2021-02-24 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 22, 2021 at 02:43:39PM +0800, Tiezhu Yang escreveu: > On 02/04/2021 11:35 AM, Tiezhu Yang wrote: > > v2: add R26 and R27 to the enum perf_event_mips_regs in patch #1 > > > > Tiezhu Yang (3): > >MIPS: kernel: Support extracting off-line stack traces from user-space > > with per

Re: [PATCH] perf-probe: dso: Add symbols in .text.* subsections to text symbol map in kenrel modules

2021-02-23 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 23, 2021 at 06:02:58PM +0300, Evgenii Shatokhin escreveu: > On 23.02.2021 10:37, Masami Hiramatsu wrote: > > The kernel modules have .text.* subsections such as .text.unlikely. > > Since dso__process_kernel_symbol() only identify the symbols in the ".text" > > section as the text symbol

Re: [PATCH] perf annotate: add --demangle and --demangle-kernel

2021-02-23 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 22, 2021 at 09:29:22AM +0100, Martin Liška escreveu: > Perf annotate supports --symbol but it's impossible to filter > a C++ symbol. With --no-demangle one can filter easily by > mangled function name. > > Signed-off-by: Martin Liška > --- > tools/perf/Documentation/perf-annotate.txt

Re: [PATCH] perf annotate: improve --stdio mode

2021-02-23 Thread Arnaldo Carvalho de Melo
Em Sun, Feb 21, 2021 at 01:46:36PM +0100, Martin Liška escreveu: > The patch changes the output format in 2 ways: > - line number is displayed for all source lines (matching TUI mode) Are you aware of 'perf annotate --stdio2' ? If the goal is to make the stdio mode better, doing it in that mode wo

[GIT PULL] perf tools changes for v5.12

2021-02-19 Thread Arnaldo Carvalho de Melo
m64, s390 and powerpc. Arch specific: - Support exposing Performance Monitor Counter SPRs as part of extended regs on powerpc. - Add JSON 'perf stat' metrics for ARM64's imx8mp, imx8mq and imx8mn DDR, fix imx8mm ones. - Fix common and uarch events for ARM64's A76 and Ampere

Re: [PATCH 3/3] tools/lib/fs: Cache cgroupfs mount point

2021-02-19 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 19, 2021 at 07:05:59PM +0900, Namhyung Kim escreveu: > On Wed, Feb 17, 2021 at 9:58 PM Arnaldo Carvalho de Melo > wrote: > > Em Fri, Jan 08, 2021 at 02:51:44PM +0900, Namhyung Kim escreveu: > > > On Wed, Jan 6, 2021 at 10:33 AM Namhyung Kim wrote: > > &g

Re: [PATCH 1/2] perf report: Remove redundant libbfd checks

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 18, 2021 at 02:42:17PM -0500, Nicholas Fraser escreveu: > > On 2021-02-18 2:39 p.m., Arnaldo Carvalho de Melo wrote: > > you forgot the: > > > > Signed-off-by: Nicholas Fraser > > > > I'm adding it, ok? > > Ah yes sorry about that

Re: [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 17, 2021 at 08:54:00PM +0100, Jiri Olsa escreveu: > On Wed, Feb 10, 2021 at 02:17:25PM -0500, Nicholas Fraser wrote: > > lsdir_bid_tail_filter() ignored any build-id that wasn't exactly 20 > > bytes. This worked only for SHA-1 build-ids. The build-id for a PE file > > is always a 16-byt

Re: [PATCH 1/2] perf report: Remove redundant libbfd checks

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 16, 2021 at 03:37:20PM -0500, Nicholas Fraser escreveu: > This removes the redundant checks bfd_check_format() and > bfd_target_elf_flavour. They were previously checking different files. you forgot the: Signed-off-by: Nicholas Fraser I'm adding it, ok? I'm also addressing Jiri's r

Re: [PATCH v1 0/2] perf test: Output sub testing result in cs-etm

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 15, 2021 at 07:59:42PM +0800, Leo Yan escreveu: > The "perf test" can be integrated into testing framework, e.g. Linux > kernel functional testing (LKFT) [1]. We are not satisfied with only > outputting the summarized result for Arm CoreSight testing but lacking > more detailed result

Re: [PATCH v5] perf tools: Fix arm64 build error with gcc-11

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 18, 2021 at 09:26:17AM +, John Garry escreveu: > On 18/02/2021 03:12, Jianlin Lv wrote: > > gcc version: 11.0.0 20210208 (experimental) (GCC) > > > > Following build error on arm64: > > > > ... > > In function ‘printf’, > > inlined from ‘regs_dump__printf’ at util/session

Re: [PATCH] perf auxtrace: Automatically group aux-output events

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Sun, Jan 24, 2021 at 12:11:25AM +0100, Jiri Olsa escreveu: > On Thu, Jan 21, 2021 at 04:04:18PM +0200, Adrian Hunter wrote: > > aux-output events need to have an AUX area event as the group leader. > > However, grouping events does not allow the AUX area event to be given > > an address filter b

Re: [PATCH] perf test: Fix unaligned access in sample parsing test

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 15, 2021 at 08:26:08AM +0200, Adrian Hunter escreveu: > On 14/02/21 11:16 am, Namhyung Kim wrote: > > The ubsan reported the following error. It was because sample's raw > > data missed u32 padding at the end. So it broke the alignment of the > > array after it. > > > > The raw data

Re: [PATCH] perf tools: Support arch specific PERF_SAMPLE_WEIGHT_STRUCT processing

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 05, 2021 at 08:01:52AM -0800, kan.li...@linux.intel.com escreveu: > From: Kan Liang > > For X86, the var2_w field of PERF_SAMPLE_WEIGHT_STRUCT stands for the > instruction latency. Current perf forces the var2_w to the data->ins_lat > in the generic code. It works well for now because

Re: [PATCH 4/0] perf intel-pt: Add PSB events

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 05, 2021 at 12:54:49PM -0800, Andi Kleen escreveu: > On Fri, Feb 05, 2021 at 07:53:46PM +0200, Adrian Hunter wrote: > > Hi > > > > Here are 3 fixes and 1 minor new feature, for Intel PT. > > For the series: > > Reviewed-by: Andi Kleen Thanks, applied. - Arnaldo

Re: [PATCH] perf record: Fix continue profiling after draining the buffer

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 18, 2021 at 10:20:53AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 05, 2021 at 11:46:12AM +0100, Jiri Olsa escreveu: > > On Fri, Feb 05, 2021 at 07:35:22PM +0900, Namhyung Kim wrote: > > > Hello, > > > > > > On Fri, Feb 5

Re: [PATCH] perf record: Fix continue profiling after draining the buffer

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 05, 2021 at 11:46:12AM +0100, Jiri Olsa escreveu: > On Fri, Feb 05, 2021 at 07:35:22PM +0900, Namhyung Kim wrote: > > Hello, > > > > On Fri, Feb 5, 2021 at 3:50 PM Yang Jihong wrote: > > > > > > commit da231338ec9c098707c8a1e4d8a50e2400e2fe17 uses eventfd to solve > > > rare race > >

Re: [PATCH V3 0/4] tools: perf: Add JSON metrics for i.MX8M platforms

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 18, 2021 at 10:14:29AM +, Joakim Zhang escreveu: > > Gentle pinging... Thanks, applied. - Arnaldo > Best Regards, > Joakim Zhang > > > -Original Message- > > From: John Garry > > Sent: 2021年1月27日 22:14 > > To: Joakim Zhang ; w...@kernel.org; > > mathieu.poir...@linar

Re: [PATCH] perf tools: Simplify the calculation of variables

2021-02-18 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 05, 2021 at 10:49:15AM +0100, Jiri Olsa escreveu: > On Fri, Feb 05, 2021 at 11:54:15AM +0800, Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > > > ./tools/perf/util/header.c:3809:18-20: WARNING !A || A && B is > > equivalent to !A || B. > > > > Reported-by: Abaci Ro

Re: [PATCH] perf annotate: do not jump after 'k' is pressed

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 15, 2021 at 01:45:25PM +0100, Martin Liška escreveu: > Do not jump when 'k' is pressed, the cursor show stay where it is. > Right now, it jumps to the currently selected hot instruction. Thanks, applied. - Arnaldo > Signed-off-by: Martin Liška > --- > tools/perf/ui/browsers/annot

Re: [PATCH] perf metricgroup: remove unneeded semicolon

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 16, 2021 at 04:34:25PM +0900, Namhyung Kim escreveu: > Hello, > > On Mon, Feb 1, 2021 at 4:41 PM Yang Li wrote: > > > > Eliminate the following coccicheck warning: > > ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon > > > > Reported-by: Abaci Robot > > Signed-off-by: Yang

Re: [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 16, 2021 at 11:35:06AM -0500, Nicholas Fraser escreveu: > No problem, I've added a call to "perf buildid-cache -l" in check() to make > sure the added IDs are reported. The MD5 test fails without the previous > patch to allow 16-byte build-ids. > > Do you also want PE files tested by t

Re: [PATCH] perf tools: Add OCaml demangling

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 16, 2021 at 04:47:30PM +0900, Namhyung Kim escreveu: > Hello, > > (+ Cc: LKML) > > On Thu, Feb 4, 2021 at 6:22 AM Fabian Hemmer wrote: > > > > Detect symbols generated by the OCaml compiler based on their prefix. > > > > Demangle OCaml symbols, returning a newly allocated string (lik

Re: [PATCH 3/3] tools/lib/fs: Cache cgroupfs mount point

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jan 08, 2021 at 02:51:44PM +0900, Namhyung Kim escreveu: > On Wed, Jan 6, 2021 at 10:33 AM Namhyung Kim wrote: > > > > Hi Arnaldo, > > > > On Tue, Dec 29, 2020 at 8:51 PM Arnaldo Carvalho de Melo > > wrote: > > > > > > Em Wed, Dec

Re: [PATCH v4] perf tools: Fix arm64 build error with gcc-11

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 17, 2021 at 07:58:30PM +0800, Jianlin Lv escreveu: > gcc version: 11.0.0 20210208 (experimental) (GCC) > > Following build error on arm64: > > ... > In function ‘printf’, > inlined from ‘regs_dump__printf’ at util/session.c:1141:3, > inlined from ‘regs__printf’ at util/ses

Re: [PATCH v2] perf tools: Resolve symbols against debug file first

2021-02-17 Thread Arnaldo Carvalho de Melo
t; Signed-off-by: Jiri Slaby > Acked-by: Namhyung Kim Thanks, applied. - Arnaldo > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > --- > [v2] added a comment > > tools/perf/

Re: ANNOUNCE: pahole v1.20 (gcc11 DWARF5's default, lots of ELF sections, BTF)

2021-02-17 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 17, 2021 at 01:08:23PM +0100, Domenico Andreoli escreveu: > On Mon, Feb 08, 2021 at 09:32:53AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Feb 08, 2021 at 03:44:54AM +0100, Sedat Dilek escreveu: > > > On Thu, Feb 4, 2021 at 11:07 PM Arnaldo Carvalho de

Re: [RFC][PATCH 1/2] x86: remove duplicate TSC DEADLINE MSR definitions

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 05, 2021 at 10:31:05AM +0100, Borislav Petkov escreveu: > On Thu, Mar 05, 2020 at 09:47:06AM -0800, Dave Hansen wrote: > > > > There are two definitions for the TSC deadline MSR in msr-index.h, > > one with an underscore and one without. Axe one of them and move > > all the references

Re: [PATCH v2] perf probe: fix kretprobe issue caused by GCC bug

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 10, 2021 at 02:26:46PM +0800, Jianlin Lv escreveu: > Perf failed to add kretprobe event with debuginfo of vmlinux which is > compiled by gcc with -fpatchable-function-entry option enabled. > The same issue with kernel module. > > Issue: > > # perf probe -v 'kernel_clone%return $ret

Re: [PATCH 2/4] perf report: Load PE files from debug cache only

2021-02-12 Thread Arnaldo Carvalho de Melo
s debugfile as the file in the > debugcache if it has a build-id. Even if the file was previously loaded at > its original path, (if I understand correctly) this load will override it > so the debugcache file ends up being used. > > Nick > > > On 2021-02-12 7:28 a.m., Arn

Re: [PATCH 3/4] perf archive: Fix filtering of empty build-ids

2021-02-12 Thread Arnaldo Carvalho de Melo
ta file, it should know that a zero-filled or a blank filled build-id means the same and act accordingly. - Arnaldo > Nick > > > On 2021-02-12 7:29 a.m., Arnaldo Carvalho de Melo wrote: > > Em Wed, Feb 10, 2021 at 02:17:49PM -0500, Nicholas Fraser escreveu: > >> A non-existen

Re: [PATCH v2 1/6] perf arm-spe: Enable sample type PERF_SAMPLE_DATA_SRC

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 11, 2021 at 03:38:51PM +0200, James Clark escreveu: > From: Leo Yan > > This patch is to enable sample type PERF_SAMPLE_DATA_SRC for Arm SPE in > the perf data, when output the tracing data, it tells tools that it > contains data source in the memory event. Thanks, series applied. -

Re: [PATCH] perf env: Remove unneeded internal/cpumap inclusions

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 12, 2021 at 09:33:45AM +0100, Jiri Olsa escreveu: > On Thu, Feb 11, 2021 at 10:39:14AM -0800, Ian Rogers wrote: > > Minor cleanup. > > > > Signed-off-by: Ian Rogers > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo > thanks, > jirka > > > --- > > tools/perf/bench/epoll-ctl.c

Re: [PATCH][RFC] perf annotate: show full line locations with 'k' in UI

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 12, 2021 at 03:42:47PM +0100, Martin Liška escreveu: > Hello. > > Sometimes it's handy to display also a filename of a source location, mainly > because > source lines can come from different files. I extended 'k' hotkey and one can > now see: > > 1) no source lines: > > 1.31 │

Re: [PATCH] perf libperf: Remove unused xyarray.c

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 12, 2021 at 09:33:58AM +0100, Jiri Olsa escreveu: > On Thu, Feb 11, 2021 at 08:38:03PM -0800, Ian Rogers wrote: > > Migrated to libperf in: > > commit 4b247fa7314c ("libperf: Adopt xyarray class from perf") > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo > thanks, > jirka > >

Re: [PATCH 4/4] perf report: Fix return value when loading PE DSO

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 10, 2021 at 02:18:02PM -0500, Nicholas Fraser escreveu: > The first time dso__load() was called on a PE file it always returned -1 > error. This caused the first call to map__find_symbol() to always fail > on a PE file so the first sample from each PE file always had symbol > . Subseque

Re: [PATCH 3/4] perf archive: Fix filtering of empty build-ids

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 10, 2021 at 02:17:49PM -0500, Nicholas Fraser escreveu: > A non-existent build-id used to be treated as all-zero SHA-1 hash. > Build-ids are now variable width. A non-existent build-id is an empty > string and "perf buildid-list" pads this with spaces. > > This fixes "perf-archive" to

Re: [PATCH 2/4] perf report: Load PE files from debug cache only

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 10, 2021 at 02:17:38PM -0500, Nicholas Fraser escreveu: > dso__load_bfd_symbols() attempts to load a DSO at its original path, > then closes it and loads the file in the debug cache. This is incorrect. > It should ignore the original file and work with only the debug cache. > The origin

Re: [PATCH] perf: Use (long) for iterator for bfd symbols

2021-02-11 Thread Arnaldo Carvalho de Melo
: all warnings being treated as errors > > > > It's unlikely that the symtable will be that big, but the fix is > > oneliner and as perf has CORE_CFLAGS += -Wextra, which makes build to > > fail together with CORE_CFLAGS += -Werror > > > > Fixes: eac9a4342e54 (&qu

Re: [PATCH] Fix jump parsing for C++ code.

2021-02-11 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 11, 2021 at 01:37:55PM +0100, Martin Liška escreveu: > Considering the following testcase: > > int > foo(int a, int b) > { > for (unsigned i = 0; i < 10; i++) > a += b; > return a; > } > > int main() > { > foo (3, 4); > return 0; > } > > perf annotate displays: >

Re: [PATCH 06/24] perf daemon: Add config file support

2021-02-11 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 11, 2021 at 05:45:38PM +0100, Jiri Olsa escreveu: > On Thu, Feb 11, 2021 at 03:01:12PM +0900, Namhyung Kim wrote: > > Hi Jiri, > > > > On Tue, Feb 9, 2021 at 5:09 AM Jiri Olsa wrote: > > > +static int daemon__reconfig(struct daemon *daemon) > > > +{ > > > + struct daemon_session

Re: [PATCH 13/24] perf daemon: Allow only one daemon over base directory

2021-02-11 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 08, 2021 at 09:08:57PM +0100, Jiri Olsa escreveu: > Add 'lock' file under daemon base and flock it, so only one > perf daemon can run on top of it. > > Each daemon tries to create and lock BASE/lock file, if it's > successful we are sure we're the only daemon running over > the BASE. >

Re: [PATCH] Fix jump parsing for C++ code.

2021-02-11 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 11, 2021 at 01:37:55PM +0100, Martin Liška escreveu: > Considering the following testcase: Cool, applied, next time please use a Summary like: Subject: Re: [PATCH] perf annotate: Fix jump parsing for C++ code. So that it stands out more clearly in my inbox, this time I saw your nam

Re: [PATCH] perf: Replace lkml.org links with lore

2021-02-11 Thread Arnaldo Carvalho de Melo
Em Thu, Feb 11, 2021 at 11:11:19AM +0100, Peter Zijlstra escreveu: > On Wed, Feb 10, 2021 at 03:42:19PM -0800, Kees Cook wrote: > > As started by commit 05a5f51ca566 ("Documentation: Replace lkml.org > > links with lore"), replace lkml.org links with lore to better use a > > single source that's mo

Re: [PATCH 05/24] perf daemon: Add client socket support

2021-02-11 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 08, 2021 at 09:08:49PM +0100, Jiri Olsa escreveu: > +__maybe_unused > +static int send_cmd(struct daemon *daemon, union cmd *cmd) > +{ > + int ret = -1, fd; > + char *line = NULL; > + size_t len = 0; > + ssize_t nread; > + FILE *in = NULL; > + > + if (setup_clien

Re: [PATCH 15/24] perf daemon: Add ping command

2021-02-10 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 08, 2021 at 09:08:59PM +0100, Jiri Olsa escreveu: > + > + if (!pollfd.revents & POLLIN) { > + pr_err("failed: did not received an ack\n"); > + goto out; > + } > + Fixed up this, pointed out by clang on many build containers, including fedora:34: Committ

Re: [PATCH] perf report: Fix arm64 gap between kernel start and module end

2021-02-09 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 09, 2021 at 09:40:09AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Mar 30, 2020 at 10:18:10AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Mar 30, 2020 at 10:11:29AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Mon, Mar 30, 2020 at 03:41:11PM

<    1   2   3   4   5   6   7   8   9   10   >