Re: [PATCH 07/25] perf tools: Add build_id__is_defined function

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 26, 2020 at 06:00:08PM +0100, Jiri Olsa escreveu: > Adding build_id__is_defined helper to check build id > is defined and is != zero build id. Thanks, applied. - Arnaldo > Signed-off-by: Jiri Olsa > --- > tools/perf/util/build-id.c | 6 ++ > tools/perf/util/build-id.h | 1 +

Re: [PATCH 06/25] perf tools: Do not swap mmap2 fields in case it contains build id

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 26, 2020 at 06:00:07PM +0100, Jiri Olsa escreveu: > If PERF_RECORD_MISC_MMAP_BUILD_ID misc bit is set, > mmap2 event carries build id, placed in following union: > > union { > struct { > u32 maj; > u32 min; >

Re: [PATCH 05/25] tools lib: Adopt memchr_inv() from kernel

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 26, 2020 at 06:00:06PM +0100, Jiri Olsa escreveu: > We'll use it to check for undefined/zero data. Thanks, applied. - Arnaldo > Signed-off-by: Jiri Olsa > --- > tools/include/linux/string.h | 1 + > tools/lib/string.c | 58 > 2

Re: [PATCH 25/25] perf record: Add --buildid-mmap option to enable mmap's build id

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 26, 2020 at 06:00:26PM +0100, Jiri Olsa escreveu: > Adding --buildid-mmap option to enable build id in mmap2 events. It > will only work if there's kernel support for that and it disables > build id cache (implies --no-buildid). > It's also possible to enable it permanently via

Re: [BUG] perf probe can't remove probes

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 26, 2020 at 09:21:25AM +0900, Masami Hiramatsu escreveu: > Hi Arnaldo, > > On Wed, 25 Nov 2020 14:27:55 -0300 > Arnaldo Carvalho de Melo wrote: > > > > > Masami, have you stumbled on this already? > > > > [root@seventh ~]# perf probe s

Re: [PATCH v9 01/16] perf arm-spe: Refactor printing string to buffer

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 19, 2020 at 11:24:26PM +0800, Leo Yan escreveu: > When outputs strings to the decoding buffer with function snprintf(), > SPE decoder needs to detects if any error returns from snprintf() and if > so needs to directly bail out. If snprintf() returns success, it needs > to update

Re: [PATCH v9 00/16] perf arm-spe: Refactor decoding & dumping flow

2020-11-26 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 25, 2020 at 02:17:56PM +, Will Deacon escreveu: > On Thu, Nov 19, 2020 at 11:24:25PM +0800, Leo Yan wrote: > > This is patch set v9 for refactoring Arm SPE trace decoding and dumping. > > > > According to comments and suggestions from patch set v8, it squashs the > > two patches

[BUG] perf probe can't remove probes

2020-11-25 Thread Arnaldo Carvalho de Melo
Masami, have you stumbled on this already? [root@seventh ~]# perf probe security_locked_down%return 'ret=$retval' Added new event: probe:security_locked_down__return (on security_locked_down%return with ret=$retval) You can now use it in all perf tools, such as: perf record -e

ANNOUNCE: pahole v1.19 (Split BTF for kmodules, DWARF bug workarounds, speedups, --packed)

2020-11-24 Thread Arnaldo Carvalho de Melo
- Fix bug in distros such as OpenSUSE:15.2 where DW_AT_alignment isn't defined. Signed-off-by: Arnaldo Carvalho de Melo

Re: [RFC 0/2] Introduce perf-stat -b for BPF programs

2020-11-19 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 18, 2020 at 08:50:44PM -0800, Song Liu escreveu: > This set introduces perf-stat -b option to count events for BPF programs. > This is similar to bpftool-prog-profile. But perf-stat makes it much more > flexible. > > Sending as RFC because I would like comments on some key design

Re: [PATCH 06/24] perf tools: Add build_id__is_defined function

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 09:53:59PM +0100, Jiri Olsa escreveu: > On Tue, Nov 17, 2020 at 11:00:37AM -0800, Ian Rogers wrote: > > On Tue, Nov 17, 2020 at 3:01 AM Jiri Olsa wrote: > > > > > Adding build_id__is_defined helper to check build id > > > is defined and is != zero build id. > > > > > >

Re: [PATCH 23/24] perf buildid-list: Add support for mmap2's buildid events

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 04:21:40PM +0100, Jiri Olsa escreveu: > On Tue, Nov 17, 2020 at 09:50:40AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Nov 17, 2020 at 12:00:52PM +0100, Jiri Olsa escreveu: > > > Add buildid-list support for mmap2's build id data, so we can >

Re: [PATCH 13/24] perf tools: Allow mmap2 event to synthesize kernel image

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 04:16:51PM +0100, Jiri Olsa escreveu: > On Tue, Nov 17, 2020 at 09:44:37AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Nov 17, 2020 at 12:00:42PM +0100, Jiri Olsa escreveu: > > > Allow mmap2 event to synthesize kernel image, > > > so we can

[GIT PULL] perf tools fixes for v5.10: 3rd batch

2020-11-17 Thread Arnaldo Carvalho de Melo
f lock'. Signed-off-by: Arnaldo Carvalho de Melo Test results at the signed tag at: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tag/?h=perf-tools-fixes-for-v5.10-2020-11-17 Al Grant (1): perf inject: Fix

Re: [PATCH 23/24] perf buildid-list: Add support for mmap2's buildid events

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:52PM +0100, Jiri Olsa escreveu: > Add buildid-list support for mmap2's build id data, so we can > display build ids for dso objects for data without the build > id cache update. > $ perf buildid-list > 1805c738c8f3ec0f47b7ea09080c28f34d18a82b

Re: [PATCH 21/24] perf buildid-cache: Add support to add build ids from perf data

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:50PM +0100, Jiri Olsa escreveu: > Adding support to specify perf data file as -a option file > argument, > > If the file is detected to be perf data file, it is processed > and all dso objects with sample hit are stored to the build > id cache. > > $

Re: [PATCH 15/24] perf tools: Synthesize build id for kernel/modules/tasks

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:44PM +0100, Jiri Olsa escreveu: > Adding build id to synthesized mmap2 events for > everything - kernel/modules/tasks. > > Signed-off-by: Jiri Olsa > --- > tools/perf/util/synthetic-events.c | 32 ++ > 1 file changed, 32 insertions(+) >

Re: [PATCH 22/24] perf buildid-cache: Add --debuginfod option

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:51PM +0100, Jiri Olsa escreveu: > Adding --debuginfod option to specify debuginfod url and > support to do that through config file as well. > > Use following in ~/.perfconfig file: > > [buildid-cache] > debuginfod=http://192.168.122.174:8002 Ditto, its cool

Re: [PATCH 13/24] perf tools: Allow mmap2 event to synthesize kernel image

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:42PM +0100, Jiri Olsa escreveu: > Allow mmap2 event to synthesize kernel image, > so we can synthesize kernel build id data in > following changes. > > It's enabled by new symbol_conf.buildid_mmap2 > bool, which will be switched in following > changes. Why make this

Re: [PATCH 14/24] perf tools: Allow mmap2 event to synthesize modules

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:43PM +0100, Jiri Olsa escreveu: > Allow mmap2 event to synthesize kernel modules, > so we can synthesize module's build id data in > following changes. > > It's enabled by new symbol_conf.buildid_mmap2 > bool, which will be switched in following > changes. Ditto as

Re: [PATCH 12/24] perf tools: Store build id from mmap2 events

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:41PM +0100, Jiri Olsa escreveu: > When processing mmap2 event, check on the build id > misc bit: PERF_RECORD_MISC_BUILD_ID and if it's set, > store the build id in mmap's dso object. > > Also adding the build id data arts to struct > perf_record_mmap2 event

Re: [PATCH 08/24] perf tools: Add support to read build id from compressed elf

2020-11-17 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 17, 2020 at 12:00:37PM +0100, Jiri Olsa escreveu: > Adding support to decompress file before reading build id. > > Adding filename__read_build_id and change its current > versions to read_build_id. > > Shutting down stderr output of perf list in the shell test: > 82: Check open

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 16, 2020 at 11:12:30AM -0800, Ian Rogers escreveu: > On Mon, Nov 16, 2020 at 9:05 AM Arnaldo Carvalho de Melo > wrote: > > > Em Fri, Nov 06, 2020 at 01:21:58PM +0900, Namhyung Kim escreveu: > > > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao > > wrote: >

Re: [PATCH] perf test: Avoid an msan warning in a copied stack.

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 13, 2020 at 10:20:53AM -0800, Ian Rogers escreveu: > This fix is for a failure that occurred in the DWARF unwind perf test. > Stack unwinders may probe memory when looking for frames. Memory > sanitizer will poison and track uninitialized memory on the stack, and > on the heap if the

Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 13, 2020 at 10:38:28AM -0800, Ian Rogers escreveu: > On Fri, Sep 4, 2020 at 9:29 AM Arnaldo Carvalho de Melo > wrote: > > > Em Thu, Sep 03, 2020 at 10:53:16PM -0700, Ian Rogers escreveu: > > > On Thu, Aug 27, 2020 at 12:00 AM kajoljain wrote: > > >

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 06, 2020 at 01:21:58PM +0900, Namhyung Kim escreveu: > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao wrote: > > >> Signed-off-by: Jin Yao > > > > > > It seems not applied to acme/perf/core cleanly. > > > > > > Thanks, > > > Namhyung > > > > > > > It seems the patch mail is truncated. :( >

Re: [PATCH] perf bench: Update arch/x86/lib/mem{cpy,set}_64.S

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 03, 2020 at 04:56:09PM -0800, Fangrui Song escreveu: > In memset_64.S, the macros expand to `.weak MEMSET ... .globl MEMSET` > which will produce a STB_WEAK MEMSET with GNU as but STB_GLOBAL MEMSET > with LLVM's integrated assembler before LLVM 12. LLVM 12 (since >

Re: [PATCH v2] perf data: Allow to use stdio functions for pipe mode

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Sat, Nov 14, 2020 at 09:55:34PM +0100, Jiri Olsa escreveu: > On Fri, Oct 30, 2020 at 02:47:42PM +0900, Namhyung Kim wrote: > > When perf data is in a pipe, it reads each event separately using > > read(2) syscall. This is a huge performance bottleneck when > > processing large data like in

Re: [PATCH 24/24] perf record: Add --buildid-mmap option to enable mmap's build id

2020-11-12 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 12, 2020 at 12:57:10PM +0100, Jiri Olsa escreveu: > On Wed, Nov 11, 2020 at 09:00:46AM -0800, Andi Kleen wrote: > > On Mon, Nov 09, 2020 at 10:54:15PM +0100, Jiri Olsa wrote: > > > Adding --buildid-mmap option to enable build id in mmap2 events. > > > It will only work if there's

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:02:48PM -0300, Arnaldo Carvalho de Melo escreveu: > > I'll keep the series up to that point and will run my build tests, then > > push it publicly to acme/perf/core and you can go from there, ok? > > I've changed the BIT() to BIT_ULL() as Andre suggest

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:01:27PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Nov 11, 2020 at 05:58:27PM +, Dave Martin escreveu: > > > > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Nov 11, 2020 at 03:45:23PM

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 05:58:27PM +, Dave Martin escreveu: > > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu: > > > On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote: &g

Re: [PATCH v8 00/22] perf arm-spe: Refactor decoding & dumping flow

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 04:20:26PM +, André Przywara escreveu: > On 11/11/2020 16:15, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 11, 2020 at 01:10:51PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Wed, Nov 11, 2020 at 03:11:27PM +0800, Leo Yan escreveu: > >

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:58:27PM +, Dave Martin escreveu: > On Wed, Nov 11, 2020 at 03:53:20PM +, Dave Martin wrote: > > On Wed, Nov 11, 2020 at 07:11:33AM +, Leo Yan wrote: > > > When outputs strings to the decoding buffer with function snprintf(), > > > SPE decoder needs to detects

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:45:23PM +, André Przywara escreveu: > On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote: > > Hi Arnaldo, > > thanks for taking a look! > > > Em Wed, Nov 11, 2020 at 03:11:33PM +0800, Leo Yan escreveu: > >> When outpu

Re: [PATCH v8 00/22] perf arm-spe: Refactor decoding & dumping flow

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 01:10:51PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Nov 11, 2020 at 03:11:27PM +0800, Leo Yan escreveu: > > This is patch set v8 for refactoring Arm SPE trace decoding and dumping. > > > > This version addresses Andre's comment to

Re: [PATCH v8 00/22] perf arm-spe: Refactor decoding & dumping flow

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:11:27PM +0800, Leo Yan escreveu: > This is patch set v8 for refactoring Arm SPE trace decoding and dumping. > > This version addresses Andre's comment to pass parameter '_len' at > the last call arm_spe_pkt_snprintf() in the function arm_spe_pkt_desc(). > > This patch

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:11:33PM +0800, Leo Yan escreveu: > When outputs strings to the decoding buffer with function snprintf(), > SPE decoder needs to detects if any error returns from snprintf() and if > so needs to directly bail out. If snprintf() returns success, it needs > to update

Re: [PATCH v8 00/22] perf arm-spe: Refactor decoding & dumping flow

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 10:13:52AM +, André Przywara escreveu: > On 11/11/2020 07:11, Leo Yan wrote: > > Hi Arnaldo, Ingo, Peter, (whoever feels responsible for taking this) > > > This is patch set v8 for refactoring Arm SPE trace decoding and dumping. > I have reviewed every patch of this

Re: [PATCH 03/24] perf: Add build id data in mmap2 event

2020-11-10 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 10, 2020 at 07:23:34PM +0100, Jiri Olsa escreveu: > On Tue, Nov 10, 2020 at 11:10:46AM +0100, Jiri Olsa wrote: > > On Tue, Nov 10, 2020 at 09:28:51AM +0100, Peter Zijlstra wrote: > > > On Mon, Nov 09, 2020 at 10:53:54PM +0100, Jiri Olsa wrote: > > > > There's new misc bit for mmap2 to

Re: [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm

2020-11-10 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 10, 2020 at 11:08:29AM -0700, Mathieu Poirier escreveu: > On Tue, Nov 10, 2020 at 02:34:17PM +0800, Leo Yan wrote: > > Since the commit 943b69ac1884 ("perf parse-events: Set exclude_guest=1 > > for user-space counting"), 'exclude_guest=1' is set for user-space > > counting; and the

Re: [PATCH 03/24] perf: Add build id data in mmap2 event

2020-11-10 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 10, 2020 at 01:22:32PM +0100, Peter Zijlstra escreveu: > On Tue, Nov 10, 2020 at 08:54:26AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Nov 10, 2020 at 09:07:16AM +0100, Peter Zijlstra escreveu: > > > On Mon, Nov 09, 2020 at 10:53:54PM +0100, Jiri Olsa wro

Re: [PATCH 03/24] perf: Add build id data in mmap2 event

2020-11-10 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 10, 2020 at 09:07:16AM +0100, Peter Zijlstra escreveu: > On Mon, Nov 09, 2020 at 10:53:54PM +0100, Jiri Olsa wrote: > > Adding support to carry build id data in mmap2 event. > > > > The build id data replaces maj/min/ino/ino_generation > > fields, whichc are also used to identify

Re: 5.10 tree fails to build

2020-11-09 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 09, 2020 at 11:32:13AM +0100, Jiri Olsa escreveu: > On Mon, Nov 09, 2020 at 05:57:37PM +0800, Ming Lei wrote: > > On Thu, Nov 5, 2020 at 12:58 PM Amy Parker wrote: > > > > > > On all attempts to build the 5.10 tree (from either release candidate, > > > Linus's tree, Greg's tree, etc),

Re: [PATCH v3 1/2] perf lock: Correct field name "flags"

2020-11-04 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 04, 2020 at 05:42:28PM +0800, Leo Yan escreveu: > The tracepoint "lock:lock_acquire" contains field "flags" but not > "flag". Current code wrongly retrieves value from field "flag" and it > always gets zero for the value, thus "perf lock" doesn't report the > correct result. > > This

[GIT PULL] perf tools changes for v5.11

2020-11-03 Thread Arnaldo Carvalho de Melo
-by: Arnaldo Carvalho de Melo Test results in the signed tag at: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tag/?h=perf-tools-for-v5.10-2020-11-03 Arnaldo Carvalho de Melo (14): perf tools: Update copy

Re: [PATCH] perf tools: Add missing swap for cgroup events

2020-11-03 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 02, 2020 at 06:49:56PM +0100, Jiri Olsa escreveu: > On Mon, Nov 02, 2020 at 11:02:28PM +0900, Namhyung Kim wrote: > > It was missed to add a swap function for PERF_RECORD_CGROUP. > > > > Fixes: ba78c1c5461c ("perf tools: Basic support for CGROUP event") > > Acked-by: Jiri Olsa

Re: [PATCH 1/2] perf tools: Initialize output buffer in build_id__sprintf

2020-11-03 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 02, 2020 at 10:50:00PM +0900, Namhyung Kim escreveu: > Hi Jiri, > > On Mon, Nov 2, 2020 at 8:31 AM Jiri Olsa wrote: > > > > We display garbage for undefined build_id objects, > > because we don't initialize the output buffer. > > > > Signed-off-by: Jiri Olsa > > Acked-by: Namhyung

Re: [PATCH] perf: increase size of buf in perf_evsel__hists_browse()

2020-11-03 Thread Arnaldo Carvalho de Melo
tes. > > > > Fix this by increasing the size of buf[] to 128. > > > > Fixes: dbddf1747441 ("perf report/top TUI: Support hotkeys to let user > > select any event for sorting") > > Cc: stable # v5.7+ > > Cc: Jin Yao > > Cc: Jiri Olsa > > Cc: Arnaldo Carvalho de Melo > > Cc: Arnaldo Carvalho de Melo > > Signed-off-by: Song Liu > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo

[GIT PULL] perf tools changes for v5.10: 2nd batch

2020-10-30 Thread Arnaldo Carvalho de Melo
__no_tail_call attribute. - Add kvm-stat for arm64. - Fix segfault when trying to trace events by cgroup. - Fix crash with non-jited BPF progs Signed-off-by: Arnaldo Carvalho de Melo Test results on the signed tag at: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tag/?h=perf-tools

Re: [PATCH v3 2/2] perf stat: Support regex pattern in --for-each-cgroup

2020-10-27 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 27, 2020 at 02:44:21PM +0100, Jiri Olsa escreveu: > On Tue, Oct 27, 2020 at 04:28:55PM +0900, Namhyung Kim wrote: > > To make the command line even more compact with cgroups, support regex > > pattern matching in cgroup names. > > > > $ perf stat -a -e cpu-clock,cycles

Re: [PATCH 1/2] perf tools: Add --quiet option to perf stat

2020-10-27 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 26, 2020 at 05:27:36PM -0700, Andi Kleen escreveu: > Add a new --quiet option to perf stat. This is useful with perf stat > record to write the data only to the perf.data file, which can lower > measurement overhead because the data doesn't need to be formatted. > > On my 4C desktop:

Re: [PATCH v2 0/2] perf PMU events test: Add scenario for arch std events

2020-10-27 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 22, 2020 at 07:02:25PM +0800, John Garry escreveu: > The small series covers the following: > - Tidy error handling in jevents a bit > - Expands on PMU events test to cover jevents arch std events support > > Differences to v1: > - Revert to original logic in jevents.c error path

Re: [PATCH] perf vendor events: Fix DRAM_BW_Use 0 issue for CLX/SKX

2020-10-27 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 22, 2020 at 06:02:31PM -0700, Ian Rogers escreveu: > On Thu, Oct 22, 2020 at 5:54 PM Jin Yao wrote: > > > > Ian reports an issue that the metric DRAM_BW_Use often remains 0. > > > > The metric expression for DRAM_BW_Use on CLX/SKX: > > > > "( 64 * ( uncore_imc@cas_count_read@ +

Re: [PATCH] perf trace beauty: Allow header files in a different path

2020-10-27 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 22, 2020 at 07:09:12PM -0700, Ian Rogers escreveu: > On Thu, Oct 22, 2020 at 7:06 PM Namhyung Kim wrote: > > > > Current script to generate mmap flags and prot checks headers from the > > uapi/asm-generic directory but it might come from a different > > directory in some environment.

Re: [PATCHv5] perf kvm: add kvm-stat for arm64

2020-10-27 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 27, 2020 at 03:24:21PM +0900, Sergey Senozhatsky escreveu: > Add support for perf kvm stat on arm64 platform. > > Example: > # perf kvm stat report > > Analyze events for all VMs, all VCPUs: > > VM-EXITSamples Samples% Time%Min TimeMax Time > Avg time

Re: [PATCH v2 2/2] perf stat: Support regex pattern in --for-each-cgroup

2020-10-26 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 26, 2020 at 09:32:34PM +0900, Namhyung Kim escreveu: > Hi Jiri, > > On Mon, Oct 26, 2020 at 8:40 PM Jiri Olsa wrote: > > > > On Sat, Oct 24, 2020 at 11:59:18AM +0900, Namhyung Kim wrote: > > > To make the command line even more compact with cgroups, support regex > > > pattern

Re: Segfault in pahole 1.18 when building kernel 5.9.1 for arm64

2020-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2020 at 08:53:16AM -0700, Andrii Nakryiko escreveu: > On Wed, Oct 21, 2020 at 6:48 AM Arnaldo Carvalho de Melo > wrote: > > > > Em Wed, Oct 21, 2020 at 08:22:40AM +0200, Jiri Slaby escreveu: > > > On 20. 10. 20, 14:20, Arnaldo Carvalho de Melo wrote

Re: Segfault in pahole 1.18 when building kernel 5.9.1 for arm64

2020-10-21 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 21, 2020 at 08:22:40AM +0200, Jiri Slaby escreveu: > On 20. 10. 20, 14:20, Arnaldo Carvalho de Melo wrote: > > > Yeah, I observe the very same. I reported it at: > > > https://bugzilla.suse.com/show_bug.cgi?id=1177921 > > Would it be possible to try with >

Re: Segfault in pahole 1.18 when building kernel 5.9.1 for arm64

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2020 at 03:14:59PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Oct 20, 2020 at 10:10:19AM -0700, Andrii Nakryiko escreveu: > > On Tue, Oct 20, 2020 at 10:05 AM Hao Luo wrote: > > > Thanks for reporting this and cc'ing me. I forgot to update the error &

Re: Segfault in pahole 1.18 when building kernel 5.9.1 for arm64

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2020 at 10:10:19AM -0700, Andrii Nakryiko escreveu: > On Tue, Oct 20, 2020 at 10:05 AM Hao Luo wrote: > > Thanks for reporting this and cc'ing me. I forgot to update the error > > messages when renaming the flags. I will send a patch to fix the error > > message. > > The commit

Re: Segfault in pahole 1.18 when building kernel 5.9.1 for arm64

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2020 at 11:01:39AM +0200, Jiri Slaby escreveu: > Hi, > > On 19. 10. 20, 1:18, Érico Rolim wrote: > > I'm trying to build kernel 5.9.1 for arm64, and my dotconfig has > > `CONFIG_DEBUG_INFO_BTF=y`, which requires pahole for building. However, > > pahole > > version 1.18 segfaults

Re: [PATCH] perf test: Implement skip_reason callback for watchpoint tests

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2020 at 03:07:15PM +0900, Namhyung Kim escreveu: > Hello, > On Fri, Oct 16, 2020 at 10:17 PM Tommi Rantala > wrote: > > > > Currently reason for skipping the read only watchpoint test is only seen > > when running in verbose mode: > > > > $ perf test watchpoint > > 23:

Re: [PATCH] perf tools: Fix crash with non-jited bpf progs

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 19, 2020 at 10:53:43PM +0200, Jiri Olsa escreveu: > On Fri, Oct 16, 2020 at 02:47:18PM +0300, Tommi Rantala wrote: > > The addr in PERF_RECORD_KSYMBOL events for non-jited bpf progs points to > > the bpf interpreter, ie. within kernel text section. When processing the > > unregister

Re: [PATCH v6 0/2] perf: Make tsc testing as a common testing case

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2020 at 08:11:59AM +0200, Jiri Olsa escreveu: > On Mon, Oct 19, 2020 at 06:02:34PM +0800, Leo Yan wrote: > > This patch set is to move tsc testing from x86 specific to common > > testing case. Since Arnaldo found the building failure for patch set > > v4 [1], the first four

Re: [PATCH] perf mem2node: Improve warning if detected no memory nodes

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 20, 2020 at 08:06:27AM +0200, Jiri Olsa escreveu: > On Mon, Oct 19, 2020 at 08:36:13AM +0800, Leo Yan wrote: > > Some archs (e.g. x86 and Arm64) don't enable the configuration > > CONFIG_MEMORY_HOTPLUG by default, if this configuration is not enabled > > when build the kernel image,

Re: [PATCH] perf version: Add a feature for libpfm4.

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 19, 2020 at 04:25:45PM -0700, Ian Rogers escreveu: > If perf is built with libpfm4 (LIBPFM4=1) then advertise it in perf -vv. Thanks, applied. - Arnaldo > Signed-off-by: Ian Rogers > --- > tools/perf/builtin-version.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v1 0/2] doc/admin-guide: update perf-security.rst with CAP_PERFMON usage flows

2020-10-20 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 19, 2020 at 08:15:14PM +0300, Alexey Budankov escreveu: > > Assignment of CAP_PERFMON [1] Linux capability to an executable located > on a file system requires extended attributes (xattrs) [2] to be supported > by the file system. Even if the file system supports xattrs an fs device >

[GIT PULL] perf tools changes for v5.10

2020-10-15 Thread Arnaldo Carvalho de Melo
8 PMU vendor events JSON files. - Hide libtraceevent non API functions. Signed-off-by: Arnaldo Carvalho de Melo Test results in the signed tag. Adrian Hunter (9): perf tools: Consolidate --control option parsing into one function perf tools: Handle read errors from ctl_fd perf tools

Re: perf test 67 dumps core on linux v5.9

2020-10-15 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 15, 2020 at 05:09:17PM +0200, Jiri Olsa escreveu: > ah when puting it on top of perf/core I found it's already fixed there: > a55b7bb1c146 (tag: perf-tools-tests-v5.10-2020-09-28) perf test: Fix msan > uninitialized use. > so we should be fine For 5.10, yes, but probably we need

Re: [PATCH v1 0/8] perf c2c: Sort cacheline with LLC load

2020-10-15 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 15, 2020 at 03:50:33PM +0100, Leo Yan escreveu: > If the memory event doesn't contain HITM tag (like Arm SPE), it cannot > rely on HITM display to report cache false sharing. Alternatively, we > can use the LLC access and multi-threads info to locate the potential > false sharing's

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-15 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 14, 2020 at 06:46:12PM +0100, John Garry escreveu: > On 14/10/2020 17:49, Arnaldo Carvalho de Melo wrote: > > Ok, applied, > > Thanks > > > please consider adding a Fixes tag next time. > > > > Can do if it helps, but I only thought it approp

Re: [PATCH v2] perf bench: Use condition variables in numa.

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 14, 2020 at 06:14:18PM +0200, Jiri Olsa escreveu: > On Wed, Oct 14, 2020 at 08:39:51AM -0700, Ian Rogers wrote: > > The pthread_mutex_lock avoids any race on g->nr_tasks_started and > > g->p.nr_tasks is set up in init() along with all the global state. I > > don't think there's any

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 01:24:19PM +0200, Jiri Olsa escreveu: > On Mon, Oct 12, 2020 at 12:15:04PM +0100, John Garry wrote: > > On 12/10/2020 11:54, Jiri Olsa wrote: > > > > ff --git a/tools/perf/pmu-events/jevents.c > > > > b/tools/perf/pmu-events/jevents.c > > > > index

Re: [PATCH] perf: Improve PT documentation slightly

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 13, 2020 at 08:53:46PM -0700, Andi Kleen escreveu: > Document the higher level --insn-trace etc. perf script options. > > Include the howto how to build xed into the manpage Thanks, applied. > Cc: adrian.hun...@intel.com > Signed-off-by: Andi Kleen > --- >

Re: [PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 14, 2020 at 03:21:46PM +0200, Jiri Olsa escreveu: > On Wed, Oct 14, 2020 at 08:59:08AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 13, 2020 at 09:24:39PM +0200, Jiri Olsa escreveu: > > > We do not store size with build ids in perf data, > > > but

Re: [PATCH v2] perf: Add support for exclusive groups/events

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 14, 2020 at 07:42:55AM -0700, Andi Kleen escreveu: > Peter suggested that using the exclusive mode in perf could > avoid some problems with bad scheduling of groups. Exclusive > is implemented in the kernel, but wasn't exposed by the perf tool, > so hard to use without custom low level

Re: [PATCH] perf: sched: Show start of latency as well

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 14, 2020 at 11:05:17AM -0400, j...@joelfernandes.org escreveu: > On Tue, Oct 13, 2020 at 09:37:48AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sat, Sep 26, 2020 at 11:45:39AM -0400, Joel Fernandes escreveu: > > > On Sat, Sep 26, 2020 at 10:10 AM N

Re: [PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 13, 2020 at 09:24:39PM +0200, Jiri Olsa escreveu: > We do not store size with build ids in perf data, > but there's enough space to do it. Adding misc bit > PERF_RECORD_MISC_BUILD_ID_SIZE to mark build id event > with size. > > With this fix the dso with md5 build id will have correct

Re: [PATCH 7/9] perf tools: Add size to struct perf_record_header_build_id

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 13, 2020 at 09:24:39PM +0200, Jiri Olsa escreveu: > We do not store size with build ids in perf data, > but there's enough space to do it. Adding misc bit > PERF_RECORD_MISC_BUILD_ID_SIZE to mark build id event > with size. > > With this fix the dso with md5 build id will have correct

Re: [PATCH 5/9] perf tools: Pass build_id object to dso__set_build_id

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 13, 2020 at 09:24:37PM +0200, Jiri Olsa escreveu: > Passing build_id object to dso__set_build_id, so it's easier > to initialize dos's build id object. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa > --- > tools/perf/util/dso.c| 4 ++-- > tools/perf/util/dso.h

Re: [PATCH RESEND 1/1] perf build: Allow nested externs to enable BUILD_BUG() usage

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 08:59:36AM +1100, Stephen Rothwell escreveu: > Hi all, > > On Fri, 9 Oct 2020 14:41:11 +0200 Jiri Olsa wrote: > > > > On Fri, Oct 09, 2020 at 02:25:23PM +0200, Vasily Gorbik wrote: > > > Currently BUILD_BUG() macro is expanded to smth like the following: > > >do { > >

Re: [PATCH RESEND 1/1] perf build: Allow nested externs to enable BUILD_BUG() usage

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 09, 2020 at 02:41:11PM +0200, Jiri Olsa escreveu: > On Fri, Oct 09, 2020 at 02:25:23PM +0200, Vasily Gorbik wrote: > > Currently BUILD_BUG() macro is expanded to smth like the following: > >do { > >extern void __compiletime_assert_0(void) > >

Re: [PATCH v1 03/15] perf data: open data directory in read access mode

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 07:52:33PM +0300, Alexey Budankov escreveu: > > On 12.10.2020 19:03, Andi Kleen wrote: > > On Mon, Oct 12, 2020 at 11:55:07AM +0300, Alexey Budankov wrote: > >> > >> Open files located at data directory in case of read access mode. > > > > Need some rationale. Is this a

Re: [PATCH v1 00/15] Introduce threaded trace streaming for basic perf record operation

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 11:50:29AM +0300, Alexey Budankov escreveu: > > Patch set provides threaded trace streaming for base perf record > operation. Provided streaming mode (--threads) mitigates profiling > data losses and resolves scalability issues of serial and asynchronous > (--aio) trace

Re: [PATCH] perf c2c: Update usage for showing memory events

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 08:25:42AM -0700, Ian Rogers escreveu: > On Mon, Oct 12, 2020 at 2:13 AM Jiri Olsa wrote: > > > > On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote: > > > Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to > > > show the default events used"),

Re: [PATCH 1/9] perf tools: Add build id shell test

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 30, 2020 at 07:15:04PM +0200, Jiri Olsa escreveu: > Adding test for build id cache that adds binary > with sha1 and md5 build ids and verifies it's > added properly. > > The test updates build id cache with perf record > and perf buildid-cache -a. [root@five ~]# perf test "build id"

Re: [PATCH v2 00/14] perf arm-spe: Refactor decoding & dumping flow

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 29, 2020 at 02:39:03PM +0100, Leo Yan escreveu: > The prominent issue for the SPE trace decoding and dumping is the packet > header and payload values are hard coded with numbers and it's not > readable and difficult to maintain; and has other minor issues, e.g. the > packet length

Re: [PATCH 4/5] perf: arm_spe: Decode memory tagging properties

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 13, 2020 at 11:51:03AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sun, Sep 27, 2020 at 11:19:18AM +0800, Leo Yan escreveu: > > On Tue, Sep 22, 2020 at 11:12:24AM +0100, Andre Przywara wrote: > > > When SPE records a physical address, it can addition

Re: [PATCHv4] perf kvm: add kvm-stat for arm64

2020-10-13 Thread Arnaldo Carvalho de Melo
my perf/core branch? - Arnaldo [acme@five perf]$ b4 am -csl 20200929033450.GB529@jagdpanzerIV.localdomain Looking up https://lore.kernel.org/r/20200929033450.GB529%40jagdpanzerIV.localdomain Grabbing thread from lore.kernel.org/linux-arm-kernel Analyzing 2 messages in the thread --- Writing

Re: [PATCH] perf: sched: Show start of latency as well

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 26, 2020 at 11:45:39AM -0400, Joel Fernandes escreveu: > On Sat, Sep 26, 2020 at 10:10 AM Namhyung Kim wrote: > [...] > > On Sat, Sep 26, 2020 at 8:56 AM Joel Fernandes (Google) > > wrote: > > > > > > perf sched latency is really useful at showing worst-case latencies that > > >

Re: [PATCH] perf: sched: Show start of latency as well

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 26, 2020 at 11:10:46PM +0900, Namhyung Kim escreveu: > Hi Joel, > > On Sat, Sep 26, 2020 at 8:56 AM Joel Fernandes (Google) > wrote: > > > > perf sched latency is really useful at showing worst-case latencies that > > task > > encountered since wakeup. However it shows only the end

Re: [PATCH] perf vendor events: Fix typos in power8 PMU events

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 01:21:26PM +0530, kajoljain escreveu: > > > On 10/12/20 10:32 AM, Sandipan Das wrote: > > This replaces the incorrectly spelled word "localtion" > > with "location" in some power8 PMU event descriptions. > > Patch looks good to me, Thanks for correcting it. > >

Re: [PATCHSET v4 0/6] perf inject: Speed build-id injection

2020-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 04:02:08PM +0900, Namhyung Kim escreveu: > Hello, > > This is the new version of speed up build-id injection. As this is > to improve performance, I've added a benchmark for it. Please look at > the usage in the first commit. > > By default, it measures average

Re: [PATCH] perf stat: Fix segfault on armv8_pmu events

2020-10-07 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 07, 2020 at 01:42:19PM +0200, Jiri Olsa escreveu: > On Wed, Oct 07, 2020 at 05:13:11PM +0900, Namhyung Kim wrote: > > It was reported that perf stat crashed when using with armv8_pmu (cpu) > > events with the task mode. As perf stat uses an empty cpu map for > > task mode but

ANNOUNCE: pahole v1.18 (raw data pretty printer, BTF global vars)

2020-10-02 Thread Arnaldo Carvalho de Melo
ressed files, the later being just flatly refused, that got left for v1.19. - Bail out on partial units for now, avoiding segfaults and providing warning to user, hopefully will be addressed in v1.19. Signed-off-by: Arnaldo Carvalho de Melo

Re: [PATCHv2 1/9] perf tools: Add build id shell test

2020-10-02 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers escreveu: > On Fri, Oct 2, 2020 at 6:07 AM Namhyung Kim wrote: > > > > Hi Jiri, > > > > On Fri, Oct 2, 2020 at 4:05 AM Jiri Olsa wrote: > > > > > > Adding test for build id cache that adds binary > > > with sha1 and md5 build ids and verifies

Re: [PATCH] perf tools: Fix printable strings in python3 scripts

2020-10-01 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 28, 2020 at 10:11:35PM +0200, Jiri Olsa escreveu: > Hagen reported broken strings in python3 tracepoint scripts: > > make PYTHON=python3 > ./perf record -e sched:sched_switch -a -- sleep 5 > ./perf script --gen-script py > ./perf script -s ./perf-script.py > > [..] >

Re: [PATCH v4] tools lib traceevent: Hide non API functions

2020-09-30 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 30, 2020 at 12:50:27PM -0400, Steven Rostedt escreveu: > On Wed, 30 Sep 2020 14:07:33 +0300 > "Tzvetomir Stoyanov (VMware)" wrote: > > > There are internal library functions, which are not declared as a static. > > They are used inside the library from different files. Hide them from

Re: perf script, libperf: python binding bug (bytearrays vs. strings)

2020-09-28 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 28, 2020 at 03:39:42PM +0200, Jiri Olsa escreveu: > On Mon, Sep 28, 2020 at 12:43:11PM +0200, Hagen Paul Pfeifer wrote: > > * Jiri Olsa | 2020-09-28 12:08:08 [+0200]: > > > > >patch below fixes it for me, but seems strange this was > > >working till now.. maybe you're the only one

<    1   2   3   4   5   6   7   8   9   10   >