Re: [PATCH] perf: add psw_idle and psw_idle_exit to list of idle symbols

2020-08-04 Thread Arnaldo Carvalho de Melo
idle_exit", > > NULL > > }; > > int i; > > gentle ping? This was merged already: commit 19bf119ccfa071b73a54465e8082ab2c8f8c30eb Author: Sven Schnelle AuthorDate: Tue Jul 7 19:14:55 2020 +0200 Commit: Arnaldo Carvalho de Melo CommitDate: Tue Jul 7 16:44:57 2020 -0300 perf symbols: Add s390 idle functions 'psw_idle' and 'psw_idle_exit' to list of idle symbols

Re: [PATCH v2] perf evsel: Don't set sample_regs_intr/sample_regs_user for dummy event

2020-08-04 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 04, 2020 at 10:06:56AM +0300, Adrian Hunter escreveu: > On 29/07/20 10:23 am, Jin, Yao wrote: > > Hi Adrian, > > > > Could you help to check if following condition will break PT? > > > > "(opts->sample_intr_regs && !evsel->no_aux_samples && > > !evsel__is_dummy_event(evsel))" > >

Re: [PATCHv4 00/19] perf metric: Add support to reuse metric

2020-08-03 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 03, 2020 at 06:26:36PM +0200, Jiri Olsa escreveu: > On Mon, Aug 03, 2020 at 08:54:16AM -0700, Ian Rogers wrote: > > On Sat, Aug 1, 2020 at 4:41 AM Paul A. Clarke wrote: > > > > > > On Wed, Jul 29, 2020 at 11:18:49AM +0200, Jiri Olsa wrote: > > > > this patchset is adding the support

Re: [PATCH v2 2/2] perf pmu: Improve CPU core PMU HW event list ordering

2020-08-03 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 03, 2020 at 09:00:06AM +0100, John Garry escreveu: > On 17/06/2020 13:15, Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 17, 2020 at 08:31:02PM +0900, Namhyung Kim escreveu: > > > On Wed, Jun 17, 2020 at 6:06 PM John Garry wrote: > > > > For perf l

[GIT PULL] Fourth batch of perf tooling fixes for v5.8

2020-08-01 Thread Arnaldo Carvalho de Melo
Carvalho de Melo Ben Hutchings (1): libtraceevent: Fix build with binutils 2.35 Philippe Duplessis-Guindon (1): tools lib traceevent: Fix memory leak in process_dynamic_array_len Thomas Richter (1): perf tests: Fix test 68 zstd compression for s390 Wei Li (1): perf tools: Fix

Re: [PATCH 0/6] perf tools: Add wallclock time conversion support

2020-08-01 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 31, 2020 at 06:46:21PM -0600, David Ahern escreveu: > On 7/31/20 12:05 PM, pet...@infradead.org wrote: > > On Fri, Jul 31, 2020 at 08:36:12AM -0700, Andi Kleen wrote: > >>> yep, we have a customer that needs to compare data from multiple servers > >> It's also needed to correlate over

Re: [PATCH v7 00/18] perf: ftrace enhancement

2020-07-31 Thread Arnaldo Carvalho de Melo
On July 31, 2020 2:35:20 PM GMT-03:00, Changbin Du wrote: >Hi Arnaldo, >Are we ready to merge this serias now Thanks. :) Next week I'll be in vacation, do I'll have more time for upstream stuff, - Arnaldo > >On Sat, Jul 18, 2020 at 02:48:08PM +0800, Changbin Du wrote: >> The perf has

Re: [PATCH] tools lib traceevent: Fix memory leak in process_dynamic_array_len

2020-07-31 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 30, 2020 at 05:28:43PM -0400, Steven Rostedt escreveu: > > Arnaldo, > > Can you pull this into your tree under urgent? > > > https://lore.kernel.org/linux-trace-devel/20200730150236.5392-1-pduples...@efficios.com/ > > Reviewed-by: Steven Rostedt (VMware) Sure, will get it and

Re: [perf] Explicitly use python[3]-[config]

2020-07-30 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 30, 2020 at 12:06:55PM +0200, Sedat Dilek escreveu: > Hi, > > I wanted to have some detailed numbers for building a Linux-kernel > with GNU-eco-system means GNU/gcc-10 and GNU/binutils-2,35 VS. > LLVM/Clang with its utils version 11.0.0-rc1. > > Arnd recommended me to use "perf stat

Re: [PATCH -next] tools build: Check return value of fwrite_unlocked in jvmti_agent.c

2020-07-30 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 29, 2020 at 04:47:36PM -0700, Ian Rogers escreveu: > On Fri, Jul 24, 2020 at 3:07 AM Wang ShaoBo > wrote: > > > > Function jvmti_write_code called by compiled_method_load_cb may return > > error in using fwrite_unlocked, this failure should be captured and > > warned. > > > >

Re: [PATCH -next] tools build: Check return value of fwrite_unlocked in jvmti_agent.c

2020-07-29 Thread Arnaldo Carvalho de Melo
On July 29, 2020 8:47:36 PM GMT-03:00, Ian Rogers wrote: >On Fri, Jul 24, 2020 at 3:07 AM Wang ShaoBo > wrote: >> >> Function jvmti_write_code called by compiled_method_load_cb may >return >> error in using fwrite_unlocked, this failure should be captured and >> warned. >> >> Signed-off-by:

Re: [PATCH] perf bench: Add benchmark of find_next_bit

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 29, 2020 at 04:59:18PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jul 28, 2020 at 08:51:52AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Jul 24, 2020 at 12:19:59AM -0700, Ian Rogers escreveu: > > > for_each_set_bit, or similar functions like for_ea

Re: [PATCH] perf bench: Add benchmark of find_next_bit

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 08:51:52AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Jul 24, 2020 at 12:19:59AM -0700, Ian Rogers escreveu: > > for_each_set_bit, or similar functions like for_each_cpu, may be hot > > within the kernel. If many bits were set then one could imagi

Re: [PATCH v2 4/5] perf record: Don't clear event's period if set by a term

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:33AM -0700, Ian Rogers escreveu: > If events in a group explicitly set a frequency or period with leader > sampling, don't disable the samples on those events. > > Prior to 5.8: > perf record -e '{cycles/period=12345000/,instructions/period=6789000/}:S' > would clear

Re: [PATCH v2 2/5] perf record: Prevent override of attr->sample_period for libpfm4 events

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:31AM -0700, Ian Rogers escreveu: > From: Stephane Eranian > > Before: > $ perf record -c 1 --pfm-events=cycles:period=7 > > Would yield a cycles event with period=1, instead of 7. I tried the equivalent without libpfm and it works: $ perf record

Re: [PATCH v2 1/5] perf record: Set PERF_RECORD_PERIOD if attr->freq is set.

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:30AM -0700, Ian Rogers escreveu: > From: David Sharp > > evsel__config() would only set PERF_RECORD_PERIOD if it set attr->freq There is no such thing as 'PERF_RECORD_PERIOD', its PERF_SAMPLE_PERIOD, also... > from perf record options. When it is set by libpfm

Re: Should perf version match kernel version?

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 29, 2020 at 08:57:04PM +0300, Vitaly Chikunov escreveu: > On Wed, Jul 29, 2020 at 01:27:32PM -0300, Arnaldo Carvalho de Melo wrote: > > On July 29, 2020 1:02:20 PM GMT-03:00, pet...@infradead.org wrote: > > >On Wed, Jul 29, 2020 at 06:56:47PM +0300, Vit

Re: Should perf version match kernel version?

2020-07-29 Thread Arnaldo Carvalho de Melo
On July 29, 2020 1:02:20 PM GMT-03:00, pet...@infradead.org wrote: >On Wed, Jul 29, 2020 at 06:56:47PM +0300, Vitaly Chikunov wrote: >> Hi, >> >> It seems that most distros try to have perf version to match with >> running kernel version. Is is requirement? Would it be better to have >> single

Re: [PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-29 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 29, 2020 at 01:47:01AM +0530, kajoljain escreveu: > > > On 7/28/20 10:56 PM, Ian Rogers wrote: > > On Tue, Jul 28, 2020 at 5:36 AM Arnaldo Carvalho de Melo > > wrote: > >> > >> Em Sun, Jul 19, 2020 at 08:13:17PM +0200, Jiri Olsa escreveu: >

Re: [PATCH v2 1/5] perf record: Set PERF_RECORD_PERIOD if attr->freq is set.

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 05:43:47PM +0200, Jiri Olsa escreveu: > On Tue, Jul 28, 2020 at 01:57:30AM -0700, Ian Rogers wrote: > > From: David Sharp > > > > evsel__config() would only set PERF_RECORD_PERIOD if it set attr->freq > > from perf record options. When it is set by libpfm events, it would

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 03:01:00PM +0200, Jiri Olsa escreveu: > On Tue, Jul 28, 2020 at 02:54:56PM +0200, Jiri Olsa wrote: > > On Tue, Jul 28, 2020 at 09:39:55AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Jul 20, 2020 at 09:16:25PM +0200, Jiri Olsa escreveu: > >

Re: [PATCH 1/3] tools build feature: Use CC and CXX from parent

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 04:42:02PM +0200, Jiri Olsa escreveu: > On Sun, Jul 26, 2020 at 09:08:14PM -0700, Thomas Hebb wrote: > > commit c8c188679ccf ("tools build: Use the same CC for feature detection > > and actual build") changed these assignments from unconditional (:=) to > > conditional (?=)

Re: [PATCH v2 3/5] perf test: Ensure sample_period is set libpfm4 events

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 28, 2020 at 01:57:32AM -0700, Ian Rogers escreveu: > Test that a command line option doesn't override the period set on a > libpfm4 event. > Without libpfm4 test passes as unsupported. Thanks, applied. - Arnaldo

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2020 at 10:59:58AM -0500, Paul A. Clarke escreveu: > On Wed, Jul 22, 2020 at 08:11:58PM +0200, Jiri Olsa wrote: > > On Tue, Jul 21, 2020 at 09:48:48AM -0500, Paul A. Clarke wrote: > > > On Sun, Jul 19, 2020 at 08:13:01PM +0200, Jiri Olsa wrote: > > > > hi, > > > > this patchset is

Re: [PATCHv3 00/19] perf metric: Add support to reuse metric

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 20, 2020 at 09:16:25PM +0200, Jiri Olsa escreveu: > On Mon, Jul 20, 2020 at 02:32:40PM +0530, kajoljain wrote: > > > > > > On 7/20/20 1:49 PM, Jiri Olsa wrote: > > > On Mon, Jul 20, 2020 at 01:39:24PM +0530, kajoljain wrote: > > > > > > SNIP > > > > > >> This is with your

Re: [PATCH 19/19] perf metric: Rename group_list to metric_list

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:51:19PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Following the previous change that rename egroup > > to metric, there's no reason to call the list > > 'group_list' anymore, renaming it to metric_list. > > > > Signed-off-by: Jiri Olsa

Re: [PATCH 17/19] perf metric: Add metric group test

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 03:41:14PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:14 AM Jiri Olsa wrote: > > > > Adding test for metric group plus compute_metric_group > > function to get metrics values within the group. > > > > Signed-off-by: Jiri Olsa > > Acked-by: Ian Rogers

Re: [PATCH 16/19] perf metric: Make compute_single function more precise

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 08:13:17PM +0200, Jiri Olsa escreveu: > So far compute_single function relies on the fact, that > there's only single metric defined within evlist in all > tests. In following patch we will add test for metric > group, so we need to be able to compute metric by given >

Re: [PATCH 15/19] perf metric: Add recursion check when processing nested metrics

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 03:40:26PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:14 AM Jiri Olsa wrote: > > > > Keeping the stack of nested metrics via 'struct expr_id' objects > > and checking if we are in recursion via already processed metric. > > > > The stack is implemented as

Re: [PATCH 13/19] perf metric: Add cache_miss_cycles to metric parse test

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:49:35PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Adding test that compute metric with other metrics in it. > > > > cache_miss_cycles = metric:dcache_miss_cpi + metric:icache_miss_cycles > > > > Acked-by: Ian Rogers > >

Re: [PATCH 14/19] perf metric: Add DCache_L2 to metric parse test

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:49:46PM +0530, kajoljain escreveu: > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Adding test that compute DCache_L2 metrics with other related metrics in it. > > > > Acked-by: Ian Rogers > > Signed-off-by: Jiri Olsa > > Reviewed-By : Kajol Jain Thanks, applied. -

Re: [PATCH 12/19] perf metric: Add events for the current list

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 03:34:48PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:14 AM Jiri Olsa wrote: > > > > There's no need to iterate the whole list of groups, > > when adding new events. The currently created groups > > are the ones we want to add. > > > > Signed-off-by: Jiri

Re: [PATCH 11/19] perf metric: Compute referenced metrics

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:49:04PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Adding computation (expr__parse call) of referenced metric at > > the point when it needs to be resolved during the parent metric > > computation. > > > > Once the inner metric is

Re: [PATCH 10/19] perf metric: Add referenced metrics to hash data

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 03:32:26PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:14 AM Jiri Olsa wrote: > > > > Adding referenced metrics to the parsing context so they > > can be resolved during the metric processing. > > > > Adding expr__add_ref function to store referenced metrics >

Re: [PATCH 08/19] perf metric: Collect referenced metrics in struct metric_ref_node

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 03:18:58PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:13 AM Jiri Olsa wrote: > > > > Collecting referenced metrics in struct metric_ref_node object, > > so we can process them later on. > > > > The change will parse nested metric names out of expression and >

Re: [PATCH 09/19] perf metric: Collect referenced metrics in struct metric_expr

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:48:35PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Add referenced metrics into struct metric_expr object, > > so they are accessible when computing the metric. > > > > Storing just name and expression itself, so the metric > > can be

Re: [PATCH 07/19] perf metric: Rename __metricgroup__add_metric to __add_metric

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:48:05PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Renaming __metricgroup__add_metric to __add_metric > > to fit in the current function names. > > > > Acked-by: Ian Rogers > > Signed-off-by: Jiri Olsa > > Reviewed-By : Kajol Jain

Re: [PATCH 06/19] perf metric: Add add_metric function

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:47:53PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Decouple metric adding logging into add_metric function, > > so it can be used from other places in following changes. > > > > Acked-by: Ian Rogers > > Signed-off-by: Jiri Olsa > >

Re: [PATCH 05/19] perf metric: Add macros for iterating map events

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 02:46:12PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:13 AM Jiri Olsa wrote: > > > > Adding following macros to iterate events and metric: > > map_for_each_event(__pe, __idx, __map) > > - iterates over all pmu_events_map events > >

Re: [PATCH 04/19] perf metric: Add expr__del_id function

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:47:11PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Adding expr__del_id function to remove ID from hashmap. > > It will save us few lines in following changes. > > > > Acked-by: Ian Rogers > > Signed-off-by: Jiri Olsa > > Reviewed-By

Re: [PATCH 03/19] perf metric: Change expr__get_id to return struct expr_id_data

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:47:00PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Changing expr__get_id to use and return struct expr_id_data > > pointer as value for the ID. This way we can access data other > > than value for given ID in following changes. > > > >

Re: [PATCH 02/19] perf metric: Add expr__add_id function

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 26, 2020 at 02:46:47PM +0530, kajoljain escreveu: > > > On 7/19/20 11:43 PM, Jiri Olsa wrote: > > Adding expr__add_id function to data for ID > > with zero value, which is used when scanning > > the expression for IDs. > > > > Reviewed-By : Kajol Jain Thanks, applied. - Arnaldo

Re: [PATCH 01/19] perf metric: Fix memory leak in expr__add_id function

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 19, 2020 at 02:41:46PM -0700, Ian Rogers escreveu: > On Sun, Jul 19, 2020 at 11:13 AM Jiri Olsa wrote: > > > > Arnaldo found that we don't release value data in case the > > hashmap__set fails. Releasing it in case of an error. > > > > Reported-by: Arn

Re: [PATCHv2 2/2] perf tools: Fix term parsing for raw syntax

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 27, 2020 at 08:26:27AM +0800, Jin, Yao escreveu: > > > On 7/27/2020 8:21 AM, Jin, Yao wrote: > > > > > > On 7/26/2020 3:52 PM, Jiri Olsa wrote: > > > Jin Yao reported issue with possible conflict between raw > > > events and term values in pmu event syntax. > > > > > > Currently

Re: [PATCH 1/2] perf tools: Allow r0x event syntax

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Sat, Jul 25, 2020 at 09:40:55AM -0700, Ian Rogers escreveu: > On Sat, Jul 25, 2020 at 5:20 AM Jiri Olsa wrote: > > > > Adding support to specify raw event with 'r0' syntax within > > pmu term syntax like: > > > > -e cpu/r0xdead/ > > > > It will be used to specify raw events in cases where

Re: [PATCH bpf-next v2 35/35] perf: don't touch RLIMIT_MEMLOCK

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 27, 2020 at 11:09:43PM -0700, Andrii Nakryiko escreveu: > On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin wrote: > > > > Since bpf stopped using memlock rlimit to limit the memory usage, > > there is no more reason for perf to alter its own limit. > > > > Signed-off-by: Roman Gushchin

Re: [PATCH -next] tools build: Check return value of fwrite_unlocked in jvmti_agent.c

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 24, 2020 at 06:07:06PM +0800, Wang ShaoBo escreveu: > Function jvmti_write_code called by compiled_method_load_cb may return > error in using fwrite_unlocked, this failure should be captured and > warned. Thanks, applied. - Arnaldo > Signed-off-by: Wang ShaoBo > --- >

Re: [PATCH 0/4] Add support for ARMv8.3-SPE

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 24, 2020 at 05:16:03PM +0800, Wei Li escreveu: > The ARMv8.3-SPE adds an Alignment Flag in the Events packet and filtering > on this event using PMSEVFR_EL1, together with support for the profiling > of Scalable Vector Extension operations. Leo, Matthieu, have you had the time to

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 27, 2020 at 02:34:36PM -0600, Mathieu Poirier escreveu: > On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > > - Firstly, the function auxtrace_record__init() will be invoked only > > once, the variable "arm_spe_pmus" will not be used afterwards, thus > > we don't need to

Re: [PATCH] perf bench: Add benchmark of find_next_bit

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 24, 2020 at 12:19:59AM -0700, Ian Rogers escreveu: > for_each_set_bit, or similar functions like for_each_cpu, may be hot > within the kernel. If many bits were set then one could imagine on > Intel a "bt" instruction with every bit may be faster than the function > call and word

Re: [PATCH v2 2/2] perf tools: ARM SPE code cleanup

2020-07-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 27, 2020 at 02:34:36PM -0600, Mathieu Poirier escreveu: > On Fri, Jul 24, 2020 at 03:11:11PM +0800, Wei Li wrote: > > - Firstly, the function auxtrace_record__init() will be invoked only > > once, the variable "arm_spe_pmus" will not be used afterwards, thus > > we don't need to

Re: [PATCH] tools/perf-bench: Add basic syscall benchmark

2020-07-26 Thread Arnaldo Carvalho de Melo
Em Thu, May 14, 2020 at 03:39:42PM -0500, Josh Poimboeuf escreveu: > On Fri, Mar 08, 2019 at 10:17:47AM -0800, Davidlohr Bueso wrote: > > On Thu, 07 Mar 2019, Arnaldo Carvalho de Melo wrote: > > > You forgot to update tools/perf/Documentation/perf-bench.txt, and please > >

Re: [PATCH v12 11/15] perf stat: implement control commands handling

2020-07-22 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 10:05:06AM +0300, Alexey Budankov escreveu: > > Implement handling of 'enable' and 'disable' control commands coming > from control file descriptor. If poll event splits initiated timeout > interval then the reminder is calculated and still waited in the > following

Re: [PATCH v12 05/15] perf evlist: implement control command handling functions

2020-07-22 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 10:01:33AM +0300, Alexey Budankov escreveu: > > Implement functions of initialization, finalization and processing > of control command messages coming from control file descriptors. > Allocate control file descriptor as descriptor at struct pollfd > object of evsel_list

Re: [PATCH v12 05/15] perf evlist: implement control command handling functions

2020-07-22 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 22, 2020 at 09:27:34AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Jul 17, 2020 at 10:01:33AM +0300, Alexey Budankov escreveu: > > > > Implement functions of initialization, finalization and processing > > of control command messages coming from con

Re: [PATCH v12 05/15] perf evlist: implement control command handling functions

2020-07-22 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 10:01:33AM +0300, Alexey Budankov escreveu: > > Implement functions of initialization, finalization and processing > of control command messages coming from control file descriptors. > Allocate control file descriptor as descriptor at struct pollfd > object of evsel_list

Re: [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-07-22 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 21, 2020 at 04:06:34PM +0300, Alexey Budankov escreveu: > > On 13.07.2020 21:51, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 13, 2020 at 03:37:51PM +0300, Alexey Budankov escreveu: > >> > >> On 13.07.2020 15:17, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH v12 03/15] tools/libperf: avoid counting of nonfilterable fdarray fds

2020-07-21 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 10:00:15AM +0300, Alexey Budankov escreveu: > > Avoid counting of struct pollfd *entries objects with > fdarray_flag__nonfilterable flag by fdarray__filter(). > Nonfilterable objects are still processed if requested > revents have been signaled for them. Thanks, applied.

Re: [PATCH v12 02/15] tools/libperf: add flags to fdarray fds objects

2020-07-21 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 09:59:45AM +0300, Alexey Budankov escreveu: > > Store flags per struct pollfd *entries object in a bitmap of int size. > Implement fdarray_flag__nonfilterable flag to skip object from counting > by fdarray__filter(). Fixed fdarray test issue reported by kernel test >

Re: [PATCH v12 01/15] tools/libperf: avoid internal moving of fdarray fds

2020-07-21 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 09:59:12AM +0300, Alexey Budankov escreveu: > > Avoid moving of fds by fdarray__filter() so fds indices returned > by fdarray__add() can be used for access and processing of > objects at struct pollfd *entries. Thanks, applied. - Arnaldo > Signed-off-by: Alexey

Re: [PATCH v4 0/5] powerpc/perf: Add json file support for hv_24x7 core level events

2020-07-20 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 20, 2020 at 09:21:33PM +0200, Jiri Olsa escreveu: > On Mon, Jul 20, 2020 at 12:31:22PM +0530, Kajol Jain wrote: > > Patchset enhance current runtime parameter support. It introduces new > > fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is > > used to specify

[GIT PULL] perf/urgent improvements and fixes

2020-07-19 Thread Arnaldo Carvalho de Melo
off-by: Arnaldo Carvalho de Melo Arnaldo Carvalho de Melo (2): perf tools: Sync hashmap.h with libbpf's tools arch kvm: Sync kvm headers with the kernel sources Ravi Bangoria (1): libsubcmd: Fix OPT_CALLBACK_SET() tools/arch/x86/include/uapi/asm/kvm.h | 5 +++-- tools/lib/subcmd/pa

Re: [PATCH v5 03/17] perf ftrace: add option -t/--tid to filter by thread id

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 01:53:51PM -0400, Steven Rostedt escreveu: > On Fri, 17 Jul 2020 14:40:53 -0300 Arnaldo Carvalho de Melo > wrote: > > Say you use: > > ^C[root@ssdandy ~]# cyclictest --smp -um -p95 > > # /dev/cpu_dma_latency set to 0us > > policy: fifo:

Re: [PATCH v5 03/17] perf ftrace: add option -t/--tid to filter by thread id

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 01:01:24PM -0400, Steven Rostedt escreveu: > On Fri, 17 Jul 2020 21:26:50 +0800 > Changbin Du wrote: > > > On Thu, Jul 16, 2020 at 12:36:30PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Sat, Jul 11, 2020 at 08:40:21PM +0800, Changbin Du escreve

Re: [PATCH v5 03/17] perf ftrace: add option -t/--tid to filter by thread id

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 09:26:50PM +0800, Changbin Du escreveu: > On Thu, Jul 16, 2020 at 12:36:30PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sat, Jul 11, 2020 at 08:40:21PM +0800, Changbin Du escreveu: > > > +++ b/tools/perf/Documentation/perf-ftrace.txt > > >

Re: [PATCH v5 02/17] perf ftrace: add option '-F/--funcs' to list available functions

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 12:27:40PM -0400, Steven Rostedt escreveu: > On Fri, 17 Jul 2020 13:21:16 -0300 Arnaldo Carvalho de Melo > wrote: > > > Would you like to start contributing to that, and when we get the > > > libtracefs.so packed in distributions, we can easi

Re: [PATCH v5 02/17] perf ftrace: add option '-F/--funcs' to list available functions

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 11:05:04AM -0400, Steven Rostedt escreveu: > On Sat, 11 Jul 2020 20:40:20 +0800 > Changbin Du wrote: > > > This adds an option '-F/--funcs' to list all available functions to trace, > > which is read from tracing file 'available_filter_functions'. > > > > $ sudo ./perf

Re: [PATCH v6 02/17] perf ftrace: add option '-F/--funcs' to list available functions

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 10:36:13PM +0800, Changbin Du escreveu: > This adds an option '-F/--funcs' to list all available functions to trace, > which is read from tracing file 'available_filter_functions'. I'll apply and add a comment stating that this is the same workflow as for 'perf probe',

Re: [PATCH 1/2] libsubcmd: Fix OPT_CALLBACK_SET()

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 09:10:45AM +0530, Ravi Bangoria escreveu: > Hi Arnaldo, > > Can you please consider this trivial fix. Trivial but important, sorry for taking so long, applied to perf/urgent, aimed at v5.8, - Arnaldo > Ravi > > On 6/19/20 7:04 PM, Ravi Bangoria wrote: > > Any option

Re: [PATCH] perf evsel: Don't set sample_regs_intr/sample_regs_user for dummy event

2020-07-17 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 17, 2020 at 04:30:21PM +0800, Jin, Yao escreveu: > > > On 7/17/2020 4:24 PM, Jiri Olsa wrote: > > On Fri, Jul 17, 2020 at 11:33:46AM +0800, Jin, Yao wrote: > > > Hi, > > > > > > On 7/6/2020 8:55 AM, Jin, Yao wrote: > > > > Hi Ian, > > > > > > > > On 7/6/2020 8:47 AM, Ian Rogers

Re: [PATCH v2 1/4] perf-probe: Avoid setting probes on same address on same event

2020-07-16 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 10, 2020 at 10:11:04PM +0900, Masami Hiramatsu escreveu: > There is a case that the several same-name symbols points > same address. In that case, perf probe returns an error. > > E.g. > > perf probe -x /lib64/libc-2.30.so -v -a "memcpy arg1=%di" > probe-definition(0): memcpy

Re: [PATCH v5 03/17] perf ftrace: add option -t/--tid to filter by thread id

2020-07-16 Thread Arnaldo Carvalho de Melo
Em Sat, Jul 11, 2020 at 08:40:21PM +0800, Changbin Du escreveu: > This allows us to trace single thread instead of the whole process. > > Signed-off-by: Changbin Du > --- > tools/perf/Documentation/perf-ftrace.txt | 4 > tools/perf/builtin-ftrace.c | 2 ++ > 2 files changed, 6

Re: [PATCH 03/18] perf metric: Add expr__add_id function

2020-07-16 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 12, 2020 at 03:26:19PM +0200, Jiri Olsa escreveu: > Adding expr__add_id function to data for ID > with zero value, which is used when scanning > the expression for IDs. > > Acked-by: Ian Rogers > Signed-off-by: Jiri Olsa > --- > tools/perf/util/expr.c | 29

Re: [PATCH 02/18] perf metric: Add struct expr_id_data to keep expr value

2020-07-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 14, 2020 at 02:06:23PM -0700, Ian Rogers escreveu: > On Sun, Jul 12, 2020 at 6:26 AM Jiri Olsa wrote: > > > > Adding struct expr_id_data to keep expr value > > instead of just simple double pointer, so we can > > store more data for ID in following changes. > > > > Signed-off-by: Jiri

Re: [PATCH 01/18] perf metric: Rename expr__add_id to expr__add_val

2020-07-16 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 14, 2020 at 02:05:36PM -0700, Ian Rogers escreveu: > On Sun, Jul 12, 2020 at 6:26 AM Jiri Olsa wrote: > > > > Renaming expr__add_id to expr__add_val so we can use > > expr__add_id to actually add just id without any value > > in following changes. > > > > There's no functional change.

Re: [PATCH v3 0/5] powerpc/perf: Add json file support for hv_24x7 core level events

2020-07-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 16, 2020 at 03:12:11PM +0530, Kajol Jain escreveu: > Patchset enhance current runtime parameter support. It introduces new > fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is > used to specify perpkg events. > > The "PerCore" and "PerChip" specifies whether

Re: [PATCH v5 02/17] perf ftrace: add option '-F/--funcs' to list available functions

2020-07-16 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 13, 2020 at 10:49:40AM +0900, Namhyung Kim escreveu: > Hello, > > On Sat, Jul 11, 2020 at 9:42 PM Changbin Du wrote: > > > > This adds an option '-F/--funcs' to list all available functions to trace, > > which is read from tracing file 'available_filter_functions'. > > > > $ sudo

Re: [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-07-14 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 14, 2020 at 12:59:34PM +0200, Peter Zijlstra escreveu: > On Mon, Jul 13, 2020 at 03:51:52PM -0300, Arnaldo Carvalho de Melo wrote: > > > > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > > > index 856d98c36f56..a2397f724c10 100644 >

Re: [PATCH v11 00/15] perf: support enable and disable commands in stat and record modes

2020-07-14 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 14, 2020 at 09:05:10PM +0900, Namhyung Kim escreveu: > Hello, > > On Tue, Jul 14, 2020 at 5:37 PM Alexey Budankov > wrote: > > > > > > Changes in v11: > > - added comments to struct ctl_fd > > - explicitly coded data_size decrement > > Acked-by: Namhyung Kim So, I think v10 had

Re: [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-07-13 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 13, 2020 at 03:37:51PM +0300, Alexey Budankov escreveu: > > On 13.07.2020 15:17, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 13, 2020 at 12:48:25PM +0300, Alexey Budankov escreveu: > >> > >> On 10.07.2020 20:09, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-07-13 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 13, 2020 at 12:48:25PM +0300, Alexey Budankov escreveu: > > On 10.07.2020 20:09, Arnaldo Carvalho de Melo wrote: > > Em Fri, Jul 10, 2020 at 05:30:50PM +0300, Alexey Budankov escreveu: > >> On 10.07.2020 16:31, Ravi Bangoria wrote: > >>>> Curren

Re: [PATCH v2 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 10, 2020 at 07:27:12PM +0530, Srikar Dronamraju escreveu: > * Masami Hiramatsu [2020-07-10 22:11:33]: > > > Warn if the probe target function is GNU indirect function (GNU_IFUNC) > > because it may not what the user want to probe. > > > > The GNU indirect function (

Re: [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 10, 2020 at 05:30:50PM +0300, Alexey Budankov escreveu: > On 10.07.2020 16:31, Ravi Bangoria wrote: > >> Currently access to perf_events, i915_perf and other performance > >> monitoring and observability subsystems of the kernel is open only for > >> a privileged process [1] with

Re: [PATCH] perf kmem: pass additional arguments to record

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 11:39:19AM -0700, Ian Rogers escreveu: > perf kmem has an input file option but current an output file option > fails: > ``` > $ sudo perf kmem record -o /tmp/p.data sleep 1   >  Error: unknown switch `o' > > Usage: perf kmem [] {record|stat} > >    -f, --force          

Re: [PATCH] perf parse-events: report bpf errors

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 08:47:32PM +0200, Jiri Olsa escreveu: > On Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers wrote: > > Setting the parse_events_error directly doesn't increment num_errors > > causing the error message not to be displayed. Use the > > parse_events__handle_error function

Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 10, 2020 at 12:30:08PM +0900, Masami Hiramatsu escreveu: > On Thu, 9 Jul 2020 07:36:54 -0700 > Andi Kleen wrote: > > > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > > > index 1e95a336862c..671176d39569 100644 > > > --- a/tools/perf/util/probe-event.c

Re: [PATCH V7 00/15] perf/x86: Add perf text poke events

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 09:34:23AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Jul 08, 2020 at 02:55:36PM +0300, Adrian Hunter escreveu: > > On 27/05/20 6:54 pm, Peter Zijlstra wrote: > > > On Wed, May 27, 2020 at 12:47:16PM -0300, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH V7 15/15] perf script: Show text poke address symbol

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Tue, May 12, 2020 at 03:19:22PM +0300, Adrian Hunter escreveu: > It is generally more useful to show the symbol with an address. In this > case, the print function requires the 'machine' which means changing > callers to provide it as a parameter. It is optional because most events > do not

Re: [PATCH v2] Fix annotate.c use of uninitialized value error

2020-07-09 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 05:54:47PM -0700, Ian Rogers escreveu: > On Fri, Oct 25, 2019 at 3:11 PM Ian Rogers wrote: > > > > It looks like this wasn't merged to tip. Does anything need addressing > > to get it merged? Finally processed, thanks for the multiple reminders, - Arnaldo > > Thanks, >

Re: [PATCH v3 00/17] perf: ftrace enhancement

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 09, 2020 at 12:45:48AM +0800, Changbin Du escreveu: > Here is a glance of all ftrace functions with this serias: > > $ sudo perf ftrace -h > Usage: perf ftrace [] [] > or: perf ftrace [] -- [] > > -a, --all-cpussystem-wide collection from all CPUs > -C, --cpu

Re: [PATCH v3 09/17] perf: util: add general function to parse sublevel options

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 09, 2020 at 12:45:57AM +0800, Changbin Du escreveu: > This factors out a general function perf_parse_sublevel_options() to parse > sublevel options. The 'sublevel' options is something like the '--debug' > options which allow more sublevel options. Please don't add stuff to

Re: [PATCH] perf parse-events: report bpf errors

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 08:15:24AM -0700, Ian Rogers escreveu: > On Wed, Jul 8, 2020 at 4:19 AM Arnaldo Carvalho de Melo > wrote: > > Em Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers escreveu: > > > Setting the parse_events_error directly doesn't increment num_errors &g

Re: [PATCH V7 00/15] perf/x86: Add perf text poke events

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 02:55:36PM +0300, Adrian Hunter escreveu: > On 27/05/20 6:54 pm, Peter Zijlstra wrote: > > On Wed, May 27, 2020 at 12:47:16PM -0300, Arnaldo Carvalho de Melo wrote: > >> Em Wed, May 20, 2020 at 05:56:34PM +0200, Peter Zijlstra escreveu: > >>>

Re: [PATCH] perf parse-events: report bpf errors

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers escreveu: > Setting the parse_events_error directly doesn't increment num_errors > causing the error message not to be displayed. Use the > parse_events__handle_error function that sets num_errors and handle > multiple errors. What was the

[GIT PULL] Second batch of perf tooling fixes for v5.8

2020-07-07 Thread Arnaldo Carvalho de Melo
time chart call tree perf intel-pt: Fix recording PEBS-via-PT with registers perf intel-pt: Fix displaying PEBS-via-PT with registers perf intel-pt: Fix PEBS sample for XMM registers Andreas Gerstmayr (1): perf flamegraph: Explicitly set utf-8 encoding Arnaldo Carvalho de

Re: [PATCH v2 05/15] perf ftrace: factor out function write_tracing_file_int()

2020-07-07 Thread Arnaldo Carvalho de Melo
Em Sat, Jun 27, 2020 at 09:36:44PM +0800, Changbin Du escreveu: > We will reuse this function later. > > Signed-off-by: Changbin Du > --- > tools/perf/builtin-ftrace.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/builtin-ftrace.c

Re: [PATCH v2 10/15] perf ftrace: add support for trace option sleep-time

2020-07-07 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 07, 2020 at 11:35:14PM +0800, Changbin Du escreveu: > On Fri, Jul 03, 2020 at 03:40:59PM +0900, Namhyung Kim wrote: > > On Sat, Jun 27, 2020 at 10:38 PM Changbin Du wrote: > > > This adds an option '--graph-nosleep-time' which allow us only to measure > > > on-CPU time. This option is

Re: [PATCH] perf/tools/pmu-events/powerpc: Added nest imc metric events

2020-07-06 Thread Arnaldo Carvalho de Melo
Em Sun, Jul 05, 2020 at 06:30:30PM -0700, Ian Rogers escreveu: > On Thu, Jul 2, 2020 at 11:57 PM Kajol Jain wrote: > > > > Added nest imc metric events. > > Acked-by: Ian Rogers Thanks, applied. - Arnaldo > > Signed-off-by: Kajol Jain > > --- > > .../arch/powerpc/power9/nest_metrics.json

Re: [PATCH 1/1] perf report TUI: Remove needless 'dummy' event from menu

2020-07-06 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 03, 2020 at 10:44:28PM +0900, Namhyung Kim escreveu: > Hi Arnaldo, > > On Fri, Jul 3, 2020 at 9:34 PM Arnaldo Carvalho de Melo > wrote: > > > > Please Ack, > > > > - Arnaldo > > > > > > > > Fixing the common case of:

Re: [PATCH v2 07/15] perf ftrace: show trace column header

2020-07-03 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 03, 2020 at 03:20:15PM +0900, Namhyung Kim escreveu: > On Sat, Jun 27, 2020 at 10:38 PM Changbin Du wrote: > > > > This makes perf-ftrace display column header before printing trace. > > > > $ sudo perf ftrace > > \# tracer: function > > \# > > \# entries-in-buffer/entries-written:

<    3   4   5   6   7   8   9   10   11   12   >