Re: [PATCH] net-hsr: Delete unnecessary checks before the function call "kfree_skb"

2015-11-24 Thread Arvid Brodin
will be NULL here, so it could be considered nice form to check for this and not just trust kfree_skb() to do this. I'm not sure what's considered more correct in the kernel, so I will just say that I'm agnostic about this and let others decide. Again, thanks! -- Arvid Brodin ALTEN Sweden ww

Re: [PATCH] net-hsr: Delete unnecessary checks before the function call "kfree_skb"

2015-11-24 Thread Arvid Brodin
least one of these (.skb_hsr or .skb_std) will be NULL here, so it could be considered nice form to check for this and not just trust kfree_skb() to do this. I'm not sure what's considered more correct in the kernel, so I will just say that I'm agnostic about this and let others decide. Ag

Re: [PATCH] fs/proc: Add process text segment md5-summing

2012-11-13 Thread Arvid Brodin
oing this with ptrace just adds > up to extra kernel maintenance for no real point. If my client still wants to run text segment checks, even after the criticism of the idea behind the patch, the above should prove very handy. Thanks! -- Arvid Brodin | Consultant (Linux) XDIN AB | Knarrarnäsg

Re: [PATCH] fs/proc: Add process text segment md5-summing

2012-11-13 Thread Arvid Brodin
On 2012-11-13 00:03, Andrew Morton wrote: > On Mon, 12 Nov 2012 21:36:17 + > Arvid Brodin wrote: > >> Adds /proc//text_md5sum which, when read, calculates an md5sum over >> the process' text segment. This can detect some cases where the system RAM >> has been dist

Re: [PATCH] fs/proc: Add process text segment md5-summing

2012-11-13 Thread Arvid Brodin
On 2012-11-13 00:03, Andrew Morton wrote: On Mon, 12 Nov 2012 21:36:17 + Arvid Brodin arvid.bro...@xdin.com wrote: Adds /proc/pid/text_md5sum which, when read, calculates an md5sum over the process' text segment. This can detect some cases where the system RAM has been disturbed by e.g

Re: [PATCH] fs/proc: Add process text segment md5-summing

2012-11-13 Thread Arvid Brodin
adds up to extra kernel maintenance for no real point. If my client still wants to run text segment checks, even after the criticism of the idea behind the patch, the above should prove very handy. Thanks! -- Arvid Brodin | Consultant (Linux) XDIN AB | Knarrarnäsgatan 7 | SE-164 40 Kista | Sweden

[PATCH] fs/proc: Add process text segment md5-summing

2012-11-12 Thread Arvid Brodin
of executables, where the perpetrator has not bothered to cover up the tracks. Signed-off-by: Arvid Brodin --- I'm not sure which tree this should go into. I made this patch against next-20121112. I had some questions and posted this patch before to get them answered. See http://www.spinics.net

[PATCH] fs/proc: Add process text segment md5-summing

2012-11-12 Thread Arvid Brodin
modifications of executables, where the perpetrator has not bothered to cover up the tracks. Signed-off-by: Arvid Brodin arvid.bro...@xdin.com --- I'm not sure which tree this should go into. I made this patch against next-20121112. I had some questions and posted this patch before to get them answered

Re: fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-11-02 Thread Arvid Brodin
On 2012-11-01 21:29, Arvid Brodin wrote: > On 2012-10-30 23:45, Eric W. Biederman wrote: >> I recommend you checkout the code in security/ima/ looks like it can >> already do what you are trying to do. > > Ah. I did actually check this out a year and a half ago or somethin

Re: fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-11-02 Thread Arvid Brodin
On 2012-11-01 21:29, Arvid Brodin wrote: On 2012-10-30 23:45, Eric W. Biederman wrote: I recommend you checkout the code in security/ima/ looks like it can already do what you are trying to do. Ah. I did actually check this out a year and a half ago or something like that. Seems like

Re: fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-11-01 Thread Arvid Brodin
On 2012-10-30 22:22, Al Viro wrote: > On Tue, Oct 30, 2012 at 09:02:33PM +0000, Arvid Brodin wrote: > >> +config PROC_TEXT_MD5SUM >> +bool "/proc//text_md5sum support" >> +depends on PROC_FS >> +select CRYPTO >> +select CRYPTO_MD5

Re: fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-11-01 Thread Arvid Brodin
On 2012-10-30 23:45, Eric W. Biederman wrote: > Arvid Brodin writes: >> Hi, >> [] Thanks for the info! >> * Any other comments about the code? > > There are known successful attacks against md5 so using md5 for > something new and security related is a bad

Re: fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-11-01 Thread Arvid Brodin
On 2012-10-30 23:45, Eric W. Biederman wrote: Arvid Brodin arvid.bro...@xdin.com writes: Hi, [] Thanks for the info! * Any other comments about the code? There are known successful attacks against md5 so using md5 for something new and security related is a bad idea. Userspace can

Re: fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-11-01 Thread Arvid Brodin
On 2012-10-30 22:22, Al Viro wrote: On Tue, Oct 30, 2012 at 09:02:33PM +, Arvid Brodin wrote: +config PROC_TEXT_MD5SUM +bool /proc/pid/text_md5sum support +depends on PROC_FS +select CRYPTO +select CRYPTO_MD5 +help + Read /proc/pid/text_md5sum to get

fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-10-30 Thread Arvid Brodin
tions), REG("projid_map", S_IRUGO|S_IWUSR, proc_projid_map_operations), #endif +#ifdef CONFIG_PROC_TEXT_MD5SUM + ONE("text_md5sum", S_IRUGO, proc_get_text_md5sum), +#endif }; static int proc_tgid_base_readdir(struct file * filp, -- Arvid Brodin | Consultant (Linux) XDIN AB | Knarrarnäsgatan 7 | SE-164 40 Kista | Sweden | xdin.com

fs/proc/base.c: text md5sums; tgid vs tid; and INF vs ONE?

2012-10-30 Thread Arvid Brodin
, proc_projid_map_operations), #endif +#ifdef CONFIG_PROC_TEXT_MD5SUM + ONE(text_md5sum, S_IRUGO, proc_get_text_md5sum), +#endif }; static int proc_tgid_base_readdir(struct file * filp, -- Arvid Brodin | Consultant (Linux) XDIN AB | Knarrarnäsgatan 7 | SE-164 40 Kista | Sweden | xdin.com

Re: Print long messages to console from kernel module

2008-02-26 Thread Arvid Brodin
On 2008-02-25 23:27, linux-os (Dick Johnson) wrote: > On Mon, 25 Feb 2008, Arvid Brodin wrote: > >> I need to write messages > 1023 characters long to the console from a >> module*. printk() is limited to 1023 characters, and splitting the message >> over several p

Re: Print long messages to console from kernel module

2008-02-26 Thread Arvid Brodin
On 2008-02-25 23:27, linux-os (Dick Johnson) wrote: On Mon, 25 Feb 2008, Arvid Brodin wrote: I need to write messages 1023 characters long to the console from a module*. printk() is limited to 1023 characters, and splitting the message over several printk()'s results in a line break

Print long messages to console from kernel module

2008-02-25 Thread Arvid Brodin
ty and writing to it the way to go? * I'm writing an in-memory logger to be included in a module. The log can be several megabytes. The idea is to use SysRq to print the contents of the log to console after a kernel panic or otherwise when writing to disk might not work. -- Arvid Brodin Enea

Print long messages to console from kernel module

2008-02-25 Thread Arvid Brodin
? * I'm writing an in-memory logger to be included in a module. The log can be several megabytes. The idea is to use SysRq to print the contents of the log to console after a kernel panic or otherwise when writing to disk might not work. -- Arvid Brodin Enea LCC -- To unsubscribe from this list