Move error handling to service thread, and use mtip_set_timeout()
to set timeouts for HDIO_DRIVE_TASK and HDIO_DRIVE_CMD IOCTL commands.
Signed-off-by: Selvan Mani
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 71 +
drivers/block
Move error handling to service thread, and use mtip_set_timeout()
to set timeouts for HDIO_DRIVE_TASK and HDIO_DRIVE_CMD IOCTL commands.
Signed-off-by: Selvan Mani sm...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 71
Add open/close handlers to 'block_device_operations' instance.
Signed-off-by: Selvan Mani
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers
Fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
Signed-off-by: Selvan Mani
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
Fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
Signed-off-by: Selvan Mani sm...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
Add open/close handlers to 'block_device_operations' instance.
Signed-off-by: Selvan Mani sm...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers
is passed on to block drivers.
With respect to the block driver, the device is removed and cleaned up the
data structures. This check will stop I/O to a non-existent device at the
block layer.
Signed-off-by: Asai Thambi S P
---
block/blk-core.c |2 +-
1 files changed, 1 insertions(+), 1
and then remove dfs_parent.
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
index 51628eb..27641bc 100644
--- a/drivers/block/mtip32xx
Increased timeout for STANDBY IMMEDIATE command to 2 minutes.
Signed-off-by: Selvan Mani
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 66 +++-
1 files changed, 35 insertions(+), 31 deletions(-)
diff --git a/drivers/block/mtip32xx
Increased timeout for STANDBY IMMEDIATE command to 2 minutes.
Signed-off-by: Selvan Mani sm...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 66 +++-
1 files changed, 35 insertions(+), 31 deletions
and then remove dfs_parent.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
index 51628eb..27641bc 100644
is passed on to block drivers.
With respect to the block driver, the device is removed and cleaned up the
data structures. This check will stop I/O to a non-existent device at the
block layer.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
block/blk-core.c |2 +-
1 files changed, 1
Fix incorrectly releasing a reference to pci_dev in pci_remove()
Signed-off-by: Rajesh Kumar S
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block
Fix incorrectly releasing a reference to pci_dev in pci_remove()
Signed-off-by: Rajesh Kumar S rsamban...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers
with a PCIe upstream
device with device id 0x5aXX
Signed-off-by: Asai Thambi S P
Signed-off-by: Sam Bradshaw
---
drivers/block/mtip32xx/mtip32xx.c | 53 +
1 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers
with a PCIe upstream
device with device id 0x5aXX
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off-by: Sam Bradshaw sbrads...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 53 +
1 files changed, 53 insertions(+), 0 deletions(-)
diff --git
On 2/26/2014 11:29 AM, Christoph Hellwig wrote:
> Hi all,
>
> with blk-mq stabilizing in mainline and Jens using mtip32xx as tje major
> example drivers in the past is there any progress on getting the
> conversion finished and merged?
We are working on few changes in mtip32xx. After that, we
On 2/26/2014 11:29 AM, Christoph Hellwig wrote:
Hi all,
with blk-mq stabilizing in mainline and Jens using mtip32xx as tje major
example drivers in the past is there any progress on getting the
conversion finished and merged?
We are working on few changes in mtip32xx. After that, we will
Hi Jens,
Please include this for 3.14. It is a trivial change, hope it should be ok.
--
Regards,
Asai
After several experiments, deduced the the optimal number of unaligned
writes to be 2. Changing the value accordingly.
Signed-off-by: Asai Thambi S P
Signed-off-by: Sam Bradshaw
Hi Jens,
Please include this for 3.14. It is a trivial change, hope it should be ok.
--
Regards,
Asai
After several experiments, deduced the the optimal number of unaligned
writes to be 2. Changing the value accordingly.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off
On 07/12/2013 3:59 PM, Asai Thambi S P wrote:
On 5/23/2013 2:23 PM, David Milburn wrote:
Dynamically allocate buf to prevent warnings:
drivers/block/mtip32xx/mtip32xx.c: In function ‘mtip_hw_read_device_status’:
drivers/block/mtip32xx/mtip32xx.c:2823: warning: the frame size of 1056 bytes
On 07/12/2013 3:59 PM, Asai Thambi S P wrote:
On 5/23/2013 2:23 PM, David Milburn wrote:
Dynamically allocate buf to prevent warnings:
drivers/block/mtip32xx/mtip32xx.c: In function ‘mtip_hw_read_device_status’:
drivers/block/mtip32xx/mtip32xx.c:2823: warning: the frame size of 1056 bytes
On 09/08/2013 5:28 PM, Guenter Roeck wrote:
Hi all,
powerpc allmodconfig build on the latest upstream kernel results in:
ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
This is due to commit 15863ff3b (powerpc: Make chip-id information
available to userspace).
Not
On 09/08/2013 5:28 PM, Guenter Roeck wrote:
Hi all,
powerpc allmodconfig build on the latest upstream kernel results in:
ERROR: .cpu_to_chip_id [drivers/block/mtip32xx/mtip32xx.ko] undefined!
This is due to commit 15863ff3b (powerpc: Make chip-id information
available to userspace).
Not
2xx.c:2917: warning: the frame size of 1056 bytes
> is larger than 1024 bytes
>
> Signed-off-by: David Milburn
Acked-by: Asai Thambi S P
> ---
> drivers/block/mtip32xx/mtip32xx.c | 47
> +
> 1 files changed, 37 insertions(+), 10 de
of 1056 bytes
is larger than 1024 bytes
Signed-off-by: David Milburn dmilb...@redhat.com
Acked-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 47
+
1 files changed, 37 insertions(+), 10 deletions(-)
diff --git
On 5/9/2013 11:48 PM, Asai Thambi S P wrote:
>
> This patch add support for SRSI(Surprise Removal Surprise Insertion).
Jens,
Forgot to include. This patch is for 3.10
>
> Approach:
> -
> Surprise Removal:
> -
> On surprise removal of the device
On 5/9/2013 11:48 PM, Asai Thambi S P wrote:
This patch add support for SRSI(Surprise Removal Surprise Insertion).
Jens,
Forgot to include. This patch is for 3.10
Approach:
-
Surprise Removal:
-
On surprise removal of the device, gendisk, request queue, device
:
---
No change, this scenario follows the normal pci probe() function flow.
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 453 ++---
drivers/block/mtip32xx/mtip32xx.h | 18 +-
2 files changed, 289 insertions(+), 182 deletions(-)
diff --git
:
---
No change, this scenario follows the normal pci probe() function flow.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 453 ++---
drivers/block/mtip32xx/mtip32xx.h | 18 +-
2 files changed, 289 insertions(+), 182
Workaround for handling unaligned writes: limit number of outstanding
unaligned writes
Signed-off-by: Sam Bradshaw
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 59 +---
drivers/block/mtip32xx/mtip32xx.h | 11 +++
2 files changed
Workaround for handling unaligned writes: limit number of outstanding
unaligned writes
Signed-off-by: Sam Bradshaw sbrads...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 59 +---
drivers/block/mtip32xx
On 4/14/2013 1:55 PM, Jens Axboe wrote:
> On Fri, Apr 12 2013, Asai Thambi S P wrote:
>>
>> Temporarily disabling TRIM support until TRIM related issues
>> are addressed in the firmware.
>
> How serious is this? We do have released kernels out there with the
> driv
On 4/14/2013 1:55 PM, Jens Axboe wrote:
On Fri, Apr 12 2013, Asai Thambi S P wrote:
Temporarily disabling TRIM support until TRIM related issues
are addressed in the firmware.
How serious is this? We do have released kernels out there with the
driver, you might want to consider a stable
Temporarily disabling TRIM support until TRIM related issues
are addressed in the firmware.
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx
ue.
Reported-by: Dan Carpenter
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 18 --
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
index 32c6780..d11ea92 100644
--- a/d
dan.carpen...@oracle.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 18 --
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
index 32c6780
Temporarily disabling TRIM support until TRIM related issues
are addressed in the firmware.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b
This patch adds a new debugfs entry 'device_status' in
/sys/kernel/debug/rssd. The value of this entry shows
devices online and those in the process of removing.
Signed-off-by: Sam Bradshaw
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 148
Fix to return 0 from pci probe in case of rebuild. If not, pci consider
probe has failed, and crash during rmmod.
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b
To recover from command timeouts, reset the device. In addition
to that improved timeout handling of PIO commands.
Signed-off-by: Sam Bradshaw
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 177 ++---
1 files changed, 87 insertions
Hi Jens,
This patchset includes the following. It was generated against your
for-3.9/drivers
* improved recovery for command timeout
* fix for a crash during rmmod
* add new debugfs entry 'device_status'
Asai Thambi S P (3):
mtip32xx: recovery from command timeout
mtip32xx: return 0 from
Hi Jens,
This patchset includes the following. It was generated against your
for-3.9/drivers
* improved recovery for command timeout
* fix for a crash during rmmod
* add new debugfs entry 'device_status'
Asai Thambi S P (3):
mtip32xx: recovery from command timeout
mtip32xx: return 0 from
To recover from command timeouts, reset the device. In addition
to that improved timeout handling of PIO commands.
Signed-off-by: Sam Bradshaw sbrads...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 177
Fix to return 0 from pci probe in case of rebuild. If not, pci consider
probe has failed, and crash during rmmod.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/block
This patch adds a new debugfs entry 'device_status' in
/sys/kernel/debug/rssd. The value of this entry shows
devices online and those in the process of removing.
Signed-off-by: Sam Bradshaw sbrads...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx
in
* mtip_command_cleanup()
* mtip_timeout_function()
* mtip_handle_tfe()
Signed-off-by: Kent Overstreet
Signed-off-by: Andrew Morton
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 86
in
* mtip_command_cleanup()
* mtip_timeout_function()
* mtip_handle_tfe()
Signed-off-by: Kent Overstreet koverstr...@google.com
Signed-off-by: Andrew Morton a...@linux-foundation.org
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block
On 1/14/2013 9:28 AM, Stephen Rothwell wrote:
> Hi Andrew,
>
> Today's linux-next merge of the akpm tree got a conflict in
> drivers/block/mtip32xx/mtip32xx.c between commit 16c906e51c6f ("mtip32xx:
> Add workqueue and NUMA support") from the tree and commit "mtip32xx:
> convert to batch
On 1/14/2013 9:28 AM, Stephen Rothwell wrote:
Hi Andrew,
Today's linux-next merge of the akpm tree got a conflict in
drivers/block/mtip32xx/mtip32xx.c between commit 16c906e51c6f (mtip32xx:
Add workqueue and NUMA support) from the tree and commit mtip32xx:
convert to batch completion from
When rebuild is in progress, disk->queue is yet to be created. Surprise
removing the device will call remove()-> del_gendisk(). del_gendisk()
expect disk->queue be not NULL. Fix is to call put_disk() when disk_queue
is NULL.
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/m
If an I/O command times out when a PIO command is active,
MTIP_PF_EH_ACTIVE_BIT is not cleared. This results in I/O
hang in the driver. Fix is to clear this bit.
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c |9 +
1 files changed, 5 insertions(+), 4
TRIM support added through vendor unique command.
Signed-off-by: Sam Bradshaw < sbrads...@micron.com>
Signed-off-by: Asai Thambi S P
---
drivers/block/mtip32xx/mtip32xx.c | 96 +
drivers/block/mtip32xx/mtip32xx.h | 18 +++
2 files change
This patch series contain changes for trim support and couple of fixes
Asai Thambi S P (3):
mtip32xx: add trim support
mtip32xx: fix for driver hang after a command timeout
mtip32xx: fix for crash when the device surprise removed during
rebuild
drivers/block/mtip32xx/mtip32xx.c
This patch series contain changes for trim support and couple of fixes
Asai Thambi S P (3):
mtip32xx: add trim support
mtip32xx: fix for driver hang after a command timeout
mtip32xx: fix for crash when the device surprise removed during
rebuild
drivers/block/mtip32xx/mtip32xx.c
TRIM support added through vendor unique command.
Signed-off-by: Sam Bradshaw sbrads...@micron.com
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 96 +
drivers/block/mtip32xx/mtip32xx.h | 18 +++
2 files
If an I/O command times out when a PIO command is active,
MTIP_PF_EH_ACTIVE_BIT is not cleared. This results in I/O
hang in the driver. Fix is to clear this bit.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |9 +
1 files changed, 5
When rebuild is in progress, disk-queue is yet to be created. Surprise
removing the device will call remove()- del_gendisk(). del_gendisk()
expect disk-queue be not NULL. Fix is to call put_disk() when disk_queue
is NULL.
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
---
drivers/block
Removed the dead code in mtip_hw_read_registers() and mtip_hw_read_flags().
Reported-by: Coverity
Signed-off-by: Asai Thambi S P
Signed-off-by: Selvan Mani
---
drivers/block/mtip32xx/mtip32xx.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/block/mtip32xx
Changed printk to be compliant with latest style changes
Signed-off-by: Asai Thambi S P
Signed-off-by: Selvan Mani
---
drivers/block/mtip32xx/mtip32xx.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx
Proper reporting of write protect status on big-endian
Signed-off-by: Asai Thambi S P
Signed-off-by: Selvan Mani
---
drivers/block/mtip32xx/mtip32xx.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx
Increased timeout for standby command to work with larger capacity drives
Signed-off-by: Asai Thambi S P
Signed-off-by: Selvan Mani
---
drivers/block/mtip32xx/mtip32xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block
Return error for NCQ commands when the drive is in security locked state
Signed-off-by: Asai Thambi S P
Signed-off-by: Selvan Mani
---
drivers/block/mtip32xx/mtip32xx.c | 10 +-
drivers/block/mtip32xx/mtip32xx.h |2 ++
2 files changed, 11 insertions(+), 1 deletions(-)
diff --git
Added supported device IDs in pci table
Signed-off-by: Asai Thambi S P
Signed-off-by: Selvan Mani
---
drivers/block/mtip32xx/mtip32xx.c |8 +++-
drivers/block/mtip32xx/mtip32xx.h |8 +++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/block/mtip32xx
This patchset adds support for new devices and few minor changes.
Asai Thambi S P (6):
mtip32xx: Add support for new devices
mtip32xx: Handle NCQ commands during the security locked state
mtip32xx: Increase timeout for standby command
mtip32xx: Proper reporting of write protect status
This patchset adds support for new devices and few minor changes.
Asai Thambi S P (6):
mtip32xx: Add support for new devices
mtip32xx: Handle NCQ commands during the security locked state
mtip32xx: Increase timeout for standby command
mtip32xx: Proper reporting of write protect status
Added supported device IDs in pci table
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off-by: Selvan Mani sm...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |8 +++-
drivers/block/mtip32xx/mtip32xx.h |8 +++-
2 files changed, 14 insertions(+), 2 deletions
Return error for NCQ commands when the drive is in security locked state
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off-by: Selvan Mani sm...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c | 10 +-
drivers/block/mtip32xx/mtip32xx.h |2 ++
2 files changed, 11
Increased timeout for standby command to work with larger capacity drives
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off-by: Selvan Mani sm...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers
Proper reporting of write protect status on big-endian
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off-by: Selvan Mani sm...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/mtip32xx
Changed printk to be compliant with latest style changes
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off-by: Selvan Mani sm...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/mtip32xx
Removed the dead code in mtip_hw_read_registers() and mtip_hw_read_flags().
Reported-by: Coverity
Signed-off-by: Asai Thambi S P asamymuth...@micron.com
Signed-off-by: Selvan Mani sm...@micron.com
---
drivers/block/mtip32xx/mtip32xx.c |6 --
1 files changed, 0 insertions(+), 6 deletions
72 matches
Mail list logo
