On 8/21/24 12:40, Steven Rostedt wrote:
> On Thu, 15 Aug 2024 16:16:33 -0500
> Avadhut Naik wrote:
>
>> diff --git a/include/trace/events/mce.h b/include/trace/events/mce.h
>> index 65aba1afcd07..1e7d5696b3ba 100644
>> --- a/include/trace/events/mce.h
>>
coding FRU Text, it has to be
exported through the mce_record tracepoint so that userspace tools like
the rasdaemon can determine if FRU Text has been reported through the
MCA_SYND1 and MCA_SYND2 registers and output it.
[Yazen: Add Avadhut as co-developer for wrapper changes.]
Co-developed-by: Av
y: Avadhut Naik
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
Signed-off-by: Avadhut Naik
---
Changes in v2:
[1]
https://lore.kernel.org/linux-edac/20240521125434.1555845-1-yazen.ghan...@amd.com/
[2]
https://lore.kernel.org/linux-edac/20240523155641.2805411-1-yazen.ghan...@amd.com
ssage paragraph.]
Suggested-by: Borislav Petkov (AMD)
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
Signed-off-by: Avadhut Naik
---
Changes in v2:
[1]
https://lore.kernel.org/linux-edac/20240521125434.1555845-1-yazen.ghan...@amd.com/
[2]
https://lore.kernel.org/linux
Text contained in them.
[Yazen: Drop Yazen's Co-developed-by tag and moved SoB tag.]
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
Signed-off-by: Avadhut Naik
---
Changes in v2:
[1]
https://lore.kernel.org/linux-edac/20240521125434.1555845-1-yazen.ghan...@amd.com/
flicts.
Links:
v1:
https://lore.kernel.org/linux-edac/20240530211620.1829453-1-avadhut.n...@amd.com/
v2:
https://lore.kernel.org/linux-edac/20240625195624.2565741-1-avadhut.n...@amd.com/
v3:
https://lore.kernel.org/linux-edac/20240730185406.3709876-1-avadhut.n...@amd.com/T/#t
Avadhut Naik (2):
x86/mce: Add wrap
coding FRU Text, it has to be
exported through the mce_record tracepoint so that userspace tools like
the rasdaemon can determine if FRU Text has been reported through the
MCA_SYND1 and MCA_SYND2 registers and output it.
[Yazen: Add Avadhut as co-developer for wrapper changes.]
Co-developed-by: Av
y: Avadhut Naik
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
Signed-off-by: Avadhut Naik
---
Changes in v2:
[1]
https://lore.kernel.org/linux-edac/20240521125434.1555845-1-yazen.ghan...@amd.com/
[2]
https://lore.kernel.org/linux-edac/20240523155641.2805411-1-yazen.ghan...@amd.com
Text contained in them.
[Yazen: Drop Yazen's Co-developed-by tag and moved SoB tag.]
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
Signed-off-by: Avadhut Naik
---
Changes in v2:
[1]
https://lore.kernel.org/linux-edac/20240521125434.1555845-1-yazen.ghan...@amd.com/
ssage paragraph.]
Suggested-by: Borislav Petkov (AMD)
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
Signed-off-by: Avadhut Naik
---
Changes in v2:
[1]
https://lore.kernel.org/linux-edac/20240521125434.1555845-1-yazen.ghan...@amd.com/
[2]
https://lore.kernel.org/linux
h.
Instead, just ensure that the string is NULL terminated.
- Fix SoB chains on all patches to properly reflect the patch path.
Links:
v1:
https://lore.kernel.org/linux-edac/20240530211620.1829453-1-avadhut.n...@amd.com/
v2:
https://lore.kernel.org/linux-edac/20240625195624.2565741-1-avadhut.n...@amd.
s/warnings are ignored to maintain coding style.
[Yazen: Add Avadhut as co-developer for wrapper changes. ]
Co-developed-by: Avadhut Naik
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
---
arch/x86/include/asm/mce.h | 2 ++
arch/x86/kernel/cpu/mce/amd.c | 1 +
arch/x86/kern
y: Avadhut Naik
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
---
arch/x86/kernel/cpu/mce/apei.c | 73 +++---
1 file changed, 59 insertions(+), 14 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/apei.c b/arch/x86/kernel/cpu/mce/apei.c
index b8f4e75fb8a7..7a
ped-by tag and moved SoB tag.]
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
---
arch/x86/include/asm/mce.h | 12
arch/x86/kernel/cpu/mce/amd.c | 5 -
arch/x86/kernel/cpu/mce/core.c | 24 +---
drivers/edac/mce_amd.c | 10 +++---
inc
have been ignored to maintain coding style.
[Yazen: Add last commit message paragraph.]
Suggested-by: Borislav Petkov (AMD)
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
---
arch/x86/include/asm/mce.h | 6 +-
arch/x86/kernel/cpu/mce/amd.c | 29 ++--
arc
.@amd.com/
[2]
https://lore.kernel.org/linux-edac/20240523155641.2805411-1-yazen.ghan...@amd.com/
Changes in v2:
- Drop dependencies on sets [1] and [2] above and rebase on top of
tip/master. (Boris)
Avadhut Naik (2):
x86/mce: Add wrapper for struct mce to export vendor specific info
x86/m
s/warnings are ignored to maintain coding style.
[Yazen: Add Avadhut as co-developer for wrapper changes. ]
Co-developed-by: Avadhut Naik
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
---
arch/x86/include/asm/mce.h | 2 ++
arch/x86/kernel/cpu/mce/apei.c | 2 ++
arch/x86/kern
y: Avadhut Naik
Signed-off-by: Avadhut Naik
Signed-off-by: Yazen Ghannam
---
arch/x86/kernel/cpu/mce/apei.c | 73 +++---
1 file changed, 59 insertions(+), 14 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/apei.c b/arch/x86/kernel/cpu/mce/apei.c
index 4cd6312423c6..8f
From: Avadhut Naik
AMD's Scalable MCA systems viz. Genoa will include two new registers:
MCA_SYND1 and MCA_SYND2.
These registers will include supplemental error information in addition
to the existing MCA_SYND register. The data within the registers is
considered valid if MCA_STATUS[Synd
From: Avadhut Naik
Currently, exporting new additional machine check error information
involves adding new fields for the same at the end of the struct mce.
This additional information can then be consumed through mcelog or
tracepoint.
However, as new MSRs are being added (and will be added in
..@amd.com/
2:
https://lore.kernel.org/linux-edac/20240523155641.2805411-1-yazen.ghan...@amd.com/
Avadhut Naik (2):
x86/mce: Add wrapper for struct mce to export vendor specific info
x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers
Yazen Ghannam (2):
x86/mce/apei: Handle variab
version might result in discrepancies since it can be
changed at runtime.
Export microcode version through the tracepoint to prevent ambiguity over
the active version on the system when the MCE was received.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt (Google
identifier for
the system (or socket in case of multi-socket systems) on which the MCE
has been received.
Also, add a comment explaining the kind of information that can be and
should be added to the tracepoint.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt
7053f50fc3faddab931707f0f
[NOTE:
- Since changes in this version are very minor, have retained the below
tags received for previous versions:
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt (Google)
Reviewed-by: Tony Luck ]
Avadhut Naik (2):
tracing: Include PPIN in mce_re
version might result in discrepancies since it can be
changed at runtime.
Export microcode version through the tracepoint to prevent ambiguity over
the active version on the system when the MCE was received.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt (Google
identifier for
the system (or socket in case of multi-socket systems) on which the MCE
has been received.
Additionally, also change words which are not acronyms from uppercase
(ALL CAPS) to lowercase in tracepoint's output.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
Reviewed-by: S
he the below tags received for previous
versions:
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt (Google)
Reviewed-by: Tony Luck
- Missed adding linux-kernel@vger.kernel.org with v5. Hence, resending.]
Avadhut Naik (2):
tracing: Include PPIN in mce_record tracepoin
version might result in discrepancies since it can be
changed at runtime.
Export microcode version through the tracepoint to prevent ambiguity over
the active version on the system when the MCE was received.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt (Google
identifier for
the system (or socket in case of multi-socket systems) on which the MCE
has been received.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt (Google)
---
include/trace/events/mce.h | 13 -
1 file changed, 12 insertions(+), 1 deletion
been reworked i.e. no code changes have been undertaken for this
version, have the retained the below tags from v3:
Reviewed-by: Sohil Mehta
Reviewed-by: Steven Rostedt (Google) ]
Avadhut Naik (2):
tracing: Include PPIN in mce_record tracepoint
tracing: Include Microcode Revision
Currently, the microcode field (Microcode Revision) of struct mce is not
exported to userspace through the mce_record tracepoint.
Export it through the tracepoint as it may provide useful information for
debug and analysis.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
---
include
information
for debug and analysis.
Signed-off-by: Avadhut Naik
Reviewed-by: Sohil Mehta
---
include/trace/events/mce.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/mce.h b/include/trace/events/mce.h
index 1391ada0da3b..41a5431545e2 100644
--- a
tracepoint.
Changes in v2:
- Export microcode field (Microcode Revision) through the tracepoiont in
addition to PPIN.
Changes in v3:
- Change format specifier for microcode revision from %u to %x
- Fix tab alignments
- Add Reviewed-by: Sohil Mehta
Avadhut Naik (2):
tracing: Include PPIN
Currently, the microcode field (Microcode Revision) of struct mce is not
exported to userspace through the mce_record tracepoint.
Export it through the tracepoint as it may provide useful information for
debug and analysis.
Signed-off-by: Avadhut Naik
---
include/trace/events/mce.h | 7
information
for debug and analysis.
Signed-off-by: Avadhut Naik
---
include/trace/events/mce.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/mce.h b/include/trace/events/mce.h
index 1391ada0da3b..657b93ec8176 100644
--- a/include/trace/events/mce.h
tracepoint.
Changes in v2:
- Export microcode field (Microcode Revision) through the tracepoiont in
addition to PPIN.
Avadhut Naik (2):
tracing: Include PPIN in mce_record tracepoint
tracing: Include Microcode Revision in mce_record tracepoint
include/trace/events/mce.h | 10 --
1
information
for debug and analysis.
Signed-off-by: Avadhut Naik
---
include/trace/events/mce.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/mce.h b/include/trace/events/mce.h
index 1391ada0da3b..657b93ec8176 100644
--- a/include/trace/events/mce.h
37 matches
Mail list logo