Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-04 Thread Azael Avalos
Hi there Let me add my two cents on the Toshiba side. 2018-06-04 8:23 GMT-06:00 Hans de Goede : > > 1) drivers/platform/x86/toshiba_acpi.c > > I don't know how the key on Toshiba's behaves on models where > it is hardwired / under Windows With Toshiba we have two types of hardware

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-04 Thread Azael Avalos
Hi there Let me add my two cents on the Toshiba side. 2018-06-04 8:23 GMT-06:00 Hans de Goede : > > 1) drivers/platform/x86/toshiba_acpi.c > > I don't know how the key on Toshiba's behaves on models where > it is hardwired / under Windows With Toshiba we have two types of hardware

Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-10-19 Thread Azael Avalos
Hi Darren, 2016-10-19 14:26 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Wed, Oct 12, 2016 at 10:26:43AM -0600, Azael Avalos wrote: >> *ping* >> >> 2016-08-28 11:00 GMT-06:00 Darren Hart <dvh...@infradead.org>: >> > On Thu, Aug 25, 2016 at 12:50

Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-10-19 Thread Azael Avalos
Hi Darren, 2016-10-19 14:26 GMT-06:00 Darren Hart : > On Wed, Oct 12, 2016 at 10:26:43AM -0600, Azael Avalos wrote: >> *ping* >> >> 2016-08-28 11:00 GMT-06:00 Darren Hart : >> > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote: >> >>

Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-10-12 Thread Azael Avalos
*ping* 2016-08-28 11:00 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote: >> Bug 150611 uncovered that the WMI ID used by the toshiba-wmi driver >> is not Toshiba specific, and as such, the driver was being loa

Re: [PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-10-12 Thread Azael Avalos
*ping* 2016-08-28 11:00 GMT-06:00 Darren Hart : > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote: >> Bug 150611 uncovered that the WMI ID used by the toshiba-wmi driver >> is not Toshiba specific, and as such, the driver was being loaded >> on no

[PATCH 2/2] toshiba_haps: Change the error logging level from info to debug

2016-09-07 Thread Azael Avalos
Two of the internal functions are printing an info message, one whenever the HDD protection level changes, and another when the driver receives an ACPI event. This patch changes those two prints to debug, as that information is more pertaining to debuging purposes. Signed-off-by: Azael Avalos

[PATCH] toshiba_bluetooth: Decouple an error checking status code

2016-09-07 Thread Azael Avalos
This patch simply decouples te error checking of the ACPI status and the actual BT status, as those two were nested in an if/else check, but are completely unrelated. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_bluetooth.c | 4 +++- 1 file chan

[PATCH 2/2] toshiba_haps: Change the error logging level from info to debug

2016-09-07 Thread Azael Avalos
Two of the internal functions are printing an info message, one whenever the HDD protection level changes, and another when the driver receives an ACPI event. This patch changes those two prints to debug, as that information is more pertaining to debuging purposes. Signed-off-by: Azael Avalos

[PATCH] toshiba_bluetooth: Decouple an error checking status code

2016-09-07 Thread Azael Avalos
This patch simply decouples te error checking of the ACPI status and the actual BT status, as those two were nested in an if/else check, but are completely unrelated. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_bluetooth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 1/2] toshiba_haps: Split ACPI status error check from HDD protection support

2016-09-07 Thread Azael Avalos
Currently the code checking for the ACPI status is mixed along with the actual HDD protection status check. This patch splits those two checks are they are not related, printing an error string in case the ACPI call failed, and then check for actual HDD protection status. Signed-off-by: Azael

[PATCH 0/2] toshiba_haps: Small updates to driver code

2016-09-07 Thread Azael Avalos
These two patches make some small changes to the driver code, the first splits the error check fro the ACPI status and the HDD protection, and the second simply changes the printing level of two strings from info to debug. Azael Avalos (2): toshiba_haps: Split ACPI status error check from HDD

[PATCH 1/2] toshiba_haps: Split ACPI status error check from HDD protection support

2016-09-07 Thread Azael Avalos
Currently the code checking for the ACPI status is mixed along with the actual HDD protection status check. This patch splits those two checks are they are not related, printing an error string in case the ACPI call failed, and then check for actual HDD protection status. Signed-off-by: Azael

[PATCH 0/2] toshiba_haps: Small updates to driver code

2016-09-07 Thread Azael Avalos
These two patches make some small changes to the driver code, the first splits the error check fro the ACPI status and the HDD protection, and the second simply changes the printing level of two strings from info to debug. Azael Avalos (2): toshiba_haps: Split ACPI status error check from HDD

[PATCH v2 1/3] toshiba_acpi: Clean up variable declaration

2016-08-29 Thread Azael Avalos
This patch moves all the multiple line variable declaration to a single line declaration (except variables being initialized) following the reverse tree order, to conform to the practices of the kernel. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_

[PATCH v2 1/3] toshiba_acpi: Clean up variable declaration

2016-08-29 Thread Azael Avalos
This patch moves all the multiple line variable declaration to a single line declaration (except variables being initialized) following the reverse tree order, to conform to the practices of the kernel. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 33

[PATCH v2 3/3] toshiba_acpi: Fix typo in *_cooling_method_set function

2016-08-29 Thread Azael Avalos
This patch simply fixes a typo in the error string printed in such function. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/pl

[PATCH v2 3/3] toshiba_acpi: Fix typo in *_cooling_method_set function

2016-08-29 Thread Azael Avalos
This patch simply fixes a typo in the error string printed in such function. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index

[PATCH v2 0/3] toshiba_acpi: Functions cleanup

2016-08-29 Thread Azael Avalos
to Darren's comments - Added a missing return on *eco_mode_available function Azael Avalos (3): toshiba_acpi: Clean up variable declaration toshiba_acpi: Change error checking logic from TCI functions toshiba_acpi: Fix typo in *_cooling_method_set function drivers/platform/x86/toshiba_acpi.c

[PATCH v2 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-29 Thread Azael Avalos
the acpi_status and the tci_raw function call error check, as those two are completely unrelated and were nested in if/else statements. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 226 ++-- 1 file changed, 138 inse

[PATCH v2 0/3] toshiba_acpi: Functions cleanup

2016-08-29 Thread Azael Avalos
to Darren's comments - Added a missing return on *eco_mode_available function Azael Avalos (3): toshiba_acpi: Clean up variable declaration toshiba_acpi: Change error checking logic from TCI functions toshiba_acpi: Fix typo in *_cooling_method_set function drivers/platform/x86/toshiba_acpi.c

[PATCH v2 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-29 Thread Azael Avalos
the acpi_status and the tci_raw function call error check, as those two are completely unrelated and were nested in if/else statements. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 226 ++-- 1 file changed, 138 insertions(+), 88 deletions

Re: [PATCH 1/3] toshiba_acpi: Cleanup variable declaration

2016-08-29 Thread Azael Avalos
Hi Darren, 2016-08-28 10:49 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Tue, Aug 16, 2016 at 12:06:15PM -0600, Azael Avalos wrote: >> This patch moves all the multiple line variable declaration to a >> single line declaration (except variables being initialized) >

Re: [PATCH 1/3] toshiba_acpi: Cleanup variable declaration

2016-08-29 Thread Azael Avalos
Hi Darren, 2016-08-28 10:49 GMT-06:00 Darren Hart : > On Tue, Aug 16, 2016 at 12:06:15PM -0600, Azael Avalos wrote: >> This patch moves all the multiple line variable declaration to a >> single line declaration (except variables being initialized) >> following the reverse t

Re: [PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-29 Thread Azael Avalos
Hi Darren, 2016-08-28 10:56 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Tue, Aug 16, 2016 at 12:06:16PM -0600, Azael Avalos wrote: >> Currently the success/error checking logic is intermixed, making the >> code a bit cumbersome to understand. >> >> This pat

Re: [PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-29 Thread Azael Avalos
Hi Darren, 2016-08-28 10:56 GMT-06:00 Darren Hart : > On Tue, Aug 16, 2016 at 12:06:16PM -0600, Azael Avalos wrote: >> Currently the success/error checking logic is intermixed, making the >> code a bit cumbersome to understand. >> >> This patch changes the affect

[PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-08-25 Thread Azael Avalos
, dropping the TOSHIBA_ prefix, to better reflect that such GUID is not a Toshiba specific one. Cc: <sta...@vger.kernel.org> # 4.4+ Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Hi Darren, I was waiting on input from the bug above, but haven't received an answer (as of yet),

[PATCH] toshiba-wmi: Fix loading the driver on non Toshiba laptops

2016-08-25 Thread Azael Avalos
, dropping the TOSHIBA_ prefix, to better reflect that such GUID is not a Toshiba specific one. Cc: # 4.4+ Signed-off-by: Azael Avalos --- Hi Darren, I was waiting on input from the bug above, but haven't received an answer (as of yet), so I decided to send this to the mailing list for feedback

[PATCH 0/3] toshiba_acpi: Functions cleanup

2016-08-16 Thread Azael Avalos
These set of patches make some cleanup in some of the driver's functions. The first patch changes the variables declaration, the second changes the error checking logic and the third simply fixes a typo found while making these changes. Azael Avalos (3): toshiba_acpi: Cleanup variable

[PATCH 3/3] toshiba_acpi: Fix typo in *_cooling_method_set function

2016-08-16 Thread Azael Avalos
This patch simply fixes a typo in the error string printed in such function. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/pl

[PATCH 0/3] toshiba_acpi: Functions cleanup

2016-08-16 Thread Azael Avalos
These set of patches make some cleanup in some of the driver's functions. The first patch changes the variables declaration, the second changes the error checking logic and the third simply fixes a typo found while making these changes. Azael Avalos (3): toshiba_acpi: Cleanup variable

[PATCH 3/3] toshiba_acpi: Fix typo in *_cooling_method_set function

2016-08-16 Thread Azael Avalos
This patch simply fixes a typo in the error string printed in such function. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index

[PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-16 Thread Azael Avalos
the acpi_status and the tci_raw function call error check, as those two are completely unrelated and were nested in if/else statements. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 222 ++-- 1 file changed, 135 inse

[PATCH 1/3] toshiba_acpi: Cleanup variable declaration

2016-08-16 Thread Azael Avalos
This patch moves all the multiple line variable declaration to a single line declaration (except variables being initialized) following the reverse tree order, to conform to the practices of the kernel. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_

[PATCH 2/3] toshiba_acpi: Change error checking logic from TCI functions

2016-08-16 Thread Azael Avalos
the acpi_status and the tci_raw function call error check, as those two are completely unrelated and were nested in if/else statements. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 222 ++-- 1 file changed, 135 insertions(+), 87 deletions

[PATCH 1/3] toshiba_acpi: Cleanup variable declaration

2016-08-16 Thread Azael Avalos
This patch moves all the multiple line variable declaration to a single line declaration (except variables being initialized) following the reverse tree order, to conform to the practices of the kernel. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 98

[PATCH] toshiba_acpi: Fix the kbd_backlight_mode_show printed value

2016-08-16 Thread Azael Avalos
-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 254a4d5..444f351 100644 --- a/drivers/platform/x86/toshiba_acpi.c

[PATCH] toshiba_acpi: Fix the kbd_backlight_mode_show printed value

2016-08-16 Thread Azael Avalos
-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 254a4d5..444f351 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86

Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

2016-06-28 Thread Azael Avalos
2016-06-28 23:16 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Tue, Jun 28, 2016 at 01:58:55PM -0600, Azael Avalos wrote: >> The toshiba_acpi driver added support to the accelerometer axis >> via the IIO subsystem, but failed to add the dependency to the >> Kcon

Re: [PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

2016-06-28 Thread Azael Avalos
2016-06-28 23:16 GMT-06:00 Darren Hart : > On Tue, Jun 28, 2016 at 01:58:55PM -0600, Azael Avalos wrote: >> The toshiba_acpi driver added support to the accelerometer axis >> via the IIO subsystem, but failed to add the dependency to the >> Kconfig file, making the d

[PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

2016-06-28 Thread Azael Avalos
in Kconfig to avoid such build failure. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Darren, Jonathan: I just received a few mails from the kbuild test robot informing the build failure, as a fix for this I just added a hard dependency to IIO, but maybe Jonathan can weigh in and prov

[PATCH] platform/x86: Add IIO dependency to ACPI_TOSHIBA

2016-06-28 Thread Azael Avalos
in Kconfig to avoid such build failure. Signed-off-by: Azael Avalos --- Darren, Jonathan: I just received a few mails from the kbuild test robot informing the build failure, as a fix for this I just added a hard dependency to IIO, but maybe Jonathan can weigh in and provide me with a better alternative

[PATCH v3 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-27 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos <coproscef...@gmail.

[PATCH v3 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-27 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos --- drivers/platform

[PATCH v3 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-27 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.

[PATCH v3 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-27 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 25 - 1 file

[PATCH v3 3/3] toshiba_acpi: Bump driver version and update copyright year

2016-06-27 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file c

[PATCH v3 3/3] toshiba_acpi: Bump driver version and update copyright year

2016-06-27 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 0/3] toshiba_acpi: Accelerometer updates

2016-06-27 Thread Azael Avalos
- Changed the iio code according to feedback from Jonathan Cameron Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove the position sysfs entry toshiba_acpi: Bump driver version and update copyright year drivers/platform/x86/toshiba_acpi.c

[PATCH v3 0/3] toshiba_acpi: Accelerometer updates

2016-06-27 Thread Azael Avalos
- Changed the iio code according to feedback from Jonathan Cameron Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove the position sysfs entry toshiba_acpi: Bump driver version and update copyright year drivers/platform/x86/toshiba_acpi.c

Re: [PATCH v2 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-27 Thread Azael Avalos
Hi Darren, 2016-06-27 18:19 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Sun, Jun 19, 2016 at 05:28:04PM -0600, Azael Avalos wrote: >> This patch adds the accelerometer axis data to the IIO subsystem. >> >> Currently reporting the X, Y and Z values, as no other d

Re: [PATCH v2 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-27 Thread Azael Avalos
Hi Darren, 2016-06-27 18:19 GMT-06:00 Darren Hart : > On Sun, Jun 19, 2016 at 05:28:04PM -0600, Azael Avalos wrote: >> This patch adds the accelerometer axis data to the IIO subsystem. >> >> Currently reporting the X, Y and Z values, as no other data can be >

Re: [PATCH 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-19 Thread Azael Avalos
Hi, Thanks for the feedback, I just did a respin of the series with the changes you mentioned. Cheers Azael 2016-06-19 14:16 GMT-06:00 Jonathan Cameron <ji...@kernel.org>: > On 11/06/16 19:57, Azael Avalos wrote: >> This patch adds the accelerometer axis data to th

Re: [PATCH 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-19 Thread Azael Avalos
Hi, Thanks for the feedback, I just did a respin of the series with the changes you mentioned. Cheers Azael 2016-06-19 14:16 GMT-06:00 Jonathan Cameron : > On 11/06/16 19:57, Azael Avalos wrote: >> This patch adds the accelerometer axis data to the IIO subsystem. >> >>

[PATCH v2 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-19 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos <coproscef...@gmail.

[PATCH v2 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-19 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos --- drivers/platform

[PATCH v2 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-19 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.

[PATCH v2 0/3] toshiba_acpi: Accelerometer updates

2016-06-19 Thread Azael Avalos
Cameron Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove the position sysfs entry toshiba_acpi: Bump driver version and update copyright year drivers/platform/x86/toshiba_acpi.c | 136 +--- 1 file changed

[PATCH v2 3/3] toshiba_acpi: Bump driver version and update copyright year

2016-06-19 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file c

[PATCH v2 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-19 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 25 - 1 file

[PATCH v2 0/3] toshiba_acpi: Accelerometer updates

2016-06-19 Thread Azael Avalos
Cameron Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove the position sysfs entry toshiba_acpi: Bump driver version and update copyright year drivers/platform/x86/toshiba_acpi.c | 136 +--- 1 file changed

[PATCH v2 3/3] toshiba_acpi: Bump driver version and update copyright year

2016-06-19 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-11 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos <coproscef...@gmail.

[PATCH 1/3] toshiba_acpi: Add IIO interface for accelerometer axis data

2016-06-11 Thread Azael Avalos
This patch adds the accelerometer axis data to the IIO subsystem. Currently reporting the X, Y and Z values, as no other data can be queried given the fact that the accelerometer chip itself is hidden behind the Toshiba proprietary interface. Signed-off-by: Azael Avalos --- All: This is my

[PATCH 0/3] toshiba_acpi: Accelerometer updates

2016-06-11 Thread Azael Avalos
These series of patches update the accelerometer axis data reporting to use the IIO subsystem, deprecating the custom position sysfs entry, and finally bumping the driver version to 0.24. Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove

[PATCH 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-11 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.

[PATCH 3/3] toshiba_acpi: Bump driver version and update copyrignt year

2016-06-11 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file c

[PATCH 0/3] toshiba_acpi: Accelerometer updates

2016-06-11 Thread Azael Avalos
These series of patches update the accelerometer axis data reporting to use the IIO subsystem, deprecating the custom position sysfs entry, and finally bumping the driver version to 0.24. Azael Avalos (3): toshiba_acpi: Add IIO interface for accelerometer axis data toshiba_acpi: Remove

[PATCH 2/3] toshiba_acpi: Remove the position sysfs entry

2016-06-11 Thread Azael Avalos
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated. This patch removes all code related to the position sysfs entry. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 29 - 1

[PATCH 3/3] toshiba_acpi: Bump driver version and update copyrignt year

2016-06-11 Thread Azael Avalos
After several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24. Also update the copyright year. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] toshiba_acpi: Fix regression caused by hotkey enabling value

2016-04-25 Thread Azael Avalos
Hi Darren, No problem with me, ohh and thanks, I forgot to include stable. Cheers Azael 2016-04-25 11:31 GMT-06:00 Darren Hart <dvh...@infradead.org>: > On Fri, Apr 22, 2016 at 09:29:36AM -0600, Azael Avalos wrote: >> Commit 52cbae0127ad ("toshiba_acpi: Change default H

Re: [PATCH] toshiba_acpi: Fix regression caused by hotkey enabling value

2016-04-25 Thread Azael Avalos
Hi Darren, No problem with me, ohh and thanks, I forgot to include stable. Cheers Azael 2016-04-25 11:31 GMT-06:00 Darren Hart : > On Fri, Apr 22, 2016 at 09:29:36AM -0600, Azael Avalos wrote: >> Commit 52cbae0127ad ("toshiba_acpi: Change default Hotkey enabling valu

[PATCH] toshiba_acpi: Fix regression caused by hotkey enabling value

2016-04-22 Thread Azael Avalos
ill switch or the pointing device toggle button. This patch reverts such commit by changing the default hotkey enabling value to 0x09, which enables hotkey events only, making the hardware buttons working again. Fixes bugs 113331 and 114941. Signed-off-by: Azael Avalos <coproscef...@gmail.com> ---

[PATCH] toshiba_acpi: Fix regression caused by hotkey enabling value

2016-04-22 Thread Azael Avalos
ill switch or the pointing device toggle button. This patch reverts such commit by changing the default hotkey enabling value to 0x09, which enables hotkey events only, making the hardware buttons working again. Fixes bugs 113331 and 114941. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_

[PATCH] toshiba_acpi: Add a module parameter to disable hotkeys registration

2016-01-25 Thread Azael Avalos
-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 5ace1e0..df1f1a7 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86

[PATCH 0/3] toshiba_acpi: Add support for Cooling Method

2016-01-25 Thread Azael Avalos
. Azael Avalos (3): toshiba_acpi: Add support for cooling method feature toshiba_acpi: Add sysfs entries for th Cooling Method feature Documentation/ABI: Update sysfs-driver-toshiba_acpi file .../ABI/testing/sysfs-driver-toshiba_acpi | 16 drivers/platform/x86/toshiba_acpi.c

[PATCH 3/3] Documentation/ABI: Update sysfs-driver-toshiba_acpi file

2016-01-25 Thread Azael Avalos
This patch updates the documentation file adding the Cooling Method entry. Signed-off-by: Azael Avalos --- Documentation/ABI/testing/sysfs-driver-toshiba_acpi | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-driver-toshiba_acpi b

[PATCH 1/3] toshiba_acpi: Add support for cooling method feature

2016-01-25 Thread Azael Avalos
- Battery Optimized Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 54 + 1 file changed, 54 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 7383307..c6f92ec 100644 --- a/driver

[PATCH 2/2] toshiba_acpi: Add sysfs entries for the Cooling Method feature

2016-01-25 Thread Azael Avalos
This patch adds the sysfs entry Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 51 + 1 file changed, 51 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index c6f92ec..5ace1e0 100644

[PATCH] toshiba_acpi: Add a module parameter to disable hotkeys registration

2016-01-25 Thread Azael Avalos
-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 5ace1e0..df1f1a7 100644 --- a/drivers/platform/x86/toshiba_

[PATCH 2/2] toshiba_acpi: Add sysfs entries for the Cooling Method feature

2016-01-25 Thread Azael Avalos
This patch adds the sysfs entry Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 51 + 1 file changed, 51 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c

[PATCH 0/3] toshiba_acpi: Add support for Cooling Method

2016-01-25 Thread Azael Avalos
. Azael Avalos (3): toshiba_acpi: Add support for cooling method feature toshiba_acpi: Add sysfs entries for th Cooling Method feature Documentation/ABI: Update sysfs-driver-toshiba_acpi file .../ABI/testing/sysfs-driver-toshiba_acpi | 16 drivers/platform/x86/toshiba_acpi.c

[PATCH 1/3] toshiba_acpi: Add support for cooling method feature

2016-01-25 Thread Azael Avalos
- Battery Optimized Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 54 + 1 file changed, 54 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 7383307

[PATCH 3/3] Documentation/ABI: Update sysfs-driver-toshiba_acpi file

2016-01-25 Thread Azael Avalos
This patch updates the documentation file adding the Cooling Method entry. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Documentation/ABI/testing/sysfs-driver-toshiba_acpi | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-

[PATCH] platform/x86: Add rfkill dependency to ACPI_TOSHIBA entry

2015-12-14 Thread Azael Avalos
the build issue. Signed-off-by: Azael Avalos --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 1089eaa..25a02f9 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -64

[PATCH] platform/x86: Add rfkill dependency to ACPI_TOSHIBA entry

2015-12-14 Thread Azael Avalos
the build issue. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 1089eaa..25a02f9 100644 --- a/drivers/platform/x86/Kconfig +++ b/driv

[PATCH v2] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

2015-11-23 Thread Azael Avalos
, to make userspace aware of such change. Signed-off-by: Azael Avalos --- Changes since v1: - Moved the implementation of the toshiba_acpi_kbd_bl_work function further down to make the file compile drivers/platform/x86/toshiba_acpi.c | 47 + 1 file changed, 43

[PATCH v3 1/2] toshiba_acpi: Add support for WWAN devices

2015-11-23 Thread Azael Avalos
), the second queries WWAN support, and finally the third (de)activates the device. Signed-off-by: Fabian Koester Signed-off-by: Azael Avalos ZZ --- drivers/platform/x86/toshiba_acpi.c | 109 1 file changed, 109 insertions(+) diff --git a/drivers/platform/x86

[PATCH v3 2/2] toshiba_acpi: Add WWAN RFKill support

2015-11-23 Thread Azael Avalos
status. Signed-off-by: Fabian Koester Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 79 +++-- 1 file changed, 76 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index

[PATCH v3 0/2] toshiba_acpi: Add WWAN support

2015-11-23 Thread Azael Avalos
to rfkill_unregister and rfkill_destroy functions Azael Avalos (2): toshiba_acpi: Add support for WWAN devices toshiba_acpi: Add WWAN RFKill support drivers/platform/x86/toshiba_acpi.c | 188 +++- 1 file changed, 185 insertions(+), 3 deletions(-) -- 2.6.3

[PATCH v3 2/2] toshiba_acpi: Add WWAN RFKill support

2015-11-23 Thread Azael Avalos
status. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 79 +++-- 1 file changed, 76 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH v3 0/2] toshiba_acpi: Add WWAN support

2015-11-23 Thread Azael Avalos
to rfkill_unregister and rfkill_destroy functions Azael Avalos (2): toshiba_acpi: Add support for WWAN devices toshiba_acpi: Add WWAN RFKill support drivers/platform/x86/toshiba_acpi.c | 188 +++- 1 file changed, 185 insertions(+), 3 deletions(-) -- 2.6.3

[PATCH v3 1/2] toshiba_acpi: Add support for WWAN devices

2015-11-23 Thread Azael Avalos
), the second queries WWAN support, and finally the third (de)activates the device. Signed-off-by: Fabian Koester <fabian.koes...@bringnow.com> Signed-off-by: Azael Avalos <coproscef...@gmail.com>ZZ --- drivers/platform/x86/toshiba_acpi.c | 109 1

[PATCH v2] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

2015-11-23 Thread Azael Avalos
, to make userspace aware of such change. Signed-off-by: Azael Avalos <coproscef...@gmail.com> --- Changes since v1: - Moved the implementation of the toshiba_acpi_kbd_bl_work function further down to make the file compile drivers/platform/x86/toshiba_acpi.

Re: [PATCH 1/1] toshiba_acpi: Propagate the hotkey value via genetlink

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 16:19 GMT-07:00 Darren Hart : > On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote: >> The driver uses genetlink to inform userspace of events generated by >> the system, but the data passed is always zero as there is no data to >> pass, except

Re: [PATCH] toshiba_acpi: Fix keyboard backight sysfs entries not being updated

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 16:39 GMT-07:00 Darren Hart : > On Mon, Nov 16, 2015 at 12:59:31PM -0700, Azael Avalos wrote: >> Certain Toshiba models with the second generation keyboard backlight >> (type 2) do not generate the keyboard backlight changed event (0x92), >> and th

Re: [PATCH] toshiba_acpi: Fix blank screen at boot if transflective backlight is supported

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 16:16 GMT-07:00 Darren Hart : > On Sun, Nov 15, 2015 at 08:32:47PM -0700, Azael Avalos wrote: >> If transflective backlight is supported and the brightness is zero >> (lowest brightness level), the set_lcd_brightness function will activate >> the tr

Re: [PATCH v2 2/2] toshiba_acpi: Add WWAN RFKill support

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 15:50 GMT-07:00 Darren Hart : > On Thu, Nov 19, 2015 at 08:49:25AM -0700, Azael Avalos wrote: > > Hi Azael, > >> A previuos patch added WWAN support to the driver, allowing to query >> and set the device status. >> >> This patch

Re: [PATCH v2 1/2] toshiba_acpi: Add support for WWAN devices

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 15:49 GMT-07:00 Darren Hart : > On Thu, Nov 19, 2015 at 08:49:24AM -0700, Azael Avalos wrote: >> Toshiba laptops with WWAN devices installed cannot use the device unless >> it is attached and powered, similar to how Toshiba Bluetooth devices >> work.

Re: [PATCH] toshiba_acpi: Fix blank screen at boot if transflective backlight is supported

2015-11-20 Thread Azael Avalos
Hi Darren, 2015-11-20 16:16 GMT-07:00 Darren Hart <dvh...@infradead.org>: > On Sun, Nov 15, 2015 at 08:32:47PM -0700, Azael Avalos wrote: >> If transflective backlight is supported and the brightness is zero >> (lowest brightness level), the set_lcd_brightness f

  1   2   3   4   5   6   7   >