Commit 2b74103547b4 ("toshiba_acpi: Remove bluetooth rfkill code")
removed bluetooth related code, however, the wireless defines were
not removed and are being unused.
This patch simply removes those defines as there is no code using
them.
Signed-off-by: Azael Avalos
---
drivers/pl
This patch adds a new function named "set_fan_status" to complement
its get* counterpart, as well as to avoid code duplication between
"fan_proc_write" and "fan_store".
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 55 +++
*accelerometer_supported.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 138 +++-
1 file changed, 59 insertions(+), 79 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 32d6d16..789a17c
es", which will
print the available laptop features.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 69 +++--
1 file changed, 44 insertions(+), 25 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x8
Given that some features were added (/dev/toshiba_acpi device), some
clean-ups and minor changes, bump the driver version to 0.23.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86
This patch simply reorders the entries found in the new keymap by
ascending order, this is simply a cosmetic change, no functionality
was modified.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a
This patch changes some variables to avoid warnins in the ninja-check
script.
We are basically moving some variables inside the conditionals were
such variables are being used, and we are checking the returned
values of some others.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
functions return one instead of zero to
indicate success.
As a special case, the LED functions only check for TOS_FAILURE on
*set with their default return value as LED_OFF, and check for
TOS_FAILURE and TOS_SUCCESS on *get.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 339
thus, such commit denied several supported features.
This patch avoids registering the input device and ignores all hotkey
events on laptops with such WMI Event GUID, making the supported
features found in those laptops to work.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Minor typ
of it.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Minor typographical corrections in patch description
drivers/platform/x86/toshiba_acpi.c | 30 +++---
1 file changed, 11 insertions(+), 19 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers
till using that interface,
hotkeys reporting should now work on these devices.
Signed-off-by: Azael Avalos
---
Changes since v1:
- No changes were made, this is simply a resend
drivers/platform/x86/toshiba_acpi.c | 56 +
1 file changed, 20 insertions(+), 36
hiba_acpi paths and command,
however, it is strongly reccomended to use the new IOCTL for any
SCI command to avoid any buggy BIOS.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Expanded patch comment a bit
Documentation/ioctl/ioctl-number.txt | 2 +-
d
Hi Darren,
2015-07-22 14:54 GMT-06:00 Darren Hart :
> On Mon, Jul 20, 2015 at 04:49:51PM -0600, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-07-20 15:55 GMT-06:00 Darren Hart :
>> > On Thu, Jul 16, 2015 at 05:38:57PM -0600, Azael Avalos wrote:
>> >> Com
Hi Darren,
2015-07-20 15:55 GMT-06:00 Darren Hart :
> On Thu, Jul 16, 2015 at 05:38:57PM -0600, Azael Avalos wrote:
>> Commit f11f999e9890 ("toshiba_acpi: Refuse to load on machines with
>> buggy INFO implementations") denied loading on laptops with a WMI Event
>&g
Hi Darren,
2015-07-20 15:36 GMT-06:00 Darren Hart :
> On Thu, Jul 16, 2015 at 05:32:44PM -0600, Azael Avalos wrote:
>> There were previous attempts to "merge" the toshiba SMM module to the
>> toshiba_acpi one, they were trying to imitate what the old toshiba
>> mo
till using that interface,
hotkeys reporting should now work on these devices.
Signed-off-by: Azael Avalos
---
Darren:
While checking the driver for the ninja-check report you sent me,
it remiended me of the changes made on this patch, and while I was
at it, "solved" a couple of the iss
thus, such commit denied several supported features.
This patch avoids registering the input device and ignores all hotkey
events on laptops with such WMI Event GUI, making the supported
features found in those laptops to work.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_a
of it.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 30 +++---
1 file changed, 11 insertions(+), 19 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 3ad7b1f..15d8f0d 100644
--- a/drivers
y BIOS, while at
the same time providing backwards compatibility.
Older programs who wish to access the SMM on newer models can do it
without much code change, as the toshiba.h header was modified to
reflect these changes as well as adds all the toshiba_acpi paths
and commands.
Signed-off-by: Azae
This patch fixes the build warning caused by the BT status variable,
it was previously printing a u64 value, but since it was moved to
another function, the value is now an int, and thus causing such
warning.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 2 +-
1
Hi Darren,
2015-05-06 16:45 GMT-06:00 Darren Hart :
> On Wed, May 06, 2015 at 09:08:52AM -0600, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-05-06 0:00 GMT-06:00 Darren Hart :
>> > On Mon, May 04, 2015 at 11:15:53AM -0600, Azael Avalos wrote:
>> >> The
This patch simply bumps the driver version to 0.22, as significant
changes were made to the driver, such as cleanups, updated events,
keymap handling, fixes and the bluetooth rfkill code removal.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1
This patch simply renames the hci_{read, write}1 functions to
hci_{read, write}.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b
This patch removes the check for TOS_FAILURE whenever we are using
the tci_raw function call, as that code is only returned by the
{hci, sci}_{read, write} functions and never by the tci_raw, and
thus making that check irrelevant.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
function was only used by the toshiba_hotkey_event_type_get
function.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 39 +++--
1 file changed, 7 insertions(+), 32 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers
This patch simply does some misc cleanup to comments, mainly
capitalizes some left over comments from a previous clean up and
adds some comments at the beginning of some feature function calls,
as well as some misc changes to some comments.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
patch
Changes since v1:
- Added two new patches to the series, one containing error check
removals and another bumping the driver version.
Azael Avalos (5):
toshiba_acpi: Remove no longer needed hci_{read, write}2 functions
toshiba_acpi: Rename hci_{read, write}1 functions
toshiba_acpi
Hi Darren,
2015-05-06 0:00 GMT-06:00 Darren Hart :
> On Mon, May 04, 2015 at 11:15:53AM -0600, Azael Avalos wrote:
>> These patches cleanup the driver from some no longer needed
>> functions, renames hci_{read, write}1 functions, some comment
>> blocks were changed, unneeded
Hi there,
2015-05-05 8:18 GMT-06:00 Joe Perches :
> On Mon, 2015-05-04 at 11:15 -0600, Azael Avalos wrote:
>> This patch removes some blank lines after comment blocks, capitalizes
>> some comments first words and adds a few comments to the beggining
>> of some functions.
&g
Hi Darren,
2015-03-06 11:32 GMT-07:00 Darren Hart :
> On Thu, Feb 26, 2015 at 10:58:29AM -0700, Azael Avalos wrote:
>> These patches make some misc chanes to the driver, replacing sscanf with
>> kstrtoint, DEVICE_ATTR_{RW, WO} macros and adding documentation about
>&
This patch removes some blank lines after comment blocks, capitalizes
some comments first words and adds a few comments to the beggining
of some functions.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 31 +--
1 file changed, 17 insertions
This patch simply renames the hci_{read, write}1 functions to
hci_{read, write}.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b
check
removals and another bumping the driver version.
Darren:
Sorry for this, I totally forgot to include the patch to remove
the function error check :-(
Now this patchset is complete now :-)
Azael Avalos (5):
toshiba_acpi: Remove no longer needed hci_{read, write}2 functions
toshiba_acpi
This patch simply bumps the driver version to 0.22, as significant
changeswere made to the driver, such as cleanups, updated events,
keymap handling, fixes and the bluetooth rfkill code removal.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1
This patch removes the check for TOS_FAILURE whenever we are using
the tci_raw function call, as that code is only returned by the
{hci, sci}_{read, write} functions and never by the tci_raw, and
thus making that check irrelevant.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
function was only used by the toshiba_hotkey_event_type_get
function.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 39 +++--
1 file changed, 7 insertions(+), 32 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers
These patches cleanup the driver from some no longer needed
functions, renames hci_{read, write}1 functions and also some comment
blocks were changed.
Azael Avalos (3):
toshiba_acpi: Remove no longer needed hci_{read, write}2 functions
toshiba_acpi: Rename hci_{read, write}1 functions
of three
- Typos in comments
Azael Avalos (4):
toshiba_bluetooth: Add a container struct named toshiba_bluetooth_dev
toshiba_bluetooth: Add RFKill handler functions
toshiba_bluetooth: Adapt *_enable, *_notify and *_resume functions to
rfkill
toshiba_bluetooth: Change BT status message to
This patch simply renames the hci_{read, write}1 functions to
hci_{read, write}.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 44 ++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b
This patch removes some blank lines after comment blocks, capitalizes
some comments first words and adds a few comments to the beggining
of some functions.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 31 +--
1 file changed, 17 insertions
function was only used by the toshiba_hotkey_event_type_get
function.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 39 +++--
1 file changed, 7 insertions(+), 32 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers
debug message to the *_sync_status function printing the
bluetooth device raw status, killswitch, plug and power states of the
device as well.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
also used by upcomming patches.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 47 +++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index
toshiba_bluetooth_enable.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 47
1 file changed, 18 insertions(+), 29 deletions(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index
This patch adds RFKill handler functions to the driver, allowing it
to register and update the rfkill switch status.
Also, a comment block was moved from the header to the poll function,
as it explains why we need to poll the killswitch on older devices.
Signed-off-by: Azael Avalos
---
drivers
This patch removes all bluetooth rfkill related code residing in
the toshiba_acpi driver.
Separate patches will add (and adapt) the code to toshiba_bluetooth
(where it belongs).
Signed-off-by: Azael Avalos
---
Changes since v1:
- Merged the two patches into one
- Removed a leftover boolean
Hi there,
2015-04-28 1:36 GMT-06:00 Bjørn Mork :
> Azael Avalos writes:
>
>> The function toshiba_bluetooth_status s currently printing the status
>> of the device whenever it is queried, but since the introduction of
>> the rfkill poll code, this value will get pr
This patch adds RFKill handler functions to the driver, allowing it
to register and update the rfkill switch.
Also, a comment block was moved from the header to the poll function,
as it explains why we need to poll the killswitch on older devices.
Signed-off-by: Azael Avalos
---
drivers
This patch removes unneeded code from the toshiba_bluetooth_enable
function as propper rfkill code as been added now.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/platform/x86
This patch adapts toshiba_bt_rfkill_notify and toshiba_bt_resume
functions to update the rfkill status, as they were only calling
toshiba_bluetooth_enable.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 20 ++--
1 file changed, 18 insertions(+), 2
adds a few more debug messages printing the
killswitch, plug and power status of the device as well.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers
This patch simply adds the RFKILL dependency to Kconfig, as we are
now using rfkill code on the driver.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9752761
also used by upcomming patches.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 47 +++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index
These patches add support to use the rfkill core functionality to the
Toshiba bluetooth driver and adapting the existing code to it.
Azael Avalos (6):
toshiba_bluetooth: Add a container struct named toshiba_bluetooth_dev
toshiba_bluetooth: Add RFKill handler functions
toshiba_bluetooth
This patch removes all bluetooth rfkill related code residing in
the toshiba_acpi driver.
Separate patches will add (and adapt) the code to toshiba_bluetooth
(where it belongs).
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 123
1
These two patches remove all bluetooth rfkill code from toshiba_acpi
and its build dependencies, as another series of patches will re-add
the rfkill code to toshiba_bluetooth instead.
Azael Avalos (2):
toshiba_acpi: Remove bluetooth rfkill code
platform/x86: Remove RFKILL dependency from
This patch removes the dependency on rfkill for toshiba_acpi from
KConfig, as a previous patch removed all the code related to it.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86
This patch updates the sysfs-driver-toshiba_acpi entry, adding the
missing entries for USB Sleep functions.
And also, while at the neighborhood, fix some typos and add a note
that some features require a reboot.
Signed-off-by: Azael Avalos
---
.../ABI/testing/sysfs-driver-toshiba_acpi
This patch fixes the messages displayed by the USB Sleep Functions,
they were printing wrong messages not associated to the feature
currently queried.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
This patch fixes the USB Sleep and Charge mode on certain models
where the value returned by the BIOS is different, and thus, making
this feature not to work for those models.
Also, the "Typical" charging mode was added as a supported mode.
Signed-off-by: Azael Avalos
---
drivers/pl
rted value of sleep and charge to zero in case
of an error and added comments.
- Updated the title and commit message of second patch to better
reflect what the patch is doing.
Azael Avalos (3):
toshiba_acpi: Update and fix USB Sleep and Charge modes
toshiba_acpi: Fix pr_* messages from USB S
This patch fixes the messages displayed by the USB Sleep Functions,
they were printing wrong messages not associated to the feature
currently queried.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
Hi Darren,
2015-04-01 23:21 GMT-06:00 Darren Hart :
> On Sun, Mar 29, 2015 at 07:25:39PM -0600, Azael Avalos wrote:
>> This patch fixes the USB Sleep and Charge mode on certain models
>> where the value returned by the BIOS is different, and thus, making
>> this feature
This patch updates the sysfs-driver-toshiba_acpi entry, adding the
missing entries for USB Sleep functions.
And also, while at the neighborhood, fix some typos and add a note
that some features require a reboot.
Signed-off-by: Azael Avalos
---
.../ABI/testing/sysfs-driver-toshiba_acpi
This patch fixes the USB Sleep and Charge mode on certain models
where the value returned by the BIOS is different, and thus, making
this feature not to work for those models.
Also, the "Typical" charging mode was added as a supported mode.
Signed-off-by: Azael Avalos
---
drivers/pl
This patch fixes the messages displayed by the USB Sleep Functions,
they were printing wrong messages not associated to the feature
currently queried.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
itle and commit message of second patch to better
reflect what the patch is doing.
Azael Avalos (3):
toshiba_acpi: Update and fix USB Sleep and Charge modes
toshiba_acpi: Fix pr_* messages from USB Sleep Functions
Documentation/ABI: Update sysfs-driver-toshiba_acpi entry
.../ABI/testing/s
Hi Darren,
2015-03-27 20:58 GMT-06:00 Darren Hart :
> On Fri, Mar 27, 2015 at 03:09:25PM -0600, Azael Avalos wrote:
>> This patch fixes typos in the pr_* messages from the USB Sleep
>> Functions.
>>
>> Signed-off-by: Azael Avalos
>> ---
>> d
Hi Darren,
2015-03-27 20:53 GMT-06:00 Darren Hart :
> On Fri, Mar 27, 2015 at 03:09:24PM -0600, Azael Avalos wrote:
>> This patch fixes the USB Sleep and Charge mode on certain models
>> where the value returned by the BIOS is different, and thus, making
>> this feature
This patch updates the sysfs-driver-toshiba_acpi entry, adding the
missing entries for USB Sleep functions.
And also, while at the neighborhood, fix some typos and add a note
that some features require a reboot.
Signed-off-by: Azael Avalos
---
.../ABI/testing/sysfs-driver-toshiba_acpi
This patch fixes typos in the pr_* messages from the USB Sleep
Functions.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86
This patch fixes the USB Sleep & Charge charging mode on certain
models, fixes some typos in pr_* messages and also adds the missing
entries in the documentation file.
Azael Avalos (3):
toshiba_acpi: Update and fix USB Sleep and Charge modes
toshiba_acpi: Fix typos in pr_* messages from
This patch fixes the USB Sleep and Charge mode on certain models
where the value returned by the BIOS is different, and thus, making
this feature not to work for those models.
Also, the "Typical" charging mode was added as a supported mode.
Signed-off-by: Azael Avalos
---
drivers/pl
check to verify the status of the BT device,
returning silently if it is already activated.
Also, checks and returns appropriate error values while evaluating
the AUSB and BTPO methods.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 50 +++-
1
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index b479a70..b8404c7 100644
--- a
respectively.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 51
1 file changed, 51 insertions(+)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index 2cb1ea6..b479a70 100644
--- a/drivers
Changes since v1:
- Removed pr_info calls from *_notify function
- Added checks to the status of the BT device removing the TODO
comment and retaining the previous functionality of the driver
Azael Avalos (3):
toshiba_bluetooth: Add three new functions to the driver
toshiba_bluetooth: Clean up
Hi Darren,
2015-03-25 15:24 GMT-06:00 Darren Hart :
> On Wed, Mar 25, 2015 at 02:19:17PM -0600, Azael Avalos wrote:
>> Bug 93911 reported a broken handling of the BT device, causing the
>> driver to get stuck in a loop enabling/disabling the device whenever
>> the device
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index b479a70..b8404c7 100644
--- a
respectively.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 51
1 file changed, 51 insertions(+)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index 2cb1ea6..b479a70 100644
--- a/drivers
This patch cleans the toshiba_bluetooth_enable function, removing
some unneeded code and returning appropriate error values.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff
the BT device status, activating the
device only when it is disabled and returning silently if the KS is
activated, this way we retain the previous functionality but without
affecting the newer devices that trigger the enable/disable loop.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
retaining the previous functionality of the driver
Azael Avalos (4):
toshiba_bluetooth: Add three new functions to the driver
toshiba_bluetooth: Clean up *_add function and disable BT device at
removal
toshiba_bluetooth: Clean toshiba_bluetooth_enable function
toshiba_bluetooth: Remove BT
Hi Darren,
2015-03-25 11:50 GMT-06:00 Darren Hart :
> On Wed, Mar 18, 2015 at 01:12:59PM -0600, Azael Avalos wrote:
>> Bug 93911 reported a broken handling of the BT device, causing the
>> driver to get stuck in a loop enabling/disabling the device whenever
>> the device
EVENT call, but this time
we are using a different parameter to make the "Special Functions"
mode work as expected.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/
ching list.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 70 +
1 file changed, 32 insertions(+), 38 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index c4edae3..d7dac48 100644
---
er reflect what the call does, and also the HCI_HOTKEY_EVENT_*
types
- Fixed a typo in the error description
- Added a comment block explaining a bit why we also use the "Special
Functions" as a check for keymap selection
Azael Avalos (3):
toshiba_acpi: Add Hotkey Event Type func
This patch adds support to query the "Hotkey Event Type" the system
supports.
There are two main event types (so far), 0x10 and 0x11, with the
first being all those laptops that have the old keyboard layout, and
the latter all those new laptops with the new keyboard layout.
Signed-off
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index b479a70..b8404c7 100644
--- a
This patch cleans the toshiba_bluetooth_enable function, removing
some unneeded code and returning appropriate error values.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff
add code to handle special circumstances
depending on the status of the device.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers
respectively.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 51
1 file changed, 51 insertions(+)
diff --git a/drivers/platform/x86/toshiba_bluetooth.c
b/drivers/platform/x86/toshiba_bluetooth.c
index 2cb1ea6..b479a70 100644
--- a/drivers
This patch cleans the toshiba_bluetooth_enable function, removing
some unneeded code and returning appropriate error values.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 32
1 file changed, 12 insertions(+), 20 deletions(-)
diff
These patches introduce three new functions, cleaning up the driver
code, checking for errors and returning accordingly, and also fixes
bug 93911.
Azael Avalos (4):
toshiba_bluetooth: Add three new functions to the driver
toshiba_bluetooth: Clean up *_add function and disable BT device at
Add the missing toshiba_bluetooth and toshiba_haps entries and add
myself as their maintainer.
Also add the Maintainers entry for toshiba_acpi driver and change its
status to maintained.
Signed-off-by: Azael Avalos
---
MAINTAINERS | 15 ++-
1 file changed, 14 insertions(+), 1
: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 09c6a2f..3a895a8 100644
--- a/drivers/platform/x86/toshiba_acpi.c
Hi Darren,
2015-03-06 11:34 GMT-07:00 Darren Hart :
> On Thu, Feb 26, 2015 at 10:57:11AM -0700, Azael Avalos wrote:
>> These patches add support to a new function that queries the supported Hotkey
>> Event Type, making the use of the DMI matching unnecessary and also fixes
Hi Darren,
2015-03-06 11:28 GMT-07:00 Darren Hart :
> On Thu, Feb 26, 2015 at 10:57:14AM -0700, Azael Avalos wrote:
>> Some Toshiba laptops with the "Special Functions" feature enabled
>> fail to properly enable such feature unless a specific value is
>> used to en
Hi Darren,
2015-03-06 11:21 GMT-07:00 Darren Hart :
> On Thu, Feb 26, 2015 at 10:57:12AM -0700, Azael Avalos wrote:
>
> Hi Azael,
>
> I'm pretty behind on this one, apologies.
>
No wories, we still have plenty of time for 4.1 ;-)
I simply wanted to send these early
Hi Joe,
2015-03-05 13:59 GMT-07:00 Joseph Salisbury :
> On 03/04/2015 07:05 PM, Azael Avalos wrote:
>> Hi there,
>>
>> 2015-03-04 14:52 GMT-07:00 Joseph Salisbury :
>> ...
>>> + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } },
>>>
101 - 200 of 316 matches
Mail list logo
