Hi there,
2015-03-04 14:52 GMT-07:00 Joseph Salisbury :
...
> + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } },
> + { KE_KEY, 0x141, { KEY_BRIGHTNESSUP } },
...
These two are not neccesary, as they may collide with "previous song"
and "playpause" in case Toshiba (or its manufacturers) deci
This patch makes use of DEVICE_ATTR_{RW, WO} macros, simplifying
device attributes creation.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_haps.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/toshiba_haps.c
b/drivers/platform/x86
This patch adds a new file describing the sysfs entries for the
toshiba_haps driver.
Signed-off-by: Azael Avalos
---
Documentation/ABI/testing/sysfs-driver-toshiba_haps | 20
1 file changed, 20 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-driver
These patches make some misc chanes to the driver, replacing sscanf with
kstrtoint, DEVICE_ATTR_{RW, WO} macros and adding documentation about
the sysfs entries.
Azael Avalos (3):
toshiba_haps: Replace sscanf with kstrtoint
toshiba_haps: Make use of DEVICE_ATTR_{RW, WO} macros
Documentation
These patches add support to a new function that queries the supported Hotkey
Event Type, making the use of the DMI matching unnecessary and also fixes
the "Special Functions" mode on some laptops.
Azael Avalos (3):
toshiba_acpi: Add Hotkey Event Type function and definitions
to
ching list.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 51 +
1 file changed, 18 insertions(+), 33 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index e6aa8f9..10e0773 100644
---
This patch simply replaces the use of sscanf with kstrtoint returning
the error code in case that something went bad.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_haps.c | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/drivers
This patch adds support to query the "Hotkey Event Type" the system
supports.
There are two main event types (so far), 0x10 and 0x11, with the
first beign all those laptops that have the old keyboard layout, and
the latter all those new laptops with the new keyboard layout.
Signed-off
EVENT call, but this time
we are using a different parameter to make the "Special Functions"
mode work as expected.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/platform/x86/toshiba_
2015-02-11 22:57 GMT-07:00 Darren Hart :
> After Azael's various fixes and cleanups to toshiba_acpi.c, I've made some
> final
> cleanups to comment formatting and the file header.
>
> Azael, any objections?
Nope, looks good to me.
>
> --
> Darren Hart
> Intel Open Source Technology Center
>
Che
Hi Darren,
2015-02-11 22:38 GMT-07:00 Darren Hart :
> On Tue, Feb 10, 2015 at 11:43:57PM -0700, Azael Avalos wrote:
>> This patch adds a new file describing the sysfs entries for the
>> toshiba_acpi driver.
>>
>
> +linux-api list
Just CC me, because I'm not
for 3.21 :-)
---8<---
Azael Avalos (5):
toshiba_acpi: Clean file according to coding style
Documentation/ABI: Add file describing the sysfs entries for
toshiba_acpi
toshiba_acpi: Move sysfs function and struct declarations further down
toshiba_acpi: Drop the toshiba_ prefix from
This patch adds a new file describing the sysfs entries for the
toshiba_acpi driver.
Signed-off-by: Azael Avalos
---
.../ABI/testing/sysfs-driver-toshiba_acpi | 114 +
1 file changed, 114 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-driver
This patch makes use of the DEVICE_ATTR_{RO, RW} macros to simplify
sysfs attributes declarations.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 42 +
1 file changed, 15 insertions(+), 27 deletions(-)
diff --git a/drivers/platform/x86
use of that function unnecesary.
This patch moves all the sysfs structs and function declarations
further down, making the file shorther in lines and better readable.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 196 +++-
1 file changed, 5
This patch simply cleans the the driver out of 2 errors and 17
warnings according to "checkpatch -f", no functionality was changed,
simply a cleanup.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 38 ++---
1 file changed, 23
: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 166 +---
1 file changed, 76 insertions(+), 90 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 818d184..0b5614c 100644
--- a/drivers/platform/x86
, keys <-> input).
The rest add support for new features found on recent Toshiba laptops.
And the last one simply bump up the driver version.
Changes since v1:
- Added a pr_info message informing the user that the laptop needs to
reboot
Azael Avalos (6):
toshiba_acpi: Add version en
This patch adds a fan entry to sysfs, enabling the user to get and
set the fan status.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 51 -
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86
2} keys are as usual and
the hotkeys are accessed via FN-F{1-12}.
In the "Special Functions" mode, the F{1-12} keys trigger the hotkey
and the F{1-12} keys are accessed via FN-F{1-12}.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 100 +++
uch feature, however, a reboot is needed on every mode
change.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 100
1 file changed, 100 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_
This patch adds a new entry to the sysfs, showing the version of the
driver.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
the
USB 3 (acting as a USB 2) and 1 to enable it, however, a reboot is
needed everytime this is toggled.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 103
1 file changed, 103 insertions(+)
diff --git a/drivers/platform/x86/toshiba
Several new features were added on previous patches, so lets bump up
the driver version.
And also, update the copyright year.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86
Hi Darren,
2015-02-09 21:55 GMT-07:00 Darren Hart :
> On Mon, Feb 09, 2015 at 09:46:07PM -0700, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-02-09 21:11 GMT-07:00 Darren Hart :
>> > On Mon, Feb 09, 2015 at 08:34:53PM -0700, Azael Avalos wrote:
>> >> Toshi
Hi Darren,
2015-02-09 21:22 GMT-07:00 Darren Hart :
> On Mon, Feb 09, 2015 at 08:55:02PM -0700, Azael Avalos wrote:
>> Some Toshiba laptops do not come with the ECO led installed, however,
>> the driver is registering support for it when it should not.
>>
&g
Hi Darren,
2015-02-09 21:11 GMT-07:00 Darren Hart :
> On Mon, Feb 09, 2015 at 08:34:53PM -0700, Azael Avalos wrote:
>> Toshiba laptops that come with USB 3 ports have a feature that lets
>> them disable USB 3 functionality and act as a regular USB 2 port, and
>> thus, sav
Hi Darren,
2015-02-09 21:08 GMT-07:00 Darren Hart :
> On Mon, Feb 09, 2015 at 08:34:51PM -0700, Azael Avalos wrote:
>> Recent Toshiba laptops that come with the new keyboard layout have
>> the Special Functions (hotkeys) enabled by default, which, in order to
>> access the F
Hi Darren,
2015-02-09 21:02 GMT-07:00 Darren Hart :
> On Mon, Feb 09, 2015 at 08:34:50PM -0700, Azael Avalos wrote:
>> This patch adds a fan entry to sysfs, enabling the user to get and
>> set the fan status.
>>
>
> Hi Azael,
>
> I was finally getting aro
anything and
and the LED device was being registered too, hence the change of the
default return value from 1 to 0.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Removed the comment block from the TOS_NOT_INSTALLED check, the
error code as well as the pr_info message is self explanatory
2} keys are as usual and
the hotkeys are accessed via FN-F{1-12}.
In the "Special Functions" mode, the F{1-12} keys trigger the hotkey
and the F{1-12} keys are accessed via FN-F{1-12}.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 98 +++
uch feature.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 98 +
1 file changed, 98 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index c79211a..baf3376 100644
--- a/drivers/platfor
Several new features were added on previous patches, so lets bump up
the driver version.
And also, update the copyright year.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86
This patch adds a fan entry to sysfs, enabling the user to get and
set the fan status.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 51 -
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86
, keys <-> input).
The rest add support for new features found on recent Toshiba laptops.
And the last one simply bump up the driver version.
Azael Avalos (6):
toshiba_acpi: Add version entry to sysfs
toshiba_acpi: Add fan entry to sysfs
toshiba_acpi: Add support for Keyboard fu
This patch adds a new entry to the sysfs, showing the version of the
driver.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
the
USB 3 (acting as a USB 2) and 1 to enable it.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 101
1 file changed, 101 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index baf337
registering the led when it really does.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 8b4a78b
This patch adds a fan entry to sysfs, enabling the user to get and
set the fan status.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 51 -
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86
This patch adds a new entry to the sysfs, showing the version of the
driver.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
, keys <-> input).
The rest add support for new features found on recent Toshiba laptops.
And the last one simply bump up the driver version.
Azael Avalos (6):
toshiba_acpi: Add version entry to sysfs
toshiba_acpi: Add fan entry to sysfs
toshiba_acpi: Add support for Keyboard fu
uch feature.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 98 +
1 file changed, 98 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index c79211a..baf3376 100644
--- a/drivers/platfor
the
USB 3 (acting as a USB 2) and 1 to enable it.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 101
1 file changed, 101 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index baf337
2} keys are as usual and
the hotkeys are accessed via FN-F{1-12}.
In the "Special Functions" mode, the F{1-12} keys trigger the hotkey
and the F{1-12} keys are accessed via FN-F{1-12}.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 98 +++
Several new features were added on previous patches, so lets bump up
the driver version.
And also, update the copyright year.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86
Hi Darren,
Any input on this patch?
2015-01-18 19:17 GMT-07:00 Azael Avalos :
> This was "toshiba_acpi: Change sci_open function return value"
>
> Some Toshiba laptops have "poorly implemented" SCI calls on their
> BIOSes and are not checking for sci_{open
Hi there,
Sorry for the late reply.
2015-01-20 4:15 GMT-07:00 Oliver Neukum :
> On Sun, 2015-01-18 at 18:30 -0700, Azael Avalos wrote:
>> The following patches add support to several USB Sleep functions
>> found on newer Toshiba laptops, allowing to use the USB ports while
&
ORTED, and thus, not
registering support for the queried feature.
Signed-off-by: Azael Avalos
---
Darren,
Hopefully this new patch eases some of the concerns of the previous
patch, and this time I added a comment block explaining a bit, but of
course, let me know if there is something else that needs c
a sysfs entry
named "usb_sleep_music", accepting only two values, 0 to disable and
1 to enable.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 97 +
1 file changed, 97 insertions(+)
diff --git a/drivers/platform/x86/toshiba
ntry
named "sleep_functions_on_battery", accepting values from 0-100,
where zero disables the function and 1-100 sets the battery level at
which point the USB Sleep functions will be disabled, and printing
the current state of the functon and also the battery level currently
set.
Signed-
wever, the machine needs a restart everytime the
function is toggled.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 107
1 file changed, 107 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/tosh
charging modes mean
- Some misc format and typo changes
Azael Avalos (4):
toshiba_acpi: Add support for USB Sleep and Charge function
toshiba_acpi: Add support for USB Sleep functions under battery
toshiba_acpi: Add support for USB Rapid Charge
toshiba_acpi: Add support for USB Sleep and
disable it.
The sysfs entry accepts three parameters, 0, 1 and 2, beign disabled,
alternate and auto respectively.
The auto mode stands for USB conformant devices (which most are), and
the alternate mode stands for those non USB conformant devices that
require more power.
Signed-off-by: Az
The following patches add support to several USB Sleep functions
found on newer Toshiba laptops, allowing to use th USB ports while
the laptop is asleep or turned off.
Azael Avalos (4):
toshiba_acpi: Add support for USB Sleep and Charge function
toshiba_acpi: Add support for USB Sleep
ntry
named "sleep_functions_on_battery", accepting values from 0-100,
where zero disables the function and 1-100 sets the battery level at
which point the USB Sleep functions will be disabled, and printing
the current state of the functon and also the battery level currently
set.
Signed-
music", accepting parameters zero and one, where
zero disables the feature and one enables it respectively.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 97 +
1 file changed, 97 insertions(+)
diff --git a/drivers/platform/x86/toshiba
disable it.
The sysfs entry accepts three parameters, 0x0, 0x9 and 0x21, beign
disabled, alternate and auto respectively.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 112
1 file changed, 112 insertions(+)
diff --git a/drivers/pl
e, however, the machine needs a restart everytime the
function is toggled.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 107
1 file changed, 107 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/tosh
he default return code of the sci_open function
to return one instead of zero, making all those faulty laptops load
all the supported features.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pl
:
- Removed a left over variable from the split in patch 02 and
moved it to patch 03 (where it belongs)
- A bit more verbose description on patch 03
Azael Avalos (3):
toshiba_acpi: Move hotkey enabling code to own function
toshiba_acpi: Change notify funtion to handle more events
toshiba_acpi
toshiba_acpi_process_hotkeys.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 85 ++---
1 file changed, 51 insertions(+), 34 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 8bb07c7
The hotkey enabling code is being used by
*_setup_keyboard and also by *_resume.
This patch creates a new function called
toshiba_acpi_enable_hotkeys to be used by
these two functions to avoid duplicating
code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 40
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 99db763..5e9b298 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b
Hi Darren,
2014-12-03 6:12 GMT-07:00 Darren Hart :
> On Wed, Dec 03, 2014 at 11:42:04PM -0700, Azael Avalos wrote:
>> @@ -1971,41 +2008,22 @@ error:
>> static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event)
>> {
>> struct toshiba_acpi_dev *dev
toshiba_acpi_process_hotkeys.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 86 ++---
1 file changed, 52 insertions(+), 34 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 8bb07c7
:
- Split patch 02 in two patches
- Some misc changes in the description of the patches (a bit wider now)
Azael Avalos (3):
toshiba_acpi: Move hotkey enabling code to own function
toshiba_acpi: Change notify funtion to handle more events
toshiba_acpi: Add keyboard backlight mode change event
The hotkey enabling code is being used by toshiba_acpi_setup_keyboard
and also by toshiba_acpi_resume.
This patch creates a new function called toshiba_acpi_enable_hotkeys
to be used by these two functions to avoid duplicating code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
A previous patch added support to handle more events.
This patch adds support to update the sysfs group whenever we receive
a 0x92 event, which indicates a change in the keyboard backlight mode.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 13 +++--
1 file
These patches change the current code to accomodate
the handling of more events, since so far, it only
handles hotkey events (0x80), as well as move some
hotkey enabling code to a sub function to avoid
duplication.
Azael Avalos (2):
toshiba_acpi: Move hotkey enabling code to own function
toshiba_acpi_process_hotkeys,
and also update the sysfs group whenever we
receive a 0x92 event, which indicates a change
in the keyboard backlight mode.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 99 ++---
1 file changed, 59 insertions
The hotkey enabling code is being used by
*_setup_keyboard and also by *_resume.
This patch creates a new function called
toshiba_acpi_enable_hotkeys to be used by
these two functions to avoid duplicating
code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 40
ion
format.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Simply revert the commit to its original state by just
adapting the code to the new function format
Darren,
This patch simply reverts the commit so the bug can be closed,
I'll send a few patches later which will include the c
2014-11-10 22:49 GMT-07:00 Darren Hart :
> On Mon, Nov 10, 2014 at 09:58:29AM -0700, Azael Avalos wrote:
>> Hi Darren,
>>
>> Sorry for the way late reply, I had to go out of town in a hurry.
>>
>> 2014-11-03 23:21 GMT-07:00 Darren Hart :
>> > On Mon, Nov
Hi Darren,
Sorry for the way late reply, I had to go out of town in a hurry.
2014-11-03 23:21 GMT-07:00 Darren Hart :
> On Mon, Nov 03, 2014 at 08:58:34PM -0700, Azael Avalos wrote:
>> Bug 86521 uncovered that some TOS6208 devices also return
>> non zero values on a write call t
backlight code.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index ef3a190..e3fed12 100644
--- a/drivers/platform/x86
With the introduccion of the new keyboard backlight
implementation, the *_timeout_store function is
broken, as it only supports the first kbd_type.
This patch adapt such function for the new kbd_type,
as well as convert from using sscanf to kstrtoint.
Signed-off-by: Azael Avalos
---
Changes
Hi there,
2014-10-02 12:32 GMT-06:00 Darren Hart :
> On Mon, Sep 29, 2014 at 08:57:04PM -0600, Azael Avalos wrote:
>> With the introduccion of the new keyboard backlight
>> implementation, the *_timeout_store function is
>> broken, as it only supports the first kbd_type.
&
With the introduccion of the new keyboard backlight
implementation, the *_timeout_store function is
broken, as it only supports the first kbd_type.
This patch adapt such function for the new kbd_type,
as well as convert from using sscanf to kstrtoint.
Signed-off-by: Azael Avalos
---
drivers
tion to
tci_raw (for Toshiba Configuration Interface), and
change the comments about it.
Also, the HCI_WORDS definition was changed to TCI_RAW,
to better reflect that we're no longer using pure HCI
calls, but a combination of HCI and SCI, which form
part of the Toshiba Configuration Interface.
instead
replacing it with TOS (for TOShiba).
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 143 ++--
1 file changed, 72 insertions(+), 71 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
was never checked on most of the functions.
Changes since v1:
- Be a bit more verbose on patch 1 about the Toshiba
configuration interface
- Merged patches 3 and 4 into a same patch
Azael Avalos (3):
toshiba_acpi: Rename hci_raw to tci_raw
toshiba_acpi: Unify return codes prefix from HCI/
call status,
eliminating one parameter, and returning something
useful that indeed is being checked.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 129 +---
1 file changed, 62 insertions(+), 67 deletions(-)
diff --git a/drivers/platform
2014-09-25 21:11 GMT-06:00 Darren Hart :
> On Tue, Sep 23, 2014 at 06:24:27PM -0600, Azael Avalos wrote:
>> Currently the HCI/SCI read/write functions are returning
>> the status of the ACPI call and also assigning the
>> returned value of the HCI/SCI function.
>>
2014-09-25 21:01 GMT-06:00 Darren Hart :
> On Tue, Sep 23, 2014 at 06:24:25PM -0600, Azael Avalos wrote:
>> The function name hci_raw was used before to reflect
>> a raw (read/write) call to the Toshiba's Hardware
>> Configuration Interface (HCI), however, since the
>
would like these to be queued for 3.18 if possible.
Azael Avalos (4):
toshiba_acpi: Rename hci_raw to tci_raw
toshiba_acpi: Unify return codes prefix to from HCI/SCI to TOS
toshiba_acpi: Change HCI/SCI functions return code type
toshiba_acpi: Adapt functions to the changes made to HCI/SCI
The previous patch changed the return type for the HCI/SCI
read/write functions.
This patch adapts the code for that change, as now the
"result" parameter is returned by those functions, instead
of the ACPI status call.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_a
tion to
tci_raw (for Toshiba Configuration Interface), and
change the comments about it.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 40 ++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/platform/x86/toshiba_ac
HCI/SCI functions
to reflect the change made in this patch.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 51 -
1 file changed, 27 insertions(+), 24 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86
instead
replacing it with TOS (for TOShiba).
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 143 ++--
1 file changed, 72 insertions(+), 71 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
keyboard type.
Signed-off-by: Azael Avalos
---
Changes since v3:
Fixed typos on patch description
Dropped changes to toshiba_kbd_bl_mode_show and simply added the new mode mask
drivers/platform/x86/toshiba_acpi.c | 188 ++--
1 file changed, 156 insertions(+), 32
The position file on sysfs was reporting absolute values
for its axes.
This patch fixes the direction reporting (either negative
or positive), as well as added a mutex lock to it.
Signed-off-by: Azael Avalos
---
This was: Add accelerometer input polled device
Changes since v1:
Dropped polldev
Hi Darren,
2014-09-12 14:48 GMT-06:00 Darren Hart :
> On Thu, Sep 11, 2014 at 09:22:25PM -0600, Azael Avalos wrote:
>> Newer Toshiba models now come with a new (and different) keyboard
>> backlight implementation with three modes of operation: TIMER,
>> ON and OFF, and
type.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 193 +---
1 file changed, 158 insertions(+), 35 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 4c8fa7b..a5d7d83 100644
--- a
Hi Darren,
2014-09-11 18:36 GMT-06:00 Darren Hart :
> On Wed, Sep 10, 2014 at 09:01:56PM -0600, Azael Avalos wrote:
>
> Hi Azael,
>
>> Newer Toshiba models now come with a new (and different) keyboard
>> backlight implementation with three modes of operation: TIMER,
>&
The function toshiba_touchpad_store is not checking
for invalid values and simply returns silently.
This patch checks for invalid values and returns accordingly.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 14 ++
1 file changed, 10 insertions(+), 4
type.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 117 +++-
1 file changed, 102 insertions(+), 15 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 4c8fa7b..08147c5 100644
--- a
Hi Darren,
2014-09-09 22:11 GMT-06:00 Darren Hart :
> On Fri, Sep 05, 2014 at 11:14:06AM -0600, Azael Avalos wrote:
>
> Hi Azael,
>
> Apologies for the delay. I'm still recovering from a couple weeks of travel
> and
> a nasty conference bug. Thanks for being patient.
Hi there,
2014-09-09 21:35 GMT-06:00 Darren Hart :
>
> I immediately went to a tablet with a marble maze game and it didn't seem too
> crazy, but I don't suppose that is what people are actually doing with it...
>
> What are people actually doing with this thing Azael?
Gaming mostly (supertuxkart
Hi there,
2014-09-05 20:42 GMT-06:00 Darren Hart :
> On Fri, Sep 05, 2014 at 11:14:05AM -0600, Azael Avalos wrote:
>> The accelerometer sensor is very sensitive, and having userspace
>> poll the sysfs position entry is not very battery friendly.
>>
>> This patch
Hi there
2014-09-05 20:35 GMT-06:00 Darren Hart :
> On Fri, Sep 05, 2014 at 11:14:04AM -0600, Azael Avalos wrote:
>> Some Toshiba models with illumination support set a different
>> value on the returned codes, thus not allowing the illumination
>> LED to be registere
201 - 300 of 316 matches
Mail list logo
