Re: [PATCH 1/1] clk/zynq: Fix possible memory leak

2013-10-06 Thread Baruch Siach
Hi Felipe, On Sun, Oct 06, 2013 at 09:55:17PM -0300, Felipe Pena wrote: The zynq_clk_register_fclk function can leak memory (fclk_lock) when unable to alloc memory for fclk_gate_lock Signed-off-by: Felipe Pena felipe...@gmail.com --- drivers/clk/zynq/clkc.c |1 + 1 file changed, 1

Re: [PATCH] MAINTAINERS: add the generic sched_clock under timekeeping

2013-08-18 Thread Baruch Siach
Hi John, On Wed, Jul 17, 2013 at 12:21:12PM -0700, John Stultz wrote: > On 07/17/2013 12:12 PM, Baruch Siach wrote: > >On Wed, Jul 17, 2013 at 11:57:32AM -0700, John Stultz wrote: > >>On 07/17/2013 03:05 AM, Baruch Siach wrote: > >>>Signed-off-by: Baruch Siach &

Re: [GIT PULL] Generic sched_clock fix for 3.11

2013-08-18 Thread Baruch Siach
; > > > > > git://git.linaro.org/people/jstultz/linux.git fortglx/3.11/time > > > > for you to fetch changes up to 53c035204253efe373d9ff166fae6147e8c693b6: > > > > sched_clock: Fix integer overflow (2013-07-22 16:24:22 -0700) > > > > -

Re: [GIT PULL] Generic sched_clock fix for 3.11

2013-08-18 Thread Baruch Siach
to 53c035204253efe373d9ff166fae6147e8c693b6: sched_clock: Fix integer overflow (2013-07-22 16:24:22 -0700) Baruch Siach (1): sched_clock: Fix integer overflow kernel/time/sched_clock.c | 2 +- 1 file changed

Re: [PATCH] MAINTAINERS: add the generic sched_clock under timekeeping

2013-08-18 Thread Baruch Siach
Hi John, On Wed, Jul 17, 2013 at 12:21:12PM -0700, John Stultz wrote: On 07/17/2013 12:12 PM, Baruch Siach wrote: On Wed, Jul 17, 2013 at 11:57:32AM -0700, John Stultz wrote: On 07/17/2013 03:05 AM, Baruch Siach wrote: Signed-off-by: Baruch Siach bar...@tkos.co.il --- MAINTAINERS | 2

Re: [Linux-Xtensa] Re: [PATCH] time: sched_clock: fix integer overflow

2013-08-11 Thread Baruch Siach
Hi Thomas, John, On Mon, Jul 29, 2013 at 08:59:39AM +0300, Baruch Siach wrote: > On Wed, Jul 17, 2013 at 12:46:53PM +0300, Baruch Siach wrote: > > The expression '(1 << 32)' happens to evaluate as 0 on ARM, but it > > evaluates as > > 1 on xtensa and x86_64.

Re: [Linux-Xtensa] Re: [PATCH] time: sched_clock: fix integer overflow

2013-08-11 Thread Baruch Siach
Hi Thomas, John, On Mon, Jul 29, 2013 at 08:59:39AM +0300, Baruch Siach wrote: On Wed, Jul 17, 2013 at 12:46:53PM +0300, Baruch Siach wrote: The expression '(1 32)' happens to evaluate as 0 on ARM, but it evaluates as 1 on xtensa and x86_64. This zeros sched_clock_mask, and breaks

Re: [PATCH] time: sched_clock: fix integer overflow

2013-07-29 Thread Baruch Siach
Hi Thomas, John, On Wed, Jul 17, 2013 at 12:46:53PM +0300, Baruch Siach wrote: > The expression '(1 << 32)' happens to evaluate as 0 on ARM, but it evaluates > as > 1 on xtensa and x86_64. This zeros sched_clock_mask, and breaks sched_clock(). > Set the type of 1 to 'unsigned

Re: [PATCH] time: sched_clock: fix integer overflow

2013-07-29 Thread Baruch Siach
Hi Thomas, John, On Wed, Jul 17, 2013 at 12:46:53PM +0300, Baruch Siach wrote: The expression '(1 32)' happens to evaluate as 0 on ARM, but it evaluates as 1 on xtensa and x86_64. This zeros sched_clock_mask, and breaks sched_clock(). Set the type of 1 to 'unsigned long long' to get

Re: [PATCH v4 04/17] sched_clock: Add support for >32 bit sched_clock

2013-07-19 Thread Baruch Siach
Hi Stephen, On Thu, Jul 18, 2013 at 04:21:17PM -0700, Stephen Boyd wrote: > The ARM architected system counter has at least 56 usable bits. > Add support for counters with more than 32 bits to the generic > sched_clock implementation so we can increase the time between > wakeups due to dealing

Re: [PATCH v4 04/17] sched_clock: Add support for 32 bit sched_clock

2013-07-19 Thread Baruch Siach
Hi Stephen, On Thu, Jul 18, 2013 at 04:21:17PM -0700, Stephen Boyd wrote: The ARM architected system counter has at least 56 usable bits. Add support for counters with more than 32 bits to the generic sched_clock implementation so we can increase the time between wakeups due to dealing with

Re: [PATCH] MAINTAINERS: add the generic sched_clock under timekeeping

2013-07-17 Thread Baruch Siach
Hi John, On Wed, Jul 17, 2013 at 11:57:32AM -0700, John Stultz wrote: > On 07/17/2013 03:05 AM, Baruch Siach wrote: > >Signed-off-by: Baruch Siach > >--- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > >diff --git a/MAINTAINERS b/MAINT

[PATCH] time: sched_clock: fix integer overflow

2013-07-17 Thread Baruch Siach
ussell King Signed-off-by: Baruch Siach --- kernel/time/sched_clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c index a326f27..0b479a6 100644 --- a/kernel/time/sched_clock.c +++ b/kernel/time/sched_clock.c @@ -121,7

[PATCH] MAINTAINERS: add the generic sched_clock under timekeeping

2013-07-17 Thread Baruch Siach
Signed-off-by: Baruch Siach --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bf61e04..bd9616a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7129,6 +7129,7 @@ M:Thomas Gleixner T: git git://git.kernel.org/pub/scm/linux/kernel/git

[PATCH] MAINTAINERS: add the generic sched_clock under timekeeping

2013-07-17 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bf61e04..bd9616a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7129,6 +7129,7 @@ M:Thomas Gleixner t...@linutronix.de T: git git

[PATCH] time: sched_clock: fix integer overflow

2013-07-17 Thread Baruch Siach
jcmvb...@gmail.com Acked-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Baruch Siach bar...@tkos.co.il --- kernel/time/sched_clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/sched_clock.c b/kernel/time/sched_clock.c index a326f27..0b479a6 100644

Re: [PATCH] MAINTAINERS: add the generic sched_clock under timekeeping

2013-07-17 Thread Baruch Siach
Hi John, On Wed, Jul 17, 2013 at 11:57:32AM -0700, John Stultz wrote: On 07/17/2013 03:05 AM, Baruch Siach wrote: Signed-off-by: Baruch Siach bar...@tkos.co.il --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bf61e04..bd9616a 100644

Re: [PATCH] clocksource/cadence_ttc: Reuse clocksource as sched_clock

2013-07-03 Thread Baruch Siach
Hi Soren, On Wed, Jul 03, 2013 at 02:50:16PM -0700, Soren Brinkmann wrote: > Reuse the TTC clocksource timer as sched clock, too. Since only a single > sched clock is supported in Linux, this feature optional and can be > selected through Kconfig. > > Signed-off-by: Soren Brinkmann > --- [...]

Re: [PATCH] clocksource/cadence_ttc: Reuse clocksource as sched_clock

2013-07-03 Thread Baruch Siach
Hi Soren, On Wed, Jul 03, 2013 at 02:50:16PM -0700, Soren Brinkmann wrote: Reuse the TTC clocksource timer as sched clock, too. Since only a single sched clock is supported in Linux, this feature optional and can be selected through Kconfig. Signed-off-by: Soren Brinkmann

Re: [PATCH 2/8] clocksource: sun4i: Add clocksource and sched clock drivers

2013-06-27 Thread Baruch Siach
Hi Maxime, On Thu, Jun 27, 2013 at 07:21:44PM +0200, Maxime Ripard wrote: > On Thu, Jun 27, 2013 at 12:46:49PM +0300, Baruch Siach wrote: > > On Thu, Jun 27, 2013 at 11:35:58AM +0200, Maxime Ripard wrote: > > > On Thu, Jun 27, 2013 at 09:02:34AM +0300, Baruch Siach wrote: >

Re: [PATCH 2/8] clocksource: sun4i: Add clocksource and sched clock drivers

2013-06-27 Thread Baruch Siach
Hi Maxime, On Thu, Jun 27, 2013 at 11:35:58AM +0200, Maxime Ripard wrote: > On Thu, Jun 27, 2013 at 09:02:34AM +0300, Baruch Siach wrote: > > On Wed, Jun 26, 2013 at 11:16:55PM +0200, Maxime Ripard wrote: > > > +static u32 sun4i_timer_sched_read(void) > > > > You co

Re: [PATCH 2/8] clocksource: sun4i: Add clocksource and sched clock drivers

2013-06-27 Thread Baruch Siach
Hi Maxime, On Wed, Jun 26, 2013 at 11:16:55PM +0200, Maxime Ripard wrote: > The A10 and the A13 has a 64 bits free running counter that we can use > as a clocksource and a sched clock, that were both not used yet on these > platforms. > > Signed-off-by: Maxime Ripard > --- >

Re: [PATCH 2/8] clocksource: sun4i: Add clocksource and sched clock drivers

2013-06-27 Thread Baruch Siach
Hi Maxime, On Wed, Jun 26, 2013 at 11:16:55PM +0200, Maxime Ripard wrote: The A10 and the A13 has a 64 bits free running counter that we can use as a clocksource and a sched clock, that were both not used yet on these platforms. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com

Re: [PATCH 2/8] clocksource: sun4i: Add clocksource and sched clock drivers

2013-06-27 Thread Baruch Siach
Hi Maxime, On Thu, Jun 27, 2013 at 11:35:58AM +0200, Maxime Ripard wrote: On Thu, Jun 27, 2013 at 09:02:34AM +0300, Baruch Siach wrote: On Wed, Jun 26, 2013 at 11:16:55PM +0200, Maxime Ripard wrote: +static u32 sun4i_timer_sched_read(void) You commit message mentions 64 bits free

Re: [PATCH 2/8] clocksource: sun4i: Add clocksource and sched clock drivers

2013-06-27 Thread Baruch Siach
Hi Maxime, On Thu, Jun 27, 2013 at 07:21:44PM +0200, Maxime Ripard wrote: On Thu, Jun 27, 2013 at 12:46:49PM +0300, Baruch Siach wrote: On Thu, Jun 27, 2013 at 11:35:58AM +0200, Maxime Ripard wrote: On Thu, Jun 27, 2013 at 09:02:34AM +0300, Baruch Siach wrote: On Wed, Jun 26, 2013 at 11

Re: [RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-06-20 Thread Baruch Siach
Hi Pavel, On Thu, Jun 20, 2013 at 04:44:33PM +0200, Pavel Machek wrote: > > > >@@ -73,6 +77,9 @@ static void add_clocksource(struct device_node > > > > *source_timer) > > > > } > > > > static void __iomem *sched_io_base; > > > >+#ifndef CONFIG_HAVE_SETUP_SCHED_CLOCK > > > >+static u64

Re: [RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-06-20 Thread Baruch Siach
Hi Pavel, On Thu, Jun 20, 2013 at 04:44:33PM +0200, Pavel Machek wrote: @@ -73,6 +77,9 @@ static void add_clocksource(struct device_node *source_timer) } static void __iomem *sched_io_base; +#ifndef CONFIG_HAVE_SETUP_SCHED_CLOCK +static u64 sched_clock_mult __read_mostly;

Re: [PATCHv2 0/6] Make ARM's sched_clock generic + 64 bit friendly

2013-06-17 Thread Baruch Siach
Hi John, On Mon, Jun 17, 2013 at 09:23:00AM -0700, John Stultz wrote: > On 06/16/2013 02:45 AM, Baruch Siach wrote: > >On Tue, Jun 04, 2013 at 10:53:04AM -0700, John Stultz wrote: > >>On 06/04/2013 09:09 AM, Will Deacon wrote: > >>>On Tue, Jun 04, 2013 at 01:19

Re: [PATCHv2 0/6] Make ARM's sched_clock generic + 64 bit friendly

2013-06-17 Thread Baruch Siach
Hi John, On Mon, Jun 17, 2013 at 09:23:00AM -0700, John Stultz wrote: On 06/16/2013 02:45 AM, Baruch Siach wrote: On Tue, Jun 04, 2013 at 10:53:04AM -0700, John Stultz wrote: On 06/04/2013 09:09 AM, Will Deacon wrote: On Tue, Jun 04, 2013 at 01:19:48AM +0100, John Stultz wrote: On 06/01/2013

Re: [PATCHv2 0/6] Make ARM's sched_clock generic + 64 bit friendly

2013-06-16 Thread Baruch Siach
Hi John, On Tue, Jun 04, 2013 at 10:53:04AM -0700, John Stultz wrote: > On 06/04/2013 09:09 AM, Will Deacon wrote: > >On Tue, Jun 04, 2013 at 01:19:48AM +0100, John Stultz wrote: > >>On 06/01/2013 11:39 PM, Stephen Boyd wrote: > >>>This is mostly a resend of a patch series I sent a little over a

Re: [PATCHv2 0/6] Make ARM's sched_clock generic + 64 bit friendly

2013-06-16 Thread Baruch Siach
Hi John, On Tue, Jun 04, 2013 at 10:53:04AM -0700, John Stultz wrote: On 06/04/2013 09:09 AM, Will Deacon wrote: On Tue, Jun 04, 2013 at 01:19:48AM +0100, John Stultz wrote: On 06/01/2013 11:39 PM, Stephen Boyd wrote: This is mostly a resend of a patch series I sent a little over a month

Re: [PATCH 3/3] clocksource: dw_apb_timer_of: use clocksource_of_init

2013-06-03 Thread Baruch Siach
Hi Heiko, On Mon, Jun 03, 2013 at 09:59:55PM +0200, Heiko Stübner wrote: > dw_apb_timer_init used to search the devicetree for matching timer > devices, making calls to it from board files necessary. > > Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE. > With this change the

Re: [PATCHv2 0/6] Make ARM's sched_clock generic + 64 bit friendly

2013-06-03 Thread Baruch Siach
he 64 bit > patches. The last three patches add 64 bit support and move the architected > timers on ARM64 and ARM to use it. You can have my Build-tested-by: Baruch Siach for xtensa target, with the dw_apb_timer driver (no real hardware yet). Thanks for pushing this series. baruch &g

Re: [PATCHv2 3/6] sched_clock: Make ARM's sched_clock generic for all architectures

2013-06-03 Thread Baruch Siach
Hi Stephen, On Sat, Jun 01, 2013 at 11:39:40PM -0700, Stephen Boyd wrote: > Nothing about the sched_clock implementation in the ARM port is > specific to the architecture. Generalize the code so that other > architectures can use it by selecting GENERIC_SCHED_CLOCK. > > Signed-off-by: Stephen

Re: [PATCH 3/3] clocksource: dw_apb_timer_of: use clocksource_of_init

2013-06-03 Thread Baruch Siach
Hi Heiko, On Mon, Jun 03, 2013 at 09:59:55PM +0200, Heiko Stübner wrote: dw_apb_timer_init used to search the devicetree for matching timer devices, making calls to it from board files necessary. Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE. With this change the function

Re: [PATCHv2 3/6] sched_clock: Make ARM's sched_clock generic for all architectures

2013-06-03 Thread Baruch Siach
Hi Stephen, On Sat, Jun 01, 2013 at 11:39:40PM -0700, Stephen Boyd wrote: Nothing about the sched_clock implementation in the ARM port is specific to the architecture. Generalize the code so that other architectures can use it by selecting GENERIC_SCHED_CLOCK. Signed-off-by: Stephen Boyd

Re: [PATCHv2 0/6] Make ARM's sched_clock generic + 64 bit friendly

2013-06-03 Thread Baruch Siach
patches. The last three patches add 64 bit support and move the architected timers on ARM64 and ARM to use it. You can have my Build-tested-by: Baruch Siach bar...@tkos.co.il for xtensa target, with the dw_apb_timer driver (no real hardware yet). Thanks for pushing this series. baruch Stephen

Re: [PATCH 02/10] clocksource: dw_apb_timer_of: add clock-handling

2013-06-02 Thread Baruch Siach
Hi Heiko, On Mon, Jun 03, 2013 at 12:56:37AM +0200, Heiko Stübner wrote: > Add the possibility to get the clock-frequency from a timer clock instead > of specifying it as dt property. Additionally also add the possibility > to also define a controlling periphal clock for the timer block. > > The

Re: [PATCH 02/10] clocksource: dw_apb_timer_of: add clock-handling

2013-06-02 Thread Baruch Siach
Hi Heiko, On Mon, Jun 03, 2013 at 12:56:37AM +0200, Heiko Stübner wrote: Add the possibility to get the clock-frequency from a timer clock instead of specifying it as dt property. Additionally also add the possibility to also define a controlling periphal clock for the timer block. The

Re: [RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-05-30 Thread Baruch Siach
Hi John, On Thu, May 30, 2013 at 09:11:17AM -0700, John Stultz wrote: > On 05/29/2013 10:32 PM, Baruch Siach wrote: > >On Tue, May 28, 2013 at 01:24:17PM -0700, John Stultz wrote: > >>On 05/26/2013 05:12 AM, Baruch Siach wrote: > >>> static const struct of_device

Re: [RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-05-30 Thread Baruch Siach
Hi John, On Thu, May 30, 2013 at 09:11:17AM -0700, John Stultz wrote: On 05/29/2013 10:32 PM, Baruch Siach wrote: On Tue, May 28, 2013 at 01:24:17PM -0700, John Stultz wrote: On 05/26/2013 05:12 AM, Baruch Siach wrote: static const struct of_device_id osctimer_ids[] __initconst

Re: [RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-05-29 Thread Baruch Siach
Hi John, On Tue, May 28, 2013 at 01:24:17PM -0700, John Stultz wrote: > On 05/26/2013 05:12 AM, Baruch Siach wrote: > >ARM is the only architecture providing sched_clock.h and setup_sched_clock(). > >Implement sched_clock() for use by other architectures. > > > >Cc

Re: [RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-05-29 Thread Baruch Siach
Hi John, On Tue, May 28, 2013 at 01:24:17PM -0700, John Stultz wrote: On 05/26/2013 05:12 AM, Baruch Siach wrote: ARM is the only architecture providing sched_clock.h and setup_sched_clock(). Implement sched_clock() for use by other architectures. Cc: Ingo Molnar mi...@redhat.com Cc: Peter

Re: [PATCH] clocksource: dw_apb: fix error check

2013-05-27 Thread Baruch Siach
Hi Daniel, On Mon, May 27, 2013 at 03:14:23PM +0200, Daniel Lezcano wrote: > On 05/27/2013 01:51 PM, Baruch Siach wrote: > > irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ. > > This breaks on platforms that have NO_IRQ != 0. > > > > Cc:

[PATCH] clocksource: dw_apb: fix error check

2013-05-27 Thread Baruch Siach
irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ. This breaks on platforms that have NO_IRQ != 0. Cc: Signed-off-by: Baruch Siach --- drivers/clocksource/dw_apb_timer_of.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource

[PATCH] clocksource: dw_apb: fix error check

2013-05-27 Thread Baruch Siach
irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ. This breaks on platforms that have NO_IRQ != 0. Cc: sta...@vger.kernel.org Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/clocksource/dw_apb_timer_of.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] clocksource: dw_apb: fix error check

2013-05-27 Thread Baruch Siach
Hi Daniel, On Mon, May 27, 2013 at 03:14:23PM +0200, Daniel Lezcano wrote: On 05/27/2013 01:51 PM, Baruch Siach wrote: irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ. This breaks on platforms that have NO_IRQ != 0. Cc: sta...@vger.kernel.org Signed-off

[PATCH 1/2] clocksource: dw_apb: remove unused header

2013-05-26 Thread Baruch Siach
The time.h header seems not to be used by current code. Removing this include allows the driver to build on other architecture that do not have this header. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: John Stultz Cc: Thomas Gleixner Cc: Jamie Iles Cc: Dinh Nguyen Signed-off-by: Baruch Siach

[RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-05-26 Thread Baruch Siach
ARM is the only architecture providing sched_clock.h and setup_sched_clock(). Implement sched_clock() for use by other architectures. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: John Stultz Cc: Thomas Gleixner Cc: Jamie Iles Cc: Dinh Nguyen Signed-off-by: Baruch Siach --- arch/arm/Kconfig

[RFC PATCH 2/2] clocksource: dw_apb: allow build for architectures other than arm

2013-05-26 Thread Baruch Siach
Iles ja...@jamieiles.com Cc: Dinh Nguyen dingu...@altera.com Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/Kconfig |1 + drivers/clocksource/Kconfig |3 +++ drivers/clocksource/dw_apb_timer_of.c | 18 ++ 3 files changed, 22

[PATCH 1/2] clocksource: dw_apb: remove unused header

2013-05-26 Thread Baruch Siach
...@linutronix.de Cc: Jamie Iles ja...@jamieiles.com Cc: Dinh Nguyen dingu...@altera.com Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/clocksource/dw_apb_timer_of.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource

Re: [BUG] irq_dispose_mapping after irq request failure

2013-02-10 Thread Baruch Siach
Hi Michael, On Mon, Feb 11, 2013 at 05:19:49PM +1100, Michael Ellerman wrote: > On Mon, Feb 11, 2013 at 07:31:00AM +0200, Baruch Siach wrote: [...] > > mpc85xx_pci_err_probe: Unable to requiest irq 16 for MPC85xx PCI err > While you're there, can you fix the typo :) The

[BUG] irq_dispose_mapping after irq request failure

2013-02-10 Thread Baruch Siach
Hi lkml, The drivers/edac/mpc85xx_edac.c driver contains the following (abbreviated) code snippet it its .probe: res = devm_request_irq(>dev, pdata->irq, mpc85xx_pci_isr, IRQF_DISABLED, "[EDAC] PCI

[BUG] irq_dispose_mapping after irq request failure

2013-02-10 Thread Baruch Siach
Hi lkml, The drivers/edac/mpc85xx_edac.c driver contains the following (abbreviated) code snippet it its .probe: res = devm_request_irq(op-dev, pdata-irq, mpc85xx_pci_isr, IRQF_DISABLED, [EDAC] PCI err,

Re: [BUG] irq_dispose_mapping after irq request failure

2013-02-10 Thread Baruch Siach
Hi Michael, On Mon, Feb 11, 2013 at 05:19:49PM +1100, Michael Ellerman wrote: On Mon, Feb 11, 2013 at 07:31:00AM +0200, Baruch Siach wrote: [...] mpc85xx_pci_err_probe: Unable to requiest irq 16 for MPC85xx PCI err While you're there, can you fix the typo :) The patch fixing it is already

Re: [PATCH 2/2] pinctrl: mvebu: make pdma clock on dove mandatory

2012-11-26 Thread Baruch Siach
Hi Sebastian, On Mon, Nov 26, 2012 at 10:20:34AM +0100, Sebastian Hesselbarth wrote: [...] > diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c > b/drivers/pinctrl/mvebu/pinctrl-dove.c > index 40c9c3e..90f257d 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-dove.c > +++

Re: [PATCH 2/2] pinctrl: mvebu: make pdma clock on dove mandatory

2012-11-26 Thread Baruch Siach
Hi Sebastian, On Mon, Nov 26, 2012 at 10:20:34AM +0100, Sebastian Hesselbarth wrote: [...] diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c index 40c9c3e..90f257d 100644 --- a/drivers/pinctrl/mvebu/pinctrl-dove.c +++

Re: [RFC][PATCH] printk: add boot_quiet param to support deferred printk while booting

2012-11-22 Thread Baruch Siach
Hi Barry, On Fri, Nov 23, 2012 at 10:50:22AM +0800, Barry Song wrote: [...] > diff --git a/kernel/printk.c b/kernel/printk.c > index 2d607f4..0b88d6bf 100644 > --- a/kernel/printk.c > +++ b/kernel/printk.c > @@ -250,6 +250,9 @@ static u32 clear_idx; > #define LOG_ALIGN __alignof__(struct log)

Re: [RFC][PATCH] printk: add boot_quiet param to support deferred printk while booting

2012-11-22 Thread Baruch Siach
Hi Barry, On Fri, Nov 23, 2012 at 10:50:22AM +0800, Barry Song wrote: [...] diff --git a/kernel/printk.c b/kernel/printk.c index 2d607f4..0b88d6bf 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -250,6 +250,9 @@ static u32 clear_idx; #define LOG_ALIGN __alignof__(struct log)

Re: [PATCH v2] video: imxfb: Do not crash on reboot

2012-10-08 Thread Baruch Siach
Hi Fabio, On Mon, Oct 08, 2012 at 07:23:58PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Issuing a "reboot" command after the LCD times out causes the following > warnings: [snip] > @@ -513,47 +514,53 @@ static void imxfb_exit_backlight(struct imxfb_info > *fbi) > > static void

Re: [PATCH v2] video: imxfb: Do not crash on reboot

2012-10-08 Thread Baruch Siach
Hi Fabio, On Mon, Oct 08, 2012 at 07:23:58PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Issuing a reboot command after the LCD times out causes the following warnings: [snip] @@ -513,47 +514,53 @@ static void imxfb_exit_backlight(struct imxfb_info *fbi)

<    1   2   3   4   5