On 19/03/14 02:48, Alexandre Courbot wrote:
On Tue, Mar 18, 2014 at 7:41 PM, Ben Dooks wrote:
Some of the gpiod_ calls take a pointer to a gpio_desc as their
argument but only check to see if it is NULL to validate the
input.
Calls such as devm_gpiod_get() return an error-pointer if they
fail
On 19/03/14 02:48, Alexandre Courbot wrote:
On Tue, Mar 18, 2014 at 7:41 PM, Ben Dooks ben.do...@codethink.co.uk wrote:
Some of the gpiod_ calls take a pointer to a gpio_desc as their
argument but only check to see if it is NULL to validate the
input.
Calls such as devm_gpiod_get() return
(...);
gpiod_direction_output(gpio, 0);
The sequence produces an OOPS like:
Unable to handle kernel paging request at virtual address fffe
Change all calls that check for !desc to use IS_ERR_OR_NULL() to
avoid these issues.
Signed-off-by: Ben Dooks
---
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc
(...);
gpiod_direction_output(gpio, 0);
The sequence produces an OOPS like:
Unable to handle kernel paging request at virtual address fffe
Change all calls that check for !desc to use IS_ERR_OR_NULL() to
avoid these issues.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
Cc: Linus Walleij
On 07/03/14 16:50, Sergei Shtylyov wrote:
Hello.
On 03/07/2014 04:01 PM, Ben Dooks wrote:
Add device-tree for vin1 (composite video in) on the
lager board.
Signed-off-by: Ben Dooks
This patch should have been preceded by the VIN driver patch and
bindings description, don't you think
On 07/03/14 16:45, Sergei Shtylyov wrote:
Hello.
On 03/07/2014 04:01 PM, Ben Dooks wrote:
Add nodes for the four video input channels on the R8A7790.
Signed-off-by: Ben Dooks
This patch should have been preceded by the VIN driver patch and
bindings description, don't you think
Add nodes for the four video input channels on the R8A7790.
Signed-off-by: Ben Dooks
---
arch/arm/boot/dts/r8a7790.dtsi | 32
1 file changed, 32 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index a1e7c39..4c3eafb
The platform data is a single word, so simply copy
it into the device's private data structure than
keeping a copy of the pointer.
This will make changing to device-tree binding
easier as it is one allocation instead of two.
Signed-off-by: Ben Dooks
---
drivers/media/platform/soc_camera
From: Phil Edworthy
Signed-off-by: Phil Edworthy
---
drivers/media/platform/soc_camera/rcar_vin.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
b/drivers/media/platform/soc_camera/rcar_vin.c
index 3b1c05a..702dc47 100644
---
This is a series of patches to get towards the point the renesas
rcar_vin driver can be bound via device-tree. Patches 1 and 2 add
the device tree nodes, patch 3 is one which has been in my tree
for a while and the last two modify the rcar_vin driver.
--
To unsubscribe from this list: send the
Add device-tree for vin1 (composite video in) on the
lager board.
Signed-off-by: Ben Dooks
---
arch/arm/boot/dts/r8a7790-lager.dts | 38 +
1 file changed, 38 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
b/arch/arm/boot/dts/r8a7790
Add support for devicetree probe for the rcar-vin
driver.
Signed-off-by: Ben Dooks
---
.../devicetree/bindings/media/rcar_vin.txt | 79 ++
drivers/media/platform/soc_camera/rcar_vin.c | 67 --
2 files changed, 140 insertions(+), 6 deletions
Add support for devicetree probe for the rcar-vin
driver.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
.../devicetree/bindings/media/rcar_vin.txt | 79 ++
drivers/media/platform/soc_camera/rcar_vin.c | 67 --
2 files changed, 140
Add device-tree for vin1 (composite video in) on the
lager board.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
arch/arm/boot/dts/r8a7790-lager.dts | 38 +
1 file changed, 38 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
b/arch/arm
This is a series of patches to get towards the point the renesas
rcar_vin driver can be bound via device-tree. Patches 1 and 2 add
the device tree nodes, patch 3 is one which has been in my tree
for a while and the last two modify the rcar_vin driver.
--
To unsubscribe from this list: send the
The platform data is a single word, so simply copy
it into the device's private data structure than
keeping a copy of the pointer.
This will make changing to device-tree binding
easier as it is one allocation instead of two.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/media
Add nodes for the four video input channels on the R8A7790.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
arch/arm/boot/dts/r8a7790.dtsi | 32
1 file changed, 32 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
From: Phil Edworthy phil.edwor...@renesas.com
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
drivers/media/platform/soc_camera/rcar_vin.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
On 07/03/14 16:45, Sergei Shtylyov wrote:
Hello.
On 03/07/2014 04:01 PM, Ben Dooks wrote:
Add nodes for the four video input channels on the R8A7790.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
This patch should have been preceded by the VIN driver patch and
bindings
On 07/03/14 16:50, Sergei Shtylyov wrote:
Hello.
On 03/07/2014 04:01 PM, Ben Dooks wrote:
Add device-tree for vin1 (composite video in) on the
lager board.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
This patch should have been preceded by the VIN driver patch and
bindings
On 05/03/14 20:33, Stephen Boyd wrote:
+Lorenzo
On 02/24/14 03:22, Jürg Billeter wrote:
Skip 'disabled' cpu nodes when building the cpu logical map. This avoids
booting cpus that have been disabled in the device tree.
Signed-off-by: Jürg Billeter
Reviewed-by: Ben Dooks
---
arch/arm/kernel
On 05/03/14 20:33, Stephen Boyd wrote:
+Lorenzo
On 02/24/14 03:22, Jürg Billeter wrote:
Skip 'disabled' cpu nodes when building the cpu logical map. This avoids
booting cpus that have been disabled in the device tree.
Signed-off-by: Jürg Billeter j...@bitron.ch
Reviewed-by: Ben Dooks ben.do
is supposed to be device-tree. If we keep
doing this then we will not get any of the current issues fixed.
Will it impact the devicetree bindings on rcar?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
this when
our primary boot method is supposed to be device-tree. If we keep
doing this then we will not get any of the current issues fixed.
Will it impact the devicetree bindings on rcar?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer
if none of the above
This fixes the issue:
net eth0: attached PHY 1 (IRQ -1) to driver Micrel KSZ8041RNLI
to the correct:
net eth0: attached PHY 1 (IRQ 416) to driver Micrel KSZ8041RNLI
Signed-off-by: Ben Dooks
---
Since v1:
- Updated phy->irq setting code
- Deal with issue if mdi
On 18/02/14 09:30, Grant Likely wrote:
On Mon, 17 Feb 2014 16:29:40 +, Ben Dooks wrote:
The of_mdiobus_register_phy() is not setting phy->irq this causing
some drivers to incorrectly assume that the PHY does not have an
IRQ associated with it or install an interrupt handler for the
On 18/02/14 09:30, Grant Likely wrote:
On Mon, 17 Feb 2014 16:29:40 +, Ben Dooks ben.do...@codethink.co.uk wrote:
The of_mdiobus_register_phy() is not setting phy-irq this causing
some drivers to incorrectly assume that the PHY does not have an
IRQ associated with it or install an interrupt
the issue:
net eth0: attached PHY 1 (IRQ -1) to driver Micrel KSZ8041RNLI
to the correct:
net eth0: attached PHY 1 (IRQ 416) to driver Micrel KSZ8041RNLI
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
Since v1:
- Updated phy-irq setting code
- Deal with issue if mdio-irq
On 17/02/14 17:48, Florian Fainelli wrote:
2014-02-17 9:42 GMT-08:00 Ben Dooks :
On 17/02/14 17:26, Florian Fainelli wrote:
Hi Ben,
2014-02-17 8:29 GMT-08:00 Ben Dooks :
The of_mdiobus_register_phy() is not setting phy->irq this causing
some drivers to incorrectly assume that the PHY d
On 17/02/14 17:26, Florian Fainelli wrote:
Hi Ben,
2014-02-17 8:29 GMT-08:00 Ben Dooks :
The of_mdiobus_register_phy() is not setting phy->irq this causing
some drivers to incorrectly assume that the PHY does not have an
IRQ associated with it or install an interrupt handler for the
On 17/02/14 17:26, Florian Fainelli wrote:
Hi Ben,
2014-02-17 8:29 GMT-08:00 Ben Dooks :
The of_mdiobus_register_phy() is not setting phy->irq this causing
some drivers to incorrectly assume that the PHY does not have an
IRQ associated with it or install an interrupt handler for the
o->irq is not NULL is easier to read.
This fixes the issue:
net eth0: attached PHY 1 (IRQ -1) to driver Micrel KSZ8041RNLI
to the correct:
net eth0: attached PHY 1 (IRQ 416) to driver Micrel KSZ8041RNLI
Signed-off-by: Ben Dooks
---
drivers/of/of_mdio.c | 12 ++--
1 file c
is not NULL is easier to read.
This fixes the issue:
net eth0: attached PHY 1 (IRQ -1) to driver Micrel KSZ8041RNLI
to the correct:
net eth0: attached PHY 1 (IRQ 416) to driver Micrel KSZ8041RNLI
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/of/of_mdio.c | 12 ++--
1
On 17/02/14 17:26, Florian Fainelli wrote:
Hi Ben,
2014-02-17 8:29 GMT-08:00 Ben Dooks ben.do...@codethink.co.uk:
The of_mdiobus_register_phy() is not setting phy-irq this causing
some drivers to incorrectly assume that the PHY does not have an
IRQ associated with it or install an interrupt
On 17/02/14 17:26, Florian Fainelli wrote:
Hi Ben,
2014-02-17 8:29 GMT-08:00 Ben Dooks ben.do...@codethink.co.uk:
The of_mdiobus_register_phy() is not setting phy-irq this causing
some drivers to incorrectly assume that the PHY does not have an
IRQ associated with it or install an interrupt
On 17/02/14 17:48, Florian Fainelli wrote:
2014-02-17 9:42 GMT-08:00 Ben Dooks ben.do...@codethink.co.uk:
On 17/02/14 17:26, Florian Fainelli wrote:
Hi Ben,
2014-02-17 8:29 GMT-08:00 Ben Dooks ben.do...@codethink.co.uk:
The of_mdiobus_register_phy() is not setting phy-irq this causing
some
On 14/02/14 05:40, Magnus Damm wrote:
On Thu, Feb 13, 2014 at 9:34 PM, Ben Dooks wrote:
On 13/02/14 03:03, Magnus Damm wrote:
PCI: rcar: Recent driver patches from Ben Dooks and me
[PATCH 01/08] PCI: rcar: check platform_get_irq() return code
[PATCH v2 02/08] PCI: rcar: add error interrupt
On 14/02/14 05:40, Magnus Damm wrote:
On Thu, Feb 13, 2014 at 9:34 PM, Ben Dooks ben.do...@codethink.co.uk wrote:
On 13/02/14 03:03, Magnus Damm wrote:
PCI: rcar: Recent driver patches from Ben Dooks and me
[PATCH 01/08] PCI: rcar: check platform_get_irq() return code
[PATCH v2 02/08] PCI
On 13/02/14 03:03, Magnus Damm wrote:
PCI: rcar: Recent driver patches from Ben Dooks and me
[PATCH 01/08] PCI: rcar: check platform_get_irq() return code
[PATCH v2 02/08] PCI: rcar: add error interrupt handling
[PATCH 03/08] PCI: rcar: fix bridge logic configuration accesses
[PATCH v2 04/08
On 13/02/14 03:03, Magnus Damm wrote:
PCI: rcar: Recent driver patches from Ben Dooks and me
[PATCH 01/08] PCI: rcar: check platform_get_irq() return code
[PATCH v2 02/08] PCI: rcar: add error interrupt handling
[PATCH 03/08] PCI: rcar: fix bridge logic configuration accesses
[PATCH v2 04/08
Two ideas are
ARM_LE(tst r2, #L_PTE_VALID)
ARM_BE(tst r3, #L_PTE_VALID)
or change r2, r3 pair to say rlow, rhi and
#ifdef CONFIG_CPU_ENDIAN_BE8
#define rlow r3
#define rhi r2
#else
#define rlow r2
#define rhi r3
#endif
--
Ben Dooks http://www.codethink.co.uk/
Senio
rlow r2
#define rhi r3
#endif
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
a test with please?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kerne
On 10/02/14 15:21, Dave Martin wrote:
On Mon, Feb 10, 2014 at 02:54:22PM +, Ben Dooks wrote:
On 10/02/14 14:16, Dave Martin wrote:
On Fri, Feb 07, 2014 at 05:19:15PM +0100, Fabrice GASNIER wrote:
This patch adds imprecise abort enable/disable macros.
It also enables imprecise aborts when
as imprecise aborts. However it was /annoying/ and therefore
easier just to turn it off and rely on the hardware returning 0x
for any configuration area it couldn't get to.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing
"orr" and "bic" instruction might change N
and Z bits, depending on the result.
So shouldn't "cc" be placed here ?
I also see that it is used in local_fiq_enable/disable macros just
above, that are similar:
No, only if they have the S flag set on the instruction (OR
on the instruction (ORRS,BICS)
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
as imprecise aborts. However it was /annoying/ and therefore
easier just to turn it off and rely on the hardware returning 0x
for any configuration area it couldn't get to.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing
On 10/02/14 15:21, Dave Martin wrote:
On Mon, Feb 10, 2014 at 02:54:22PM +, Ben Dooks wrote:
On 10/02/14 14:16, Dave Martin wrote:
On Fri, Feb 07, 2014 at 05:19:15PM +0100, Fabrice GASNIER wrote:
This patch adds imprecise abort enable/disable macros.
It also enables imprecise aborts when
a test with please?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On 05/02/14 09:40, Magnus Damm wrote:
On Wed, Feb 5, 2014 at 6:25 PM, Ben Dooks wrote:
On 05/02/14 09:00, Magnus Damm wrote:
Hi Ben,
[snip]
I think we should try to pick out the stuff that is ready to be merged
first. I think these patches may require a bit of time before people
start
the
less fdt support that is in the kernel then the more patches we end up
carrying out of tree. This is why we have been pushing patches out to
try and get the support in.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing
, is it possible to build a set with my of updates ready for next
merge window? I can update the set based on this if you like and try
and make the necessary changes to deal with the modifications from this
series.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer
ver rcar_pci_driver = {
.driver = {
.name = "pci-rcar-gen2",
+ .owner = THIS_MODULE,
+ .suppress_bind_attrs = true,
},
+ .probe = rcar_pci_probe,
};
--
Ben Dooks http://www.codethink.co.uk/
?
static struct platform_driver rcar_pci_driver = {
.driver = {
.name = pci-rcar-gen2,
+ .owner = THIS_MODULE,
+ .suppress_bind_attrs = true,
},
+ .probe = rcar_pci_probe,
};
--
Ben Dooks http
, is it possible to build a set with my of updates ready for next
merge window? I can update the set based on this if you like and try
and make the necessary changes to deal with the modifications from this
series.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer
the
less fdt support that is in the kernel then the more patches we end up
carrying out of tree. This is why we have been pushing patches out to
try and get the support in.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing
On 05/02/14 09:40, Magnus Damm wrote:
On Wed, Feb 5, 2014 at 6:25 PM, Ben Dooks ben.do...@codethink.co.uk wrote:
On 05/02/14 09:00, Magnus Damm wrote:
Hi Ben,
[snip]
I think we should try to pick out the stuff that is ready to be merged
first. I think these patches may require a bit
e
setting to the regulators so that if there is >2 states we can
select the state it starts in.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubsc
to the regulators so that if there is 2 states we can
select the state it starts in.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
rect way to support DMA on
> this arch or is there a better one?
I have a similar issue with Renesas R8A7790 where there is a bus bridge
that can only deal with transactions to one half of the available RAM.
--
Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/
Large Hadro
a similar issue with Renesas R8A7790 where there is a bus bridge
that can only deal with transactions to one half of the available RAM.
--
Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
--
To unsubscribe from this list
The of_get_gpio_regulator_config() will error out if there is no
"regulator_type" field in the fdt node hoewver it makes no attempt
at warning if the contents of said node is not known.
Signed-off-by: Ben Dooks
---
Cc: Liam Girdwood
Cc: Mark Brown
Cc: linux-kernel@vger.kernel.org
--
The of_get_gpio_regulator_config() will error out if there is no
regulator_type field in the fdt node hoewver it makes no attempt
at warning if the contents of said node is not known.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
Cc: Liam Girdwood lgirdw...@gmail.com
Cc: Mark Brown broo
. Thank you.
Shouldn't be posting them to public lists then.
--
Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
of this message; nor open or read any attachment. If you have
received this message in error, please notify us as soon as possible on the
following telephone number and destroy this message including any
attachments. Thank you.
Shouldn't be posting them to public lists then.
--
Ben Dooks, b
Add a number of files to the list of files covered by SHMOBILE
so any changes to these can be reported with get_maintailers.pl
for the current SHMOILE architectures.
Signed-off-by: Ben Dooks
---
v2:
- add defconfigs and r7 configurations
- fix path to dt-bindings
Cc: Joe Perches
Cc: Greg
Add a number of files to the list of files covered by SHMOBILE
so any changes to these can be reported with get_maintailers.pl
for the current SHMOILE architectures.
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
v2:
- add defconfigs and r7 configurations
- fix path to dt-bindings
Cc
place the driver
calls clk_enable().
Cc: "Rafael J. Wysocki"
Cc: Pavel Machek
Cc: Greg Kroah-Hartman
Cc: linux...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks
Reviewed-by: Ian Molton
---
drivers/base/power/clock_ops.c | 6
nt to fail to work:
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:883 __clk_enable+0x2c/0xa0()
Cc: "Rafael J. Wysocki"
Cc: Pavel Machek
Cc: Greg Kroah-Hartman
Cc: linux...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks
Rev
kernel.org
Signed-off-by: Ben Dooks
Reviewed-by: Ian Molton
---
drivers/base/power/clock_ops.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index cad7190..e870bbe 100644
--- a/drivers/
A re-send of the clk_ops.c fixes for handling clocks with the
current renesas development branch. I am not sure if these need
to be applied to any stable kernel branches.
>From v1:
- Fixed comments from Rafael Wysocki on checking of ret.
--
To unsubscribe from this list: send the line
On 13/01/14 19:55, Rafael J. Wysocki wrote:
On Saturday, January 11, 2014 01:05:39 PM Ben Dooks wrote:
@@ -262,8 +263,9 @@ int pm_clk_resume(struct device *dev)
list_for_each_entry(ce, >clock_list, node) {
if (ce->status < PCE_STA
On 13/01/14 19:55, Rafael J. Wysocki wrote:
On Saturday, January 11, 2014 01:05:39 PM Ben Dooks wrote:
@@ -262,8 +263,9 @@ int pm_clk_resume(struct device *dev)
list_for_each_entry(ce, psd-clock_list, node) {
if (ce-status PCE_STATUS_ERROR
A re-send of the clk_ops.c fixes for handling clocks with the
current renesas development branch. I am not sure if these need
to be applied to any stable kernel branches.
From v1:
- Fixed comments from Rafael Wysocki on checking of ret.
--
To unsubscribe from this list: send the line unsubscribe
...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
drivers/base/power/clock_ops.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power
place the driver
calls clk_enable().
Cc: Rafael J. Wysocki r...@rjwysocki.net
Cc: Pavel Machek pa...@ucw.cz
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: linux...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
drivers/base/power/clock_ops.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 9d8fde7..b9dd8fa 100644
kernel.org
Signed-off-by: Ben Dooks
Reviewed-by: Ian Molton
---
drivers/base/power/clock_ops.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 9bb95ab..b94b3ec 100644
--- a/drivers/
oduce
ARCH_SHMOBILE_MULTI") but this has only just recently been found due to
building device-tree only kernels.
Cc: Linux Kernel list
Cc: Linus SH list
Cc: Simon Horman
Cc: Magnus Damm
Cc: Greg Kroah-Hartman
Signed-off-by: Ben Dooks
---
drivers/Makefile| 1 +
drivers/sh/Makefile | 3 +++
2 files
place the driver
calls clk_enable().
Cc: "Rafael J. Wysocki"
Cc: Pavel Machek
Cc: Greg Kroah-Hartman
Cc: linux...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks
Reviewed-by: Ian Molton
---
drivers/base/power/clock_ops.c | 6
nt to fail to work:
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:883 __clk_enable+0x2c/0xa0()
Cc: "Rafael J. Wysocki"
Cc: Pavel Machek
Cc: Greg Kroah-Hartman
Cc: linux...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks
Rev
On 13/01/14 09:28, Geert Uytterhoeven wrote:
On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks wrote:
--- a/drivers/sh/Makefile
+++ b/drivers/sh/Makefile
@@ -3,7 +3,10 @@
#
obj-y := intc/
+ifeq ($(CONFIG_COMMON_CLK),n)
obj-$(CONFIG_HAVE_CLK) += clk/
+endif
+
This part breaks my
On 13/01/14 08:50, Geert Uytterhoeven wrote:
On Mon, Jan 13, 2014 at 7:28 AM, Ben Dooks wrote:
I've never noticed this on Lager, probably because Lager multiplatform
doesn't
make use of clock_ops.c as drivers/sh/pm_runtime.c (which you addressed in
another patch that I've also replied to). I'm
On 13/01/14 08:50, Geert Uytterhoeven wrote:
On Mon, Jan 13, 2014 at 7:28 AM, Ben Dooks ben.do...@codethink.co.uk wrote:
I've never noticed this on Lager, probably because Lager multiplatform
doesn't
make use of clock_ops.c as drivers/sh/pm_runtime.c (which you addressed in
another patch
On 13/01/14 09:28, Geert Uytterhoeven wrote:
On Fri, Jan 10, 2014 at 4:18 PM, Ben Dooks ben.do...@codethink.co.uk wrote:
--- a/drivers/sh/Makefile
+++ b/drivers/sh/Makefile
@@ -3,7 +3,10 @@
#
obj-y := intc/
+ifeq ($(CONFIG_COMMON_CLK),n)
obj-$(CONFIG_HAVE_CLK) += clk/
+endif
place the driver
calls clk_enable().
Cc: Rafael J. Wysocki r...@rjwysocki.net
Cc: Pavel Machek pa...@ucw.cz
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: linux...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
drivers/base/power/clock_ops.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 9d8fde7..b9dd8fa 100644
...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
Reviewed-by: Ian Molton ian.mol...@codethink.co.uk
---
drivers/base/power/clock_ops.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power
...@linuxfoundation.org
Signed-off-by: Ben Dooks ben.do...@codethink.co.uk
---
drivers/Makefile| 1 +
drivers/sh/Makefile | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/Makefile b/drivers/Makefile
index 8e3b8b0..abc4744 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -118,6 +118,7
On 12/01/14 22:01, Laurent Pinchart wrote:
Hi Ben,
On Sunday 12 January 2014 22:54:15 Laurent Pinchart wrote:
Hi Ben,
Thank you for the patch.
On Saturday 11 January 2014 13:06:29 Ben Dooks wrote:
If the kernel is built to support multi-arm configurmation with shmobile
support built
On 12/01/14 22:04, Laurent Pinchart wrote:
Hi Ben,
Thank you for the patch.
On Saturday 11 January 2014 13:05:38 Ben Dooks wrote:
The drivers/base/power/clock_ops.c file is causing warnings from
the clock driver (as shown below) due to failing to do a clk_prepare()
call before enabling
On 13/01/14 00:30, Simon Horman wrote:
On Fri, Jan 10, 2014 at 03:18:15PM +, Ben Dooks wrote:
If the kernel is built to support multi-arm configurmation with shmobile
support built in, then the drivers/sh is not built. This contains drivers
that are essential to devices support
On 13/01/14 00:30, Simon Horman wrote:
On Fri, Jan 10, 2014 at 03:18:15PM +, Ben Dooks wrote:
If the kernel is built to support multi-arm configurmation with shmobile
support built in, then the drivers/sh is not built. This contains drivers
that are essential to devices support
On 12/01/14 22:04, Laurent Pinchart wrote:
Hi Ben,
Thank you for the patch.
On Saturday 11 January 2014 13:05:38 Ben Dooks wrote:
The drivers/base/power/clock_ops.c file is causing warnings from
the clock driver (as shown below) due to failing to do a clk_prepare()
call before enabling
On 12/01/14 22:01, Laurent Pinchart wrote:
Hi Ben,
On Sunday 12 January 2014 22:54:15 Laurent Pinchart wrote:
Hi Ben,
Thank you for the patch.
On Saturday 11 January 2014 13:06:29 Ben Dooks wrote:
If the kernel is built to support multi-arm configurmation with shmobile
support built
On 10/01/14 17:09, Geert Uytterhoeven wrote:
On Fri, Jan 10, 2014 at 5:23 PM, Ben Dooks wrote:
On 10/01/14 15:59, Geert Uytterhoeven wrote:
On Fri, Jan 10, 2014 at 4:06 PM, Ben Dooks
wrote:
On the Renesas Lager board, this causes numerous warnings of the
following
and even worse the clock
On 10/01/14 15:59, Geert Uytterhoeven wrote:
Hi Ben,
On Fri, Jan 10, 2014 at 4:06 PM, Ben Dooks wrote:
On the Renesas Lager board, this causes numerous warnings of the following
and even worse the clock system will not enable clocks, causing drivers
that are in development to fail to work
Sorry, as a note the patch title /should/ have been:
power: fixup clock_ops clk prepare count usage
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
--
To unsubscribe from this list: send the line
oduce
ARCH_SHMOBILE_MULTI") but this has only just recently been found due to
building device-tree only kernels.
Cc: Linux Kernel list
Cc: Linus SH list
Cc: Simon Horman
Cc: Magnus Damm
Cc: Greg Kroah-Hartman
Signed-off-by: Ben Dooks
---
drivers/Makefile| 1 +
drivers/sh/Makefile | 3 +++
2 files
401 - 500 of 688 matches
Mail list logo
