Re: [lustre-devel] [PATCH 10/11] staging: lustre: move ldlm into ptlrpc

2018-06-07 Thread Ben Evans
On 6/7/18, 5:48 AM, "lustre-devel on behalf of NeilBrown" wrote: >On Thu, Jun 07 2018, James Simmons wrote: > >>> The ldlm code is built into the ptlrpc module, yet it lived in a >>> separate directory. This requires filename editing in the Makefile >>> and make it difficult to e.g. build

Re: [lustre-devel] [PATCH 10/11] staging: lustre: move ldlm into ptlrpc

2018-06-07 Thread Ben Evans
On 6/7/18, 5:48 AM, "lustre-devel on behalf of NeilBrown" wrote: >On Thu, Jun 07 2018, James Simmons wrote: > >>> The ldlm code is built into the ptlrpc module, yet it lived in a >>> separate directory. This requires filename editing in the Makefile >>> and make it difficult to e.g. build

Re:

2018-01-11 Thread Ben Evans
a separate array for the MDC stats, then print them conditionally. This would reduce all of the calls to these macros to counter increments. -Ben Evans On 1/11/18, 12:16 PM, "Fabian Huegel" <fabian_hue...@web.de> wrote: >We cleaned up a lot of checkpatch errors and warn

Re:

2018-01-11 Thread Ben Evans
a separate array for the MDC stats, then print them conditionally. This would reduce all of the calls to these macros to counter increments. -Ben Evans On 1/11/18, 12:16 PM, "Fabian Huegel" wrote: >We cleaned up a lot of checkpatch errors and warnings in obd_class.h, >but ther

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

2016-12-12 Thread Ben Evans
eneral guidelines for your reading pleasure: http://wiki.lustre.org/Lustre_Coding_Style_Guidelines The specific guidelines on organizing #includes are here: http://wiki.lustre.org/Lustre_Style_Guide_Includes -Ben Evans

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

2016-12-12 Thread Ben Evans
ding pleasure: http://wiki.lustre.org/Lustre_Coding_Style_Guidelines The specific guidelines on organizing #includes are here: http://wiki.lustre.org/Lustre_Style_Guide_Includes -Ben Evans

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

2016-12-12 Thread Ben Evans
This was done to conform to the Lustre Coding Guidelines. -Ben On 12/10/16, 1:14 PM, "Greg Kroah-Hartman" <gre...@linuxfoundation.org> wrote: >On Sat, Dec 10, 2016 at 01:05:59PM -0500, James Simmons wrote: >> From: Ben Evans <bev...@cray.com> >> &g

Re: [PATCH v2 3/5] staging: lustre: headers: sort headers affected by obdo move

2016-12-12 Thread Ben Evans
This was done to conform to the Lustre Coding Guidelines. -Ben On 12/10/16, 1:14 PM, "Greg Kroah-Hartman" wrote: >On Sat, Dec 10, 2016 at 01:05:59PM -0500, James Simmons wrote: >> From: Ben Evans >> >> It was found if you sort the headers alphabetically >