Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-21 Thread Ben Levinsky
Hi Mathieu -Original Message- From: Mathieu Poirier Date: Wednesday, March 17, 2021 at 9:27 AM To: Ben Levinsky Cc: "devicet...@vger.kernel.org" , "linux-remotep...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-ker...@lists.inf

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-19 Thread Ben Levinsky
-Original Message- From: Mathieu Poirier Date: Wednesday, March 17, 2021 at 9:27 AM To: Ben Levinsky Cc: "devicet...@vger.kernel.org" , "linux-remotep...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-ker...@lists.infradead.or

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-15 Thread Ben Levinsky
-Original Message- From: Mathieu Poirier Date: Monday, March 15, 2021 at 10:26 AM To: Ben Levinsky Cc: "devicet...@vger.kernel.org" , "linux-remotep...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-ker...@lists.infradead.or

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-15 Thread Ben Levinsky
-Original Message- From: Mathieu Poirier Date: Monday, March 15, 2021 at 10:37 AM To: Ben Levinsky Cc: "devicet...@vger.kernel.org" , "linux-remotep...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-ker...@lists.infradead.or

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-11 Thread Ben Levinsky
Hi Mathieu -Original Message- From: Mathieu Poirier Date: Tuesday, March 9, 2021 at 8:53 AM To: Ben Levinsky Cc: "devicet...@vger.kernel.org" , "linux-remotep...@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-ker...@lists.infradea

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-11 Thread Ben Levinsky
Hi Mathieu Thanks for the feedback. I responded inline -Original Message- From: Mathieu Poirier Date: Monday, March 8, 2021 at 11:00 AM To: Ben Levinsky Cc: "devicet...@vger.kernel.org" , "linux-remotep...@vger.kernel.org" , "linux-kernel@vger.kern

[PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-23 Thread Ben Levinsky
the R5 configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- drivers

[PATCH v26 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2021-02-23 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v26 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2021-02-23 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration and TCM Nodes for later use via request_node and release_node Signed-off-by: Ben Levinsky --- include/linux/firmware/xlnx-zynqmp.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/linux/firmware/xlnx

[PATCH v26 0/5] Add initial zynqmp R5 remoteproc driver

2021-02-23 Thread Ben Levinsky
. The ensuing prepare, unprepare and parse_fw logic are now much simpler. - similarly add 'size' field to struct sram_addr_data to simplify prepare, unprepare and parse_fw. Previous version: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=412083 Ben Levinsky (5): firmware

[PATCH v26 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2021-02-23 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- .../xilinx,zynqmp-r5

[PATCH v26 3/5] firmware: xilinx: Add RPU configuration APIs

2021-02-23 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
1 more for the pnode_id comment > -Original Message- > From: Ben Levinsky > Sent: Wednesday, February 17, 2021 11:12 AM > To: Mathieu Poirier > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.inf

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
Hi Mathieu, I worked on this further and had 1 more comment on the prepare/unprepare for TCM banks below > -Original Message- > From: Ben Levinsky > Sent: Wednesday, February 17, 2021 8:47 AM > To: Mathieu Poirier > Cc: devicet...@vger.kernel.org; linux-remotep...@

RE: [PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-02-17 Thread Ben Levinsky
Hi Mathieu, Please see my replies to your questions inline Again thanks for the continued review of this set Cheers Ben > -Original Message- > From: Mathieu Poirier > Sent: Tuesday, February 16, 2021 10:48 AM > To: Ben Levinsky > Cc: devicet...@vger.kernel.org

[PATCH v25 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-01-10 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v25: - reword

[PATCH v25 3/5] firmware: xilinx: Add RPU configuration APIs

2021-01-10 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v25 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2021-01-10 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v25 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2021-01-10 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v25: - grammar in device tree

[PATCH v25 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2021-01-10 Thread Ben Levinsky
://patchwork.kernel.org/project/linux-remoteproc/list/?series=393387 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs dt-bindings: remoteproc: Add documentation

[PATCH v25 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2021-01-10 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration and TCM Nodes for later use via request_node and release_node Signed-off-by: Ben Levinsky --- v25: - update include/linux/firmware/xlnx-zynqmp.h style to match for enum --- include/linux/firmware/xlnx-zynqmp.h | 23 +++ 1

RE: [PATCH v24 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-12-07 Thread Ben Levinsky
Hi Mathieu, Thanks for the clarification. IIRC he is on the device tree list so should see this. Ill add him on this particular thread to be safe. +Rob Best, Ben > -Original Message- > From: Mathieu Poirier > Sent: Monday, December 7, 2020 10:04 AM > To: Ben Levinsky &

[PATCH v24 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-11-30 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v24 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-11-30 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration and TCM Nodes for later use via request_node and release_node Signed-off-by: Ben Levinsky --- include/linux/firmware/xlnx-zynqmp.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/linux/firmware/xlnx

[PATCH v24 3/5] firmware: xilinx: Add RPU configuration APIs

2020-11-30 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v24 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-11-30 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v24: update for 'make

[PATCH v24 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-30 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- drivers

[PATCH v24 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-11-30 Thread Ben Levinsky
minor comments in v22 review Previous version: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=384227 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU

RE: [PATCH v23 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-30 Thread Ben Levinsky
Hi Mathieu, Thanks for the tip. I will fix up the DT Schema bot output this week then Best Ben > -Original Message- > From: Mathieu Poirier > Sent: Monday, November 30, 2020 7:32 AM > To: Ben Levinsky > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.or

RE: [PATCH v23 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-29 Thread Ben Levinsky
Ping for comments > -Original Message- > From: Ben Levinsky > Sent: Saturday, November 14, 2020 8:49 AM > To: mathieu.poir...@linaro.org > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infra

[PATCH v23 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-11-14 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v23 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-14 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- - Rework R5

[PATCH v23 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-11-14 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- - Update grammar

[PATCH v23 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-11-14 Thread Ben Levinsky
version: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=376801 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs dt-bindings: remoteproc: Add

[PATCH v23 3/5] firmware: xilinx: Add RPU configuration APIs

2020-11-14 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v23 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-11-14 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration and TCM Nodes for later use via request_node and release_node Signed-off-by: Ben Levinsky --- v23: add TCM Node IDs to be used in R5 Remoteproc driver --- include/linux/firmware/xlnx-zynqmp.h | 23 +++ 1 file changed, 23

RE: [PATCH v22 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-04 Thread Ben Levinsky
Hi Mathieu, > -Original Message- > From: Mathieu Poirier > Sent: Wednesday, November 4, 2020 1:30 PM > To: Ben Levinsky > Cc: michael.auch...@ni.com; Stefano Stabellini ; > devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kern

[PATCH v22 3/5] firmware: xilinx: Add RPU configuration APIs

2020-11-03 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v22 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-11-03 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- .../xilinx,zynqmp-r5

[PATCH v22 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-11-03 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- include/linux/firmware/xlnx-zynqmp.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h index 5968df82b991

[PATCH v22 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-11-03 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v22 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-03 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- - update

[PATCH v22 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-11-03 Thread Ben Levinsky
- update zynqmp_r5_rproc_kick to only use mailbox-related properties if the rproc pointer's corresponding of_node has mbox properties present, otherwise kick should and will do nothing Previous version https://patchwork.kernel.org/project/linux-remoteproc/list/?series=374399 Ben Levinsky (5

RE: [PATCH v21 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-02 Thread Ben Levinsky
Hi Michael, > -Original Message- > From: Michael Auchter > Sent: Monday, November 2, 2020 1:14 PM > To: Ben Levinsky > Cc: Stefano Stabellini ; mathieu.poir...@linaro.org; > devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kern

[PATCH v21 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-11-02 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- include/linux/firmware/xlnx-zynqmp.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h index 5968df82b991

[PATCH v21 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-11-02 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v21 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-02 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- Update Xilinx

[PATCH v21 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-11-02 Thread Ben Levinsky
unneeded lines in zynqmp_r5_remoteproc_remove Previous version https://patchwork.kernel.org/project/linux-remoteproc/list/?series=374399 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx

[PATCH v21 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-11-02 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- .../xilinx,zynqmp-r5

[PATCH v21 3/5] firmware: xilinx: Add RPU configuration APIs

2020-11-02 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v20 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-30 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- - remove

[PATCH v20 3/5] firmware: xilinx: Add RPU configuration APIs

2020-10-30 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v20 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-10-30 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- include/linux/firmware/xlnx-zynqmp.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h index 5968df82b991

[PATCH v20 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-30 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v20: - update typos and style

[PATCH v20 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-10-30 Thread Ben Levinsky
config Previous version https://patchwork.kernel.org/project/linux-remoteproc/list/?series=367125 Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration. firmware: xilinx: Add shutdown/wakeup APIs firmware: xilinx: Add RPU configuration APIs dt-bi

[PATCH v20 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-10-30 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v19 3/5] firmware: xilinx: Add RPU configuration APIs

2020-10-19 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v19 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-10-19 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v19 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-10-19 Thread Ben Levinsky
ed check for negative value on a u32 - fix off-by-one error in bound checking for parse_mem_regions strlen - fix checkpatch strict warnings for comments - update tcm_mem_alloc bound check for TCM bank addresses Ben Levinsky (5): firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU

[PATCH v19 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-19 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove

[PATCH v19 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-10-19 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v19 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-19 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-19 Thread Ben Levinsky
Hi Stefano, Thanks for the review. > -Original Message- > From: Stefano Stabellini > Sent: Monday, October 19, 2020 1:44 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; sunnylian...@gmail.com; > punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; m

RE: RE: RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-15 Thread Ben Levinsky
Hi All, > -Original Message- > From: Michael Auchter > Sent: Tuesday, October 6, 2020 3:21 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; Stefano Stabellini > ; Michal Simek ; > devicet...@vger.kernel.org; mathieu.poir...@linaro.org; linux- > remotep...@vger.

RE: [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-08 Thread Ben Levinsky
Hi Sorry there were some typos and errors in my response so I'll correct them below: > -Original Message- > From: Ben Levinsky > Sent: Thursday, October 8, 2020 7:21 AM > To: Linus Walleij ; Catalin Marinas > ; Stefano Stabellini ; Ed T. > Mooring > Cc: Ed T

RE: [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-08 Thread Ben Levinsky
Hi Linus, Thanks for the review Please see my comments inline > > Hi Ben, > > thanks for your patch! I noticed this today and pay some interest > because in the past I used with implementing the support for > TCM memory on ARM32. > > On Mon, Oct 5, 2020 at 6:06

RE: RE: RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-07 Thread Ben Levinsky
> -Original Message- > From: Michael Auchter > Sent: Tuesday, October 6, 2020 3:21 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; Stefano Stabellini > ; Michal Simek ; > devicet...@vger.kernel.org; mathieu.poir...@linaro.org; linux- > remotep...@vger.

RE: RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-06 Thread Ben Levinsky
> -Original Message- > From: Michael Auchter > Sent: Tuesday, October 6, 2020 2:32 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; sunnylian...@gmail.com; > punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; devicet...@vger.kernel.org; > mathieu.p

RE: [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-06 Thread Ben Levinsky
Hi Michael, Thanks for the review > -Original Message- > From: Michael Auchter > Sent: Monday, October 5, 2020 12:35 PM > To: Ben Levinsky > Cc: Ed T. Mooring ; sunnylian...@gmail.com; > punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; devic

[PATCH v18 3/5] firmware: xilinx: Add RPU configuration APIs

2020-10-05 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v18 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-10-05 Thread Ben Levinsky
in zynqmp_r5_release, and mbox_free_channel - remove device_unregister call in zynqmp_r5_release - remove kzalloc for pdata (what is now called z_rproc) - update conditional in loop to calls of zynqmp_r5_probe - update example remoteproc zynqmp r5 compat string, remove version number

[PATCH v18 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-10-05 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v18 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-10-05 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-05 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-05 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove

RE: [PATCH v17 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-02 Thread Ben Levinsky
so sorry about that... Otherwise I will fix up the memory management that is occurring in the driver as you describe. Again thank you! Ben > -Original Message- > From: Michael Auchter > Sent: Friday, October 2, 2020 11:59 AM > To: Ben Levinsky > Cc: sunnylian...@gmail.c

[PATCH v17 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-10-01 Thread Ben Levinsky
check for pdata->pnode_id == 0 is not needed v17: - remove compatible string from tcm bank nodes - fix style for bindings - add boolean type to lockstep mode in binding - add/update descriptions memory-region, meta-memory-regions, pnode-id, mbox* properties - update driver as per kernel-te

[PATCH v17 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-01 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky Reported

[PATCH v17 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-10-01 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v17 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-10-01 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v17 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-01 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v17 3/5] firmware: xilinx: Add RPU configuration APIs

2020-10-01 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

RE: [PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-30 Thread Ben Levinsky
Hi Rob, > -Original Message- > From: Rob Herring > Sent: Tuesday, September 29, 2020 11:36 AM > To: Ben Levinsky > Cc: Stefano Stabellini ; Michal Simek > ; michael.auch...@ni.com; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Moori

[PATCH v16 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-22 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove

[PATCH v16 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-22 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-22 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

[PATCH v16 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-09-22 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v16 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-09-22 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v16 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-09-22 Thread Ben Levinsky
zynqmp_r5_remoteproc::zynqmp_r5_probe if the index is valid - remove uneven dev_dbg/dev_err fn calls v15: - change lockstep mode device tree property from acting as boolean, to instead being used as, if it is present, then r5 is in lockstep mode. otherwise in split. - add safeguard for if 2 rpu rem

RE: [PATCH v15 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-22 Thread Ben Levinsky
Hi Michael, > -Original Message- > From: Michael Auchter > Sent: Monday, September 21, 2020 3:12 PM > To: Ben Levinsky > Cc: sunnylian...@gmail.com; punit1.agra...@toshiba.co.jp; Stefano Stabellini > ; Michal Simek ; > devicet...@vger.kernel.org; mathieu.poi

[PATCH v15 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP

2020-09-21 Thread Ben Levinsky
zynqmp_r5_remoteproc::zynqmp_r5_probe if the index is valid - remove uneven dev_dbg/dev_err fn calls v15: - change lockstep mode device tree property from acting as boolean, to instead being used as, if it is present, then r5 is in lockstep mode. otherwise in split. - add safeguard for if 2 rpu r

[PATCH v15 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

2020-09-21 Thread Ben Levinsky
Add ZynqMP firmware ioctl enums for RPU configuration. Signed-off-by: Ben Levinsky --- v3: - add xilinx-related platform mgmt fn's instead of wrapping around function pointer in xilinx eemi ops struct v4: - add default values for enums --- include/linux/firmware/xlnx-zynqmp.h | 19

[PATCH v15 3/5] firmware: xilinx: Add RPU configuration APIs

2020-09-21 Thread Ben Levinsky
This patch adds APIs to access to configure RPU and its processor-specific memory. That is query the run-time mode of RPU as either split or lockstep as well as API to set this mode. In addition add APIs to access configuration of the RPUs' tightly coupled memory (TCM). Signed-off-by: Ben

[PATCH v15 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-21 Thread Ben Levinsky
configuration, memory access and R5 lifecycle management. The interface to this manager is done in this driver via zynqmp_pm_* function calls. Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ed Mooring Signed-off-by: Jason Wu Signed-off-by: Ben Levinsky --- v2: - remove

[PATCH v15 2/5] firmware: xilinx: Add shutdown/wakeup APIs

2020-09-21 Thread Ben Levinsky
Add shutdown/wakeup a resource eemi operations to shutdown or bringup a resource. Note alignment of args matches convention of other fn's in this file. The reason being that the long fn name results in aligned args that otherwise go over 80 chars so shift right to avoid this Signed-off-by: Ben

[PATCH v15 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-09-21 Thread Ben Levinsky
Add binding for ZynqMP R5 OpenAMP. Represent the RPU domain resources in one device node. Each RPU processor is a subnode of the top RPU domain node. Signed-off-by: Jason Wu Signed-off-by: Wendy Liang Signed-off-by: Michal Simek Signed-off-by: Ben Levinsky --- v3: - update zynqmp_r5 yaml

RE: RE: RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-20 Thread Ben Levinsky
Hi All, > -Original Message- > From: Wendy Liang > Sent: Friday, September 18, 2020 6:53 PM > To: Michael Auchter > Cc: Ben Levinsky ; punit1.agra...@toshiba.co.jp; > devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kern

RE: RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-18 Thread Ben Levinsky
Hi Michael, Punit, > -Original Message- > From: Michael Auchter > Sent: Friday, September 18, 2020 9:07 AM > To: Ben Levinsky > Cc: devicet...@vger.kernel.org; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org

RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-17 Thread Ben Levinsky
> -Original Message- > From: Ben Levinsky > Sent: Thursday, September 17, 2020 3:19 PM > To: Michael Auchter > Cc: punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; devicet...@vger.kernel.org; > mathieu.poir...@linaro.org; Ed T. Moori

RE: [PATCH v14 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-09-17 Thread Ben Levinsky
Hi Michael, Thanks for the comments, > -Original Message- > From: Michael Auchter > Sent: Thursday, September 17, 2020 3:11 PM > To: Ben Levinsky > Cc: punit1.agra...@toshiba.co.jp; Stefano Stabellini ; > Michal Simek ; devicet...@vger.kernel.org; > mathieu.poi

  1   2   >